RFR: 8341162: Open source some of the AWT window test [v2]

[Jayathirth D V]

On Tue, 1 Oct 2024 22:08:46 GMT, Phil Race <prr at openjdk.org> wrote:

>> Jayathirth D V has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove not needed setVisible calls
>>  - Update based on review comments
>
> test/jdk/java/awt/Window/LocationByPlatform/TestLocationByPlatform.java line 28:
> 
>> 26:  * @bug 6318630
>> 27:  * @summary Test that location by platform works
>> 28:  * @library /open/test/jdk/java/awt/regtesthelpers
> 
> remove the leading "/open/test/jdk"

Updated.

> test/jdk/java/awt/Window/OwnedWindowShowTest/OwnedWindowShowTest.java line 38:
> 
>> 36: public class OwnedWindowShowTest {
>> 37:     public static void main(String args[])
>> 38:     {
> 
> I guess this should all be inside EventQueue.invokeAndWait() ?

Yes added.

> test/jdk/java/awt/Window/OwnedWindowShowTest/OwnedWindowShowTest.java line 46:
> 
>> 44:             try {
>> 45:                 window.setVisible(true);
>> 46:             } catch (NullPointerException npe) {
> 
> Is there any point to this ? Just let the NPE propagate. This just hides the origin.

We can just throw NPE. Updated it.

> test/jdk/java/awt/Window/ResizeTest/ResizeTest.java line 29:
> 
>> 27:  * @summary Tests that focus lost is delivered to a lightweight component
>> 28:  * in a disposed window
>> 29:  * @library /open/test/jdk/java/awt/regtesthelpers
> 
> remove the leading "/open/test/jdk"

Updated.

> test/jdk/java/awt/Window/ShowWindowTest/ShowWindowTest.java line 28:
> 
>> 26:  * @bug 4084997
>> 27:  * @summary See if Window can be created without its size explicitly set
>> 28:  * @library /open/test/jdk/java/awt/regtesthelpers
> 
> again, remove the leading "/open/test/jdk"

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21284#discussion_r1785771800
PR Review Comment: https://git.openjdk.org/jdk/pull/21284#discussion_r1785772385
PR Review Comment: https://git.openjdk.org/jdk/pull/21284#discussion_r1785772984
PR Review Comment: https://git.openjdk.org/jdk/pull/21284#discussion_r1785772064
PR Review Comment: https://git.openjdk.org/jdk/pull/21284#discussion_r1785773224