RFR: 8341000: Open source some of the AWT Window tests [v3]
Jayathirth D V
jdv at openjdk.org
Thu Oct 3 08:19:37 UTC 2024
On Thu, 3 Oct 2024 07:40:46 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update based on review comments
>
> test/jdk/java/awt/Window/InvalidFocusLostEventTest/InvalidFocusLostEventTest.java line 90:
>
>> 88: robot.setAutoWaitForIdle(true);
>> 89: EventQueue.invokeAndWait(() -> bp = b.getLocationOnScreen());
>> 90: robot.mouseMove(bp.x + b.getWidth() / 2, bp.y + b.getHeight() / 2 );
>
> button width and height should be accessed on EDT?
I am not sure whether we need to use EDT even for getting information of already drawn UI Components.
I was under the impression that only for UI updates we need to use EDT.
Now i am not sure whether we need to use EDT for getLocationOnScreen() also. Most of the already present tests don't use EDT for only getting information related to already rendered UI components.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21281#discussion_r1785817575
More information about the client-libs-dev
mailing list