RFR: 8340985: Open source some Desktop related tests

[Abhishek Kumar]

On Thu, 3 Oct 2024 09:09:42 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and open source five regression tests related to java.awt.Desktop component.

test/jdk/java/awt/Desktop/ActionSupportTest/ActionSupportTest.java line 28:

> 26:  * @bug 6255196
> 27:  * @key headful
> 28:  * @summary Verifies the supported actions on different platforms.

Usually we keep summary just after bug, not mandatory though. Infact, this is not consistent with the tests here.

test/jdk/java/awt/Desktop/ActionSupportTest/ActionSupportTest.java line 49:

> 47:             System.out.println("Class java.awt.Desktop is not supported on " +
> 48:                     "current platform. Farther testing will not be performed");
> 49:             return;

May use jtreg skipped Exception.

test/jdk/java/awt/Desktop/BrowseTest/BrowseTest.java line 44:

> 42:             directory, and default web browser to show the URL of java vendor.
> 43:             After test execution close the native file manager and web browser
> 44:             windows if they were lunched by test.

Suggestion:

            windows if they were launched by test.

test/jdk/java/awt/Desktop/MailTest/MailTest.java line 42:

> 40: 
> 41:     static final String INSTRUCTIONS = """
> 42:             This test could launch the mail client to composing mail

Suggestion:

            This test could launch the mail client to compose mail

test/jdk/java/awt/Desktop/MailTest/MailTest.java line 45:

> 43:             with and without filling the message fields.
> 44:             After test execution close the mail composing windows if they
> 45:             were lunched by test.

Suggestion:

            were launched by test.

test/jdk/java/awt/Desktop/OpenTest/OpenTest.java line 27:

> 25:  * @test
> 26:  * @bug 6255196
> 27:  * @key headful

`headful` tag is redundant for manual test.

test/jdk/java/awt/Desktop/OpenTest/OpenTest.java line 29:

> 27:  * @key headful
> 28:  * @summary Verifies the function of method open(java.io.File file).
> 29:  * @library /open/test/jdk/java/awt/regtesthelpers

Please remove leading `/open/test/jdk`

test/jdk/java/awt/Desktop/OpenTest/OpenTest.java line 45:

> 43:             This test could open the user's home directory and a .txt file.
> 44:             After test execution, close the native application windows that
> 45:             are used to open the directory and .txt file if they were lunched

Suggestion:

            are used to open the directory and .txt file if they were launched

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21321#discussion_r1786065979
PR Review Comment: https://git.openjdk.org/jdk/pull/21321#discussion_r1786066438
PR Review Comment: https://git.openjdk.org/jdk/pull/21321#discussion_r1786068136
PR Review Comment: https://git.openjdk.org/jdk/pull/21321#discussion_r1786074604
PR Review Comment: https://git.openjdk.org/jdk/pull/21321#discussion_r1786074324
PR Review Comment: https://git.openjdk.org/jdk/pull/21321#discussion_r1786084318
PR Review Comment: https://git.openjdk.org/jdk/pull/21321#discussion_r1786084637
PR Review Comment: https://git.openjdk.org/jdk/pull/21321#discussion_r1786085200