RFR: 8341162: Open source some of the AWT window test [v2]

Alexey Ivanov aivanov at openjdk.org
Thu Oct 3 17:23:36 UTC 2024


On Thu, 3 Oct 2024 07:45:21 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> Clean up and open source some of the AWT window tests.
>> Automated test `OwnedWindowShowTest.java` is verified in our CI also and it passes on all platforms.
>
> Jayathirth D V has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Remove not needed setVisible calls
>  - Update based on review comments

test/jdk/java/awt/Window/OwnedWindowShowTest/OwnedWindowShowTest.java line 47:

> 45:             Window owner = new Window(parent);
> 46:             Window window = new Window(owner);
> 47:             window.setVisible(true);

You may add a comment here that `setVisible(true)` should not throw any exception.

Yes, it is stated in the test summary, yet repeating it here would make it clearer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21284#discussion_r1786591157


More information about the client-libs-dev mailing list