RFR: 8341162: Open source some of the AWT window test [v3]

[Alexey Ivanov]

On Fri, 4 Oct 2024 06:45:24 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> Clean up and open source some of the AWT window tests.
>> Automated test `OwnedWindowShowTest.java` is verified in our CI also and it passes on all platforms.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update based on review comments

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/Window/LocationByPlatform/TestLocationByPlatform.java line 86:

> 84: }
> 85: 
> 86: class MyCanvas extends Canvas {

Please make a nested static class inside `TestLocationByPlatform`.

It avoids any potential conflicts for any other tests which may use `MyCanvas` that you may have in classpath in your IDE.

test/jdk/java/awt/Window/OwnedWindowShowTest/OwnedWindowShowTest.java line 47:

> 45:             Window owner = new Window(parent);
> 46:             Window window = new Window(owner);
> 47:             // Showing a window with multiple level of ownership

Suggestion:

            // Showing a window with multiple levels of ownership

test/jdk/java/awt/Window/ShowWindowTest/ShowWindowTest.java line 52:

> 50:             2. Click on the "Show" button. A window with a "Hello World" Label
> 51:             should appear
> 52:             3. If the window does not appear the test failed, otherwise passed.

Suggestion:

            3. If the window does not appear, the test failed, otherwise passed.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21284#pullrequestreview-2348100434
PR Review Comment: https://git.openjdk.org/jdk/pull/21284#discussion_r1787738719
PR Review Comment: https://git.openjdk.org/jdk/pull/21284#discussion_r1787739922
PR Review Comment: https://git.openjdk.org/jdk/pull/21284#discussion_r1787740736