RFR: 8341162: Open source some of the AWT window test [v3]

Alexey Ivanov aivanov at openjdk.org
Fri Oct 4 13:49:37 UTC 2024


On Fri, 4 Oct 2024 06:45:24 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> Clean up and open source some of the AWT window tests.
>> Automated test `OwnedWindowShowTest.java` is verified in our CI also and it passes on all platforms.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update based on review comments

test/jdk/java/awt/Window/ShowWindowTest/ShowWindowTest.java line 43:

> 41: public class ShowWindowTest implements ActionListener
> 42: {
> 43:     private static Window win;

I rather rename `win` to `window` — it makes it clearer. With code completion in IDE, you don't need to type the entire name; and renaming is just a shortcut or a few clicks away.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21284#discussion_r1787746551


More information about the client-libs-dev mailing list