RFR: 8340799: Add border inside instruction frame in PassFailJFrame
Damon Nguyen
dnguyen at openjdk.org
Fri Oct 4 23:36:35 UTC 2024
On Thu, 3 Oct 2024 15:05:50 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
> This changeset unifies borders used inside the `PassFailJFrame` framework and adds missing borders.
>
> I started it in  for [JDK-8340306](https://bugs.openjdk.org/browse/JDK-8340306). That changeset handled only the instructions.
>
> This changeset add a border around the entire contents of the instruction frame, adds a border to the log area as well as to the failure reason dialog. The result looks more pleasing and consistent.
>
> I chose the gap of 4 because it plays nicely with fractional scales: 4 × 1.25 = 5 — no fractional pixels.
Changes look good! The "after" screenshot does look better with a gap.
-------------
Marked as reviewed by dnguyen (Committer).
PR Review: https://git.openjdk.org/jdk/pull/21327#pullrequestreview-2349369645
More information about the client-libs-dev
mailing list