RFR: 8341170: Open source several Choice related tests (part 2)

Alexander Zuev kizune at openjdk.org
Sun Oct 6 21:25:35 UTC 2024


On Fri, 4 Oct 2024 17:24:43 GMT, Phil Race <prr at openjdk.org> wrote:

>> Clean up and iopen source five more regression tests related to the java.awt.Choice component.
>
> test/jdk/java/awt/Choice/ChoiceDragEventsInside/ChoiceDragEventsInside.java line 94:
> 
>> 92:             });
>> 93:             testDragInsideChoice(InputEvent.BUTTON1_MASK);
>> 94:             //            testDragInsideChoiceWhileUnfurled(InputEvent.BUTTON1_MASK);
> 
> Why is this commented out line present ?
> Should it be uncommented ?
> Otherwise why do you have a method definition of this otherwise uncalled method ?

That part of the test passes on Linux and fails on macOS and Windows. I think it is better to remove this test scenario completely because this behavior is not documented and it is platform specific.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21334#discussion_r1789257529


More information about the client-libs-dev mailing list