RFR: 8341170: Open source several Choice related tests (part 2) [v2]

Harshitha Onkar honkar at openjdk.org
Tue Oct 8 01:01:17 UTC 2024


On Sun, 6 Oct 2024 21:28:59 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Clean up and iopen source five more regression tests related to the java.awt.Choice component.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unused test scenario and correct output to reflect it.

LGTM other than few missing Frame titles

test/jdk/java/awt/Choice/ChoiceDragEventsInside/ChoiceDragEventsInside.java line 76:

> 74:         );
> 75:         add(choice1);
> 76:         setLayout(new FlowLayout());

Frame title missing here and at other places.
`setTitle("ChoiceDragEventsInside");`

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21334#pullrequestreview-2353167571
PR Review Comment: https://git.openjdk.org/jdk/pull/21334#discussion_r1791041830


More information about the client-libs-dev mailing list