RFR: 8340173: Open source some Component/Panel/EventQueue tests - Set2 [v2]

Damon Nguyen dnguyen at openjdk.org
Tue Oct 8 16:55:20 UTC 2024


On Tue, 8 Oct 2024 02:57:55 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> test/jdk/java/awt/EventQueue/PushPopDeadlock/PushPopDeadlock.java line 29:
> 
>> 27:  * @summary Verifies that calling EventQueue.push() and EventQueue.pop()
>> 28:  *          does not deadlock.
>> 29:  * @library /open/test/jdk/java/awt/regtesthelpers
> 
> library path

Thanks. Fixed both.

> test/jdk/java/awt/LightweightComponent/MultipleAddNotifyTest/MultipleAddNotifyTest.java line 72:
> 
>> 70:                 f.add(l);
>> 71:                 f.addNotify();
>> 72:                 f.addNotify();
> 
> duplicate addNotify..

The test is to use multiple addNotify and check if a LW component still works properly. So this needs 2.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21398#discussion_r1792213280
PR Review Comment: https://git.openjdk.org/jdk/pull/21398#discussion_r1792211657


More information about the client-libs-dev mailing list