RFR: 8341257: Open source few DND tests - Set1 [v3]

[Harshitha Onkar]

On Tue, 8 Oct 2024 17:34:31 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Following tests are added as part of this PR:
>> 
>> 1. /java/awt/dnd/NonAsciiFilenames/NonAsciiFilenames.java - MANUAL
>> 2. /java/awt/dnd/DnDRemoveFocusOwnerCrashTest/DnDRemoveFocusOwnerCrashTest.java - AUTO
>> 3. /java/awt/dnd/DnDToWordpadTest/DnDToWordpadTest.java - MANUAL
>> 4. /java/awt/dnd/DnDCursorCrashTest/DnDCursorCrashTest.java - AUTO (Problem listed on MacOS only.)
>> 5. /java/awt/dnd/DnDClipboardDeadlockTest/DnDClipboardDeadlockTest.java - AUTO (Problem listed on Linux only.)
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment

test/jdk/java/awt/dnd/DnDCursorCrashTest/DnDCursorCrashTest.java line 76:

> 74:         try {
> 75:             EventQueue.invokeAndWait(() -> {
> 76:                 frame.setTitle("Test frame");

A more descriptive title for the Frame ?
This test passes on macOS, is it problemlisted due to an intermittent issue?

test/jdk/java/awt/dnd/DnDRemoveFocusOwnerCrashTest/DnDRemoveFocusOwnerCrashTest.java line 86:

> 84:                     e.printStackTrace();
> 85:                     throw new RuntimeException("The test failed.");
> 86:                 }

Thread.sleep can be replaced with robot.delay()

test/jdk/java/awt/dnd/DnDRemoveFocusOwnerCrashTest/DnDRemoveFocusOwnerCrashTest.java line 98:

> 96:                     for (int dy = 0; dy < 50; dy++) {
> 97:                         robot.mouseMove(p.x, p.y + dy);
> 98:                         Thread.sleep(10);

Suggestion:

                        robot.delay(10);

test/jdk/java/awt/dnd/DnDToWordpadTest/DnDToWordpadTest.java line 237:

> 235:         return m_img;
> 236:     }
> 237: }

Missing EOF newline

test/jdk/java/awt/dnd/NonAsciiFilenames/NonAsciiFilenames.java line 56:

> 54:                 Explorer. Try to find a file whose name uses non-ISO 8859-1
> 55:                 characters. You will not be verifying the fix for 4187490 unless
> 56:                 you drag a file which contains non-ISO 8859-1 characters. Drag

Would it be better to provide the tester some examples of non-ISO 8859-1 characters and change the test instructions as below?

Suggestion:

                Create a file and name it such that it contains non-ISO 8859-1 characters. (For eg. é, à, ö, €, ¥)

test/jdk/java/awt/dnd/NonAsciiFilenames/NonAsciiFilenames.java line 158:

> 156:         showDrop(false);
> 157:     }
> 158: }

Missing EOF newline

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21394#discussion_r1792300109
PR Review Comment: https://git.openjdk.org/jdk/pull/21394#discussion_r1792302131
PR Review Comment: https://git.openjdk.org/jdk/pull/21394#discussion_r1792302462
PR Review Comment: https://git.openjdk.org/jdk/pull/21394#discussion_r1792332281
PR Review Comment: https://git.openjdk.org/jdk/pull/21394#discussion_r1792331070
PR Review Comment: https://git.openjdk.org/jdk/pull/21394#discussion_r1792331975