RFR: 8341257: Open source few DND tests - Set1 [v3]

Damon Nguyen dnguyen at openjdk.org
Tue Oct 8 21:19:42 UTC 2024


On Tue, 8 Oct 2024 18:30:57 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment
>
> test/jdk/java/awt/dnd/NonAsciiFilenames/NonAsciiFilenames.java line 56:
> 
>> 54:                 Explorer. Try to find a file whose name uses non-ISO 8859-1
>> 55:                 characters. You will not be verifying the fix for 4187490 unless
>> 56:                 you drag a file which contains non-ISO 8859-1 characters. Drag
> 
> Would it be better to provide the tester some examples of non-ISO 8859-1 characters and change the test instructions as below?
> 
> Suggestion:
> 
>                 Create a file and name it such that it contains non-ISO 8859-1 characters. (For eg. é, à, ö, €, ¥)

Good idea. Edited.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21394#discussion_r1792518212


More information about the client-libs-dev mailing list