RFR: 8340173: Open source some Component/Panel/EventQueue tests - Set2 [v2]
Damon Nguyen
dnguyen at openjdk.org
Tue Oct 8 23:43:58 UTC 2024
On Tue, 8 Oct 2024 22:33:39 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/awt/EventQueue/PushPopDeadlock/PushPopDeadlock.java line 59:
>
>> 57: .testUI(PushPopDeadlock::createUI)
>> 58: .build()
>> 59: .awaitAndCheck();
>
> Though the test is problemlisted I think it might be better to separate the createUI code from the EventQueue push/pop test logic as below.
> With the test() method having all the code from `EventQueue q = new EventQueue() { ....` onwards.
>
>
> PassFailJFrame pfJFrame = PassFailJFrame.builder()
> .title("Test Instructions")
> .instructions(INSTRUCTIONS)
> .columns(35)
> .testUI(PushPopDeadlock::createUI)
> .build();
> PushPopDeadlock.test();
> pfJFrame.awaitAndCheck();
Sure, I made the suggested changes needed for this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21398#discussion_r1792621286
More information about the client-libs-dev
mailing list