RFR: 8340809: Open source few more AWT PopupMenu tests [v2]
Abhishek Kumar
abhiscxk at openjdk.org
Wed Oct 9 17:38:35 UTC 2024
On Wed, 9 Oct 2024 16:46:19 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comment fix
>
> test/jdk/java/awt/PopupMenu/PopupMenuCrash.java line 48:
>
>> 46: String INSTRUCTIONS = """
>> 47: This tests a windows specific problem.
>> 48: When you see a frame titled "PopupMenuCrash Test", right-click on it a lot
>
> Suggestion:
>
> When you see a frame titled "PopupMenuCrash Test", right-click on it several times
>
> Does it sound better?
Yes... Updated.
> test/jdk/java/awt/PopupMenu/PopupMenuCrash.java line 78:
>
>> 76: firstPress = false;
>> 77: try {
>> 78: Thread.sleep(15000);
>
> Suggestion:
>
> Thread.sleep(10000);
>
> Reduce to 10 seconds as stated in instructions?
Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21412#discussion_r1793909328
PR Review Comment: https://git.openjdk.org/jdk/pull/21412#discussion_r1793909114
More information about the client-libs-dev
mailing list