RFR: 8341257: Open source few DND tests - Set1 [v2]
Damon Nguyen
dnguyen at openjdk.org
Wed Oct 9 19:14:34 UTC 2024
On Wed, 9 Oct 2024 18:59:11 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
>> Well, the frames aren't being disposed, so the VM isn't going to exit() on its own.
>> You need to make sure that is done in both the parent and the exec'd chilld
>>
>> I don't see an issue with calling System.exit(0) from the exec'ed child.
>> ie so long as it is ONLY from the child process, not the test launched by jtreg.
>> You'd need to do this if you wanted to signal any non-default condition.
>
> @prrace Could you elaborate on what needs to be done in the parent and exec'd child? I'm not sure I quite understand. Do you want me to add `frame.dispose()` to both the parent and child processes?
I added what I think you meant, but let me know if this is correct/incorrect. Test still working as expected.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21394#discussion_r1794074320
More information about the client-libs-dev
mailing list