RFR: 8340173: Open source some Component/Panel/EventQueue tests - Set2 [v5]
Damon Nguyen
dnguyen at openjdk.org
Thu Oct 10 00:59:07 UTC 2024
On Thu, 10 Oct 2024 00:22:56 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Changed offset to pass on win
>
> test/jdk/java/awt/LightweightComponent/MultipleAddNotifyTest/MultipleAddNotifyTest.java line 86:
>
>> 84: posX = l.getWidth() + 75;
>> 85: posY = l.getHeight();
>> 86: });
>
> After moving the frame to the center of the screen the click location can be updated as below.
>
> This adds some context for click location instead of having a hard-coded arbitrary offset.
>
> Suggestion:
>
> EventQueue.invokeAndWait(() -> {
> posX = f.getX() + l.getWidth() + l.getWidth() / 2;
> posY = f.getY() + l.getHeight();
> });
Added this but in testing on CI, a small offset is still needed. Still better than just having the large offset. Changed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21398#discussion_r1794432026
More information about the client-libs-dev
mailing list