RFR: 8340336: Open some checkbox awt tests

Tejesh R tr at openjdk.org
Thu Oct 10 05:05:12 UTC 2024


On Thu, 10 Oct 2024 00:25:39 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Fourth set of dialog swing tests to open during fall 2024 test sprint

test/jdk/java/awt/Dialog/ClosingParentTest.java line 36:

> 34:  * @bug 4336913
> 35:  * @summary On Win32, disable parent window controls while modal dialog is being created.
> 36:  * @library /open/test/jdk/java/awt/regtesthelpers

Suggestion:

 * @library /java/awt/regtesthelpers

test/jdk/java/awt/Dialog/ClosingParentTest.java line 73:

> 71:             public void actionPerformed(ActionEvent e) {
> 72:                 try {
> 73:                     Thread.currentThread().sleep(5000);

sleep is required here?

test/jdk/java/awt/Dialog/ClosingParentTest.java line 91:

> 89:         dialog.setSize(100, 100);
> 90:         dialog.addWindowListener(new WindowAdapter() {
> 91:             public void windowClosing(WindowEvent e) {

Does the test need windowClosing? Same in other test too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21433#discussion_r1794652056
PR Review Comment: https://git.openjdk.org/jdk/pull/21433#discussion_r1794652702
PR Review Comment: https://git.openjdk.org/jdk/pull/21433#discussion_r1794653808


More information about the client-libs-dev mailing list