RFR: 8340851: Open some TextArea awt tests

Abhishek Kumar abhiscxk at openjdk.org
Thu Oct 10 11:35:12 UTC 2024


On Thu, 10 Oct 2024 00:37:15 GMT, Alisen Chung <achung at openjdk.org> wrote:

> sixth set of tests to open for fall 2024 test sprint

test/jdk/java/awt/TextArea/TextAreaAppendScrollTest.java line 34:

> 32:  * @bug 5003402
> 33:  * @summary TextArea must scroll automatically when calling append and select, even when not in focus
> 34:  * @library /open/test/jdk/java/awt/regtesthelpers

Please remove leading `/open/test/jdk` from all the tests.

test/jdk/java/awt/TextArea/TextAreaAppendScrollTest.java line 39:

> 37:  */
> 38: 
> 39: public class TextAreaAppendScrollTest extends Frame implements ActionListener {

May not require to extend Frame, frame can be created inside constructor.

test/jdk/java/awt/TextArea/TextAreaCursorTest.java line 36:

> 34:  * @test
> 35:  * @bug 4060320
> 36:  * @summary Test textarea cursor shape on its scrollbars

Suggestion:

 * @summary Test TextArea cursor shape on its scrollbars

test/jdk/java/awt/TextArea/TextAreaKeypadTest.java line 55:

> 53: 
> 54:     public static Frame createGUI() {
> 55:         Frame frame = new Frame();

Title missing.

test/jdk/java/awt/TextArea/TextAreaSelectionTest.java line 35:

> 33:  * @test
> 34:  * @bug 4095946
> 35:  * @summary 592677:TEXTFIELD TAB SELECTION CONFUSING; REMOVE ES_NOHIDESEL STYLE IN

Why summary is in all caps?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21434#discussion_r1795239807
PR Review Comment: https://git.openjdk.org/jdk/pull/21434#discussion_r1795247875
PR Review Comment: https://git.openjdk.org/jdk/pull/21434#discussion_r1795248530
PR Review Comment: https://git.openjdk.org/jdk/pull/21434#discussion_r1795250963
PR Review Comment: https://git.openjdk.org/jdk/pull/21434#discussion_r1795251596


More information about the client-libs-dev mailing list