RFR: 8341072: Open source several AWT Canvas and Rectangle related tests

Phil Race prr at openjdk.org
Fri Oct 11 18:35:14 UTC 2024


On Fri, 11 Oct 2024 07:10:20 GMT, Tejesh R <tr at openjdk.org> wrote:

> Open source these AWT Canvas and Rectangle tests:
> java/awt/Canvas/MultiDitherTest/MultiDitherTest.java
> java/awt/Canvas/MultiGraphicsTest/MultiGraphicsTest.java
> java/awt/Canvas/NoEventsLeakTest/NoEventsLeakTest.java
> java/awt/Rectangle/IntersectionTest/IntersectionTest.java

test/jdk/java/awt/Canvas/MultiDitherTest.java line 77:

> 75:         String INSTRUCTIONS = """
> 76:                 This test displays several dithered Canvases similar to the
> 77:                 DitherTest demo applet, one for each available GraphicsConfiguration.

remove the phrase "similar to the DitherTest demo applet" that applet was retired many years ago.

test/jdk/java/awt/Canvas/MultiDitherTest.java line 84:

> 82:                 On Solaris, making some Windows active will cause some of the
> 83:                 other Windows to display strangely. This is normal.
> 84:                 Ensure that there are as many Frames created as there are

remove the sentence about Solaris, it hasn't been a supported platform for several years

test/jdk/java/awt/Canvas/MultiGraphicsTest.java line 68:

> 66:                 Ensure that there are as many Windows created as there are
> 67:                 available GraphicsConfigurations.
> 68:                 Examine each Window to ensure it displays Jim.

Jim ? You mean Duke.

Also remove mention of Solaris, it hasn't been a supported platform for several years

test/jdk/java/awt/Rectangle/IntersectionTest.java line 30:

> 28:  * @summary Test to verify setClip with invalid rect changes rect to valid
> 29:  * @library /java/awt/regtesthelpers
> 30:  * @build PassFailJFrame

This isn't a manual test, it does not need these two lines

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21464#discussion_r1797301798
PR Review Comment: https://git.openjdk.org/jdk/pull/21464#discussion_r1797301076
PR Review Comment: https://git.openjdk.org/jdk/pull/21464#discussion_r1797300400
PR Review Comment: https://git.openjdk.org/jdk/pull/21464#discussion_r1797302697


More information about the client-libs-dev mailing list