RFR: 8341972: java/awt/dnd/DnDRemoveFocusOwnerCrashTest.java timed out after JDK-8341257 [v2]
Damon Nguyen
dnguyen at openjdk.org
Fri Oct 11 19:59:24 UTC 2024
On Fri, 11 Oct 2024 19:50:27 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add delay before getting location. Put whole disposal into EDT
>
> test/jdk/java/awt/dnd/DnDRemoveFocusOwnerCrashTest.java line 86:
>
>> 84: frame.setVisible(true);
>> 85:
>> 86: p = dragSourceButton.getLocationOnScreen();
>
> Getting the location just after `setVisible` on EDT may give an inaccurate result(especially if the tested system is slow, and decided to move the window somewhere else).
>
> I suggest to wait as usual before getting the location
>
> robot.waitForIdle();
> robot.delay(500); // or FRAME_ACTIVATION_TIMEOUT
Good idea. Added.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21477#discussion_r1797371009
More information about the client-libs-dev
mailing list