RFR: 8341982: Simplify JButton/bug4323121.java [v2]
Alexey Ivanov
aivanov at openjdk.org
Mon Oct 14 15:34:29 UTC 2024
> The test `javax/swing/JButton/bug4323121.java` contains lots of unused methods.
>
> I removed all the unused methods by extending `MouseAdapter`.
>
> I use `CountDownLatch` to synchronise actions in the test.
>
> The test still verifies `button.getModel().isArmed()` doesn't always return `true` for classes which extend `JButton`. I verified the updated test fails in 1.3.0 and passes in 1.4.0, so the test still reproduces the original problem.
Alexey Ivanov has updated the pull request incrementally with two additional commits since the last revision:
- Clarify thread-safety of the modelArmed flag
- Remove MouseMotionListener; get rid of eventHandler variable
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/21475/files
- new: https://git.openjdk.org/jdk/pull/21475/files/25c84b6e..128d7bef
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=21475&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=21475&range=00-01
Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/21475.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21475/head:pull/21475
PR: https://git.openjdk.org/jdk/pull/21475
More information about the client-libs-dev
mailing list