RFR: 8341982: Simplify JButton/bug4323121.java [v2]
Abhishek Kumar
abhiscxk at openjdk.org
Mon Oct 14 15:58:11 UTC 2024
On Mon, 14 Oct 2024 15:35:47 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Yeah, this is an option. As I mentioned earlier that MouseMotionListener is not needed, so creating an eventHandler object may not be of great use. I agree if more than one listener needs to be added, creating an eventHandler object is a good idea.
>
> I removed the unneeded listener and inlined creation of the event handler.
>
> Thus, I kept the current structure of test code. I prefer it this way for consistency with `JButton/bug4490179.java` in https://github.com/openjdk/jdk/pull/21474. Both tests are really similar, and I think consistent coding helps.
Ok...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21475#discussion_r1799756648
More information about the client-libs-dev
mailing list