RFR: 8341984: Use PassFailJFrame for TimeChangeButtonClickTest.java

Abhishek Kumar abhiscxk at openjdk.org
Mon Oct 14 17:37:18 UTC 2024


On Fri, 11 Oct 2024 18:47:47 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Refactor the test `javax/swing/JButton/TimeChangeButtonClickTest.java` to use the `PassFailJFrame` framework to handle the tester's decision on whether the test passes or fails.
> 
> I reformatted the instructions for performing the test into HTML.
> 
> I preserved the test UI panel which contains the button to press and the label with button press counter.
> 
> The updated test is shorter by nearly 100 lines.

test/jdk/javax/swing/JButton/TimeChangeButtonClickTest.java line 29:

> 27:  * @summary  Test that Swing does not ignore first click on a JButton after
> 28:  * decreasing system's time
> 29:  * @run main/manual TimeChangeButtonClickTest

Please add jtreg tags to avoid compilation error.
`@library /java/awt/regtesthelpers` and `@build PassFailJFrame`

test/jdk/javax/swing/JButton/TimeChangeButtonClickTest.java line 45:

> 43: 
> 44: public class TimeChangeButtonClickTest {
> 45:     private static final String instructions = """

Suggestion:

    private static final String INSTRUCTIONS = """

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21476#discussion_r1799863412
PR Review Comment: https://git.openjdk.org/jdk/pull/21476#discussion_r1799863744


More information about the client-libs-dev mailing list