RFR: 8341984: Use PassFailJFrame for TimeChangeButtonClickTest.java [v2]

[Harshitha Onkar]

On Mon, 14 Oct 2024 18:37:43 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Refactor the test `javax/swing/JButton/TimeChangeButtonClickTest.java` to use the `PassFailJFrame` framework to handle the tester's decision on whether the test passes or fails.
>> 
>> I reformatted the instructions for performing the test into HTML.
>> 
>> I preserved the test UI panel which contains the button to press and the label with button press counter.
>> 
>> The updated test is shorter by nearly 100 lines.
>
> Alexey Ivanov has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Rename instructions -> INSTRUCTIONS
>  - Add @library and @build jtreg tags

LGTM other than minor suggestion on default timeout.

test/jdk/javax/swing/JButton/TimeChangeButtonClickTest.java line 87:

> 85:                       .instructions(INSTRUCTIONS)
> 86:                       .rows(20)
> 87:                       .columns(40)

Suggestion:

                      .columns(40)
                      .testTimeOut(10)


We do have a pause timer option but I think a timeout of 8-10 mins is better than the default of 5 mins since it allows more time for the user to change the time settings.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21476#pullrequestreview-2367406140
PR Review Comment: https://git.openjdk.org/jdk/pull/21476#discussion_r1799956133