RFR: 8341982: Simplify JButton/bug4323121.java [v2]
Alisen Chung
achung at openjdk.org
Tue Oct 15 22:32:11 UTC 2024
On Mon, 14 Oct 2024 15:34:29 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> The test `javax/swing/JButton/bug4323121.java` contains lots of unused methods.
>>
>> I removed all the unused methods by extending `MouseAdapter`.
>>
>> I use `CountDownLatch` to synchronise actions in the test.
>>
>> The test still verifies `button.getModel().isArmed()` doesn't always return `true` for classes which extend `JButton`. I verified the updated test fails in 1.3.0 and passes in 1.4.0, so the test still reproduces the original problem.
>
> Alexey Ivanov has updated the pull request incrementally with two additional commits since the last revision:
>
> - Clarify thread-safety of the modelArmed flag
> - Remove MouseMotionListener; get rid of eventHandler variable
Marked as reviewed by achung (Committer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/21475#pullrequestreview-2370808118
More information about the client-libs-dev
mailing list