RFR: 8342098: Write a test to compare the images [v2]

Harshitha Onkar honkar at openjdk.org
Wed Oct 16 18:07:11 UTC 2024


On Wed, 16 Oct 2024 16:13:33 GMT, Naveen Narayanan <duke at openjdk.org> wrote:

>> This testcase checks for the following:
>> 
>> 1. An image is drawn on the screen and a portion of it is captured using a Robot. It is tested by comparing whether the captured image is same as the source image. 
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in MacOS, Linux and Windows. Seen all tests passing.
>
> Naveen Narayanan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8342098: Updated review comments

test/jdk/java/awt/Robot/ScreenCaptureRobotTest.java line 52:

> 50:     private static BufferedImage realImage;
> 51:     private static BufferedImage displayImage;
> 52:     private static int difference;

This can be changed to toleranceLevel  instead of having two variables track it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21524#discussion_r1803576206


More information about the client-libs-dev mailing list