RFR: 8342098: Write a test to compare the images [v2]

Tejesh R tr at openjdk.org
Thu Oct 17 10:17:12 UTC 2024


On Wed, 16 Oct 2024 16:13:33 GMT, Naveen Narayanan <duke at openjdk.org> wrote:

>> This testcase checks for the following:
>> 
>> 1. An image is drawn on the screen and a portion of it is captured using a Robot. It is tested by comparing whether the captured image is same as the source image. 
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in MacOS, Linux and Windows. Seen all tests passing.
>
> Naveen Narayanan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8342098: Updated review comments

Also the test is failing in windows local machine. Can you re-confirm once by testing it in any Windows machine? Or is there anything I might be missing while testing?

test/jdk/java/awt/Robot/ScreenCaptureRobotTest.java line 47:

> 45: public class ScreenCaptureRobotTest {
> 46: 
> 47:     private static int delay = 500;

I don't think we need `delay`, since it's used only once. Can directly use the value.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21524#pullrequestreview-2374766667
PR Review Comment: https://git.openjdk.org/jdk/pull/21524#discussion_r1804490838


More information about the client-libs-dev mailing list