RFR: 8340494: Open some dialog awt tests 4 [v4]

[Harshitha Onkar]

On Thu, 17 Oct 2024 15:24:05 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Fifth set of swing test to open for fall 2024 test sprint
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update

test/jdk/java/awt/Container/ActivateOnFocusTest.java line 62:

> 60: 
> 61:             Robot robot = new Robot();
> 62:             robot.waitForIdle();

Missing delay after UI Creation

Suggestion:

            robot.waitForIdle();
            robot.delay(1000);

test/jdk/java/awt/Container/ActivateOnFocusTest.java line 73:

> 71:             robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 72:             robot.delay(250);
> 73:             robot.waitForIdle();

Suggestion:

            robot.waitForIdle();
            robot.delay(250);

test/jdk/java/awt/Container/MouseEnteredTest.java line 79:

> 77: 
> 78:     public MouseEnteredTest() {
> 79:         JPopupMenu.setDefaultLightWeightPopupEnabled(false);

Frame title missing

test/jdk/java/awt/Container/MouseEnteredTest.java line 96:

> 94:             robot.setAutoWaitForIdle(true);
> 95:             robot.waitForIdle();
> 96:             robot.delay(250);

Usually we have a minimum delay of 1 second after UI creation.

test/jdk/java/awt/Dialog/ModalExcludedTest.java line 71:

> 69:                 Make sure the frame and the modeless dialog are inaccessible,
> 70:                 i.e. receive no mouse and keyboard events. MousePressed and
> 71:                 KeyPressed events are logged in the text area below - use it

Suggestion:

                KeyPressed events are logged in the text area - use it

test/jdk/java/awt/Dialog/ModalExcludedTest.java line 80:

> 78:                 behave the same way as there is no modal dialog shown. Verify
> 79:                 this by pressing mouse buttons and typing any keys. The
> 80:                 RootFrame would be modal blocked - verify this too

` RootFrame would be modal blocked - verify this too`

How to verify this? Does it mean that we cannot close the RootFrame without closing the modal?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21479#discussion_r1805235569
PR Review Comment: https://git.openjdk.org/jdk/pull/21479#discussion_r1805236196
PR Review Comment: https://git.openjdk.org/jdk/pull/21479#discussion_r1805248839
PR Review Comment: https://git.openjdk.org/jdk/pull/21479#discussion_r1805249565
PR Review Comment: https://git.openjdk.org/jdk/pull/21479#discussion_r1805262311
PR Review Comment: https://git.openjdk.org/jdk/pull/21479#discussion_r1805265337