RFR: 8339975: Open some dialog awt tests 2 [v4]

Alexander Zvegintsev azvegint at openjdk.org
Thu Oct 17 19:12:16 UTC 2024


On Thu, 17 Oct 2024 17:25:23 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Second set of dialog swing tests to open during fall 2024 test sprint
>
> Alisen Chung has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - fix small issues
>  - revert test to manual
>  - revert test to manual

Marked as reviewed by azvegint (Reviewer).

test/jdk/java/awt/Dialog/DialogDisposeLeak.java line 94:

> 92: class DisposeDialog extends Dialog {
> 93:     DisposeDialog(Frame frame) {
> 94:         super(frame, "DisposeDialog", true);

The dialog to click on is too far away from the parent frame, it will be easier to click 10 times if it is just under the mouse cursor.

Suggestion:

        super(frame, "DisposeDialog", true);
        setLocation(frame.getX(), frame.getY());

-------------

PR Review: https://git.openjdk.org/jdk/pull/21488#pullrequestreview-2376066901
PR Review Comment: https://git.openjdk.org/jdk/pull/21488#discussion_r1805289305


More information about the client-libs-dev mailing list