RFR: 8341978: Improve JButton/bug4490179.java
Alexey Ivanov
aivanov at openjdk.org
Fri Oct 18 10:55:39 UTC 2024
On Thu, 17 Oct 2024 08:56:48 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> test/jdk/javax/swing/JButton/bug4490179.java line 123:
>>
>>> 121:
>>> 122: if (actionPerformed.await(100, MILLISECONDS)) {
>>> 123: throw new RuntimeException("Action event triggered by releasing button 3");
>>
>> line here also should be put into 2 lines
>
> I'm reluctant about changing it… The PR is approved now. And the line still fits 100-column limit.
>
> Yet here it wrapping the line has its value, the button number is at the end of the line.
I talked to @azvegint and we decided it's good enough. Wrapping the lines would require re-review.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21474#discussion_r1806305567
More information about the client-libs-dev
mailing list