RFR: 8341982: Simplify JButton/bug4323121.java [v4]

Sergey Bylokhov serb at openjdk.org
Fri Oct 18 16:40:31 UTC 2024


On Fri, 18 Oct 2024 12:19:24 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The test `javax/swing/JButton/bug4323121.java` contains lots of unused methods.
>> 
>> I removed all the unused methods by extending `MouseAdapter`.
>> 
>> I use `CountDownLatch` to synchronise actions in the test.
>> 
>> The test still verifies `button.getModel().isArmed()` doesn't always return `true` for classes which extend `JButton`. I verified the updated test fails in 1.3.0 and passes in 1.4.0, so the test still reproduces the original problem.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove space before comma
>   
>   Co-authored-by: Abhishek Kumar <abhishek.cx.kumar at oracle.com>

test/jdk/javax/swing/JButton/bug4323121.java line 66:

> 64:             });
> 65:             robot.waitForIdle();
> 66:             robot.delay(1000);

The new code probably should follow the same pattern, flush all events/commands to native by the waitForIdle. and then wait response from OS for 1_or_less second.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21475#discussion_r1806763932


More information about the client-libs-dev mailing list