RFR: 8338570: sun/font/HBShaper - mismatch in return type of FFM upcall function description and native invocation

Alexey Ivanov aivanov at openjdk.org
Fri Oct 18 18:45:08 UTC 2024


On Fri, 18 Oct 2024 16:48:58 GMT, Phil Race <prr at openjdk.org> wrote:

> Fix a couple of function signature mismatches.
> No regression test viable that I can see.

Marked as reviewed by aivanov (Reviewer).

src/java.desktop/share/native/libfontmanager/HBShaper_Panama.c line 143:

> 141:          free(features);
> 142:      }
> 143:      return;

Suggestion:


The `return` keyword becomes redundant.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21588#pullrequestreview-2378756954
PR Review Comment: https://git.openjdk.org/jdk/pull/21588#discussion_r1806888716


More information about the client-libs-dev mailing list