RFR: 8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible [v2]
Abhishek Kumar
abhiscxk at openjdk.org
Mon Oct 21 09:43:45 UTC 2024
On Mon, 21 Oct 2024 06:40:22 GMT, Manukumar V S <mvs at openjdk.org> wrote:
>> This issue can be fixed by setting the preferred scrollable viewport size of the two tables using
>> JTable table = new JTable(data, columnNames);
>> + table.setPreferredScrollableViewportSize(table.getPreferredSize());
>> JTable secondTable = new JTable(data, columnNames);
>> + secondTable.setPreferredScrollableViewportSize(secondTable.getPreferredSize());
>>
>> The other changes in imports section are just re-arrangements and expansion of imports.
>>
>> Testing: This is a manual test and it is tested and verified manually in my local system
>> Screenshots of before and after the fix are attached in the bug.
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments fixed : Spelling correction, added setPreferredScrollableViewportSize() for other tables also
test/jdk/java/awt/a11y/AccessibleJTableTest.java line 42:
> 40:
> 41: import java.awt.FlowLayout;
> 42: import java.awt.GridLayout;
Usually we put `awt imports` before swing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21549#discussion_r1808433880
More information about the client-libs-dev
mailing list