RFR: 8342098: Write a test to compare the images [v3]
Naveen Narayanan
duke at openjdk.org
Mon Oct 21 11:40:53 UTC 2024
On Mon, 21 Oct 2024 08:23:31 GMT, Manukumar V S <mvs at openjdk.org> wrote:
>> Naveen Narayanan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8342098: Updated review comments
>
> test/jdk/java/awt/Robot/ScreenCaptureRobotTest.java line 103:
>
>> 101: + "the actual image";
>> 102: System.err.println("Test failed");
>> 103: throw new RuntimeException(errorMessage);
>
> Suggestion:
>
> System.err.println("Test failed");
> saveImage(capturedImage,"robotCapture.png");
> saveImage(realImage,"realImage.png");
> throw new RuntimeException(errorMessage);
@manukumarvs
Right, test passed with sRGB profile
in MacOS 14 & earlier version 12 as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21524#discussion_r1808619067
More information about the client-libs-dev
mailing list