RFR: 8342098: Write a test to compare the images [v3]
Naveen Narayanan
duke at openjdk.org
Mon Oct 21 12:04:23 UTC 2024
On Mon, 21 Oct 2024 04:29:20 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Naveen Narayanan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8342098: Updated review comments
>
> test/jdk/java/awt/Robot/ScreenCaptureRobotTest.java line 119:
>
>> 117:
>> 118: imgWidth = capturedImg.getWidth(null);
>> 119: imgHeight = capturedImg.getHeight(null);
>
> These variables can be removed and `capturedImg.getWidth(null)` should replace `imgWidth` in for-loop condition. same for `imgHeight` also.
@kumarabhi006
In that case,
capturedImg.getWidth(null);
capturedImg.getHeight(null)
will be calculated in every iteration of for loops right.
May be an extra Memory/Processor burden ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21524#discussion_r1808659458
More information about the client-libs-dev
mailing list