RFR: 8342098: Write a test to compare the images [v3]

Abhishek Kumar abhiscxk at openjdk.org
Mon Oct 21 15:34:29 UTC 2024


On Mon, 21 Oct 2024 13:45:45 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/Robot/ScreenCaptureRobotTest.java line 131:
>> 
>>> 129:             }
>>> 130:         }
>>> 131:         return result;
>> 
>> Suggestion:
>> 
>>         return true;
>
> In fact, image comparison can be borrowed from the `Util` class (in Swing part):
> 
> https://github.com/openjdk/jdk/blob/1f3574855e79221739d8800235583b7c47ebae97/test/jdk/javax/swing/regtesthelpers/Util.java#L59-L63

I agree to @aivanov-jdk .

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21524#discussion_r1809048964


More information about the client-libs-dev mailing list