RFR: 8339309: unused-variable warnings happen in libfontmanager

[Phil Race]

On Fri, 30 Aug 2024 10:17:38 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

> I saw following errors (warnings) when I tried to build OpenJDK on Fedora 40 with gcc-14.2.1-1.fc40.x86_64:
> 
> 
> /home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/HBShaper_Panama.c: In function ‘jdk_hb_shape’:
> /home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/HBShaper_Panama.c:101:16: error: unused variable ‘yPtSize’ [-Werror=unused-variable]
>   101 | float yPtSize = euclidianDistance(matrix[2], matrix[3]);
>       | ^~~~~~~
> cc1: all warnings being treated as errors
> * For target support_native_java.desktop_libfontmanager_X11FontScaler.o:
> /home/ysuenaga/github-forked/jdk/src/java.desktop/unix/native/libfontmanager/X11FontScaler.c: In function ‘Java_sun_font_NativeFont_getGlyphAdvance’:
> /home/ysuenaga/github-forked/jdk/src/java.desktop/unix/native/libfontmanager/X11FontScaler.c:270:32: error: unused variable ‘descent’ [-Werror=unused-variable]
>   270 | int direction, ascent, descent;
>       | ^~~~~~~
> /home/ysuenaga/github-forked/jdk/src/java.desktop/unix/native/libfontmanager/X11FontScaler.c:270:24: error: unused variable ‘ascent’ [-Werror=unused-variable]
>   270 | int direction, ascent, descent;
>       | ^~~~~~
> /home/ysuenaga/github-forked/jdk/src/java.desktop/unix/native/libfontmanager/X11FontScaler.c:270:13: error: unused variable ‘direction’ [-Werror=unused-variable]
>   270 | int direction, ascent, descent;
>       | ^~~~~~~~~
> /home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c: In function ‘Java_sun_font_FreetypeFontScaler_createScalerContextNative’:
> /home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c:516:19: error: unused variable ‘scalerInfo’ [-Werror=unused-variable]
>   516 | FTScalerInfo *scalerInfo =
>       | ^~~~~~~~~~
> /home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c: In function ‘Java_sun_font_FreetypeFontScaler_getGlyphPointNative’:
> /home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c:1655:13: error: unused variable ‘point’ [-Werror=unused-variable]
>  1655 | jobject point = NULL;
>       | ^~~~~

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20790#pullrequestreview-2386379644