RFR: 8342870: Errors related to unused code on Windows after 8339120 in accessibility [v2]

[Julian Waters]

On Sun, 27 Oct 2024 06:24:49 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> After 8339120, gcc began catching many different instances of unused code in the Windows specific codebase. Some of these seem to be bugs. I've taken the effort to mark out all the relevant globals and locals that trigger the unused warnings and addressed all of them by commenting out the code as appropriate. I am confident that in many cases this simplistic approach of commenting out code does not fix the underlying issue, and the warning actually found a bug that should be fixed. In these instances, I will be aiming to fix these bugs with help from reviewers, so I recommend anyone reviewing who knows more about the code than I do to see whether there is indeed a bug that needs fixing in a different way than what I did
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Remove now unused result
>  - Merge branch 'master' into accessibility
>  - 8342870

Bumping, please advise on whether the fixes are correct or not

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21656#issuecomment-2445892834