RFR: 8342098: Write a test to compare the images [v3]
Naveen Narayanan
duke at openjdk.org
Thu Oct 31 15:58:36 UTC 2024
On Wed, 30 Oct 2024 14:46:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Used the same logic as in `Util` class.
>> Added image width & height check now.
>
> I meant _using `Util.compareBufferedImages`_ rather than copying the code.
@aivanov-jdk
Definitely using Util will be simpler and lesser lines of code.
Then we will be getting a True/False as return value.
Afraid that we will have less info on pixel, color & coordinates like
`Captured pixel (fffeff00) at (0, 0) is not equal to real pixel (ffffff00)`
This being an AWT Robot test, should we add a Swing Util dependency as well?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21524#discussion_r1824726769
More information about the client-libs-dev
mailing list