RFR: 8342082: Remove unused BasicProgressBarUI.Animator.interval [v2]

[Harshitha Onkar]

On Tue, 29 Oct 2024 06:46:23 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> The field `javax.swing.plaf.basic.BasicProgressBarUI.Animator.interval` is unused and can be removed.
>
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8342082: Remove unused BasicProgressBarUI.Animator.interval
>   
>   adjust comment too

LGTM apart from the minor comments added inline.

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java line 35:

> 33: import javax.swing.event.*;
> 34: import javax.swing.plaf.*;
> 35: import java.beans.PropertyChangeListener;

Wild card imports can be expanded.

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java line 1227:

> 1225:         private long previousDelay; //used to tune the repaint interval
> 1226:         private long lastCall; //the last time actionPerformed was called
> 1227:         private int MINIMUM_DELAY = 5;

Suggestion:

        private static final int MINIMUM_DELAY = 5;

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21132#pullrequestreview-2405774374
PR Review Comment: https://git.openjdk.org/jdk/pull/21132#discussion_r1823112580
PR Review Comment: https://git.openjdk.org/jdk/pull/21132#discussion_r1825171707