From jwaters at openjdk.org  Sun Sep  1 16:33:24 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Sun, 1 Sep 2024 16:33:24 GMT
Subject: RFR: 8338768: Introduce runtime lookup to check for static builds
 [v2]
In-Reply-To: <56GIZnufresPSrWCWHPkbY9-qCGlm20L-nbXUi5DFv8=.445586cf-37dc-45ce-9b91-9d0a6c85e5ca@github.com>
References: <Qb-hEpMNtfzU9tOBdegv0PcIbXgmtKAQXVCOdhKZN7E=.73756496-0d50-4661-89d1-d4e9cf8a12d4@github.com>
 <56GIZnufresPSrWCWHPkbY9-qCGlm20L-nbXUi5DFv8=.445586cf-37dc-45ce-9b91-9d0a6c85e5ca@github.com>
Message-ID: <sl8l59-K_dTtCIlRlfwnD09JBWLYUiivU2V6hN-TSz0=.5c7e95af-4484-4a5f-8f14-f3b2e6cb5da0@github.com>

On Wed, 21 Aug 2024 22:14:40 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As a preparation for Hermetic Java, we need to have a way to look up during runtime if we are using a statically linked library or not.
>> 
>> This change will be the first step needed towards compiling the object files only once, and then link them into either dynamic or static libraries. (The only exception will be the linktype.c[pp] files, which needs to be compiled twice, once for the dynamic libraries and once for the static libraries.) Getting there will require further work though. 
>> 
>> This is part of the changes that make up the draft PR https://github.com/openjdk/jdk/pull/19478, which I have broken out.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Also update build to link properly

This does make me wonder: What if the new method for checking if the VM was statically linked was inlined? Then the problem comes back yet again as the object files need to be recompiled once more. This is possible if Link Time Optimization is switched on, and I don't like the implication that LTO might be removed as a result just to make this work

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20666#issuecomment-2323416932

From dholmes at openjdk.org  Mon Sep  2 04:12:26 2024
From: dholmes at openjdk.org (David Holmes)
Date: Mon, 2 Sep 2024 04:12:26 GMT
Subject: RFR: 8338768: Introduce runtime lookup to check for static builds
 [v2]
In-Reply-To: <sl8l59-K_dTtCIlRlfwnD09JBWLYUiivU2V6hN-TSz0=.5c7e95af-4484-4a5f-8f14-f3b2e6cb5da0@github.com>
References: <Qb-hEpMNtfzU9tOBdegv0PcIbXgmtKAQXVCOdhKZN7E=.73756496-0d50-4661-89d1-d4e9cf8a12d4@github.com>
 <56GIZnufresPSrWCWHPkbY9-qCGlm20L-nbXUi5DFv8=.445586cf-37dc-45ce-9b91-9d0a6c85e5ca@github.com>
 <sl8l59-K_dTtCIlRlfwnD09JBWLYUiivU2V6hN-TSz0=.5c7e95af-4484-4a5f-8f14-f3b2e6cb5da0@github.com>
Message-ID: <vFrL6wW1otFJIqxJxGMxlHO4qVEyxmV8mewgYMqZOcY=.e618476f-9dd5-402d-aad1-b573fe24e9d4@github.com>

On Sun, 1 Sep 2024 16:30:33 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> This does make me wonder: What if the new method for checking if the VM was statically linked was inlined? Then the problem comes back yet again as the object files need to be recompiled once more. This is possible if Link Time Optimization is switched on, and I don't like the implication that LTO might be removed as a result just to make this work

Wouldn't such link-time "inlining" only appear in the object code stored within the library, not in the original object file?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20666#issuecomment-2323775705

From jwaters at openjdk.org  Mon Sep  2 04:15:21 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Mon, 2 Sep 2024 04:15:21 GMT
Subject: RFR: 8338768: Introduce runtime lookup to check for static builds
 [v2]
In-Reply-To: <vFrL6wW1otFJIqxJxGMxlHO4qVEyxmV8mewgYMqZOcY=.e618476f-9dd5-402d-aad1-b573fe24e9d4@github.com>
References: <Qb-hEpMNtfzU9tOBdegv0PcIbXgmtKAQXVCOdhKZN7E=.73756496-0d50-4661-89d1-d4e9cf8a12d4@github.com>
 <56GIZnufresPSrWCWHPkbY9-qCGlm20L-nbXUi5DFv8=.445586cf-37dc-45ce-9b91-9d0a6c85e5ca@github.com>
 <sl8l59-K_dTtCIlRlfwnD09JBWLYUiivU2V6hN-TSz0=.5c7e95af-4484-4a5f-8f14-f3b2e6cb5da0@github.com>
 <vFrL6wW1otFJIqxJxGMxlHO4qVEyxmV8mewgYMqZOcY=.e618476f-9dd5-402d-aad1-b573fe24e9d4@github.com>
Message-ID: <I53OCnlTDqFzoRZcF1xpErSfVb7VstP8BP4vXi8YdTs=.fa34dc14-dcfc-403c-904f-acb782f2a553@github.com>

On Mon, 2 Sep 2024 04:09:19 GMT, David Holmes <dholmes at openjdk.org> wrote:

> > This does make me wonder: What if the new method for checking if the VM was statically linked was inlined? Then the problem comes back yet again as the object files need to be recompiled once more. This is possible if Link Time Optimization is switched on, and I don't like the implication that LTO might be removed as a result just to make this work
> 
> Wouldn't such link-time "inlining" only appear in the object code stored within the library, not in the original object file?

Ah, you're right, good catch. I got mixed up with the implementation details of different compilers there, sorry

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20666#issuecomment-2323778397

From abhiscxk at openjdk.org  Mon Sep  2 04:35:19 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 2 Sep 2024 04:35:19 GMT
Subject: RFR: 8308588: Unnecessary synchronized on GTKStyle#ICONS_MAP can
 be removed [v2]
In-Reply-To: <z0eadSkbxTL9KCodNZ4fy9ICNIAkx9Yci6mwAvicRwQ=.4d2d8a47-62bc-480f-9f2b-da93d2991a00@github.com>
References: <kg66eVHLCjJhmt85ISgXSBGMTYX3nVEMb-ix988mu-o=.feb17119-25ff-446d-8ca8-72dda8f9a4a9@github.com>
 <AZ6XepSyXtgVD38ddCtKpVy945LwFlemcdG1U1j8rlM=.b10b9f83-820a-455e-ba44-73ddbcf2dadf@github.com>
 <uLptjrr59L71xbBuWX6iZdYgamc0JYbMVNjnoWJRR3M=.e442f11a-76b3-4351-b632-5c718d16d4f0@github.com>
 <JQZX4zJX-Ref203woH4uqP6yD--px_mcmdal_aHM9v0=.3a72ebe0-4250-4dbd-8cf6-dc05e054959b@github.com>
 <6x-ET9JwHAubdYGbHnoAVp5FEc2VYJM4eUN5B0ReaHM=.5a6c52d7-4769-475d-9f15-9646b7a5c794@github.com>
 <z0eadSkbxTL9KCodNZ4fy9ICNIAkx9Yci6mwAvicRwQ=.4d2d8a47-62bc-480f-9f2b-da93d2991a00@github.com>
Message-ID: <WFOl88Qnc912tR8AgeiJCP8u-23pdoc8dLnyqF7m-L8=.60e58d23-b9d0-4d11-9420-5b139fdf89c6@github.com>

On Fri, 30 Aug 2024 15:14:06 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> It's possible to use `Map.of` if you put the condition as a conditional operator to each value. Yet it would make the intention less clear.

Yeah that can be done but current implementation look ok to me as well.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20741#issuecomment-2323794361

From jdv at openjdk.org  Mon Sep  2 04:51:18 2024
From: jdv at openjdk.org (Jayathirth D V)
Date: Mon, 2 Sep 2024 04:51:18 GMT
Subject: RFR: 8326027: Comparing buffered images of white background frame
 fails in Mac
In-Reply-To: <k_dehNjnRND72N061bx31c9YclyJhyL2hK1NHPJcLkE=.5a4fd4d5-ee80-4db0-bae4-4008360ead28@github.com>
References: <k_dehNjnRND72N061bx31c9YclyJhyL2hK1NHPJcLkE=.5a4fd4d5-ee80-4db0-bae4-4008360ead28@github.com>
Message-ID: <gSQ9KSCtinpLbGVp7U2spu5Clv-MLb2HD6GVakd-fJ0=.ecc226d7-9d18-4530-89a2-8a2940edae09@github.com>

On Thu, 29 Aug 2024 04:38:29 GMT, Tejesh R <tr at openjdk.org> wrote:

> On analysis of captured image, it is observed that there are few pixels which vary slightly w.r.t to expected color. Hence tolerance is included in color comparison. 
> Tested in mach5 multiple time and its green.

Why are we extending this test to be run on Mac now? Looks like it was Linux specific test.

Also Title "Comparing buffered images of white background frame fails in Mac" makes it looks like some product issue. But changes are related to a single test, if we are making single test related changes its better to have [Testbug] or test in the title instead of issue description.

This color comparison failure is happening when we are checking boundary pixels of a window or is it happening everywhere?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20760#issuecomment-2323807363

From tr at openjdk.org  Mon Sep  2 04:52:19 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 2 Sep 2024 04:52:19 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine
In-Reply-To: <Bm4f1mFK7hc8LLvgYh0Te6mDgkDwnUVlZafVe9ZSoW8=.470061f0-305e-43ac-9ef8-08ded974832d@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <i8yzigFx_G0yt0XyNSRSFdQGFPhWjo29luZLZRe2iuM=.7420cba9-ae3e-4b0a-8258-527130c08533@github.com>
 <Zrby9Utht2Zh2saS2nnYcYmz4fUE0oW0BlJ-ZC7PTDM=.1b7f3be5-8fc1-4dc4-bf06-0848b253f422@github.com>
 <Bm4f1mFK7hc8LLvgYh0Te6mDgkDwnUVlZafVe9ZSoW8=.470061f0-305e-43ac-9ef8-08ded974832d@github.com>
Message-ID: <L0Pdmu_hgWlL3qrBC4GVnEsYtbNScs-YlHUSZzdzCys=.815ea030-ee89-4c1f-88cd-e5cf2c13e166@github.com>

On Fri, 30 Aug 2024 17:40:01 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Tolerance is required when we are going with screen capture comparison since I see slight change in intensity of colors in captured image, not really sure of what might be the exact cause for it on some machines/some test runs. Also I've seen some tests considers this tolerance while testing. I confirmed it by decoding the pixel color of captured image (Below image). 
>> Coming to false positives, yes this is the trade off when the test is made automatic. I see no other way to confirm the check mark with captured image. Other option left is to make the test manual one, yet I feel this way is better than manual. I've captured several runs without the fix where the captured area will be just white background and with fix when checkmark is drawn on UI scale of 2.0 it is drawn inside the area without any other interference which might have led to false positive.
>> 
>> <img width="20" alt="image" src="https://github.com/user-attachments/assets/e84da671-0a6f-4871-a83c-0e134cd1d800">
>
> One more thing, how did you arrive to this number as the tolerance? I assume that maybe other tests also set tolerance as 10?

Yes, referenced from other test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20723#discussion_r1740320000

From tr at openjdk.org  Mon Sep  2 04:58:19 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 2 Sep 2024 04:58:19 GMT
Subject: RFR: 8326027: Comparing buffered images of white background frame
 fails in Mac
In-Reply-To: <gSQ9KSCtinpLbGVp7U2spu5Clv-MLb2HD6GVakd-fJ0=.ecc226d7-9d18-4530-89a2-8a2940edae09@github.com>
References: <k_dehNjnRND72N061bx31c9YclyJhyL2hK1NHPJcLkE=.5a4fd4d5-ee80-4db0-bae4-4008360ead28@github.com>
 <gSQ9KSCtinpLbGVp7U2spu5Clv-MLb2HD6GVakd-fJ0=.ecc226d7-9d18-4530-89a2-8a2940edae09@github.com>
Message-ID: <xVyPRG7HGeu2EF7FQsKa9pQoBBoLxCG-IPGJJUUG_hU=.0db67286-fedd-43a7-9814-d0e61e032647@github.com>

On Mon, 2 Sep 2024 04:48:54 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

> Why are we extending this test to be run on Mac now? Looks like it was Linux specific test.
> 
> Also Title "Comparing buffered images of white background frame fails in Mac" makes it looks like some product issue. But changes are related to a single test, if we are making single test related changes its better to have [Testbug] or test in the title instead of issue description.
> 
> This color comparison failure is happening when we are checking boundary pixels of a window or is it happening everywhere?

1. The product fix was linux specific, yet I guess there were review suggestions  on extending the test to other  OS. Hence while testing on other platforms few issues w.r.t OS for this test was observed and JBS was raised (For Windows - [JDK-8326026](https://bugs.openjdk.org/browse/JDK-8326026) - Mouse drag for a transparent frame fails in Windows) 
2. Will update the title.
3. Its not happening at borders, its at random places, u can refer to the image attached in JBS.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20760#issuecomment-2323813345

From tr at openjdk.org  Mon Sep  2 05:04:18 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 2 Sep 2024 05:04:18 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine
In-Reply-To: <vqvjJ17r3K_phaeKMjG3Mjq5qHimppDZvFi2hMXPMz8=.2ae2401e-a2ca-487b-a742-e414e24e2c97@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <vqvjJ17r3K_phaeKMjG3Mjq5qHimppDZvFi2hMXPMz8=.2ae2401e-a2ca-487b-a742-e414e24e2c97@github.com>
Message-ID: <dSQoiArzu8zW6n702kGwLgSEC0ACe5Jr_BDS0TIKFj8=.26ce0264-806c-4e5c-a835-ff9fec8fccd1@github.com>

On Wed, 28 Aug 2024 04:24:56 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rather than left top.
>> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.
>
> @TejeshR13 Did you check the current changes on CI system? Did you observe any failure on the particular machine where it failed in CI?

> As @kumarabhi006 and @alisenchung pointed out I think there might be cases of false positives with high tolerance values.
> 
> Following are couple of suggestions:
> 
> * Check if a lower more optimal value of tolerance works.
> * Continue pixel compare till you encounter 4-5 pixels of the expected color (with tolerance)
> * Adding debug logs to see which colors pass the criteria.

Checking for optimal value based on collected color samples as others mentioned might not be of much use here. But as u mentioned here we can merge both the technique along with tolerance to do that. 
How debug logs would help in analysis?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20723#issuecomment-2323818865

From jdv at openjdk.org  Mon Sep  2 05:06:18 2024
From: jdv at openjdk.org (Jayathirth D V)
Date: Mon, 2 Sep 2024 05:06:18 GMT
Subject: RFR: 8326027: Comparing buffered images of white background frame
 fails in Mac
In-Reply-To: <xVyPRG7HGeu2EF7FQsKa9pQoBBoLxCG-IPGJJUUG_hU=.0db67286-fedd-43a7-9814-d0e61e032647@github.com>
References: <k_dehNjnRND72N061bx31c9YclyJhyL2hK1NHPJcLkE=.5a4fd4d5-ee80-4db0-bae4-4008360ead28@github.com>
 <gSQ9KSCtinpLbGVp7U2spu5Clv-MLb2HD6GVakd-fJ0=.ecc226d7-9d18-4530-89a2-8a2940edae09@github.com>
 <xVyPRG7HGeu2EF7FQsKa9pQoBBoLxCG-IPGJJUUG_hU=.0db67286-fedd-43a7-9814-d0e61e032647@github.com>
Message-ID: <2gNF0CA-Uc1RQnpD1zSzQ-MB_ZmeKbqQ8PXzR3j4uFI=.f32ee857-b705-4169-b3ea-d96dffbd5b28@github.com>

On Mon, 2 Sep 2024 04:55:58 GMT, Tejesh R <tr at openjdk.org> wrote:

> > Why are we extending this test to be run on Mac now? Looks like it was Linux specific test.
> > Also Title "Comparing buffered images of white background frame fails in Mac" makes it looks like some product issue. But changes are related to a single test, if we are making single test related changes its better to have [Testbug] or test in the title instead of issue description.
> > This color comparison failure is happening when we are checking boundary pixels of a window or is it happening everywhere?
> 
>     1. The product fix was linux specific, yet I guess there were review suggestions  on extending the test to other  OS. Hence while testing on other platforms few issues w.r.t OS for this test was observed and JBS was raised (For Windows - [JDK-8326026](https://bugs.openjdk.org/browse/JDK-8326026) - Mouse drag for a transparent frame fails in Windows)
> 
>     2. Will update the title.
> 
>     3. Its not happening at borders, its at random places, u can refer to the image attached in JBS.

Please share product fix for which the original test update was done.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20760#issuecomment-2323820032

From tr at openjdk.org  Mon Sep  2 05:09:18 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 2 Sep 2024 05:09:18 GMT
Subject: RFR: 8326027: Comparing buffered images of white background frame
 fails in Mac
In-Reply-To: <2gNF0CA-Uc1RQnpD1zSzQ-MB_ZmeKbqQ8PXzR3j4uFI=.f32ee857-b705-4169-b3ea-d96dffbd5b28@github.com>
References: <k_dehNjnRND72N061bx31c9YclyJhyL2hK1NHPJcLkE=.5a4fd4d5-ee80-4db0-bae4-4008360ead28@github.com>
 <gSQ9KSCtinpLbGVp7U2spu5Clv-MLb2HD6GVakd-fJ0=.ecc226d7-9d18-4530-89a2-8a2940edae09@github.com>
 <xVyPRG7HGeu2EF7FQsKa9pQoBBoLxCG-IPGJJUUG_hU=.0db67286-fedd-43a7-9814-d0e61e032647@github.com>
 <2gNF0CA-Uc1RQnpD1zSzQ-MB_ZmeKbqQ8PXzR3j4uFI=.f32ee857-b705-4169-b3ea-d96dffbd5b28@github.com>
Message-ID: <D1mPXnNPb0v0MCPfFZcfUV4vUZ8vvrb6NYVUnon73Oc=.c8553c47-0e77-420e-abab-2e2471d291c7@github.com>

On Mon, 2 Sep 2024 05:03:25 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

> > > Why are we extending this test to be run on Mac now? Looks like it was Linux specific test.
> > > Also Title "Comparing buffered images of white background frame fails in Mac" makes it looks like some product issue. But changes are related to a single test, if we are making single test related changes its better to have [Testbug] or test in the title instead of issue description.
> > > This color comparison failure is happening when we are checking boundary pixels of a window or is it happening everywhere?
> > 
> > 
> > ```
> > 1. The product fix was linux specific, yet I guess there were review suggestions  on extending the test to other  OS. Hence while testing on other platforms few issues w.r.t OS for this test was observed and JBS was raised (For Windows - [JDK-8326026](https://bugs.openjdk.org/browse/JDK-8326026) - Mouse drag for a transparent frame fails in Windows)
> > 
> > 2. Will update the title.
> > 
> > 3. Its not happening at borders, its at random places, u can refer to the image attached in JBS.
> > ```
> 
> Please share product fix for which the original test update was done.

JBS - [JDK-8187759](https://bugs.openjdk.org/browse/JDK-8187759): Background not refreshed when painting over a transparent JFrame
PR - https://github.com/openjdk/jdk/pull/17081

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20760#issuecomment-2323822709

From tr at openjdk.org  Mon Sep  2 05:17:26 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 2 Sep 2024 05:17:26 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine
In-Reply-To: <qpHqg_8nTSSzAdzwjANK672ju1x9fd3eRF8_bvXamJ4=.2d65ea32-ad57-4a64-9c06-d3bca6350e60@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <qpHqg_8nTSSzAdzwjANK672ju1x9fd3eRF8_bvXamJ4=.2d65ea32-ad57-4a64-9c06-d3bca6350e60@github.com>
Message-ID: <wbsdqxvBH7ROBbZM2RUENJdWtPtW3zNpCtE0Iw3sTr4=.adf40d96-56cd-49af-98fd-3c1f3b77a0e6@github.com>

On Fri, 30 Aug 2024 18:22:56 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rather than left top.
>> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.
>
> test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 80:
> 
>> 78:                             if (compareColor(pixelColor)) {
>> 79:                                 checkmarkFound = true;
>> 80:                                 break check;
> 
> @TejeshR13 Logging the pixelColor inside the if block can be useful for debugging purpose.
> You could add a counter variable here and continue until 4-5 pixels match the criteria.

On failure we are saving the image, I don't think logging pixelColor would add any additional help in debugging here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20723#discussion_r1740333346

From aturbanov at openjdk.org  Mon Sep  2 07:49:21 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Mon, 2 Sep 2024 07:49:21 GMT
Subject: RFR: 8308588: Unnecessary synchronized on GTKStyle#ICONS_MAP can
 be removed [v2]
In-Reply-To: <GlDWyHUDU0NHHoghHMsa5FfTXQhPfd8-3HayoFTmito=.30b694f8-6ef9-4bd3-bf84-5ab28ab3eefa@github.com>
References: <kg66eVHLCjJhmt85ISgXSBGMTYX3nVEMb-ix988mu-o=.feb17119-25ff-446d-8ca8-72dda8f9a4a9@github.com>
 <GlDWyHUDU0NHHoghHMsa5FfTXQhPfd8-3HayoFTmito=.30b694f8-6ef9-4bd3-bf84-5ab28ab3eefa@github.com>
Message-ID: <3l4aLrCERUAi4fhjnWZoHLazyjJYdv5kPRasZICI2AU=.fc5b9938-006a-4873-9875-2df0ae8f2bd5@github.com>

On Fri, 30 Aug 2024 04:57:56 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> `static final Map<String,GTKStockIcon> ICONS_MAP` is modified only in `static` block. Then [com.sun.java.swing.plaf.gtk.GTKStyle#get](https://github.com/kumarabhi006/jdk/blob/73f7a5f15dbba54a98f3916ff1190520ac07874d/src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java#L892) method read from it within `synchronized (ICONS_MAP)` block. As this map is read-only and all its content is initialized in static block we can safely remove synchronized from get call.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use Collections.unmodifiableMap and remove blank line

Marked as reviewed by aturbanov (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20741#pullrequestreview-2274913088

From ihse at openjdk.org  Mon Sep  2 09:17:28 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Mon, 2 Sep 2024 09:17:28 GMT
Subject: Integrated: 8338768: Introduce runtime lookup to check for static
 builds
In-Reply-To: <Qb-hEpMNtfzU9tOBdegv0PcIbXgmtKAQXVCOdhKZN7E=.73756496-0d50-4661-89d1-d4e9cf8a12d4@github.com>
References: <Qb-hEpMNtfzU9tOBdegv0PcIbXgmtKAQXVCOdhKZN7E=.73756496-0d50-4661-89d1-d4e9cf8a12d4@github.com>
Message-ID: <7ZCNx3fBoTkmUDxGYAcN6eqygCSF-kxH3vBPSczQqaA=.85487425-1e4f-4496-92f7-92d7a6d69156@github.com>

On Wed, 21 Aug 2024 21:53:39 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> As a preparation for Hermetic Java, we need to have a way to look up during runtime if we are using a statically linked library or not.
> 
> This change will be the first step needed towards compiling the object files only once, and then link them into either dynamic or static libraries. (The only exception will be the linktype.c[pp] files, which needs to be compiled twice, once for the dynamic libraries and once for the static libraries.) Getting there will require further work though. 
> 
> This is part of the changes that make up the draft PR https://github.com/openjdk/jdk/pull/19478, which I have broken out.

This pull request has now been integrated.

Changeset: a136a85b
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a136a85b6f5bbc92727883693c1ce31c37a82fd5
Stats:     205 lines in 12 files changed: 109 ins; 21 del; 75 mod

8338768: Introduce runtime lookup to check for static builds

Co-authored-by: Magnus Ihse Bursie <ihse at openjdk.org>
Co-authored-by: Jiangli Zhou <jiangli at openjdk.org>
Reviewed-by: prr, jiangli, alanb

-------------

PR: https://git.openjdk.org/jdk/pull/20666

From aivanov at openjdk.org  Mon Sep  2 11:45:20 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 2 Sep 2024 11:45:20 GMT
Subject: RFR: 8326027: Comparing buffered images of white background frame
 fails in Mac
In-Reply-To: <2gNF0CA-Uc1RQnpD1zSzQ-MB_ZmeKbqQ8PXzR3j4uFI=.f32ee857-b705-4169-b3ea-d96dffbd5b28@github.com>
References: <k_dehNjnRND72N061bx31c9YclyJhyL2hK1NHPJcLkE=.5a4fd4d5-ee80-4db0-bae4-4008360ead28@github.com>
 <gSQ9KSCtinpLbGVp7U2spu5Clv-MLb2HD6GVakd-fJ0=.ecc226d7-9d18-4530-89a2-8a2940edae09@github.com>
 <xVyPRG7HGeu2EF7FQsKa9pQoBBoLxCG-IPGJJUUG_hU=.0db67286-fedd-43a7-9814-d0e61e032647@github.com>
 <2gNF0CA-Uc1RQnpD1zSzQ-MB_ZmeKbqQ8PXzR3j4uFI=.f32ee857-b705-4169-b3ea-d96dffbd5b28@github.com>
Message-ID: <qg6dyGlkXHzCaAEwgmlcbT7pxXk4zCoDEW1gk3idLR8=.24f4403c-29dd-437c-a449-405fc220b635@github.com>

On Mon, 2 Sep 2024 05:03:25 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>>> Why are we extending this test to be run on Mac now? Looks like it was Linux specific test.
>>> 
>>> Also Title "Comparing buffered images of white background frame fails in Mac" makes it looks like some product issue. But changes are related to a single test, if we are making single test related changes its better to have [Testbug] or test in the title instead of issue description.
>>> 
>>> This color comparison failure is happening when we are checking boundary pixels of a window or is it happening everywhere?
>> 
>> 1. The product fix was linux specific, yet I guess there were review suggestions  on extending the test to other  OS. Hence while testing on other platforms few issues w.r.t OS for this test was observed and JBS was raised (For Windows - [JDK-8326026](https://bugs.openjdk.org/browse/JDK-8326026) - Mouse drag for a transparent frame fails in Windows) 
>> 2. Will update the title.
>> 3. Its not happening at borders, its at random places, u can refer to the image attached in JBS.
>
>> > Why are we extending this test to be run on Mac now? Looks like it was Linux specific test.
>> > Also Title "Comparing buffered images of white background frame fails in Mac" makes it looks like some product issue. But changes are related to a single test, if we are making single test related changes its better to have [Testbug] or test in the title instead of issue description.
>> > This color comparison failure is happening when we are checking boundary pixels of a window or is it happening everywhere?
>> 
>>     1. The product fix was linux specific, yet I guess there were review suggestions  on extending the test to other  OS. Hence while testing on other platforms few issues w.r.t OS for this test was observed and JBS was raised (For Windows - [JDK-8326026](https://bugs.openjdk.org/browse/JDK-8326026) - Mouse drag for a transparent frame fails in Windows)
>> 
>>     2. Will update the title.
>> 
>>     3. Its not happening at borders, its at random places, u can refer to the image attached in JBS.
> 
> Please share product fix for which the original test update was done.

@jayathirthrao  It looks as if image comparison is a common issue on macOS, tolerance is usually added for macOS.

Sometimes colour difference is because of a color profile used; that's why the guidelines recommend setting the same common profile on all the test systems.

I suspect the other reason is because of High DPI (Retina) displays on Macs. Yet it has never been confirmed or disconfirmed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20760#issuecomment-2324545326

From mbaesken at openjdk.org  Mon Sep  2 11:48:48 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Mon, 2 Sep 2024 11:48:48 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and function
 warnings
Message-ID: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>

We get a couple of warnings as errors on AIX because of unused variables or functions , for example :
/priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10: error: unused variable 'exePath' [-Werror,-Wunused-variable]
    char exePath[PATH_MAX];
         ^
/priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:668:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
    int ret;
        ^
/priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:664:10: error: unused variable 'fn' [-Werror,-Wunused-variable]
    char fn[32];
         ^

This seems to be related to the recent make changes
8339156: Use more fine-granular clang unused warnings
https://bugs.openjdk.org/browse/JDK-8339156
(we use clang too on AIX)

-------------

Commit messages:
 - JDK-8339364

Changes: https://git.openjdk.org/jdk/pull/20812/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20812&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339364
  Stats: 61 lines in 14 files changed: 9 ins; 36 del; 16 mod
  Patch: https://git.openjdk.org/jdk/pull/20812.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20812/head:pull/20812

PR: https://git.openjdk.org/jdk/pull/20812

From aivanov at openjdk.org  Mon Sep  2 11:50:19 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 2 Sep 2024 11:50:19 GMT
Subject: RFR: 8326027: Comparing buffered images of white background frame
 fails in Mac
In-Reply-To: <k_dehNjnRND72N061bx31c9YclyJhyL2hK1NHPJcLkE=.5a4fd4d5-ee80-4db0-bae4-4008360ead28@github.com>
References: <k_dehNjnRND72N061bx31c9YclyJhyL2hK1NHPJcLkE=.5a4fd4d5-ee80-4db0-bae4-4008360ead28@github.com>
Message-ID: <cz60nGqUy8w7rPIXAixOMj3kInPiDxZAQTr5rrFTVf0=.15cb3c41-bad1-4f56-a5a8-097587684798@github.com>

On Thu, 29 Aug 2024 04:38:29 GMT, Tejesh R <tr at openjdk.org> wrote:

> On analysis of captured image, it is observed that there are few pixels which vary slightly w.r.t to expected color. Hence tolerance is included in color comparison. 
> Tested in mach5 multiple time and its green.

> JBS - [JDK-8187759](https://bugs.openjdk.org/browse/JDK-8187759): Background not refreshed when painting over a transparent JFrame
> PR - #17081

I linked the bugs in JBS and added a comment to JDK-8187759.

You could've and should've added these additional details to the bug description. I mean that it was discovered while you were working on another issue.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20760#issuecomment-2324556367

From clanger at openjdk.org  Mon Sep  2 12:20:20 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Mon, 2 Sep 2024 12:20:20 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings
In-Reply-To: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
Message-ID: <21Qc2WxZ7rcyk2WSogCUe3L2ZMbctnz7QF7XdorWFn0=.6b90a395-9f9b-4408-a05f-abb0e5008b72@github.com>

On Mon, 2 Sep 2024 11:43:20 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> We get a couple of warnings as errors on AIX because of unused variables or functions , for example :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10: error: unused variable 'exePath' [-Werror,-Wunused-variable]
>     char exePath[PATH_MAX];
>          ^
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:668:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
>     int ret;
>         ^
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:664:10: error: unused variable 'fn' [-Werror,-Wunused-variable]
>     char fn[32];
>          ^
> 
> This seems to be related to the recent make changes
> 8339156: Use more fine-granular clang unused warnings
> https://bugs.openjdk.org/browse/JDK-8339156
> (we use clang too on AIX)

Looks good and seems like the warning helped to clean out coding in a few places.

src/java.desktop/unix/native/common/awt/X11Color.c line 1236:

> 1234:     for (int i = 0; i < num_colors; i++)
> 1235:         alloc_col (awt_display, awtData->awt_cmap, red (rgbColors [i]),
> 1236:                      green (rgbColors [i]), blue (rgbColors [i]), -1,

Seems like indentation here could be improved a bit.

-------------

Marked as reviewed by clanger (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20812#pullrequestreview-2275486151
PR Review Comment: https://git.openjdk.org/jdk/pull/20812#discussion_r1740824222

From jwaters at openjdk.org  Mon Sep  2 12:36:20 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Mon, 2 Sep 2024 12:36:20 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings
In-Reply-To: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
Message-ID: <3fqsUh2hpNUSuZdV5ABE_B39ETgruLRO5jnEYzWAN18=.b8d42416-3e95-46ff-beac-545bad8207ef@github.com>

On Mon, 2 Sep 2024 11:43:20 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> We get a couple of warnings as errors on AIX because of unused variables or functions , for example :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10: error: unused variable 'exePath' [-Werror,-Wunused-variable]
>     char exePath[PATH_MAX];
>          ^
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:668:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
>     int ret;
>         ^
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:664:10: error: unused variable 'fn' [-Werror,-Wunused-variable]
>     char fn[32];
>          ^
> 
> This seems to be related to the recent make changes
> 8339156: Use more fine-granular clang unused warnings
> https://bugs.openjdk.org/browse/JDK-8339156
> (we use clang too on AIX)

Ah, the joys of supporting a platform that isn't covered by the Actions compile and test safety net :)

Looks Good, with that aside

-------------

Marked as reviewed by jwaters (Committer).

PR Review: https://git.openjdk.org/jdk/pull/20812#pullrequestreview-2275532558

From mbaesken at openjdk.org  Mon Sep  2 12:36:20 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Mon, 2 Sep 2024 12:36:20 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings
In-Reply-To: <3fqsUh2hpNUSuZdV5ABE_B39ETgruLRO5jnEYzWAN18=.b8d42416-3e95-46ff-beac-545bad8207ef@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
 <3fqsUh2hpNUSuZdV5ABE_B39ETgruLRO5jnEYzWAN18=.b8d42416-3e95-46ff-beac-545bad8207ef@github.com>
Message-ID: <rblaDQEkoGH2wggNxqD9RVrHxFMH4r-PzK3Rs5vu8iY=.160fb332-afb7-4596-839d-8f3e72b66218@github.com>

On Mon, 2 Sep 2024 12:30:43 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Ah, the joys of supporting a platform that isn't covered by the Actions compile and test safety net :)

A Linux/clang build in the GHA would have probably shown at least a part of those errors.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20812#issuecomment-2324651948

From mbaesken at openjdk.org  Mon Sep  2 13:25:51 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Mon, 2 Sep 2024 13:25:51 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v2]
In-Reply-To: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
Message-ID: <THmGrAyWicjbdHxgsFNcUQpzcN8mn4jom_fkjktQZ2M=.eff582ce-5f14-445c-98ff-6b8fb850e459@github.com>

> We get a couple of warnings as errors on AIX because of unused variables or functions , for example :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10: error: unused variable 'exePath' [-Werror,-Wunused-variable]
>     char exePath[PATH_MAX];
>          ^
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:668:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
>     int ret;
>         ^
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:664:10: error: unused variable 'fn' [-Werror,-Wunused-variable]
>     char fn[32];
>          ^
> 
> This seems to be related to the recent make changes
> 8339156: Use more fine-granular clang unused warnings
> https://bugs.openjdk.org/browse/JDK-8339156
> (we use clang too on AIX)

Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:

  adjust indentation in X11Color.c

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20812/files
  - new: https://git.openjdk.org/jdk/pull/20812/files/0fca9ee0..082e6f60

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20812&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20812&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20812.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20812/head:pull/20812

PR: https://git.openjdk.org/jdk/pull/20812

From mbaesken at openjdk.org  Mon Sep  2 13:25:51 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Mon, 2 Sep 2024 13:25:51 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings
In-Reply-To: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
Message-ID: <vbj9c3LpVYYG2GLjA7N4HgzKqztoy0igl_xvgFGUqPw=.a6b60be8-47df-4eb8-8704-81fc50ecc57a@github.com>

On Mon, 2 Sep 2024 11:43:20 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> We get a couple of warnings as errors on AIX because of unused variables or functions , for example :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10: error: unused variable 'exePath' [-Werror,-Wunused-variable]
>     char exePath[PATH_MAX];
>          ^
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:668:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
>     int ret;
>         ^
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:664:10: error: unused variable 'fn' [-Werror,-Wunused-variable]
>     char fn[32];
>          ^
> 
> This seems to be related to the recent make changes
> 8339156: Use more fine-granular clang unused warnings
> https://bugs.openjdk.org/browse/JDK-8339156
> (we use clang too on AIX)

macos-aarch64 failure seems to be https://bugs.openjdk.org/browse/JDK-8338712 (unrelated)

Hi Christoph and Julian, thanks for the reviews !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20812#issuecomment-2324745071
PR Comment: https://git.openjdk.org/jdk/pull/20812#issuecomment-2324752339

From mbaesken at openjdk.org  Mon Sep  2 13:25:51 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Mon, 2 Sep 2024 13:25:51 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v2]
In-Reply-To: <21Qc2WxZ7rcyk2WSogCUe3L2ZMbctnz7QF7XdorWFn0=.6b90a395-9f9b-4408-a05f-abb0e5008b72@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
 <21Qc2WxZ7rcyk2WSogCUe3L2ZMbctnz7QF7XdorWFn0=.6b90a395-9f9b-4408-a05f-abb0e5008b72@github.com>
Message-ID: <InkisUA7qXB26MpQ1oZfmlqkAYw9AZftlkVIqCiP_3c=.5ffff1a8-6169-4cb4-a2fb-f74d03dd0132@github.com>

On Mon, 2 Sep 2024 12:17:57 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   adjust indentation in X11Color.c
>
> src/java.desktop/unix/native/common/awt/X11Color.c line 1236:
> 
>> 1234:     for (int i = 0; i < num_colors; i++)
>> 1235:         alloc_col (awt_display, awtData->awt_cmap, red (rgbColors [i]),
>> 1236:                      green (rgbColors [i]), blue (rgbColors [i]), -1,
> 
> Seems like indentation here could be improved a bit.

Agree, I adjust this in another commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20812#discussion_r1740919406

From ngubarkov at openjdk.org  Mon Sep  2 18:53:54 2024
From: ngubarkov at openjdk.org (Nikita Gubarkov)
Date: Mon, 2 Sep 2024 18:53:54 GMT
Subject: RFR: 8339341: SurfaceManager cacheMap retains strong references
Message-ID: <1ecWvJLiG54e0saEz_Jjz46gzxXnqsNDagdPQ3y_BN4=.27116e44-886b-405f-9d87-ec5e82e2fd20@github.com>

I moved SurfaceDataProxy cache into a separate class.
Now caching level is determined by placement of the SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" proxies and therefore strong refs via them do not prevent the cache and GraphicsConfig from being detected as weakly reachable.

-------------

Commit messages:
 - 8339341: Make SurfaceDataProxy cache a separate entity.

Changes: https://git.openjdk.org/jdk/pull/20825/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20825&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339341
  Stats: 173 lines in 17 files changed: 55 ins; 55 del; 63 mod
  Patch: https://git.openjdk.org/jdk/pull/20825.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20825/head:pull/20825

PR: https://git.openjdk.org/jdk/pull/20825

From mdoerr at openjdk.org  Mon Sep  2 20:11:18 2024
From: mdoerr at openjdk.org (Martin Doerr)
Date: Mon, 2 Sep 2024 20:11:18 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v2]
In-Reply-To: <THmGrAyWicjbdHxgsFNcUQpzcN8mn4jom_fkjktQZ2M=.eff582ce-5f14-445c-98ff-6b8fb850e459@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
 <THmGrAyWicjbdHxgsFNcUQpzcN8mn4jom_fkjktQZ2M=.eff582ce-5f14-445c-98ff-6b8fb850e459@github.com>
Message-ID: <ZcUB9uh3AjUhPp4M2MtgtwaId7ll5btcXcA9HJRHv_8=.8bab8619-163c-41fb-94ba-c1f06abd9862@github.com>

On Mon, 2 Sep 2024 13:25:51 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> We get a couple of warnings as errors on AIX because of unused variables or functions , for example :
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10: error: unused variable 'exePath' [-Werror,-Wunused-variable]
>>     char exePath[PATH_MAX];
>>          ^
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:668:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
>>     int ret;
>>         ^
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:664:10: error: unused variable 'fn' [-Werror,-Wunused-variable]
>>     char fn[32];
>>          ^
>> 
>> This seems to be related to the recent make changes
>> 8339156: Use more fine-granular clang unused warnings
>> https://bugs.openjdk.org/browse/JDK-8339156
>> (we use clang too on AIX)
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adjust indentation in X11Color.c

LGTM. Only minor nits.

src/java.base/unix/native/libjava/TimeZone_md.c line 63:

> 61: static const char *ETC_ENVIRONMENT_FILE = "/etc/environment";
> 62: #else
> 63: static char *isFileIdentical(char* buf, size_t size, char *pathname);

I think it should better be moved below `#if defined(__linux__) || defined(MACOSX)` instead of creating an else case.

src/java.desktop/unix/native/common/awt/X11Color.c line 1234:

> 1232: awt_allocate_systemrgbcolors (jint *rgbColors, int num_colors,
> 1233:                               AwtGraphicsConfigDataPtr awtData) {
> 1234:     for (int i = 0; i < num_colors; i++)

This requires C99. Is this ok for all platforms with all supported compilers?

-------------

PR Review: https://git.openjdk.org/jdk/pull/20812#pullrequestreview-2276121217
PR Review Comment: https://git.openjdk.org/jdk/pull/20812#discussion_r1741226250
PR Review Comment: https://git.openjdk.org/jdk/pull/20812#discussion_r1741228253

From ihse at openjdk.org  Mon Sep  2 22:35:19 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Mon, 2 Sep 2024 22:35:19 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v2]
In-Reply-To: <ZcUB9uh3AjUhPp4M2MtgtwaId7ll5btcXcA9HJRHv_8=.8bab8619-163c-41fb-94ba-c1f06abd9862@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
 <THmGrAyWicjbdHxgsFNcUQpzcN8mn4jom_fkjktQZ2M=.eff582ce-5f14-445c-98ff-6b8fb850e459@github.com>
 <ZcUB9uh3AjUhPp4M2MtgtwaId7ll5btcXcA9HJRHv_8=.8bab8619-163c-41fb-94ba-c1f06abd9862@github.com>
Message-ID: <WKo4vV3Ao-mscoUBVy70CoxIn70Lr9u2lDSXwxkJaeg=.0e17dfa0-edc6-4d1f-b1e3-3ca19c87f37b@github.com>

On Mon, 2 Sep 2024 20:06:06 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   adjust indentation in X11Color.c
>
> src/java.desktop/unix/native/common/awt/X11Color.c line 1234:
> 
>> 1232: awt_allocate_systemrgbcolors (jint *rgbColors, int num_colors,
>> 1233:                               AwtGraphicsConfigDataPtr awtData) {
>> 1234:     for (int i = 0; i < num_colors; i++)
> 
> This requires C99. Is this ok for all platforms with all supported compilers?

Yes, we have C11 as minimum for the JDK.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20812#discussion_r1741270798

From ihse at openjdk.org  Mon Sep  2 22:35:20 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Mon, 2 Sep 2024 22:35:20 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v2]
In-Reply-To: <THmGrAyWicjbdHxgsFNcUQpzcN8mn4jom_fkjktQZ2M=.eff582ce-5f14-445c-98ff-6b8fb850e459@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
 <THmGrAyWicjbdHxgsFNcUQpzcN8mn4jom_fkjktQZ2M=.eff582ce-5f14-445c-98ff-6b8fb850e459@github.com>
Message-ID: <igLjFMZwZr-pJiYzZ5E9qFrMAOD66Lvzxi7SNHELyxA=.c4256988-3ae9-43eb-b599-c1a290c22bea@github.com>

On Mon, 2 Sep 2024 13:25:51 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> We get a couple of warnings as errors on AIX because of unused variables or functions , for example :
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10: error: unused variable 'exePath' [-Werror,-Wunused-variable]
>>     char exePath[PATH_MAX];
>>          ^
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:668:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
>>     int ret;
>>         ^
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:664:10: error: unused variable 'fn' [-Werror,-Wunused-variable]
>>     char fn[32];
>>          ^
>> 
>> This seems to be related to the recent make changes
>> 8339156: Use more fine-granular clang unused warnings
>> https://bugs.openjdk.org/browse/JDK-8339156
>> (we use clang too on AIX)
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adjust indentation in X11Color.c

src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c line 744:

> 742:     int rslt = pthread_attr_init(&attr);
> 743:     if (rslt != 0) return;
> 744:     pthread_create(&thr, &attr, SplashScreenThread, (void *) splash);

You don't think it would be better to check the return code?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20812#discussion_r1741271285

From azvegint at openjdk.org  Tue Sep  3 01:34:33 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 3 Sep 2024 01:34:33 GMT
Subject: RFR: 8190329: [macos] Swing InterOp Platform.exit() crash [v4]
In-Reply-To: <jkEJR7IkmzgbAgs0x0F-AzRCGJpPhF_vgCSwyormSF0=.5b6a3fb0-b5ad-4e97-92dd-eb64c8aaa986@github.com>
References: <RCXUBPtPMfsezzJli2ifzPT-uLkePnX8JA403l90N-U=.f674e497-01ad-4928-a84e-b47eaedaeb0a@github.com>
 <jkEJR7IkmzgbAgs0x0F-AzRCGJpPhF_vgCSwyormSF0=.5b6a3fb0-b5ad-4e97-92dd-eb64c8aaa986@github.com>
Message-ID: <3ez6tcjKXEg8qL_WtK2PJwItVYQXGLE10BtQsCqr7h4=.ceea8f93-9273-46f2-9c18-68e013a7d714@github.com>

On Fri, 30 Aug 2024 07:23:54 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> The testcase calls Platform.exit before the dialog is made visible but
>> on macOS, JavaFX takes over the AppKit thread and uses that as the FX application thread. As part of the FX platform shutdown process, it detaches that thread from the JVM. This means that the AppKit thread is no longer available to Java processes
>> so AWT crashes when it ties to access appkit thread.
>> Fix is made to check if the thread has been detached for move-resize notification event before proceeding..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use cached Env only for AWT NSApplication and not for Override-delegate

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20688#pullrequestreview-2276266985

From dholmes at openjdk.org  Tue Sep  3 02:28:18 2024
From: dholmes at openjdk.org (David Holmes)
Date: Tue, 3 Sep 2024 02:28:18 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v2]
In-Reply-To: <igLjFMZwZr-pJiYzZ5E9qFrMAOD66Lvzxi7SNHELyxA=.c4256988-3ae9-43eb-b599-c1a290c22bea@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
 <THmGrAyWicjbdHxgsFNcUQpzcN8mn4jom_fkjktQZ2M=.eff582ce-5f14-445c-98ff-6b8fb850e459@github.com>
 <igLjFMZwZr-pJiYzZ5E9qFrMAOD66Lvzxi7SNHELyxA=.c4256988-3ae9-43eb-b599-c1a290c22bea@github.com>
Message-ID: <VcGVewtYspnLN09mP5vNhRjKpd_8cpcCndhyPmdaJCI=.af4869cc-b281-498f-9eda-009872be3a47@github.com>

On Mon, 2 Sep 2024 22:32:34 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   adjust indentation in X11Color.c
>
> src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c line 744:
> 
>> 742:     int rslt = pthread_attr_init(&attr);
>> 743:     if (rslt != 0) return;
>> 744:     pthread_create(&thr, &attr, SplashScreenThread, (void *) splash);
> 
> You don't think it would be better to check the return code?

This code is devoid of pretty much all error handling and logging, but I agree that a simple fprintf on error would be useful.
Also doesn't a call like this trigger the warning about ignoring a function result, or have we disabled that one?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20812#discussion_r1741354811

From abhiscxk at openjdk.org  Tue Sep  3 05:50:00 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 3 Sep 2024 05:50:00 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v2]
In-Reply-To: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
Message-ID: <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>

> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
> Test removed from `Problem-list` file as well.
> 
> CI testing link is posted in JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Remove secondaryloop code

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20791/files
  - new: https://git.openjdk.org/jdk/pull/20791/files/797c8868..e1f9c9c5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20791&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20791&range=00-01

  Stats: 143 lines in 1 file changed: 53 ins; 59 del; 31 mod
  Patch: https://git.openjdk.org/jdk/pull/20791.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20791/head:pull/20791

PR: https://git.openjdk.org/jdk/pull/20791

From abhiscxk at openjdk.org  Tue Sep  3 05:50:00 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 3 Sep 2024 05:50:00 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v2]
In-Reply-To: <oQvmpcoZGdVPOsjtO-HoKQ1vbiIdrrjqLIK4efuXOT0=.de527fd2-804e-4e92-9ff6-fe09a7df3206@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <oQvmpcoZGdVPOsjtO-HoKQ1vbiIdrrjqLIK4efuXOT0=.de527fd2-804e-4e92-9ff6-fe09a7df3206@github.com>
Message-ID: <jKhIcWj7KvcnJGzWA18bcE2GyI0mvmH_GSizMVOdqMU=.7abdf079-5301-457b-ab90-f8623cd71976@github.com>

On Sat, 31 Aug 2024 00:48:12 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> I'm not sure if the SecondaryLoop code is required for this test or it can be simplified?

I have tried simplifying the test code and removed SecondaryLoop code. Tested the current changes in CI across all platforms and no failure observed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2325651191

From abhiscxk at openjdk.org  Tue Sep  3 05:53:19 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 3 Sep 2024 05:53:19 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v2]
In-Reply-To: <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>
Message-ID: <xuCE9i0TAgJ_6GhuKg39irMUjJVzXF16TxlEXnWoY9M=.0ed23206-1abc-4d36-92fd-04ed2f541421@github.com>

On Tue, 3 Sep 2024 05:50:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
>> Test removed from `Problem-list` file as well.
>> 
>> CI testing link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove secondaryloop code

@prsadhuk As we were discussing about the test change and removal of SecondaryLoop change, I tested the current changes without the fix proposed in [JDK-8007563](https://bugs.openjdk.org/browse/JDK-8007563) and test failed which is correct. After applying the fix, test is able to pass.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2325654807

From ihse at openjdk.org  Tue Sep  3 05:55:18 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 3 Sep 2024 05:55:18 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v2]
In-Reply-To: <VcGVewtYspnLN09mP5vNhRjKpd_8cpcCndhyPmdaJCI=.af4869cc-b281-498f-9eda-009872be3a47@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
 <THmGrAyWicjbdHxgsFNcUQpzcN8mn4jom_fkjktQZ2M=.eff582ce-5f14-445c-98ff-6b8fb850e459@github.com>
 <igLjFMZwZr-pJiYzZ5E9qFrMAOD66Lvzxi7SNHELyxA=.c4256988-3ae9-43eb-b599-c1a290c22bea@github.com>
 <VcGVewtYspnLN09mP5vNhRjKpd_8cpcCndhyPmdaJCI=.af4869cc-b281-498f-9eda-009872be3a47@github.com>
Message-ID: <1YazhBzFJBBSy6KnqHuWOBFYfBQgx2ObU5WNlgb97J8=.8015a1da-4780-4738-88fd-886b75bee195@github.com>

On Tue, 3 Sep 2024 02:25:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Also doesn't a call like this trigger the warning about ignoring a function result, or have we disabled that one?

Such a warning would be horrible to have enable. Then you would have to read the value of every function that thought it should return a value, even if it was just intended as some additional information that perhaps not everyone wanted to use. (And then you could not just store it into a variable and ignore it, since that would trigger the "unused variable" warning! ;-))

I know IntelliJ can provide warnings when ignoring the return value of a few select JDK methods that are often used incorrectly, but then they had to annotate these specially. I don't know if there is any similar kind of annotation for clang/gcc that can warn about ignoring return values that really, really shouldn't be ignored, but I'd guess not.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20812#discussion_r1741464573

From abhiscxk at openjdk.org  Tue Sep  3 06:11:19 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 3 Sep 2024 06:11:19 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v2]
In-Reply-To: <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>
Message-ID: <H36Y9hl6AZvpnAcqo-2YB0ZfHKCqsbrJiKaSYZ2_aBM=.424e7eb0-70c4-40fa-ad06-3040dc70527e@github.com>

On Tue, 3 Sep 2024 05:50:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
>> Test removed from `Problem-list` file as well.
>> 
>> CI testing link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove secondaryloop code

@prsadhuk Ran the test with uiscale of 2 and test passed across all platforms.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2325673178

From psadhukhan at openjdk.org  Tue Sep  3 06:11:20 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 3 Sep 2024 06:11:20 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v2]
In-Reply-To: <xuCE9i0TAgJ_6GhuKg39irMUjJVzXF16TxlEXnWoY9M=.0ed23206-1abc-4d36-92fd-04ed2f541421@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>
 <xuCE9i0TAgJ_6GhuKg39irMUjJVzXF16TxlEXnWoY9M=.0ed23206-1abc-4d36-92fd-04ed2f541421@github.com>
Message-ID: <T2nmaMlrFYBIpv8EDrErCV8pvxauzA9q8eza3IjspaA=.f9fc304d-afba-428b-9155-5a48ccf536c9@github.com>

On Tue, 3 Sep 2024 05:50:43 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> @prsadhuk As we were discussing about the test change and removal of SecondaryLoop change, I tested the current changes without the fix proposed in [JDK-8007563](https://bugs.openjdk.org/browse/JDK-8007563) and test failed which is correct. After applying the fix, test is able to pass.

Secondary loop was added for JDK-8078269 not for JDK-8007563 so you need to check if test fail without Secondary loop without that fix and passes with the fix..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2325676196

From dholmes at openjdk.org  Tue Sep  3 06:18:18 2024
From: dholmes at openjdk.org (David Holmes)
Date: Tue, 3 Sep 2024 06:18:18 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v2]
In-Reply-To: <1YazhBzFJBBSy6KnqHuWOBFYfBQgx2ObU5WNlgb97J8=.8015a1da-4780-4738-88fd-886b75bee195@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
 <THmGrAyWicjbdHxgsFNcUQpzcN8mn4jom_fkjktQZ2M=.eff582ce-5f14-445c-98ff-6b8fb850e459@github.com>
 <igLjFMZwZr-pJiYzZ5E9qFrMAOD66Lvzxi7SNHELyxA=.c4256988-3ae9-43eb-b599-c1a290c22bea@github.com>
 <VcGVewtYspnLN09mP5vNhRjKpd_8cpcCndhyPmdaJCI=.af4869cc-b281-498f-9eda-009872be3a47@github.com>
 <1YazhBzFJBBSy6KnqHuWOBFYfBQgx2ObU5WNlgb97J8=.8015a1da-4780-4738-88fd-886b75bee195@github.com>
Message-ID: <dFTZkGHLLE_nFupik3FcJQczQZ2YayF0ZJh4FP6eln4=.e44ff0ba-df61-4f00-bea4-5d14f8c9f0be@github.com>

On Tue, 3 Sep 2024 05:52:31 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> This code is devoid of pretty much all error handling and logging, but I agree that a simple fprintf on error would be useful.
>> Also doesn't a call like this trigger the warning about ignoring a function result, or have we disabled that one?
>
>> Also doesn't a call like this trigger the warning about ignoring a function result, or have we disabled that one?
> 
> Such a warning would be horrible to have enable. Then you would have to read the value of every function that thought it should return a value, even if it was just intended as some additional information that perhaps not everyone wanted to use. (And then you could not just store it into a variable and ignore it, since that would trigger the "unused variable" warning! ;-))
> 
> I know IntelliJ can provide warnings when ignoring the return value of a few select JDK methods that are often used incorrectly, but then they had to annotate these specially. I don't know if there is any similar kind of annotation for clang/gcc that can warn about ignoring return values that really, really shouldn't be ignored, but I'd guess not.

At one stage we started using the idiom:

(void) someFunc();

to tell the compiler to not warn about the unused result. IIRC that stopped working.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20812#discussion_r1741484485

From jwaters at openjdk.org  Tue Sep  3 06:45:18 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 3 Sep 2024 06:45:18 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v2]
In-Reply-To: <dFTZkGHLLE_nFupik3FcJQczQZ2YayF0ZJh4FP6eln4=.e44ff0ba-df61-4f00-bea4-5d14f8c9f0be@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
 <THmGrAyWicjbdHxgsFNcUQpzcN8mn4jom_fkjktQZ2M=.eff582ce-5f14-445c-98ff-6b8fb850e459@github.com>
 <igLjFMZwZr-pJiYzZ5E9qFrMAOD66Lvzxi7SNHELyxA=.c4256988-3ae9-43eb-b599-c1a290c22bea@github.com>
 <VcGVewtYspnLN09mP5vNhRjKpd_8cpcCndhyPmdaJCI=.af4869cc-b281-498f-9eda-009872be3a47@github.com>
 <1YazhBzFJBBSy6KnqHuWOBFYfBQgx2ObU5WNlgb97J8=.8015a1da-4780-4738-88fd-886b75bee195@github.com>
 <dFTZkGHLLE_nFupik3FcJQczQZ2YayF0ZJh4FP6eln4=.e44ff0ba-df61-4f00-bea4-5d14f8c9f0be@github.com>
Message-ID: <bSqvR-vDWXT7BBQ9uOYRx-IQJrygn26skZv6uTue8CE=.24541305-9bc9-4c34-b752-a3e772dd0f6b@github.com>

On Tue, 3 Sep 2024 06:16:06 GMT, David Holmes <dholmes at openjdk.org> wrote:

>>> Also doesn't a call like this trigger the warning about ignoring a function result, or have we disabled that one?
>> 
>> Such a warning would be horrible to have enable. Then you would have to read the value of every function that thought it should return a value, even if it was just intended as some additional information that perhaps not everyone wanted to use. (And then you could not just store it into a variable and ignore it, since that would trigger the "unused variable" warning! ;-))
>> 
>> I know IntelliJ can provide warnings when ignoring the return value of a few select JDK methods that are often used incorrectly, but then they had to annotate these specially. I don't know if there is any similar kind of annotation for clang/gcc that can warn about ignoring return values that really, really shouldn't be ignored, but I'd guess not.
>
> At one stage we started using the idiom:
> 
> (void) someFunc();
> 
> to tell the compiler to not warn about the unused result. IIRC that stopped working.

Not entirely sure about clang, but casting to void to silence warnings should still work for gcc

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20812#discussion_r1741510831

From mbaesken at openjdk.org  Tue Sep  3 07:13:19 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Tue, 3 Sep 2024 07:13:19 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v2]
In-Reply-To: <bSqvR-vDWXT7BBQ9uOYRx-IQJrygn26skZv6uTue8CE=.24541305-9bc9-4c34-b752-a3e772dd0f6b@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
 <THmGrAyWicjbdHxgsFNcUQpzcN8mn4jom_fkjktQZ2M=.eff582ce-5f14-445c-98ff-6b8fb850e459@github.com>
 <igLjFMZwZr-pJiYzZ5E9qFrMAOD66Lvzxi7SNHELyxA=.c4256988-3ae9-43eb-b599-c1a290c22bea@github.com>
 <VcGVewtYspnLN09mP5vNhRjKpd_8cpcCndhyPmdaJCI=.af4869cc-b281-498f-9eda-009872be3a47@github.com>
 <1YazhBzFJBBSy6KnqHuWOBFYfBQgx2ObU5WNlgb97J8=.8015a1da-4780-4738-88fd-886b75bee195@github.com>
 <dFTZkGHLLE_nFupik3FcJQczQZ2YayF0ZJh4FP6eln4=.e44ff0ba-df61-4f00-bea4-5d14f8c9f0be@github.com>
 <bSqvR-vDWXT7BBQ9uOYRx-IQJrygn26skZv6uTue8CE=.24541305-9bc9-4c34-b752-a3e772dd0f6b@github.com>
Message-ID: <OSPlO9O2J_vuiGatV5SJQYKe4YSK5vfoN7NethO-OLA=.15f89aff-5889-47f7-a8ee-f9dc6ea03e55@github.com>

On Tue, 3 Sep 2024 06:42:42 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> At one stage we started using the idiom:
>> 
>> (void) someFunc();
>> 
>> to tell the compiler to not warn about the unused result. IIRC that stopped working.
>
> Not entirely sure about clang, but casting to void to silence warnings should still work for gcc

> You don't think it would be better to check the return code?

Hi , maybe we could check it ;  in HS code we mostly do  (but there we have UL).
But would be a separate PR I guess (splashscreen_sys.m on macOS has the same issue) .

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20812#discussion_r1741542559

From tr at openjdk.org  Tue Sep  3 07:26:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 3 Sep 2024 07:26:21 GMT
Subject: RFR: 8308588: Unnecessary synchronized on GTKStyle#ICONS_MAP can
 be removed [v2]
In-Reply-To: <GlDWyHUDU0NHHoghHMsa5FfTXQhPfd8-3HayoFTmito=.30b694f8-6ef9-4bd3-bf84-5ab28ab3eefa@github.com>
References: <kg66eVHLCjJhmt85ISgXSBGMTYX3nVEMb-ix988mu-o=.feb17119-25ff-446d-8ca8-72dda8f9a4a9@github.com>
 <GlDWyHUDU0NHHoghHMsa5FfTXQhPfd8-3HayoFTmito=.30b694f8-6ef9-4bd3-bf84-5ab28ab3eefa@github.com>
Message-ID: <4VUMKIE-_v9i5OD7bCDaAQEFUDPRDreE-L6ulHxSNSc=.03f889aa-601b-4bd7-9e4f-2d0b1ea97b2a@github.com>

On Fri, 30 Aug 2024 04:57:56 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> `static final Map<String,GTKStockIcon> ICONS_MAP` is modified only in `static` block. Then [com.sun.java.swing.plaf.gtk.GTKStyle#get](https://github.com/kumarabhi006/jdk/blob/73f7a5f15dbba54a98f3916ff1190520ac07874d/src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java#L892) method read from it within `synchronized (ICONS_MAP)` block. As this map is read-only and all its content is initialized in static block we can safely remove synchronized from get call.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use Collections.unmodifiableMap and remove blank line

Looks good to me.

-------------

Marked as reviewed by tr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20741#pullrequestreview-2276611822

From mbaesken at openjdk.org  Tue Sep  3 07:26:53 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Tue, 3 Sep 2024 07:26:53 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v3]
In-Reply-To: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
Message-ID: <W2_wdkLnGuOLys4J-pWfraNhgDuq5UGo77XYE7Y9L44=.27712b5a-610e-4cd9-8b42-e47dcc29ab39@github.com>

> We get a couple of warnings as errors on AIX because of unused variables or functions , for example :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10: error: unused variable 'exePath' [-Werror,-Wunused-variable]
>     char exePath[PATH_MAX];
>          ^
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:668:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
>     int ret;
>         ^
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:664:10: error: unused variable 'fn' [-Werror,-Wunused-variable]
>     char fn[32];
>          ^
> 
> This seems to be related to the recent make changes
> 8339156: Use more fine-granular clang unused warnings
> https://bugs.openjdk.org/browse/JDK-8339156
> (we use clang too on AIX)

Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:

  TimeZone_md move platform stuff

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20812/files
  - new: https://git.openjdk.org/jdk/pull/20812/files/082e6f60..e20948ca

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20812&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20812&range=01-02

  Stats: 8 lines in 1 file changed: 2 ins; 6 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20812.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20812/head:pull/20812

PR: https://git.openjdk.org/jdk/pull/20812

From mbaesken at openjdk.org  Tue Sep  3 07:26:53 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Tue, 3 Sep 2024 07:26:53 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v2]
In-Reply-To: <THmGrAyWicjbdHxgsFNcUQpzcN8mn4jom_fkjktQZ2M=.eff582ce-5f14-445c-98ff-6b8fb850e459@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
 <THmGrAyWicjbdHxgsFNcUQpzcN8mn4jom_fkjktQZ2M=.eff582ce-5f14-445c-98ff-6b8fb850e459@github.com>
Message-ID: <0_Av5QvMB9nUSbRIN-x2Z6OhkN__s0pzRSKw-8kEGLg=.7e4115e6-2f3a-4270-8fd7-f85ea8b2c137@github.com>

On Mon, 2 Sep 2024 13:25:51 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> We get a couple of warnings as errors on AIX because of unused variables or functions , for example :
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10: error: unused variable 'exePath' [-Werror,-Wunused-variable]
>>     char exePath[PATH_MAX];
>>          ^
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:668:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
>>     int ret;
>>         ^
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:664:10: error: unused variable 'fn' [-Werror,-Wunused-variable]
>>     char fn[32];
>>          ^
>> 
>> This seems to be related to the recent make changes
>> 8339156: Use more fine-granular clang unused warnings
>> https://bugs.openjdk.org/browse/JDK-8339156
>> (we use clang too on AIX)
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adjust indentation in X11Color.c

I would suggest creating a JBS issue and later PR for the pthread_create return code checking (both unix and macos).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20812#issuecomment-2325785214

From abhiscxk at openjdk.org  Tue Sep  3 07:58:20 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 3 Sep 2024 07:58:20 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v2]
In-Reply-To: <T2nmaMlrFYBIpv8EDrErCV8pvxauzA9q8eza3IjspaA=.f9fc304d-afba-428b-9155-5a48ccf536c9@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>
 <xuCE9i0TAgJ_6GhuKg39irMUjJVzXF16TxlEXnWoY9M=.0ed23206-1abc-4d36-92fd-04ed2f541421@github.com>
 <T2nmaMlrFYBIpv8EDrErCV8pvxauzA9q8eza3IjspaA=.f9fc304d-afba-428b-9155-5a48ccf536c9@github.com>
Message-ID: <Aia-Ejtowppq8Y1eMkLzGYX32QEaodJwj9NDApNdSSE=.9d4ecd47-1a5e-4d3d-9b56-4ad01f66c2b7@github.com>

On Tue, 3 Sep 2024 06:08:34 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Secondary loop was added for JDK-8078269 not for JDK-8007563 so you need to check if test fail without Secondary loop without that fix and passes with the fix..

I tested without the fix for JDK-8078269 for different scenarion:

1. Old test i.e. with SecondaryLoop with Thread.sleep(200) **Test Failed for Windows platform**
2. Old test i.e. with SecondaryLoop with Thread.sleep(500) **Test Passed**

3. Changed test i.e without SecondaryLoop with added robot.delay(200) **Test Failed for Windows platform**
4. Changed test i.e. without SecondaryLoop with added robot.delay(500) **Test Passed**

Since the old test with longer delay (500 ms) and changed test with delay of 500 ms passed without the fix of JDK-8078269, looks like the reason for failure could be less delay.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2325841922

From psadhukhan at openjdk.org  Tue Sep  3 08:44:22 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 3 Sep 2024 08:44:22 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v2]
In-Reply-To: <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>
Message-ID: <4-qerxAYf6Y4GFXtFei387XBRBTzCvwK8WfXXXE_Rrc=.c1abe092-ba3f-4c0b-b9ec-ed42cc95833a@github.com>

On Tue, 3 Sep 2024 05:50:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
>> Test removed from `Problem-list` file as well.
>> 
>> CI testing link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove secondaryloop code

I am not sure why secondary loop was added in the testcase for JDK-8078269..
JDK-8078269 issue was `TabbedPane.tabAreaBackground` should have precedence over `setBackground` but it was not working after JDK-8007563..
The 8007563 tests for non-opaque case whereas 8078269 issue was for opaque.
 It seems if we put `UIManager.put("TabbedPane.tabAreaBackground", Color.GREEN); ` then the tabbedpane areas where there are no tabs are not GREEN but RED...
Seems like we need a new testcase for JDK-8078269 and do away with secondary loop in 8007563 testcase..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2325936371

From tr at openjdk.org  Tue Sep  3 09:20:36 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 3 Sep 2024 09:20:36 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v2]
In-Reply-To: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
Message-ID: <4j7l91NuGvEVoon6bXXiMJmdZybXIu4jOLDZVJ0G36E=.350fad58-1fe6-47a1-a6cd-ce50f1aab539@github.com>

> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
> 1. Move the frame to center of the screen rather than left top.
> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Checker pattern comparison

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20723/files
  - new: https://git.openjdk.org/jdk/pull/20723/files/cfd2da7b..4c33680d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20723&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20723&range=00-01

  Stats: 25 lines in 1 file changed: 15 ins; 3 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/20723.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20723/head:pull/20723

PR: https://git.openjdk.org/jdk/pull/20723

From mdoerr at openjdk.org  Tue Sep  3 09:33:20 2024
From: mdoerr at openjdk.org (Martin Doerr)
Date: Tue, 3 Sep 2024 09:33:20 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v3]
In-Reply-To: <W2_wdkLnGuOLys4J-pWfraNhgDuq5UGo77XYE7Y9L44=.27712b5a-610e-4cd9-8b42-e47dcc29ab39@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
 <W2_wdkLnGuOLys4J-pWfraNhgDuq5UGo77XYE7Y9L44=.27712b5a-610e-4cd9-8b42-e47dcc29ab39@github.com>
Message-ID: <AezIGuWfTxX1kQx0v8S9gmLKc4f2welK6i1YHWu2umo=.5a919714-3876-4e81-b300-27f66f38cd0d@github.com>

On Tue, 3 Sep 2024 07:26:53 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> We get a couple of warnings as errors on AIX because of unused variables or functions , for example :
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10: error: unused variable 'exePath' [-Werror,-Wunused-variable]
>>     char exePath[PATH_MAX];
>>          ^
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:668:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
>>     int ret;
>>         ^
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:664:10: error: unused variable 'fn' [-Werror,-Wunused-variable]
>>     char fn[32];
>>          ^
>> 
>> This seems to be related to the recent make changes
>> 8339156: Use more fine-granular clang unused warnings
>> https://bugs.openjdk.org/browse/JDK-8339156
>> (we use clang too on AIX)
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   TimeZone_md move platform stuff

Thanks for the update! I also think that adding result checks is better in a separate RFE. This build fix is good to go IMHO.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20812#pullrequestreview-2276906529

From tr at openjdk.org  Tue Sep  3 09:40:22 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 3 Sep 2024 09:40:22 GMT
Subject: RFR: 8326027: Comparing buffered images of white background frame
 fails in Mac
In-Reply-To: <gYvarNYPdKz4YIvCq2MNVxQqkmmp4c2PJT_ALUCHTII=.47541591-c627-4d2d-9866-46bdcb35d30b@github.com>
References: <k_dehNjnRND72N061bx31c9YclyJhyL2hK1NHPJcLkE=.5a4fd4d5-ee80-4db0-bae4-4008360ead28@github.com>
 <gCFzYGg4FuXFwadvTZE-T5yHMO8nvCOKY7ps_si5xKE=.72e17254-8740-4444-aa6c-4eed86de65ce@github.com>
 <qNZO9RhbyJWm_TkeB02gQnQ_w8T9FZaVriftvUC6Hv0=.b9b97880-6763-48d9-839d-6461a4ff8f51@github.com>
 <0FKvhBMfDuyvzus_Q_sjhmFB02FPipKX9p54KNy6w0k=.cf25ba18-9c25-4079-aeae-c2ffeaf0eafe@github.com>
 <gYvarNYPdKz4YIvCq2MNVxQqkmmp4c2PJT_ALUCHTII=.47541591-c627-4d2d-9866-46bdcb35d30b@github.com>
Message-ID: <9EEL4ctBHQI73B_nmGvnucR4LMefzbGCpSUd1URgr8o=.cc576bd9-025a-4aec-83e1-f66388de3629@github.com>

On Fri, 30 Aug 2024 07:20:47 GMT, Tejesh R <tr at openjdk.org> wrote:

> > > Have you checked what is the root cause? Are the pixels drawn incorrectly in the frame, or is the robot distorting the colors when it grabs the pixels?
> > 
> > 
> > The issue occurs intermittently/might be even host specific. It occurs when Robot.createMultiResolutionScreenCapture is used to capture HiDPI image and comparing them. I believe it's related to Robot capture, rather than pixel drawn incorrectly since we haven't observed such case in headless test which actually compares colors using Graphics paint to buffered image.
> 
> I assume it's the opposite: if `Robot.createMultiResolutionScreenCapture` was used, the colours would be accurate (as displayed); whereas `Robot.createScreenCapture` scales down the screenshot which may introduce colour inaccuracy.
> 
> > > I wonder whether the tolerance wouldn't be required if `Robot.createMultiResolutionScreenCapture` was used to create the screenshot and then analysing the original image which didn't go through down-scaling in High DPI environment.
> > 
> > 
> > Yes, I have observed that some of the HiDPI image capture have this shades of pixels from expected which would require tolerance to be considered while comparing.
> 
> This is why I asked the question: does the comparison remain accurate without the need for tolerance if you use `Robot.createMultiResolutionScreenCapture` and use the highest resolution from the returned multi-resolution image?

I couldn't reproduce the issue neither with `Robot.createMultiResolutionScreenCapture` nor with `Robot.createScreenCapture` since the failure occurs intermittently, not able to say anything about using `Robot.createMultiResolutionScreenCapture` instead of  `Robot.createScreenCapture` .

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20760#issuecomment-2326063167

From abhiscxk at openjdk.org  Tue Sep  3 10:40:19 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 3 Sep 2024 10:40:19 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v2]
In-Reply-To: <4-qerxAYf6Y4GFXtFei387XBRBTzCvwK8WfXXXE_Rrc=.c1abe092-ba3f-4c0b-b9ec-ed42cc95833a@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>
 <4-qerxAYf6Y4GFXtFei387XBRBTzCvwK8WfXXXE_Rrc=.c1abe092-ba3f-4c0b-b9ec-ed42cc95833a@github.com>
Message-ID: <ldYNu2qrB8di7cy94NIXrqRQdrrNSJXmXF7Lz2izzrg=.cad3d5ff-5d2c-45a9-b8aa-f2ee5162b089@github.com>

On Tue, 3 Sep 2024 08:42:03 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> I am not sure why secondary loop was added in the testcase for JDK-8078269.. 

That is unclear to me as well. 

> JDK-8078269 issue was `TabbedPane.tabAreaBackground` should have precedence over `setBackground` but it was not working after JDK-8007563.. The 8007563 tests for non-opaque case whereas 8078269 issue was for opaque. It seems if we put `UIManager.put("TabbedPane.tabAreaBackground", Color.GREEN); ` then the tabbedpane areas where there are no tabs are not GREEN but RED... Seems like we need a new testcase for JDK-8078269 and do away with secondary loop in 8007563 testcase..

This issue still exists with the existing implementation in MetalTabbedPaneUI. If we add `UIManager.put("TabbedPane.tabAreaBackground", Color.GREEN); ` to the existing test then the expected output is that `the tabbedpane areas where there are no tabs should be GREEN`  but it is `RED` and the reason is the **background color instance check of UIResource** at [L905](https://github.com/kumarabhi006/jdk/blob/73f7a5f15dbba54a98f3916ff1190520ac07874d/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalTabbedPaneUI.java#L905). Since `background is an instance of Color object` the condition evaluates to **false** and the graphic's object color is set to the background of component which is RED.

I think removal of SecondaryLoop should be ok for this PR. And for  JDK-8078269 as you suggested we may need a new test case which checks for the `UIManager.put("TabbedPane.tabAreaBackground", Color.GREEN);` as the property is not tested here.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2326188554

From mbaesken at openjdk.org  Tue Sep  3 12:05:25 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Tue, 3 Sep 2024 12:05:25 GMT
Subject: Integrated: 8339364: AIX build fails: various unused variable and
 function warnings
In-Reply-To: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
Message-ID: <snfNlmZMwM13FFG9TVc6NM2cOeeq4tWGWNeQNnZzWGk=.0905e1c1-41b4-4e97-8054-bc421017369b@github.com>

On Mon, 2 Sep 2024 11:43:20 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> We get a couple of warnings as errors on AIX because of unused variables or functions , for example :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10: error: unused variable 'exePath' [-Werror,-Wunused-variable]
>     char exePath[PATH_MAX];
>          ^
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:668:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
>     int ret;
>         ^
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:664:10: error: unused variable 'fn' [-Werror,-Wunused-variable]
>     char fn[32];
>          ^
> 
> This seems to be related to the recent make changes
> 8339156: Use more fine-granular clang unused warnings
> https://bugs.openjdk.org/browse/JDK-8339156
> (we use clang too on AIX)

This pull request has now been integrated.

Changeset: 8ea6adc6
Author:    Matthias Baesken <mbaesken at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8ea6adc623ca2183046d794eba806065deea916e
Stats:     65 lines in 14 files changed: 9 ins; 40 del; 16 mod

8339364: AIX build fails: various unused variable and function warnings

Reviewed-by: mdoerr, clanger, jwaters

-------------

PR: https://git.openjdk.org/jdk/pull/20812

From mbaesken at openjdk.org  Tue Sep  3 12:09:23 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Tue, 3 Sep 2024 12:09:23 GMT
Subject: RFR: 8339364: AIX build fails: various unused variable and
 function warnings [v3]
In-Reply-To: <W2_wdkLnGuOLys4J-pWfraNhgDuq5UGo77XYE7Y9L44=.27712b5a-610e-4cd9-8b42-e47dcc29ab39@github.com>
References: <ACR4Q4agqSEvIno3SmkZDKkw5Z3lorh5FcWLV3TN638=.85d1504f-7757-4b1c-bde3-7056dcabadcd@github.com>
 <W2_wdkLnGuOLys4J-pWfraNhgDuq5UGo77XYE7Y9L44=.27712b5a-610e-4cd9-8b42-e47dcc29ab39@github.com>
Message-ID: <JdrswSokMMG7XIc6kSt7gixPNaLGTqglHhO_xk95CYc=.448a9d48-f937-4474-838f-5c72a8ca25d6@github.com>

On Tue, 3 Sep 2024 07:26:53 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> We get a couple of warnings as errors on AIX because of unused variables or functions , for example :
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10: error: unused variable 'exePath' [-Werror,-Wunused-variable]
>>     char exePath[PATH_MAX];
>>          ^
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:668:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
>>     int ret;
>>         ^
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:664:10: error: unused variable 'fn' [-Werror,-Wunused-variable]
>>     char fn[32];
>>          ^
>> 
>> This seems to be related to the recent make changes
>> 8339156: Use more fine-granular clang unused warnings
>> https://bugs.openjdk.org/browse/JDK-8339156
>> (we use clang too on AIX)
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   TimeZone_md move platform stuff

I created https://bugs.openjdk.org/browse/JDK-8339475 for the pthread_create return code checking.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20812#issuecomment-2326356942

From ihse at openjdk.org  Tue Sep  3 13:02:55 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 3 Sep 2024 13:02:55 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked launcher
Message-ID: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>

As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.

This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 

All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).

-------------

Commit messages:
 - Makefile changes needed for static-launcher and static-jdk-image targets
 - Incorporate changes from leyden/hermetic-java-runtime that allows running a static launcher

Changes: https://git.openjdk.org/jdk/pull/20837/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20837&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339480
  Stats: 429 lines in 22 files changed: 351 ins; 5 del; 73 mod
  Patch: https://git.openjdk.org/jdk/pull/20837.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20837/head:pull/20837

PR: https://git.openjdk.org/jdk/pull/20837

From ihse at openjdk.org  Tue Sep  3 13:02:55 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 3 Sep 2024 13:02:55 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
Message-ID: <b4JPTQvVYy0YD37EA4fkGyoqdNDhmJoI3b5Nmap_Z5A=.8733d6e4-12a7-47da-9c90-87e1836d7a27@github.com>

On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.
> 
> This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 
> 
> All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).

@jianglizhou Can you please check if there are any other contributors that should be acknowledged?

The `static-jdk` image is enough to run a simple HelloWorld java program; however it cannot yet run JTReg tests. The reason for this is, afaict, that the javac launcher is missing. I am planning to examine if it is possible to add a small shim `javac` launcher that calls the static `java` with the proper main class. (And similarly for the other launchers.) The goal here must, after all, be that we should be able to run the normal jtreg tests on the `static-jdk` image.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20837#issuecomment-2326445877
PR Comment: https://git.openjdk.org/jdk/pull/20837#issuecomment-2326452510

From psadhukhan at openjdk.org  Tue Sep  3 13:46:23 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 3 Sep 2024 13:46:23 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v2]
In-Reply-To: <ldYNu2qrB8di7cy94NIXrqRQdrrNSJXmXF7Lz2izzrg=.cad3d5ff-5d2c-45a9-b8aa-f2ee5162b089@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>
 <4-qerxAYf6Y4GFXtFei387XBRBTzCvwK8WfXXXE_Rrc=.c1abe092-ba3f-4c0b-b9ec-ed42cc95833a@github.com>
 <ldYNu2qrB8di7cy94NIXrqRQdrrNSJXmXF7Lz2izzrg=.cad3d5ff-5d2c-45a9-b8aa-f2ee5162b089@github.com>
Message-ID: <a0hQ8wkMBDm6rkjTlWbYjgpgp5-Y8DoKKSYq85cjF4g=.de97a4e9-194e-4412-a45e-35eba2d57d9a@github.com>

On Tue, 3 Sep 2024 10:37:20 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> > I am not sure why secondary loop was added in the testcase for JDK-8078269..
> 
> That is unclear to me as well.
> 
> > JDK-8078269 issue was `TabbedPane.tabAreaBackground` should have precedence over `setBackground` but it was not working after JDK-8007563.. The 8007563 tests for non-opaque case whereas 8078269 issue was for opaque. It seems if we put `UIManager.put("TabbedPane.tabAreaBackground", Color.GREEN); ` then the tabbedpane areas where there are no tabs are not GREEN but RED... Seems like we need a new testcase for JDK-8078269 and do away with secondary loop in 8007563 testcase..
> 
> This issue still exists with the existing implementation in MetalTabbedPaneUI. If we add `UIManager.put("TabbedPane.tabAreaBackground", Color.GREEN); ` to the existing test then the expected output is that `the tabbedpane areas where there are no tabs should be GREEN` but it is `RED` and the reason is the **background color instance check of UIResource** at [L905](https://github.com/kumarabhi006/jdk/blob/73f7a5f15dbba54a98f3916ff1190520ac07874d/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalTabbedPaneUI.java#L905). Since `background is an instance of Color object` the condition evaluates to **false** and the graphic's object color is set to the background of component which is RED.
> 
> I think removal of SecondaryLoop should be ok for this PR. And for JDK-8078269 as you suggested we may need a new test case which checks for the `UIManager.put("TabbedPane.tabAreaBackground", Color.GREEN);` as the property is not tested here.

As per
https://mail.openjdk.org/pipermail/swing-dev/2015-May/004521.html
secondary loop was added for
> Also inappropriate design chosen for the 8007563 reg test code affected test results stability. It also has been fixed.

I guess because pre-2018 our tests was run in samevm mode so there might be some stability issue and since it has been changed to othervm mode by default since '18, I guess this loop is not needed.
Also, as per the discussion for the webrev, it seems the "background" color, if set, was given precedence over property or in other words if `background color instance check of UIResource` means if background color is not set by user and is set by L&F which in case of MetalL&F is `"TabbedPane.background", controlShadow,` which is UIResource and in this case if `TabbedPane.tabAreaBackground` is set, TabbedPane.tabAreaBackground will take precedence

but if background Color set by user as is in this case in the testcase, it will not be instance of UIResource but Color so background color will take precedence

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2326565674

From honkar at openjdk.org  Tue Sep  3 16:44:19 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 3 Sep 2024 16:44:19 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v2]
In-Reply-To: <o5dEnFQNqx_mFwQiPX_5ucJ1u9XOul2Pz0Y78KI4nf0=.cdf94c05-f946-45ad-9d25-379dda673dc1@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <o5dEnFQNqx_mFwQiPX_5ucJ1u9XOul2Pz0Y78KI4nf0=.cdf94c05-f946-45ad-9d25-379dda673dc1@github.com>
Message-ID: <cnvVw-9QHOuHEQL1i9vIjErQd09ySLCTVNeU8vgU74s=.c7c748d9-1c2a-4e01-9d46-78ae3fa02d4e@github.com>

On Sat, 31 Aug 2024 09:08:59 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
>> 
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
>> 
>> Fix:
>> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review Comments Fixed : Further stabilized the test by increasing the delay as well as removing some unwanted lines of code

frame.setExtendedState(JFrame.MAXIMIZED_BOTH);
                System.out.println("Frame is maximized");
                robot.waitForIdle();

You missed adding delays after frame state changes, in the above case after  robot.waitForIdle() adding robot.delay(100) can stabilize the test. This applies to all the places where frame.setExtendedState() is used.

-------------

Changes requested by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20777#pullrequestreview-2277965584

From serb at openjdk.org  Tue Sep  3 17:10:32 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 3 Sep 2024 17:10:32 GMT
Subject: RFR: 8337681: PNGImageWriter uses much more memory than necessary
 [v2]
In-Reply-To: <8ZstKFyu435jMQ9_44gJwjCtz1N1at3B_wqbsDi2msE=.aede545e-7d62-4af6-9f51-5682a5281ac3@github.com>
References: <CSTpfVr55ahBWOCkao8Ri0CP97dX0t9BERx4Q1yh0d0=.8d458f70-66c9-4bdc-a826-ada3bd51394a@github.com>
 <8ZstKFyu435jMQ9_44gJwjCtz1N1at3B_wqbsDi2msE=.aede545e-7d62-4af6-9f51-5682a5281ac3@github.com>
Message-ID: <xfHx_-FoHIC56O_5JRVxI_rMHxYSznZM-eHVa4PMiqs=.2c8949a5-0ad4-4fef-922b-15fc587f20aa@github.com>

On Thu, 1 Aug 2024 21:51:04 GMT, Daniel Gredler <duke at openjdk.org> wrote:

>> At some point the `JPEGImageWriter` was optimized to reduce duplication / copying of rasters and data buffers (see `JDK-6266748`). However, `PNGImageWriter` never received a similar optimization, and is making unnecessary copies of raster and data buffers whenever PNG images are written.
>> 
>> Measurements: In a local test, `PNGImageWriter.write( )` and callees were initially showing up as an allocation hotspot (~400k objects / ~65 MB allocated), but after these optimizations I'm seeing much better numbers (~400 objects / ~740 KB allocated).
>
> Daniel Gredler has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - JDK-8337681: add tests for TYPE_4BYTE_ABGR
>  - JDK-8337681: add tests for TYPE_INT_RGB

src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGImageWriter.java line 924:

> 922:         for (int row = minY + yOffset; row < minY + height; row += ySkip) {
> 923:             Raster ras;
> 924:             if (image instanceof BufferedImage bi) {

Do we really need to run these two blocks in the loop for each iteration?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20432#discussion_r1742404140

From mvs at openjdk.org  Tue Sep  3 17:46:34 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Tue, 3 Sep 2024 17:46:34 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v3]
In-Reply-To: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
Message-ID: <6R66oJxdA9T-yG_RNvY_uKjpcn5twfYGo4pfDEwnNg8=.7b0effbd-cf33-45ed-babe-f8e08f8a74c0@github.com>

> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
> 
> Failure reason:
> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
> 
> Fix:
> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted

Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:

  Review comments fixed : Added a delay after the frame state change

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20777/files
  - new: https://git.openjdk.org/jdk/pull/20777/files/3e8e35a6..866cd952

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20777&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20777&range=01-02

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20777.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20777/head:pull/20777

PR: https://git.openjdk.org/jdk/pull/20777

From mvs at openjdk.org  Tue Sep  3 17:49:17 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Tue, 3 Sep 2024 17:49:17 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v2]
In-Reply-To: <cnvVw-9QHOuHEQL1i9vIjErQd09ySLCTVNeU8vgU74s=.c7c748d9-1c2a-4e01-9d46-78ae3fa02d4e@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <o5dEnFQNqx_mFwQiPX_5ucJ1u9XOul2Pz0Y78KI4nf0=.cdf94c05-f946-45ad-9d25-379dda673dc1@github.com>
 <cnvVw-9QHOuHEQL1i9vIjErQd09ySLCTVNeU8vgU74s=.c7c748d9-1c2a-4e01-9d46-78ae3fa02d4e@github.com>
Message-ID: <0Vl3HPfpZNgmfvfU06ZedENBeUj4RLxrjUVR9VuRCoI=.bcb0a236-d5e1-40ef-9a50-164d435a17b9@github.com>

On Tue, 3 Sep 2024 16:41:26 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> ```
>                 frame.setExtendedState(JFrame.MAXIMIZED_BOTH);
>                 System.out.println("Frame is maximized");
>                 robot.waitForIdle();
> ```
> 
> You missed adding delays after frame state changes, in the above case after robot.waitForIdle() adding robot.delay(100) can stabilize the test. This applies to all the places where frame.setExtendedState() is used.

Added the delay after the frame 'Maximized' and there is already a delay in getButtonImage() just before taking a screenshot, so that will cover the 'Normal' case.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20777#issuecomment-2327094982

From honkar at openjdk.org  Tue Sep  3 18:05:20 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 3 Sep 2024 18:05:20 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v3]
In-Reply-To: <Ef095XMvU_I7l1YEaum5q-SnZy9bfKobVBUF7lT-FH0=.a19f43f6-66c1-49d7-a485-cdd4122d2470@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <de5jxQIDWtBXnZDjTAXtKV680xbN9Tr2g4lqViz1PKY=.2167ac2f-778d-447f-9075-79d6e8c4cc8e@github.com>
 <Ef095XMvU_I7l1YEaum5q-SnZy9bfKobVBUF7lT-FH0=.a19f43f6-66c1-49d7-a485-cdd4122d2470@github.com>
Message-ID: <3yEPG2oqnrzRqCVmUvnAduZjnad0vxgMUgHEUWY742w=.d15011b3-50cc-4641-9902-9333dbf31fd6@github.com>

On Sat, 31 Aug 2024 09:09:22 GMT, Manukumar V S <mvs at openjdk.org> wrote:

> Individual robot.delay() can be added after UI creation and when frame state is changed to stabilize the test.

You are still missing some delays.


@@ -124,16 +125,15 @@ public void runTest() throws Exception {

         try {
             robot = new Robot();
+            robot.waitForIdle();
+            robot.delay(1000);    // delay after UI creation

             if (focusGainedLatch.await(3, TimeUnit.SECONDS)) {
                 System.out.println("Button focus gained...");
             } else {
                 System.out.println("Button focus not gained...");
                 throw new RuntimeException(
                         "Can't gain focus on button even after waiting " +
                        "too long..");
             }

             System.out.println("Getting initial button image..image1");
@@ -142,16 +142,18 @@ public void runTest() throws Exception {
             // some platforms may not support maximize frame
             if (frame.getToolkit().isFrameStateSupported(
                     JFrame.MAXIMIZED_BOTH)) {
-                robot.waitForIdle(); // unnecessary waitForIdle can be removed 
                 // maximize frame from normal size
                 frame.setExtendedState(JFrame.MAXIMIZED_BOTH);
                 System.out.println("Frame is maximized");
                 robot.waitForIdle();
                 robot.delay(100);

                 if (frame.getToolkit().isFrameStateSupported(JFrame.NORMAL)) {
                     System.out.println("Frame is back to normal");
                     // resize from maximum size to normal
                     frame.setExtendedState(JFrame.NORMAL);
+                    robot.waitForIdle();
+                    robot.delay(100); // please add these two lines after frame state is changed again.

@@ -192,7 +194,7 @@ public void runTest() throws Exception {
     private BufferedImage getButtonImage() {
         try {
             robot.waitForIdle();
-            robot.delay(1000);
+            robot.delay(300); this can be reduced from 1000 to ~300-500ms based on testing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20777#issuecomment-2327119894

From erikj at openjdk.org  Tue Sep  3 18:12:22 2024
From: erikj at openjdk.org (Erik Joelsson)
Date: Tue, 3 Sep 2024 18:12:22 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
Message-ID: <s3w0tA5ZwPTEux_ApC8BgGMObt-HQ9VJzvaC-IIj6CA=.e1e766d9-dc58-434b-8ce9-c6beedb974b4@github.com>

On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.
> 
> This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 
> 
> All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).

I tried to take this for a spin on my m1 mac laptop. I ran configure and then `make static-jdk-image`. The build failed with the following:


chmod: /Users/erik/dev/jdk/build/macosx-aarch64/jdk/lib/server/libjsig.dylib: No such file or directory
ModuleWrapper.gmk:81: recipe for target '/Users/erik/dev/jdk/build/macosx-aarch64/jdk/lib/server/libjsig.dylib' failed
make[3]: *** [/Users/erik/dev/jdk/build/macosx-aarch64/jdk/lib/server/libjsig.dylib] Error 1
make[3]: *** Waiting for unfinished jobs....
make/Main.gmk:191: recipe for target 'java.base-libs' failed
make[2]: *** [java.base-libs] Error 2


I'm guessing this would work if I built the regular image first, or at least at the same time.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20837#issuecomment-2327132241

From mvs at openjdk.org  Tue Sep  3 18:17:33 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Tue, 3 Sep 2024 18:17:33 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v4]
In-Reply-To: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
Message-ID: <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>

> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
> 
> Failure reason:
> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
> 
> Fix:
> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted

Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:

  Review comments fixed : Added some more delays

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20777/files
  - new: https://git.openjdk.org/jdk/pull/20777/files/866cd952..353b304f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20777&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20777&range=02-03

  Stats: 6 lines in 1 file changed: 3 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20777.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20777/head:pull/20777

PR: https://git.openjdk.org/jdk/pull/20777

From honkar at openjdk.org  Tue Sep  3 18:17:33 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 3 Sep 2024 18:17:33 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v4]
In-Reply-To: <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
Message-ID: <AJV8bk9n2iVwmWdmFauzN-QdOyY7YNkqm_j3pd7FenU=.dfac629f-02a6-4d3b-9780-9a8d91d9b342@github.com>

On Tue, 3 Sep 2024 18:14:44 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
>> 
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
>> 
>> Fix:
>> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments fixed : Added some more delays

LGTM now. 
Does CI testing look good with the updated changes? Since this is an intermittent test failure it is good to check if the added delays are working as expected.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20777#pullrequestreview-2278139908

From mvs at openjdk.org  Tue Sep  3 18:17:33 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Tue, 3 Sep 2024 18:17:33 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v4]
In-Reply-To: <3yEPG2oqnrzRqCVmUvnAduZjnad0vxgMUgHEUWY742w=.d15011b3-50cc-4641-9902-9333dbf31fd6@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <de5jxQIDWtBXnZDjTAXtKV680xbN9Tr2g4lqViz1PKY=.2167ac2f-778d-447f-9075-79d6e8c4cc8e@github.com>
 <Ef095XMvU_I7l1YEaum5q-SnZy9bfKobVBUF7lT-FH0=.a19f43f6-66c1-49d7-a485-cdd4122d2470@github.com>
 <3yEPG2oqnrzRqCVmUvnAduZjnad0vxgMUgHEUWY742w=.d15011b3-50cc-4641-9902-9333dbf31fd6@github.com>
Message-ID: <_rl2IYLbIbKZdNYygbxCthaGtg5_ioa3wYOPwyuanRk=.0adbab8f-fb49-48a3-a309-c636da9d2f7a@github.com>

On Tue, 3 Sep 2024 18:02:33 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> > Individual robot.delay() can be added after UI creation and when frame state is changed to stabilize the test.
> 
> You are still missing some delays. Please check the diff lines in the following code snippet.
> 
> ```
> @@ -124,16 +125,15 @@ public void runTest() throws Exception {
> 
>          try {
>              robot = new Robot();
> +            robot.waitForIdle();
> +            robot.delay(1000);    // delay after UI creation
> 
>              if (focusGainedLatch.await(3, TimeUnit.SECONDS)) {
>                  System.out.println("Button focus gained...");
>              } else {
>                  System.out.println("Button focus not gained...");
>                  throw new RuntimeException(
>                          "Can't gain focus on button even after waiting " +
>                         "too long..");
>              }
> 
>              System.out.println("Getting initial button image..image1");
> @@ -142,16 +142,18 @@ public void runTest() throws Exception {
>              // some platforms may not support maximize frame
>              if (frame.getToolkit().isFrameStateSupported(
>                      JFrame.MAXIMIZED_BOTH)) {
> -                robot.waitForIdle(); // unnecessary waitForIdle can be removed 
>                  // maximize frame from normal size
>                  frame.setExtendedState(JFrame.MAXIMIZED_BOTH);
>                  System.out.println("Frame is maximized");
>                  robot.waitForIdle();
>                  robot.delay(100);
> 
>                  if (frame.getToolkit().isFrameStateSupported(JFrame.NORMAL)) {
>                      System.out.println("Frame is back to normal");
>                      // resize from maximum size to normal
>                      frame.setExtendedState(JFrame.NORMAL);
> +                    robot.waitForIdle();
> +                    robot.delay(100); // please add these two lines after frame state is changed again.
> 
> @@ -192,7 +194,7 @@ public void runTest() throws Exception {
>      private BufferedImage getButtonImage() {
>          try {
>              robot.waitForIdle();
> -            robot.delay(1000);
> +            robot.delay(300); this can be reduced from 1000 to ~300-500ms based on testing.
> ```

Done.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20777#issuecomment-2327134209

From mvs at openjdk.org  Tue Sep  3 18:17:33 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Tue, 3 Sep 2024 18:17:33 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v4]
In-Reply-To: <AJV8bk9n2iVwmWdmFauzN-QdOyY7YNkqm_j3pd7FenU=.dfac629f-02a6-4d3b-9780-9a8d91d9b342@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
 <AJV8bk9n2iVwmWdmFauzN-QdOyY7YNkqm_j3pd7FenU=.dfac629f-02a6-4d3b-9780-9a8d91d9b342@github.com>
Message-ID: <fkKhglDUWzVMWlX9mBBsX_x0G8fxWz_cRFrRAi5oduI=.a2356ed3-cd60-4fa1-8703-9e9d29b26963@github.com>

On Tue, 3 Sep 2024 18:13:13 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> LGTM now. Does CI testing look good with the updated changes?

Yes, I have attached the results in the bug comment.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20777#issuecomment-2327139798

From honkar at openjdk.org  Tue Sep  3 18:23:23 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 3 Sep 2024 18:23:23 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v4]
In-Reply-To: <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
Message-ID: <O8wMXYb2hQQBf4eh6uUy-PVt3-jZErBaXN4JBPbG3Tw=.ba2e6ca5-5065-4d66-94ef-d66162be419e@github.com>

On Tue, 3 Sep 2024 18:17:33 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
>> 
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
>> 
>> Fix:
>> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments fixed : Added some more delays

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20777#pullrequestreview-2278150451

From duke at openjdk.org  Tue Sep  3 18:23:23 2024
From: duke at openjdk.org (duke)
Date: Tue, 3 Sep 2024 18:23:23 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v4]
In-Reply-To: <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
Message-ID: <0RbhwPQniaQnlY24XLypsZtDq7dFNqbPqf7me1czbkc=.52e37820-0883-451c-a543-bd49c186dc15@github.com>

On Tue, 3 Sep 2024 18:17:33 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
>> 
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
>> 
>> Fix:
>> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments fixed : Added some more delays

@openjdk[bot] 
Your change (at version 353b304f075713d6ea264b350b1b81473776975a) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20777#issuecomment-2327148806

From ihse at openjdk.org  Tue Sep  3 19:53:18 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 3 Sep 2024 19:53:18 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <s3w0tA5ZwPTEux_ApC8BgGMObt-HQ9VJzvaC-IIj6CA=.e1e766d9-dc58-434b-8ce9-c6beedb974b4@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
 <s3w0tA5ZwPTEux_ApC8BgGMObt-HQ9VJzvaC-IIj6CA=.e1e766d9-dc58-434b-8ce9-c6beedb974b4@github.com>
Message-ID: <1nXZ6wL05zwQD3alCwKAo7P0XbkXkJbX_p5TFTXobvI=.d119ebf5-f5b0-495b-a16b-259110b13357@github.com>

On Tue, 3 Sep 2024 18:10:06 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> I'm guessing this would work if I built the regular image first, or at least at the same time.

No, I don't think that should matter. `static-jdk-image` depends on `exploded-image`, and the files in your error message resides in `jdk`, not `images/jdk`. I have never seen this problem before. I'm not even sure why or when we try to chmod libjsig?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20837#issuecomment-2327308045

From ihse at openjdk.org  Tue Sep  3 19:53:19 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 3 Sep 2024 19:53:19 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
Message-ID: <B16wN8KTxTitqlKgNK8zWwhiC79xxRNF63JhvFLG42U=.61a51fb2-280f-486b-9013-aa73986bf9bf@github.com>

On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.
> 
> This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 
> 
> All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).

I wonder if it is related to JDK-8336498?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20837#issuecomment-2327311982

From erikj at openjdk.org  Tue Sep  3 20:01:21 2024
From: erikj at openjdk.org (Erik Joelsson)
Date: Tue, 3 Sep 2024 20:01:21 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
Message-ID: <FQ5Ecut4VNYYHMBRZhCcVejcHrInMe7vDkyNIPZkprA=.aa9111b7-e3e3-4f4a-9031-d1fb5b9f6ffb@github.com>

On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.
> 
> This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 
> 
> All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).

make/ModuleWrapper.gmk line 59:

> 57:   endif
> 58: endif
> 59: 

This part looks a bit convoluted. It would be nice with a comment explaining what it does, where `$($(MODULE)_JDK_LIBS)` is coming from and what consumes the module-libs.txt.

make/StaticLibs.gmk line 171:

> 169: 
> 170: $(eval $(call SetupCopyFiles, copy-static-launcher, \
> 171:     SRC := $(dir $(JAVA_LAUNCHER)), \

If only copying a single file, this becomes the default value for SRC, so no need to specify it.

make/common/JdkNativeCompilation.gmk line 310:

> 308:       $$(MODULE)_JDK_LIBS += $$($1_NAME)
> 309:     endif
> 310:   endif

Same, here as in ModuleWrapper.gmk, I think we need a comment explaining how this is consumed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1742601500
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1742500522
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1742605313

From honkar at openjdk.org  Wed Sep  4 00:07:19 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 4 Sep 2024 00:07:19 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v2]
In-Reply-To: <4j7l91NuGvEVoon6bXXiMJmdZybXIu4jOLDZVJ0G36E=.350fad58-1fe6-47a1-a6cd-ce50f1aab539@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <4j7l91NuGvEVoon6bXXiMJmdZybXIu4jOLDZVJ0G36E=.350fad58-1fe6-47a1-a6cd-ce50f1aab539@github.com>
Message-ID: <njiwmWOAd3NrXSlVPIwqwju4162PC-xFl9OwNTNPDQM=.0145c267-3826-4089-89de-869c08e91ba8@github.com>

On Tue, 3 Sep 2024 09:20:36 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rather than left top.
>> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Checker pattern comparison

With the updated checker pattern

- The test condition is changed to `checkmarkFound = true`  which may not be ideal condition to start with.
- Are specific pixels being compared? I think it is easier to loop through the entire image and keep track of number of pixels matching the condition compareColor(pixelColor).

I was suggesting something like the following.  A counter var - `pixelCounter` to keep track of no. of pixels and when 5-6 pixels matches the criteria exit out of the loop. 


--- a/test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java
+++ b/test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java
@@ -48,6 +48,8 @@ public class CheckboxCheckerScalingTest {
     private static Checkbox checkbox;
     private static BufferedImage imageAfterChecked;
     private static volatile boolean checkmarkFound = false;
+    private static final int TOLERANCE = 5;
+    private static int pixelCounter = 0;

     public static void main(String[] args) throws Exception {
         System.setProperty("sun.java2d.uiScale", "2");
@@ -58,6 +60,7 @@ public static void main(String[] args) throws Exception {
                 checkbox = new Checkbox("one");
                 checkbox.setState(true);
                 frame.add(checkbox);
                 frame.setLocationRelativeTo(null);
                 frame.pack();
                 frame.setVisible(true);
             });
@@ -72,9 +75,14 @@ public static void main(String[] args) throws Exception {
                 check: {
                     for (int i = 0; i < imageAfterChecked.getHeight(); i++) {
                         for (int j = 0; j < imageAfterChecked.getWidth(); j++) {
-                            if (Color.black.getRGB() == imageAfterChecked.getRGB(i, j)) {
-                                checkmarkFound = true;
-                                break check;
+                            Color pixelColor = new Color(imageAfterChecked.getRGB(i, j));
+                            if (compareColor(pixelColor)) {
+                                System.out.println(pixelColor);
+                                pixelCounter++;
+                                if (pixelCounter >= 5) {
+                                    checkmarkFound = true;
+                                    break check;
+                                }
                             }
                         }
                     }

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20723#issuecomment-2327652353

From dnguyen at openjdk.org  Wed Sep  4 01:00:39 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 4 Sep 2024 01:00:39 GMT
Subject: RFR: 6672644: JComboBox still scrolling if switch to another window
 and return back.
Message-ID: <vOzWxTYyh6qDyDB7sg2I1DjLG0I0ZZFb9sG9qKRd--4=.647cbf42-332c-430b-b12a-763bbee68ff3@github.com>

In a JComboBox, if the user opens the dropdown list and clicks and holds the down-button, then ALT-TABs to switch focus, when the user re-focuses the frame with the JComboBox and opens the dropdown list again, the list will still be scrolling even though the down-button isn't pressed.

This isn't OS or L&F specific, although Aqua L&F does not have any directional arrows in the dropdown list (and is thus exempt). This led me to believe it could be handled in BasicComboBoxUI where focusLost and focusGain are used or isPopupVisible but the scroll behavior cannot be altered here. Likewise for BasicComboPopup where `autoscroll` is used. However, this behavior isn't related to autoscroll and is actually found in the JScrollbar of the JScrollpane inside of the JComboBox. The timer for the scroll action starts but is never stopped if focus is lost, so a new listener is created and used. The proposed solution uses `KeyboardFocusManager` to track the focus owner. The listener stops the `scrollTimer` when the `focusOwner` property is changed. With this change, the list no longer automatically scrolls when re-focused and instead opens normally.

The included test is manual due to the need to confirm that the list still scrolls after ALT-TABing. The L&F is set to Metal since it is the cross-platform lookandfeel and has directional buttons for the JScrollPane list.

-------------

Commit messages:
 - Initial commit

Changes: https://git.openjdk.org/jdk/pull/20845/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20845&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-6672644
  Stats: 126 lines in 2 files changed: 125 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/20845.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20845/head:pull/20845

PR: https://git.openjdk.org/jdk/pull/20845

From dnguyen at openjdk.org  Wed Sep  4 01:13:25 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 4 Sep 2024 01:13:25 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v2]
In-Reply-To: <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>
Message-ID: <3BgWw-SKgjezBt481wMJnq8Mpn6rb6wkIj8hBnvzzW0=.b3b0a6f8-57b7-427e-819a-489f0ac53752@github.com>

On Tue, 3 Sep 2024 05:50:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
>> Test removed from `Problem-list` file as well.
>> 
>> CI testing link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove secondaryloop code

I tested this myself and it does seem to be stable and pass consistently. Looks like the extra delay works.

Following the logic regarding the precedence of the different sources of background color, it does seem like Prasanta is correct when glancing over the different sources of colors.

Worth noting, I think it'd be good to rename the test since we're removing it from the problemlist and moving the test to a new location anyway. Maybe rename it to `JTabbedPaneBackgroundColorTest` or something similar to be more descriptive.

-------------

Changes requested by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/20791#pullrequestreview-2278752187

From abhiscxk at openjdk.org  Wed Sep  4 04:21:00 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 4 Sep 2024 04:21:00 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v3]
In-Reply-To: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
Message-ID: <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>

> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
> Test removed from `Problem-list` file as well.
> 
> CI testing link is posted in JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Test name renamed

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20791/files
  - new: https://git.openjdk.org/jdk/pull/20791/files/e1f9c9c5..1ff306c4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20791&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20791&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20791.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20791/head:pull/20791

PR: https://git.openjdk.org/jdk/pull/20791

From abhiscxk at openjdk.org  Wed Sep  4 04:25:22 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 4 Sep 2024 04:25:22 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v2]
In-Reply-To: <3BgWw-SKgjezBt481wMJnq8Mpn6rb6wkIj8hBnvzzW0=.b3b0a6f8-57b7-427e-819a-489f0ac53752@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <Hkx41weCGHw6PvtlNty0hk4P9xbULWRXkZ-1DeTOd-w=.02f6b28a-2ac3-4892-9bd6-85e2b73cea22@github.com>
 <3BgWw-SKgjezBt481wMJnq8Mpn6rb6wkIj8hBnvzzW0=.b3b0a6f8-57b7-427e-819a-489f0ac53752@github.com>
Message-ID: <S97-A4NkglPIJelAw3tu8eu9s9SSuvLb63prpMcoYRc=.9361b1f2-06ad-4317-a4db-1efadb1370da@github.com>

On Wed, 4 Sep 2024 01:10:16 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Worth noting, I think it'd be good to rename the test since we're removing it from the problemlist and moving the test to a new location anyway. Maybe rename it to `JTabbedPaneBackgroundColorTest` or something similar to be more descriptive.

I didn't pay attention that the file is recognized as a new file when it has moved to new location. This may be due to the recent changes in test where it has been almost changed except few lines and is recognized as new file.
Renamed the test now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2327884410

From abhiscxk at openjdk.org  Wed Sep  4 04:29:21 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 4 Sep 2024 04:29:21 GMT
Subject: Integrated: 8308588: Unnecessary synchronized on GTKStyle#ICONS_MAP
 can be removed
In-Reply-To: <kg66eVHLCjJhmt85ISgXSBGMTYX3nVEMb-ix988mu-o=.feb17119-25ff-446d-8ca8-72dda8f9a4a9@github.com>
References: <kg66eVHLCjJhmt85ISgXSBGMTYX3nVEMb-ix988mu-o=.feb17119-25ff-446d-8ca8-72dda8f9a4a9@github.com>
Message-ID: <vQbQPjGw-2H5668wph7MM7ovKemTUYzT8ctThR9zftk=.42d820fe-4bd0-41b0-b36c-0d631f793a8e@github.com>

On Wed, 28 Aug 2024 08:54:39 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> `static final Map<String,GTKStockIcon> ICONS_MAP` is modified only in `static` block. Then [com.sun.java.swing.plaf.gtk.GTKStyle#get](https://github.com/kumarabhi006/jdk/blob/73f7a5f15dbba54a98f3916ff1190520ac07874d/src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java#L892) method read from it within `synchronized (ICONS_MAP)` block. As this map is read-only and all its content is initialized in static block we can safely remove synchronized from get call.

This pull request has now been integrated.

Changeset: 5998f4b6
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5998f4b6f53769f98188ae8c23ea49cc1f7aa802
Stats:     21 lines in 1 file changed: 1 ins; 4 del; 16 mod

8308588: Unnecessary synchronized on GTKStyle#ICONS_MAP can be removed

Reviewed-by: tr, aivanov, aturbanov

-------------

PR: https://git.openjdk.org/jdk/pull/20741

From tr at openjdk.org  Wed Sep  4 04:54:22 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 4 Sep 2024 04:54:22 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v2]
In-Reply-To: <njiwmWOAd3NrXSlVPIwqwju4162PC-xFl9OwNTNPDQM=.0145c267-3826-4089-89de-869c08e91ba8@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <4j7l91NuGvEVoon6bXXiMJmdZybXIu4jOLDZVJ0G36E=.350fad58-1fe6-47a1-a6cd-ce50f1aab539@github.com>
 <njiwmWOAd3NrXSlVPIwqwju4162PC-xFl9OwNTNPDQM=.0145c267-3826-4089-89de-869c08e91ba8@github.com>
Message-ID: <L5ZdlqhdpHqB-zDJHqge6lKdI2kW6CJX-SAflRFOjvo=.4d28d6a9-5519-42d3-9234-9173a1bb7c23@github.com>

On Wed, 4 Sep 2024 00:04:19 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> break check;

Yeah starting with `checkmarkFound = true` might not be right condition to start with. I selected these specific pixels index pattern based on checkmarker considering color gradient. Pixel counter would also be fine I guess, but pattern matching would be restricted check and Pixel counter is more of relaxed check. Will update as per your suggestions because I think here such restrictions might cause intermittent failures too, if image capture varies by even one pixel pixel `y` position.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20723#issuecomment-2327916347

From rgupta at openjdk.org  Wed Sep  4 05:00:22 2024
From: rgupta at openjdk.org (Ravi Gupta)
Date: Wed, 4 Sep 2024 05:00:22 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v7]
In-Reply-To: <QweXa3qMo3QTx7GMt3jACHTj85pE24c-XypNVxvtCdE=.8e555e97-9153-4375-8c97-9f4036dd716f@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <QweXa3qMo3QTx7GMt3jACHTj85pE24c-XypNVxvtCdE=.8e555e97-9153-4375-8c97-9f4036dd716f@github.com>
Message-ID: <LVW4ggTqQ4-e3_ALQP6xnojSEAUa0x3AxKru40vBRQs=.2929ff1a-b8b6-4a6c-a4a5-2e766489d534@github.com>

On Mon, 5 Aug 2024 04:46:47 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:

>> This testcase checks for the following assertions for Component events:
>> 
>> 1. When components are resized, moved, hidden and shown the respective events are triggered.
>> 2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
>> 3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
>> 4. When a window is minimized/restored then hidden and shown component events should be triggered.
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.
>
> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8333403: Review comments fixed

any volunteer for review?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19521#issuecomment-2327921623

From psadhukhan at openjdk.org  Wed Sep  4 05:05:26 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 4 Sep 2024 05:05:26 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v3]
In-Reply-To: <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
Message-ID: <1RbhpSaHnU9A5ZT2hCAA4GTHz3cbcdePFRCXdUcVLZI=.df120e89-a1ab-4383-b1f9-4701d7dffdfb@github.com>

On Wed, 4 Sep 2024 04:21:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
>> Test removed from `Problem-list` file as well.
>> 
>> CI testing link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test name renamed

Seems like closed test 4690946 where the UI property "TabbedPane.tabAreaBackground" was added in webrev.0 is moved to open and renamed as javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java..Any idea why the test is only for windows and linux? Can it be extended for macos too? Is [JDK-7148101](https://bugs.openjdk.org/browse/JDK-7148101) still valid?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2327925931

From psadhukhan at openjdk.org  Wed Sep  4 05:08:24 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 4 Sep 2024 05:08:24 GMT
Subject: Integrated: 8190329: [macos] Swing InterOp Platform.exit() crash
In-Reply-To: <RCXUBPtPMfsezzJli2ifzPT-uLkePnX8JA403l90N-U=.f674e497-01ad-4928-a84e-b47eaedaeb0a@github.com>
References: <RCXUBPtPMfsezzJli2ifzPT-uLkePnX8JA403l90N-U=.f674e497-01ad-4928-a84e-b47eaedaeb0a@github.com>
Message-ID: <29ipW1pcFLaihtrTD9opzusSOGaog4kezfzQ6fldDFo=.81ad6a38-3654-4f1b-8183-f4a31ff10c2f@github.com>

On Fri, 23 Aug 2024 09:17:43 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> The testcase calls Platform.exit before the dialog is made visible but
> on macOS, JavaFX takes over the AppKit thread and uses that as the FX application thread. As part of the FX platform shutdown process, it detaches that thread from the JVM. This means that the AppKit thread is no longer available to Java processes
> so AWT crashes when it ties to access appkit thread.
> Fix is made to check if the thread has been detached for move-resize notification event before proceeding..

This pull request has now been integrated.

Changeset: 9a1024de
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/9a1024dec68057c7c581ac0a38fc7f96489a0a76
Stats:     27 lines in 3 files changed: 19 ins; 1 del; 7 mod

8190329: [macos] Swing InterOp Platform.exit() crash

Co-authored-by: Kevin Rushforth <kcr at openjdk.org>
Reviewed-by: kcr, azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/20688

From abhiscxk at openjdk.org  Wed Sep  4 05:33:19 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 4 Sep 2024 05:33:19 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v3]
In-Reply-To: <1RbhpSaHnU9A5ZT2hCAA4GTHz3cbcdePFRCXdUcVLZI=.df120e89-a1ab-4383-b1f9-4701d7dffdfb@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
 <1RbhpSaHnU9A5ZT2hCAA4GTHz3cbcdePFRCXdUcVLZI=.df120e89-a1ab-4383-b1f9-4701d7dffdfb@github.com>
Message-ID: <xkN1kcP2VsE4Auq_Ez101RyrsI3gcZpEZhXIUPGUuKU=.86a7af36-ee94-42ca-881c-a2ecd22dcced@github.com>

On Wed, 4 Sep 2024 05:02:24 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Seems like closed test 4690946 where the UI property "TabbedPane.tabAreaBackground" was added in webrev.0 is moved to open and renamed as javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java..Any idea why the test is only for windows and linux? Can it be extended for macos too? Is [JDK-7148101](https://bugs.openjdk.org/browse/JDK-7148101) still valid?

closed test 4690946 was moved to open for the issue [JDK-8226990](https://bugs.openjdk.org/browse/JDK-8226990) and was tested against the windows and linux platform only because the issue was reported for Nimbus and GTK L&F. [See the discussion here](https://github.com/openjdk/jdk/pull/17720#discussion_r1584537667).
For Aqua separate bug was filed [JDK-8331619](https://bugs.openjdk.org/browse/JDK-8331619) and [PR raised](https://github.com/openjdk/jdk/pull/19170). But this bug was closed as were unable to verify the native behavior for TabbedPane.

> Can it be extended for macos too?

Do you mean TestJTabbedPaneOpaqueColor Test ? I guess it can be extended for Mac but we need to restrict the testing only for Metal and Nimbus L&F on Mac machine.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2327954489

From abhiscxk at openjdk.org  Wed Sep  4 05:38:19 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 4 Sep 2024 05:38:19 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v3]
In-Reply-To: <xkN1kcP2VsE4Auq_Ez101RyrsI3gcZpEZhXIUPGUuKU=.86a7af36-ee94-42ca-881c-a2ecd22dcced@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
 <1RbhpSaHnU9A5ZT2hCAA4GTHz3cbcdePFRCXdUcVLZI=.df120e89-a1ab-4383-b1f9-4701d7dffdfb@github.com>
 <xkN1kcP2VsE4Auq_Ez101RyrsI3gcZpEZhXIUPGUuKU=.86a7af36-ee94-42ca-881c-a2ecd22dcced@github.com>
Message-ID: <X0dNjpHSaOIz75i-NtwUDkhflGFxudch-61CWgR5V6Y=.4133a9ff-0641-491b-b3f3-b03fe0838e2b@github.com>

On Wed, 4 Sep 2024 05:30:48 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Is [JDK-7148101](https://bugs.openjdk.org/browse/JDK-7148101) still valid?

Yes, issue still exists for mac machine.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2327960292

From psadhukhan at openjdk.org  Wed Sep  4 05:43:22 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 4 Sep 2024 05:43:22 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v3]
In-Reply-To: <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
Message-ID: <X3BbhaUhh_YnqrTxy7WvDQ1FjwGFpMApejhQ5ArwRmU=.82c0d743-6414-45e2-a9a2-c1fe26ae0349@github.com>

On Wed, 4 Sep 2024 04:21:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
>> Test removed from `Problem-list` file as well.
>> 
>> CI testing link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test name renamed

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20791#pullrequestreview-2279041927

From psadhukhan at openjdk.org  Wed Sep  4 05:43:22 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 4 Sep 2024 05:43:22 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v3]
In-Reply-To: <X0dNjpHSaOIz75i-NtwUDkhflGFxudch-61CWgR5V6Y=.4133a9ff-0641-491b-b3f3-b03fe0838e2b@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
 <1RbhpSaHnU9A5ZT2hCAA4GTHz3cbcdePFRCXdUcVLZI=.df120e89-a1ab-4383-b1f9-4701d7dffdfb@github.com>
 <xkN1kcP2VsE4Auq_Ez101RyrsI3gcZpEZhXIUPGUuKU=.86a7af36-ee94-42ca-881c-a2ecd22dcced@github.com>
 <X0dNjpHSaOIz75i-NtwUDkhflGFxudch-61CWgR5V6Y=.4133a9ff-0641-491b-b3f3-b03fe0838e2b@github.com>
Message-ID: <JGHkUFcv8ylvpbnWgsFe3i_4Gal12U9cZi54HjsaKu0=.c9b43138-ec1e-4985-bd1a-6510218c812f@github.com>

On Wed, 4 Sep 2024 05:36:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> > Is [JDK-7148101](https://bugs.openjdk.org/browse/JDK-7148101) still valid?
> 
> Yes, issue still exists for mac machine.

Issue is for AquaL&F which as per your verification in [JDK-8331619](https://bugs.openjdk.org/browse/JDK-8331619) and https://github.com/openjdk/jdk/pull/19170 is not an issue it seems..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2327965002

From tr at openjdk.org  Wed Sep  4 05:48:53 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 4 Sep 2024 05:48:53 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v3]
In-Reply-To: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
Message-ID: <IvS76KgbntrLx7wR0a65Cp-QrGNHjsgtzGTm2mUVU_c=.bff06a6f-3128-4dfe-aaed-6e20904e5030@github.com>

> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
> 1. Move the frame to center of the screen rather than left top.
> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Updated based on review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20723/files
  - new: https://git.openjdk.org/jdk/pull/20723/files/4c33680d..9a562914

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20723&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20723&range=01-02

  Stats: 35 lines in 1 file changed: 14 ins; 19 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20723.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20723/head:pull/20723

PR: https://git.openjdk.org/jdk/pull/20723

From abhiscxk at openjdk.org  Wed Sep  4 05:59:21 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 4 Sep 2024 05:59:21 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v3]
In-Reply-To: <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
Message-ID: <tNgDRYhTbfiOVjZIiSKcz98uSFPL0MI9vIHGxXFLQsE=.a5a91402-cd2c-49b0-8ed8-d1c0c3d28e5a@github.com>

On Wed, 4 Sep 2024 04:21:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
>> Test removed from `Problem-list` file as well.
>> 
>> CI testing link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test name renamed

> > > Is [JDK-7148101](https://bugs.openjdk.org/browse/JDK-7148101) still valid?
> > 
> > 
> > Yes, issue still exists for mac machine.
> 
> Issue is for AquaL&F which as per your verification in [JDK-8331619](https://bugs.openjdk.org/browse/JDK-8331619) and #19170 is not an issue it seems..

Yes, for Aqua L&F we were not able to verify the native behavior.
I think bug4690946.java test needs to be removed from closed problemlist.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2327979341

From psadhukhan at openjdk.org  Wed Sep  4 05:59:21 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 4 Sep 2024 05:59:21 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v3]
In-Reply-To: <tNgDRYhTbfiOVjZIiSKcz98uSFPL0MI9vIHGxXFLQsE=.a5a91402-cd2c-49b0-8ed8-d1c0c3d28e5a@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
 <tNgDRYhTbfiOVjZIiSKcz98uSFPL0MI9vIHGxXFLQsE=.a5a91402-cd2c-49b0-8ed8-d1c0c3d28e5a@github.com>
Message-ID: <0aVuRMUkPDj7JN8RN8wNIRIHVb1s7rXa4Eslca4izZ4=.e544a627-9d90-4879-a35f-abf8684903a5@github.com>

On Wed, 4 Sep 2024 05:54:20 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> > > > Is [JDK-7148101](https://bugs.openjdk.org/browse/JDK-7148101) still valid?
> > > 
> > > 
> > > Yes, issue still exists for mac machine.
> > 
> > 
> > Issue is for AquaL&F which as per your verification in [JDK-8331619](https://bugs.openjdk.org/browse/JDK-8331619) and #19170 is not an issue it seems..
> 
> Yes, for Aqua L&F we were not able to verify the native behavior. I think bug4690946.java test needs to be removed from closed problemlist.

Yes already raised the PR for removal..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2327981898

From tr at openjdk.org  Wed Sep  4 07:00:19 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 4 Sep 2024 07:00:19 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v4]
In-Reply-To: <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
Message-ID: <y1r4OF7qQyQ55m9ge5175I6FsPwVkxcuWQ-kmWZgxLY=.270c86dc-a0d5-446f-92a9-d6cdca465aed@github.com>

On Tue, 3 Sep 2024 18:17:33 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
>> 
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
>> 
>> Fix:
>> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments fixed : Added some more delays

test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java line 213:

> 211: 
> 212:     private void disposeFrame() {
> 213:         frame.dispose();

null check might be required here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20777#discussion_r1743175302

From mvs at openjdk.org  Wed Sep  4 07:09:22 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Wed, 4 Sep 2024 07:09:22 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v4]
In-Reply-To: <y1r4OF7qQyQ55m9ge5175I6FsPwVkxcuWQ-kmWZgxLY=.270c86dc-a0d5-446f-92a9-d6cdca465aed@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
 <y1r4OF7qQyQ55m9ge5175I6FsPwVkxcuWQ-kmWZgxLY=.270c86dc-a0d5-446f-92a9-d6cdca465aed@github.com>
Message-ID: <vLGAv8rTiiv_FjxNpFB1XKqNNcvC1VgITlV_IE6lAkY=.6d0c4ce3-5665-4b89-a7cf-f92373e25882@github.com>

On Wed, 4 Sep 2024 06:57:56 GMT, Tejesh R <tr at openjdk.org> wrote:

> null check might be required here.

But we are not setting it as null anywhere in the code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20777#discussion_r1743182238

From tr at openjdk.org  Wed Sep  4 07:09:22 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 4 Sep 2024 07:09:22 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v4]
In-Reply-To: <vLGAv8rTiiv_FjxNpFB1XKqNNcvC1VgITlV_IE6lAkY=.6d0c4ce3-5665-4b89-a7cf-f92373e25882@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
 <y1r4OF7qQyQ55m9ge5175I6FsPwVkxcuWQ-kmWZgxLY=.270c86dc-a0d5-446f-92a9-d6cdca465aed@github.com>
 <vLGAv8rTiiv_FjxNpFB1XKqNNcvC1VgITlV_IE6lAkY=.6d0c4ce3-5665-4b89-a7cf-f92373e25882@github.com>
Message-ID: <QB6Z5SC3X0q8HTemTZGEH8nX_EXoqOhWK_rqUmZi8Qk=.c9b89e4e-3467-4a98-a422-ea26c2926e32@github.com>

On Wed, 4 Sep 2024 07:03:54 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java line 213:
>> 
>>> 211: 
>>> 212:     private void disposeFrame() {
>>> 213:         frame.dispose();
>> 
>> null check might be required here.
>
>> null check might be required here.
> 
> But we are not setting it as null anywhere in the code.

What if its not initialized at first place? To handle this scenario most of the test has this condition.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20777#discussion_r1743184534

From mvs at openjdk.org  Wed Sep  4 07:17:19 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Wed, 4 Sep 2024 07:17:19 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v4]
In-Reply-To: <QB6Z5SC3X0q8HTemTZGEH8nX_EXoqOhWK_rqUmZi8Qk=.c9b89e4e-3467-4a98-a422-ea26c2926e32@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
 <y1r4OF7qQyQ55m9ge5175I6FsPwVkxcuWQ-kmWZgxLY=.270c86dc-a0d5-446f-92a9-d6cdca465aed@github.com>
 <vLGAv8rTiiv_FjxNpFB1XKqNNcvC1VgITlV_IE6lAkY=.6d0c4ce3-5665-4b89-a7cf-f92373e25882@github.com>
 <QB6Z5SC3X0q8HTemTZGEH8nX_EXoqOhWK_rqUmZi8Qk=.c9b89e4e-3467-4a98-a422-ea26c2926e32@github.com>
Message-ID: <l_aRardmWyl_VnE3lUDxrlj61i-vp49O6cJRLqqMTpA=.bdc4085e-4f75-4e74-8f2e-629892f2ef60@github.com>

On Wed, 4 Sep 2024 07:05:57 GMT, Tejesh R <tr at openjdk.org> wrote:

>>> null check might be required here.
>> 
>> But we are not setting it as null anywhere in the code.
>
> What if its not initialized at first place? To handle this scenario most of the test has this condition.

I don't see a chance for that as the frame is initialized in createGUI() and there are lot of code which directly access frame object there itself, so if it was null, it would have thrown the Nullpointer even before. Anyway, I had this null check before, but removed it as per @honkar-jdk 's review comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20777#discussion_r1743194980

From abhiscxk at openjdk.org  Wed Sep  4 07:22:20 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 4 Sep 2024 07:22:20 GMT
Subject: RFR: 6672644: JComboBox still scrolling if switch to another
 window and return back.
In-Reply-To: <vOzWxTYyh6qDyDB7sg2I1DjLG0I0ZZFb9sG9qKRd--4=.647cbf42-332c-430b-b12a-763bbee68ff3@github.com>
References: <vOzWxTYyh6qDyDB7sg2I1DjLG0I0ZZFb9sG9qKRd--4=.647cbf42-332c-430b-b12a-763bbee68ff3@github.com>
Message-ID: <vik6i5HSn4njOzO-OC4iJO85hih6f_Ie8eCkXoK0uGk=.214b300b-fc60-4e1c-bf3c-31c061297c92@github.com>

On Wed, 4 Sep 2024 00:54:16 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> In a JComboBox, if the user opens the dropdown list and clicks and holds the down-button, then ALT-TABs to switch focus, when the user re-focuses the frame with the JComboBox and opens the dropdown list again, the list will still be scrolling even though the down-button isn't pressed.
> 
> This isn't OS or L&F specific, although Aqua L&F does not have any directional arrows in the dropdown list (and is thus exempt). This led me to believe it could be handled in BasicComboBoxUI where focusLost and focusGain are used or isPopupVisible but the scroll behavior cannot be altered here. Likewise for BasicComboPopup where `autoscroll` is used. However, this behavior isn't related to autoscroll and is actually found in the JScrollbar of the JScrollpane inside of the JComboBox. The timer for the scroll action starts but is never stopped if focus is lost, so a new listener is created and used. The proposed solution uses `KeyboardFocusManager` to track the focus owner. The listener stops the `scrollTimer` when the `focusOwner` property is changed. With this change, the list no longer automatically scrolls when re-focused and instead opens normally.
> 
> The included test is manual due to the need to confirm that the list still scrolls after ALT-TABing. The L&F is set to Metal since it is the cross-platform lookandfeel and has directional buttons for the JScrollPane list.

@DamonGuy are you able to reproduce the issue on linux machine? I tried on windows and linux, was able to reproduce it only on windows.
I checked on Ubuntu-22.04 and I can see the list is not scrolling and is stopped. Could you please confirm the same?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20845#issuecomment-2328102613

From tr at openjdk.org  Wed Sep  4 07:28:18 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 4 Sep 2024 07:28:18 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v4]
In-Reply-To: <l_aRardmWyl_VnE3lUDxrlj61i-vp49O6cJRLqqMTpA=.bdc4085e-4f75-4e74-8f2e-629892f2ef60@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
 <y1r4OF7qQyQ55m9ge5175I6FsPwVkxcuWQ-kmWZgxLY=.270c86dc-a0d5-446f-92a9-d6cdca465aed@github.com>
 <vLGAv8rTiiv_FjxNpFB1XKqNNcvC1VgITlV_IE6lAkY=.6d0c4ce3-5665-4b89-a7cf-f92373e25882@github.com>
 <QB6Z5SC3X0q8HTemTZGEH8nX_EXoqOhWK_rqUmZi8Qk=.c9b89e4e-3467-4a98-a422-ea26c2926e32@github.com>
 <l_aRardmWyl_VnE3lUDxrlj61i-vp49O6cJRLqqMTpA=.bdc4085e-4f75-4e74-8f2e-629892f2ef60@github.com>
Message-ID: <gbCjAhftOaHV-e15W2Qni6aZYaNZhTGB6vZZyKZKWGw=.082363dc-5684-4a39-a7be-4c32ef8ef530@github.com>

On Wed, 4 Sep 2024 07:14:14 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> What if its not initialized at first place? To handle this scenario most of the test has this condition.
>
> I don't see a chance for that as the frame is initialized in createGUI() and there are lot of code which directly access frame object there itself, so if it was null, it would have thrown the Nullpointer even before. Anyway, I had this null check before, but removed it as per @honkar-jdk 's review comment.

`Frame is assigned null after disposing which is not required and can be removed.` I hope u r referring to this comment. I hope she meant to remove null assignment after dispose is called.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20777#discussion_r1743210317

From abhiscxk at openjdk.org  Wed Sep  4 07:54:18 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 4 Sep 2024 07:54:18 GMT
Subject: RFR: 6672644: JComboBox still scrolling if switch to another
 window and return back.
In-Reply-To: <vOzWxTYyh6qDyDB7sg2I1DjLG0I0ZZFb9sG9qKRd--4=.647cbf42-332c-430b-b12a-763bbee68ff3@github.com>
References: <vOzWxTYyh6qDyDB7sg2I1DjLG0I0ZZFb9sG9qKRd--4=.647cbf42-332c-430b-b12a-763bbee68ff3@github.com>
Message-ID: <H7ShoNJ6GCNRTmQHX-Op_cvc4gPA4l4-yLL89e-HFks=.96ec4cf5-b76f-4057-8465-322ccbcbfdae@github.com>

On Wed, 4 Sep 2024 00:54:16 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> In a JComboBox, if the user opens the dropdown list and clicks and holds the down-button, then ALT-TABs to switch focus, when the user re-focuses the frame with the JComboBox and opens the dropdown list again, the list will still be scrolling even though the down-button isn't pressed.
> 
> This isn't OS or L&F specific, although Aqua L&F does not have any directional arrows in the dropdown list (and is thus exempt). This led me to believe it could be handled in BasicComboBoxUI where focusLost and focusGain are used or isPopupVisible but the scroll behavior cannot be altered here. Likewise for BasicComboPopup where `autoscroll` is used. However, this behavior isn't related to autoscroll and is actually found in the JScrollbar of the JScrollpane inside of the JComboBox. The timer for the scroll action starts but is never stopped if focus is lost, so a new listener is created and used. The proposed solution uses `KeyboardFocusManager` to track the focus owner. The listener stops the `scrollTimer` when the `focusOwner` property is changed. With this change, the list no longer automatically scrolls when re-focused and instead opens normally.
> 
> The included test is manual due to the need to confirm that the list still scrolls after ALT-TABing. The L&F is set to Metal since it is the cross-platform lookandfeel and has directional buttons for the JScrollPane list.

I can verify on linux machine that it is suto-scrolling but it is intermittent on windows as well as on linux. Sometimes the list is scrolling and sometimes it's not. Are you facing the same?
To regain focus, if click on frame title bar then the intermittent issue can be observed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20845#issuecomment-2328163032

From duke at openjdk.org  Wed Sep  4 12:10:29 2024
From: duke at openjdk.org (Daniel Gredler)
Date: Wed, 4 Sep 2024 12:10:29 GMT
Subject: RFR: 8337681: PNGImageWriter uses much more memory than necessary
 [v2]
In-Reply-To: <xfHx_-FoHIC56O_5JRVxI_rMHxYSznZM-eHVa4PMiqs=.2c8949a5-0ad4-4fef-922b-15fc587f20aa@github.com>
References: <CSTpfVr55ahBWOCkao8Ri0CP97dX0t9BERx4Q1yh0d0=.8d458f70-66c9-4bdc-a826-ada3bd51394a@github.com>
 <8ZstKFyu435jMQ9_44gJwjCtz1N1at3B_wqbsDi2msE=.aede545e-7d62-4af6-9f51-5682a5281ac3@github.com>
 <xfHx_-FoHIC56O_5JRVxI_rMHxYSznZM-eHVa4PMiqs=.2c8949a5-0ad4-4fef-922b-15fc587f20aa@github.com>
Message-ID: <sT-VPjzuxDmbjRozxiuEY3hqCLJSar5mLziSmpozb9Y=.58ab7032-c52c-45c0-a44f-30829e4b85a1@github.com>

On Tue, 3 Sep 2024 17:07:46 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Daniel Gredler has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - JDK-8337681: add tests for TYPE_4BYTE_ABGR
>>  - JDK-8337681: add tests for TYPE_INT_RGB
>
> src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGImageWriter.java line 924:
> 
>> 922:         for (int row = minY + yOffset; row < minY + height; row += ySkip) {
>> 923:             Raster ras;
>> 924:             if (image instanceof BufferedImage bi) {
> 
> Do we really need to run these two blocks in the loop for each iteration?

Hi Sergey! The current logic does make it very clear where and how `ras` is initialized, which is nice. The top two initialization blocks (for `BufferedImage`s and tiled images) could in theory be hoisted outside the loop, but the third one cannot (and we might have to jump through some hoops to guarantee to the compiler that the variable is initialized if we start initializing it sometimes in one place and sometimes in another).

AFAICT the `BufferedImage.getRaster()` call is not doing any work (just providing a reference to an instance variable), but the `getTile(...)` call might be doing some extra work, depending on the specific instance type (but in any event will not be copying raster data, which was by far the biggest waste here).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20432#discussion_r1743656653

From abhiscxk at openjdk.org  Wed Sep  4 12:46:21 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 4 Sep 2024 12:46:21 GMT
Subject: RFR: 6672644: JComboBox still scrolling if switch to another
 window and return back.
In-Reply-To: <vOzWxTYyh6qDyDB7sg2I1DjLG0I0ZZFb9sG9qKRd--4=.647cbf42-332c-430b-b12a-763bbee68ff3@github.com>
References: <vOzWxTYyh6qDyDB7sg2I1DjLG0I0ZZFb9sG9qKRd--4=.647cbf42-332c-430b-b12a-763bbee68ff3@github.com>
Message-ID: <qMNotGE7lp6Y3jdyGuZDFfpPry1F0kB-qNM80nYqtRg=.8a5182bf-c0f6-4957-ad01-559831abd750@github.com>

On Wed, 4 Sep 2024 00:54:16 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> In a JComboBox, if the user opens the dropdown list and clicks and holds the down-button, then ALT-TABs to switch focus, when the user re-focuses the frame with the JComboBox and opens the dropdown list again, the list will still be scrolling even though the down-button isn't pressed.
> 
> This isn't OS or L&F specific, although Aqua L&F does not have any directional arrows in the dropdown list (and is thus exempt). This led me to believe it could be handled in BasicComboBoxUI where focusLost and focusGain are used or isPopupVisible but the scroll behavior cannot be altered here. Likewise for BasicComboPopup where `autoscroll` is used. However, this behavior isn't related to autoscroll and is actually found in the JScrollbar of the JScrollpane inside of the JComboBox. The timer for the scroll action starts but is never stopped if focus is lost, so a new listener is created and used. The proposed solution uses `KeyboardFocusManager` to track the focus owner. The listener stops the `scrollTimer` when the `focusOwner` property is changed. With this change, the list no longer automatically scrolls when re-focused and instead opens normally.
> 
> The included test is manual due to the need to confirm that the list still scrolls after ALT-TABing. The L&F is set to Metal since it is the cross-platform lookandfeel and has directional buttons for the JScrollPane list.

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java line 371:

> 369:         scrollbar.addPropertyChangeListener(propertyChangeListener);
> 370:         scrollbar.addFocusListener(getHandler());
> 371:         keyboardFocusManager.addPropertyChangeListener(keyboardFocusListener);

creating `keyboardFocusManager` instance can be avoided and we can directly use `KeyboardFocusManager.getCurrentKeyboardFocusManager().addPropertyChangeListener(keyboardFocusListener);` to add the listener and similarly to remove.

test/jdk/javax/swing/JComboBox/JComboBoxScrollFocusTest.java line 75:

> 73:         JFrame frame = new JFrame("JComboBoxScrollFocusTest Test Frame");
> 74:         JComboBox combobox = new JComboBox();
> 75:         for (int i = 0; i< 100; i ++) {

Suggestion:

        for (int i = 0; i < 100; i++) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20845#discussion_r1743717017
PR Review Comment: https://git.openjdk.org/jdk/pull/20845#discussion_r1743692496

From aivanov at openjdk.org  Wed Sep  4 16:15:28 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 4 Sep 2024 16:15:28 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v7]
In-Reply-To: <QweXa3qMo3QTx7GMt3jACHTj85pE24c-XypNVxvtCdE=.8e555e97-9153-4375-8c97-9f4036dd716f@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <QweXa3qMo3QTx7GMt3jACHTj85pE24c-XypNVxvtCdE=.8e555e97-9153-4375-8c97-9f4036dd716f@github.com>
Message-ID: <y6GbW6nFOYrEwZ5RvwJ-xXbw_slBMXdE09VacjnvOH4=.509b4ceb-9b5c-4f24-99e0-369ab68ecfb4@github.com>

On Mon, 5 Aug 2024 04:46:47 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:

>> This testcase checks for the following assertions for Component events:
>> 
>> 1. When components are resized, moved, hidden and shown the respective events are triggered.
>> 2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
>> 3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
>> 4. When a window is minimized/restored then hidden and shown component events should be triggered.
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.
>
> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8333403: Review comments fixed

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 1:

> 1: /*

I suggest moving the test to `java/awt/Component` ? you're testing the functionality of `Component` class and its subclasses.

It looks to me all the tests under `java/awt/event` should be moved to a particular component where the event is expected or not expected to be generated. So that these tests aren't missed when that component is modified and the developer runs tests for that specific component.

Yes, the developer is expected to run all the tests anyway, however, I would still expect all tests related to a component be under the component class folder.

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 67:

> 65:     private static volatile Dimension compSize;
> 66:     private static final java.util.Collection<ComponentEvent> events =
> 67:         Collections.synchronizedList(new ArrayList<ComponentEvent>());

Any reason why you use fully qualified `java.util.Collection` class name instead of importing it?

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 67:

> 65:     private static volatile Dimension compSize;
> 66:     private static final java.util.Collection<ComponentEvent> events =
> 67:         Collections.synchronizedList(new ArrayList<ComponentEvent>());

Suggestion:

    private static final Collection<ComponentEvent> events =
        Collections.synchronizedList(new ArrayList<>());

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 67:

> 65:     private static volatile Dimension compSize;
> 66:     private static final java.util.Collection<ComponentEvent> events =
> 67:         Collections.synchronizedList(new ArrayList<ComponentEvent>());

I suggest re-organising the fields in another order and putting blank lines between groups:


    private static final int DELAY = 500;

    private static Frame frame;
    private static Robot robot;

    private static Component[] components;

    private static volatile Point compAt;
    private static volatile Dimension compSize;

    private static volatile boolean componentHidden;
    private static volatile boolean componentShown;
    private static volatile boolean componentMoved;
    private static volatile boolean componentResized;

    private static final Collection<ComponentEvent> events =
        Collections.synchronizedList(new ArrayList<ComponentEvent>());


This way it's more readable in my opinion.

The most common: `frame` and `robot`, then array of components, location to click on (see below as well), event flags and a list (collection) of generated events.

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 157:

> 155:         EventQueue.invokeAndWait(() -> {
> 156:             compAt = components[9].getLocationOnScreen();
> 157:             compSize = components[9].getSize();

Why did you change it from 0 to 9?

The number 9 looks like a magic number, it may change if anything changes in the `components` array.

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 161:

> 159: 
> 160:         robot.mouseMove(compAt.x + compSize.width / 2,
> 161:             compAt.y + compSize.height / 2);

Suggestion:

        // Add a comment why you click a component
        EventQueue.invokeAndWait(() -> {
            Point location = components[9].getLocationOnScreen();
            Dimension size = components[9].getSize();
            centerPoint = new Point(location.x + size.width / 2,
                                    location.y + size.height / 2);
        });
        robot.mouseMove(centerPoint.x, centerPoint.y);

You can calculate the center point where you click inside `invokeAndWait` and then assign the resulting value to `centerPoint` (rename `compAt` to `centerPoint` or another name). Remove `compSize`.

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 164:

> 162: 
> 163:         robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
> 164:         robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);

Why do you click a component? You didn't answer the previous question.

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 174:

> 172:         robot.delay(DELAY);
> 173: 
> 174:         resetValues();

Suggestion:

        System.out.println("Iconify frame");
        resetValues();


Print a message what you're testing.

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 177:

> 175:         EventQueue.invokeAndWait(() -> frame.setExtendedState(Frame.ICONIFIED));
> 176: 
> 177:         robot.delay(DELAY);

Suggestion:

        robot.waitForIdle();
        robot.delay(DELAY);

Since changing the state of frame generates system events, it's better to add `waitForIdle()` to ensure all the system event are processed before you test the flags.

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 183:

> 181:         }
> 182: 
> 183:         resetValues();

Suggestion:

        System.out.println("Deiconify frame");
        resetValues();

Print a message.

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 201:

> 199:         System.err.println();
> 200:         throw new RuntimeException("FAIL: " + errorMsg);
> 201:     }

So you're collecting a list of events to print them if iconify or deiconify generates an unexpected list of events.

In all other cases `events` isn't used at all.

Given that all the generated events are printed as they're come, I see no reason why `events` is needed at all. By printing messages that you're about to test iconifying frame and deiconifying frame you separate the cases, the list of events will be printed between these messages.

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 206:

> 204:         throws InvocationTargetException, InterruptedException {
> 205: 
> 206:         Component currentComponent = components[i];

Suggestion:

    private static void doTest(final Component currentComponent, boolean enable)
        throws InvocationTargetException, InterruptedException {

You don't use the index for anything else but assigning the current component ? pass it into the method. Replace any occurrences of `components[i]` with `currentComponent`, it'll be consistent.

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 208:

> 206:         Component currentComponent = components[i];
> 207:         System.out
> 208:             .println("Component " + currentComponent + "is enabled " + enable);

It is so uncommon to break `System.out.println` this way, these are usually kept together.

Anyway, I suggest splitting that into two lines: `toString` representation of a component is pretty long, therefore printing the `enabled` flag on its own line helps to see it.
Suggestion:

        System.out.println("Component " + currentComponent);
        System.out.println("  enabled " + enable);

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 305:

> 303:                 + "when size decreases for " + components[i].getClass());
> 304:         }
> 305:     }

Suggestion:

        }

        System.out.println("\n");
    }

Printing two blank lines after a component is tested will help you parse the log. You'll be able to easily find where one portion of the test finishes and another starts.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19521#pullrequestreview-2280441854
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1744073977
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1743933493
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1743949637
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1743980292
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1743971465
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1743997273
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1743985969
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1744051268
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1744061638
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1744051797
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1744058260
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1744028795
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1744033326
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1744036241

From aivanov at openjdk.org  Wed Sep  4 16:15:29 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 4 Sep 2024 16:15:29 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v7]
In-Reply-To: <y6GbW6nFOYrEwZ5RvwJ-xXbw_slBMXdE09VacjnvOH4=.509b4ceb-9b5c-4f24-99e0-369ab68ecfb4@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <QweXa3qMo3QTx7GMt3jACHTj85pE24c-XypNVxvtCdE=.8e555e97-9153-4375-8c97-9f4036dd716f@github.com>
 <y6GbW6nFOYrEwZ5RvwJ-xXbw_slBMXdE09VacjnvOH4=.509b4ceb-9b5c-4f24-99e0-369ab68ecfb4@github.com>
Message-ID: <-KNXygH0dh8yifIeVTz0ICWx2xev2EOVqiIx1Pr-ZdQ=.68cfe7e3-7856-4253-a418-3bed76a7e7f6@github.com>

On Wed, 4 Sep 2024 15:20:46 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8333403: Review comments fixed
>
> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 161:
> 
>> 159: 
>> 160:         robot.mouseMove(compAt.x + compSize.width / 2,
>> 161:             compAt.y + compSize.height / 2);
> 
> Suggestion:
> 
>         // Add a comment why you click a component
>         EventQueue.invokeAndWait(() -> {
>             Point location = components[9].getLocationOnScreen();
>             Dimension size = components[9].getSize();
>             centerPoint = new Point(location.x + size.width / 2,
>                                     location.y + size.height / 2);
>         });
>         robot.mouseMove(centerPoint.x, centerPoint.y);
> 
> You can calculate the center point where you click inside `invokeAndWait` and then assign the resulting value to `centerPoint` (rename `compAt` to `centerPoint` or another name). Remove `compSize`.

I also suggest removing the blank line between `mouseMove` and `mousePress` and `mouseRelease`.

> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 164:
> 
>> 162: 
>> 163:         robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
>> 164:         robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 
> Why do you click a component? You didn't answer the previous question.

If you expect anything to change in the UI state after you click, you should add `robot.waitForIdle()`. Yes, you used `robot.setAutoWaitForIdle(true)`, so robot with call `waitForIdle()` after each event generated. Alternatively, you can add `robot.delay(DELAY)` to wait a little to guarantee what you expect has happened before you continue with the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1744001163
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1744007695

From aivanov at openjdk.org  Wed Sep  4 16:15:30 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 4 Sep 2024 16:15:30 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v6]
In-Reply-To: <LgtHsnsX7NzUQXkb1QxZ3T-qBBVWkR5PVavc4uvPQFI=.95d627c2-8692-470c-859f-6a8b6ef07cd0@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <JW9jDWC8Gcz9H6MDYnHEXv4MY-lV0IFuyO5dQkEXzaw=.b1364df2-62ae-41e3-a8bb-d2003e2e786f@github.com>
 <LgtHsnsX7NzUQXkb1QxZ3T-qBBVWkR5PVavc4uvPQFI=.95d627c2-8692-470c-859f-6a8b6ef07cd0@github.com>
Message-ID: <j3Yz0BbMOKUZfK6c-vqHAm2sGQJIGAQ65BTVbU-nwy8=.0cc26718-041e-4cd4-b17c-d93fd02d8c5b@github.com>

On Wed, 24 Jul 2024 19:23:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8333403: Review commnets fixed
>
> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 164:
> 
>> 162: 
>> 163:         robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
>> 164:         robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 
> Do you click the panel to ensure the frame has focus?
> 
> Does the test fail if the frame fails to be the active frame for whatever reason? (It should always be the active frame / window.)

You didn't answer the question and marked it resolved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1743984396

From aivanov at openjdk.org  Wed Sep  4 16:15:31 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 4 Sep 2024 16:15:31 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v6]
In-Reply-To: <tPc_DYcQiHelb4ll56MnPYSIU6hq03ZHQMuhF7k4fM0=.026f1278-5c2f-4fbe-be2a-cb7146f3f281@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <JW9jDWC8Gcz9H6MDYnHEXv4MY-lV0IFuyO5dQkEXzaw=.b1364df2-62ae-41e3-a8bb-d2003e2e786f@github.com>
 <LgtHsnsX7NzUQXkb1QxZ3T-qBBVWkR5PVavc4uvPQFI=.95d627c2-8692-470c-859f-6a8b6ef07cd0@github.com>
 <tPc_DYcQiHelb4ll56MnPYSIU6hq03ZHQMuhF7k4fM0=.026f1278-5c2f-4fbe-be2a-cb7146f3f281@github.com>
Message-ID: <PtW1s2ZEPwpXX3x0kQN4XIkIlTuEBx6wBEC8Zm9QzFw=.fdf51273-1357-4117-9fc1-a93407b5d170@github.com>

On Mon, 5 Aug 2024 11:52:45 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:

> when form Frame.ICONIFIED to Frame.NORMAL componentMoved and componentResized events are triggered

Then verify that these events are triggered:


-        if (componentShown || componentHidden) {
+        if (componentShown || componentHidden || !componentMoved
+            || !componentResized) {

Otherwise it looks as if you forgot to test something. You may have two `if` statements to print more precise error message.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1744049100

From aivanov at openjdk.org  Wed Sep  4 16:40:25 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 4 Sep 2024 16:40:25 GMT
Subject: RFR: 8332901: Select{Current,New}ItemTest.java for Choice don't
 open popup on macOS [v4]
In-Reply-To: <KyKNGYzOO-lcl82oWEjbDhqZlr_-LRb-HcoxfXs-IGo=.feb89b2a-d0df-420e-9157-ca06a103de08@github.com>
References: <EiUBUmg_gdulvKa5GkanBoOt2N5X2AAwJ8O1BtVLVDI=.cb84fef8-a90a-46c2-98d9-51eb59fd9390@github.com>
 <EwXVqBvO9Kr5apShAKDB1qOXGVWovh5kqCKhUmZPSbQ=.a5df5028-99a3-4945-86dd-f72f8bc3304a@github.com>
 <D0E84Avs8G-SPsT3-HQxhL6sgGyfjsN3v8i_DRIoVg4=.268d0fcf-3ddc-4bb9-9fbf-000087309dc1@github.com>
 <KyKNGYzOO-lcl82oWEjbDhqZlr_-LRb-HcoxfXs-IGo=.feb89b2a-d0df-420e-9157-ca06a103de08@github.com>
Message-ID: <LGM8V5nJ7iWFTyG9rrFWECnAsSAyWYdIalFxs0F3rIA=.1408c336-e97f-4bd9-8589-2584cee13ad0@github.com>

On Tue, 20 Aug 2024 20:03:48 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I found another test which tests the same scenario as `SelectNewItemTest`, it's `test/jdk/java/awt/event/ComponentEvent/ComponentItemEventTest.java`. It was added in #11786. I'm going to submit a bug to remove this scenario from the `ComponentItemEventTest` test.

I submitted [JDK-8339338](https://bugs.openjdk.org/browse/JDK-8339338) to remove `Choice` from `ComponentItemEventTest`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20601#issuecomment-2329525130

From aivanov at openjdk.org  Wed Sep  4 16:40:26 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 4 Sep 2024 16:40:26 GMT
Subject: Integrated: 8332901: Select{Current,
 New}ItemTest.java for Choice don't open popup on macOS
In-Reply-To: <EiUBUmg_gdulvKa5GkanBoOt2N5X2AAwJ8O1BtVLVDI=.cb84fef8-a90a-46c2-98d9-51eb59fd9390@github.com>
References: <EiUBUmg_gdulvKa5GkanBoOt2N5X2AAwJ8O1BtVLVDI=.cb84fef8-a90a-46c2-98d9-51eb59fd9390@github.com>
Message-ID: <xr3kpoI2xwfYXV_BsOawmJ7PHmkZw5T1BN4wUR9MXaQ=.fc065122-2681-4df7-baf6-b46e106ceee7@github.com>

On Thu, 15 Aug 2024 18:02:33 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I looked at `java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.java`, ran it and noticed that the test does not open the popup of the `Choice` component on macOS 14.x.
> 
> If the popup does not open, the test does not verify anything ? it always passes.
> 
> I refactored the test and added a mouse listener to the `Choice` component. If mouse click isn't registered, the test fails.
> 
> Later, I found a similar test: `test/jdk/java/awt/Choice/SelectNewItemTest/SelectNewItemTest.java`. It clicks on another item in the Choice popup and expects to receive `ItemEvent`.
> 
> I refactored both tests and moved them into `Choice/SelectItem` folder.
> 
> `SelectCurrentItemTest` encapsulates the common test logic and provides overridable methods to customise conditions for `SelectNewItemTest`.
> 
> Now, `SelectNewItemTest` extends `SelectCurrentItemTest` and overrides the conditions as well as the coordinates for clicking the popup of the `Choice` component.
> 
> ~~The updated test fails for me locally on macOS Sonoma 14.5. This is likely the result of [JDK-8322653](https://bugs.openjdk.org/browse/JDK-8322653): _[macos14] : Mouse clicks are not received within 3 pixels of the window boundary_.~~
> 
> To work around JDK-8322653, both tests use non-resizable frame. Both updated tests pass on CI and locally on macOS 14.5. This is why I removed `SelectNewItemTest` from problem-list.

This pull request has now been integrated.

Changeset: ef96a7b0
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ef96a7b014795f366af3a90ef8f474cfb621197f
Stats:     593 lines in 5 files changed: 276 ins; 317 del; 0 mod

8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS

Move SelectCurrentItemTest.java to java/awt/Choice/SelectItem/.
Move SelectNewItemTest.java to java/awt/Choice/SelectItem/.
Use latches to control test flow instead of delays.
Encapsulate the common logic in SelectCurrentItemTest.
Provide overridable checkXXX() methods to modify conditions.
Provide an overridable method which defines where to click
in the choice popup to select an item.

Reviewed-by: honkar, prr, dnguyen

-------------

PR: https://git.openjdk.org/jdk/pull/20601

From honkar at openjdk.org  Wed Sep  4 17:12:21 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 4 Sep 2024 17:12:21 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v3]
In-Reply-To: <IvS76KgbntrLx7wR0a65Cp-QrGNHjsgtzGTm2mUVU_c=.bff06a6f-3128-4dfe-aaed-6e20904e5030@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <IvS76KgbntrLx7wR0a65Cp-QrGNHjsgtzGTm2mUVU_c=.bff06a6f-3128-4dfe-aaed-6e20904e5030@github.com>
Message-ID: <KbvArJknypDhDqo3slHzrbqOR16PrmR9nUey7KrkMIU=.ae275716-a2ef-47e2-8024-73fd02679238@github.com>

On Wed, 4 Sep 2024 05:48:53 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rather than left top.
>> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated based on review comments

Updated changes LGTM,
I'm okay with color tolerance set to 10 but if a smaller value works for this test (in CI testing) then it might be better to be more restrictive with color tolerance.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20723#issuecomment-2329586131

From mvs at openjdk.org  Wed Sep  4 17:30:59 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Wed, 4 Sep 2024 17:30:59 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v5]
In-Reply-To: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
Message-ID: <J1D5xWqpCbjL5VddngNL5dACCSFHxbaVfsAP1AdJeTo=.a8f0e1cd-5025-47eb-a9e5-7cbcbeb242d1@github.com>

> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
> 
> Failure reason:
> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
> 
> Fix:
> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted

Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:

  Added null check to frame before disposing

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20777/files
  - new: https://git.openjdk.org/jdk/pull/20777/files/353b304f..2684224f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20777&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20777&range=03-04

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/20777.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20777/head:pull/20777

PR: https://git.openjdk.org/jdk/pull/20777

From mvs at openjdk.org  Wed Sep  4 17:31:00 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Wed, 4 Sep 2024 17:31:00 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v4]
In-Reply-To: <gbCjAhftOaHV-e15W2Qni6aZYaNZhTGB6vZZyKZKWGw=.082363dc-5684-4a39-a7be-4c32ef8ef530@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
 <y1r4OF7qQyQ55m9ge5175I6FsPwVkxcuWQ-kmWZgxLY=.270c86dc-a0d5-446f-92a9-d6cdca465aed@github.com>
 <vLGAv8rTiiv_FjxNpFB1XKqNNcvC1VgITlV_IE6lAkY=.6d0c4ce3-5665-4b89-a7cf-f92373e25882@github.com>
 <QB6Z5SC3X0q8HTemTZGEH8nX_EXoqOhWK_rqUmZi8Qk=.c9b89e4e-3467-4a98-a422-ea26c2926e32@github.com>
 <l_aRardmWyl_VnE3lUDxrlj61i-vp49O6cJRLqqMTpA=.bdc4085e-4f75-4e74-8f2e-629892f2ef60@github.com>
 <gbCjAhftOaHV-e15W2Qni6aZYaNZhTGB6vZZyKZKWGw=.082363dc-5684-4a39-a7be-4c32ef8ef530@github.com>
Message-ID: <lbYj4K3-nFBePBeWmz_mlB1vOxaKUDJ-L72aJuvu5gs=.7e560034-b78e-4b30-b0f5-78adb7a19fbc@github.com>

On Wed, 4 Sep 2024 07:25:59 GMT, Tejesh R <tr at openjdk.org> wrote:

>> I don't see a chance for that as the frame is initialized in createGUI() and there are lot of code which directly access frame object there itself, so if it was null, it would have thrown the Nullpointer even before. Anyway, I had this null check before, but removed it as per @honkar-jdk 's review comment.
>
> `Frame is assigned null after disposing which is not required and can be removed.` I hope u r referring to this comment. I hope she meant to remove null assignment after dispose is called.

Yes, added the null check back.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20777#discussion_r1744173520

From honkar at openjdk.org  Wed Sep  4 17:43:19 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 4 Sep 2024 17:43:19 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v4]
In-Reply-To: <lbYj4K3-nFBePBeWmz_mlB1vOxaKUDJ-L72aJuvu5gs=.7e560034-b78e-4b30-b0f5-78adb7a19fbc@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <9p6g6LHUjWZxmEOb_-NqWp5Ee2cGGPdjVSCpRswv-U4=.611f522a-939b-49e3-b1be-001eb6951474@github.com>
 <y1r4OF7qQyQ55m9ge5175I6FsPwVkxcuWQ-kmWZgxLY=.270c86dc-a0d5-446f-92a9-d6cdca465aed@github.com>
 <vLGAv8rTiiv_FjxNpFB1XKqNNcvC1VgITlV_IE6lAkY=.6d0c4ce3-5665-4b89-a7cf-f92373e25882@github.com>
 <QB6Z5SC3X0q8HTemTZGEH8nX_EXoqOhWK_rqUmZi8Qk=.c9b89e4e-3467-4a98-a422-ea26c2926e32@github.com>
 <l_aRardmWyl_VnE3lUDxrlj61i-vp49O6cJRLqqMTpA=.bdc4085e-4f75-4e74-8f2e-629892f2ef60@github.com>
 <gbCjAhftOaHV-e15W2Qni6aZYaNZhTGB6vZZyKZKWGw=.082363dc-5684-4a39-a7be-4c32ef8ef530@github.com>
 <lbYj4K3-nFBePBeWmz_mlB1vOxaKUDJ-L72aJuvu5gs=.7e560034-b78e-4b30-b0f5-78adb7a19fbc@github.com>
Message-ID: <-b6e1MVWhJHx2Lz2vNmEkdOk6pHrZrBoqEnCaq4KTD0=.c010dc70-074f-40c4-87a3-330693924b03@github.com>

On Wed, 4 Sep 2024 17:26:42 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> `Frame is assigned null after disposing which is not required and can be removed.` I hope u r referring to this comment. I hope she meant to remove null assignment after dispose is called.
>
> Yes, added the null check back.

Right, I meant remove only the null assignment not the null check.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20777#discussion_r1744189358

From serb at openjdk.org  Wed Sep  4 18:52:26 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Wed, 4 Sep 2024 18:52:26 GMT
Subject: RFR: 8327401: Some jtreg tests fail on Wayland without any
 tracking bug [v3]
In-Reply-To: <tWHECNP9oppLE9vt2LH59WlSszOjq3nvCRmQfQscRmo=.228f4b8b-d071-4fc8-8106-636e937dc3ad@github.com>
References: <uf7Ueev2Rc542qY9ckw4046PfqfZIxu96d9J0EGwUIY=.4257a5b9-0950-4d6d-af25-7b1a7a927b08@github.com>
 <yynR9n_N67T8yVIuPcs13E0sCfo1L4mB2nYhUN9DCh8=.f157568f-9793-4c5b-838c-4cb9012ca71d@github.com>
 <tWHECNP9oppLE9vt2LH59WlSszOjq3nvCRmQfQscRmo=.228f4b8b-d071-4fc8-8106-636e937dc3ad@github.com>
Message-ID: <xI3gt8qoVUkzPzgXQOr2xOh5d_rEhUlWhv8_SOXcNmI=.365cadc3-6ec7-4eed-a6ce-2e716f45870d@github.com>

On Wed, 22 May 2024 20:44:54 GMT, Phil Race <prr at openjdk.org> wrote:

>> test/jdk/java/awt/Paint/ListRepaint.java line 40:
>> 
>>> 38:     static Frame frame;
>>> 39: 
>>> 40:     public static void main(final String[] args) throws Exception {
>> 
>> It is critical to call AWT code on EDT in this test, otherwise it may fail with:
>> 
>>> java.lang.NullPointerException: Cannot read field "x" because "this.prevFocusRect" is null
>> 	at java.desktop/sun.awt.X11.XListPeer$ListPainter.paintFocus(XListPeer.java:1976)
>> 	at java.desktop/sun.awt.X11.XListPeer$ListPainter.paint(XListPeer.java:1830)
>> 	at java.desktop/sun.awt.X11.XListPeer.repaint(XListPeer.java:389)
>> 	at java.desktop/sun.awt.X11.XListPeer.repaint(XListPeer.java:364)
>> 	at java.desktop/sun.awt.X11.XListPeer.repaint(XListPeer.java:360)
>> 	at java.desktop/sun.awt.X11.XListPeer.select(XListPeer.java:1214)
>> 	at java.desktop/java.awt.List.select(List.java:598)
>> 	at ListRepaint.test(ListRepaint.java:73)
>> 	at ListRepaint.main(ListRepaint.java:51)
>> 	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>> 	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
>> 	at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
>> 	at java.base/java.lang.Thread.run(Thread.java:1575)
>
> I'm not sure that this should happen, (implemenation bug?) but it is outside the scope of the test updates to fix.

this looks like a product bug.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19339#discussion_r1744270136

From serb at openjdk.org  Wed Sep  4 19:01:27 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Wed, 4 Sep 2024 19:01:27 GMT
Subject: RFR: 8327401: Some jtreg tests fail on Wayland without any
 tracking bug [v3]
In-Reply-To: <N2dmNo8_Zip4rgVf--_qgcM6_8FQATnKsBq9gg3AE78=.eaa54d94-bc04-4c55-ae57-25e776a8ebb0@github.com>
References: <uf7Ueev2Rc542qY9ckw4046PfqfZIxu96d9J0EGwUIY=.4257a5b9-0950-4d6d-af25-7b1a7a927b08@github.com>
 <N2dmNo8_Zip4rgVf--_qgcM6_8FQATnKsBq9gg3AE78=.eaa54d94-bc04-4c55-ae57-25e776a8ebb0@github.com>
Message-ID: <sN9TMZ1yDXFCN_LzXpNCcNByF3PS4Mc9EOWXx0cWmaU=.054a9d7a-dbe6-4fcd-bc7d-f294d3386a4e@github.com>

On Wed, 29 May 2024 09:56:20 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> These changes are intended to stabilize testing on Wayland in X11 compatibility mode.
>> 
>> <hr>
>> 
>> Many tests may fail if there is no `robot.delay()` call after `robot.waitForIdle()` (right after displaying a window).
>> <hr>
>> 
>> Some tests do not release previously pressed mouse button/key, this leads to other test failures later, but it is not a problem for X11 session.
>> I haven't checked this, but it looks like the XWayland server does not release the key/button emulated by XTEST when the client application disconnects, while the regular X11 server does.
>> 
>> <hr>
>> 
>> For some tests it is critical to call AWT code on EDT(it prevents NPE):
>> java/awt/List/KeyEventsTest/KeyEventsTest.java
>> java/awt/Paint/ListRepaint.java
>> 
>> <hr>
>> 
>> Some other explanations can be found inline in the comments for a specific test.
>> <hr>
>> 
>> Testing is green on all platforms.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spacing

test/jdk/java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java line 55:

> 53:             test.doTest();
> 54:         } finally {
> 55:             EventQueue.invokeLater(() -> {

Why invokeLater? it might not be completed before jtreg kills the main thread.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19339#discussion_r1744279740

From serb at openjdk.org  Wed Sep  4 19:09:29 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Wed, 4 Sep 2024 19:09:29 GMT
Subject: RFR: 8327401: Some jtreg tests fail on Wayland without any
 tracking bug [v3]
In-Reply-To: <yynR9n_N67T8yVIuPcs13E0sCfo1L4mB2nYhUN9DCh8=.f157568f-9793-4c5b-838c-4cb9012ca71d@github.com>
References: <uf7Ueev2Rc542qY9ckw4046PfqfZIxu96d9J0EGwUIY=.4257a5b9-0950-4d6d-af25-7b1a7a927b08@github.com>
 <yynR9n_N67T8yVIuPcs13E0sCfo1L4mB2nYhUN9DCh8=.f157568f-9793-4c5b-838c-4cb9012ca71d@github.com>
Message-ID: <-9336-bEHvkk7xV6_Gv3RrjNnqpa-tEyBiTIunfwFT0=.86e6dbe7-e3bb-4b52-bde6-26424f65bd1a@github.com>

On Wed, 22 May 2024 02:51:31 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   spacing
>
> test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java line 53:
> 
>> 51: import jdk.test.lib.Platform;
>> 52: 
>> 53: public class KeyEventsTest {
> 
> It is critical to call AWT code on EDT in this, otherwise it may fail with:
> 
>> java.lang.NullPointerException: Cannot read field "x" because "this.prevFocusRect" is null
> 	at java.desktop/sun.awt.X11.XListPeer$ListPainter.paintFocus(XListPeer.java:1976)
> 	at java.desktop/sun.awt.X11.XListPeer$ListPainter.paint(XListPeer.java:1799)
> 	at java.desktop/sun.awt.X11.XListPeer.repaint(XListPeer.java:389)
> 	at java.desktop/sun.awt.X11.XListPeer.scrollVertical(XListPeer.java:1469)
> 	at java.desktop/sun.awt.X11.XListPeer.makeVisible(XListPeer.java:1311)
> 	at java.desktop/java.awt.List.makeVisible(List.java:784)
> 	at KeyEventsTest.test(KeyEventsTest.java:235)
> 	at KeyEventsTest.doTest(KeyEventsTest.java:292)
> 	at KeyEventsTest.start(KeyEventsTest.java:107)
> 	at KeyEventsTest.main(KeyEventsTest.java:56)
> 	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> 	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
> 	at java.base/java.lang.Thread.run(Thread.java:1575)

product bug as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19339#discussion_r1744287938

From serb at openjdk.org  Wed Sep  4 19:17:26 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Wed, 4 Sep 2024 19:17:26 GMT
Subject: RFR: 8327401: Some jtreg tests fail on Wayland without any
 tracking bug [v3]
In-Reply-To: <xI3gt8qoVUkzPzgXQOr2xOh5d_rEhUlWhv8_SOXcNmI=.365cadc3-6ec7-4eed-a6ce-2e716f45870d@github.com>
References: <uf7Ueev2Rc542qY9ckw4046PfqfZIxu96d9J0EGwUIY=.4257a5b9-0950-4d6d-af25-7b1a7a927b08@github.com>
 <yynR9n_N67T8yVIuPcs13E0sCfo1L4mB2nYhUN9DCh8=.f157568f-9793-4c5b-838c-4cb9012ca71d@github.com>
 <tWHECNP9oppLE9vt2LH59WlSszOjq3nvCRmQfQscRmo=.228f4b8b-d071-4fc8-8106-636e937dc3ad@github.com>
 <xI3gt8qoVUkzPzgXQOr2xOh5d_rEhUlWhv8_SOXcNmI=.365cadc3-6ec7-4eed-a6ce-2e716f45870d@github.com>
Message-ID: <wbmK3JOaGaiodScvvXwd3USKss0ZFFODzRgBadbjO2I=.cf302bae-a515-466e-903e-1a86ff471dd6@github.com>

On Wed, 4 Sep 2024 18:50:12 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> I'm not sure that this should happen, (implemenation bug?) but it is outside the scope of the test updates to fix.
>
> this looks like a product bug.

see https://bugs.openjdk.org/browse/JDK-8339561

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19339#discussion_r1744296060

From achung at openjdk.org  Wed Sep  4 19:47:54 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 4 Sep 2024 19:47:54 GMT
Subject: RFR: 8339271: JDK-8328999 giflib update removed giflib VCS URL
Message-ID: <9bUf9UKVavgShir_2Z2Hfjelu4gLJUxoWCel8AntU_M=.2a57b6e4-dafa-45ec-97ba-a70da712b2f9@github.com>

Changing format of file paths in giflib copyright file and removing extra text from authors list

-------------

Commit messages:
 - update md file

Changes: https://git.openjdk.org/jdk/pull/20859/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20859&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339271
  Stats: 16 lines in 1 file changed: 6 ins; 10 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20859.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20859/head:pull/20859

PR: https://git.openjdk.org/jdk/pull/20859

From honkar at openjdk.org  Wed Sep  4 20:05:20 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 4 Sep 2024 20:05:20 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v5]
In-Reply-To: <J1D5xWqpCbjL5VddngNL5dACCSFHxbaVfsAP1AdJeTo=.a8f0e1cd-5025-47eb-a9e5-7cbcbeb242d1@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <J1D5xWqpCbjL5VddngNL5dACCSFHxbaVfsAP1AdJeTo=.a8f0e1cd-5025-47eb-a9e5-7cbcbeb242d1@github.com>
Message-ID: <tfZ9A9eeROKrRq0u-Ka3LfLJZYZJySQXQG0P0PRNGcM=.09b1a147-4937-4c92-b6bf-9dae18d93555@github.com>

On Wed, 4 Sep 2024 17:30:59 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
>> 
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
>> 
>> Fix:
>> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added null check to frame before disposing

LGTM

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20777#pullrequestreview-2281129608

From duke at openjdk.org  Wed Sep  4 20:05:20 2024
From: duke at openjdk.org (duke)
Date: Wed, 4 Sep 2024 20:05:20 GMT
Subject: RFR: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize [v5]
In-Reply-To: <J1D5xWqpCbjL5VddngNL5dACCSFHxbaVfsAP1AdJeTo=.a8f0e1cd-5025-47eb-a9e5-7cbcbeb242d1@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
 <J1D5xWqpCbjL5VddngNL5dACCSFHxbaVfsAP1AdJeTo=.a8f0e1cd-5025-47eb-a9e5-7cbcbeb242d1@github.com>
Message-ID: <HUc6LhNfohzDAWbdEYvGeLajmJdKfj3o8anIAibPOXk=.adfe11ce-6b0e-40e2-9669-40f5b359fa1e@github.com>

On Wed, 4 Sep 2024 17:30:59 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
>> 
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
>> 
>> Fix:
>> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added null check to frame before disposing

@openjdk[bot] 
Your change (at version 2684224f3d2b658cf73136688a0e2d65a7bc26a0) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20777#issuecomment-2329870448

From mvs at openjdk.org  Wed Sep  4 20:08:26 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Wed, 4 Sep 2024 20:08:26 GMT
Subject: Integrated: 8339233: Test
 javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button
 renderings are different after window resize
In-Reply-To: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
References: <kMMAH3-_Qlexsg9UxHa7aEQhZTSG2lGKEr704Zu36GQ=.72a94d4f-c5c3-4aa8-81c1-3de58abf1541@github.com>
Message-ID: <QnNKR2m1L-mkMBPG9G2Sug8ztUAcSOZJw-i2PLkqIUE=.45b7dfab-57a1-4cb0-ac8b-831ea8b678c7@github.com>

On Thu, 29 Aug 2024 19:07:29 GMT, Manukumar V S <mvs at openjdk.org> wrote:

> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
> 
> Failure reason:
> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
> 
> Fix:
> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted

This pull request has now been integrated.

Changeset: b8d560b6
Author:    Manukumar V S <mvs at openjdk.org>
Committer: Harshitha Onkar <honkar at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/b8d560b6cd9ea35c747487017107a6caeacf8a98
Stats:     10 lines in 1 file changed: 3 ins; 3 del; 4 mod

8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize

Reviewed-by: honkar

-------------

PR: https://git.openjdk.org/jdk/pull/20777

From duke at openjdk.org  Wed Sep  4 20:10:29 2024
From: duke at openjdk.org (duke)
Date: Wed, 4 Sep 2024 20:10:29 GMT
Subject: Withdrawn: 8334868: Ensure CheckUninstallModalHook is called in
 WPageDialogPeer._show
In-Reply-To: <mU1ZaCGoP8WyXjHofISjz2YTWwTbZtYwZfN5gaUR59M=.909f8142-19ec-488d-8868-54a9ddc79c26@github.com>
References: <mU1ZaCGoP8WyXjHofISjz2YTWwTbZtYwZfN5gaUR59M=.909f8142-19ec-488d-8868-54a9ddc79c26@github.com>
Message-ID: <UzfuD9pfp1QcdnGfDf5t2A1-fnVb-Wl-oUi2PgHdulE=.d5319f33-1b6f-4e85-a575-470bc4d64d78@github.com>

On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> This is somewhat a continuation for [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509).
> 
> The former removed the `doIt` flag in #18584, but it introduced a regression.  
> The regression is resolved by the latter in #19786, and it added the 'doIt' flag again.
> 
> I think using a flag makes the code less clear. When reading the code, one has to keep track of the current value of the `doIt` flag.
> 
> I raised my concern in [comments in PR 19786](https://github.com/openjdk/jdk/pull/19786#discussion_r1649191308):
> 
>> I'd rather keep `JNI_FALSE` here ? it's more explicit and therefore clearer. You don't have to keep track of the value of `doIt` flag while reading the code.
>> 
>> In fact, I'd prefer no `doIt` flag at all? yet it makes handling the code below `if (ret)` slightly harder.
> 
> I came up with a solution which simplifies handling the clean-up. The solution relies on C++ destructors which are called when the declared objects go out of scope.
> 
> The C++ object wraps a lambda function to clean up and invokes this function in its destructor. Such C++ class has to be a templated class because there's no defined type to represent a lambda. The class has to be declared at the top of the file because it needs C++ linkage.
> 
> There are two `Cleaner` objects declared in the code of `Java_sun_awt_windows_WPageDialogPeer__1show`:
> 
> **`refCleaner`** is declared right after all the references to Java objects are initialised. The corresponding `refCleanup` lambda deletes all the references and replaces the `CLEANUP_SHOW` macro. Before JDK-8307160, the code jumped to a go-to label to perform the clean-up.
> 
> **`postCleaner`** is declared after `AwtDialog::CheckInstallModalHook` is called. Its lambda `postCleanup` uninstalls the modal hook and handles focus transfer as well as saves the updated printer parameters.
> 
> It is `postCleaner` that resolves the bug JDK-8334868 by ensuring `CheckUninstallModalHook` and `ModalActivateNextWindow` are called if `::PageSetupDlg` is called.
> 
> As the result of using `refCleaner`, all the `return` statements in the function use an explicit value, which makes the code cleaner. There's no need to use a `go to` statement or insert a macro to delete references to Java objects, about which one had to remember ? the destructor of the `refCleaner` handles deleting references when `refCleaner` goes out of scope, that is when the function returns.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/19867

From serb at openjdk.org  Wed Sep  4 20:50:27 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Wed, 4 Sep 2024 20:50:27 GMT
Subject: RFR: 8327401: Some jtreg tests fail on Wayland without any
 tracking bug [v3]
In-Reply-To: <N2dmNo8_Zip4rgVf--_qgcM6_8FQATnKsBq9gg3AE78=.eaa54d94-bc04-4c55-ae57-25e776a8ebb0@github.com>
References: <uf7Ueev2Rc542qY9ckw4046PfqfZIxu96d9J0EGwUIY=.4257a5b9-0950-4d6d-af25-7b1a7a927b08@github.com>
 <N2dmNo8_Zip4rgVf--_qgcM6_8FQATnKsBq9gg3AE78=.eaa54d94-bc04-4c55-ae57-25e776a8ebb0@github.com>
Message-ID: <e9mkbQXt7EMPODXsxvw0nJanKz6lGEGSCHzj0hyh8oo=.c1914ba8-68c8-4a8c-a02e-bc021424c85a@github.com>

On Wed, 29 May 2024 09:56:20 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> These changes are intended to stabilize testing on Wayland in X11 compatibility mode.
>> 
>> <hr>
>> 
>> Many tests may fail if there is no `robot.delay()` call after `robot.waitForIdle()` (right after displaying a window).
>> <hr>
>> 
>> Some tests do not release previously pressed mouse button/key, this leads to other test failures later, but it is not a problem for X11 session.
>> I haven't checked this, but it looks like the XWayland server does not release the key/button emulated by XTEST when the client application disconnects, while the regular X11 server does.
>> 
>> <hr>
>> 
>> For some tests it is critical to call AWT code on EDT(it prevents NPE):
>> java/awt/List/KeyEventsTest/KeyEventsTest.java
>> java/awt/Paint/ListRepaint.java
>> 
>> <hr>
>> 
>> Some other explanations can be found inline in the comments for a specific test.
>> <hr>
>> 
>> Testing is green on all platforms.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spacing

I'll tweak some of these tests under https://bugs.openjdk.org/browse/JDK-8339561

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19339#issuecomment-2329978844

From honkar at openjdk.org  Wed Sep  4 20:52:23 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 4 Sep 2024 20:52:23 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v3]
In-Reply-To: <wbsdqxvBH7ROBbZM2RUENJdWtPtW3zNpCtE0Iw3sTr4=.adf40d96-56cd-49af-98fd-3c1f3b77a0e6@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <qpHqg_8nTSSzAdzwjANK672ju1x9fd3eRF8_bvXamJ4=.2d65ea32-ad57-4a64-9c06-d3bca6350e60@github.com>
 <wbsdqxvBH7ROBbZM2RUENJdWtPtW3zNpCtE0Iw3sTr4=.adf40d96-56cd-49af-98fd-3c1f3b77a0e6@github.com>
Message-ID: <x37btMFY9y27PbHheo1AgvJF015kZTE6rpB6lzhI-ZE=.8c889497-4173-45be-8e96-a42fa70f94ba@github.com>

On Mon, 2 Sep 2024 05:14:23 GMT, Tejesh R <tr at openjdk.org> wrote:

> On failure we are saving the image, I don't think logging pixelColor would add any additional help in debugging here.

True, this is not for the failure case but to get some idea on which pixel colors are picked up with the current color tolerance and to adjust the tolerance value accordingly after running CI tests. It is not required though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20723#discussion_r1744425750

From honkar at openjdk.org  Wed Sep  4 20:55:19 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 4 Sep 2024 20:55:19 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v3]
In-Reply-To: <IvS76KgbntrLx7wR0a65Cp-QrGNHjsgtzGTm2mUVU_c=.bff06a6f-3128-4dfe-aaed-6e20904e5030@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <IvS76KgbntrLx7wR0a65Cp-QrGNHjsgtzGTm2mUVU_c=.bff06a6f-3128-4dfe-aaed-6e20904e5030@github.com>
Message-ID: <0vrFE1dMuk0uIFmV9L0d6H1cLEnFjZ7uB0BpXphzonk=.e20325b8-48d2-4ec1-b026-fb65c62ff93d@github.com>

On Wed, 4 Sep 2024 05:48:53 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rather than left top.
>> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated based on review comments

> I'm okay with color tolerance set to 10 but if a smaller value works for this test (in CI testing) then it might be better to be more restrictive with color tolerance.

LGTM other than the color tolerance comment as mentioned above.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20723#pullrequestreview-2281285836

From jiangli at openjdk.org  Wed Sep  4 23:39:54 2024
From: jiangli at openjdk.org (Jiangli Zhou)
Date: Wed, 4 Sep 2024 23:39:54 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
Message-ID: <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>

On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.
> 
> This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 
> 
> All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).

make/StaticLibs.gmk line 1:

> 1: #

Perhaps also consider adopting StaticLink.gmk file name from the https://github.com/openjdk/leyden/tree/hermetic-java-runtime/ branch, as we are mostly doing the static linking here. Creating the static libs is handled elsewhere.

make/StaticLibs.gmk line 71:

> 69:   # libsspi_bridge has name conflicts with sunmscapi
> 70:   BROKEN_STATIC_LIBS += sspi_bridge
> 71:   # These libs define DllMain which conflict with Hotspot

I'm not aware of the DllMain issue with static linking these libs. Could you please explain? The libawt.a and libdt_socket.a are statically linked with `javastatic` in https://github.com/openjdk/leyden/tree/hermetic-java-runtime/ branch.

make/StaticLibs.gmk line 74:

> 72:   BROKEN_STATIC_LIBS += awt dt_shmem dt_socket javaaccessbridge
> 73:   # These libs are dependent on any of the above disabled libs
> 74:   BROKEN_STATIC_LIBS += fontmanager jawt lcms net nio

Which specific dependent cause these libs being excluded? In https://github.com/openjdk/leyden/tree/hermetic-java-runtime/ branch, these JDK libs (except `libjawt.a`) are statically linked into `javastatic`.

make/StaticLibs.gmk line 118:

> 116:     OPTIMIZATION := HIGH, \
> 117:     STATIC_LAUNCHER := true, \
> 118:     LDFLAGS := $(JAVASTATIC_LINK_LDFLAGS), \

I could be missing something, but I don't see where is $JAVASTATIC_LINK_LDFLAGS defined.

On a related notes, I think we need to include $JVM_LDFLAGS when linking the static "java". See https://bugs.openjdk.org/browse/JDK-8339522?focusedId=14702923&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14702923.

make/modules/java.desktop/lib/AwtLibraries.gmk line 176:

> 174: 
> 175:   ifneq ($(ENABLE_HEADLESS_ONLY), true)
> 176:     # We cannot link with both awt_headless and awt_xawt at the same time

Just a note on that. It's doable to link with both awt_headless and awt_xawt with some work. I did some quick experiments on that during the initial investigation for hermetic/static Java.

src/java.base/unix/native/libjli/java_md.c line 300:

> 298:                            char jvmcfg[],  jint so_jvmcfg) {
> 299:     /* Compute/set the name of the executable. This is needed for macOS. */
> 300:     SetExecname(*pargv);

Why is `SetExecname()` needed for the static case?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1744614583
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1744604685
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1744603414
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1744611776
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1744616878
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1744620611

From honkar at openjdk.org  Thu Sep  5 00:00:53 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 5 Sep 2024 00:00:53 GMT
Subject: RFR: 6672644: JComboBox still scrolling if switch to another
 window and return back.
In-Reply-To: <vOzWxTYyh6qDyDB7sg2I1DjLG0I0ZZFb9sG9qKRd--4=.647cbf42-332c-430b-b12a-763bbee68ff3@github.com>
References: <vOzWxTYyh6qDyDB7sg2I1DjLG0I0ZZFb9sG9qKRd--4=.647cbf42-332c-430b-b12a-763bbee68ff3@github.com>
Message-ID: <-thiCdaj9qlQshgmU0oRqI_DIqS5FWayBL_JQPk0GSY=.5d5f0f32-5506-4bc0-b7bd-bd68e4a42e27@github.com>

On Wed, 4 Sep 2024 00:54:16 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> In a JComboBox, if the user opens the dropdown list and clicks and holds the down-button, then ALT-TABs to switch focus, when the user re-focuses the frame with the JComboBox and opens the dropdown list again, the list will still be scrolling even though the down-button isn't pressed.
> 
> This isn't OS or L&F specific, although Aqua L&F does not have any directional arrows in the dropdown list (and is thus exempt). This led me to believe it could be handled in BasicComboBoxUI where focusLost and focusGain are used or isPopupVisible but the scroll behavior cannot be altered here. Likewise for BasicComboPopup where `autoscroll` is used. However, this behavior isn't related to autoscroll and is actually found in the JScrollbar of the JScrollpane inside of the JComboBox. The timer for the scroll action starts but is never stopped if focus is lost, so a new listener is created and used. The proposed solution uses `KeyboardFocusManager` to track the focus owner. The listener stops the `scrollTimer` when the `focusOwner` property is changed. With this change, the list no longer automatically scrolls when re-focused and instead opens normally.
> 
> The included test is manual due to the need to confirm that the list still scrolls after ALT-TABing. The L&F is set to Metal since it is the cross-platform lookandfeel and has directional buttons for the JScrollPane list.

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java line 1238:

> 1236:                 // Stop scrolling if no longer focus owner
> 1237:                 if (e.getNewValue() == null && scrollTimer.isRunning()) {
> 1238:                     scrollTimer.stop();

In some places `scrollTimer.stop()` is followed by `scrollbar.setValueIsAdjusting(false)`. Is this applicable for KeyboardFocusListener ?
For instance:
https://github.com/openjdk/jdk/blob/0cc3caf2b49426bb6738a9792c88275c0cc7774a/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java#L1608

test/jdk/javax/swing/JComboBox/JComboBoxScrollFocusTest.java line 59:

> 57:             UnsupportedLookAndFeelException, ClassNotFoundException,
> 58:             InstantiationException, IllegalAccessException, AWTException,
> 59:             InterruptedException, InvocationTargetException {

Can this be simplified to throw generic Exception?

test/jdk/javax/swing/JComboBox/JComboBoxScrollFocusTest.java line 85:

> 83:         return frame;
> 84:     }
> 85: }

EOF newline missing here

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20845#discussion_r1744633549
PR Review Comment: https://git.openjdk.org/jdk/pull/20845#discussion_r1744612747
PR Review Comment: https://git.openjdk.org/jdk/pull/20845#discussion_r1744613060

From jiangli at openjdk.org  Thu Sep  5 00:05:50 2024
From: jiangli at openjdk.org (Jiangli Zhou)
Date: Thu, 5 Sep 2024 00:05:50 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
Message-ID: <yIflmF7xMl0tVULX6Hy87pMUllWz6FkuJx4fji1t004=.aec2f5c1-2106-4dbe-83a6-2c0a8cdda35a@github.com>

On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.
> 
> This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 
> 
> All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).

src/hotspot/share/classfile/classLoader.cpp line 953:

> 951:   assert(CanonicalizeEntry == nullptr, "should not load java library twice");
> 952:   if (is_vm_statically_linked()) {
> 953:     CanonicalizeEntry = CAST_TO_FN_PTR(canonicalize_fn_t, os::lookup_function("JDK_Canonicalize"));

Can you add an assert to make sure `CanonicalizeEntry` is not NULL?

src/hotspot/share/classfile/classLoader.cpp line 969:

> 967: 
> 968:   if (is_vm_statically_linked()) {
> 969:       JImageOpen = CAST_TO_FN_PTR(JImageOpen_t, os::lookup_function("JIMAGE_Open"));

It might be good to assert these are not NULL as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1744635408
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1744635916

From jiangli at openjdk.org  Thu Sep  5 00:17:51 2024
From: jiangli at openjdk.org (Jiangli Zhou)
Date: Thu, 5 Sep 2024 00:17:51 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
Message-ID: <WfweadNY7uFR6FfVedxH7wIXrPZvwgtIo9evDUkfwZc=.39943e16-32d8-43a1-b55a-f1f7eca540c6@github.com>

On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.
> 
> This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 
> 
> All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).

src/java.base/unix/native/libjli/java_md.c line 509:

> 507: 
> 508:     if (GetApplicationHome(path, pathsize)) {
> 509:         if (JLI_IsStaticallyLinked()) {

`GetJREPath()` does not need to be called for the static case. Any reason why this path is executed for static mode?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1744642315

From jiangli at openjdk.org  Thu Sep  5 00:27:50 2024
From: jiangli at openjdk.org (Jiangli Zhou)
Date: Thu, 5 Sep 2024 00:27:50 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <b4JPTQvVYy0YD37EA4fkGyoqdNDhmJoI3b5Nmap_Z5A=.8733d6e4-12a7-47da-9c90-87e1836d7a27@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
 <b4JPTQvVYy0YD37EA4fkGyoqdNDhmJoI3b5Nmap_Z5A=.8733d6e4-12a7-47da-9c90-87e1836d7a27@github.com>
Message-ID: <4ZyGLLJL7fVUDI0QXFBOZ1dK97dOjWKDuDCBhsPqEHs=.ac87ad4f-0839-4d5d-a59e-b273f37a6711@github.com>

On Tue, 3 Sep 2024 12:51:13 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> @jianglizhou Can you please check if there are any other contributors that should be acknowledged?

Thanks for asking! I checked all the related changes in https://github.com/openjdk/leyden/tree/hermetic-java-runtime branch. Following are the related commits from the branch corresponding to the extracted changes included in this PR. There are no other author for those changes. However, all changes have go though prior reviews by my teammates. I didn't ask it for the earlier integration PR, is there way to mention the reviewer contributions?

- https://github.com/openjdk/leyden/commit/bceb753f79b4bc767fdfb71d5f68a84430644df6
- https://github.com/openjdk/leyden/commit/a998a9d6ca44a93d4e9859a17de2dca60963de76
- https://github.com/openjdk/leyden/commit/53aa8f0cf418ab5f435a4b9996c7754fb8505d4b
- https://github.com/openjdk/leyden/commit/63f84f5c0a98077c8f49a19f026f103b9e29d6e0
- https://github.com/openjdk/leyden/commit/afe9ca06dd86e8983768de80ba1a08f3c68589b4
- https://github.com/openjdk/leyden/commit/7d75a7f4d6aa020b7580fbbf660b2b3e3a41b27

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20837#issuecomment-2330368791

From tr at openjdk.org  Thu Sep  5 04:48:36 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 5 Sep 2024 04:48:36 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v4]
In-Reply-To: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
Message-ID: <cjkOpnnS25kZpsAUxe8lKseKEPTmxUXbx57AssvQ3PE=.36fc3d5f-4117-417c-914f-d9f61ad0cc3a@github.com>

> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
> 1. Move the frame to center of the screen rather than left top.
> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  reduce tolerance value

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20723/files
  - new: https://git.openjdk.org/jdk/pull/20723/files/9a562914..0f28899d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20723&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20723&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/20723.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20723/head:pull/20723

PR: https://git.openjdk.org/jdk/pull/20723

From jwaters at openjdk.org  Thu Sep  5 05:11:55 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Thu, 5 Sep 2024 05:11:55 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
 <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>
Message-ID: <bfBaJj8ARo7c7iCF7U4ymPRfAbtKotBqj5WU_4z9490=.60be0f5a-a237-4496-905b-ef51128b3189@github.com>

On Wed, 4 Sep 2024 23:06:00 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.
>> 
>> This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 
>> 
>> All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).
>
> make/StaticLibs.gmk line 71:
> 
>> 69:   # libsspi_bridge has name conflicts with sunmscapi
>> 70:   BROKEN_STATIC_LIBS += sspi_bridge
>> 71:   # These libs define DllMain which conflict with Hotspot
> 
> I'm not aware of the DllMain issue with static linking these libs. Could you please explain? The libawt.a and libdt_socket.a are statically linked with `javastatic` in https://github.com/openjdk/leyden/tree/hermetic-java-runtime/ branch.

DllMain is a Windows specific initialization method that is called when a Windows dll (Dynamic library) is loaded, among other things. Since DllMain is extern "C", it is not mangled and hence likely that having multiple static libraries that each define it will cause multiple symbol definition errors during linking. It might be that the reason hermetic Java hasn't encountered this problem yet is because it mainly tests its code on Linux, while this is a Windows specific issue, since the names you mention (libawt.a and libdt_socket.a) are the names of those libraries on Linux, not Windows. However, the issue likely deeper than that. DllMain is completely wrong to define when inside a static library, and should not be compiled at all when making the static versions of these libraries. Simply localizing the DllMain symbol when creating a static library would be wrong. We'll have to find out how to run the initialization code for each of these currently dynamic libraries without DllMain 
 when compiling them as static libraries

> src/hotspot/share/classfile/classLoader.cpp line 953:
> 
>> 951:   assert(CanonicalizeEntry == nullptr, "should not load java library twice");
>> 952:   if (is_vm_statically_linked()) {
>> 953:     CanonicalizeEntry = CAST_TO_FN_PTR(canonicalize_fn_t, os::lookup_function("JDK_Canonicalize"));
> 
> Can you add an assert to make sure `CanonicalizeEntry` is not NULL?

Also please remember to use nullptr and not NULL! @kimbarrett would appreciate it :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1744808169
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1744810286

From abhiscxk at openjdk.org  Thu Sep  5 09:31:51 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 5 Sep 2024 09:31:51 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v4]
In-Reply-To: <cjkOpnnS25kZpsAUxe8lKseKEPTmxUXbx57AssvQ3PE=.36fc3d5f-4117-417c-914f-d9f61ad0cc3a@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <cjkOpnnS25kZpsAUxe8lKseKEPTmxUXbx57AssvQ3PE=.36fc3d5f-4117-417c-914f-d9f61ad0cc3a@github.com>
Message-ID: <ZNHJVVyOXBlARHJlxUuhScQ1GovYQpVlNOFPJZWCmfw=.5bfc6a60-14ea-4417-b965-2592a0817db2@github.com>

On Thu, 5 Sep 2024 04:48:36 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rather than left top.
>> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reduce tolerance value

`private static BufferedImage imageAfterChecked;` can be move inside main method.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20723#pullrequestreview-2282379098

From tr at openjdk.org  Thu Sep  5 09:38:51 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 5 Sep 2024 09:38:51 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v4]
In-Reply-To: <ZNHJVVyOXBlARHJlxUuhScQ1GovYQpVlNOFPJZWCmfw=.5bfc6a60-14ea-4417-b965-2592a0817db2@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <cjkOpnnS25kZpsAUxe8lKseKEPTmxUXbx57AssvQ3PE=.36fc3d5f-4117-417c-914f-d9f61ad0cc3a@github.com>
 <ZNHJVVyOXBlARHJlxUuhScQ1GovYQpVlNOFPJZWCmfw=.5bfc6a60-14ea-4417-b965-2592a0817db2@github.com>
Message-ID: <Mfez7MzMTeY8ErvQOU7J4t9J_DXF0CFhxvARFB-ZLyc=.3bf68a96-bdb9-43ed-a9aa-531378f5fbb1@github.com>

On Thu, 5 Sep 2024 09:29:11 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> `private static BufferedImage imageAfterChecked;` can be move inside main method.

It's used inside `EventQueue`, then have to covert to atomic. Better to retain as it is.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20723#issuecomment-2331059882

From ihse at openjdk.org  Thu Sep  5 09:54:52 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 5 Sep 2024 09:54:52 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <bfBaJj8ARo7c7iCF7U4ymPRfAbtKotBqj5WU_4z9490=.60be0f5a-a237-4496-905b-ef51128b3189@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
 <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>
 <bfBaJj8ARo7c7iCF7U4ymPRfAbtKotBqj5WU_4z9490=.60be0f5a-a237-4496-905b-ef51128b3189@github.com>
Message-ID: <KHRKhEhQIgvknE2mHJ059rYoYZVom7_E7k4mN2K55GM=.8d36647a-27d0-43e2-9a75-f20d9ee43477@github.com>

On Thu, 5 Sep 2024 05:06:55 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> make/StaticLibs.gmk line 71:
>> 
>>> 69:   # libsspi_bridge has name conflicts with sunmscapi
>>> 70:   BROKEN_STATIC_LIBS += sspi_bridge
>>> 71:   # These libs define DllMain which conflict with Hotspot
>> 
>> I'm not aware of the DllMain issue with static linking these libs. Could you please explain? The libawt.a and libdt_socket.a are statically linked with `javastatic` in https://github.com/openjdk/leyden/tree/hermetic-java-runtime/ branch.
>
> DllMain is a Windows specific initialization method that is called when a Windows dll (Dynamic library) is loaded, among other things. Since DllMain is extern "C", it is not mangled and hence likely that having multiple static libraries that each define it will cause multiple symbol definition errors during linking. It might be that the reason hermetic Java hasn't encountered this problem yet is because it mainly tests its code on Linux, while this is a Windows specific issue, since the names you mention (libawt.a and libdt_socket.a) are the names of those libraries on Linux, not Windows. However, the issue likely deeper than that. DllMain is completely wrong to define when inside a static library, and should not be compiled at all when making the static versions of these libraries. Simply localizing the DllMain symbol when creating a static library would be wrong. We'll have to find out how to run the initialization code for each of these currently dynamic libraries without DllMai
 n when compiling them as static libraries

As Julian says, this is for Windows, and you have not even tried to compile that in your prototype.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1745162496

From ihse at openjdk.org  Thu Sep  5 09:54:53 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 5 Sep 2024 09:54:53 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
 <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>
Message-ID: <7tmo9e9RcUi06DYLjvQEaEu_XCY4bUa4OcWByw7vCdc=.11672bb7-71ca-46f4-8ed1-48512ab59e15@github.com>

On Wed, 4 Sep 2024 23:03:23 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.
>> 
>> This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 
>> 
>> All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).
>
> make/StaticLibs.gmk line 74:
> 
>> 72:   BROKEN_STATIC_LIBS += awt dt_shmem dt_socket javaaccessbridge
>> 73:   # These libs are dependent on any of the above disabled libs
>> 74:   BROKEN_STATIC_LIBS += fontmanager jawt lcms net nio
> 
> Which specific dependent cause these libs being excluded? In https://github.com/openjdk/leyden/tree/hermetic-java-runtime/ branch, these JDK libs (except `libjawt.a`) are statically linked into `javastatic`.

Well, but your proof-of-concept only supports clang on linux, where you have enabled symbol hiding. 

Our conclusion in the zoom talks was that we should strive for getting a static launcher build pushed into mainline before we have full and proper support for symbol hiding on all platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1745161079

From ihse at openjdk.org  Thu Sep  5 10:02:59 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 5 Sep 2024 10:02:59 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
 <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>
Message-ID: <Yc36M18CA-LzcyvnVwL7D_8CE-nPC8WtO7gMnPzQ9-U=.353a312a-64f4-41d9-ae51-dcd93a2c819c@github.com>

On Wed, 4 Sep 2024 23:28:10 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.
>> 
>> This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 
>> 
>> All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).
>
> make/modules/java.desktop/lib/AwtLibraries.gmk line 176:
> 
>> 174: 
>> 175:   ifneq ($(ENABLE_HEADLESS_ONLY), true)
>> 176:     # We cannot link with both awt_headless and awt_xawt at the same time
> 
> Just a note on that. It's doable to link with both awt_headless and awt_xawt with some work. I did some quick experiments on that during the initial investigation for hermetic/static Java.

That would require quite some work then..! The two libraries are meant as exclusive complements to each other -- they both implement the same "entry points", but in different ways -- one with X11 support, and one without. For other reasons (outside of static launcher reasons) I'd like to see some refactoring in how this is implemented, but that is completely outside this discussion.

For the static launcher scenario, I can't even see the point of trying to include both? What would you accomplish by that? 

The entire point of having two libraries is that you want to be able to have full workstation capabilities, but then be dependent on the X11 libraries, or have limited capabilities, but skip the X11 dependency.

> src/java.base/unix/native/libjli/java_md.c line 300:
> 
>> 298:                            char jvmcfg[],  jint so_jvmcfg) {
>> 299:     /* Compute/set the name of the executable. This is needed for macOS. */
>> 300:     SetExecname(*pargv);
> 
> Why is `SetExecname()` needed for the static case?

Because of how macOS re-exec the launcher to reserve the main thread for GUI operations. Please check the rather extensive documentation elsewhere in this file.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1745171016
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1745172749

From ihse at openjdk.org  Thu Sep  5 10:02:58 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 5 Sep 2024 10:02:58 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
Message-ID: <dOHTFTlXDWQc_3M5zfjPeevfGHXv1ZJi5I3FLzJBWXg=.038829b7-b07a-4ace-bc3d-35402e98eeb5@github.com>

On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.
> 
> This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 
> 
> All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).

The `/contributor` is supposed to add attribution to whomever wrote the code. There is no way to document any prior reviewing for code; but they are of course welcome to review this PR, and then it will be documented.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20837#issuecomment-2331113024

From abhiscxk at openjdk.org  Thu Sep  5 10:03:53 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 5 Sep 2024 10:03:53 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v4]
In-Reply-To: <Mfez7MzMTeY8ErvQOU7J4t9J_DXF0CFhxvARFB-ZLyc=.3bf68a96-bdb9-43ed-a9aa-531378f5fbb1@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <cjkOpnnS25kZpsAUxe8lKseKEPTmxUXbx57AssvQ3PE=.36fc3d5f-4117-417c-914f-d9f61ad0cc3a@github.com>
 <ZNHJVVyOXBlARHJlxUuhScQ1GovYQpVlNOFPJZWCmfw=.5bfc6a60-14ea-4417-b965-2592a0817db2@github.com>
 <Mfez7MzMTeY8ErvQOU7J4t9J_DXF0CFhxvARFB-ZLyc=.3bf68a96-bdb9-43ed-a9aa-531378f5fbb1@github.com>
Message-ID: <JH9JusG4MG1l2ISkaXf91hvhZ8pCXowx8rVclVWYLpU=.4b6e9efb-a3c4-408d-b6f9-24588cd654c4@github.com>

On Thu, 5 Sep 2024 09:36:43 GMT, Tejesh R <tr at openjdk.org> wrote:

> It's used inside `EventQueue`, then have to covert to atomic. Better to retain as it is.

I guess only `Point point = checkbox.getLocationOnScreen();` should be enough to access on EDT, rest of the code can be executed on main thread.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20723#issuecomment-2331114701

From ihse at openjdk.org  Thu Sep  5 10:05:56 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 5 Sep 2024 10:05:56 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
 <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>
Message-ID: <zNCkkRVUN1in536PEjPTyTRlvrjgd5082V4cQ_KnjU4=.db76a175-9dce-4431-ac30-db7fd8829f50@github.com>

On Wed, 4 Sep 2024 23:24:13 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.
>> 
>> This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 
>> 
>> All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).
>
> make/StaticLibs.gmk line 1:
> 
>> 1: #
> 
> Perhaps also consider adopting StaticLink.gmk file name from the https://github.com/openjdk/leyden/tree/hermetic-java-runtime/ branch, as we are mostly doing the static linking here. Creating the static libs is handled elsewhere.

My intention is to move all relevant handling of static linking into this file.

> make/StaticLibs.gmk line 118:
> 
>> 116:     OPTIMIZATION := HIGH, \
>> 117:     STATIC_LAUNCHER := true, \
>> 118:     LDFLAGS := $(JAVASTATIC_LINK_LDFLAGS), \
> 
> I could be missing something, but I don't see where is $JAVASTATIC_LINK_LDFLAGS defined.
> 
> On a related notes, I think we need to include $JVM_LDFLAGS when linking the static "java". See https://bugs.openjdk.org/browse/JDK-8339522?focusedId=14702923&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14702923.

You are right, this is dead code. Thanks for spotting this. 

During my experimentation, I tried passing along LDFLAGS from the individual libraries as well, but it turned out not to be a good idea -- the way we have used them were to modify some special properties on a single dynamic library, which did not apply to the static library as a whole.

However, there is a risk that we in the future need to add LDFLAGS to a library that also needs to be carried over to the static launcher. If this happens, I guess we need to separate between LDFLAGS_ONLY_FOR_THIS_DLL and LDFLAGS_ALSO_FOR_STATIC_LINKING.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1745180739
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1745180044

From tr at openjdk.org  Thu Sep  5 10:06:53 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 5 Sep 2024 10:06:53 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v4]
In-Reply-To: <JH9JusG4MG1l2ISkaXf91hvhZ8pCXowx8rVclVWYLpU=.4b6e9efb-a3c4-408d-b6f9-24588cd654c4@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <cjkOpnnS25kZpsAUxe8lKseKEPTmxUXbx57AssvQ3PE=.36fc3d5f-4117-417c-914f-d9f61ad0cc3a@github.com>
 <ZNHJVVyOXBlARHJlxUuhScQ1GovYQpVlNOFPJZWCmfw=.5bfc6a60-14ea-4417-b965-2592a0817db2@github.com>
 <Mfez7MzMTeY8ErvQOU7J4t9J_DXF0CFhxvARFB-ZLyc=.3bf68a96-bdb9-43ed-a9aa-531378f5fbb1@github.com>
 <JH9JusG4MG1l2ISkaXf91hvhZ8pCXowx8rVclVWYLpU=.4b6e9efb-a3c4-408d-b6f9-24588cd654c4@github.com>
Message-ID: <n2DgIxyTq-zadxuT0hutf30rul4mItQsfay7p9QZb_c=.8b18a573-072d-419a-9a07-89617b9e9d86@github.com>

On Thu, 5 Sep 2024 10:00:44 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> > It's used inside `EventQueue`, then have to covert to atomic. Better to retain as it is.
> 
> I guess only `Point point = checkbox.getLocationOnScreen();` should be enough to access on EDT, rest of the code can be executed on main thread.

Then have to move `point` out of EDT. Can do it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20723#issuecomment-2331122794

From alanb at openjdk.org  Thu Sep  5 10:19:51 2024
From: alanb at openjdk.org (Alan Bateman)
Date: Thu, 5 Sep 2024 10:19:51 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
Message-ID: <1XTLQONTqkE6n6BTX2KzIngNeewtx5F-cHqvHw7Bk4U=.ded8a4e8-e3e4-414a-afc1-9c694bcb9182@github.com>

On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> As a prerequisite for Hermetic Java, we need a statically linked `java` launcher. It should behave like the normal, dynamically linked `java` launcher, except that all JDK native libraries should be statically, not dynamically, linked.
> 
> This patch is the first step towards this goal. It will generate a `static-jdk` image with a statically linked launcher. This launcher is missing several native libs, however, and does therefore not behave like a proper dynamic java. One of the reasons for this is that local symbol hiding in static libraries are not implemented yet, which causes symbol clashes when linking all static libraries together. This will be addressed in an upcoming patch. 
> 
> All changes in the `src` directory are copied from, or inspired by, changes made in [the hermetic-java-runtime branch in Project Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).

src/java.base/unix/native/libjli/java_md.c line 509:

> 507: 
> 508:     if (GetApplicationHome(path, pathsize)) {
> 509:         if (JLI_IsStaticallyLinked()) {

In passing, GetJREPath's function description includes "or registry settings" which is confusing to see now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1745198354

From tr at openjdk.org  Thu Sep  5 10:23:15 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 5 Sep 2024 10:23:15 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v5]
In-Reply-To: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
Message-ID: <mMgtogAZn74yHDpSP10vAzE_usYRzA7bWYgXN_RKZBc=.fc7c3b58-dbb5-4554-b561-76accf8b7344@github.com>

> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
> 1. Move the frame to center of the screen rather than left top.
> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Updated with review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20723/files
  - new: https://git.openjdk.org/jdk/pull/20723/files/0f28899d..a02be6cf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20723&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20723&range=03-04

  Stats: 19 lines in 1 file changed: 1 ins; 3 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/20723.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20723/head:pull/20723

PR: https://git.openjdk.org/jdk/pull/20723

From ngubarkov at openjdk.org  Thu Sep  5 12:04:19 2024
From: ngubarkov at openjdk.org (Nikita Gubarkov)
Date: Thu, 5 Sep 2024 12:04:19 GMT
Subject: RFR: 8339341: SurfaceManager cacheMap retains strong references
 [v2]
In-Reply-To: <1ecWvJLiG54e0saEz_Jjz46gzxXnqsNDagdPQ3y_BN4=.27116e44-886b-405f-9d87-ec5e82e2fd20@github.com>
References: <1ecWvJLiG54e0saEz_Jjz46gzxXnqsNDagdPQ3y_BN4=.27116e44-886b-405f-9d87-ec5e82e2fd20@github.com>
Message-ID: <VZi8p9nS4x7oE4ES1NhMBsbUiLVVQ_WmWJoFVwqFqdQ=.0dc37621-d54c-40cf-a5ad-fc4abe29a4b5@github.com>

> I moved SurfaceDataProxy cache into a separate class.
> Now caching level is determined by placement of the SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" proxies and therefore strong refs via them do not prevent the cache and GraphicsConfig from being detected as weakly reachable.

Nikita Gubarkov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8339341: Make SurfaceDataProxy cache a separate entity.
  
  Now caching level is determined by placement of the SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" proxies and therefore strong refs via them do not prevent the cache (and hence GraphicsConfig) from being detected as weakly reachable.

-------------

Changes: https://git.openjdk.org/jdk/pull/20825/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20825&range=01
  Stats: 173 lines in 17 files changed: 55 ins; 55 del; 63 mod
  Patch: https://git.openjdk.org/jdk/pull/20825.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20825/head:pull/20825

PR: https://git.openjdk.org/jdk/pull/20825

From abhiscxk at openjdk.org  Thu Sep  5 12:04:53 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 5 Sep 2024 12:04:53 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v5]
In-Reply-To: <mMgtogAZn74yHDpSP10vAzE_usYRzA7bWYgXN_RKZBc=.fc7c3b58-dbb5-4554-b561-76accf8b7344@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <mMgtogAZn74yHDpSP10vAzE_usYRzA7bWYgXN_RKZBc=.fc7c3b58-dbb5-4554-b561-76accf8b7344@github.com>
Message-ID: <ilZD9g2c9Ny_L8aXaRTFs3m02HmPcFQhR-zIreg7MBI=.597b92c1-03ad-44e5-aef5-ac8615db438e@github.com>

On Thu, 5 Sep 2024 10:23:15 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rather than left top.
>> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated with review comments

test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 49:

> 47:     private static Frame frame;
> 48:     private static Checkbox checkbox;
> 49:     private static Point point;

`point` is accessed across multiple threads, should be declared as `volatile`. No need to declare `checkmarkFound ` as `volatile`, it is accessed only in main thread.

test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 82:

> 80:                         if (compareColor(pixelColor)) {
> 81:                             colorCounter++;
> 82:                             if (colorCounter >= COLOR_CHECK_THRESHOLD) {

Just a suggestion, Could be merged in one statement
`if (++colorCounter >= COLOR_CHECK_THRESHOLD) {`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20723#discussion_r1745331036
PR Review Comment: https://git.openjdk.org/jdk/pull/20723#discussion_r1745334295

From achung at openjdk.org  Thu Sep  5 15:14:21 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 5 Sep 2024 15:14:21 GMT
Subject: RFR: 8339524: Clean up ExtendedRobot tests
Message-ID: <HC64NDQIWs3GWaJI1BscY7iAsc6uZabf1QytcbWHqdU=.f353752e-03ca-4a8f-986b-3690d3a1da52@github.com>

Cleaning up tests building ExtendedRobot that shouldn't be.

-------------

Commit messages:
 - revert test using ExtendedRobot
 - reverted some tests actually using ExtendedRobot
 - init commit

Changes: https://git.openjdk.org/jdk/pull/20846/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20846&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339524
  Stats: 5 lines in 2 files changed: 0 ins; 1 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/20846.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20846/head:pull/20846

PR: https://git.openjdk.org/jdk/pull/20846

From tr at openjdk.org  Thu Sep  5 15:14:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 5 Sep 2024 15:14:21 GMT
Subject: RFR: 8339524: Clean up ExtendedRobot tests
In-Reply-To: <HC64NDQIWs3GWaJI1BscY7iAsc6uZabf1QytcbWHqdU=.f353752e-03ca-4a8f-986b-3690d3a1da52@github.com>
References: <HC64NDQIWs3GWaJI1BscY7iAsc6uZabf1QytcbWHqdU=.f353752e-03ca-4a8f-986b-3690d3a1da52@github.com>
Message-ID: <b7HyzM0hThu3uaUhODTzKH5ATQQZyGd7SA6sBf6avOY=.1efcd074-7d31-4e0a-9e32-ac2921b5ee47@github.com>

On Wed, 4 Sep 2024 03:34:34 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Cleaning up tests building ExtendedRobot that shouldn't be.

test/jdk/java/awt/Robot/ModifierRobotKey/ModifierRobotEnhancedKeyTest.java line 158:

> 156: 
> 157:     public void doTest() throws Exception {
> 158:         robot = new ExtendedRobot();

`robot.click()` at line 161 is from ExtendedRobot class. Can u reconfirm that ExtendedRobot is not required here and other classes?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20846#discussion_r1743170960

From dnguyen at openjdk.org  Thu Sep  5 15:48:55 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 5 Sep 2024 15:48:55 GMT
Subject: RFR: 6672644: JComboBox still scrolling if switch to another
 window and return back.
In-Reply-To: <-thiCdaj9qlQshgmU0oRqI_DIqS5FWayBL_JQPk0GSY=.5d5f0f32-5506-4bc0-b7bd-bd68e4a42e27@github.com>
References: <vOzWxTYyh6qDyDB7sg2I1DjLG0I0ZZFb9sG9qKRd--4=.647cbf42-332c-430b-b12a-763bbee68ff3@github.com>
 <-thiCdaj9qlQshgmU0oRqI_DIqS5FWayBL_JQPk0GSY=.5d5f0f32-5506-4bc0-b7bd-bd68e4a42e27@github.com>
Message-ID: <y0-DWDwr2wJcxpU3COo0flSRy2xU9IvRp6t5P3LA4AU=.1fa3405e-4733-4aa1-ad07-fdbdeeec408a@github.com>

On Wed, 4 Sep 2024 23:58:02 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> In a JComboBox, if the user opens the dropdown list and clicks and holds the down-button, then ALT-TABs to switch focus, when the user re-focuses the frame with the JComboBox and opens the dropdown list again, the list will still be scrolling even though the down-button isn't pressed.
>> 
>> This isn't OS or L&F specific, although Aqua L&F does not have any directional arrows in the dropdown list (and is thus exempt). This led me to believe it could be handled in BasicComboBoxUI where focusLost and focusGain are used or isPopupVisible but the scroll behavior cannot be altered here. Likewise for BasicComboPopup where `autoscroll` is used. However, this behavior isn't related to autoscroll and is actually found in the JScrollbar of the JScrollpane inside of the JComboBox. The timer for the scroll action starts but is never stopped if focus is lost, so a new listener is created and used. The proposed solution uses `KeyboardFocusManager` to track the focus owner. The listener stops the `scrollTimer` when the `focusOwner` property is changed. With this change, the list no longer automatically scrolls when re-focused and instead opens normally.
>> 
>> The included test is manual due to the need to confirm that the list still scrolls after ALT-TABing. The L&F is set to Metal since it is the cross-platform lookandfeel and has directional buttons for the JScrollPane list.
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java line 1238:
> 
>> 1236:                 // Stop scrolling if no longer focus owner
>> 1237:                 if (e.getNewValue() == null && scrollTimer.isRunning()) {
>> 1238:                     scrollTimer.stop();
> 
> In some places `scrollTimer.stop()` is followed by `scrollbar.setValueIsAdjusting(false)`. Is this applicable for KeyboardFocusListener ?
> For instance:
> https://github.com/openjdk/jdk/blob/0cc3caf2b49426bb6738a9792c88275c0cc7774a/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java#L1608

You're right. I added this to my fix, but didn't get it pushed yet. Thanks for the reminder.

> test/jdk/javax/swing/JComboBox/JComboBoxScrollFocusTest.java line 59:
> 
>> 57:             UnsupportedLookAndFeelException, ClassNotFoundException,
>> 58:             InstantiationException, IllegalAccessException, AWTException,
>> 59:             InterruptedException, InvocationTargetException {
> 
> Can this be simplified to throw generic Exception?

Good point.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20845#discussion_r1745789070
PR Review Comment: https://git.openjdk.org/jdk/pull/20845#discussion_r1745789363

From dnguyen at openjdk.org  Thu Sep  5 15:51:01 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 5 Sep 2024 15:51:01 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v3]
In-Reply-To: <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
Message-ID: <Zu8MKE_MRwH3vrzPKe_iWm7xedbIOwwHMT_WfAFi7lk=.ae381a57-87c3-4bb6-9a4d-caa2d5add48a@github.com>

On Wed, 4 Sep 2024 04:21:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
>> Test removed from `Problem-list` file as well.
>> 
>> CI testing link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test name renamed

Since the other issue in question is separate, then this fix looks good.

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/20791#pullrequestreview-2283470100

From dnguyen at openjdk.org  Thu Sep  5 15:53:59 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 5 Sep 2024 15:53:59 GMT
Subject: RFR: 8339271: giflib attribution correction
In-Reply-To: <9bUf9UKVavgShir_2Z2Hfjelu4gLJUxoWCel8AntU_M=.2a57b6e4-dafa-45ec-97ba-a70da712b2f9@github.com>
References: <9bUf9UKVavgShir_2Z2Hfjelu4gLJUxoWCel8AntU_M=.2a57b6e4-dafa-45ec-97ba-a70da712b2f9@github.com>
Message-ID: <QlNTz9Rx3o9X44A64WJsJjfhs8kZHKt0D9c0SDkxqnI=.25f71646-0797-4b5e-bb87-5e5eddb506cf@github.com>

On Wed, 4 Sep 2024 19:43:19 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Changing format of file paths in giflib copyright file and removing extra text from authors list

Marked as reviewed by dnguyen (Committer).

LGTM

-------------

PR Review: https://git.openjdk.org/jdk/pull/20859#pullrequestreview-2283477970
PR Comment: https://git.openjdk.org/jdk/pull/20859#issuecomment-2332092481

From djgredler at gmail.com  Thu Sep  5 18:30:39 2024
From: djgredler at gmail.com (Daniel Gredler)
Date: Thu, 5 Sep 2024 20:30:39 +0200
Subject: Graphics2D.drawString() fails with Font derived from rotated + scaled
 AffineTransform
Message-ID: <CAPA+ug5PSdU4_pMJ+vMRhs72-CErf-qKdwjjbiTwC2iXp3HWAg@mail.gmail.com>

Hi all,

I've run into a bug [1] in the drawing of strings via
Graphics2D.drawString(), when used with a Font derived from a rotated +
scaled AffineTransform. If the AffineTransform scaling is small, the text
draws correctly. But if the scale is too large, the text does not draw. [3]

It looks like it's an effect of the OutlineTextRenderer.THRESHHOLD; text
larger than this threshold is sent to the OutlineTextRenderer and fails to
draw. The fix [2] seems to be to apply the position translation
transformation *after* the text outline shape is created, rather than
passing it into TextLayout.getOutline(). However, I do not know if this is
the correct fix, or if it is just a workaround to a deeper issue in
TextLayout.getOutline(), which in theory might need to wait to apply the
provided translation until after the layout path has had a chance to map to
user space.

Can someone familiar with this code comment on whether the proposed fix is
the correct fix, or whether deeper surgery is needed in
TextLayout.getOutline()?

My other small worry with the current fix [2] is that it creates an extra
copy of the Shape object, so it's going to allocate a bit more memory than
the current implementation. Not sure if there's a better way to update the
Shape in-place.

Take care,

Daniel

---

[1] Oracle internal review ID 9077538, no public bug ID yet
[2]
https://github.com/openjdk/jdk/compare/master...gredler:jdk:draw-string-bug
[3]
import java.awt.Color;
import java.awt.Font;
import java.awt.Graphics2D;
import java.awt.geom.AffineTransform;
import java.awt.image.BufferedImage;
import java.io.File;

import javax.imageio.ImageIO;

/**
 * <p>The "TEST 2" text does not draw. NOTE: Reducing the AffineTransform
scale
 * from 12 to 10 seems to allow it to draw?!?
 *
 * <p>Oracle internal review ID : 9077538
 */
public class DrawStringTest {

    public static void main(String[] args) throws Exception {

        AffineTransform at = AffineTransform.getRotateInstance(3 * Math.PI
/ 2);
        at.scale(12, 12);

        Font font1 = new Font("SansSerif", Font.PLAIN, 10);
        Font font2 = font1.deriveFont(at);

        BufferedImage image = new BufferedImage(500, 500,
BufferedImage.TYPE_BYTE_GRAY);
        Graphics2D g2d = image.createGraphics();
        g2d.setColor(Color.WHITE);
        g2d.fillRect(0, 0, image.getWidth(), image.getHeight());
        g2d.setColor(Color.BLACK);
        g2d.setFont(font1);
        g2d.drawString("TEST 1", 200, 400); // draws text
        g2d.setFont(font2);
        g2d.drawString("TEST 2", 200, 400); // does not draw text
        g2d.dispose();

        ImageIO.write(image, "png", new File("test.png"));
    }

}
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20240905/b8af0939/attachment.htm>

From jiangli at openjdk.org  Thu Sep  5 19:21:52 2024
From: jiangli at openjdk.org (Jiangli Zhou)
Date: Thu, 5 Sep 2024 19:21:52 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <7tmo9e9RcUi06DYLjvQEaEu_XCY4bUa4OcWByw7vCdc=.11672bb7-71ca-46f4-8ed1-48512ab59e15@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
 <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>
 <7tmo9e9RcUi06DYLjvQEaEu_XCY4bUa4OcWByw7vCdc=.11672bb7-71ca-46f4-8ed1-48512ab59e15@github.com>
Message-ID: <lMsYEHY3jMzn6jizRTPmcUpmp_w---h3h7QANpzW4ds=.44aa8e2e-77e7-4543-9428-5a83ea308bdf@github.com>

On Thu, 5 Sep 2024 09:50:49 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Well, but your proof-of-concept only supports clang on linux, where you have enabled symbol hiding.

The hermetic-java-runtime branch doesn't have general symbol hiding enabled. That's why I'm wondering what the issues are with these libs except for `libjawt` with the current PR. 

(A side-note on `libjawt.a`: For static linking, we don't need `libjawt.a` and the headless or headful libs can be directly statically linked with.)

> 
> Our conclusion in the zoom talks was that we should strive for getting a static launcher build pushed into mainline before we have full and proper support for symbol hiding on all platforms.

Right, that would be a good & practical way to add the support in the mainline.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1746051842

From dnguyen at openjdk.org  Thu Sep  5 20:32:07 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 5 Sep 2024 20:32:07 GMT
Subject: RFR: 6672644: JComboBox still scrolling if switch to another
 window and return back [v2]
In-Reply-To: <vOzWxTYyh6qDyDB7sg2I1DjLG0I0ZZFb9sG9qKRd--4=.647cbf42-332c-430b-b12a-763bbee68ff3@github.com>
References: <vOzWxTYyh6qDyDB7sg2I1DjLG0I0ZZFb9sG9qKRd--4=.647cbf42-332c-430b-b12a-763bbee68ff3@github.com>
Message-ID: <rTnlB07-VJA8q485vPf6VqNKT8V7xHoS_Ko5_IDFZ5w=.0db6e909-7f04-4c8a-a2e8-31152cb974db@github.com>

> In a JComboBox, if the user opens the dropdown list and clicks and holds the down-button, then ALT-TABs to switch focus, when the user re-focuses the frame with the JComboBox and opens the dropdown list again, the list will still be scrolling even though the down-button isn't pressed.
> 
> This isn't OS or L&F specific, although Aqua L&F does not have any directional arrows in the dropdown list (and is thus exempt). This led me to believe it could be handled in BasicComboBoxUI where focusLost and focusGain are used or isPopupVisible but the scroll behavior cannot be altered here. Likewise for BasicComboPopup where `autoscroll` is used. However, this behavior isn't related to autoscroll and is actually found in the JScrollbar of the JScrollpane inside of the JComboBox. The timer for the scroll action starts but is never stopped if focus is lost, so a new listener is created and used. The proposed solution uses `KeyboardFocusManager` to track the focus owner. The listener stops the `scrollTimer` when the `focusOwner` property is changed. With this change, the list no longer automatically scrolls when re-focused and instead opens normally.
> 
> The included test is manual due to the need to confirm that the list still scrolls after ALT-TABing. The L&F is set to Metal since it is the cross-platform lookandfeel and has directional buttons for the JScrollPane list.

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20845/files
  - new: https://git.openjdk.org/jdk/pull/20845/files/0cc3caf2..312c484d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20845&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20845&range=00-01

  Stats: 21 lines in 2 files changed: 5 ins; 10 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/20845.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20845/head:pull/20845

PR: https://git.openjdk.org/jdk/pull/20845

From jiangli at openjdk.org  Thu Sep  5 20:39:51 2024
From: jiangli at openjdk.org (Jiangli Zhou)
Date: Thu, 5 Sep 2024 20:39:51 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <bfBaJj8ARo7c7iCF7U4ymPRfAbtKotBqj5WU_4z9490=.60be0f5a-a237-4496-905b-ef51128b3189@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
 <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>
 <bfBaJj8ARo7c7iCF7U4ymPRfAbtKotBqj5WU_4z9490=.60be0f5a-a237-4496-905b-ef51128b3189@github.com>
Message-ID: <r7W5pQxzeIaE8GIvW_vri7SpZk2HDsBj6339ouuS5vY=.014c1ff8-d800-42f3-bfe2-7121e5e0cbc2@github.com>

On Thu, 5 Sep 2024 05:06:55 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> make/StaticLibs.gmk line 71:
>> 
>>> 69:   # libsspi_bridge has name conflicts with sunmscapi
>>> 70:   BROKEN_STATIC_LIBS += sspi_bridge
>>> 71:   # These libs define DllMain which conflict with Hotspot
>> 
>> I'm not aware of the DllMain issue with static linking these libs. Could you please explain? The libawt.a and libdt_socket.a are statically linked with `javastatic` in https://github.com/openjdk/leyden/tree/hermetic-java-runtime/ branch.
>
> DllMain is a Windows specific initialization method that is called when a Windows dll (Dynamic library) is loaded, among other things. Since DllMain is extern "C", it is not mangled and hence likely that having multiple static libraries that each define it will cause multiple symbol definition errors during linking. It might be that the reason hermetic Java hasn't encountered this problem yet is because it mainly tests its code on Linux, while this is a Windows specific issue, since the names you mention (libawt.a and libdt_socket.a) are the names of those libraries on Linux, not Windows. However, the issue likely deeper than that. DllMain is completely wrong to define when inside a static library, and should not be compiled at all when making the static versions of these libraries. Simply localizing the DllMain symbol when creating a static library would be wrong. We'll have to find out how to run the initialization code for each of these currently dynamic libraries without DllMai
 n when compiling them as static libraries

@TheShermanTanker thanks for the details on DllMain issue. Right, we have only tested hermetic/static Java on Linux.

I agree that hiding DllMain is not the right approach. One possible solution is to put the DllMain in separate .c/.cpp files and only link with those when building the .dll. 

With the current PR, we mainly focuses on the Linux (or unix-like) port, e.g. `os::lookup_function()` is not supported in the Windows port yet. Any thoughts on if we only limit static linking these affected JDK libraries on Windows initially, and allow statically linking more libs on Linux? We can add those libs on Windows when we resolve the DllMain issue. For running some minimum jtreg testing initially, I think we would want to include `libnet` (and other libs) in the statically linked `java` binary.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1746129101

From jiangli at openjdk.org  Thu Sep  5 20:43:52 2024
From: jiangli at openjdk.org (Jiangli Zhou)
Date: Thu, 5 Sep 2024 20:43:52 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <zNCkkRVUN1in536PEjPTyTRlvrjgd5082V4cQ_KnjU4=.db76a175-9dce-4431-ac30-db7fd8829f50@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
 <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>
 <zNCkkRVUN1in536PEjPTyTRlvrjgd5082V4cQ_KnjU4=.db76a175-9dce-4431-ac30-db7fd8829f50@github.com>
Message-ID: <d1amVzHP2IX0PFufkHNm7W4_vRy6U_JSBJg6yXOAp5g=.49e079ba-42d2-4d8a-b3b9-224996db2ef0@github.com>

On Thu, 5 Sep 2024 10:03:19 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/StaticLibs.gmk line 118:
>> 
>>> 116:     OPTIMIZATION := HIGH, \
>>> 117:     STATIC_LAUNCHER := true, \
>>> 118:     LDFLAGS := $(JAVASTATIC_LINK_LDFLAGS), \
>> 
>> I could be missing something, but I don't see where is $JAVASTATIC_LINK_LDFLAGS defined.
>> 
>> On a related notes, I think we need to include $JVM_LDFLAGS when linking the static "java". See https://bugs.openjdk.org/browse/JDK-8339522?focusedId=14702923&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14702923.
>
> You are right, this is dead code. Thanks for spotting this. 
> 
> During my experimentation, I tried passing along LDFLAGS from the individual libraries as well, but it turned out not to be a good idea -- the way we have used them were to modify some special properties on a single dynamic library, which did not apply to the static library as a whole.
> 
> However, there is a risk that we in the future need to add LDFLAGS to a library that also needs to be carried over to the static launcher. If this happens, I guess we need to separate between LDFLAGS_ONLY_FOR_THIS_DLL and LDFLAGS_ALSO_FOR_STATIC_LINKING.

+1 on "separate between LDFLAGS_ONLY_FOR_THIS_DLL and LDFLAGS_ALSO_FOR_STATIC_LINKING"

I think we need to get the linker flags sorted out correctly in this initial PR and make sure the needed flags (most importantly the ones used in $JVM_LDFLAGS).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1746133505

From jiangli at openjdk.org  Thu Sep  5 20:47:50 2024
From: jiangli at openjdk.org (Jiangli Zhou)
Date: Thu, 5 Sep 2024 20:47:50 GMT
Subject: RFR: 8339480: Build static-jdk image with a statically linked
 launcher
In-Reply-To: <Yc36M18CA-LzcyvnVwL7D_8CE-nPC8WtO7gMnPzQ9-U=.353a312a-64f4-41d9-ae51-dcd93a2c819c@github.com>
References: <5r5p2HyEXsEIr7wnq_5RSMfcbw-gsP4fBvTgr9P2lvY=.d3a51eae-661a-45d2-80e1-723e05e5eb32@github.com>
 <7MvsbWwg0NapAkQ45NF2u-KUtT7JaeyDjjPJa3bgK70=.9e181a2f-5d7d-43de-b943-cbd76de06e2f@github.com>
 <Yc36M18CA-LzcyvnVwL7D_8CE-nPC8WtO7gMnPzQ9-U=.353a312a-64f4-41d9-ae51-dcd93a2c819c@github.com>
Message-ID: <UDcq933mLhYdzTGhxuxX8Wm7gDlkOrH7oXbkelCtKPQ=.85b649fd-06da-4349-874a-011a4f31f5bc@github.com>

On Thu, 5 Sep 2024 09:57:15 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/modules/java.desktop/lib/AwtLibraries.gmk line 176:
>> 
>>> 174: 
>>> 175:   ifneq ($(ENABLE_HEADLESS_ONLY), true)
>>> 176:     # We cannot link with both awt_headless and awt_xawt at the same time
>> 
>> Just a note on that. It's doable to link with both awt_headless and awt_xawt with some work. I did some quick experiments on that during the initial investigation for hermetic/static Java.
>
> That would require quite some work then..! The two libraries are meant as exclusive complements to each other -- they both implement the same "entry points", but in different ways -- one with X11 support, and one without. For other reasons (outside of static launcher reasons) I'd like to see some refactoring in how this is implemented, but that is completely outside this discussion.
> 
> For the static launcher scenario, I can't even see the point of trying to include both? What would you accomplish by that? 
> 
> The entire point of having two libraries is that you want to be able to have full workstation capabilities, but then be dependent on the X11 libraries, or have limited capabilities, but skip the X11 dependency.

My initial understanding was that the libawt_headless was mostly as subset of libawt_xawt, which made it possible to statically link both the headless and headful natives. Completely agree that it's outside of the current scope.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1746136942

From kcr at openjdk.org  Thu Sep  5 21:16:58 2024
From: kcr at openjdk.org (Kevin Rushforth)
Date: Thu, 5 Sep 2024 21:16:58 GMT
Subject: RFR: 8311530: Deprecate jdk.jsobject module for removal
Message-ID: <IGLgrBcj15QFo70cviDkjokoBOBpDBYXru2PS2N7hKQ=.d365a073-1153-420f-992c-03c7994073e9@github.com>

Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it with JavaFX instead.

See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR openjdk/jfx#1529 for the JavaFX PR that will include the module with JavaFX. That PR describes the needed test scenarios.

This PR does two things:

1. Deprecates the `jdk.jsobject` module for removal; the javadoc indicates that the module will be delivered with JavaFX
2. Makes `jdk.jsobject` an upgradeable module, which will facilitate the transition by allowing the version of the module shipped with JavaFX to be used in favor of the deprecated module in the JDK itself.

-------------

Commit messages:
 - Merge branch 'master' into 8311530-depr-jsobject
 - Merge branch 'master' into 8311530-depr-jsobject
 - Update javadoc
 - Update copyright years
 - Merge branch 'master' into 8311530-depr-jsobject
 - Add jdk.jsobject to list of UPGRADEABLE_MODULES in UpgradeableModules test
 - 8311530: Deprecate jdk.jsobject module for removal

Changes: https://git.openjdk.org/jdk/pull/20555/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20555&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8311530
  Stats: 27 lines in 7 files changed: 17 ins; 5 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/20555.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20555/head:pull/20555

PR: https://git.openjdk.org/jdk/pull/20555

From kcr at openjdk.org  Thu Sep  5 21:16:58 2024
From: kcr at openjdk.org (Kevin Rushforth)
Date: Thu, 5 Sep 2024 21:16:58 GMT
Subject: RFR: 8311530: Deprecate jdk.jsobject module for removal
In-Reply-To: <IGLgrBcj15QFo70cviDkjokoBOBpDBYXru2PS2N7hKQ=.d365a073-1153-420f-992c-03c7994073e9@github.com>
References: <IGLgrBcj15QFo70cviDkjokoBOBpDBYXru2PS2N7hKQ=.d365a073-1153-420f-992c-03c7994073e9@github.com>
Message-ID: <p97afTZnY5Z8tP60HwLAOqiTumwQgsY321virh85zbs=.b1fa1990-349d-4966-8249-e771a4fda8ba@github.com>

On Mon, 12 Aug 2024 17:22:47 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it with JavaFX instead.
> 
> See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR openjdk/jfx#1529 for the JavaFX PR that will include the module with JavaFX. That PR describes the needed test scenarios.
> 
> This PR does two things:
> 
> 1. Deprecates the `jdk.jsobject` module for removal; the javadoc indicates that the module will be delivered with JavaFX
> 2. Makes `jdk.jsobject` an upgradeable module, which will facilitate the transition by allowing the version of the module shipped with JavaFX to be used in favor of the deprecated module in the JDK itself.

The GHA run shows a spurious failure in macOS (a network timeout cloning the repo). I'll rerun it with no changes to my branch.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20555#issuecomment-2332635931

From andrew at openjdk.org  Thu Sep  5 23:36:50 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 5 Sep 2024 23:36:50 GMT
Subject: RFR: 8339271: giflib attribution correction
In-Reply-To: <9bUf9UKVavgShir_2Z2Hfjelu4gLJUxoWCel8AntU_M=.2a57b6e4-dafa-45ec-97ba-a70da712b2f9@github.com>
References: <9bUf9UKVavgShir_2Z2Hfjelu4gLJUxoWCel8AntU_M=.2a57b6e4-dafa-45ec-97ba-a70da712b2f9@github.com>
Message-ID: <6NDFsqBnv87BBpf1dKCVdsrGQPTiesfXatVV9j7_CAQ=.aec581b3-14dc-4259-ab4e-a8e45c9fa1b3@github.com>

On Wed, 4 Sep 2024 19:43:19 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Changing format of file paths in giflib copyright file and removing extra text from authors list

This doesn't seem to make the situation any better. It merely removes the line about other contributors and pretends they don't exist.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20859#pullrequestreview-2284321326

From honkar at openjdk.org  Fri Sep  6 00:18:52 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 6 Sep 2024 00:18:52 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v3]
In-Reply-To: <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
Message-ID: <yahyqEwQa0uL1Jt8U6Kbs2imsifQots8rMtyOYzKIbs=.76261c44-578c-4388-bd21-67352de9bcf7@github.com>

On Wed, 4 Sep 2024 04:21:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
>> Test removed from `Problem-list` file as well.
>> 
>> CI testing link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test name renamed

LGTM other than the minor test changes mentioned below.

test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneBackgroundColor.java line 45:

> 43: 
> 44: public class TestJTabbedPaneBackgroundColor {
> 45:     private static final ArrayList<String> LIST = new ArrayList<>();

I think it can be changed to a non-final static var

Suggestion:

    private static ArrayList<String> lafList = new ArrayList<>();

test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneBackgroundColor.java line 54:

> 52:     public static void main(String[] args) throws Exception {
> 53:         robot = new Robot();
> 54:         robot.setAutoDelay(200);

This can be removed as there no Robot mouse or key events.
 `robot.setAutoDelay(200);`

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20791#pullrequestreview-2284347635
PR Review Comment: https://git.openjdk.org/jdk/pull/20791#discussion_r1746331625
PR Review Comment: https://git.openjdk.org/jdk/pull/20791#discussion_r1746333137

From rriggs at openjdk.org  Fri Sep  6 01:54:55 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Fri, 6 Sep 2024 01:54:55 GMT
Subject: RFR: 8311530: Deprecate jdk.jsobject module for removal
In-Reply-To: <IGLgrBcj15QFo70cviDkjokoBOBpDBYXru2PS2N7hKQ=.d365a073-1153-420f-992c-03c7994073e9@github.com>
References: <IGLgrBcj15QFo70cviDkjokoBOBpDBYXru2PS2N7hKQ=.d365a073-1153-420f-992c-03c7994073e9@github.com>
Message-ID: <_MLFl-Zir7vvv44qc5hGXChNRhuiwmvTYkXLxVIUFC0=.a6fd655a-6e1a-4704-b317-5a2553a86fd3@github.com>

On Mon, 12 Aug 2024 17:22:47 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it with JavaFX instead.
> 
> See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR openjdk/jfx#1529 for the JavaFX PR that will include the module with JavaFX. That PR describes the needed test scenarios.
> 
> This PR does two things:
> 
> 1. Deprecates the `jdk.jsobject` module for removal; the javadoc indicates that the module will be delivered with JavaFX
> 2. Makes `jdk.jsobject` an upgradeable module, which will facilitate the transition by allowing the version of the module shipped with JavaFX to be used in favor of the deprecated module in the JDK itself.

Looks good. I'll review the CSR when its ready.

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20555#pullrequestreview-2284421844

From tr at openjdk.org  Fri Sep  6 05:37:09 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 6 Sep 2024 05:37:09 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v6]
In-Reply-To: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
Message-ID: <nu1JlM8VceXybd4BPVtluLXpb1bykyoBuM5vMUK37FM=.846074eb-ddb7-485e-926b-d0d0ca4e8c1c@github.com>

> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
> 1. Move the frame to center of the screen rather than left top.
> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Updated with review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20723/files
  - new: https://git.openjdk.org/jdk/pull/20723/files/a02be6cf..560862ff

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20723&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20723&range=04-05

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20723.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20723/head:pull/20723

PR: https://git.openjdk.org/jdk/pull/20723

From alanb at openjdk.org  Fri Sep  6 05:39:55 2024
From: alanb at openjdk.org (Alan Bateman)
Date: Fri, 6 Sep 2024 05:39:55 GMT
Subject: RFR: 8311530: Deprecate jdk.jsobject module for removal
In-Reply-To: <IGLgrBcj15QFo70cviDkjokoBOBpDBYXru2PS2N7hKQ=.d365a073-1153-420f-992c-03c7994073e9@github.com>
References: <IGLgrBcj15QFo70cviDkjokoBOBpDBYXru2PS2N7hKQ=.d365a073-1153-420f-992c-03c7994073e9@github.com>
Message-ID: <VfAMbg1CKLOeWRZDWJE71tVL1xpX2oA0TLa4O7fufTo=.5276aab5-c12f-44b0-b55a-594d808c5e34@github.com>

On Mon, 12 Aug 2024 17:22:47 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it with JavaFX instead.
> 
> See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR openjdk/jfx#1529 for the JavaFX PR that will include the module with JavaFX. That PR describes the needed test scenarios.
> 
> This PR does two things:
> 
> 1. Deprecates the `jdk.jsobject` module for removal; the javadoc indicates that the module will be delivered with JavaFX
> 2. Makes `jdk.jsobject` an upgradeable module, which will facilitate the transition by allowing the version of the module shipped with JavaFX to be used in favor of the deprecated module in the JDK itself.

The changes to make jdk.jsobject an upgradeable module looks right.

I was initially surprised by the wording "will be delivered with JavaFX" but after playing with a few alternatives I concluded that what we have is okay.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20555#pullrequestreview-2284861631

From abhiscxk at openjdk.org  Fri Sep  6 05:47:31 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 6 Sep 2024 05:47:31 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v4]
In-Reply-To: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
Message-ID: <asCIwPpVBSJEEzo5ATNHaguheBOYFoiejkrrLiuYkgQ=.1c65ec01-9e7b-4412-8b5d-86a6c51a5617@github.com>

> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
> Test removed from `Problem-list` file as well.
> 
> CI testing link is posted in JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Remove robot autodelay, modify list variable declaration

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20791/files
  - new: https://git.openjdk.org/jdk/pull/20791/files/1ff306c4..52753953

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20791&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20791&range=02-03

  Stats: 5 lines in 1 file changed: 0 ins; 1 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/20791.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20791/head:pull/20791

PR: https://git.openjdk.org/jdk/pull/20791

From abhiscxk at openjdk.org  Fri Sep  6 05:47:31 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 6 Sep 2024 05:47:31 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v3]
In-Reply-To: <yahyqEwQa0uL1Jt8U6Kbs2imsifQots8rMtyOYzKIbs=.76261c44-578c-4388-bd21-67352de9bcf7@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
 <yahyqEwQa0uL1Jt8U6Kbs2imsifQots8rMtyOYzKIbs=.76261c44-578c-4388-bd21-67352de9bcf7@github.com>
Message-ID: <UQj7rM_-pQRvMfqm6buWIk-b3Hdsq2ov5EZVwUJk3Ic=.443fca42-86ca-41e6-9187-e5da8a199b20@github.com>

On Fri, 6 Sep 2024 00:13:26 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test name renamed
>
> test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneBackgroundColor.java line 54:
> 
>> 52:     public static void main(String[] args) throws Exception {
>> 53:         robot = new Robot();
>> 54:         robot.setAutoDelay(200);
> 
> This can be removed as there no Robot mouse or key events.
>  `robot.setAutoDelay(200);`

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20791#discussion_r1746538631

From abhiscxk at openjdk.org  Fri Sep  6 05:55:53 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 6 Sep 2024 05:55:53 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v6]
In-Reply-To: <nu1JlM8VceXybd4BPVtluLXpb1bykyoBuM5vMUK37FM=.846074eb-ddb7-485e-926b-d0d0ca4e8c1c@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <nu1JlM8VceXybd4BPVtluLXpb1bykyoBuM5vMUK37FM=.846074eb-ddb7-485e-926b-d0d0ca4e8c1c@github.com>
Message-ID: <QrotOi47rsw0q8tiRl9lqV0pM2oDlpiF90QcfWxCrSQ=.9f2af9d4-9e16-40da-b8d6-a9f444fc17d0@github.com>

On Fri, 6 Sep 2024 05:37:09 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rather than left top.
>> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated with review comments

test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 50:

> 48:     private static Checkbox checkbox;
> 49:     private static volatile Point point;
> 50:     private static volatile boolean checkmarkFound = false;

`checkmarkFound` need not to be `volatile`. Although declaring it as volatile won't add any overhead but it will prevent optimization. For this test, it won't have much impact though.

test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 61:

> 59:         try {
> 60:             EventQueue.invokeAndWait(() -> {
> 61:                 frame = new Frame("ComboBox checker scaling test");

I just noticed the title contains `ComboBox checker`. Should it be `CheckBox checker` ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20723#discussion_r1746545404
PR Review Comment: https://git.openjdk.org/jdk/pull/20723#discussion_r1746543021

From abhiscxk at openjdk.org  Fri Sep  6 06:01:22 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 6 Sep 2024 06:01:22 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in
 JColorChooser
Message-ID: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>

There is no Swatches tab available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test instructions.

-------------

Commit messages:
 - Whitespace error fix
 - Test instructions change

Changes: https://git.openjdk.org/jdk/pull/20867/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20867&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8226933
  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20867.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20867/head:pull/20867

PR: https://git.openjdk.org/jdk/pull/20867

From tr at openjdk.org  Fri Sep  6 06:09:07 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 6 Sep 2024 06:09:07 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v7]
In-Reply-To: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
Message-ID: <6k6-fOAIoHsWKATPNE6osJYU2Abdp6MVfCbswAo9AxA=.734208bd-86bc-4bf6-b8cf-bc3f465db059@github.com>

> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
> 1. Move the frame to center of the screen rather than left top.
> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Updated with review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20723/files
  - new: https://git.openjdk.org/jdk/pull/20723/files/560862ff..404bd11b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20723&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20723&range=05-06

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20723.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20723/head:pull/20723

PR: https://git.openjdk.org/jdk/pull/20723

From abhiscxk at openjdk.org  Fri Sep  6 06:12:51 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 6 Sep 2024 06:12:51 GMT
Subject: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine [v7]
In-Reply-To: <6k6-fOAIoHsWKATPNE6osJYU2Abdp6MVfCbswAo9AxA=.734208bd-86bc-4bf6-b8cf-bc3f465db059@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
 <6k6-fOAIoHsWKATPNE6osJYU2Abdp6MVfCbswAo9AxA=.734208bd-86bc-4bf6-b8cf-bc3f465db059@github.com>
Message-ID: <mLL9unEQfyKKWe8B7fr-UxF6lrW1g8C27RKpW9R5f7k=.993a802f-eea6-4bb1-a5d2-5cdd340239b8@github.com>

On Fri, 6 Sep 2024 06:09:07 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rather than left top.
>> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated with review comments

Look good to me now.

-------------

Marked as reviewed by abhiscxk (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20723#pullrequestreview-2284950786

From psadhukhan at openjdk.org  Fri Sep  6 06:14:49 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 6 Sep 2024 06:14:49 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser
In-Reply-To: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
Message-ID: <MmXuDxgdC4ROzJZdgxpnjKEak8CYP5PPwyL26bq6_yA=.7dd29d44-9b76-4d8e-8567-b34d1229e2a0@github.com>

On Thu, 5 Sep 2024 10:34:40 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> There is no Swatches tab available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test instructions.

test/jdk/javax/swing/JColorChooser/Test4887836.java line 45:

> 43:                                 then test passed, otherwise it failed.
> 44: 
> 45:                                 NOTE: There is no Swatches tab for GTK Look and Feel, Press Pass.""";

I guess better to restrict programmatically 
"GTK".equals(UIManager.getLookAndFeel().getName())
Also, add a comment why it is not applicable..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20867#discussion_r1746559640

From abhiscxk at openjdk.org  Fri Sep  6 06:29:49 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 6 Sep 2024 06:29:49 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser
In-Reply-To: <MmXuDxgdC4ROzJZdgxpnjKEak8CYP5PPwyL26bq6_yA=.7dd29d44-9b76-4d8e-8567-b34d1229e2a0@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
 <MmXuDxgdC4ROzJZdgxpnjKEak8CYP5PPwyL26bq6_yA=.7dd29d44-9b76-4d8e-8567-b34d1229e2a0@github.com>
Message-ID: <ftakYU_g2f53qJ39kj8DfBooQbPz2RGfsx8T7JLdfZY=.15991b16-a833-464b-8089-b69580e335a2@github.com>

On Fri, 6 Sep 2024 06:12:03 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> I guess better to restrict programmatically "GTK".equals(UIManager.getLookAndFeel().getName()) Also, add a comment why it is not applicable..

For a manual test, it can be run by command line with `Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel` option. How could I restrict programmatically ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20867#discussion_r1746572134

From psadhukhan at openjdk.org  Fri Sep  6 06:46:49 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 6 Sep 2024 06:46:49 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser
In-Reply-To: <ftakYU_g2f53qJ39kj8DfBooQbPz2RGfsx8T7JLdfZY=.15991b16-a833-464b-8089-b69580e335a2@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
 <MmXuDxgdC4ROzJZdgxpnjKEak8CYP5PPwyL26bq6_yA=.7dd29d44-9b76-4d8e-8567-b34d1229e2a0@github.com>
 <ftakYU_g2f53qJ39kj8DfBooQbPz2RGfsx8T7JLdfZY=.15991b16-a833-464b-8089-b69580e335a2@github.com>
Message-ID: <fzFbJ0JWp2uaiSRZNs-C_hG-tsYtiuwNc8QlpKXWXCw=.dc570681-6096-4aea-bf5d-e3fed6313f44@github.com>

On Fri, 6 Sep 2024 06:26:50 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> test/jdk/javax/swing/JColorChooser/Test4887836.java line 45:
>> 
>>> 43:                                 then test passed, otherwise it failed.
>>> 44: 
>>> 45:                                 NOTE: There is no Swatches tab for GTK Look and Feel, Press Pass.""";
>> 
>> I guess better to restrict programmatically 
>> "GTK".equals(UIManager.getLookAndFeel().getName())
>> Also, add a comment why it is not applicable..
>
>> I guess better to restrict programmatically "GTK".equals(UIManager.getLookAndFeel().getName()) Also, add a comment why it is not applicable..
> 
> For a manual test, it can be run by command line with `Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel` option. How could I restrict programmatically ?

Whatever L&F you are running on irrespective of manually or automated, it should be able to find out via getLookAndFeel..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20867#discussion_r1746588110

From abhiscxk at openjdk.org  Fri Sep  6 07:09:12 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 6 Sep 2024 07:09:12 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser [v2]
In-Reply-To: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
Message-ID: <zk2VTjM1flpwk38wllMvYN-eBHUELQOkLNF4iC2cemw=.5bbdc848-7f5e-4906-9822-1dea1d89471d@github.com>

> There is no Swatches tab available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test instructions.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Restrict test programatically for GTK L&F

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20867/files
  - new: https://git.openjdk.org/jdk/pull/20867/files/e18f940f..56bb68d9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20867&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20867&range=00-01

  Stats: 14 lines in 1 file changed: 10 ins; 2 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20867.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20867/head:pull/20867

PR: https://git.openjdk.org/jdk/pull/20867

From abhiscxk at openjdk.org  Fri Sep  6 07:18:49 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 6 Sep 2024 07:18:49 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser [v2]
In-Reply-To: <fzFbJ0JWp2uaiSRZNs-C_hG-tsYtiuwNc8QlpKXWXCw=.dc570681-6096-4aea-bf5d-e3fed6313f44@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
 <MmXuDxgdC4ROzJZdgxpnjKEak8CYP5PPwyL26bq6_yA=.7dd29d44-9b76-4d8e-8567-b34d1229e2a0@github.com>
 <ftakYU_g2f53qJ39kj8DfBooQbPz2RGfsx8T7JLdfZY=.15991b16-a833-464b-8089-b69580e335a2@github.com>
 <fzFbJ0JWp2uaiSRZNs-C_hG-tsYtiuwNc8QlpKXWXCw=.dc570681-6096-4aea-bf5d-e3fed6313f44@github.com>
Message-ID: <L1dLHwSNn7OUkYG4iVarzGPFlA1o_9okRB6AJ3zNaEw=.e8181112-65cc-4461-b2d8-4b41c1115ef7@github.com>

On Fri, 6 Sep 2024 06:44:25 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>>> I guess better to restrict programmatically "GTK".equals(UIManager.getLookAndFeel().getName()) Also, add a comment why it is not applicable..
>> 
>> For a manual test, it can be run by command line with `Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel` option. How could I restrict programmatically ?
>
> Whatever L&F you are running on irrespective of manually or automated, it should be able to find out via getLookAndFeel..

Yeah, you are right. Test updated to throw `jtreg.SkippedException` if it is run for GTK L&F.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20867#discussion_r1746620391

From psadhukhan at openjdk.org  Fri Sep  6 07:51:49 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 6 Sep 2024 07:51:49 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser [v2]
In-Reply-To: <zk2VTjM1flpwk38wllMvYN-eBHUELQOkLNF4iC2cemw=.5bbdc848-7f5e-4906-9822-1dea1d89471d@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
 <zk2VTjM1flpwk38wllMvYN-eBHUELQOkLNF4iC2cemw=.5bbdc848-7f5e-4906-9822-1dea1d89471d@github.com>
Message-ID: <MbwSM_Ok8t6aAYY6b-lHxwaY13fG-KhCwyELGg1CsyM=.27c2b19a-03ef-4a51-bbdb-df4d87b8e8e9@github.com>

On Fri, 6 Sep 2024 07:09:12 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> There is no Swatches tab available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test instructions.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restrict test programatically for GTK L&F

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20867#pullrequestreview-2285260817

From abhiscxk at openjdk.org  Fri Sep  6 08:03:53 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 6 Sep 2024 08:03:53 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v3]
In-Reply-To: <0aVuRMUkPDj7JN8RN8wNIRIHVb1s7rXa4Eslca4izZ4=.e544a627-9d90-4879-a35f-abf8684903a5@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <5KpxRMfOtJBFrisU07Wb6SubWd15_hVhtpfcWJpnzIQ=.b0a69f2e-bf37-41d1-9386-7e8f04cf9fe7@github.com>
 <tNgDRYhTbfiOVjZIiSKcz98uSFPL0MI9vIHGxXFLQsE=.a5a91402-cd2c-49b0-8ed8-d1c0c3d28e5a@github.com>
 <0aVuRMUkPDj7JN8RN8wNIRIHVb1s7rXa4Eslca4izZ4=.e544a627-9d90-4879-a35f-abf8684903a5@github.com>
Message-ID: <SGGDLMTOeA5Gfhvi3DgH9yJ80aYigXX3wyUrLLXipKg=.f791cb4f-237e-4ef9-a980-4471ab3ef68f@github.com>

On Wed, 4 Sep 2024 05:56:41 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>>> > > Is [JDK-7148101](https://bugs.openjdk.org/browse/JDK-7148101) still valid?
>>> > 
>>> > 
>>> > Yes, issue still exists for mac machine.
>>> 
>>> Issue is for AquaL&F which as per your verification in [JDK-8331619](https://bugs.openjdk.org/browse/JDK-8331619) and #19170 is not an issue it seems..
>> 
>> Yes, for Aqua L&F we were not able to verify the native behavior.
>> I think bug4690946.java test needs to be removed from closed problemlist.
>
>> > > > Is [JDK-7148101](https://bugs.openjdk.org/browse/JDK-7148101) still valid?
>> > > 
>> > > 
>> > > Yes, issue still exists for mac machine.
>> > 
>> > 
>> > Issue is for AquaL&F which as per your verification in [JDK-8331619](https://bugs.openjdk.org/browse/JDK-8331619) and #19170 is not an issue it seems..
>> 
>> Yes, for Aqua L&F we were not able to verify the native behavior. I think bug4690946.java test needs to be removed from closed problemlist.
> 
> Yes already raised the PR for removal..

@prsadhuk Minor update after you reviewed. Please re-review the PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2333476754

From tr at openjdk.org  Fri Sep  6 08:23:50 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 6 Sep 2024 08:23:50 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser [v2]
In-Reply-To: <zk2VTjM1flpwk38wllMvYN-eBHUELQOkLNF4iC2cemw=.5bbdc848-7f5e-4906-9822-1dea1d89471d@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
 <zk2VTjM1flpwk38wllMvYN-eBHUELQOkLNF4iC2cemw=.5bbdc848-7f5e-4906-9822-1dea1d89471d@github.com>
Message-ID: <fjVjC9_Ktrzg6yf7Y3gO-RvfuggKz1hPpabPtcEHnsQ=.ae9f623c-f533-48ca-8981-af3955a76b19@github.com>

On Fri, 6 Sep 2024 07:09:12 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> There is no Swatches tab available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test instructions.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restrict test programatically for GTK L&F

Looks good to me.

-------------

Marked as reviewed by tr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20867#pullrequestreview-2285370704

From abhiscxk at openjdk.org  Fri Sep  6 10:34:18 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 6 Sep 2024 10:34:18 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser [v3]
In-Reply-To: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
Message-ID: <SYI3e_-_-m2ZNZgm2q8z_W4o5VRlqNcwW8p1vsMGsYE=.34e08e25-a3da-4546-91f7-9c36191b00ec@github.com>

> There is no Swatches tab available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test instructions.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Open source test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20867/files
  - new: https://git.openjdk.org/jdk/pull/20867/files/56bb68d9..7f984872

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20867&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20867&range=01-02

  Stats: 69 lines in 1 file changed: 69 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20867.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20867/head:pull/20867

PR: https://git.openjdk.org/jdk/pull/20867

From abhiscxk at openjdk.org  Fri Sep  6 10:34:19 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 6 Sep 2024 10:34:19 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser [v2]
In-Reply-To: <MbwSM_Ok8t6aAYY6b-lHxwaY13fG-KhCwyELGg1CsyM=.27c2b19a-03ef-4a51-bbdb-df4d87b8e8e9@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
 <zk2VTjM1flpwk38wllMvYN-eBHUELQOkLNF4iC2cemw=.5bbdc848-7f5e-4906-9822-1dea1d89471d@github.com>
 <MbwSM_Ok8t6aAYY6b-lHxwaY13fG-KhCwyELGg1CsyM=.27c2b19a-03ef-4a51-bbdb-df4d87b8e8e9@github.com>
Message-ID: <0K3OgthCNz9-WvIMKMjKeOi_hsVS414LROvs6gMX5bE=.addcf6d6-85e7-4a7e-9e6f-9f5d5887f559@github.com>

On Fri, 6 Sep 2024 07:49:06 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Restrict test programatically for GTK L&F
>
> Marked as reviewed by psadhukhan (Reviewer).

@prsadhuk @TejeshR13 bug4419255.java is open sourced. Fixed similar issue for ColorChooser UI in GTK L&F. 
Please re-review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20867#issuecomment-2333763872

From psadhukhan at openjdk.org  Fri Sep  6 11:20:51 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 6 Sep 2024 11:20:51 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser [v3]
In-Reply-To: <SYI3e_-_-m2ZNZgm2q8z_W4o5VRlqNcwW8p1vsMGsYE=.34e08e25-a3da-4546-91f7-9c36191b00ec@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
 <SYI3e_-_-m2ZNZgm2q8z_W4o5VRlqNcwW8p1vsMGsYE=.34e08e25-a3da-4546-91f7-9c36191b00ec@github.com>
Message-ID: <tJx8ylJQQ0x6w5iBQeMJsKEb1CP9r9m1-0QXqKpKfj0=.ef5de521-f1a1-4185-9d24-050a5064ff99@github.com>

On Fri, 6 Sep 2024 10:34:18 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> There is no Swatches tab available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test instructions.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Open source test

test/jdk/javax/swing/JColorChooser/Test4887836.java line 47:

> 45:         // There is no Swatches tab available for GTK L&F, skip the testing.
> 46:         if (UIManager.getLookAndFeel().getName().contains("GTK")) {
> 47:             System.out.println("Test skipped for " + UIManager.getLookAndFeel().getName());

same here

test/jdk/javax/swing/plaf/basic/BasicSliderUI/bug4419255.java line 46:

> 44:         // There is no RGB tab available for GTK L&F, skip the testing.
> 45:         if (UIManager.getLookAndFeel().getName().contains("GTK")) {
> 46:             System.out.println("Test skipped for " + UIManager.getLookAndFeel().getName());

guess no need to enquire it again in as we know it's GTK

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20867#discussion_r1746953971
PR Review Comment: https://git.openjdk.org/jdk/pull/20867#discussion_r1746953664

From abhiscxk at openjdk.org  Fri Sep  6 11:37:10 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 6 Sep 2024 11:37:10 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser [v4]
In-Reply-To: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
Message-ID: <chHEHotvS2SMPSaMhpsXF9NvJ7-kFvDNGuq0haoKn44=.eb9641ae-182d-483d-a432-ebfb7a44734a@github.com>

> There is no Swatches tab available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test instructions.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Remove print statement

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20867/files
  - new: https://git.openjdk.org/jdk/pull/20867/files/7f984872..677cb0e9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20867&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20867&range=02-03

  Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20867.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20867/head:pull/20867

PR: https://git.openjdk.org/jdk/pull/20867

From abhiscxk at openjdk.org  Fri Sep  6 11:37:10 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 6 Sep 2024 11:37:10 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser [v3]
In-Reply-To: <tJx8ylJQQ0x6w5iBQeMJsKEb1CP9r9m1-0QXqKpKfj0=.ef5de521-f1a1-4185-9d24-050a5064ff99@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
 <SYI3e_-_-m2ZNZgm2q8z_W4o5VRlqNcwW8p1vsMGsYE=.34e08e25-a3da-4546-91f7-9c36191b00ec@github.com>
 <tJx8ylJQQ0x6w5iBQeMJsKEb1CP9r9m1-0QXqKpKfj0=.ef5de521-f1a1-4185-9d24-050a5064ff99@github.com>
Message-ID: <KufpODCy_AAhRIh0QecXP-DEVexoYF8dG6xZ7TozoyA=.4a5e92a3-0b06-416f-9fb2-348c3d739d34@github.com>

On Fri, 6 Sep 2024 11:18:13 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Open source test
>
> test/jdk/javax/swing/JColorChooser/Test4887836.java line 47:
> 
>> 45:         // There is no Swatches tab available for GTK L&F, skip the testing.
>> 46:         if (UIManager.getLookAndFeel().getName().contains("GTK")) {
>> 47:             System.out.println("Test skipped for " + UIManager.getLookAndFeel().getName());
> 
> same here

Removed print statement here as well.

> test/jdk/javax/swing/plaf/basic/BasicSliderUI/bug4419255.java line 46:
> 
>> 44:         // There is no RGB tab available for GTK L&F, skip the testing.
>> 45:         if (UIManager.getLookAndFeel().getName().contains("GTK")) {
>> 46:             System.out.println("Test skipped for " + UIManager.getLookAndFeel().getName());
> 
> guess no need to enquire it again in as we know it's GTK

I think print statement is not required, anyways it is captured in exception, so removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20867#discussion_r1746972697
PR Review Comment: https://git.openjdk.org/jdk/pull/20867#discussion_r1746972353

From psadhukhan at openjdk.org  Fri Sep  6 12:23:51 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 6 Sep 2024 12:23:51 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser [v4]
In-Reply-To: <chHEHotvS2SMPSaMhpsXF9NvJ7-kFvDNGuq0haoKn44=.eb9641ae-182d-483d-a432-ebfb7a44734a@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
 <chHEHotvS2SMPSaMhpsXF9NvJ7-kFvDNGuq0haoKn44=.eb9641ae-182d-483d-a432-ebfb7a44734a@github.com>
Message-ID: <DQxagzHBFOAQBdqz-u2dI9F_uZL6ThOiAkdibKuOYaM=.d2a02aa4-ed09-4e4a-aa92-201d28e442f7@github.com>

On Fri, 6 Sep 2024 11:37:10 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> There is no Swatches tab available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test instructions.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove print statement

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20867#pullrequestreview-2286138561

From kcr at openjdk.org  Fri Sep  6 13:18:49 2024
From: kcr at openjdk.org (Kevin Rushforth)
Date: Fri, 6 Sep 2024 13:18:49 GMT
Subject: RFR: 8311530: Deprecate jdk.jsobject module for removal
In-Reply-To: <_MLFl-Zir7vvv44qc5hGXChNRhuiwmvTYkXLxVIUFC0=.a6fd655a-6e1a-4704-b317-5a2553a86fd3@github.com>
References: <IGLgrBcj15QFo70cviDkjokoBOBpDBYXru2PS2N7hKQ=.d365a073-1153-420f-992c-03c7994073e9@github.com>
 <_MLFl-Zir7vvv44qc5hGXChNRhuiwmvTYkXLxVIUFC0=.a6fd655a-6e1a-4704-b317-5a2553a86fd3@github.com>
Message-ID: <WhG8jlLAttk0bO_beHeYTh7G3lhWR-uRvJdPqVr_wj4=.2a8b5a00-5382-46df-8e39-abcfa76fc64b@github.com>

On Fri, 6 Sep 2024 01:52:10 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Looks good. I'll review the CSR when its ready.

Thanks.

> The changes to make jdk.jsobject an upgradeable module looks right.

Thanks for checking. My testing primarily focused on this aspect of the change, so it's pretty well tested.

> I was initially surprised by the wording "will be delivered with JavaFX" but after playing with a few alternatives I concluded that what we have is okay.

Yeah, I tried a few variants and couldn't come up with anything better.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20555#issuecomment-2334035899

From serb at openjdk.org  Fri Sep  6 16:16:07 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 6 Sep 2024 16:16:07 GMT
Subject: RFR: 8339341: SurfaceManager cacheMap retains strong references
 [v2]
In-Reply-To: <VZi8p9nS4x7oE4ES1NhMBsbUiLVVQ_WmWJoFVwqFqdQ=.0dc37621-d54c-40cf-a5ad-fc4abe29a4b5@github.com>
References: <1ecWvJLiG54e0saEz_Jjz46gzxXnqsNDagdPQ3y_BN4=.27116e44-886b-405f-9d87-ec5e82e2fd20@github.com>
 <VZi8p9nS4x7oE4ES1NhMBsbUiLVVQ_WmWJoFVwqFqdQ=.0dc37621-d54c-40cf-a5ad-fc4abe29a4b5@github.com>
Message-ID: <rlI7k3z6gwXOG80917AEj16Jn3HY3NzoerSoXDGky3M=.1bd0696d-ffae-4e64-9b24-7d2daf141976@github.com>

On Thu, 5 Sep 2024 12:04:19 GMT, Nikita Gubarkov <ngubarkov at openjdk.org> wrote:

>> I moved SurfaceDataProxy cache into a separate class.
>> Now caching level is determined by placement of the SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" proxies and therefore strong refs via them do not prevent the cache and GraphicsConfig from being detected as weakly reachable.
>
> Nikita Gubarkov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8339341: Make SurfaceDataProxy cache a separate entity.
>   
>   Now caching level is determined by placement of the SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" proxies and therefore strong refs via them do not prevent the cache (and hence GraphicsConfig) from being detected as weakly reachable.

If possible please add the "steps to reproduce" to the JBS issue.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20825#issuecomment-2334393018

From achung at openjdk.org  Fri Sep  6 17:23:05 2024
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 6 Sep 2024 17:23:05 GMT
Subject: RFR: 8339271: giflib attribution correction
In-Reply-To: <6NDFsqBnv87BBpf1dKCVdsrGQPTiesfXatVV9j7_CAQ=.aec581b3-14dc-4259-ab4e-a8e45c9fa1b3@github.com>
References: <9bUf9UKVavgShir_2Z2Hfjelu4gLJUxoWCel8AntU_M=.2a57b6e4-dafa-45ec-97ba-a70da712b2f9@github.com>
 <6NDFsqBnv87BBpf1dKCVdsrGQPTiesfXatVV9j7_CAQ=.aec581b3-14dc-4259-ab4e-a8e45c9fa1b3@github.com>
Message-ID: <bKaVAw5XdVB0mUQuOe1JJ50D3RCqZlCm3xFsXbbl_w0=.b46f1348-79ff-4795-ae8e-84be65023385@github.com>

On Thu, 5 Sep 2024 23:34:23 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This doesn't seem to make the situation any better. It merely removes the line about other contributors and pretends they don't exist.

That line was mistakenly added in the previous giflib update and is copied directly from the giflib 5.2.2 README file. The line mentions other authors but if those authors aren?t explicitly stated there?s nothing we can do. The line itself should be removed because it isn?t precise and shouldn?t be part of the list of authors section of the attribution.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20859#issuecomment-2334502763

From achung at openjdk.org  Fri Sep  6 22:07:15 2024
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 6 Sep 2024 22:07:15 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser [v4]
In-Reply-To: <chHEHotvS2SMPSaMhpsXF9NvJ7-kFvDNGuq0haoKn44=.eb9641ae-182d-483d-a432-ebfb7a44734a@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
 <chHEHotvS2SMPSaMhpsXF9NvJ7-kFvDNGuq0haoKn44=.eb9641ae-182d-483d-a432-ebfb7a44734a@github.com>
Message-ID: <Txtgkmq6behA_Glz92GOezq0AX8eZgk98944NFFOG4U=.6d3e30f5-4be4-4152-9858-314f233d5357@github.com>

On Fri, 6 Sep 2024 11:37:10 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> There is no Swatches tab available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test instructions.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove print statement

Since these two tests are the same test would it be better to merge them into 1 test with the test instructions combined for both tests?

-------------

PR Review: https://git.openjdk.org/jdk/pull/20867#pullrequestreview-2287215158

From honkar at openjdk.org  Sat Sep  7 00:10:05 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Sat, 7 Sep 2024 00:10:05 GMT
Subject: RFR: 8339524: Clean up ExtendedRobot tests
In-Reply-To: <HC64NDQIWs3GWaJI1BscY7iAsc6uZabf1QytcbWHqdU=.f353752e-03ca-4a8f-986b-3690d3a1da52@github.com>
References: <HC64NDQIWs3GWaJI1BscY7iAsc6uZabf1QytcbWHqdU=.f353752e-03ca-4a8f-986b-3690d3a1da52@github.com>
Message-ID: <EKTw-Uc-Eo0Qbjx0UrjBHzIZ4Bb--Gc3h192WTzSeEM=.e721f3c2-fd31-4f58-8bbc-e19579fc0383@github.com>

On Wed, 4 Sep 2024 03:34:34 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Cleaning up tests building ExtendedRobot that shouldn't be.

Are these the only two tests being changed as part of this PR?
Please update copyright years and expand import statements.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20846#pullrequestreview-2287285431

From honkar at openjdk.org  Sat Sep  7 00:28:08 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Sat, 7 Sep 2024 00:28:08 GMT
Subject: RFR: 8051591: Test
 javax/swing/JTabbedPane/8007563/Test8007563.java fails [v4]
In-Reply-To: <asCIwPpVBSJEEzo5ATNHaguheBOYFoiejkrrLiuYkgQ=.1c65ec01-9e7b-4412-8b5d-86a6c51a5617@github.com>
References: <IpnUrpHzwmiPIR4xMGT1SaEidlMPVqRKBFBkqZFTzyo=.a72c1953-9a33-4dd2-8234-da7bd3e748e5@github.com>
 <asCIwPpVBSJEEzo5ATNHaguheBOYFoiejkrrLiuYkgQ=.1c65ec01-9e7b-4412-8b5d-86a6c51a5617@github.com>
Message-ID: <81Qem1iRTyv7J-ndZ0S3MGHRzyaVdbKlGrVczwQx2CE=.0c3cc953-4780-4ffb-be85-e368169f924d@github.com>

On Fri, 6 Sep 2024 05:47:31 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
>> Test removed from `Problem-list` file as well.
>> 
>> CI testing link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove robot autodelay, modify list variable declaration

LGTM.
Adding a consolidated note listing the JBS ids & corresponding tests related to JTabbedPane background issue in this PR or JBS might be helpful for future reference (avoids scrolling through PR comments).

1. [JDK-8051591](https://bugs.openjdk.org/browse/JDK-8051591) - Test javax/swing/JTabbedPane/8007563/Test8007563.java => test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneBackgroundColor.java
...
so on.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20791#pullrequestreview-2287290618

From tr at openjdk.org  Mon Sep  9 05:17:06 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 9 Sep 2024 05:17:06 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser [v4]
In-Reply-To: <chHEHotvS2SMPSaMhpsXF9NvJ7-kFvDNGuq0haoKn44=.eb9641ae-182d-483d-a432-ebfb7a44734a@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
 <chHEHotvS2SMPSaMhpsXF9NvJ7-kFvDNGuq0haoKn44=.eb9641ae-182d-483d-a432-ebfb7a44734a@github.com>
Message-ID: <oIob3ilYETOGk-V5H9KLuUd41GWgAdoxoHxn7e6jLMY=.2d43876c-cac6-4b9d-83a7-2e87d95e5b7a@github.com>

On Fri, 6 Sep 2024 11:37:10 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> There is no Swatches tab available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test instructions.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove print statement

test/jdk/javax/swing/plaf/basic/BasicSliderUI/bug4419255.java line 66:

> 64:     private static JColorChooser createColorChooser() {
> 65:         JColorChooser chooser = new JColorChooser(Color.BLUE);
> 66:         return chooser;

Suggestion:

        return new JColorChooser(Color.BLUE);;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20867#discussion_r1749572412

From tr at openjdk.org  Mon Sep  9 05:20:11 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 9 Sep 2024 05:20:11 GMT
Subject: Integrated: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java
 test failed on linux machine
In-Reply-To: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
References: <PxROWT0bcp-dpwgFt1aD6i9X5er-Nu0xhCmdyRPtf74=.5dae567e-6389-4b38-ad83-83053cd4a076@github.com>
Message-ID: <aBlMEVluBQRh0kWiIUCiUnUrj1yDRZgKg7yPBLAchxI=.906b9717-61e3-414c-bf54-f6b165813f5a@github.com>

On Tue, 27 Aug 2024 06:04:47 GMT, Tejesh R <tr at openjdk.org> wrote:

> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
> 1. Move the frame to center of the screen rather than left top.
> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.

This pull request has now been integrated.

Changeset: 79d76135
Author:    Tejesh R <tr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/79d761358c5ee19b9028ad89d7c6a33dff6aa64a
Stats:     26 lines in 1 file changed: 13 ins; 0 del; 13 mod

8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java test failed on linux machine

Reviewed-by: abhiscxk, honkar

-------------

PR: https://git.openjdk.org/jdk/pull/20723

From serb at openjdk.org  Mon Sep  9 07:28:12 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Mon, 9 Sep 2024 07:28:12 GMT
Subject: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail
 after JDK-8327401
Message-ID: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>

Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been tweaked, see inline comments.

Notes:
 * We have a few XXXRepaint.java tests and in this patch, I updated all of them to follow the change added to the ListRepaint.java

@azvegint @aivanov-jdk please take a look.

-------------

Commit messages:
 - Update ProblemList.txt
 - add try/finally
 - 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401

Changes: https://git.openjdk.org/jdk/pull/20861/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20861&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339561
  Stats: 171 lines in 9 files changed: 51 ins; 40 del; 80 mod
  Patch: https://git.openjdk.org/jdk/pull/20861.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20861/head:pull/20861

PR: https://git.openjdk.org/jdk/pull/20861

From serb at openjdk.org  Mon Sep  9 07:28:14 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Mon, 9 Sep 2024 07:28:14 GMT
Subject: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may
 fail after JDK-8327401
In-Reply-To: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
References: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
Message-ID: <KbV8yWpFgwuRih_tbYJT1CqWccszOYFv0W9TDs1ElyE=.17b7574c-c4be-4005-b616-e67e19dab8f7@github.com>

On Wed, 4 Sep 2024 20:50:38 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been tweaked, see inline comments.
> 
> Notes:
>  * We have a few XXXRepaint.java tests and in this patch, I updated all of them to follow the change added to the ListRepaint.java
> 
> @azvegint @aivanov-jdk please take a look.

test/jdk/java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java line 42:

> 40:     private volatile Frame frame, frame2;
> 41:     private volatile Button button, button2;
> 42:     private volatile TextField textField, textField2;

probably unnecessary but some of these fields might be used on different threads, so just in case.

test/jdk/java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java line 55:

> 53:             test.doTest();
> 54:         } finally {
> 55:             EventQueue.invokeAndWait(() -> {

The test should wait until the frame will be disposed.
"invokeLater" was added [here](https://github.com/openjdk/jdk/pull/19339/files#diff-6141b9cfb077259bad37ff9fd15782c5bb31d9c52aadc81a177d9057e177d415R55),

test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java line 68:

> 66:         KeyEventsTest app = new KeyEventsTest();
> 67:         try {
> 68:             app.initAndShowGui();

The test was changed [here](https://github.com/openjdk/jdk/pull/19339/files#diff-054074499ab6611e764a315fb13c51af4ad063b07f481e775a2262196077d285R69), the root cause of the failure discussed in https://github.com/openjdk/jdk/pull/19339/files#r1609189736 is a product bug: https://bugs.openjdk.org/browse/JDK-8201307.

test/jdk/java/awt/Paint/ListRepaint.java line 43:

> 41:         for (int i = 0; i < 10; ++i) {
> 42:             try {
> 43:                 EventQueue.invokeLater(ListRepaint::createAndShowGUI);

The purpose of the test is to run some methods of the AWT component on the main thread and check if it will be refreshed on the EDT. It was changed [here](https://github.com/openjdk/jdk/pull/19339/files#r1609190355). It is a product bug: https://bugs.openjdk.org/browse/JDK-8201307.

test/jdk/javax/swing/JButton/bug4490179.java line 85:

> 83:             robot.mousePress(InputEvent.BUTTON3_DOWN_MASK);
> 84:             robot.mouseRelease(InputEvent.BUTTON3_DOWN_MASK);
> 85:             robot.delay(3000);

The test was discussed [here](https://github.com/openjdk/jdk/pull/19339/files#r1609201116). It seems that the purpose of the test is to check that no events will be generated while the left button is pressed, so we should check that "ActionListener" is not triggered and then release the mouse button.
Thoughts?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1749635644
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1749633385
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1749639085
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1749645263
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1749647438

From mbaesken at openjdk.org  Mon Sep  9 13:35:35 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Mon, 9 Sep 2024 13:35:35 GMT
Subject: RFR: 8339731:
 java.desktop/share/classes/javax/swing/text/html/default.css typo in margin
 settings
Message-ID: <iftwYjtMZe-ThXj8bLQ609WXXCiuDzyAz7AGp6-jywU=.2ec4a132-d127-4641-987e-7febebe82ed2@github.com>

java.desktop/share/classes/javax/swing/text/html/default.css:105: margin-rigth: 0;

seems to be a typo (must be right).

-------------

Commit messages:
 - JDK-8339731

Changes: https://git.openjdk.org/jdk/pull/20915/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20915&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339731
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/20915.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20915/head:pull/20915

PR: https://git.openjdk.org/jdk/pull/20915

From aivanov at openjdk.org  Mon Sep  9 18:48:04 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 9 Sep 2024 18:48:04 GMT
Subject: RFR: 8326027: [TEST_BUG]Comparing buffered images  of white
 background frame fails in Mac
In-Reply-To: <9EEL4ctBHQI73B_nmGvnucR4LMefzbGCpSUd1URgr8o=.cc576bd9-025a-4aec-83e1-f66388de3629@github.com>
References: <k_dehNjnRND72N061bx31c9YclyJhyL2hK1NHPJcLkE=.5a4fd4d5-ee80-4db0-bae4-4008360ead28@github.com>
 <gCFzYGg4FuXFwadvTZE-T5yHMO8nvCOKY7ps_si5xKE=.72e17254-8740-4444-aa6c-4eed86de65ce@github.com>
 <qNZO9RhbyJWm_TkeB02gQnQ_w8T9FZaVriftvUC6Hv0=.b9b97880-6763-48d9-839d-6461a4ff8f51@github.com>
 <0FKvhBMfDuyvzus_Q_sjhmFB02FPipKX9p54KNy6w0k=.cf25ba18-9c25-4079-aeae-c2ffeaf0eafe@github.com>
 <gYvarNYPdKz4YIvCq2MNVxQqkmmp4c2PJT_ALUCHTII=.47541591-c627-4d2d-9866-46bdcb35d30b@github.com>
 <9EEL4ctBHQI73B_nmGvnucR4LMefzbGCpSUd1URgr8o=.cc576bd9-025a-4aec-83e1-f66388de3629@github.com>
Message-ID: <I_SUvpNxGxBWiGFPjuAML8-NA71uTLmtc5h8GXx8opE=.5943ad4e-938c-4678-aed0-29dfa2a447c7@github.com>

On Tue, 3 Sep 2024 09:37:50 GMT, Tejesh R <tr at openjdk.org> wrote:

> > This is why I asked the question: does the comparison remain accurate without the need for tolerance if you use `Robot.createMultiResolutionScreenCapture` and use the highest resolution from the returned multi-resolution image?
> 
> I couldn't reproduce the issue neither with `Robot.createMultiResolutionScreenCapture` nor with `Robot.createScreenCapture` since the failure occurs intermittently, not able to say anything about using `Robot.createMultiResolutionScreenCapture` instead of `Robot.createScreenCapture` .

According to your report in JBS, the white color is not exactly white: `0xFFEE'EEEE`. White color has value of `0xFFFF'FFFF`.

However, it's also common on Macs (because of color profile applied?), I mean that the captured color value is the same as the value used for filling.

At the same time, I expect the color is the same across the entire frame surface. What we see is that there are variations. I wonder how many pixels on the image have different color, other than the first pixel.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20760#issuecomment-2338839726

From aivanov at openjdk.org  Mon Sep  9 20:25:12 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 9 Sep 2024 20:25:12 GMT
Subject: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may
 fail after JDK-8327401
In-Reply-To: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
References: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
Message-ID: <gcx7ONrZbHWzpVXqjZwaa8Gc1zTYj-H0RtictQv_S3Y=.f708d7bd-5f4b-4408-a226-557b0baf2a4e@github.com>

On Wed, 4 Sep 2024 20:50:38 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been tweaked, see inline comments.
> 
> Notes:
>  * We have a few XXXRepaint.java tests and in this patch, I updated all of them to follow the change added to the ListRepaint.java
> 
> @azvegint @aivanov-jdk please take a look.

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java line 53:

> 51: 
> 52: public class KeyEventsTest {
> 53:     private volatile TestState currentState;

I'd rather not declare it a `volatile`. It could give a false impression of being thread-safe but it is not. The `volatile` modifier has a meaning only when it's written and read subsequently. If the reference doesn't change, it has no effect on the visibility of the internal object state.

The value is assigned to `currentState` while holding a lock `LOCK`.

At the same time, `currentState.setAction(true)` is called without any synchronisation and adding `volatile` won't make the change of the state thread-safe.

test/jdk/java/awt/Paint/ButtonRepaint.java line 35:

> 33: public final class ButtonRepaint extends Button {
> 34: 
> 35:     public static void main(final String[] args) {

Could expand imports, remove `@author` tag and the second `*` from `/**`?

test/jdk/java/awt/Paint/CheckboxRepaint.java line 34:

> 32: public final class CheckboxRepaint extends Checkbox {
> 33: 
> 34:     public static void main(final String[] args) {

Could expand imports, remove `@author` tag and the second `*` from `/**`?

test/jdk/java/awt/Paint/LabelRepaint.java line 37:

> 35: public final class LabelRepaint extends Label {
> 36: 
> 37:     public static void main(final String[] args) {

Could you remove `@author` tag, update copyright year?

test/jdk/java/awt/Paint/ListRepaint.java line 35:

> 33:  * @author Sergey Bylokhov
> 34:  */
> 35: public final class ListRepaint extends List {

Could you remove `@author` tag and the second `*` from `/**`?

test/jdk/javax/swing/JButton/bug4490179.java line 56:

> 54:         try {
> 55:             SwingUtilities.invokeAndWait(() -> {
> 56:                 frame = new JFrame("bug4490179");

Instead of three volatile fields ? `pt`, `buttonW`, `buttonH` ? there could be only one:


            SwingUtilities.invokeAndWait(() -> {
                Point loc = button.getLocationOnScreen();
                Dimension size = button.getSize(); 
                pt = new Point(loc.x + size.width / 2,
                               loc.y + size.height / 2);
            });


I think this better conveys the idea, less variables / fields to track in your mind.

test/jdk/javax/swing/JButton/bug4490179.java line 61:

> 59:                 button.addActionListener(new ActionListener() {
> 60:                     public void actionPerformed(ActionEvent e) {
> 61:                         passed = false;

Maybe use two `CountDownLatch`es:


                    if ((e.getModifiers() & InputEvent.BUTTON1_MASK)
                            != InputEvent.BUTTON1_MASK) {
                        wrongMouseButton.countDown();
                    } else {
                        mouseButton1.countDown();
                    }


Then in main:


           robot.mouseRelease(InputEvent.BUTTON3_DOWN_MASK);
           // robot.delay(3000);
           if (wrongMouseButton.await(2, TimeUnit.SECONDS)) {
               // Restore robot state
               robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK); 
               throw new RuntimeException("ActionEvent delivered from mouse button 3");
           }

           robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK); 
           if (mouseButton1.await(2, TimeUnit.SECONDS)) {
               throw new RuntimeException("ActionEvent not delivered from mouse button 1");
           }

test/jdk/javax/swing/JButton/bug4490179.java line 62:

> 60:                     public void actionPerformed(ActionEvent e) {
> 61:                         passed = false;
> 62:                     }

The updated code here is correct; Alexander has restored the condition that was present in the original test which was closed-source and manual.

However, it may be not necessary. Instead, the test should fail immediately if `ActionEvent` contains anything but `BUTTON1_DOWN_MASK`. (Well, cleaning up robot state to release mouse buttons is a good thing to do.)

test/jdk/javax/swing/JButton/bug4490179.java line 89:

> 87:             robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 88: 
> 89:             if (!result) {

Perhaps, we should ensure that an `ActionEvent` gets delivered at this point. Is it expected or not?

test/jdk/javax/swing/plaf/basic/BasicMenuUI/4983388/bug4983388.java line 97:

> 95:         });
> 96: 
> 97:         if (!bMenuSelected) {

Could you also expand imports and remove `@author` tag?

-------------

PR Review: https://git.openjdk.org/jdk/pull/20861#pullrequestreview-2290709302
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750819337
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750830425
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750831557
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750833000
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750842554
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750877763
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750872680
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750863160
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750857895
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750879942

From aivanov at openjdk.org  Mon Sep  9 20:25:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 9 Sep 2024 20:25:13 GMT
Subject: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may
 fail after JDK-8327401
In-Reply-To: <KbV8yWpFgwuRih_tbYJT1CqWccszOYFv0W9TDs1ElyE=.17b7574c-c4be-4005-b616-e67e19dab8f7@github.com>
References: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
 <KbV8yWpFgwuRih_tbYJT1CqWccszOYFv0W9TDs1ElyE=.17b7574c-c4be-4005-b616-e67e19dab8f7@github.com>
Message-ID: <gzCkOQ3mvf8uLuq_Ap-IDjWLuPxI1N2YyBQARngfeS4=.e431c177-c934-412a-a24d-52072500839f@github.com>

On Mon, 9 Sep 2024 06:27:26 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been tweaked, see inline comments.
>> 
>> Notes:
>>  * We have a few XXXRepaint.java tests and in this patch, I updated all of them to follow the change added to the ListRepaint.java
>> 
>> @azvegint @aivanov-jdk please take a look.
>
> test/jdk/java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java line 42:
> 
>> 40:     private volatile Frame frame, frame2;
>> 41:     private volatile Button button, button2;
>> 42:     private volatile TextField textField, textField2;
> 
> probably unnecessary but some of these fields might be used on different threads, so just in case.

Likely, it's unnecessary. I don't mind though.

I'd rather refactor the test to simplify it. Using `CountDownLatch` or other synchronisation primitives instead of wait/notify. I submitted [JDK-8339791](https://bugs.openjdk.org/browse/JDK-8339791). Feel free to re-assign if you like.

> test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java line 68:
> 
>> 66:         KeyEventsTest app = new KeyEventsTest();
>> 67:         try {
>> 68:             app.initAndShowGui();
> 
> The test was changed [here](https://github.com/openjdk/jdk/pull/19339/files#diff-054074499ab6611e764a315fb13c51af4ad063b07f481e775a2262196077d285R69), the root cause of the failure discussed in https://github.com/openjdk/jdk/pull/19339/files#r1609189736 is a product bug: https://bugs.openjdk.org/browse/JDK-8201307.

Not sure if it's a product bug?

AWT components do not explicitly state whether they're thread-safe or not. It's more or less assumed they should be. At the same time, I don't see code which ensures all the cases are thread-safe.

As far as I know, clientlibs group has been treating AWT components just like Swing ones: for safety create, access and destroy AWT components on EDT only.

I haven't looked at the test code thoroughly. It looks it still needs more investigation.

At the same time, I find it weird that `repaint` paints directly in its code and then posts paint event.

https://github.com/openjdk/jdk/blob/77468c284c068f921da543edd28333911e915b61/src/java.desktop/unix/classes/sun/awt/X11/XListPeer.java#L389-L390

Overall, it needs more investigation. It could be that the fix for [JDK-6471693](https://bugs.openjdk.org/browse/JDK-6471693) needs revising.

> test/jdk/java/awt/Paint/ListRepaint.java line 43:
> 
>> 41:         for (int i = 0; i < 10; ++i) {
>> 42:             try {
>> 43:                 EventQueue.invokeLater(ListRepaint::createAndShowGUI);
> 
> The purpose of the test is to run some methods of the AWT component on the main thread and check if it will be refreshed on the EDT. It was changed [here](https://github.com/openjdk/jdk/pull/19339/files#r1609190355). It is a product bug: https://bugs.openjdk.org/browse/JDK-8201307.

Yep, the previous update has changed the logic of the test so that it no longer reproduces the original problem for which it was written, namely [JDK-7090424](https://bugs.openjdk.org/browse/JDK-7090424).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750768459
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750821284
PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750839501

From serb at openjdk.org  Mon Sep  9 20:37:04 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Mon, 9 Sep 2024 20:37:04 GMT
Subject: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may
 fail after JDK-8327401
In-Reply-To: <gzCkOQ3mvf8uLuq_Ap-IDjWLuPxI1N2YyBQARngfeS4=.e431c177-c934-412a-a24d-52072500839f@github.com>
References: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
 <KbV8yWpFgwuRih_tbYJT1CqWccszOYFv0W9TDs1ElyE=.17b7574c-c4be-4005-b616-e67e19dab8f7@github.com>
 <gzCkOQ3mvf8uLuq_Ap-IDjWLuPxI1N2YyBQARngfeS4=.e431c177-c934-412a-a24d-52072500839f@github.com>
Message-ID: <cNep9OnxlvjSKzBV9prPSJd2A5uPcQeolYW06hajRnY=.856fe63c-8207-42bb-8cd9-a2ada5f03c64@github.com>

On Mon, 9 Sep 2024 19:32:04 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>At the same time, I find it weird that repaint paints directly in its code and then posts paint event.

This is one of the implementation details of the AWT, the "native" component should be painted before the paint event will proceed on EDT, and even if EDT is blocked the "native" part should be painted. Since the XAWT is implemented via Swing which is not thread-safe we should use some additional synchronization. On macOS we have a special lock for that https://github.com/openjdk/jdk/blob/559fc711e03cf0086bea399ffb40cf294cbbb6e1/src/java.desktop/macosx/classes/sun/lwawt/LWListPeer.java#L87 and https://github.com/openjdk/jdk/blob/559fc711e03cf0086bea399ffb40cf294cbbb6e1/src/java.desktop/macosx/classes/sun/lwawt/LWComponentPeer.java#L361 but on XAWT it is quite "cumbersome" since it was implemented a long time ago.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750898850

From serb at openjdk.org  Mon Sep  9 22:03:06 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Mon, 9 Sep 2024 22:03:06 GMT
Subject: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may
 fail after JDK-8327401
In-Reply-To: <cNep9OnxlvjSKzBV9prPSJd2A5uPcQeolYW06hajRnY=.856fe63c-8207-42bb-8cd9-a2ada5f03c64@github.com>
References: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
 <KbV8yWpFgwuRih_tbYJT1CqWccszOYFv0W9TDs1ElyE=.17b7574c-c4be-4005-b616-e67e19dab8f7@github.com>
 <gzCkOQ3mvf8uLuq_Ap-IDjWLuPxI1N2YyBQARngfeS4=.e431c177-c934-412a-a24d-52072500839f@github.com>
 <cNep9OnxlvjSKzBV9prPSJd2A5uPcQeolYW06hajRnY=.856fe63c-8207-42bb-8cd9-a2ada5f03c64@github.com>
Message-ID: <h9AuWQycAaH8b0LaqnipFJC2c3nb5A07TyY6Xya4Dbo=.15a65cbc-a207-4841-b826-765b086a2f27@github.com>

On Mon, 9 Sep 2024 20:34:30 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Not sure if it's a product bug?
>> 
>> AWT components do not explicitly state whether they're thread-safe or not. It's more or less assumed they should be. At the same time, I don't see code which ensures all the cases are thread-safe.
>> 
>> As far as I know, clientlibs group has been treating AWT components just like Swing ones: for safety create, access and destroy AWT components on EDT only.
>> 
>> I haven't looked at the test code thoroughly. It looks it still needs more investigation.
>> 
>> At the same time, I find it weird that `repaint` paints directly in its code and then posts paint event.
>> 
>> https://github.com/openjdk/jdk/blob/77468c284c068f921da543edd28333911e915b61/src/java.desktop/unix/classes/sun/awt/X11/XListPeer.java#L389-L390
>> 
>> Overall, it needs more investigation. It could be that the fix for [JDK-6471693](https://bugs.openjdk.org/browse/JDK-6471693) needs revising.
>
>>At the same time, I find it weird that repaint paints directly in its code and then posts paint event.
> 
> This is one of the implementation details of the AWT, the "native" component should be painted before the paint event will proceed on EDT, and even if EDT is blocked the "native" part should be painted. Since the XAWT is implemented via Swing(or some custom "java peers") which are not thread-safe we should use some additional synchronization. On macOS we have a special lock for that https://github.com/openjdk/jdk/blob/559fc711e03cf0086bea399ffb40cf294cbbb6e1/src/java.desktop/macosx/classes/sun/lwawt/LWListPeer.java#L87 and https://github.com/openjdk/jdk/blob/559fc711e03cf0086bea399ffb40cf294cbbb6e1/src/java.desktop/macosx/classes/sun/lwawt/LWComponentPeer.java#L361 but on XAWT it is quite "cumbersome" since it was implemented a long time ago.

And the NPE is triggered for List.select only because it is one method in the test that uses peer w/o synchronization.
https://github.com/openjdk/jdk/blob/77468c284c068f921da543edd28333911e915b61/src/java.desktop/share/classes/java/awt/List.java#L588

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1750991107

From djgredler at gmail.com  Mon Sep  9 23:56:52 2024
From: djgredler at gmail.com (Daniel Gredler)
Date: Tue, 10 Sep 2024 01:56:52 +0200
Subject: Graphics2D.drawString() fails with Font derived from rotated +
 scaled AffineTransform
In-Reply-To: <CAPA+ug5PSdU4_pMJ+vMRhs72-CErf-qKdwjjbiTwC2iXp3HWAg@mail.gmail.com>
References: <CAPA+ug5PSdU4_pMJ+vMRhs72-CErf-qKdwjjbiTwC2iXp3HWAg@mail.gmail.com>
Message-ID: <CAPA+ug6vzkS1VY==A-pQQCX4Mf6m7Jv6vm4LSCZMTixJwyhTHg@mail.gmail.com>

Hi all,

I've done a little more digging, and there is indeed a deeper bug in
TextLayout.getOutline(AffineTransform), where the transformation is applied
too early (before the layout path applies its mapping).

There are two uses of TextLayout.getOutline(AffineTransform): the first
one, triggered via a simple Graphics2D.drawString( ) was the one I ran
into; the second one requires the use of a transformed font with a
PSPrinterJob. Both are broken, so it doesn't really make sense to work
around the TextLayout issue for the first scenario, but leave the second
scenario broken.

The deeper fix, including two test classes verifying that both scenarios
were broken and now work correctly, is available on GitHub [1]. I plan to
submit a PR as soon as I have a final bug ID from my web bug submission.

Two points I'd like some feedback on:
1. I've changed the signature of method
TextLine.getOutline(AffineTransform), to just TextLine.getOutline( ); I'm
assuming this is OK since TextLine is a package-private class?
2. I've added a fast path in TextLayout.getOutline(AffineTransform) to
transform the shape in place if it is a GeneralPath (it should usually be,
and avoids an extra Shape copy vs. the current code); does this look OK? Or
should the code be kept completely generic and a copy always made? I had a
look at just changing the variable type from Shape to GeneralPath, but the
change started to cascade into a few other classes and I pulled the plug.

Take care,

Daniel

[1]
https://github.com/openjdk/jdk/compare/master...gredler:jdk:draw-string-bug-2



On Thu, Sep 5, 2024 at 8:30?PM Daniel Gredler <djgredler at gmail.com> wrote:

> Hi all,
>
> I've run into a bug [1] in the drawing of strings via
> Graphics2D.drawString(), when used with a Font derived from a rotated +
> scaled AffineTransform. If the AffineTransform scaling is small, the text
> draws correctly. But if the scale is too large, the text does not draw. [3]
>
> It looks like it's an effect of the OutlineTextRenderer.THRESHHOLD; text
> larger than this threshold is sent to the OutlineTextRenderer and fails to
> draw. The fix [2] seems to be to apply the position translation
> transformation *after* the text outline shape is created, rather than
> passing it into TextLayout.getOutline(). However, I do not know if this is
> the correct fix, or if it is just a workaround to a deeper issue in
> TextLayout.getOutline(), which in theory might need to wait to apply the
> provided translation until after the layout path has had a chance to map to
> user space.
>
> Can someone familiar with this code comment on whether the proposed fix is
> the correct fix, or whether deeper surgery is needed in
> TextLayout.getOutline()?
>
> My other small worry with the current fix [2] is that it creates an extra
> copy of the Shape object, so it's going to allocate a bit more memory than
> the current implementation. Not sure if there's a better way to update the
> Shape in-place.
>
> Take care,
>
> Daniel
>
> ---
>
> [1] Oracle internal review ID 9077538, no public bug ID yet
> [2]
> https://github.com/openjdk/jdk/compare/master...gredler:jdk:draw-string-bug
> [3]
> import java.awt.Color;
> import java.awt.Font;
> import java.awt.Graphics2D;
> import java.awt.geom.AffineTransform;
> import java.awt.image.BufferedImage;
> import java.io.File;
>
> import javax.imageio.ImageIO;
>
> /**
>  * <p>The "TEST 2" text does not draw. NOTE: Reducing the AffineTransform
> scale
>  * from 12 to 10 seems to allow it to draw?!?
>  *
>  * <p>Oracle internal review ID : 9077538
>  */
> public class DrawStringTest {
>
>     public static void main(String[] args) throws Exception {
>
>         AffineTransform at = AffineTransform.getRotateInstance(3 * Math.PI
> / 2);
>         at.scale(12, 12);
>
>         Font font1 = new Font("SansSerif", Font.PLAIN, 10);
>         Font font2 = font1.deriveFont(at);
>
>         BufferedImage image = new BufferedImage(500, 500,
> BufferedImage.TYPE_BYTE_GRAY);
>         Graphics2D g2d = image.createGraphics();
>         g2d.setColor(Color.WHITE);
>         g2d.fillRect(0, 0, image.getWidth(), image.getHeight());
>         g2d.setColor(Color.BLACK);
>         g2d.setFont(font1);
>         g2d.drawString("TEST 1", 200, 400); // draws text
>         g2d.setFont(font2);
>         g2d.drawString("TEST 2", 200, 400); // does not draw text
>         g2d.dispose();
>
>         ImageIO.write(image, "png", new File("test.png"));
>     }
>
> }
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20240910/5c97f74f/attachment-0001.htm>

From serb at openjdk.org  Tue Sep 10 06:11:19 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 10 Sep 2024 06:11:19 GMT
Subject: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may
 fail after JDK-8327401 [v2]
In-Reply-To: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
References: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
Message-ID: <s57F6W5U2Pz66Hdstwy8DY37CGTzJ9qA5UTCRVODcHg=.379262df-f8ac-44d0-baec-30e338fe779b@github.com>

> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been tweaked, see inline comments.
> 
> Notes:
>  * We have a few XXXRepaint.java tests and in this patch, I updated all of them to follow the change added to the ListRepaint.java
> 
> @azvegint @aivanov-jdk please take a look.

Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:

  PR review part 1

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20861/files
  - new: https://git.openjdk.org/jdk/pull/20861/files/4c883851..b2907dc7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20861&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20861&range=00-01

  Stats: 42 lines in 6 files changed: 25 ins; 10 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/20861.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20861/head:pull/20861

PR: https://git.openjdk.org/jdk/pull/20861

From serb at openjdk.org  Tue Sep 10 07:21:47 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 10 Sep 2024 07:21:47 GMT
Subject: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may
 fail after JDK-8327401 [v3]
In-Reply-To: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
References: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
Message-ID: <RBOR4UTSVmj3cbpfVf0ml3g204xitHWOMTNNCScti4E=.aedda16b-514a-42dc-82b2-ae3b4ef647f4@github.com>

> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been tweaked, see inline comments.
> 
> Notes:
>  * We have a few XXXRepaint.java tests and in this patch, I updated all of them to follow the change added to the ListRepaint.java
> 
> @azvegint @aivanov-jdk please take a look.

Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:

  Update bug4490179.java

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20861/files
  - new: https://git.openjdk.org/jdk/pull/20861/files/b2907dc7..2a56f4b7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20861&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20861&range=01-02

  Stats: 26 lines in 1 file changed: 8 ins; 4 del; 14 mod
  Patch: https://git.openjdk.org/jdk/pull/20861.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20861/head:pull/20861

PR: https://git.openjdk.org/jdk/pull/20861

From jpai at openjdk.org  Tue Sep 10 09:51:29 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 10 Sep 2024 09:51:29 GMT
Subject: RFR: 8339834: Replace usages of -mx and -ms in some tests
Message-ID: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>

Can I please get a review of this trivial change which replaces the usages of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?

As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are outdated and support for them will soon be deprecated and removed as part of https://bugs.openjdk.org/browse/JDK-8286851.

There are some more tests remaining in client-libs area which too require a similar change. I'll be creating a separate JBS issue and PR for that.

-------------

Commit messages:
 - 8339834: Replace usages of -mx and -ms in some tests

Changes: https://git.openjdk.org/jdk/pull/20930/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20930&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339834
  Stats: 15 lines in 8 files changed: 0 ins; 0 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/20930.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20930/head:pull/20930

PR: https://git.openjdk.org/jdk/pull/20930

From jpai at openjdk.org  Tue Sep 10 10:04:15 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 10 Sep 2024 10:04:15 GMT
Subject: RFR: 8339835: Replace usages of -mx and -ms in some client-libs tests
Message-ID: <JXOnf33k_jGgvptHlRAeHXDlJ7VSEtYm1frMlgu-ugk=.bc3c4a31-60b0-4652-9ba8-2bc6ee3a0cd8@github.com>

Can I please get a review of this test-only change which updates some client-libs tests to replace the usage of the outdated `-mx` and `-ms` java launcher options with `-Xmx`  and `-Xms`?

As noted in https://bugs.openjdk.org/browse/JDK-8339835, these outdated options will soon be deprecated for removal from the java launcher code.

tier testing in our CI is currently in progress with these changes.

-------------

Commit messages:
 - 8339835: Replace usages of -mx and -ms in some client-libs tests

Changes: https://git.openjdk.org/jdk/pull/20931/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20931&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339835
  Stats: 21 lines in 11 files changed: 0 ins; 0 del; 21 mod
  Patch: https://git.openjdk.org/jdk/pull/20931.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20931/head:pull/20931

PR: https://git.openjdk.org/jdk/pull/20931

From jpai at openjdk.org  Tue Sep 10 11:10:38 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 10 Sep 2024 11:10:38 GMT
Subject: RFR: 8339834: Replace usages of -mx and -ms in some tests [v2]
In-Reply-To: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
References: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
Message-ID: <1uJqLZoqXPFfm00tj-7WbnQIF7L5JcTQCGG2IfAHCHQ=.2f0b3899-965d-45e4-9e87-807fe66a791c@github.com>

> Can I please get a review of this trivial change which replaces the usages of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are outdated and support for them will soon be deprecated and removed as part of https://bugs.openjdk.org/browse/JDK-8286851.
> 
> There are some more tests remaining in client-libs area which too require a similar change. I'll be creating a separate JBS issue and PR for that.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  update JImageToolTest too

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20930/files
  - new: https://git.openjdk.org/jdk/pull/20930/files/51d15461..8214fdb5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20930&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20930&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20930.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20930/head:pull/20930

PR: https://git.openjdk.org/jdk/pull/20930

From dholmes at openjdk.org  Tue Sep 10 11:10:38 2024
From: dholmes at openjdk.org (David Holmes)
Date: Tue, 10 Sep 2024 11:10:38 GMT
Subject: RFR: 8339834: Replace usages of -mx and -ms in some tests [v2]
In-Reply-To: <1uJqLZoqXPFfm00tj-7WbnQIF7L5JcTQCGG2IfAHCHQ=.2f0b3899-965d-45e4-9e87-807fe66a791c@github.com>
References: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
 <1uJqLZoqXPFfm00tj-7WbnQIF7L5JcTQCGG2IfAHCHQ=.2f0b3899-965d-45e4-9e87-807fe66a791c@github.com>
Message-ID: <kft-wWmR2KaY2rgRRBAFQVrSQT1Dl6ggsLupQblUWjM=.1318f1d6-f971-4921-9d4c-6a7acb247663@github.com>

On Tue, 10 Sep 2024 11:07:30 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this trivial change which replaces the usages of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>> 
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are outdated and support for them will soon be deprecated and removed as part of https://bugs.openjdk.org/browse/JDK-8286851.
>> 
>> There are some more tests remaining in client-libs area which too require a similar change. I'll be creating a separate JBS issue and PR for that.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update JImageToolTest too

LGTM!

Thanks for cleaning this up.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20930#pullrequestreview-2292111663

From ngubarkov at openjdk.org  Tue Sep 10 13:31:09 2024
From: ngubarkov at openjdk.org (Nikita Gubarkov)
Date: Tue, 10 Sep 2024 13:31:09 GMT
Subject: RFR: 8339341: SurfaceManager cacheMap retains strong references
 [v2]
In-Reply-To: <rlI7k3z6gwXOG80917AEj16Jn3HY3NzoerSoXDGky3M=.1bd0696d-ffae-4e64-9b24-7d2daf141976@github.com>
References: <1ecWvJLiG54e0saEz_Jjz46gzxXnqsNDagdPQ3y_BN4=.27116e44-886b-405f-9d87-ec5e82e2fd20@github.com>
 <VZi8p9nS4x7oE4ES1NhMBsbUiLVVQ_WmWJoFVwqFqdQ=.0dc37621-d54c-40cf-a5ad-fc4abe29a4b5@github.com>
 <rlI7k3z6gwXOG80917AEj16Jn3HY3NzoerSoXDGky3M=.1bd0696d-ffae-4e64-9b24-7d2daf141976@github.com>
Message-ID: <aWJv8-rU2ClMvZ5GqOmRao4HnEizZpQPwV8eoIdFvg0=.9641fc4c-5ef9-4569-bd7f-8ecc4030e2b0@github.com>

On Fri, 6 Sep 2024 16:13:31 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Nikita Gubarkov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   8339341: Make SurfaceDataProxy cache a separate entity.
>>   
>>   Now caching level is determined by placement of the SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" proxies and therefore strong refs via them do not prevent the cache (and hence GraphicsConfig) from being detected as weakly reachable.
>
> If possible please add the "steps to reproduce" to the JBS issue.

@mrserb added steps and attached a test file.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20825#issuecomment-2340788910

From jeisl at openjdk.org  Tue Sep 10 13:54:23 2024
From: jeisl at openjdk.org (Josef Eisl)
Date: Tue, 10 Sep 2024 13:54:23 GMT
Subject: RFR: 8338768: Introduce runtime lookup to check for static builds
 [v2]
In-Reply-To: <56GIZnufresPSrWCWHPkbY9-qCGlm20L-nbXUi5DFv8=.445586cf-37dc-45ce-9b91-9d0a6c85e5ca@github.com>
References: <Qb-hEpMNtfzU9tOBdegv0PcIbXgmtKAQXVCOdhKZN7E=.73756496-0d50-4661-89d1-d4e9cf8a12d4@github.com>
 <56GIZnufresPSrWCWHPkbY9-qCGlm20L-nbXUi5DFv8=.445586cf-37dc-45ce-9b91-9d0a6c85e5ca@github.com>
Message-ID: <1xFVXOUr023IxIHucx0v8dket_QOWsIV0G3wVHnF5aE=.23e8334b-a4ed-4d94-8ad9-376ffe043882@github.com>

On Wed, 21 Aug 2024 22:14:40 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As a preparation for Hermetic Java, we need to have a way to look up during runtime if we are using a statically linked library or not.
>> 
>> This change will be the first step needed towards compiling the object files only once, and then link them into either dynamic or static libraries. (The only exception will be the linktype.c[pp] files, which needs to be compiled twice, once for the dynamic libraries and once for the static libraries.) Getting there will require further work though. 
>> 
>> This is part of the changes that make up the draft PR https://github.com/openjdk/jdk/pull/19478, which I have broken out.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Also update build to link properly

src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c line 135:

> 133: #endif
> 134: 
> 135:     if (!JVM_IsStaticallyLinked()) {

These "cross-library" link-type probes are a challenge for GraalVM native image. In native image, we statically link most standard JNI libraries into the final executable. However in some cases, for example AWT, static linking is not feasible due to their dependencies. Thus, we resort to dynamic linking. Have a mix of static and dynamic linking means that `JVM_IsStaticallyLinked` should give different answers based on the caller. Example:
lets assume a follow-up change introduces a call to `JVM_IsStaticallyLinked` in libnet (which native image statically links):
* if `JVM_IsStaticallyLinked` is called from libawt.so, we want to answer `false`
* if `JVM_IsStaticallyLinked` is called from libnet.a, we want to answer `true`

Is the mixed linking use case is something that the Hermetic Java effort is having on its radar?

For this particular case, one solutions could be to avoid cross-library calls. I.e., instead of calling `JVM_IsStaticallyLinked`, have an `AWT_IsStaticallyLinked` that is local to the libawt. This is similar to the pattern also used for JLI.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20666#discussion_r1752023584

From aivanov at openjdk.org  Tue Sep 10 14:59:09 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 10 Sep 2024 14:59:09 GMT
Subject: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may
 fail after JDK-8327401 [v3]
In-Reply-To: <RBOR4UTSVmj3cbpfVf0ml3g204xitHWOMTNNCScti4E=.aedda16b-514a-42dc-82b2-ae3b4ef647f4@github.com>
References: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
 <RBOR4UTSVmj3cbpfVf0ml3g204xitHWOMTNNCScti4E=.aedda16b-514a-42dc-82b2-ae3b4ef647f4@github.com>
Message-ID: <bpAd4gYneDdA9PbLpD-N66UTApdPhpN9Ts05lrjJjW8=.84061566-819f-436d-9f7c-a5fe49c9449f@github.com>

On Tue, 10 Sep 2024 07:21:47 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been tweaked, see inline comments.
>> 
>> Notes:
>>  * We have a few XXXRepaint.java tests and in this patch, I updated all of them to follow the change added to the ListRepaint.java
>> 
>> @azvegint @aivanov-jdk please take a look.
>
> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update bug4490179.java

test/jdk/javax/swing/JButton/bug4490179.java line 86:

> 84:             robot.mousePress(InputEvent.BUTTON3_DOWN_MASK);
> 85:             robot.mouseRelease(InputEvent.BUTTON3_DOWN_MASK);
> 86:             if (anyButton.await(3, TimeUnit.SECONDS)) {

Should 2 seconds be enough?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1752149990

From azvegint at openjdk.org  Tue Sep 10 17:24:17 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 10 Sep 2024 17:24:17 GMT
Subject: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may
 fail after JDK-8327401 [v3]
In-Reply-To: <RBOR4UTSVmj3cbpfVf0ml3g204xitHWOMTNNCScti4E=.aedda16b-514a-42dc-82b2-ae3b4ef647f4@github.com>
References: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
 <RBOR4UTSVmj3cbpfVf0ml3g204xitHWOMTNNCScti4E=.aedda16b-514a-42dc-82b2-ae3b4ef647f4@github.com>
Message-ID: <CAIXTPs3ASLqeC00TDltkHTqHHp9IHCxQTfLDMJfs3g=.75518fb7-ba74-4362-94f3-5e521b6f521b@github.com>

On Tue, 10 Sep 2024 07:21:47 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been tweaked, see inline comments.
>> 
>> Notes:
>>  * We have a few XXXRepaint.java tests and in this patch, I updated all of them to follow the change added to the ListRepaint.java
>> 
>> @azvegint @aivanov-jdk please take a look.
>
> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update bug4490179.java

test/jdk/javax/swing/JButton/bug4490179.java line 86:

> 84:             robot.mousePress(InputEvent.BUTTON3_DOWN_MASK);
> 85:             robot.mouseRelease(InputEvent.BUTTON3_DOWN_MASK);
> 86:             if (anyButton.await(3, TimeUnit.SECONDS)) {

`await` is also throws the `InterruptedException`, so theoretically we can leave the mouse button pressed in this case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1752313753

From azvegint at openjdk.org  Tue Sep 10 17:32:07 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 10 Sep 2024 17:32:07 GMT
Subject: RFR: 8339835: Replace usages of -mx and -ms in some client-libs
 tests
In-Reply-To: <JXOnf33k_jGgvptHlRAeHXDlJ7VSEtYm1frMlgu-ugk=.bc3c4a31-60b0-4652-9ba8-2bc6ee3a0cd8@github.com>
References: <JXOnf33k_jGgvptHlRAeHXDlJ7VSEtYm1frMlgu-ugk=.bc3c4a31-60b0-4652-9ba8-2bc6ee3a0cd8@github.com>
Message-ID: <fr6zHmCsxoHKhagBbLPaL00lZiPKGOO_K5ZmVNhT30I=.f2c82444-353d-4991-9231-23c01cf32bfa@github.com>

On Tue, 10 Sep 2024 09:59:56 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which updates some client-libs tests to replace the usage of the outdated `-mx` and `-ms` java launcher options with `-Xmx`  and `-Xms`?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-8339835, these outdated options will soon be deprecated for removal from the java launcher code.
> 
> tier testing in our CI is currently in progress with these changes.

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20931#pullrequestreview-2293218724

From azvegint at openjdk.org  Tue Sep 10 20:57:25 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 10 Sep 2024 20:57:25 GMT
Subject: RFR: 8339794: Open source closed choice tests #1
Message-ID: <0EkumWajHuf3zkfG_ugg9ZkFl0NCwFjCmk-0iDea_7A=.058aa280-7e36-43cb-b66e-d5486caba5cb@github.com>

Few more tests open sourcing.

Testing is green.

-------------

Commit messages:
 - 8339794: Open source closed choice tests #1

Changes: https://git.openjdk.org/jdk/pull/20941/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20941&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339794
  Stats: 383 lines in 3 files changed: 383 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20941.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20941/head:pull/20941

PR: https://git.openjdk.org/jdk/pull/20941

From dholmes at openjdk.org  Tue Sep 10 21:34:04 2024
From: dholmes at openjdk.org (David Holmes)
Date: Tue, 10 Sep 2024 21:34:04 GMT
Subject: RFR: 8339834: Replace usages of -mx and -ms in some tests [v2]
In-Reply-To: <1uJqLZoqXPFfm00tj-7WbnQIF7L5JcTQCGG2IfAHCHQ=.2f0b3899-965d-45e4-9e87-807fe66a791c@github.com>
References: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
 <1uJqLZoqXPFfm00tj-7WbnQIF7L5JcTQCGG2IfAHCHQ=.2f0b3899-965d-45e4-9e87-807fe66a791c@github.com>
Message-ID: <w_PBxIPDDrg4AUHHwHl79ygG4Fz80aywxLvYBxaNx9U=.5dd55890-3546-40c7-9da0-91b3dc27c6c1@github.com>

On Tue, 10 Sep 2024 11:10:38 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this trivial change which replaces the usages of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>> 
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are outdated and support for them will soon be deprecated and removed as part of https://bugs.openjdk.org/browse/JDK-8286851.
>> 
>> There are some more tests remaining in client-libs area which too require a similar change. I'll be creating a separate JBS issue and PR for that.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update JImageToolTest too

Marked as reviewed by dholmes (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20930#pullrequestreview-2293814493

From ihse at openjdk.org  Tue Sep 10 21:50:14 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 10 Sep 2024 21:50:14 GMT
Subject: RFR: 8338768: Introduce runtime lookup to check for static builds
 [v2]
In-Reply-To: <1xFVXOUr023IxIHucx0v8dket_QOWsIV0G3wVHnF5aE=.23e8334b-a4ed-4d94-8ad9-376ffe043882@github.com>
References: <Qb-hEpMNtfzU9tOBdegv0PcIbXgmtKAQXVCOdhKZN7E=.73756496-0d50-4661-89d1-d4e9cf8a12d4@github.com>
 <56GIZnufresPSrWCWHPkbY9-qCGlm20L-nbXUi5DFv8=.445586cf-37dc-45ce-9b91-9d0a6c85e5ca@github.com>
 <1xFVXOUr023IxIHucx0v8dket_QOWsIV0G3wVHnF5aE=.23e8334b-a4ed-4d94-8ad9-376ffe043882@github.com>
Message-ID: <DckGzEtnesPu5oN7E7KzLczbKhpQqaJGX0vQvtTSwHg=.0c3031b8-4738-4321-9295-5ac17f30de23@github.com>

On Tue, 10 Sep 2024 13:51:55 GMT, Josef Eisl <jeisl at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Also update build to link properly
>
> src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c line 135:
> 
>> 133: #endif
>> 134: 
>> 135:     if (!JVM_IsStaticallyLinked()) {
> 
> These "cross-library" link-type probes are a challenge for GraalVM native image. In native image, we statically link most standard JNI libraries into the final executable. However in some cases, for example AWT, static linking is not feasible due to their dependencies. Thus, we resort to dynamic linking. Have a mix of static and dynamic linking means that `JVM_IsStaticallyLinked` should give different answers based on the caller. Example:
> lets assume a follow-up change introduces a call to `JVM_IsStaticallyLinked` in libnet (which native image statically links):
> * if `JVM_IsStaticallyLinked` is called from libawt.so, we want to answer `false`
> * if `JVM_IsStaticallyLinked` is called from libnet.a, we want to answer `true`
> 
> Is the mixed linking use case is something that the Hermetic Java effort is having on its radar?
> 
> For this particular case, one solutions could be to avoid cross-library calls. I.e., instead of calling `JVM_IsStaticallyLinked`, have an `AWT_IsStaticallyLinked` that is local to the libawt. This is similar to the pattern also used for JLI.

Mixing static and dynamic libraries willy-nilly sounds like a situation that is hard to resolve in a safe and sound way. The basic assumption here has been that you either have all libraries dynamic, or all libraries static.

In the particular case you mention about libawt, I think the proper solution is to sort out the mess that is libawt_headless/libawt_xawt. It seems to me that the X support should be loaded using dlopen, not by hard dependencies to the X libraries. I think that should solve your problem (as well as many other problems).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20666#discussion_r1752767100

From jeisl at openjdk.org  Wed Sep 11 07:05:17 2024
From: jeisl at openjdk.org (Josef Eisl)
Date: Wed, 11 Sep 2024 07:05:17 GMT
Subject: RFR: 8338768: Introduce runtime lookup to check for static builds
 [v2]
In-Reply-To: <DckGzEtnesPu5oN7E7KzLczbKhpQqaJGX0vQvtTSwHg=.0c3031b8-4738-4321-9295-5ac17f30de23@github.com>
References: <Qb-hEpMNtfzU9tOBdegv0PcIbXgmtKAQXVCOdhKZN7E=.73756496-0d50-4661-89d1-d4e9cf8a12d4@github.com>
 <56GIZnufresPSrWCWHPkbY9-qCGlm20L-nbXUi5DFv8=.445586cf-37dc-45ce-9b91-9d0a6c85e5ca@github.com>
 <1xFVXOUr023IxIHucx0v8dket_QOWsIV0G3wVHnF5aE=.23e8334b-a4ed-4d94-8ad9-376ffe043882@github.com>
 <DckGzEtnesPu5oN7E7KzLczbKhpQqaJGX0vQvtTSwHg=.0c3031b8-4738-4321-9295-5ac17f30de23@github.com>
Message-ID: <lESRWyy2WhxHRFRx1AOiV3qKNxNHZ3ojcguX1oYUGg0=.275c101c-c9a3-4196-ae56-36467bc1c85c@github.com>

On Tue, 10 Sep 2024 21:47:15 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> sort out the mess that is libawt_headless/libawt_xawt

sounds good. can you point me to a JBS?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20666#discussion_r1753307449

From aivanov at openjdk.org  Wed Sep 11 08:05:09 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 11 Sep 2024 08:05:09 GMT
Subject: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may
 fail after JDK-8327401 [v3]
In-Reply-To: <CAIXTPs3ASLqeC00TDltkHTqHHp9IHCxQTfLDMJfs3g=.75518fb7-ba74-4362-94f3-5e521b6f521b@github.com>
References: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
 <RBOR4UTSVmj3cbpfVf0ml3g204xitHWOMTNNCScti4E=.aedda16b-514a-42dc-82b2-ae3b4ef647f4@github.com>
 <CAIXTPs3ASLqeC00TDltkHTqHHp9IHCxQTfLDMJfs3g=.75518fb7-ba74-4362-94f3-5e521b6f521b@github.com>
Message-ID: <6FmslRvaxsBHGJF3NelyxAJWE73wS1QMS5DCttRWyEo=.c1b5a545-d354-46b3-9e8b-ff5b0b98f33d@github.com>

On Tue, 10 Sep 2024 16:47:34 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update bug4490179.java
>
> test/jdk/javax/swing/JButton/bug4490179.java line 86:
> 
>> 84:             robot.mousePress(InputEvent.BUTTON3_DOWN_MASK);
>> 85:             robot.mouseRelease(InputEvent.BUTTON3_DOWN_MASK);
>> 86:             if (anyButton.await(3, TimeUnit.SECONDS)) {
> 
> `await` is also throws the `InterruptedException`, so theoretically we can leave the mouse button pressed in this case.

`await` throws `InterruptedException` when the thread is interrupted; the main thread is never interrupted in the test, therefore `InterruptedException` is never thrown.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1753503239

From aivanov at openjdk.org  Wed Sep 11 09:10:12 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 11 Sep 2024 09:10:12 GMT
Subject: RFR: 8339834: Replace usages of -mx and -ms in some tests [v2]
In-Reply-To: <1uJqLZoqXPFfm00tj-7WbnQIF7L5JcTQCGG2IfAHCHQ=.2f0b3899-965d-45e4-9e87-807fe66a791c@github.com>
References: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
 <1uJqLZoqXPFfm00tj-7WbnQIF7L5JcTQCGG2IfAHCHQ=.2f0b3899-965d-45e4-9e87-807fe66a791c@github.com>
Message-ID: <D8eCKs-aPhKABEBkipCVp3R9_1-rYJvQDTAt4nUov2U=.33e32331-3e44-4aed-8b27-d5c78d160d2d@github.com>

On Tue, 10 Sep 2024 11:10:38 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this trivial change which replaces the usages of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>> 
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are outdated and support for them will soon be deprecated and removed as part of https://bugs.openjdk.org/browse/JDK-8286851.
>> 
>> There are some more tests remaining in client-libs area which too require a similar change. I'll be creating a separate JBS issue and PR for that.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update JImageToolTest too

Looks good to me.

It could be good to remove `@author` tags from all the modified tests.

test/jdk/java/beans/Introspector/Test5102804.java line 28:

> 26:  * @bug 5102804
> 27:  * @summary Tests memory leak
> 28:  * @author Sergey Malenkov

Could you also remove the `@author` tag?

test/jdk/java/beans/Introspector/Test8027905.java line 30:

> 28:  * @bug 8027905
> 29:  * @summary Tests that GC does not affect a property type
> 30:  * @author Sergey Malenkov

Could you also remove the `@author` tag?

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20930#pullrequestreview-2296140348
PR Review Comment: https://git.openjdk.org/jdk/pull/20930#discussion_r1753703304
PR Review Comment: https://git.openjdk.org/jdk/pull/20930#discussion_r1753707545

From jpai at openjdk.org  Wed Sep 11 09:19:21 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 11 Sep 2024 09:19:21 GMT
Subject: RFR: 8339834: Replace usages of -mx and -ms in some tests [v3]
In-Reply-To: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
References: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
Message-ID: <ykywER5aLgblbA3dRjpha4gD0mCe2PvDFeA6RLCjjRE=.394ea566-5680-4c3e-b3b4-386a50caf3c4@github.com>

> Can I please get a review of this trivial change which replaces the usages of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are outdated and support for them will soon be deprecated and removed as part of https://bugs.openjdk.org/browse/JDK-8286851.
> 
> There are some more tests remaining in client-libs area which too require a similar change. I'll be creating a separate JBS issue and PR for that.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  Alexey's suggestion - remove @author tags

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20930/files
  - new: https://git.openjdk.org/jdk/pull/20930/files/8214fdb5..1596c34c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20930&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20930&range=01-02

  Stats: 5 lines in 4 files changed: 0 ins; 5 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20930.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20930/head:pull/20930

PR: https://git.openjdk.org/jdk/pull/20930

From jpai at openjdk.org  Wed Sep 11 09:19:21 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 11 Sep 2024 09:19:21 GMT
Subject: RFR: 8339834: Replace usages of -mx and -ms in some tests [v2]
In-Reply-To: <D8eCKs-aPhKABEBkipCVp3R9_1-rYJvQDTAt4nUov2U=.33e32331-3e44-4aed-8b27-d5c78d160d2d@github.com>
References: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
 <1uJqLZoqXPFfm00tj-7WbnQIF7L5JcTQCGG2IfAHCHQ=.2f0b3899-965d-45e4-9e87-807fe66a791c@github.com>
 <D8eCKs-aPhKABEBkipCVp3R9_1-rYJvQDTAt4nUov2U=.33e32331-3e44-4aed-8b27-d5c78d160d2d@github.com>
Message-ID: <9qOt-WPO0yYRk9G1dd8W2B3i_dIpNdNpoXl7PNb1Jrk=.e1b334d5-3bfa-4549-8dbc-78abf93f17ab@github.com>

On Wed, 11 Sep 2024 09:03:58 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update JImageToolTest too
>
> test/jdk/java/beans/Introspector/Test5102804.java line 28:
> 
>> 26:  * @bug 5102804
>> 27:  * @summary Tests memory leak
>> 28:  * @author Sergey Malenkov
> 
> Could you also remove the `@author` tag?

Done - I've now updated the PR to remove these author tags. Tests continue to pass.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20930#discussion_r1753742813

From aivanov at openjdk.org  Wed Sep 11 09:31:07 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 11 Sep 2024 09:31:07 GMT
Subject: RFR: 8339834: Replace usages of -mx and -ms in some tests [v3]
In-Reply-To: <ykywER5aLgblbA3dRjpha4gD0mCe2PvDFeA6RLCjjRE=.394ea566-5680-4c3e-b3b4-386a50caf3c4@github.com>
References: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
 <ykywER5aLgblbA3dRjpha4gD0mCe2PvDFeA6RLCjjRE=.394ea566-5680-4c3e-b3b4-386a50caf3c4@github.com>
Message-ID: <eXLvVTzpi-3Qvs9p38KECFBAYzggTKe0UoDzhp-ASSA=.3ea127f1-f2b9-443d-a893-91e1b3d48fdd@github.com>

On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this trivial change which replaces the usages of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>> 
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are outdated and support for them will soon be deprecated and removed as part of https://bugs.openjdk.org/browse/JDK-8286851.
>> 
>> There are some more tests remaining in client-libs area which too require a similar change. I'll be creating a separate JBS issue and PR for that.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Alexey's suggestion - remove @author tags

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20930#pullrequestreview-2296196596

From jdv at openjdk.org  Wed Sep 11 09:32:08 2024
From: jdv at openjdk.org (Jayathirth D V)
Date: Wed, 11 Sep 2024 09:32:08 GMT
Subject: RFR: 8339794: Open source closed choice tests #1
In-Reply-To: <0EkumWajHuf3zkfG_ugg9ZkFl0NCwFjCmk-0iDea_7A=.058aa280-7e36-43cb-b66e-d5486caba5cb@github.com>
References: <0EkumWajHuf3zkfG_ugg9ZkFl0NCwFjCmk-0iDea_7A=.058aa280-7e36-43cb-b66e-d5486caba5cb@github.com>
Message-ID: <A6sSUdHFWDi_vWmqRUntpcnK4sYnr1p75CAgTjLLuI8=.a3f773a9-bb71-44e7-8288-082c4e7fc48f@github.com>

On Tue, 10 Sep 2024 20:51:29 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Few more tests open sourcing.
> 
> Testing is green.

@azvegint  I see that one of the test jdk/java/awt/Choice/WheelEventsConsumed/WheelEventsConsumed.java is deproblemlisted.
Is this test sufficiently tested in our CI to make sure we don't have some intermittent failure?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20941#issuecomment-2343128953

From mvs at openjdk.org  Wed Sep 11 14:43:37 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Wed, 11 Sep 2024 14:43:37 GMT
Subject: RFR: 8339943: Frame not disposed in
 java/awt/dnd/DropActionChangeTest.java
Message-ID: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>

Stabilized the test by disposing the frame at the end, adding an auto delay,  called panel.getLocationOnScreen() in invokeAndWait(), formatting changes, etc
And for better debugging, added captureScreen() for failure cases.

Testing:
Tested using mach5 in all available platforms and attached the link in bug as a comment.

-------------

Commit messages:
 - 8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java

Changes: https://git.openjdk.org/jdk/pull/20951/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20951&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339943
  Stats: 60 lines in 1 file changed: 33 ins; 13 del; 14 mod
  Patch: https://git.openjdk.org/jdk/pull/20951.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20951/head:pull/20951

PR: https://git.openjdk.org/jdk/pull/20951

From ascarpino at openjdk.org  Wed Sep 11 16:11:09 2024
From: ascarpino at openjdk.org (Anthony Scarpino)
Date: Wed, 11 Sep 2024 16:11:09 GMT
Subject: RFR: 8339834: Replace usages of -mx and -ms in some tests [v3]
In-Reply-To: <ykywER5aLgblbA3dRjpha4gD0mCe2PvDFeA6RLCjjRE=.394ea566-5680-4c3e-b3b4-386a50caf3c4@github.com>
References: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
 <ykywER5aLgblbA3dRjpha4gD0mCe2PvDFeA6RLCjjRE=.394ea566-5680-4c3e-b3b4-386a50caf3c4@github.com>
Message-ID: <dc5D7ucI9MTKMW74YYMEW3OSd8gFQWJCpC_JHYnJER0=.c9c4f334-261b-4cdc-915c-59c6451f0bd9@github.com>

On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this trivial change which replaces the usages of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>> 
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are outdated and support for them will soon be deprecated and removed as part of https://bugs.openjdk.org/browse/JDK-8286851.
>> 
>> There are some more tests remaining in client-libs area which too require a similar change. I'll be creating a separate JBS issue and PR for that.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Alexey's suggestion - remove @author tags

The Cache.java change, and the others, look good to me.

-------------

Marked as reviewed by ascarpino (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20930#pullrequestreview-2297774755

From prr at openjdk.org  Wed Sep 11 16:32:08 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 11 Sep 2024 16:32:08 GMT
Subject: RFR: 8339835: Replace usages of -mx and -ms in some client-libs
 tests
In-Reply-To: <JXOnf33k_jGgvptHlRAeHXDlJ7VSEtYm1frMlgu-ugk=.bc3c4a31-60b0-4652-9ba8-2bc6ee3a0cd8@github.com>
References: <JXOnf33k_jGgvptHlRAeHXDlJ7VSEtYm1frMlgu-ugk=.bc3c4a31-60b0-4652-9ba8-2bc6ee3a0cd8@github.com>
Message-ID: <0HgN8QgDTrH9h-nHxjzDeEzf79pGNPitAtuD6N_gO6w=.3098c2d3-fe44-4b4e-92b9-85891160e51a@github.com>

On Tue, 10 Sep 2024 09:59:56 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which updates some client-libs tests to replace the usage of the outdated `-mx` and `-ms` java launcher options with `-Xmx`  and `-Xms`?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-8339835, these outdated options will soon be deprecated for removal from the java launcher code.
> 
> tier testing in our CI is currently in progress with these changes.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20931#pullrequestreview-2297856555

From prr at openjdk.org  Wed Sep 11 16:38:08 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 11 Sep 2024 16:38:08 GMT
Subject: RFR: 8339794: Open source closed choice tests #1
In-Reply-To: <0EkumWajHuf3zkfG_ugg9ZkFl0NCwFjCmk-0iDea_7A=.058aa280-7e36-43cb-b66e-d5486caba5cb@github.com>
References: <0EkumWajHuf3zkfG_ugg9ZkFl0NCwFjCmk-0iDea_7A=.058aa280-7e36-43cb-b66e-d5486caba5cb@github.com>
Message-ID: <Adf8pHah-G5bJV5RvmhQLTkdG2ZquBWzGbIFWhi-qss=.6243a294-ca97-496a-a6ed-c4150e1b9b36@github.com>

On Tue, 10 Sep 2024 20:51:29 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Few more tests open sourcing.
> 
> Testing is green.

We went back and forth on when it makes sense to have a subdirectory, didn't we ?
Not sure this one needs it, there's no history to preserve across moves / renames and the tests don't seem to do anything that steps on other tests.
So I'm approving, but think about that.

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20941#pullrequestreview-2297876105

From prr at openjdk.org  Wed Sep 11 16:39:05 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 11 Sep 2024 16:39:05 GMT
Subject: RFR: 8339834: Replace usages of -mx and -ms in some tests [v3]
In-Reply-To: <ykywER5aLgblbA3dRjpha4gD0mCe2PvDFeA6RLCjjRE=.394ea566-5680-4c3e-b3b4-386a50caf3c4@github.com>
References: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
 <ykywER5aLgblbA3dRjpha4gD0mCe2PvDFeA6RLCjjRE=.394ea566-5680-4c3e-b3b4-386a50caf3c4@github.com>
Message-ID: <ubESMuJjjv36Eyku3WfS0LHwxIQy4uzrbAH0g4ZK2Po=.b029f131-1f37-4106-8c9c-ae6c335cafb6@github.com>

On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this trivial change which replaces the usages of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>> 
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are outdated and support for them will soon be deprecated and removed as part of https://bugs.openjdk.org/browse/JDK-8286851.
>> 
>> There are some more tests remaining in client-libs area which too require a similar change. I'll be creating a separate JBS issue and PR for that.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Alexey's suggestion - remove @author tags

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20930#pullrequestreview-2297881944

From prr at openjdk.org  Wed Sep 11 16:40:09 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 11 Sep 2024 16:40:09 GMT
Subject: RFR: 8339731:
 java.desktop/share/classes/javax/swing/text/html/default.css typo in margin
 settings
In-Reply-To: <iftwYjtMZe-ThXj8bLQ609WXXCiuDzyAz7AGp6-jywU=.2ec4a132-d127-4641-987e-7febebe82ed2@github.com>
References: <iftwYjtMZe-ThXj8bLQ609WXXCiuDzyAz7AGp6-jywU=.2ec4a132-d127-4641-987e-7febebe82ed2@github.com>
Message-ID: <8fHjgKjIeG_Bi-6cnOVZeZIid1utuzyCm6uv0xBEbDw=.3139dbfc-a80b-45ff-8b27-c83ddcaf80c8@github.com>

On Mon, 9 Sep 2024 13:29:04 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> java.desktop/share/classes/javax/swing/text/html/default.css:105: margin-rigth: 0;
> 
> seems to be a typo (must be right).

I don't know how this is used, but it is clearly a typo.

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20915#pullrequestreview-2297885372

From prr at openjdk.org  Wed Sep 11 16:57:07 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 11 Sep 2024 16:57:07 GMT
Subject: RFR: 8339271: giflib attribution correction
In-Reply-To: <9bUf9UKVavgShir_2Z2Hfjelu4gLJUxoWCel8AntU_M=.2a57b6e4-dafa-45ec-97ba-a70da712b2f9@github.com>
References: <9bUf9UKVavgShir_2Z2Hfjelu4gLJUxoWCel8AntU_M=.2a57b6e4-dafa-45ec-97ba-a70da712b2f9@github.com>
Message-ID: <_UxY03WUcn1hCaaelZN1bmFfeV_q2xPBGnlah5YgSa4=.942271df-0a9f-448f-a2c2-48ffcba67e74@github.com>

On Wed, 4 Sep 2024 19:43:19 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Changing format of file paths in giflib copyright file and removing extra text from authors list

This should be OK. 
The onus should be on the giflib maintainers.
If they thought the list important it would be provided here.

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20859#pullrequestreview-2297946689

From azvegint at openjdk.org  Wed Sep 11 18:10:03 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 11 Sep 2024 18:10:03 GMT
Subject: RFR: 8339794: Open source closed choice tests #1
In-Reply-To: <A6sSUdHFWDi_vWmqRUntpcnK4sYnr1p75CAgTjLLuI8=.a3f773a9-bb71-44e7-8288-082c4e7fc48f@github.com>
References: <0EkumWajHuf3zkfG_ugg9ZkFl0NCwFjCmk-0iDea_7A=.058aa280-7e36-43cb-b66e-d5486caba5cb@github.com>
 <A6sSUdHFWDi_vWmqRUntpcnK4sYnr1p75CAgTjLLuI8=.a3f773a9-bb71-44e7-8288-082c4e7fc48f@github.com>
Message-ID: <pAiyfLkD3WpOSs9dZ-bYYPtt9NwbuFMWCKF-ebJjidE=.4c52e471-c93d-4b7c-ba77-9e8ddae531f2@github.com>

On Wed, 11 Sep 2024 09:29:56 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

> @azvegint I see that one of the test jdk/java/awt/Choice/WheelEventsConsumed/WheelEventsConsumed.java is deproblemlisted. Is this test sufficiently tested in our CI to make sure we don't have some intermittent failure?

It is not intermittent, it always fails on Windows and macos, they just behave differently and do not deliver MouseWheelEvent when outside of the Choice component.
The original fix was for 1.6(there was no support for macos from Sun at the time). I tried 6u45 on Windows and it still fails.

This test is not in the problem list because it is now only linux `@requires (os.family == "linux")`

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20941#issuecomment-2344350676

From azvegint at openjdk.org  Wed Sep 11 18:28:31 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 11 Sep 2024 18:28:31 GMT
Subject: RFR: 8339794: Open source closed choice tests #1 [v2]
In-Reply-To: <0EkumWajHuf3zkfG_ugg9ZkFl0NCwFjCmk-0iDea_7A=.058aa280-7e36-43cb-b66e-d5486caba5cb@github.com>
References: <0EkumWajHuf3zkfG_ugg9ZkFl0NCwFjCmk-0iDea_7A=.058aa280-7e36-43cb-b66e-d5486caba5cb@github.com>
Message-ID: <Z1M720njTUYgVZv-3uhlIhlIZtm2yMw0tLT0iXAPcOc=.7c9e0567-df61-47ff-8442-dfbaf5c3b051@github.com>

> Few more tests open sourcing.
> 
> Testing is green.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  move tests

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20941/files
  - new: https://git.openjdk.org/jdk/pull/20941/files/d1fa3910..6f03f35f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20941&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20941&range=00-01

  Stats: 1 line in 3 files changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/20941.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20941/head:pull/20941

PR: https://git.openjdk.org/jdk/pull/20941

From azvegint at openjdk.org  Wed Sep 11 18:28:31 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 11 Sep 2024 18:28:31 GMT
Subject: RFR: 8339794: Open source closed choice tests #1 [v2]
In-Reply-To: <Adf8pHah-G5bJV5RvmhQLTkdG2ZquBWzGbIFWhi-qss=.6243a294-ca97-496a-a6ed-c4150e1b9b36@github.com>
References: <0EkumWajHuf3zkfG_ugg9ZkFl0NCwFjCmk-0iDea_7A=.058aa280-7e36-43cb-b66e-d5486caba5cb@github.com>
 <Adf8pHah-G5bJV5RvmhQLTkdG2ZquBWzGbIFWhi-qss=.6243a294-ca97-496a-a6ed-c4150e1b9b36@github.com>
Message-ID: <iXNbBZdv-QNASgVmGN3cKCjBIXdewcc_usmPjaIZEdY=.4cab0916-ea31-4cb0-9872-28d98bd6d932@github.com>

On Wed, 11 Sep 2024 16:35:03 GMT, Phil Race <prr at openjdk.org> wrote:

> We went back and forth on when it makes sense to have a subdirectory, didn't we ? Not sure this one needs it, there's no history to preserve across moves / renames and the tests don't seem to do anything that steps on other tests. So I'm approving, but think about that.

Moved from separate dirs

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20941#issuecomment-2344384393

From aturbanov at openjdk.org  Wed Sep 11 19:56:30 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Wed, 11 Sep 2024 19:56:30 GMT
Subject: RFR: 8339972: Make a few fields in SortingFocusTraversalPolicy static
Message-ID: <HP1wTLCSf2CmDsPY7n5glKw0FLG11yV-WFAps78qFBs=.bf09f28c-4110-4279-b844-703ccd9bcb27@github.com>

2 fields in javax.swing.SortingFocusTraversalPolicy could be made 'static':
1. FORWARD_TRAVERSAL = 0
2. BACKWARD_TRAVERSAL = 1

-------------

Commit messages:
 - [PATCH] Make a few fields in SortingFocusTraversalPolicy static

Changes: https://git.openjdk.org/jdk/pull/20327/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20327&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339972
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/20327.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20327/head:pull/20327

PR: https://git.openjdk.org/jdk/pull/20327

From jpai at openjdk.org  Thu Sep 12 02:05:09 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Thu, 12 Sep 2024 02:05:09 GMT
Subject: RFR: 8339834: Replace usages of -mx and -ms in some tests [v3]
In-Reply-To: <ykywER5aLgblbA3dRjpha4gD0mCe2PvDFeA6RLCjjRE=.394ea566-5680-4c3e-b3b4-386a50caf3c4@github.com>
References: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
 <ykywER5aLgblbA3dRjpha4gD0mCe2PvDFeA6RLCjjRE=.394ea566-5680-4c3e-b3b4-386a50caf3c4@github.com>
Message-ID: <hqBwPMCdFXVg5ABQG9TuVcJvghRUvnvOZCdrng9iAEI=.31f53203-637b-4d1c-8a44-4235a0a5fbec@github.com>

On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this trivial change which replaces the usages of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>> 
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are outdated and support for them will soon be deprecated and removed as part of https://bugs.openjdk.org/browse/JDK-8286851.
>> 
>> There are some more tests remaining in client-libs area which too require a similar change. I'll be creating a separate JBS issue and PR for that.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Alexey's suggestion - remove @author tags

Thank you everyone for the reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20930#issuecomment-2345106667

From jpai at openjdk.org  Thu Sep 12 02:05:10 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Thu, 12 Sep 2024 02:05:10 GMT
Subject: Integrated: 8339834: Replace usages of -mx and -ms in some tests
In-Reply-To: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
References: <Oqm5R6EoqEtsYJcXlCLazu7gB9iAV0g0nJ1jIzViAvI=.dd5bc096-f4b0-4ed0-a29c-8f23324e8347@github.com>
Message-ID: <xtv6kN1gsVAwNkjA2DLMx4vIra8LI3pxnZfd9f5k1JE=.090b792a-2532-4bc7-ab40-85026b57d443@github.com>

On Tue, 10 Sep 2024 09:46:14 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this trivial change which replaces the usages of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are outdated and support for them will soon be deprecated and removed as part of https://bugs.openjdk.org/browse/JDK-8286851.
> 
> There are some more tests remaining in client-libs area which too require a similar change. I'll be creating a separate JBS issue and PR for that.

This pull request has now been integrated.

Changeset: 1d392492
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1d392492311daceeae12769cb9494eae63289853
Stats:     22 lines in 9 files changed: 0 ins; 5 del; 17 mod

8339834: Replace usages of -mx and -ms in some tests

Reviewed-by: aivanov, ascarpino, prr, dholmes

-------------

PR: https://git.openjdk.org/jdk/pull/20930

From jpai at openjdk.org  Thu Sep 12 02:06:06 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Thu, 12 Sep 2024 02:06:06 GMT
Subject: RFR: 8339835: Replace usages of -mx and -ms in some client-libs
 tests
In-Reply-To: <JXOnf33k_jGgvptHlRAeHXDlJ7VSEtYm1frMlgu-ugk=.bc3c4a31-60b0-4652-9ba8-2bc6ee3a0cd8@github.com>
References: <JXOnf33k_jGgvptHlRAeHXDlJ7VSEtYm1frMlgu-ugk=.bc3c4a31-60b0-4652-9ba8-2bc6ee3a0cd8@github.com>
Message-ID: <QEEClpLqexW0WHRbRvy7sEno6YfZbsHxBQ4L8dm4jyQ=.215a2bda-886e-4ab7-8896-a08d16b3e30b@github.com>

On Tue, 10 Sep 2024 09:59:56 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which updates some client-libs tests to replace the usage of the outdated `-mx` and `-ms` java launcher options with `-Xmx`  and `-Xms`?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-8339835, these outdated options will soon be deprecated for removal from the java launcher code.
> 
> tier testing in our CI is currently in progress with these changes.

Thank you Alexander and Phil for the reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20931#issuecomment-2345108900

From jpai at openjdk.org  Thu Sep 12 02:09:09 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Thu, 12 Sep 2024 02:09:09 GMT
Subject: Integrated: 8339835: Replace usages of -mx and -ms in some client-libs
 tests
In-Reply-To: <JXOnf33k_jGgvptHlRAeHXDlJ7VSEtYm1frMlgu-ugk=.bc3c4a31-60b0-4652-9ba8-2bc6ee3a0cd8@github.com>
References: <JXOnf33k_jGgvptHlRAeHXDlJ7VSEtYm1frMlgu-ugk=.bc3c4a31-60b0-4652-9ba8-2bc6ee3a0cd8@github.com>
Message-ID: <-T7mv1aKFN37BN3VU8ow_0PmfaospFE581OCYuHsQvI=.8d86f455-2141-48ce-b3de-84893a708a58@github.com>

On Tue, 10 Sep 2024 09:59:56 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which updates some client-libs tests to replace the usage of the outdated `-mx` and `-ms` java launcher options with `-Xmx`  and `-Xms`?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-8339835, these outdated options will soon be deprecated for removal from the java launcher code.
> 
> tier testing in our CI is currently in progress with these changes.

This pull request has now been integrated.

Changeset: 6d4bd6c6
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/6d4bd6c6b6c3e6ef4c0a1e4eebf888156e43da58
Stats:     21 lines in 11 files changed: 0 ins; 0 del; 21 mod

8339835: Replace usages of -mx and -ms in some client-libs tests

Reviewed-by: azvegint, prr

-------------

PR: https://git.openjdk.org/jdk/pull/20931

From azvegint at openjdk.org  Thu Sep 12 03:38:06 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 12 Sep 2024 03:38:06 GMT
Subject: RFR: 8339972: Make a few fields in SortingFocusTraversalPolicy
 static
In-Reply-To: <HP1wTLCSf2CmDsPY7n5glKw0FLG11yV-WFAps78qFBs=.bf09f28c-4110-4279-b844-703ccd9bcb27@github.com>
References: <HP1wTLCSf2CmDsPY7n5glKw0FLG11yV-WFAps78qFBs=.bf09f28c-4110-4279-b844-703ccd9bcb27@github.com>
Message-ID: <SJcsfjng54o0oIvEDgajdYGNwUTwmsI8AipjpaaG8SQ=.8d1e5ceb-c906-41e5-a9db-c7ff61cf804c@github.com>

On Thu, 25 Jul 2024 11:17:23 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> 2 fields in javax.swing.SortingFocusTraversalPolicy could be made 'static':
> 1. FORWARD_TRAVERSAL = 0
> 2. BACKWARD_TRAVERSAL = 1

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20327#pullrequestreview-2299149018

From azvegint at openjdk.org  Thu Sep 12 05:19:05 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 12 Sep 2024 05:19:05 GMT
Subject: RFR: 8339943: Frame not disposed in
 java/awt/dnd/DropActionChangeTest.java
In-Reply-To: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
References: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
Message-ID: <IY7cJVRN5-OyZNQVobjjrnqINhMUEw5VYKRJvRlw-Ro=.242fadc0-4f9c-475a-b244-90562a155df2@github.com>

On Wed, 11 Sep 2024 14:37:12 GMT, Manukumar V S <mvs at openjdk.org> wrote:

> Stabilized the test by disposing the frame at the end, adding an auto delay,  called panel.getLocationOnScreen() in invokeAndWait(), formatting changes, etc
> And for better debugging, added captureScreen() for failure cases.
> 
> Testing:
> Tested using mach5 in all available platforms and attached the link in bug as a comment.

My other comments are minor, because this changeset doesn't seem to help, if we increase the JTREG=REPEAT_COUNT from 10 to 100 it can still timeout on Windows.

test/jdk/java/awt/dnd/DropActionChangeTest.java line 75:

> 73: 
> 74:     public static void main(String[] args) throws Exception {
> 75:         test = new DropActionChangeTest();

JFrame(aka DropActionChangeTest) is initialized on the main thread instead of the EDT.

test/jdk/java/awt/dnd/DropActionChangeTest.java line 100:

> 98:         final DragSourceListener dsl = new DragSourceAdapter() {
> 99:             public void dragDropEnd(DragSourceDropEvent e) {
> 100:                 System.err.println("DragSourseListener.dragDropEnd(): " +

Suggestion:

                System.err.println("DragSourceListener.dragDropEnd(): " +

test/jdk/java/awt/dnd/DropActionChangeTest.java line 146:

> 144:         try {
> 145:             robot = new Robot();
> 146:             robot.setAutoDelay(100);

Suggestion:

            robot.setAutoDelay(100);
            robot.waitForIdle();
            robot.delay(500);


We usually wait a bit after calling `setVisible()`

test/jdk/java/awt/dnd/DropActionChangeTest.java line 176:

> 174:             if (!dropEnd) {
> 175:                 captureScreen();
> 176:                 System.err.println("DragSourseListener.dragDropEnd() was not called, returning");

Suggestion:

                System.err.println("DragSourceListener.dragDropEnd() was not called, returning");

-------------

PR Review: https://git.openjdk.org/jdk/pull/20951#pullrequestreview-2299103542
PR Review Comment: https://git.openjdk.org/jdk/pull/20951#discussion_r1756007957
PR Review Comment: https://git.openjdk.org/jdk/pull/20951#discussion_r1756022768
PR Review Comment: https://git.openjdk.org/jdk/pull/20951#discussion_r1756133226
PR Review Comment: https://git.openjdk.org/jdk/pull/20951#discussion_r1756025576

From psadhukhan at openjdk.org  Thu Sep 12 05:56:25 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 12 Sep 2024 05:56:25 GMT
Subject: RFR: 8339727: Open source several AWT focus tests - series 1
Message-ID: <upsQ9K0vfHMndfpzhpYZbAO9nVGGRjus9W9DjRwZUmM=.ea864b5e-acf7-456a-a499-286bcd058301@github.com>

Open source few AWT focus tests

-------------

Commit messages:
 - 8339727: Open source several AWT focus tests - series 1

Changes: https://git.openjdk.org/jdk/pull/20961/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20961&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339727
  Stats: 649 lines in 5 files changed: 649 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20961.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20961/head:pull/20961

PR: https://git.openjdk.org/jdk/pull/20961

From mbaesken at openjdk.org  Thu Sep 12 07:10:08 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Thu, 12 Sep 2024 07:10:08 GMT
Subject: RFR: 8339731:
 java.desktop/share/classes/javax/swing/text/html/default.css typo in margin
 settings
In-Reply-To: <iftwYjtMZe-ThXj8bLQ609WXXCiuDzyAz7AGp6-jywU=.2ec4a132-d127-4641-987e-7febebe82ed2@github.com>
References: <iftwYjtMZe-ThXj8bLQ609WXXCiuDzyAz7AGp6-jywU=.2ec4a132-d127-4641-987e-7febebe82ed2@github.com>
Message-ID: <Ncoq9wULBWU1UAWEVeJyAXKKvFbL_eOoGZa6H604jHc=.df028b5e-d760-4cd3-a70f-d0f607f42d10@github.com>

On Mon, 9 Sep 2024 13:29:04 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> java.desktop/share/classes/javax/swing/text/html/default.css:105: margin-rigth: 0;
> 
> seems to be a typo (must be right).

Thanks for the review !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20915#issuecomment-2345433603

From mbaesken at openjdk.org  Thu Sep 12 07:10:08 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Thu, 12 Sep 2024 07:10:08 GMT
Subject: Integrated: 8339731:
 java.desktop/share/classes/javax/swing/text/html/default.css typo in margin
 settings
In-Reply-To: <iftwYjtMZe-ThXj8bLQ609WXXCiuDzyAz7AGp6-jywU=.2ec4a132-d127-4641-987e-7febebe82ed2@github.com>
References: <iftwYjtMZe-ThXj8bLQ609WXXCiuDzyAz7AGp6-jywU=.2ec4a132-d127-4641-987e-7febebe82ed2@github.com>
Message-ID: <c8r-1uLwXAI1EDZ2Pq-lt3cAgHb45mRT92ynHCjDZhI=.7d6e3699-09e9-4a49-997e-bbd598e90169@github.com>

On Mon, 9 Sep 2024 13:29:04 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> java.desktop/share/classes/javax/swing/text/html/default.css:105: margin-rigth: 0;
> 
> seems to be a typo (must be right).

This pull request has now been integrated.

Changeset: ac3f92b4
Author:    Matthias Baesken <mbaesken at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ac3f92b4110b05906a49c4146774fd6324c6d198
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/20915

From mvs at openjdk.org  Thu Sep 12 09:22:39 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Thu, 12 Sep 2024 09:22:39 GMT
Subject: RFR: 8339943: Frame not disposed in
 java/awt/dnd/DropActionChangeTest.java [v2]
In-Reply-To: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
References: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
Message-ID: <KVjQ-9fAdlvPlGPiqHf8k8GCbbebrQt9QmTAyEbrolY=.c1a14492-abea-4f33-b9eb-643da44f0198@github.com>

> Stabilized the test by disposing the frame at the end, adding an auto delay,  called panel.getLocationOnScreen() in invokeAndWait(), formatting changes, etc
> And for better debugging, added captureScreen() for failure cases.
> 
> Testing:
> Tested using mach5 in all available platforms and attached the link in bug as a comment.

Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:

  Review comments fixed : Creating frame in EDT, adding robot.delay() and robot.waitForIdle(), formatting changes, etc

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20951/files
  - new: https://git.openjdk.org/jdk/pull/20951/files/4343f4db..6238ba9b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20951&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20951&range=00-01

  Stats: 19 lines in 1 file changed: 5 ins; 5 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/20951.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20951/head:pull/20951

PR: https://git.openjdk.org/jdk/pull/20951

From mvs at openjdk.org  Thu Sep 12 09:26:04 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Thu, 12 Sep 2024 09:26:04 GMT
Subject: RFR: 8339943: Frame not disposed in
 java/awt/dnd/DropActionChangeTest.java [v2]
In-Reply-To: <IY7cJVRN5-OyZNQVobjjrnqINhMUEw5VYKRJvRlw-Ro=.242fadc0-4f9c-475a-b244-90562a155df2@github.com>
References: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
 <IY7cJVRN5-OyZNQVobjjrnqINhMUEw5VYKRJvRlw-Ro=.242fadc0-4f9c-475a-b244-90562a155df2@github.com>
Message-ID: <PVXgCw0vFDCUj1O3CRbEeu9nxLjQ0yF3Uqb3IirOmWk=.41661a45-cc2a-4d3f-bbf9-574295420df3@github.com>

On Thu, 12 Sep 2024 05:16:52 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> My other comments are minor, because this changeset doesn't seem to help, if we increase the JTREG=REPEAT_COUNT from 10 to 100 it can still timeout on Windows.

With the new changes, I have run it 900 times(JTREG=REPEAT_COUNT=100 in 9 machines) in windows as well as 100 times each on other platforms and no failures observed(mach5 test links are attached in bug).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20951#issuecomment-2345736105

From psadhukhan at openjdk.org  Thu Sep 12 13:57:30 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 12 Sep 2024 13:57:30 GMT
Subject: RFR: 8339727: Open source several AWT focus tests - series 1 [v2]
In-Reply-To: <upsQ9K0vfHMndfpzhpYZbAO9nVGGRjus9W9DjRwZUmM=.ea864b5e-acf7-456a-a499-286bcd058301@github.com>
References: <upsQ9K0vfHMndfpzhpYZbAO9nVGGRjus9W9DjRwZUmM=.ea864b5e-acf7-456a-a499-286bcd058301@github.com>
Message-ID: <sfCUYOXyXMaBWd0dzhDtiRkN2PexbKO4_MY5YXKAbdE=.d2371abc-11a5-46bd-9c99-70e51a1ea674@github.com>

> Open source few AWT focus tests

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Spacing

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20961/files
  - new: https://git.openjdk.org/jdk/pull/20961/files/8c8b8e82..7f9c1eb1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20961&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20961&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20961.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20961/head:pull/20961

PR: https://git.openjdk.org/jdk/pull/20961

From jdv at openjdk.org  Thu Sep 12 14:03:06 2024
From: jdv at openjdk.org (Jayathirth D V)
Date: Thu, 12 Sep 2024 14:03:06 GMT
Subject: RFR: 8339794: Open source closed choice tests #1 [v2]
In-Reply-To: <Z1M720njTUYgVZv-3uhlIhlIZtm2yMw0tLT0iXAPcOc=.7c9e0567-df61-47ff-8442-dfbaf5c3b051@github.com>
References: <0EkumWajHuf3zkfG_ugg9ZkFl0NCwFjCmk-0iDea_7A=.058aa280-7e36-43cb-b66e-d5486caba5cb@github.com>
 <Z1M720njTUYgVZv-3uhlIhlIZtm2yMw0tLT0iXAPcOc=.7c9e0567-df61-47ff-8442-dfbaf5c3b051@github.com>
Message-ID: <y-8NcsRnPn4fmErNv6e_gQXRkykwif6yALkW1g9HUPw=.6cd07101-6d6a-49c4-b9f0-f9f7df5bc15b@github.com>

On Wed, 11 Sep 2024 18:28:31 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Few more tests open sourcing.
>> 
>> Testing is green.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move tests

Marked as reviewed by jdv (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20941#pullrequestreview-2300418930

From azvegint at openjdk.org  Thu Sep 12 16:41:09 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 12 Sep 2024 16:41:09 GMT
Subject: RFR: 8339943: Frame not disposed in
 java/awt/dnd/DropActionChangeTest.java [v2]
In-Reply-To: <KVjQ-9fAdlvPlGPiqHf8k8GCbbebrQt9QmTAyEbrolY=.c1a14492-abea-4f33-b9eb-643da44f0198@github.com>
References: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
 <KVjQ-9fAdlvPlGPiqHf8k8GCbbebrQt9QmTAyEbrolY=.c1a14492-abea-4f33-b9eb-643da44f0198@github.com>
Message-ID: <j1NN0K4rx_R25iQNAHxyNYGVqNvnb0qPitC8ljWDVuY=.0dfd27f1-74a0-4a29-ba8c-48f29560baab@github.com>

On Thu, 12 Sep 2024 09:22:39 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> Stabilized the test by disposing the frame at the end, adding an auto delay,  called panel.getLocationOnScreen() in invokeAndWait(), formatting changes, etc
>> And for better debugging, added captureScreen() for failure cases.
>> 
>> Testing:
>> Tested using mach5 in all available platforms and attached the link in bug as a comment.
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments fixed : Creating frame in EDT, adding robot.delay() and robot.waitForIdle(), formatting changes, etc

Thank you, looks good, except for minor formatting issues.

test/jdk/java/awt/dnd/DropActionChangeTest.java line 75:

> 73: 
> 74:     public static void main(String[] args) throws Exception {
> 75:         EventQueue.invokeAndWait(()->test = new DropActionChangeTest());

Suggestion:

        EventQueue.invokeAndWait(() -> test = new DropActionChangeTest());

test/jdk/java/awt/dnd/DropActionChangeTest.java line 105:

> 103:                     System.err.println("FAILURE: wrong drop action:"
> 104:                                        + e.getDropAction()+", It should be "
> 105:                                        +DnDConstants.ACTION_MOVE);

Suggestion:

                    System.err.println("FAILURE: wrong drop action:"
                                       + e.getDropAction() + ", It should be "
                                       + DnDConstants.ACTION_MOVE);

test/jdk/java/awt/dnd/DropActionChangeTest.java line 194:

> 192:         System.err.println("Test passed!");
> 193:     }
> 194:     private static void disposeFrame() {

Suggestion:

    }

    private static void disposeFrame() {

test/jdk/java/awt/dnd/DropActionChangeTest.java line 202:

> 200:         }
> 201:     }
> 202:     private static void captureScreen(String str) {

Suggestion:

    }

    private static void captureScreen(String str) {

test/jdk/java/awt/dnd/DropActionChangeTest.java line 254:

> 252: 
> 253:     public static void doDrag(Robot robot, Point startPoint, Point endPoint) {
> 254:         robot.waitForIdle();

Suggestion:

       robot.waitForIdle();

-------------

Marked as reviewed by azvegint (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20951#pullrequestreview-2300862928
PR Review Comment: https://git.openjdk.org/jdk/pull/20951#discussion_r1757216344
PR Review Comment: https://git.openjdk.org/jdk/pull/20951#discussion_r1757222062
PR Review Comment: https://git.openjdk.org/jdk/pull/20951#discussion_r1757216752
PR Review Comment: https://git.openjdk.org/jdk/pull/20951#discussion_r1757217118
PR Review Comment: https://git.openjdk.org/jdk/pull/20951#discussion_r1757218970

From mvs at openjdk.org  Thu Sep 12 17:00:18 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Thu, 12 Sep 2024 17:00:18 GMT
Subject: RFR: 8339943: Frame not disposed in
 java/awt/dnd/DropActionChangeTest.java [v3]
In-Reply-To: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
References: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
Message-ID: <7KdqjCBzai3gwunfQ_NKnXuAotj01EDih-ZAvSVIeF8=.068989e5-4c25-4de2-a723-cabb165a356e@github.com>

> Stabilized the test by disposing the frame at the end, adding an auto delay,  called panel.getLocationOnScreen() in invokeAndWait(), formatting changes, etc
> And for better debugging, added captureScreen() for failure cases.
> 
> Testing:
> Tested using mach5 in all available platforms and attached the link in bug as a comment.

Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:

  Review comments fixed : Minor formatting changes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20951/files
  - new: https://git.openjdk.org/jdk/pull/20951/files/6238ba9b..b4758cd7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20951&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20951&range=01-02

  Stats: 24 lines in 1 file changed: 10 ins; 7 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/20951.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20951/head:pull/20951

PR: https://git.openjdk.org/jdk/pull/20951

From prr at openjdk.org  Thu Sep 12 22:37:49 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 12 Sep 2024 22:37:49 GMT
Subject: RFR: 8339883: Open source several AWT/2D related tests
Message-ID: <_hbOe0ROqqQsG7hdhrGk28JVDNGP1yz2vKhVo3GDIxw=.c3bde19f-4f6e-45df-aee3-2832258ffaa9@github.com>

This open sources a few AWT/2D regression tests.

-------------

Commit messages:
 - 8339883

Changes: https://git.openjdk.org/jdk/pull/20977/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20977&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339883
  Stats: 317 lines in 3 files changed: 317 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20977.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20977/head:pull/20977

PR: https://git.openjdk.org/jdk/pull/20977

From prr at openjdk.org  Thu Sep 12 22:41:48 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 12 Sep 2024 22:41:48 GMT
Subject: RFR: 8339883: Open source several AWT/2D related tests [v2]
In-Reply-To: <_hbOe0ROqqQsG7hdhrGk28JVDNGP1yz2vKhVo3GDIxw=.c3bde19f-4f6e-45df-aee3-2832258ffaa9@github.com>
References: <_hbOe0ROqqQsG7hdhrGk28JVDNGP1yz2vKhVo3GDIxw=.c3bde19f-4f6e-45df-aee3-2832258ffaa9@github.com>
Message-ID: <WD11YJw9dcwKZATzImMi8DPrYW65THk8rdVfz6lY1Qo=.4ecb3c79-dc1c-47d9-88a8-8748ad608283@github.com>

> This open sources a few AWT/2D regression tests.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8339883

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20977/files
  - new: https://git.openjdk.org/jdk/pull/20977/files/10f1446b..b951746e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20977&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20977&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20977.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20977/head:pull/20977

PR: https://git.openjdk.org/jdk/pull/20977

From prr at openjdk.org  Thu Sep 12 22:46:51 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 12 Sep 2024 22:46:51 GMT
Subject: RFR: 8339883: Open source several AWT/2D related tests [v3]
In-Reply-To: <_hbOe0ROqqQsG7hdhrGk28JVDNGP1yz2vKhVo3GDIxw=.c3bde19f-4f6e-45df-aee3-2832258ffaa9@github.com>
References: <_hbOe0ROqqQsG7hdhrGk28JVDNGP1yz2vKhVo3GDIxw=.c3bde19f-4f6e-45df-aee3-2832258ffaa9@github.com>
Message-ID: <po9KkUEwQoES2ShwtHKRLfLHVf0tRa8GugKe7J6TDug=.2a319fb9-5db6-47dc-9f71-8d2f582092c0@github.com>

> This open sources a few AWT/2D regression tests.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8339883

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20977/files
  - new: https://git.openjdk.org/jdk/pull/20977/files/b951746e..f0877662

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20977&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20977&range=01-02

  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20977.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20977/head:pull/20977

PR: https://git.openjdk.org/jdk/pull/20977

From honkar at openjdk.org  Thu Sep 12 22:57:05 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 12 Sep 2024 22:57:05 GMT
Subject: RFR: 8339883: Open source several AWT/2D related tests [v3]
In-Reply-To: <po9KkUEwQoES2ShwtHKRLfLHVf0tRa8GugKe7J6TDug=.2a319fb9-5db6-47dc-9f71-8d2f582092c0@github.com>
References: <_hbOe0ROqqQsG7hdhrGk28JVDNGP1yz2vKhVo3GDIxw=.c3bde19f-4f6e-45df-aee3-2832258ffaa9@github.com>
 <po9KkUEwQoES2ShwtHKRLfLHVf0tRa8GugKe7J6TDug=.2a319fb9-5db6-47dc-9f71-8d2f582092c0@github.com>
Message-ID: <2k3Nlm3UPgwo-KTBFv0M6LDJP6cOUwTQcCCB8KxKo68=.20b64493-0765-4db0-b759-d611eca2bd05@github.com>

On Thu, 12 Sep 2024 22:46:51 GMT, Phil Race <prr at openjdk.org> wrote:

>> This open sources a few AWT/2D regression tests.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8339883

LGTM other than the unused import in Position.java

test/jdk/java/awt/GraphicsConfiguration/Position.java line 37:

> 35:  */
> 36: 
> 37: import java.awt.Graphics;

Unused import can be removed.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20977#pullrequestreview-2301551955
PR Review Comment: https://git.openjdk.org/jdk/pull/20977#discussion_r1757684753

From azvegint at openjdk.org  Thu Sep 12 23:08:11 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 12 Sep 2024 23:08:11 GMT
Subject: Integrated: 8339794: Open source closed choice tests #1
In-Reply-To: <0EkumWajHuf3zkfG_ugg9ZkFl0NCwFjCmk-0iDea_7A=.058aa280-7e36-43cb-b66e-d5486caba5cb@github.com>
References: <0EkumWajHuf3zkfG_ugg9ZkFl0NCwFjCmk-0iDea_7A=.058aa280-7e36-43cb-b66e-d5486caba5cb@github.com>
Message-ID: <m4bGBZG-k6sRsWmVazQbL51BcTO7P_OlqGCHEF6cn20=.cea10c55-8b77-4e3b-b18e-94d3b0d81e6b@github.com>

On Tue, 10 Sep 2024 20:51:29 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Few more tests open sourcing.
> 
> Testing is green.

This pull request has now been integrated.

Changeset: 5e5942a2
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5e5942a282e14846404b68c65d43594d6b9226d9
Stats:     383 lines in 3 files changed: 383 ins; 0 del; 0 mod

8339794: Open source closed choice tests #1

Reviewed-by: jdv, prr

-------------

PR: https://git.openjdk.org/jdk/pull/20941

From honkar at openjdk.org  Thu Sep 12 23:23:05 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 12 Sep 2024 23:23:05 GMT
Subject: RFR: 8339727: Open source several AWT focus tests - series 1 [v2]
In-Reply-To: <sfCUYOXyXMaBWd0dzhDtiRkN2PexbKO4_MY5YXKAbdE=.d2371abc-11a5-46bd-9c99-70e51a1ea674@github.com>
References: <upsQ9K0vfHMndfpzhpYZbAO9nVGGRjus9W9DjRwZUmM=.ea864b5e-acf7-456a-a499-286bcd058301@github.com>
 <sfCUYOXyXMaBWd0dzhDtiRkN2PexbKO4_MY5YXKAbdE=.d2371abc-11a5-46bd-9c99-70e51a1ea674@github.com>
Message-ID: <7Bc48w8yzp0j4mKVDtWg4GllG_37vPt1QWThdNiYDQU=.aa575698-4086-4546-ad24-c1fe3531145b@github.com>

On Thu, 12 Sep 2024 13:57:30 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Open source few AWT focus tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Spacing

LGTM

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20961#pullrequestreview-2301575624

From mvs at openjdk.org  Fri Sep 13 02:11:11 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Fri, 13 Sep 2024 02:11:11 GMT
Subject: RFR: 8339943: Frame not disposed in
 java/awt/dnd/DropActionChangeTest.java [v2]
In-Reply-To: <j1NN0K4rx_R25iQNAHxyNYGVqNvnb0qPitC8ljWDVuY=.0dfd27f1-74a0-4a29-ba8c-48f29560baab@github.com>
References: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
 <KVjQ-9fAdlvPlGPiqHf8k8GCbbebrQt9QmTAyEbrolY=.c1a14492-abea-4f33-b9eb-643da44f0198@github.com>
 <j1NN0K4rx_R25iQNAHxyNYGVqNvnb0qPitC8ljWDVuY=.0dfd27f1-74a0-4a29-ba8c-48f29560baab@github.com>
Message-ID: <pnCgT4niQJbWowe_BUUR-JarkGW6uAM3-OwBVVUXFHg=.18691ad4-811a-4334-8ee1-bf863c19ce76@github.com>

On Thu, 12 Sep 2024 16:38:03 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments fixed : Creating frame in EDT, adding robot.delay() and robot.waitForIdle(), formatting changes, etc
>
> Thank you, looks good, except for minor formatting issues.

@azvegint I have made the formatting corrections suggested by you, can you please re-review the PR as the new process requires a re-review if any changes made after the approval.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20951#issuecomment-2347902966

From psadhukhan at openjdk.org  Fri Sep 13 05:11:47 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 13 Sep 2024 05:11:47 GMT
Subject: RFR: 8339639: Opensource few AWT PopupMenu tests
Message-ID: <FvOMRbBanx09AoLf-HQ7F3ml_mXpIhk8mO1-D4N_4cw=.25c520bc-041d-486a-b80f-455819a2b568@github.com>

OPensource few AWT PopupMenu tests

-------------

Commit messages:
 - 8339639: Opensource few AWT PopupMenu tests

Changes: https://git.openjdk.org/jdk/pull/20982/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20982&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339639
  Stats: 360 lines in 3 files changed: 360 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20982.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20982/head:pull/20982

PR: https://git.openjdk.org/jdk/pull/20982

From duke at openjdk.org  Fri Sep 13 09:05:11 2024
From: duke at openjdk.org (Karm Michal Babacek)
Date: Fri, 13 Sep 2024 09:05:11 GMT
Subject: RFR: 8336382: Fixes error reporting in loading AWT and fonts [v3]
In-Reply-To: <GbmkgT6SggwJSszpDku1oVChLXFdDXjxj-1qlcbQ53A=.77d741a9-5975-4f23-951b-35abcdeeffe4@github.com>
References: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
 <GbmkgT6SggwJSszpDku1oVChLXFdDXjxj-1qlcbQ53A=.77d741a9-5975-4f23-951b-35abcdeeffe4@github.com>
Message-ID: <EDgyJfKO5A7SvPmjTbkRo-R-9yFFWIcI4sQhPSuGiyg=.a61ad063-d7b3-4696-8d10-d80a7ede3371@github.com>

On Mon, 15 Jul 2024 19:11:38 GMT, Phil Race <prr at openjdk.org> wrote:

>> Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Treats missing class as a fatal error
>
> There is nothing in this PR that I would accept. It should be withdrawn.

ping @prrace

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20169#issuecomment-2348421391

From psadhukhan at openjdk.org  Fri Sep 13 09:37:05 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 13 Sep 2024 09:37:05 GMT
Subject: RFR: 8339883: Open source several AWT/2D related tests [v3]
In-Reply-To: <po9KkUEwQoES2ShwtHKRLfLHVf0tRa8GugKe7J6TDug=.2a319fb9-5db6-47dc-9f71-8d2f582092c0@github.com>
References: <_hbOe0ROqqQsG7hdhrGk28JVDNGP1yz2vKhVo3GDIxw=.c3bde19f-4f6e-45df-aee3-2832258ffaa9@github.com>
 <po9KkUEwQoES2ShwtHKRLfLHVf0tRa8GugKe7J6TDug=.2a319fb9-5db6-47dc-9f71-8d2f582092c0@github.com>
Message-ID: <1KTjzs1pLa0N0UNMxjd_Z_pAJDJihf6dqzRME6QAd6Q=.cd9725e3-fd73-4bc5-9cec-6ceef46aa81d@github.com>

On Thu, 12 Sep 2024 22:46:51 GMT, Phil Race <prr at openjdk.org> wrote:

>> This open sources a few AWT/2D regression tests.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8339883

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/java/awt/GraphicsConfiguration/NonDefaultGC.java line 31:

> 29:  * of windows with RGB stripes in according to the number of the
> 30:  * GraphicsConfigurations for each screen. It also displays the size of
> 31:  * the screen and the GraphicsConfiguration.toString().

Better to align the sentences after @summary tag words so that @tags can be on one column and other sentences do not encroach, similar to test/jdk/sun/java2d/pipe/DrawImageBgTest.java in this PR

test/jdk/java/awt/GraphicsConfiguration/Position.java line 31:

> 29:  * The togglebutton shows and hides an empty frame on the second monitor. The
> 30:  * frame should be positioned at 0, 0 and is shown and hidden by clicking the
> 31:  * toggleButton.

same here

-------------

PR Review: https://git.openjdk.org/jdk/pull/20977#pullrequestreview-2302625489
PR Review Comment: https://git.openjdk.org/jdk/pull/20977#discussion_r1758527331
PR Review Comment: https://git.openjdk.org/jdk/pull/20977#discussion_r1758532670

From azvegint at openjdk.org  Fri Sep 13 10:01:05 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 13 Sep 2024 10:01:05 GMT
Subject: RFR: 8339943: Frame not disposed in
 java/awt/dnd/DropActionChangeTest.java [v2]
In-Reply-To: <j1NN0K4rx_R25iQNAHxyNYGVqNvnb0qPitC8ljWDVuY=.0dfd27f1-74a0-4a29-ba8c-48f29560baab@github.com>
References: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
 <KVjQ-9fAdlvPlGPiqHf8k8GCbbebrQt9QmTAyEbrolY=.c1a14492-abea-4f33-b9eb-643da44f0198@github.com>
 <j1NN0K4rx_R25iQNAHxyNYGVqNvnb0qPitC8ljWDVuY=.0dfd27f1-74a0-4a29-ba8c-48f29560baab@github.com>
Message-ID: <HqjR7XrnlEoEkQ7lEDzgjxDnEbgcvlvN640a8WI5zfQ=.85f31d87-4b73-4187-bf20-98777f2f4ee6@github.com>

On Thu, 12 Sep 2024 16:38:03 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments fixed : Creating frame in EDT, adding robot.delay() and robot.waitForIdle(), formatting changes, etc
>
> Thank you, looks good, except for minor formatting issues.

> @azvegint I have made the formatting corrections suggested by you, can you please re-review the PR as the new process requires a re-review if any changes made after the approval.

I saw it, and it's fine, I'll just give someone else more time to review it if they want to.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20951#issuecomment-2348545156

From duke at openjdk.org  Fri Sep 13 10:13:42 2024
From: duke at openjdk.org (Daniel Gredler)
Date: Fri, 13 Sep 2024 10:13:42 GMT
Subject: RFR: 8339974: Graphics2D.drawString doesn't always work with Font
 derived from AffineTransform
Message-ID: <kFBgZ5CM0uq7As9MMN2dDMuWcv24SA1gQvfxCsFu9n0=.80c106f5-a525-4255-bf57-887407ca050e@github.com>

There is a bug in `TextLayout.getOutline(AffineTransform)`, where the transformation is applied too early (before the layout path applies its mapping). The most obvious error caused by this bug is that `Graphics2D.drawString(...)` fails to draw the string when using a rotated + scaled `AffineTransform` (see minimal test case in the bug report).

There are two uses of `TextLayout.getOutline(AffineTransform)`: the first one, triggered via a simple `Graphics2D.drawString(...)` was the one I ran into; the second one requires the use of a transformed font with a `PSPrinterJob`. Both are broken. This PR includes two test classes verifying that both scenarios were broken before the fix and are working after the fix.

Two points which might require some discussion:
1. I've changed the signature of method `TextLine.getOutline(AffineTransform)`, to just `TextLine.getOutline()`; I'm assuming this is OK since `TextLine` is a package-private class.
2. I've added a fast path in `TextLayout.getOutline(AffineTransform)` to transform the shape in place if it is a `GeneralPath` (it should usually be, and avoids an extra `Shape` copy vs. the current code, which makes no copy). A bit more complex, but efficient.

-------------

Commit messages:
 - Fix TextLayout.getOutline(AffineTransform)

Changes: https://git.openjdk.org/jdk/pull/20993/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20993&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339974
  Stats: 347 lines in 4 files changed: 341 ins; 4 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20993.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20993/head:pull/20993

PR: https://git.openjdk.org/jdk/pull/20993

From psadhukhan at openjdk.org  Fri Sep 13 11:26:12 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 13 Sep 2024 11:26:12 GMT
Subject: Integrated: 8339727: Open source several AWT focus tests - series 1
In-Reply-To: <upsQ9K0vfHMndfpzhpYZbAO9nVGGRjus9W9DjRwZUmM=.ea864b5e-acf7-456a-a499-286bcd058301@github.com>
References: <upsQ9K0vfHMndfpzhpYZbAO9nVGGRjus9W9DjRwZUmM=.ea864b5e-acf7-456a-a499-286bcd058301@github.com>
Message-ID: <M51CZJOuYvl_tO0WwuH73AISdmqnMlXfPRubGhqI6Uo=.d08cf537-d9c1-4828-a1f1-1dc4a954c71f@github.com>

On Thu, 12 Sep 2024 05:51:10 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Open source few AWT focus tests

This pull request has now been integrated.

Changeset: 358ff196
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/358ff196336407484b1b892f08936e9378701959
Stats:     649 lines in 5 files changed: 649 ins; 0 del; 0 mod

8339727: Open source several AWT focus tests - series 1

Reviewed-by: honkar

-------------

PR: https://git.openjdk.org/jdk/pull/20961

From psadhukhan at openjdk.org  Fri Sep 13 11:51:44 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 13 Sep 2024 11:51:44 GMT
Subject: RFR: 8339842: Open source several AWT focus tests - series 2
Message-ID: <iIBGu4_2bbidwDoBTVjerhAT_Q3TbYtxaajlAeZfuec=.7881e25e-357f-46d4-b229-2ecc4a00bfcb@github.com>

Opensource few AWT focus tests

-------------

Commit messages:
 - jcheck
 - 8339842: Open source several AWT focus tests - series 2

Changes: https://git.openjdk.org/jdk/pull/20996/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20996&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339842
  Stats: 701 lines in 4 files changed: 701 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20996.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20996/head:pull/20996

PR: https://git.openjdk.org/jdk/pull/20996

From azvegint at openjdk.org  Fri Sep 13 12:08:07 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 13 Sep 2024 12:08:07 GMT
Subject: RFR: 8339639: Opensource few AWT PopupMenu tests
In-Reply-To: <FvOMRbBanx09AoLf-HQ7F3ml_mXpIhk8mO1-D4N_4cw=.25c520bc-041d-486a-b80f-455819a2b568@github.com>
References: <FvOMRbBanx09AoLf-HQ7F3ml_mXpIhk8mO1-D4N_4cw=.25c520bc-041d-486a-b80f-455819a2b568@github.com>
Message-ID: <w_syNSp5dJaRRgzRAxAWTPJ2PpBydFzVs3Eb4CD0GBc=.58ef8310-76b7-47bf-8eb9-13b75771405e@github.com>

On Fri, 13 Sep 2024 05:07:26 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> OPensource few AWT PopupMenu tests

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20982#pullrequestreview-2302945839

From duke at openjdk.org  Fri Sep 13 14:41:48 2024
From: duke at openjdk.org (Daniel Gredler)
Date: Fri, 13 Sep 2024 14:41:48 GMT
Subject: RFR: 8339974: Graphics2D.drawString doesn't always work with Font
 derived from AffineTransform [v2]
In-Reply-To: <kFBgZ5CM0uq7As9MMN2dDMuWcv24SA1gQvfxCsFu9n0=.80c106f5-a525-4255-bf57-887407ca050e@github.com>
References: <kFBgZ5CM0uq7As9MMN2dDMuWcv24SA1gQvfxCsFu9n0=.80c106f5-a525-4255-bf57-887407ca050e@github.com>
Message-ID: <8wAz3aLdxXQrWuQtLvRXEtJ7ODGOGsuDE2QW465A05k=.5ed6a47d-e07f-400d-9566-70e4f6ecb8b2@github.com>

> There is a bug in `TextLayout.getOutline(AffineTransform)`, where the transformation is applied too early (before the layout path applies its mapping). The most obvious error caused by this bug is that `Graphics2D.drawString(...)` fails to draw the string when using a rotated + scaled `AffineTransform` (see minimal test case in the bug report).
> 
> There are two uses of `TextLayout.getOutline(AffineTransform)`: the first one, triggered via a simple `Graphics2D.drawString(...)` was the one I ran into; the second one requires the use of a transformed font with a `PSPrinterJob`. Both are broken. This PR includes two test classes verifying that both scenarios were broken before the fix and are working after the fix.
> 
> Two points which might require some discussion:
> 1. I've changed the signature of method `TextLine.getOutline(AffineTransform)`, to just `TextLine.getOutline()`; I'm assuming this is OK since `TextLine` is a package-private class.
> 2. I've added a fast path in `TextLayout.getOutline(AffineTransform)` to transform the shape in place if it is a `GeneralPath` (it should usually be, and avoids an extra `Shape` copy vs. the current code, which makes no copy). A bit more complex, but efficient.

Daniel Gredler has updated the pull request incrementally with one additional commit since the last revision:

  Add bug ID and summary to test classes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20993/files
  - new: https://git.openjdk.org/jdk/pull/20993/files/20e970a6..a6081981

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20993&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20993&range=00-01

  Stats: 4 lines in 2 files changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20993.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20993/head:pull/20993

PR: https://git.openjdk.org/jdk/pull/20993

From nbenalla at openjdk.org  Fri Sep 13 15:08:39 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Fri, 13 Sep 2024 15:08:39 GMT
Subject: RFR: 8339845: Update color.org and wapforum.org links to use HTTPS
 instead of HTTP
Message-ID: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>

Can I get a review for this doc-only change? I updated some links because the websites moved from HTTP to HTTPS. The redirects can cause some false-positives on tests.

TIA

-------------

Commit messages:
 - Update color.org and wapforum.org links to use HTTPS instead of HTTP
 - Update color.org and wapforum.org links to use HTTPS instead of HTTP

Changes: https://git.openjdk.org/jdk/pull/21001/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21001&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339845
  Stats: 9 lines in 5 files changed: 0 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/21001.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21001/head:pull/21001

PR: https://git.openjdk.org/jdk/pull/21001

From prr at openjdk.org  Fri Sep 13 18:55:28 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 13 Sep 2024 18:55:28 GMT
Subject: RFR: 8339883: Open source several AWT/2D related tests [v4]
In-Reply-To: <_hbOe0ROqqQsG7hdhrGk28JVDNGP1yz2vKhVo3GDIxw=.c3bde19f-4f6e-45df-aee3-2832258ffaa9@github.com>
References: <_hbOe0ROqqQsG7hdhrGk28JVDNGP1yz2vKhVo3GDIxw=.c3bde19f-4f6e-45df-aee3-2832258ffaa9@github.com>
Message-ID: <phVyZbmodtZJw1O3sO-jDh3Cr04C9-TOPsbYqRIicCw=.cd8ed940-ce07-4791-a543-5b5d0a80d0bc@github.com>

> This open sources a few AWT/2D regression tests.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8339883

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20977/files
  - new: https://git.openjdk.org/jdk/pull/20977/files/f0877662..648685d3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20977&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20977&range=02-03

  Stats: 13 lines in 2 files changed: 0 ins; 2 del; 11 mod
  Patch: https://git.openjdk.org/jdk/pull/20977.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20977/head:pull/20977

PR: https://git.openjdk.org/jdk/pull/20977

From honkar at openjdk.org  Fri Sep 13 22:09:44 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 13 Sep 2024 22:09:44 GMT
Subject: RFR: JDK-8339962 : Open source AWT TextField tests - Set1
Message-ID: <v6evWDMdJ5taNxUxxPD-onH6DfUhWGyWSW69gyb87fo=.380962ba-cc65-403e-8337-33186b5d9e29@github.com>

Following test are open-sourced.

1. 	test/jdk/java/awt/Label/ContainerValidateTest.java - Automated
2. 	test/jdk/java/awt/TextField/SetEchoCharTest.java - Automated
3. 	test/jdk/java/awt/TextField/SetEchoCharWordOpsTest.java - PassFailJFrame manual test

-------------

Commit messages:
 - open source awt tests

Changes: https://git.openjdk.org/jdk/pull/21005/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21005&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339962
  Stats: 438 lines in 3 files changed: 438 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21005.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21005/head:pull/21005

PR: https://git.openjdk.org/jdk/pull/21005

From prr at openjdk.org  Fri Sep 13 22:59:12 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 13 Sep 2024 22:59:12 GMT
Subject: RFR: 8339845: Update color.org and wapforum.org links to use HTTPS
 instead of HTTP
In-Reply-To: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
References: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
Message-ID: <TpDQU-APeBkHDJ4F5fn2y0QNqnG_4tq8ayyTOLIfP-I=.27a78d7f-8aa1-41df-bcfc-d794d5f264cf@github.com>

On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I get a review for this doc-only change? I updated some links because the websites moved from HTTP to HTTPS. The redirects can cause some false-positives on tests.
> 
> TIA

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21001#pullrequestreview-2304277071

From prr at openjdk.org  Fri Sep 13 23:00:17 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 13 Sep 2024 23:00:17 GMT
Subject: RFR: 8339639: Opensource few AWT PopupMenu tests
In-Reply-To: <FvOMRbBanx09AoLf-HQ7F3ml_mXpIhk8mO1-D4N_4cw=.25c520bc-041d-486a-b80f-455819a2b568@github.com>
References: <FvOMRbBanx09AoLf-HQ7F3ml_mXpIhk8mO1-D4N_4cw=.25c520bc-041d-486a-b80f-455819a2b568@github.com>
Message-ID: <MDVvx7quhTjpUlJyW1DIQoW3fXojX-8rlPRA0SZelQo=.4ae98b1f-e219-42b3-b2ca-a54266f071dd@github.com>

On Fri, 13 Sep 2024 05:07:26 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> OPensource few AWT PopupMenu tests

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20982#pullrequestreview-2304277510

From duke at openjdk.org  Fri Sep 13 23:02:22 2024
From: duke at openjdk.org (duke)
Date: Fri, 13 Sep 2024 23:02:22 GMT
Subject: RFR: 8339943: Frame not disposed in
 java/awt/dnd/DropActionChangeTest.java [v3]
In-Reply-To: <7KdqjCBzai3gwunfQ_NKnXuAotj01EDih-ZAvSVIeF8=.068989e5-4c25-4de2-a723-cabb165a356e@github.com>
References: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
 <7KdqjCBzai3gwunfQ_NKnXuAotj01EDih-ZAvSVIeF8=.068989e5-4c25-4de2-a723-cabb165a356e@github.com>
Message-ID: <VkUYGb5cEsAzu43_ntooFiza7IKC8J5sd-sg-hTXEbU=.ae348143-969c-41b3-9630-8807eb7a4c13@github.com>

On Thu, 12 Sep 2024 17:00:18 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> Stabilized the test by disposing the frame at the end, adding an auto delay,  called panel.getLocationOnScreen() in invokeAndWait(), formatting changes, etc
>> And for better debugging, added captureScreen() for failure cases.
>> 
>> Testing:
>> Tested using mach5 in all available platforms and attached the link in bug as a comment.
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments fixed : Minor formatting changes

@openjdk[bot] 
Your change (at version b4758cd7c35dd15cb6bc1cf42fc64c455dca3743) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20951#issuecomment-2350650463

From prr at openjdk.org  Fri Sep 13 23:02:22 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 13 Sep 2024 23:02:22 GMT
Subject: RFR: 8339943: Frame not disposed in
 java/awt/dnd/DropActionChangeTest.java [v3]
In-Reply-To: <7KdqjCBzai3gwunfQ_NKnXuAotj01EDih-ZAvSVIeF8=.068989e5-4c25-4de2-a723-cabb165a356e@github.com>
References: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
 <7KdqjCBzai3gwunfQ_NKnXuAotj01EDih-ZAvSVIeF8=.068989e5-4c25-4de2-a723-cabb165a356e@github.com>
Message-ID: <75mc8c9gFsy-MUDXJilKtV63OXvq0sW9ulwH6VmkYPA=.b33136be-aac8-4c95-8537-99c23f7ffffe@github.com>

On Thu, 12 Sep 2024 17:00:18 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> Stabilized the test by disposing the frame at the end, adding an auto delay,  called panel.getLocationOnScreen() in invokeAndWait(), formatting changes, etc
>> And for better debugging, added captureScreen() for failure cases.
>> 
>> Testing:
>> Tested using mach5 in all available platforms and attached the link in bug as a comment.
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments fixed : Minor formatting changes

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20951#pullrequestreview-2304278197

From prr at openjdk.org  Fri Sep 13 23:07:18 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 13 Sep 2024 23:07:18 GMT
Subject: RFR: 8339842: Open source several AWT focus tests - series 2
In-Reply-To: <iIBGu4_2bbidwDoBTVjerhAT_Q3TbYtxaajlAeZfuec=.7881e25e-357f-46d4-b229-2ecc4a00bfcb@github.com>
References: <iIBGu4_2bbidwDoBTVjerhAT_Q3TbYtxaajlAeZfuec=.7881e25e-357f-46d4-b229-2ecc4a00bfcb@github.com>
Message-ID: <8uTUDdmYD-1-MpK50bjuGIqbWm-R0F0q9S1kdHz9Dbs=.0ed6cfa7-74a7-4191-86ac-fac2444388b4@github.com>

On Fri, 13 Sep 2024 11:41:52 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few AWT focus tests

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20996#pullrequestreview-2304286115

From mvs at openjdk.org  Sat Sep 14 05:12:08 2024
From: mvs at openjdk.org (Manukumar V S)
Date: Sat, 14 Sep 2024 05:12:08 GMT
Subject: Integrated: 8339943: Frame not disposed in
 java/awt/dnd/DropActionChangeTest.java
In-Reply-To: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
References: <uQEDlg0zaHqyE2sFyTy6ILy09ii1LccQjGeqx4mGvEU=.81da421a-0ef6-4423-835d-f41d1b3737bb@github.com>
Message-ID: <tqYhbUS5kdaT2iNPxtutCutKKXfxjoZNvN64zNjEuSI=.c11d9050-60c5-41eb-9310-4335e497148d@github.com>

On Wed, 11 Sep 2024 14:37:12 GMT, Manukumar V S <mvs at openjdk.org> wrote:

> Stabilized the test by disposing the frame at the end, adding an auto delay,  called panel.getLocationOnScreen() in invokeAndWait(), formatting changes, etc
> And for better debugging, added captureScreen() for failure cases.
> 
> Testing:
> Tested using mach5 in all available platforms and attached the link in bug as a comment.

This pull request has now been integrated.

Changeset: fa502ecd
Author:    Manukumar V S <mvs at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/fa502ecd2d1040ee2fe26d0ac5dd547379a0ade7
Stats:     74 lines in 1 file changed: 40 ins; 17 del; 17 mod

8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java

Reviewed-by: prr, azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/20951

From duke at openjdk.org  Sat Sep 14 17:24:02 2024
From: duke at openjdk.org (Abdelhak Zaaim)
Date: Sat, 14 Sep 2024 17:24:02 GMT
Subject: RFR: 8339845: Update color.org and wapforum.org links to use HTTPS
 instead of HTTP
In-Reply-To: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
References: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
Message-ID: <_uzari_nPRkF8Y9kV2S1BDWWq1mjuIAfUjvEriHMiWA=.da35b9af-59bc-4a5f-9e97-c31bc1715e85@github.com>

On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I get a review for this doc-only change? I updated some links because the websites moved from HTTP to HTTPS. The redirects can cause some false-positives on tests.
> 
> TIA

The update to HTTPS is appreciated for consistency, though not strictly necessary since HTTP links already redirect to HTTPS. Please ensure all updated links function as expected and align with the project standards.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21001#pullrequestreview-2304447218

From honkar at openjdk.org  Sun Sep 15 02:03:04 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Sun, 15 Sep 2024 02:03:04 GMT
Subject: RFR: 8339845: Update color.org and wapforum.org links to use HTTPS
 instead of HTTP
In-Reply-To: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
References: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
Message-ID: <MtmMa6xVJEpvKSnOYdg4-Nv6mp93FBq2b7VifiwAUko=.10607d28-5c0d-4590-a9f3-0fd0ac222c16@github.com>

On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I get a review for this doc-only change? I updated some links because the websites moved from HTTP to HTTPS. The redirects can cause some false-positives on tests.
> 
> TIA

src/java.desktop/share/classes/java/awt/image/ColorConvertOp.java line 693:

> 691:          * bytes here.
> 692:          *
> 693:          *  See https://www.color.org/ICC1v42_2006-05.pdf, section 7.2.15.

@prrace I wanted to clarify regarding current ICC Doc links which point to older ICC Specification document. Do they need to be updated to the latest one?
https://www.color.org/specification/ICC.1-2022-05.pdf

src/java.desktop/share/classes/javax/imageio/plugins/tiff/BaselineTIFFTagSet.java line 1011:

> 1009:      * Constant specifying the "ICC Profile" tag.
> 1010:      *
> 1011:      * @see <a href="https://www.color.org/ICC1V42.pdf">ICC Specification, section B.4: Embedding ICC profiles in TIFF files</a>

Same here ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21001#discussion_r1759941444
PR Review Comment: https://git.openjdk.org/jdk/pull/21001#discussion_r1759941591

From honkar at openjdk.org  Mon Sep 16 02:25:26 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 16 Sep 2024 02:25:26 GMT
Subject: RFR: JDK-8339962 : Open source AWT TextField tests - Set1 [v2]
In-Reply-To: <v6evWDMdJ5taNxUxxPD-onH6DfUhWGyWSW69gyb87fo=.380962ba-cc65-403e-8337-33186b5d9e29@github.com>
References: <v6evWDMdJ5taNxUxxPD-onH6DfUhWGyWSW69gyb87fo=.380962ba-cc65-403e-8337-33186b5d9e29@github.com>
Message-ID: <VXJcFdO105h6lzTWkTEP72SuUBUK36S8UgyAb6Eb5kQ=.93342883-52b3-4762-9e4e-11e87fa4feb3@github.com>

> Following test are open-sourced.
> 
> 1. 	test/jdk/java/awt/Label/ContainerValidateTest.java - Automated
> 2. 	test/jdk/java/awt/TextField/SetEchoCharTest.java - Automated
> 3. 	test/jdk/java/awt/TextField/SetEchoCharWordOpsTest.java - PassFailJFrame manual test

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  formatting

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21005/files
  - new: https://git.openjdk.org/jdk/pull/21005/files/818df2ab..fa890150

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21005&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21005&range=00-01

  Stats: 6 lines in 1 file changed: 0 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/21005.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21005/head:pull/21005

PR: https://git.openjdk.org/jdk/pull/21005

From psadhukhan at openjdk.org  Mon Sep 16 03:52:10 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 16 Sep 2024 03:52:10 GMT
Subject: Integrated: 8339639: Opensource few AWT PopupMenu tests
In-Reply-To: <FvOMRbBanx09AoLf-HQ7F3ml_mXpIhk8mO1-D4N_4cw=.25c520bc-041d-486a-b80f-455819a2b568@github.com>
References: <FvOMRbBanx09AoLf-HQ7F3ml_mXpIhk8mO1-D4N_4cw=.25c520bc-041d-486a-b80f-455819a2b568@github.com>
Message-ID: <8dbLagFkKaaIdqowCjFyxFCfAZ0b6CdAdw2dpx85S4g=.b3e7502f-daad-40e3-b01e-7c8ae991170c@github.com>

On Fri, 13 Sep 2024 05:07:26 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> OPensource few AWT PopupMenu tests

This pull request has now been integrated.

Changeset: a0794e0a
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a0794e0a054c5e7ed051efa6362726cdd7598255
Stats:     360 lines in 3 files changed: 360 ins; 0 del; 0 mod

8339639: Opensource few AWT PopupMenu tests

Reviewed-by: azvegint, prr

-------------

PR: https://git.openjdk.org/jdk/pull/20982

From psadhukhan at openjdk.org  Mon Sep 16 04:21:21 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 16 Sep 2024 04:21:21 GMT
Subject: RFR: 8340015: Open source several AWT focus tests - series 7
Message-ID: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>

Opensource few AWT focus tests

-------------

Commit messages:
 - 8340015: Open source several AWT focus tests - series 7
 - 8340015: Open source several AWT focus tests - series 7

Changes: https://git.openjdk.org/jdk/pull/21008/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21008&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340015
  Stats: 272 lines in 4 files changed: 272 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21008.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21008/head:pull/21008

PR: https://git.openjdk.org/jdk/pull/21008

From psadhukhan at openjdk.org  Mon Sep 16 05:45:15 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 16 Sep 2024 05:45:15 GMT
Subject: Integrated: 8339842: Open source several AWT focus tests - series 2
In-Reply-To: <iIBGu4_2bbidwDoBTVjerhAT_Q3TbYtxaajlAeZfuec=.7881e25e-357f-46d4-b229-2ecc4a00bfcb@github.com>
References: <iIBGu4_2bbidwDoBTVjerhAT_Q3TbYtxaajlAeZfuec=.7881e25e-357f-46d4-b229-2ecc4a00bfcb@github.com>
Message-ID: <vOTnSAvLeqGBoMYbeDyFF1UmwQDoXvoubD45kQBVLBc=.452592f6-1e2b-4836-9cd5-c9ecdaacb1ee@github.com>

On Fri, 13 Sep 2024 11:41:52 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few AWT focus tests

This pull request has now been integrated.

Changeset: 4b790637
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/4b7906375b4bd11a480665110561180825c2dd9c
Stats:     701 lines in 4 files changed: 701 ins; 0 del; 0 mod

8339842: Open source several AWT focus tests - series 2

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/20996

From psadhukhan at openjdk.org  Mon Sep 16 05:47:06 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 16 Sep 2024 05:47:06 GMT
Subject: RFR: 8339883: Open source several AWT/2D related tests [v4]
In-Reply-To: <phVyZbmodtZJw1O3sO-jDh3Cr04C9-TOPsbYqRIicCw=.cd8ed940-ce07-4791-a543-5b5d0a80d0bc@github.com>
References: <_hbOe0ROqqQsG7hdhrGk28JVDNGP1yz2vKhVo3GDIxw=.c3bde19f-4f6e-45df-aee3-2832258ffaa9@github.com>
 <phVyZbmodtZJw1O3sO-jDh3Cr04C9-TOPsbYqRIicCw=.cd8ed940-ce07-4791-a543-5b5d0a80d0bc@github.com>
Message-ID: <PsC59E5LyHlG-F0SSD0ga7WuFkTPsH5pQlIzbobOJGY=.3c5a341f-6602-4265-9ca9-6dc67b175d84@github.com>

On Fri, 13 Sep 2024 18:55:28 GMT, Phil Race <prr at openjdk.org> wrote:

>> This open sources a few AWT/2D regression tests.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8339883

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20977#pullrequestreview-2305772850

From aivanov at openjdk.org  Mon Sep 16 09:59:17 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 16 Sep 2024 09:59:17 GMT
Subject: RFR: 8340007: Refactor KeyEvent/FunctionKeyTest.java
Message-ID: <TT5b8Kyty70NTNh94YUfKY1lKtxbBe_Niw9X3HmSBTk=.ab198caa-c838-4336-9e07-470e607ac781@github.com>

This changeset refactors `java/awt/event/KeyEvent/FunctionKeyTest.java`.

Key changes:

- Use `CyclicBarrier` to verify whether a key is pressed and released;
- Use `CountDownLatch` for frame activation;
- Ensure thread-safety for keeping thrown exceptions.

Other changes:

- Made `FunctionKeyTester` a nested class inside `FunctionKeyTest`;
- Used constants for the key events rather than magic numbers.

I ran the updated test a few times with `JTREG=REPEAT_COUNT=20`, the test has passed.

The updated test executes somewhat quicker than the old one.

@azvegint, you may want to take a look.

-------------

Commit messages:
 - 8340007: Refactor KeyEvent/FunctionKeyTest.java

Changes: https://git.openjdk.org/jdk/pull/21013/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21013&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340007
  Stats: 114 lines in 1 file changed: 62 ins; 15 del; 37 mod
  Patch: https://git.openjdk.org/jdk/pull/21013.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21013/head:pull/21013

PR: https://git.openjdk.org/jdk/pull/21013

From aivanov at openjdk.org  Mon Sep 16 10:10:05 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 16 Sep 2024 10:10:05 GMT
Subject: RFR: 8340007: Refactor KeyEvent/FunctionKeyTest.java
In-Reply-To: <TT5b8Kyty70NTNh94YUfKY1lKtxbBe_Niw9X3HmSBTk=.ab198caa-c838-4336-9e07-470e607ac781@github.com>
References: <TT5b8Kyty70NTNh94YUfKY1lKtxbBe_Niw9X3HmSBTk=.ab198caa-c838-4336-9e07-470e607ac781@github.com>
Message-ID: <Ws24rhvvySgTD_rnHDKwTqtnDqyER4iNdQfBTJXFp2s=.ab9ea246-1846-43fd-bca6-b1b09ab98278@github.com>

On Mon, 16 Sep 2024 09:55:19 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> This changeset refactors `java/awt/event/KeyEvent/FunctionKeyTest.java`.
> 
> Key changes:
> 
> - Use `CyclicBarrier` to verify whether a key is pressed and released;
> - Use `CountDownLatch` for frame activation;
> - Ensure thread-safety for keeping thrown exceptions.
> 
> Other changes:
> 
> - Made `FunctionKeyTester` a nested class inside `FunctionKeyTest`;
> - Used constants for the key events rather than magic numbers.
> 
> I ran the updated test a few times with `JTREG=REPEAT_COUNT=20`, the test has passed.
> 
> The updated test executes somewhat quicker than the old one.
> 
> @azvegint, you may want to take a look.

test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java line 70:

> 68:     public static void main(String[] args) throws Exception {
> 69:         robot = new Robot();
> 70:         robot.setAutoWaitForIdle(true);

This makes the updated test run slower because the barriers block EDT for a short while until the two threads ? EDT and main thread ? arrive to the same point.

`robot.waitForIdle` blocks the main thread from arriving to the barrier and *releasing EDT*.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21013#discussion_r1760867438

From aivanov at openjdk.org  Mon Sep 16 11:41:10 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 16 Sep 2024 11:41:10 GMT
Subject: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may
 fail after JDK-8327401 [v3]
In-Reply-To: <gcx7ONrZbHWzpVXqjZwaa8Gc1zTYj-H0RtictQv_S3Y=.f708d7bd-5f4b-4408-a226-557b0baf2a4e@github.com>
References: <rot7Rc0pyVsH2CTy5LnxVRPSAGilnI3HQJcJWTvrjs0=.9b585c6b-99bd-4ab7-bb9d-d164b6e90289@github.com>
 <gcx7ONrZbHWzpVXqjZwaa8Gc1zTYj-H0RtictQv_S3Y=.f708d7bd-5f4b-4408-a226-557b0baf2a4e@github.com>
Message-ID: <Ta5ZMw5GGCxXzPrgBdTNSofBDZiFQb7J0owGLiW7f8M=.15fbd630-3af1-4319-8640-af97ec074ae7@github.com>

On Mon, 9 Sep 2024 19:30:35 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update bug4490179.java
>
> test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java line 53:
> 
>> 51: 
>> 52: public class KeyEventsTest {
>> 53:     private volatile TestState currentState;
> 
> I'd rather not declare it a `volatile`. It could give a false impression of being thread-safe but it is not. The `volatile` modifier has a meaning only when it's written and read subsequently. If the reference doesn't change, it has no effect on the visibility of the internal object state.
> 
> The value is assigned to `currentState` while holding a lock `LOCK`.
> 
> At the same time, `currentState.setAction(true)` is called without any synchronisation and adding `volatile` won't make the change of the state thread-safe.

Submitted [JDK-8340196](https://bugs.openjdk.org/browse/JDK-8340196): _j.a/List/KeyEventsTest/KeyEventsTest: TestState currentState is not thread-safe_.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20861#discussion_r1760988001

From honkar at openjdk.org  Mon Sep 16 19:18:43 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 16 Sep 2024 19:18:43 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame builder
 pattern
Message-ID: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>

`positionTestUI()` option is added to PassFailJFrame (PFJ).

With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 

Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code per test UI requirements.

Usage:

PassFailJFrame.builder()
                      .title("Test Instructions")
                      .instructions(INSTRUCTIONS)
                      .rows((int) INSTRUCTIONS.lines().count() + 3)
                      .columns(30)
                      .testUI(<TestClass::createAndShowUI>)
                      .positionTestUI(<TestClass::positionMultiTestUI>)
                      .build()
                      .awaitAndCheck();

where positionMultiTestUI is the implementation for position of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`

-------------

Commit messages:
 - add positionTestUI() to PFJ builder pattern

Changes: https://git.openjdk.org/jdk/pull/21023/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21023&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340210
  Stats: 29 lines in 1 file changed: 29 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21023.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21023/head:pull/21023

PR: https://git.openjdk.org/jdk/pull/21023

From aivanov at openjdk.org  Mon Sep 16 19:22:08 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 16 Sep 2024 19:22:08 GMT
Subject: RFR: 8337287: Update image in javax.swing.text.Document.insert
In-Reply-To: <VuiOfLGEHf8qGHHfAdUzSf2UGjER2PZmoTMDY9shoP8=.67f977a7-c99a-4ba8-9972-0ac787b23d1f@github.com>
References: <uGCW954xUGOPLGAdN1je8b3k9tQHYTfi8vb8-fYRHYk=.737dfade-8b82-4194-a4ab-fcf30bcb7ea1@github.com>
 <VuiOfLGEHf8qGHHfAdUzSf2UGjER2PZmoTMDY9shoP8=.67f977a7-c99a-4ba8-9972-0ac787b23d1f@github.com>
Message-ID: <xfpB8WHjI41Mx4QpMUQd0uWstF01x9-Aix-aRAK4dBQ=.5c8146fe-bd6d-40f8-9dd2-fe5bbdbbe51f@github.com>

On Sat, 24 Aug 2024 00:11:14 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Just curious why the chars are not in the middle of the boxes?

They're aligned according to CSS rules:


            text-anchor: middle;
            dominant-baseline: middle;


The text is positioned in the middle of the box -0.5 pixels.

However, I agree the text looks visually unbalanced. Indeed, at 200% scale and Arial font, there are 4 pixels on top of ?T? and ?h?, but there are 8 pixels on the bottom of ?q?. If I use Calibri font, the values are 8 and 9 pixels correspondingly. So it depends on the font used. The situation is similar on macOS.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20376#issuecomment-2353728939

From aivanov at openjdk.org  Mon Sep 16 19:31:09 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 16 Sep 2024 19:31:09 GMT
Subject: RFR: 8337287: Update image in javax.swing.text.Document.insert
In-Reply-To: <xfpB8WHjI41Mx4QpMUQd0uWstF01x9-Aix-aRAK4dBQ=.5c8146fe-bd6d-40f8-9dd2-fe5bbdbbe51f@github.com>
References: <uGCW954xUGOPLGAdN1je8b3k9tQHYTfi8vb8-fYRHYk=.737dfade-8b82-4194-a4ab-fcf30bcb7ea1@github.com>
 <VuiOfLGEHf8qGHHfAdUzSf2UGjER2PZmoTMDY9shoP8=.67f977a7-c99a-4ba8-9972-0ac787b23d1f@github.com>
 <xfpB8WHjI41Mx4QpMUQd0uWstF01x9-Aix-aRAK4dBQ=.5c8146fe-bd6d-40f8-9dd2-fe5bbdbbe51f@github.com>
Message-ID: <nM03hooHi90ntshtB6FWlYgX7QSaB-khYdaJisW_Dn0=.5cf65ce1-aa1c-44ef-b082-657751dd3e8f@github.com>

On Mon, 16 Sep 2024 19:19:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> The text is positioned in the middle of the box -0.5 pixels.

Moving the text position by 0.5 seems to help, and the values become equal: 7 on either side.

This needs to be done for the image in `remove` too, so I'd rather do that separately, at a later time.

At this time, the diagrams for `insertString` and `remove` look the same.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20376#issuecomment-2353743533

From prr at openjdk.org  Mon Sep 16 19:31:15 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 16 Sep 2024 19:31:15 GMT
Subject: Integrated: 8339883: Open source several AWT/2D related tests
In-Reply-To: <_hbOe0ROqqQsG7hdhrGk28JVDNGP1yz2vKhVo3GDIxw=.c3bde19f-4f6e-45df-aee3-2832258ffaa9@github.com>
References: <_hbOe0ROqqQsG7hdhrGk28JVDNGP1yz2vKhVo3GDIxw=.c3bde19f-4f6e-45df-aee3-2832258ffaa9@github.com>
Message-ID: <IlyPzvTIx6HtCgw5zobxmeBruygOWWWiP35XbN5PV7E=.8939fb19-a456-4236-8df9-9d7d5c71e82b@github.com>

On Thu, 12 Sep 2024 22:31:04 GMT, Phil Race <prr at openjdk.org> wrote:

> This open sources a few AWT/2D regression tests.

This pull request has now been integrated.

Changeset: b26645f6
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/b26645f64bb6dd3efafaceb92bedeaf8f93906e3
Stats:     315 lines in 4 files changed: 315 ins; 0 del; 0 mod

8339883: Open source several AWT/2D related tests

Reviewed-by: psadhukhan, honkar

-------------

PR: https://git.openjdk.org/jdk/pull/20977

From prr at openjdk.org  Mon Sep 16 19:32:04 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 16 Sep 2024 19:32:04 GMT
Subject: RFR: JDK-8339962 : Open source AWT TextField tests - Set1 [v2]
In-Reply-To: <VXJcFdO105h6lzTWkTEP72SuUBUK36S8UgyAb6Eb5kQ=.93342883-52b3-4762-9e4e-11e87fa4feb3@github.com>
References: <v6evWDMdJ5taNxUxxPD-onH6DfUhWGyWSW69gyb87fo=.380962ba-cc65-403e-8337-33186b5d9e29@github.com>
 <VXJcFdO105h6lzTWkTEP72SuUBUK36S8UgyAb6Eb5kQ=.93342883-52b3-4762-9e4e-11e87fa4feb3@github.com>
Message-ID: <n5XnRSpK4LI6JFk9967odDIRa3pH4LtI6j-Nwg_29Yk=.5f763300-ecf2-4e09-8562-ef30765f0c4b@github.com>

On Mon, 16 Sep 2024 02:25:26 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test are open-sourced.
>> 
>> 1. 	test/jdk/java/awt/Label/ContainerValidateTest.java - Automated
>> 2. 	test/jdk/java/awt/TextField/SetEchoCharTest.java - Automated
>> 3. 	test/jdk/java/awt/TextField/SetEchoCharWordOpsTest.java - PassFailJFrame manual test
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   formatting

Marked as reviewed by prr (Reviewer).

test/jdk/java/awt/TextField/SetEchoCharWordOpsTest.java line 34:

> 32:  * @test
> 33:  * @bug 6191897
> 34:  * @summary Verifies that ctrl+left/right does not move word-by-word in a TexField

TexField -> TextField.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21005#pullrequestreview-2307597795
PR Review Comment: https://git.openjdk.org/jdk/pull/21005#discussion_r1761766839

From prr at openjdk.org  Mon Sep 16 19:33:05 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 16 Sep 2024 19:33:05 GMT
Subject: RFR: 8339845: Update color.org and wapforum.org links to use HTTPS
 instead of HTTP
In-Reply-To: <MtmMa6xVJEpvKSnOYdg4-Nv6mp93FBq2b7VifiwAUko=.10607d28-5c0d-4590-a9f3-0fd0ac222c16@github.com>
References: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
 <MtmMa6xVJEpvKSnOYdg4-Nv6mp93FBq2b7VifiwAUko=.10607d28-5c0d-4590-a9f3-0fd0ac222c16@github.com>
Message-ID: <sMnGZIBcD-DY48WeGq8rcJkZ4wKcLMJbK-R90KgPRs4=.94868a83-feff-4036-af3b-5fd5412e13a7@github.com>

On Sun, 15 Sep 2024 01:56:16 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Can I get a review for this doc-only change? I updated some links because the websites moved from HTTP to HTTPS. The redirects can cause some false-positives on tests.
>> 
>> TIA
>
> src/java.desktop/share/classes/java/awt/image/ColorConvertOp.java line 693:
> 
>> 691:          * bytes here.
>> 692:          *
>> 693:          *  See https://www.color.org/ICC1v42_2006-05.pdf, section 7.2.15.
> 
> @prrace I wanted to clarify if the ICC Specification Doc links need to be updated to the latest one?
> https://www.color.org/specification/ICC.1-2022-05.pdf

That would be out of scope for this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21001#discussion_r1761768091

From aivanov at openjdk.org  Mon Sep 16 19:44:04 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 16 Sep 2024 19:44:04 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame builder
 pattern
In-Reply-To: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
Message-ID: <AOkqcFB49WnYv-glna-grpATlF3QUBlRjLKI5beA2vA=.c09dcd14-4613-462b-8179-45577706c813@github.com>

On Mon, 16 Sep 2024 19:11:59 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> `positionTestUI()` option is added to PassFailJFrame (PFJ).
> 
> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
> 
> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code per test UI requirements.
> 
> Usage:
> 
> PassFailJFrame.builder()
>                       .title("Test Instructions")
>                       .instructions(INSTRUCTIONS)
>                       .rows((int) INSTRUCTIONS.lines().count() + 3)
>                       .columns(30)
>                       .testUI(<TestClass::createAndShowUI>)
>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>                       .build()
>                       .awaitAndCheck();
> 
> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
> 
> Few examples of custom testUI positioning implementation using positionTestUI are demonstrated here: 
> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**

Looks good to me.

It was previously discussed in #15665 when I added `testUI`. The interface and the field in the builder were defined but there was no way to pass an implementation of `PositionWindows`.

> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code per test UI requirements.

There's an enhancement [JDK-8317116](https://bugs.openjdk.org/browse/JDK-8317116): _Provide layouts for multiple test UI in `PassFailJFrame`_ to provide a set of common layouts for tests to re-use. It would avoid code duplication for the most common layouts like columns or rows to the right or bottom of the instruction UI.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21023#pullrequestreview-2307616880

From honkar at openjdk.org  Mon Sep 16 19:45:04 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 16 Sep 2024 19:45:04 GMT
Subject: RFR: 8339845: Update color.org and wapforum.org links to use HTTPS
 instead of HTTP
In-Reply-To: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
References: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
Message-ID: <mO3MmTZR8aqyZLjl0g4hxR2mGc4aLkPepILDV_DhoUA=.7fcdcaf4-f031-40e0-ac03-247367454523@github.com>

On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I get a review for this doc-only change? I updated some links because the websites moved from HTTP to HTTPS. The redirects can cause some false-positives on tests.
> 
> TIA

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21001#pullrequestreview-2307620748

From honkar at openjdk.org  Mon Sep 16 21:03:04 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 16 Sep 2024 21:03:04 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
In-Reply-To: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
Message-ID: <a4PU348Ox-5FHJnprbvbgmGHKw2CXzLcZiNG4V0Dt-I=.334caf90-d15a-42cb-9869-8a3fba06ec71@github.com>

On Mon, 16 Sep 2024 19:11:59 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> `positionTestUI()` option is added to PassFailJFrame (PFJ).
> 
> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
> 
> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code per test UI requirements.
> 
> Usage:
> 
> PassFailJFrame.builder()
>                       .title("Test Instructions")
>                       .instructions(INSTRUCTIONS)
>                       .rows(int)
>                       .columns(int)
>                       .testUI(<TestClass::createAndShowUI>)
>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>                       .build()
>                       .awaitAndCheck();
> 
> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
> 
> @aivanov-jdk has demonstrated custom test UI positioning in this PR: 
> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**

> There's an enhancement [JDK-8317116](https://bugs.openjdk.org/browse/JDK-8317116): Provide layouts for multiple test UI in PassFailJFrame to provide a set of common layouts for tests to re-use. It would avoid code duplication for the most common layouts like columns or rows to the right or bottom of the instruction UI.

Update PR description with the PR link related to JDK-8317116 in case anyone wants to explore custom positioning of multiple UIs.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21023#issuecomment-2354024837

From honkar at openjdk.org  Mon Sep 16 21:38:36 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 16 Sep 2024 21:38:36 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v2]
In-Reply-To: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
Message-ID: <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>

> `positionTestUI()` option is added to PassFailJFrame (PFJ).
> 
> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
> 
> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code per test UI requirements.
> 
> Usage:
> 
> PassFailJFrame.builder()
>                       .title("Test Instructions")
>                       .instructions(INSTRUCTIONS)
>                       .rows(int)
>                       .columns(int)
>                       .testUI(<TestClass::createAndShowUI>)
>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>                       .build()
>                       .awaitAndCheck();
> 
> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
> 
> @aivanov-jdk has demonstrated custom test UI positioning in this PR: 
> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  removed errorenous check

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21023/files
  - new: https://git.openjdk.org/jdk/pull/21023/files/081b3fe1..5a331fd6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21023&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21023&range=00-01

  Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21023.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21023/head:pull/21023

PR: https://git.openjdk.org/jdk/pull/21023

From honkar at openjdk.org  Mon Sep 16 21:38:36 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 16 Sep 2024 21:38:36 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v2]
In-Reply-To: <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
 <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
Message-ID: <FFSo1RNt9a8IsPu67AEA7Fd389gogqtTmSSeeKmmg1k=.7cfc4b77-ed2a-430d-9915-2e6c53072049@github.com>

On Mon, 16 Sep 2024 21:31:58 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>> 
>> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
>> 
>> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code per test UI requirements.
>> 
>> Usage:
>> 
>> PassFailJFrame.builder()
>>                       .title("Test Instructions")
>>                       .instructions(INSTRUCTIONS)
>>                       .rows(int)
>>                       .columns(int)
>>                       .testUI(<TestClass::createAndShowUI>)
>>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>>                       .build()
>>                       .awaitAndCheck();
>> 
>> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
>> 
>> @aivanov-jdk has demonstrated custom test UI positioning in this PR: 
>> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed errorenous check

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1277:

> 1275:                                                 + "nor a list of test windows "
> 1276:                                                 + "has been provided");
> 1277:             }

@aivanov-jdk Running into exception when this check is added here. I believe this check needs to be done after `positionWindows` is assigned.
  
And since this check is already in-place in [validate()](https://github.com/openjdk/jdk/blob/418bb42b95b177f5f31f756054d0dd83740c6686/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L1475C1-L1479C18) , I'm removing it from here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21023#discussion_r1761989555

From djgredler at gmail.com  Mon Sep 16 22:51:12 2024
From: djgredler at gmail.com (Daniel Gredler)
Date: Tue, 17 Sep 2024 00:51:12 +0200
Subject: Graphics2D.drawString() fails with Font derived from rotated +
 scaled AffineTransform
In-Reply-To: <CAPA+ug6vzkS1VY==A-pQQCX4Mf6m7Jv6vm4LSCZMTixJwyhTHg@mail.gmail.com>
References: <CAPA+ug5PSdU4_pMJ+vMRhs72-CErf-qKdwjjbiTwC2iXp3HWAg@mail.gmail.com>
 <CAPA+ug6vzkS1VY==A-pQQCX4Mf6m7Jv6vm4LSCZMTixJwyhTHg@mail.gmail.com>
Message-ID: <CAPA+ug4bbOyY4mUjD5PDYGeHXg8ezxoRGwf8MFjhjuGnkZ0UVQ@mail.gmail.com>

Hi all,

A bug number was issued for this issue [1], and I've created the
corresponding PR [2]. Can a couple of reviewers spend a few cycles
reviewing it? The fix is relatively simple, I think the main questions are
more stylistic / cultural (simplicity vs. performance, compatibility
constraints).

Thanks!

Daniel

[1] https://bugs.openjdk.org/browse/JDK-8339974
[2] https://github.com/openjdk/jdk/pull/20993


On Tue, Sep 10, 2024 at 1:56?AM Daniel Gredler <djgredler at gmail.com> wrote:

> Hi all,
>
> I've done a little more digging, and there is indeed a deeper bug in
> TextLayout.getOutline(AffineTransform), where the transformation is applied
> too early (before the layout path applies its mapping).
>
> There are two uses of TextLayout.getOutline(AffineTransform): the first
> one, triggered via a simple Graphics2D.drawString( ) was the one I ran
> into; the second one requires the use of a transformed font with a
> PSPrinterJob. Both are broken, so it doesn't really make sense to work
> around the TextLayout issue for the first scenario, but leave the second
> scenario broken.
>
> The deeper fix, including two test classes verifying that both scenarios
> were broken and now work correctly, is available on GitHub [1]. I plan to
> submit a PR as soon as I have a final bug ID from my web bug submission.
>
> Two points I'd like some feedback on:
> 1. I've changed the signature of method
> TextLine.getOutline(AffineTransform), to just TextLine.getOutline( ); I'm
> assuming this is OK since TextLine is a package-private class?
> 2. I've added a fast path in TextLayout.getOutline(AffineTransform) to
> transform the shape in place if it is a GeneralPath (it should usually be,
> and avoids an extra Shape copy vs. the current code); does this look OK? Or
> should the code be kept completely generic and a copy always made? I had a
> look at just changing the variable type from Shape to GeneralPath, but the
> change started to cascade into a few other classes and I pulled the plug.
>
> Take care,
>
> Daniel
>
> [1]
> https://github.com/openjdk/jdk/compare/master...gredler:jdk:draw-string-bug-2
>
>
>
> On Thu, Sep 5, 2024 at 8:30?PM Daniel Gredler <djgredler at gmail.com> wrote:
>
>> Hi all,
>>
>> I've run into a bug [1] in the drawing of strings via
>> Graphics2D.drawString(), when used with a Font derived from a rotated +
>> scaled AffineTransform. If the AffineTransform scaling is small, the text
>> draws correctly. But if the scale is too large, the text does not draw. [3]
>>
>> It looks like it's an effect of the OutlineTextRenderer.THRESHHOLD; text
>> larger than this threshold is sent to the OutlineTextRenderer and fails to
>> draw. The fix [2] seems to be to apply the position translation
>> transformation *after* the text outline shape is created, rather than
>> passing it into TextLayout.getOutline(). However, I do not know if this is
>> the correct fix, or if it is just a workaround to a deeper issue in
>> TextLayout.getOutline(), which in theory might need to wait to apply the
>> provided translation until after the layout path has had a chance to map to
>> user space.
>>
>> Can someone familiar with this code comment on whether the proposed fix
>> is the correct fix, or whether deeper surgery is needed in
>> TextLayout.getOutline()?
>>
>> My other small worry with the current fix [2] is that it creates an extra
>> copy of the Shape object, so it's going to allocate a bit more memory than
>> the current implementation. Not sure if there's a better way to update the
>> Shape in-place.
>>
>> Take care,
>>
>> Daniel
>>
>> ---
>>
>> [1] Oracle internal review ID 9077538, no public bug ID yet
>> [2]
>> https://github.com/openjdk/jdk/compare/master...gredler:jdk:draw-string-bug
>> [3]
>> import java.awt.Color;
>> import java.awt.Font;
>> import java.awt.Graphics2D;
>> import java.awt.geom.AffineTransform;
>> import java.awt.image.BufferedImage;
>> import java.io.File;
>>
>> import javax.imageio.ImageIO;
>>
>> /**
>>  * <p>The "TEST 2" text does not draw. NOTE: Reducing the AffineTransform
>> scale
>>  * from 12 to 10 seems to allow it to draw?!?
>>  *
>>  * <p>Oracle internal review ID : 9077538
>>  */
>> public class DrawStringTest {
>>
>>     public static void main(String[] args) throws Exception {
>>
>>         AffineTransform at = AffineTransform.getRotateInstance(3 *
>> Math.PI / 2);
>>         at.scale(12, 12);
>>
>>         Font font1 = new Font("SansSerif", Font.PLAIN, 10);
>>         Font font2 = font1.deriveFont(at);
>>
>>         BufferedImage image = new BufferedImage(500, 500,
>> BufferedImage.TYPE_BYTE_GRAY);
>>         Graphics2D g2d = image.createGraphics();
>>         g2d.setColor(Color.WHITE);
>>         g2d.fillRect(0, 0, image.getWidth(), image.getHeight());
>>         g2d.setColor(Color.BLACK);
>>         g2d.setFont(font1);
>>         g2d.drawString("TEST 1", 200, 400); // draws text
>>         g2d.setFont(font2);
>>         g2d.drawString("TEST 2", 200, 400); // does not draw text
>>         g2d.dispose();
>>
>>         ImageIO.write(image, "png", new File("test.png"));
>>     }
>>
>> }
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20240917/f1fc15aa/attachment.htm>

From honkar at openjdk.org  Mon Sep 16 22:59:35 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 16 Sep 2024 22:59:35 GMT
Subject: RFR: JDK-8339962 : Open source AWT TextField tests - Set1 [v3]
In-Reply-To: <v6evWDMdJ5taNxUxxPD-onH6DfUhWGyWSW69gyb87fo=.380962ba-cc65-403e-8337-33186b5d9e29@github.com>
References: <v6evWDMdJ5taNxUxxPD-onH6DfUhWGyWSW69gyb87fo=.380962ba-cc65-403e-8337-33186b5d9e29@github.com>
Message-ID: <Fog0s8VOThwYsgzPpN1mQaUXJVLVEOxG2tcDr5Vritc=.eac43e4b-7862-4154-93eb-6cefd9d95514@github.com>

> Following test are open-sourced.
> 
> 1. 	test/jdk/java/awt/Label/ContainerValidateTest.java - Automated
> 2. 	test/jdk/java/awt/TextField/SetEchoCharTest.java - Automated
> 3. 	test/jdk/java/awt/TextField/SetEchoCharWordOpsTest.java - PassFailJFrame manual test

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  typo fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21005/files
  - new: https://git.openjdk.org/jdk/pull/21005/files/fa890150..d3711cb2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21005&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21005&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21005.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21005/head:pull/21005

PR: https://git.openjdk.org/jdk/pull/21005

From kizune at openjdk.org  Mon Sep 16 23:20:26 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 16 Sep 2024 23:20:26 GMT
Subject: RFR: 8339902: Open source couple TextField related tests
Message-ID: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>

Clean up and open source five TextField related tests: 
java/awt/TextField/CaretPositionTest;
java/awt/TextField/SetBoundsTest;
java/awt/TextField/SetEchoCharTest4;
java/awt/TextField/SetPasswordTest;
java/awt/TextField/ZeroEchoCharTest

-------------

Commit messages:
 - 8339902: Open source couple TextField related tests

Changes: https://git.openjdk.org/jdk/pull/21026/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21026&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339902
  Stats: 527 lines in 5 files changed: 527 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21026.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21026/head:pull/21026

PR: https://git.openjdk.org/jdk/pull/21026

From honkar at openjdk.org  Mon Sep 16 23:28:05 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 16 Sep 2024 23:28:05 GMT
Subject: RFR: 8339902: Open source couple TextField related tests
In-Reply-To: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
Message-ID: <PcybwH0YzyZHIK-G_hmuVbmtybRNJdRlrsbK5jz_NGw=.c25a5aa8-f05e-4b60-af7c-7f37cc751735@github.com>

On Mon, 16 Sep 2024 23:02:58 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and open source five TextField related tests: 
> java/awt/TextField/CaretPositionTest;
> java/awt/TextField/SetBoundsTest;
> java/awt/TextField/SetEchoCharTest4;
> java/awt/TextField/SetPasswordTest;
> java/awt/TextField/ZeroEchoCharTest

Changes requested by honkar (Reviewer).

test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java line 51:

> 49:     private Dimension size;
> 50:     String text = "12 45 789";
> 51:     private static int position = -1;

Since position var is accessed in 2 different threads, should it be changed to volatile?

test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java line 60:

> 58:             test.test();
> 59:             if (position != 9) {
> 60:                 System.err.println("Caret position should be at the end of the string");

Should be throw new RuntimeException("Caret position should be at the end of the string") ??

-------------

PR Review: https://git.openjdk.org/jdk/pull/21026#pullrequestreview-2307988198
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762076251
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762076497

From honkar at openjdk.org  Mon Sep 16 23:38:05 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 16 Sep 2024 23:38:05 GMT
Subject: RFR: 8339902: Open source couple TextField related tests
In-Reply-To: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
Message-ID: <S-98_Y3GTFGWtjU3UXiX8YbpWxVIb4HR-G9VYG-nHOQ=.b7335007-6187-447a-b8ef-589e2a3ff7e2@github.com>

On Mon, 16 Sep 2024 23:02:58 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and open source five TextField related tests: 
> java/awt/TextField/CaretPositionTest;
> java/awt/TextField/SetBoundsTest;
> java/awt/TextField/SetEchoCharTest4;
> java/awt/TextField/SetPasswordTest;
> java/awt/TextField/ZeroEchoCharTest

Changes requested by honkar (Reviewer).

Changes requested by honkar (Reviewer).

test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java line 53:

> 51:     private static int position = -1;
> 52: 
> 53:     public static void main(String[] args) throws InterruptedException,

Can be simplified to throw generic Exception
Suggestion:

    public static void main(String[] args) throws Exception

test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java line 80:

> 78:     }
> 79: 
> 80:     public void test() throws AWTException, InterruptedException,

Suggestion:

    public void test() throws Exception,

test/jdk/java/awt/TextField/SetBoundsTest/SetBoundsTest.java line 39:

> 37: /*
> 38:  * @test
> 39:  * @bug 6198290, 6277332

Test fails due to comma between bugIDs - Invalid or unrecognized bugid: 6198290

test/jdk/java/awt/TextField/SetBoundsTest/SetBoundsTest.java line 41:

> 39:  * @bug 6198290, 6277332
> 40:  * @summary TextField painting is broken when placed on a Scrollpane, XToolkit
> 41:  * @library /open/test/jdk/java/awt/regtesthelpers

Library path needs to be updated
Suggestion:

 * @library /java/awt/regtesthelpers

-------------

PR Review: https://git.openjdk.org/jdk/pull/21026#pullrequestreview-2307989995
PR Review: https://git.openjdk.org/jdk/pull/21026#pullrequestreview-2307995012
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762078525
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762078021
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762082561
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762083157

From honkar at openjdk.org  Mon Sep 16 23:47:04 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 16 Sep 2024 23:47:04 GMT
Subject: RFR: 8339902: Open source couple TextField related tests
In-Reply-To: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
Message-ID: <x0lJWlfu11yvCcQOIHO8NnmF5NCxrky8D3CZj2d20rc=.17731a82-2755-407f-a828-78cf122b1144@github.com>

On Mon, 16 Sep 2024 23:02:58 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and open source five TextField related tests: 
> java/awt/TextField/CaretPositionTest;
> java/awt/TextField/SetBoundsTest;
> java/awt/TextField/SetEchoCharTest4;
> java/awt/TextField/SetPasswordTest;
> java/awt/TextField/ZeroEchoCharTest

test/jdk/java/awt/TextField/SetEchoCharTest4/SetEchoCharTest4.java line 37:

> 35:  * @bug 4226580
> 36:  * @summary TextField with echoChar add+remove+add seems to be broken
> 37:  * @library /open/test/jdk/java/awt/regtesthelpers

Same here. Library path needs to be updated and applicable to other tests as well.

test/jdk/java/awt/TextField/SetEchoCharTest4/SetEchoCharTest4.java line 75:

> 73:         add(tf3);
> 74:         add(b);
> 75:         setVisible(true);

Not required here as PassFailJFrame handles setVisible(true) for test frame as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762085509
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762088145

From kizune at openjdk.org  Mon Sep 16 23:55:52 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 16 Sep 2024 23:55:52 GMT
Subject: RFR: 8339902: Open source couple TextField related tests [v2]
In-Reply-To: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
Message-ID: <lxyoB7C4Oh5R4YkI_wqsvs49QS2XxdWJhpGU3A0-n6c=.955666b1-dbb9-4de4-9bc4-f359b4f9d065@github.com>

> Clean up and open source five TextField related tests: 
> java/awt/TextField/CaretPositionTest;
> java/awt/TextField/SetBoundsTest;
> java/awt/TextField/SetEchoCharTest4;
> java/awt/TextField/SetPasswordTest;
> java/awt/TextField/ZeroEchoCharTest

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Update test/jdk/java/awt/TextField/SetBoundsTest/SetBoundsTest.java
  
  Co-authored-by: Harshitha Onkar <harshitha.onkar at oracle.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21026/files
  - new: https://git.openjdk.org/jdk/pull/21026/files/067869fc..4bbc9b0a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21026&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21026&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21026.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21026/head:pull/21026

PR: https://git.openjdk.org/jdk/pull/21026

From honkar at openjdk.org  Mon Sep 16 23:56:07 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 16 Sep 2024 23:56:07 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v2]
In-Reply-To: <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
 <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
Message-ID: <i5ErTEShTqZfVywFvJU7Q4C3PinFwnUkSMxVG6ZangE=.e4e48e62-2541-4b42-91c8-446df9ed8c0c@github.com>

On Mon, 16 Sep 2024 21:38:36 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>> 
>> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
>> 
>> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code as per test UI requirements.
>> 
>> Usage:
>> 
>> PassFailJFrame.builder()
>>                       .title("Test Instructions")
>>                       .instructions(INSTRUCTIONS)
>>                       .rows(int)
>>                       .columns(int)
>>                       .testUI(<TestClass::createAndShowUI>)
>>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>>                       .build()
>>                       .awaitAndCheck();
>> 
>> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
>> 
>> @aivanov-jdk has demonstrated custom test UI positioning in this PR: 
>> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed errorenous check

@azvegint You may want to review this PR, as it is related to https://github.com/openjdk/jdk/pull/15721

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21023#issuecomment-2354228824

From kizune at openjdk.org  Tue Sep 17 00:01:07 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 17 Sep 2024 00:01:07 GMT
Subject: RFR: 8339902: Open source couple TextField related tests [v2]
In-Reply-To: <PcybwH0YzyZHIK-G_hmuVbmtybRNJdRlrsbK5jz_NGw=.c25a5aa8-f05e-4b60-af7c-7f37cc751735@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
 <PcybwH0YzyZHIK-G_hmuVbmtybRNJdRlrsbK5jz_NGw=.c25a5aa8-f05e-4b60-af7c-7f37cc751735@github.com>
Message-ID: <6pMx2nU5WOFAvNaKmOQkllEsYeCDgTCOjAMluwZ2X4U=.ae5bc66f-3f6b-4ad8-86a6-e004d481bf83@github.com>

On Mon, 16 Sep 2024 23:25:24 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/jdk/java/awt/TextField/SetBoundsTest/SetBoundsTest.java
>>   
>>   Co-authored-by: Harshitha Onkar <harshitha.onkar at oracle.com>
>
> test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java line 60:
> 
>> 58:             test.test();
>> 59:             if (position != 9) {
>> 60:                 System.err.println("Caret position should be at the end of the string");
> 
> Should be throw new RuntimeException("Caret position should be at the end of the string") ??

Sure.

> test/jdk/java/awt/TextField/SetBoundsTest/SetBoundsTest.java line 39:
> 
>> 37: /*
>> 38:  * @test
>> 39:  * @bug 6198290, 6277332
> 
> Test fails due to comma between bugIDs - Invalid or unrecognized bugid: 6198290

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762097985
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762098093

From kizune at openjdk.org  Tue Sep 17 00:04:06 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 17 Sep 2024 00:04:06 GMT
Subject: RFR: 8339902: Open source couple TextField related tests [v2]
In-Reply-To: <x0lJWlfu11yvCcQOIHO8NnmF5NCxrky8D3CZj2d20rc=.17731a82-2755-407f-a828-78cf122b1144@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
 <x0lJWlfu11yvCcQOIHO8NnmF5NCxrky8D3CZj2d20rc=.17731a82-2755-407f-a828-78cf122b1144@github.com>
Message-ID: <Jef62ez4fiLmw6Xh4ukFnW-0Wai9yle-EY0MblAXslM=.ca76af62-f6ff-4e73-9438-2a23577d2ac7@github.com>

On Mon, 16 Sep 2024 23:43:39 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/jdk/java/awt/TextField/SetBoundsTest/SetBoundsTest.java
>>   
>>   Co-authored-by: Harshitha Onkar <harshitha.onkar at oracle.com>
>
> test/jdk/java/awt/TextField/SetEchoCharTest4/SetEchoCharTest4.java line 75:
> 
>> 73:         add(tf3);
>> 74:         add(b);
>> 75:         setVisible(true);
> 
> Not required here as PassFailJFrame handles setVisible(true) for test frame as well.

Ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762099352

From kizune at openjdk.org  Tue Sep 17 00:11:30 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 17 Sep 2024 00:11:30 GMT
Subject: RFR: 8339902: Open source couple TextField related tests [v3]
In-Reply-To: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
Message-ID: <TDHbjRG7l_MXtuM_mmfkBh-HlMdb0q-RlknG8YbgCaI=.e0fb8caa-2fed-4736-bab6-f036eea4eb7f@github.com>

> Clean up and open source five TextField related tests: 
> java/awt/TextField/CaretPositionTest;
> java/awt/TextField/SetBoundsTest;
> java/awt/TextField/SetEchoCharTest4;
> java/awt/TextField/SetPasswordTest;
> java/awt/TextField/ZeroEchoCharTest

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Some fixes based on review

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21026/files
  - new: https://git.openjdk.org/jdk/pull/21026/files/4bbc9b0a..0dce88fc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21026&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21026&range=01-02

  Stats: 6 lines in 5 files changed: 0 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/21026.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21026/head:pull/21026

PR: https://git.openjdk.org/jdk/pull/21026

From kizune at openjdk.org  Tue Sep 17 00:11:30 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 17 Sep 2024 00:11:30 GMT
Subject: RFR: 8339902: Open source couple TextField related tests [v3]
In-Reply-To: <S-98_Y3GTFGWtjU3UXiX8YbpWxVIb4HR-G9VYG-nHOQ=.b7335007-6187-447a-b8ef-589e2a3ff7e2@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
 <S-98_Y3GTFGWtjU3UXiX8YbpWxVIb4HR-G9VYG-nHOQ=.b7335007-6187-447a-b8ef-589e2a3ff7e2@github.com>
Message-ID: <q-xDROVNHFuFpQHUjWiyMV3KbxQ2dCEt8HRcuu73g8A=.63cd13da-20e5-49f0-abb1-782c952ead32@github.com>

On Mon, 16 Sep 2024 23:27:34 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Some fixes based on review
>
> test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java line 80:
> 
>> 78:     }
>> 79: 
>> 80:     public void test() throws AWTException, InterruptedException,
> 
> Suggestion:
> 
>     public void test() throws Exception,

I prefer to list all the exceptions i am intentionally do not catch.

> test/jdk/java/awt/TextField/SetEchoCharTest4/SetEchoCharTest4.java line 37:
> 
>> 35:  * @bug 4226580
>> 36:  * @summary TextField with echoChar add+remove+add seems to be broken
>> 37:  * @library /open/test/jdk/java/awt/regtesthelpers
> 
> Same here. Library path needs to be updated and applicable to other tests as well.

Fixed here and in all other places.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762103428
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762103716

From honkar at openjdk.org  Tue Sep 17 00:18:04 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 17 Sep 2024 00:18:04 GMT
Subject: RFR: 8340015: Open source several AWT focus tests - series 7
In-Reply-To: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>
References: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>
Message-ID: <weNRPgZOQ_AYynWRXFTBh_HQj99u6isqM46xY2sutkU=.f9d89723-8193-482d-8a1a-3570f05db4c3@github.com>

On Mon, 16 Sep 2024 04:16:01 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few AWT focus tests

test/jdk/java/awt/Focus/MinimizeNonfocusableWindowTest.java line 57:

> 55:         if ("sun.awt.motif.MToolkit".equals(Toolkit.getDefaultToolkit().getClass().getName())) {
> 56:             return;
> 57:         }

Should the MToolkit check be removed?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1762107648

From kizune at openjdk.org  Tue Sep 17 00:23:35 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 17 Sep 2024 00:23:35 GMT
Subject: RFR: 8339902: Open source couple TextField related tests [v4]
In-Reply-To: <PcybwH0YzyZHIK-G_hmuVbmtybRNJdRlrsbK5jz_NGw=.c25a5aa8-f05e-4b60-af7c-7f37cc751735@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
 <PcybwH0YzyZHIK-G_hmuVbmtybRNJdRlrsbK5jz_NGw=.c25a5aa8-f05e-4b60-af7c-7f37cc751735@github.com>
Message-ID: <88o9xlcbpRZHjAfMaK0LQq7lneh3Nz4fG5SV0iCF3F8=.21f4bba3-8e1a-4e14-baf8-b9c6129818fa@github.com>

On Mon, 16 Sep 2024 23:25:02 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make varible volatile
>
> test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java line 51:
> 
>> 49:     private Dimension size;
>> 50:     String text = "12 45 789";
>> 51:     private static int position = -1;
> 
> Since position var is accessed in 2 different threads, should it be changed to volatile?

Can be.

> test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java line 53:
> 
>> 51:     private static int position = -1;
>> 52: 
>> 53:     public static void main(String[] args) throws InterruptedException,
> 
> Can be simplified to throw generic Exception
> Suggestion:
> 
>     public static void main(String[] args) throws Exception

Same, i prefer to list all checked exceptions that i intentionally do not catch - makes it safer to modify if needed later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762109327
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762110230

From kizune at openjdk.org  Tue Sep 17 00:23:35 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 17 Sep 2024 00:23:35 GMT
Subject: RFR: 8339902: Open source couple TextField related tests [v4]
In-Reply-To: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
Message-ID: <dk9_DKqT-bltDXfoh9AnyPrF009MjQ8JOzPaYpkEGU4=.b4fe9afb-6ffd-4026-b743-72c95448648f@github.com>

> Clean up and open source five TextField related tests: 
> java/awt/TextField/CaretPositionTest;
> java/awt/TextField/SetBoundsTest;
> java/awt/TextField/SetEchoCharTest4;
> java/awt/TextField/SetPasswordTest;
> java/awt/TextField/ZeroEchoCharTest

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Make varible volatile

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21026/files
  - new: https://git.openjdk.org/jdk/pull/21026/files/0dce88fc..10bf5fe3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21026&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21026&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21026.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21026/head:pull/21026

PR: https://git.openjdk.org/jdk/pull/21026

From honkar at openjdk.org  Tue Sep 17 00:33:05 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 17 Sep 2024 00:33:05 GMT
Subject: RFR: 8339902: Open source couple TextField related tests [v4]
In-Reply-To: <dk9_DKqT-bltDXfoh9AnyPrF009MjQ8JOzPaYpkEGU4=.b4fe9afb-6ffd-4026-b743-72c95448648f@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
 <dk9_DKqT-bltDXfoh9AnyPrF009MjQ8JOzPaYpkEGU4=.b4fe9afb-6ffd-4026-b743-72c95448648f@github.com>
Message-ID: <EMMJx1qECXRtBtXW02ivs5zGNhyQBXZJpKR11v3iUG4=.e08efcc6-07e0-4866-b9b1-5e2616625a45@github.com>

On Tue, 17 Sep 2024 00:23:35 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Clean up and open source five TextField related tests: 
>> java/awt/TextField/CaretPositionTest;
>> java/awt/TextField/SetBoundsTest;
>> java/awt/TextField/SetEchoCharTest4;
>> java/awt/TextField/SetPasswordTest;
>> java/awt/TextField/ZeroEchoCharTest
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make varible volatile

LGTM other than https://github.com/openjdk/jdk/pull/21026/files#r1762115939

test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java line 51:

> 49:     private Dimension size;
> 50:     String text = "12 45 789";
> 51:     private volatile static int position = -1;

blessed modifier order

Suggestion:

    private static volatile int position = -1;

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21026#pullrequestreview-2308031741
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762115939

From tr at openjdk.org  Tue Sep 17 03:42:09 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 17 Sep 2024 03:42:09 GMT
Subject: RFR: 8326027: [TEST_BUG]Comparing buffered images  of white
 background frame fails in Mac
In-Reply-To: <I_SUvpNxGxBWiGFPjuAML8-NA71uTLmtc5h8GXx8opE=.5943ad4e-938c-4678-aed0-29dfa2a447c7@github.com>
References: <k_dehNjnRND72N061bx31c9YclyJhyL2hK1NHPJcLkE=.5a4fd4d5-ee80-4db0-bae4-4008360ead28@github.com>
 <gCFzYGg4FuXFwadvTZE-T5yHMO8nvCOKY7ps_si5xKE=.72e17254-8740-4444-aa6c-4eed86de65ce@github.com>
 <qNZO9RhbyJWm_TkeB02gQnQ_w8T9FZaVriftvUC6Hv0=.b9b97880-6763-48d9-839d-6461a4ff8f51@github.com>
 <0FKvhBMfDuyvzus_Q_sjhmFB02FPipKX9p54KNy6w0k=.cf25ba18-9c25-4079-aeae-c2ffeaf0eafe@github.com>
 <gYvarNYPdKz4YIvCq2MNVxQqkmmp4c2PJT_ALUCHTII=.47541591-c627-4d2d-9866-46bdcb35d30b@github.com>
 <9EEL4ctBHQI73B_nmGvnucR4LMefzbGCpSUd1URgr8o=.cc576bd9-025a-4aec-83e1-f66388de3629@github.com>
 <I_SUvpNxGxBWiGFPjuAML8-NA71uTLmtc5h8GXx8opE=.5943ad4e-938c-4678-aed0-29dfa2a447c7@github.com>
Message-ID: <7Tr-UybQqD265bWlPZk_gE58Pjyd55TKrlYSFs10pDw=.42b04997-431a-471e-9191-6887ae5dd67a@github.com>

On Mon, 9 Sep 2024 18:45:45 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > > This is why I asked the question: does the comparison remain accurate without the need for tolerance if you use `Robot.createMultiResolutionScreenCapture` and use the highest resolution from the returned multi-resolution image?
> > 
> > 
> > I couldn't reproduce the issue neither with `Robot.createMultiResolutionScreenCapture` nor with `Robot.createScreenCapture` since the failure occurs intermittently, not able to say anything about using `Robot.createMultiResolutionScreenCapture` instead of `Robot.createScreenCapture` .
> 
> According to your report in JBS, the white color is not exactly white: `0xFFEE'EEEE`. White color has value of `0xFFFF'FFFF`.
> 
> However, it's also common on Macs (because of color profile applied?), I mean that the captured color value is the same as the value used for filling.
> 
> At the same time, I expect the color is the same across the entire frame surface. What we see is that there are variations. I wonder how many pixels on the image have different color, other than the first pixel.

I guess the number pixels that doesn't match might vary, can't be constant. We can get that from the failure image though, but since the issue is intermittent, can't conclude exactly.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20760#issuecomment-2354441837

From kizune at openjdk.org  Tue Sep 17 03:46:51 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 17 Sep 2024 03:46:51 GMT
Subject: RFR: 8339902: Open source couple TextField related tests [v5]
In-Reply-To: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
Message-ID: <_rmMkDVFIdATVcs--DIJETAbl_WIutknG8WhzwS7IFM=.532bc05c-290c-40e9-9933-35e5f00ec8ba@github.com>

> Clean up and open source five TextField related tests: 
> java/awt/TextField/CaretPositionTest;
> java/awt/TextField/SetBoundsTest;
> java/awt/TextField/SetEchoCharTest4;
> java/awt/TextField/SetPasswordTest;
> java/awt/TextField/ZeroEchoCharTest

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Fixing typo in thrown keyword;
  Removed windows platform because on modern windows platform the cursor position does always return 0 when all text selected.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21026/files
  - new: https://git.openjdk.org/jdk/pull/21026/files/10bf5fe3..e4804501

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21026&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21026&range=03-04

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21026.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21026/head:pull/21026

PR: https://git.openjdk.org/jdk/pull/21026

From psadhukhan at openjdk.org  Tue Sep 17 04:06:52 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 17 Sep 2024 04:06:52 GMT
Subject: RFR: 8340015: Open source several AWT focus tests - series 7 [v2]
In-Reply-To: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>
References: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>
Message-ID: <PZkBO7l5nzakzHctnjgNtYJkJ2Utibr9LX-gxd7dw30=.0df815ed-8837-46ef-8fcd-7efbde5fcccd@github.com>

> Opensource few AWT focus tests

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  MToolkit removed

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21008/files
  - new: https://git.openjdk.org/jdk/pull/21008/files/b7ccd8af..a385e767

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21008&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21008&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21008.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21008/head:pull/21008

PR: https://git.openjdk.org/jdk/pull/21008

From psadhukhan at openjdk.org  Tue Sep 17 04:06:53 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 17 Sep 2024 04:06:53 GMT
Subject: RFR: 8340015: Open source several AWT focus tests - series 7 [v2]
In-Reply-To: <weNRPgZOQ_AYynWRXFTBh_HQj99u6isqM46xY2sutkU=.f9d89723-8193-482d-8a1a-3570f05db4c3@github.com>
References: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>
 <weNRPgZOQ_AYynWRXFTBh_HQj99u6isqM46xY2sutkU=.f9d89723-8193-482d-8a1a-3570f05db4c3@github.com>
Message-ID: <vWbjdyeMKHRTFxdmcuGaRxD6gpEwZwtl-ZaJumTN5-w=.2cb05c03-9973-485a-8bf8-122c829e4464@github.com>

On Tue, 17 Sep 2024 00:15:14 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   MToolkit removed
>
> test/jdk/java/awt/Focus/MinimizeNonfocusableWindowTest.java line 57:
> 
>> 55:         if ("sun.awt.motif.MToolkit".equals(Toolkit.getDefaultToolkit().getClass().getName())) {
>> 56:             return;
>> 57:         }
> 
> @prsadhuk MToolkit is obsolete and can be removed.
> [JDK-8279337](https://bugs.openjdk.org/browse/JDK-8279337) - The MToolkit is still referenced in a few places

ok removed...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1762251439

From kizune at openjdk.org  Tue Sep 17 04:07:53 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 17 Sep 2024 04:07:53 GMT
Subject: RFR: 8339902: Open source couple TextField related tests [v6]
In-Reply-To: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
Message-ID: <vzgFoKDCekHILA2r2HL0bQZRWX2xegFkXzTKf4YNOPY=.3d2b3493-c587-4689-b06f-576c55170631@github.com>

> Clean up and open source five TextField related tests: 
> java/awt/TextField/CaretPositionTest;
> java/awt/TextField/SetBoundsTest;
> java/awt/TextField/SetEchoCharTest4;
> java/awt/TextField/SetPasswordTest;
> java/awt/TextField/ZeroEchoCharTest

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Update test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java
  
  Co-authored-by: Harshitha Onkar <harshitha.onkar at oracle.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21026/files
  - new: https://git.openjdk.org/jdk/pull/21026/files/e4804501..a9e439a4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21026&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21026&range=04-05

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21026.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21026/head:pull/21026

PR: https://git.openjdk.org/jdk/pull/21026

From abhiscxk at openjdk.org  Tue Sep 17 04:35:48 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 17 Sep 2024 04:35:48 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests
Message-ID: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>

Few AWT MenuItem related tests are converted from applet to manual and moved to open.

-------------

Commit messages:
 - MenuItem test moved to open

Changes: https://git.openjdk.org/jdk/pull/21029/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339984
  Stats: 461 lines in 5 files changed: 461 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From azvegint at openjdk.org  Tue Sep 17 07:50:06 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 17 Sep 2024 07:50:06 GMT
Subject: RFR: 8340007: Refactor KeyEvent/FunctionKeyTest.java
In-Reply-To: <TT5b8Kyty70NTNh94YUfKY1lKtxbBe_Niw9X3HmSBTk=.ab198caa-c838-4336-9e07-470e607ac781@github.com>
References: <TT5b8Kyty70NTNh94YUfKY1lKtxbBe_Niw9X3HmSBTk=.ab198caa-c838-4336-9e07-470e607ac781@github.com>
Message-ID: <eWJCdjpP4GIztI0nhtsDOj-gV4yaJJ0l0A5abQ0ujDE=.66068e07-9d80-42eb-bb21-5b6e26c29ecc@github.com>

On Mon, 16 Sep 2024 09:55:19 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> This changeset refactors `java/awt/event/KeyEvent/FunctionKeyTest.java`.
> 
> Key changes:
> 
> - Use `CyclicBarrier` to verify whether a key is pressed and released;
> - Use `CountDownLatch` for frame activation;
> - Ensure thread-safety for keeping thrown exceptions.
> 
> Other changes:
> 
> - Made `FunctionKeyTester` a nested class inside `FunctionKeyTest`;
> - Used constants for the key events rather than magic numbers.
> 
> I ran the updated test a few times with `JTREG=REPEAT_COUNT=20`, the test has passed.
> 
> The updated test executes somewhat quicker than the old one.
> 
> @azvegint, you may want to take a look.

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21013#pullrequestreview-2308671159

From azvegint at openjdk.org  Tue Sep 17 08:41:05 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 17 Sep 2024 08:41:05 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v2]
In-Reply-To: <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
 <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
Message-ID: <LgXx8_EObRzM7xJ4g39Lv_o0CLKQs0b0EiiB2sdjsO0=.b0b1795f-6934-459a-b6a3-80ec0f88b0ff@github.com>

On Mon, 16 Sep 2024 21:38:36 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>> 
>> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
>> 
>> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code as per test UI requirements.
>> 
>> Usage:
>> 
>> PassFailJFrame.builder()
>>                       .title("Test Instructions")
>>                       .instructions(INSTRUCTIONS)
>>                       .rows(int)
>>                       .columns(int)
>>                       .testUI(<TestClass::createAndShowUI>)
>>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>>                       .build()
>>                       .awaitAndCheck();
>> 
>> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
>> 
>> @aivanov-jdk has demonstrated custom test UI positioning in this PR: 
>> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed errorenous check

I think that this can be improved by adding some predefined positionTestUI functions, like in the #15721 (we can borrow them from it).
For example, consider adding `PositionWindowsLib.java`(or maybe a nested public static class for `PassFailJFrame` to avoid extra `@build` clause), which has functions something like 

.positionTestUI(PositionWindowsLib::positionHH) // aka TwoWindowsHH.positionTestUI
.positionTestUI(PositionWindowsLib::positionHV) // aka TwoWindowsHV.positionTestUI
...


It'll be easier for a test developer to just take a ready-to-use function (which in most cases will be the same across multiple tests),
and it'll be easier for the test reviewer because there will be less code to review.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21023#pullrequestreview-2308800489

From aivanov at openjdk.org  Tue Sep 17 09:24:06 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 09:24:06 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v2]
In-Reply-To: <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
 <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
Message-ID: <Mzuqzsva8Dxf95vmXPyBtxAsnbLvg77V9k-S3miR4_g=.f7a89e7a-59b5-4f3b-8335-b14b7564ff30@github.com>

On Mon, 16 Sep 2024 21:38:36 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>> 
>> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
>> 
>> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code as per test UI requirements.
>> 
>> Usage:
>> 
>> PassFailJFrame.builder()
>>                       .title("Test Instructions")
>>                       .instructions(INSTRUCTIONS)
>>                       .rows(int)
>>                       .columns(int)
>>                       .testUI(<TestClass::createAndShowUI>)
>>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>>                       .build()
>>                       .awaitAndCheck();
>> 
>> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
>> 
>> @aivanov-jdk has demonstrated custom test UI positioning in this PR: 
>> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed errorenous check

Marked as reviewed by aivanov (Reviewer).

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1264:

> 1262:          * @throws IllegalStateException if the {@code positionWindows} field
> 1263:          *              is already set, or if neither a windows list creator
> 1264:          *              nor a list of test windows has been provided

Suggestion:

         * @throws IllegalStateException if the {@code positionWindows} field
         *              is already set

-------------

PR Review: https://git.openjdk.org/jdk/pull/21023#pullrequestreview-2309011043
PR Review Comment: https://git.openjdk.org/jdk/pull/21023#discussion_r1762784996

From aivanov at openjdk.org  Tue Sep 17 09:27:07 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 09:27:07 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v2]
In-Reply-To: <FFSo1RNt9a8IsPu67AEA7Fd389gogqtTmSSeeKmmg1k=.7cfc4b77-ed2a-430d-9915-2e6c53072049@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
 <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
 <FFSo1RNt9a8IsPu67AEA7Fd389gogqtTmSSeeKmmg1k=.7cfc4b77-ed2a-430d-9915-2e6c53072049@github.com>
Message-ID: <AmCxvtHchqhtzixaRfy8q2GSOZvvidHw1i5IURk22bw=.9c94e161-58e6-452b-96bb-d4c13adbfee0@github.com>

On Mon, 16 Sep 2024 21:31:24 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed errorenous check
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1277:
> 
>> 1275:                                                 + "nor a list of test windows "
>> 1276:                                                 + "has been provided");
>> 1277:             }
> 
> @aivanov-jdk Running into exception when this check is added here. I believe Builder's windowListCreator and testWindows are not assigned yet at this stage.
>   
> And since this check is already in-place here: [validate()](https://github.com/openjdk/jdk/blob/418bb42b95b177f5f31f756054d0dd83740c6686/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L1475C1-L1479C18), I'm removing it from positionTestUI().

The condition should've been `&&`: the error message is correct, the exception was supposed to be thrown if both `windowListCreator` and `testWindows` is null. The condition with `||` is always `true`.

Yet I agree to remove this condition from here as it enforces the order of calls, which is not strictly required, even though it would common to add a window creator before setting positioning.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21023#discussion_r1762800438

From aivanov at openjdk.org  Tue Sep 17 09:52:04 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 09:52:04 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v2]
In-Reply-To: <LgXx8_EObRzM7xJ4g39Lv_o0CLKQs0b0EiiB2sdjsO0=.b0b1795f-6934-459a-b6a3-80ec0f88b0ff@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
 <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
 <LgXx8_EObRzM7xJ4g39Lv_o0CLKQs0b0EiiB2sdjsO0=.b0b1795f-6934-459a-b6a3-80ec0f88b0ff@github.com>
Message-ID: <uPxPCbmy429--iGeIHG7KqhZ6Ec5QXqSSW662gTov7c=.8c771355-864b-4237-8f1b-3a30865386fc@github.com>

On Tue, 17 Sep 2024 08:38:13 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> I think that this can be improved by adding some predefined positionTestUI functions, like in the #15721 (we can borrow them from it).

I agree that we should ? and *we will*. Yet I don't see missing default layouts as stopper from integrating this PR.

Adding a library of common layouts will take more time ? to add layouts and to review ? and @honkar-jdk wants to use the feature right now. It's better to do it with what's currently available rather than implement tricks to position two test UI windows. @kumarabhi006 also asked about the feature.

Once tests are created, or even right now, we can submit bugs to update the test and use a common layout rather than one in the test and link those bugs as blocked by [JDK-8317116](https://bugs.openjdk.org/browse/JDK-8317116).

There's already a test `java/awt/event/KeyEvent/AcceleratorTest/AcceleratorTest.java` which uses two test UI windows, yet it doesn't do anything to position them:
https://github.com/openjdk/jdk/blob/c6721a0fa2582c3ddf1ef0a6e16a09234432939c/test/jdk/java/awt/event/KeyEvent/AcceleratorTest/AcceleratorTest.java#L157-L161

This test could be updated to use logging area instead of two test windows. Either way works.

> For example, consider adding `PositionWindowsLib.java`(or maybe a nested public static class for `PassFailJFrame` to avoid extra `@build` clause)

I've thought about it. We can add the most common layout right into `PassFailJFrame` to avoid additional `@build` tag. It could even be in a separate class, as you suggest, if it's referenced by `PassFailJFrame`, it will be automatically compiled by jtreg.

I think we should add convenience methods `positionTestUIRows`, `positionTestUIColumns`, it'll make using the common layouts even simpler. If the convenience methods reference another class, it should be compiled automatically; if it doesn't work, we will put the layouts as a nested class or as methods directly into `PassFailJFrame`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21023#issuecomment-2355078684

From aivanov at openjdk.org  Tue Sep 17 09:52:06 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 09:52:06 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v2]
In-Reply-To: <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
 <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
Message-ID: <RvVjhYJ7_U82kg003eCJVZOfk8FaeYWIccd_17nSJDY=.10d7414e-83bb-4a54-8dc9-4477480acf93@github.com>

On Mon, 16 Sep 2024 21:38:36 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>> 
>> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
>> 
>> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code as per test UI requirements.
>> 
>> Usage:
>> 
>> PassFailJFrame.builder()
>>                       .title("Test Instructions")
>>                       .instructions(INSTRUCTIONS)
>>                       .rows(int)
>>                       .columns(int)
>>                       .testUI(<TestClass::createAndShowUI>)
>>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>>                       .build()
>>                       .awaitAndCheck();
>> 
>> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
>> 
>> @aivanov-jdk has demonstrated custom test UI positioning in this PR: 
>> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed errorenous check

There has been no need for multiple test windows for nearly a year, it's not the most used feature. This is why I think we can add common layouts later rather than *rush it* right now.

A few tests are also easy to update, and these tests would be a live demo for the improvement.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21023#issuecomment-2355083435

From aivanov at openjdk.org  Tue Sep 17 12:44:36 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 12:44:36 GMT
Subject: RFR: 8340306: Add border around instructions in PassFailJFrame
Message-ID: <zTSZWNkl9I8P5xSP_v09hE2PT29ngxOYoQ8Zhui4ZoA=.48419fb6-aa9d-4d8d-a078-354e7360a029@github.com>

A trivial change which adds border around instruction text. It makes the text easier to read.

-------------

Commit messages:
 - 8340306: Add border around instructions in PassFailJFrame

Changes: https://git.openjdk.org/jdk/pull/21038/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21038&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340306
  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21038.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21038/head:pull/21038

PR: https://git.openjdk.org/jdk/pull/21038

From aivanov at openjdk.org  Tue Sep 17 12:55:03 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 12:55:03 GMT
Subject: RFR: 8340306: Add border around instructions in PassFailJFrame
In-Reply-To: <zTSZWNkl9I8P5xSP_v09hE2PT29ngxOYoQ8Zhui4ZoA=.48419fb6-aa9d-4d8d-a078-354e7360a029@github.com>
References: <zTSZWNkl9I8P5xSP_v09hE2PT29ngxOYoQ8Zhui4ZoA=.48419fb6-aa9d-4d8d-a078-354e7360a029@github.com>
Message-ID: <SCtDF0lp3TOhmxS2apQkFR6qIZG7GHRTJ9noMp1fV9k=.5d337ece-d004-4cc5-b2a7-1ad9a64ad0a7@github.com>

On Tue, 17 Sep 2024 12:39:20 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> A trivial change which adds border around instruction text. It makes the text easier to read.

**Updated look:**

![Screenshot of PrintLatinCJKTest with border around text](https://github.com/user-attachments/assets/93311a78-6339-42f0-97e6-89661bb21743)

The text is no longer attaches to the left of the frame.

**Previous look:**

![Screenshot of PrintLatinCJKTest without border around text](https://github.com/user-attachments/assets/516c168d-94ea-4df8-befb-5afc3559df37)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21038#issuecomment-2355679301

From aivanov at openjdk.org  Tue Sep 17 13:50:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 13:50:16 GMT
Subject: RFR: 8340308: PassFailJFrame: Make rows default to number of lines in
 instructions
Message-ID: <u0itoRE_OT4Jht_rlEj1RPKS2zDPZlywWqleNJMiDnE=.27f17c90-c321-45b9-8f78-e669ce10df69@github.com>

It has become quite common to use the following code


.rows((int) INSTRUCTIONS.lines().count() + 1)


to set the number of rows for `PassFailJFrame`.

Make this the default value. Newer tests could drop `.rows` from builder configuration if the new default works well.

If a test needs customising the new default value, the newly added method `rowsAdd` could be used to increase the number of rows.

-------------

Commit messages:
 - Add description for Builder.columns method
 - 8340308: PassFailJFrame: Make rows default to number of lines in instructions

Changes: https://git.openjdk.org/jdk/pull/21039/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21039&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340308
  Stats: 35 lines in 1 file changed: 34 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21039.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21039/head:pull/21039

PR: https://git.openjdk.org/jdk/pull/21039

From aivanov at openjdk.org  Tue Sep 17 14:03:03 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 14:03:03 GMT
Subject: RFR: 8340308: PassFailJFrame: Make rows default to number of lines
 in instructions
In-Reply-To: <u0itoRE_OT4Jht_rlEj1RPKS2zDPZlywWqleNJMiDnE=.27f17c90-c321-45b9-8f78-e669ce10df69@github.com>
References: <u0itoRE_OT4Jht_rlEj1RPKS2zDPZlywWqleNJMiDnE=.27f17c90-c321-45b9-8f78-e669ce10df69@github.com>
Message-ID: <dRb729TfdRu_j2npzXqgr0KfDMXzjdJj0sRojuquqlM=.6b83d945-63c7-4400-8349-a357d1a0aa82@github.com>

On Tue, 17 Sep 2024 13:45:06 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> It has become quite common to use the following code
> 
> 
> .rows((int) INSTRUCTIONS.lines().count() + 1)
> 
> 
> to set the number of rows for `PassFailJFrame`.
> 
> Make this the default value. Newer tests could drop `.rows` from builder configuration if the new default works well.
> 
> If a test needs customising the new default value, the newly added method `rowsAdd` could be used to increase the number of rows.

There are currently 29 tests which use `.rows((int) INSTRUCTIONS.lines().count() + 1)` to set the number of rows.

Another set of tests uses `+ 2` instead, the number of such tests is 24.

You can get the list of files using these commands:


grep --recursive --files-with-matches --perl-regexp '.rows((int).*.lines().count().*+.*1.*)' test/jdk
grep --recursive --files-with-matches --perl-regexp '.rows((int).*.lines().count().*+.*2.*)' test/jdk


Two tests added in #20996 use `+ 5`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21039#issuecomment-2355916309

From aivanov at openjdk.org  Tue Sep 17 14:34:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 14:34:13 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v2]
In-Reply-To: <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
 <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
Message-ID: <EIcN0ijhGQltv7k2NzDo-CzKLh2yATiv9JiOHm5hMqQ=.5ece3700-0cc6-4456-b84a-1b9ade7b5d93@github.com>

On Mon, 16 Sep 2024 21:38:36 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>> 
>> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
>> 
>> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code as per test UI requirements.
>> 
>> Usage:
>> 
>> PassFailJFrame.builder()
>>                       .title("Test Instructions")
>>                       .instructions(INSTRUCTIONS)
>>                       .rows(int)
>>                       .columns(int)
>>                       .testUI(<TestClass::createAndShowUI>)
>>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>>                       .build()
>>                       .awaitAndCheck();
>> 
>> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
>> 
>> @aivanov-jdk has demonstrated custom test UI positioning in this PR: 
>> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed errorenous check

I wanted to request the changes instead: the description of the method needs updating as the result of removing the check for window creator or window list.

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21023#pullrequestreview-2309949336

From duke at openjdk.org  Tue Sep 17 15:30:07 2024
From: duke at openjdk.org (duke)
Date: Tue, 17 Sep 2024 15:30:07 GMT
Subject: RFR: 8339845: Update color.org and wapforum.org links to use HTTPS
 instead of HTTP
In-Reply-To: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
References: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
Message-ID: <Jhsrgx2UT7Zv860YSzmA6EdFAs1LvsjVTaEF8x8-fDU=.16a4cd32-96e2-4159-97ba-08e1d30373fe@github.com>

On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I get a review for this doc-only change? I updated some links because the websites moved from HTTP to HTTPS. The redirects can cause some false-positives on tests.
> 
> TIA

@nizarbenalla 
Your change (at version 06086104bf40bb76ba8af127fb5d120a85146bf0) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21001#issuecomment-2356241704

From rgupta at openjdk.org  Tue Sep 17 16:11:48 2024
From: rgupta at openjdk.org (Ravi Gupta)
Date: Tue, 17 Sep 2024 16:11:48 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v7]
In-Reply-To: <y6GbW6nFOYrEwZ5RvwJ-xXbw_slBMXdE09VacjnvOH4=.509b4ceb-9b5c-4f24-99e0-369ab68ecfb4@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <QweXa3qMo3QTx7GMt3jACHTj85pE24c-XypNVxvtCdE=.8e555e97-9153-4375-8c97-9f4036dd716f@github.com>
 <y6GbW6nFOYrEwZ5RvwJ-xXbw_slBMXdE09VacjnvOH4=.509b4ceb-9b5c-4f24-99e0-369ab68ecfb4@github.com>
Message-ID: <mBUqwtLcw7R2FUM_9dJQNWPuofs0HU0y_ZH8ewwzido=.b6fb7314-84f4-4041-9ee3-8101cbbb6fbb@github.com>

On Wed, 4 Sep 2024 15:04:25 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8333403: Review comments fixed
>
> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 157:
> 
>> 155:         EventQueue.invokeAndWait(() -> {
>> 156:             compAt = components[9].getLocationOnScreen();
>> 157:             compSize = components[9].getSize();
> 
> Why did you change it from 0 to 9?
> 
> The number 9 looks like a magic number, it may change if anything changes in the `components` array.

now i used frame to ensure that its gain foucs

> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 201:
> 
>> 199:         System.err.println();
>> 200:         throw new RuntimeException("FAIL: " + errorMsg);
>> 201:     }
> 
> So you're collecting a list of events to print them if iconify or deiconify generates an unexpected list of events.
> 
> In all other cases `events` isn't used at all.
> 
> Given that all the generated events are printed as they're come, I see no reason why `events` is needed at all. By printing messages that you're about to test iconifying frame and deiconifying frame you separate the cases, the list of events will be printed between these messages.

removed the events  , now list of events will be printed by using ComponentListener

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1763511677
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1763515115

From rgupta at openjdk.org  Tue Sep 17 16:11:48 2024
From: rgupta at openjdk.org (Ravi Gupta)
Date: Tue, 17 Sep 2024 16:11:48 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v8]
In-Reply-To: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
Message-ID: <mPOGl6NY-J5TrAxWVZ_dSGXXYX_45NHShsMPRiB3b2Y=.9d99e63b-3592-4b87-8d89-19d31fafe460@github.com>

> This testcase checks for the following assertions for Component events:
> 
> 1. When components are resized, moved, hidden and shown the respective events are triggered.
> 2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
> 3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
> 4. When a window is minimized/restored then hidden and shown component events should be triggered.
> 
> Testing:
> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.

Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:

  8333403: Review Comments Fixed

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19521/files
  - new: https://git.openjdk.org/jdk/pull/19521/files/b367175a..078301d8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19521&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19521&range=06-07

  Stats: 659 lines in 2 files changed: 334 ins; 325 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/19521.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19521/head:pull/19521

PR: https://git.openjdk.org/jdk/pull/19521

From duke at openjdk.org  Tue Sep 17 16:14:17 2024
From: duke at openjdk.org (lawrence.andrews)
Date: Tue, 17 Sep 2024 16:14:17 GMT
Subject: RFR: 8340306: Add border around instructions in PassFailJFrame
In-Reply-To: <SCtDF0lp3TOhmxS2apQkFR6qIZG7GHRTJ9noMp1fV9k=.5d337ece-d004-4cc5-b2a7-1ad9a64ad0a7@github.com>
References: <zTSZWNkl9I8P5xSP_v09hE2PT29ngxOYoQ8Zhui4ZoA=.48419fb6-aa9d-4d8d-a078-354e7360a029@github.com>
 <SCtDF0lp3TOhmxS2apQkFR6qIZG7GHRTJ9noMp1fV9k=.5d337ece-d004-4cc5-b2a7-1ad9a64ad0a7@github.com>
Message-ID: <Au6zzj2zSe3J-p3l6-fzs8OQGat1h7J_62DNl2fzbDA=.f7cf5343-12fd-43b6-9a6e-26702259ebf1@github.com>

On Tue, 17 Sep 2024 12:52:46 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> A trivial change which adds border around instruction text. It makes the text easier to read.
>> 
>> (In some tests, people added leading spaces to each line to make the instructions easier to read; with the added border, there's no need for this trick.)
>
> **Updated look:**
> 
> ![Screenshot of PrintLatinCJKTest with border around text](https://github.com/user-attachments/assets/93311a78-6339-42f0-97e6-89661bb21743)
> 
> The text is no longer attaches to the left of the frame.
> 
> **Previous look:**
> 
> ![Screenshot of PrintLatinCJKTest without border around text](https://github.com/user-attachments/assets/516c168d-94ea-4df8-befb-5afc3559df37)

@aivanov-jdk  thanks for adding . Now the test instruction looks highlighted. 
 LGTM

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21038#issuecomment-2356361363

From rgupta at openjdk.org  Tue Sep 17 16:19:27 2024
From: rgupta at openjdk.org (Ravi Gupta)
Date: Tue, 17 Sep 2024 16:19:27 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v9]
In-Reply-To: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
Message-ID: <4oKmSnv0K5L-6klgC3JZClGZRON9YR149ucfNlavGdI=.922747b0-0dc9-4aea-b928-0c67c6a1642c@github.com>

> This testcase checks for the following assertions for Component events:
> 
> 1. When components are resized, moved, hidden and shown the respective events are triggered.
> 2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
> 3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
> 4. When a window is minimized/restored then hidden and shown component events should be triggered.
> 
> Testing:
> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.

Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:

  8333403: Whitespace Fixed

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19521/files
  - new: https://git.openjdk.org/jdk/pull/19521/files/078301d8..acaee1a6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19521&range=08
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19521&range=07-08

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/19521.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19521/head:pull/19521

PR: https://git.openjdk.org/jdk/pull/19521

From rgupta at openjdk.org  Tue Sep 17 16:19:27 2024
From: rgupta at openjdk.org (Ravi Gupta)
Date: Tue, 17 Sep 2024 16:19:27 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v7]
In-Reply-To: <y6GbW6nFOYrEwZ5RvwJ-xXbw_slBMXdE09VacjnvOH4=.509b4ceb-9b5c-4f24-99e0-369ab68ecfb4@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <QweXa3qMo3QTx7GMt3jACHTj85pE24c-XypNVxvtCdE=.8e555e97-9153-4375-8c97-9f4036dd716f@github.com>
 <y6GbW6nFOYrEwZ5RvwJ-xXbw_slBMXdE09VacjnvOH4=.509b4ceb-9b5c-4f24-99e0-369ab68ecfb4@github.com>
Message-ID: <Y9wgxgkpjLuc-wVBLm-MtQkUKx7n3OhNh7lJFMXMHfg=.48f3dc02-39c1-4a78-a348-bfec4b310f61@github.com>

On Wed, 4 Sep 2024 14:50:58 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8333403: Review comments fixed
>
> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 67:
> 
>> 65:     private static volatile Dimension compSize;
>> 66:     private static final java.util.Collection<ComponentEvent> events =
>> 67:         Collections.synchronizedList(new ArrayList<ComponentEvent>());
> 
> Suggestion:
> 
>     private static final Collection<ComponentEvent> events =
>         Collections.synchronizedList(new ArrayList<>());

removed  events list , now events are printed using the ComponentListener.

> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 67:
> 
>> 65:     private static volatile Dimension compSize;
>> 66:     private static final java.util.Collection<ComponentEvent> events =
>> 67:         Collections.synchronizedList(new ArrayList<ComponentEvent>());
> 
> Any reason why you use fully qualified `java.util.Collection` class name instead of importing it?

removed events list , now events are printed using the ComponentListener.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1763526359
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1763526784

From rgupta at openjdk.org  Tue Sep 17 16:25:19 2024
From: rgupta at openjdk.org (Ravi Gupta)
Date: Tue, 17 Sep 2024 16:25:19 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v6]
In-Reply-To: <PtW1s2ZEPwpXX3x0kQN4XIkIlTuEBx6wBEC8Zm9QzFw=.fdf51273-1357-4117-9fc1-a93407b5d170@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <JW9jDWC8Gcz9H6MDYnHEXv4MY-lV0IFuyO5dQkEXzaw=.b1364df2-62ae-41e3-a8bb-d2003e2e786f@github.com>
 <LgtHsnsX7NzUQXkb1QxZ3T-qBBVWkR5PVavc4uvPQFI=.95d627c2-8692-470c-859f-6a8b6ef07cd0@github.com>
 <tPc_DYcQiHelb4ll56MnPYSIU6hq03ZHQMuhF7k4fM0=.026f1278-5c2f-4fbe-be2a-cb7146f3f281@github.com>
 <PtW1s2ZEPwpXX3x0kQN4XIkIlTuEBx6wBEC8Zm9QzFw=.fdf51273-1357-4117-9fc1-a93407b5d170@github.com>
Message-ID: <-FudqROzC1i4cUFYa6LezEzwV5c9bktVGQS5gZSvQno=.aacd284c-632d-44a0-9076-a27e1183047e@github.com>

On Wed, 4 Sep 2024 15:54:16 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Here we expect events should not triggered.
>> 
>> When inconify i expect all events should not triggered , but when form Frame.ICONIFIED to Frame.NORMAL componentMoved and componentResized events are triggered , Events order on Windows and Mac are different.
>> 
>> Order of the events for Frame from Frame.ICONIFIED to Frame.NORMAL
>> 
>> On Windows
>> 
>> Component Shown 
>> Frame is Visible with ExtendedState as ICONIFIED
>> Component Moved
>> Component Resized
>> Frame is Visible with ExtendedState as NORMAL
>> 
>> On MAC
>> Component Moved
>> Component Resized
>> Component Shown 
>> Frame is Visible with ExtendedState as ICONIFIED
>> Frame is Visible with ExtendedState as NORMAL
>
>> when form Frame.ICONIFIED to Frame.NORMAL componentMoved and componentResized events are triggered
> 
> Then verify that these events are triggered:
> 
> 
> -        if (componentShown || componentHidden) {
> +        if (componentShown || componentHidden || !componentMoved
> +            || !componentResized) {
> 
> Otherwise it looks as if you forgot to test something. You may have two `if` statements to print more precise error message.

We observed different behavior between MS Windows and other OS ,we natively received WM_SIZE/WM_MOVE events when set frame iconify to
deiconify , The AWT sends the events to components when it receives the events from the native system. 

Now we are applying the OS specific check to test this scenario.

Please check the details at  JDK-6754618

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1763534174

From aivanov at openjdk.org  Tue Sep 17 17:09:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 17:09:16 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v9]
In-Reply-To: <4oKmSnv0K5L-6klgC3JZClGZRON9YR149ucfNlavGdI=.922747b0-0dc9-4aea-b928-0c67c6a1642c@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <4oKmSnv0K5L-6klgC3JZClGZRON9YR149ucfNlavGdI=.922747b0-0dc9-4aea-b928-0c67c6a1642c@github.com>
Message-ID: <yajPPY-juHR9hiIZvAPZMU15BTR3ncECDFLEv-7XWsc=.37850014-8738-4953-be58-18dda0957a2d@github.com>

On Tue, 17 Sep 2024 16:19:27 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:

>> This testcase checks for the following assertions for Component events:
>> 
>> 1. When components are resized, moved, hidden and shown the respective events are triggered.
>> 2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
>> 3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
>> 4. When a window is minimized/restored then hidden and shown component events should be triggered.
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.
>
> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8333403: Whitespace Fixed

I am still for moving the test into `java/awt/Component` folder.

test/jdk/java/awt/ComponentEvent/ComponentEventTest.java line 50:

> 48:  * @bug 8333403
> 49:  * @summary Test performs various operations to check components events are triggered properly.
> 50:  * @run main ComponentEventTest

Add the library and build tags to use the `Platform` class.

Suggestion:

 * @summary Test performs various operations to check components events are triggered properly.
 * @library /test/lib
 * @build jdk.test.lib.Platform
 * @run main ComponentEventTest


And don't forget to add `jdk.test.lib.Platform` to the list of imports.

test/jdk/java/awt/ComponentEvent/ComponentEventTest.java line 149:

> 147:     private static void doTest()
> 148:         throws InvocationTargetException, InterruptedException {
> 149:         // Click on the Frame to ensure its gain Focus

Suggestion:

        // Click the frame to ensure it gains focus

I see no reason why you capitalise ?frame? and ?focus?.

test/jdk/java/awt/ComponentEvent/ComponentEventTest.java line 161:

> 159:         robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 160: 
> 161:         robot.delay(DELAY);

Does it make sense to move this part into a new method `clickFrame`?

Does anyone else have any opinions on this?

test/jdk/java/awt/ComponentEvent/ComponentEventTest.java line 171:

> 169:         robot.delay(DELAY);
> 170: 
> 171:         System.out.println("Iconify frame");

Similarly, iconify and deiconify could be moved into a separate method. Shorter, logically complete pieces improve the code quality and the overall readability of the code.

test/jdk/java/awt/ComponentEvent/ComponentEventTest.java line 196:

> 194:          * the events from the native system.
> 195:          * Please check the  JDK-6754618
> 196:          */

Suggestion:

        /*
         * Because of the different behavior between MS Windows and other OS,
         * we receive native events WM_SIZE and WM_MOVE on Windows
         * when the frame state changes from iconified to normal.
         * AWT sends these events to components when it receives
         * the events from the native system.
         * See JDK-6754618 for more information.
         */

test/jdk/java/awt/ComponentEvent/ComponentEventTest.java line 208:

> 206:             throw new RuntimeException(
> 207:                 "ComponentEvent triggered when frame set to normal");
> 208:         }

I suggest using the `Platform` class to determine whether the test runs on Windows or not and splitting the common condition and platform-dependent conditions:


        if (componentShown || componentHidden) {
            throw new RuntimeException(
                    "FAIL: componentShown or componentHidden triggered "
                    + "when frame set to normal");
        }

        if (Platform.isWindows() && (!componentMoved || !componentResized)) {
            throw new RuntimeException(
                    "FAIL: componentMoved or componentResized wasn't triggered "
                    + "when frame set to normal");
        }
        if (!Platform.isWindows() && (componentMoved || componentResized)) {
            throw new RuntimeException(
                "FAIL: componentMoved or componentResized triggered "
                + "when frame set to normal");
        }


This allows you to report a clearer error message.

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19521#pullrequestreview-2310234320
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1763592072
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1763532753
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1763582314
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1763583953
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1763545672
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1763563500

From honkar at openjdk.org  Tue Sep 17 17:28:26 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 17 Sep 2024 17:28:26 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v3]
In-Reply-To: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
Message-ID: <1JMeQt53ytU3UlSyfV77UDbccgjzpHbrFRfJR2mXb_k=.0f4f1ae2-adb0-4609-a05c-272ddd15befd@github.com>

> `positionTestUI()` option is added to PassFailJFrame (PFJ).
> 
> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
> 
> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code as per test UI requirements.
> 
> Usage:
> 
> PassFailJFrame.builder()
>                       .title("Test Instructions")
>                       .instructions(INSTRUCTIONS)
>                       .rows(int)
>                       .columns(int)
>                       .testUI(<TestClass::createAndShowUI>)
>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>                       .build()
>                       .awaitAndCheck();
> 
> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
> 
> @aivanov-jdk has demonstrated custom test UI positioning in this PR: 
> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  doc update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21023/files
  - new: https://git.openjdk.org/jdk/pull/21023/files/5a331fd6..cb342a88

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21023&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21023&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21023.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21023/head:pull/21023

PR: https://git.openjdk.org/jdk/pull/21023

From aivanov at openjdk.org  Tue Sep 17 17:28:26 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 17:28:26 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v3]
In-Reply-To: <1JMeQt53ytU3UlSyfV77UDbccgjzpHbrFRfJR2mXb_k=.0f4f1ae2-adb0-4609-a05c-272ddd15befd@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
 <1JMeQt53ytU3UlSyfV77UDbccgjzpHbrFRfJR2mXb_k=.0f4f1ae2-adb0-4609-a05c-272ddd15befd@github.com>
Message-ID: <wjXkU4L9TQDVgW0LebgGLVGiNwwjX5wp9zYo-mEhCzM=.4abb433a-3e74-43d3-954f-66667da37698@github.com>

On Tue, 17 Sep 2024 17:25:34 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>> 
>> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
>> 
>> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code as per test UI requirements.
>> 
>> Usage:
>> 
>> PassFailJFrame.builder()
>>                       .title("Test Instructions")
>>                       .instructions(INSTRUCTIONS)
>>                       .rows(int)
>>                       .columns(int)
>>                       .testUI(<TestClass::createAndShowUI>)
>>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>>                       .build()
>>                       .awaitAndCheck();
>> 
>> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
>> 
>> @aivanov-jdk has demonstrated custom test UI positioning in this PR: 
>> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   doc update

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21023#pullrequestreview-2310377833

From honkar at openjdk.org  Tue Sep 17 17:28:26 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 17 Sep 2024 17:28:26 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v2]
In-Reply-To: <Mzuqzsva8Dxf95vmXPyBtxAsnbLvg77V9k-S3miR4_g=.f7a89e7a-59b5-4f3b-8335-b14b7564ff30@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
 <rW1LWfAo6BiNHDp8KEL-sy0bRks-cG2lwLvUSld4eIo=.bad96118-e62a-4ad5-99d2-b8baf78d9c78@github.com>
 <Mzuqzsva8Dxf95vmXPyBtxAsnbLvg77V9k-S3miR4_g=.f7a89e7a-59b5-4f3b-8335-b14b7564ff30@github.com>
Message-ID: <Xntjm8GRzqky0s37ocplKm4n7nvNjecTkLNRj_JP2PE=.02be46dc-3d4b-4922-a2c0-2c4db3724b2e@github.com>

On Tue, 17 Sep 2024 09:21:24 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed errorenous check
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1264:
> 
>> 1262:          * @throws IllegalStateException if the {@code positionWindows} field
>> 1263:          *              is already set, or if neither a windows list creator
>> 1264:          *              nor a list of test windows has been provided
> 
> Suggestion:
> 
>          * @throws IllegalStateException if the {@code positionWindows} field
>          *              is already set

Updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21023#discussion_r1763613153

From honkar at openjdk.org  Tue Sep 17 17:31:10 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 17 Sep 2024 17:31:10 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v3]
In-Reply-To: <1JMeQt53ytU3UlSyfV77UDbccgjzpHbrFRfJR2mXb_k=.0f4f1ae2-adb0-4609-a05c-272ddd15befd@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
 <1JMeQt53ytU3UlSyfV77UDbccgjzpHbrFRfJR2mXb_k=.0f4f1ae2-adb0-4609-a05c-272ddd15befd@github.com>
Message-ID: <CqSF2cd0exlxwTo4xGqCB0mtCgKNa2Qst7Egvm1wTgY=.452a69c5-6169-41bf-b17a-95558aab5bc9@github.com>

On Tue, 17 Sep 2024 17:28:26 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>> 
>> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
>> 
>> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code as per test UI requirements.
>> 
>> Usage:
>> 
>> PassFailJFrame.builder()
>>                       .title("Test Instructions")
>>                       .instructions(INSTRUCTIONS)
>>                       .rows(int)
>>                       .columns(int)
>>                       .testUI(<TestClass::createAndShowUI>)
>>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>>                       .build()
>>                       .awaitAndCheck();
>> 
>> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
>> 
>> @aivanov-jdk has demonstrated custom test UI positioning in this PR: 
>> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   doc update

> I think that this can be improved by adding some predefined positionTestUI functions, like in the #15721 (we can borrow them from it). For example, consider adding `PositionWindowsLib.java`(or maybe a nested public static class for `PassFailJFrame` to avoid extra `@build` clause), which has functions something like
> 
> ```java
> .positionTestUI(PositionWindowsLib::positionHH) // aka TwoWindowsHH.positionTestUI
> .positionTestUI(PositionWindowsLib::positionHV) // aka TwoWindowsHV.positionTestUI
> ...
> ```

@azvegint Valid suggestion and re-usability of common layouts is better than having to repeat it in the test code. This will be added as next step to PassFailJFrame iterative improvement as @aivanov-jdk suggested.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21023#issuecomment-2356507943

From honkar at openjdk.org  Tue Sep 17 17:41:06 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 17 Sep 2024 17:41:06 GMT
Subject: RFR: 8340306: Add border around instructions in PassFailJFrame
In-Reply-To: <zTSZWNkl9I8P5xSP_v09hE2PT29ngxOYoQ8Zhui4ZoA=.48419fb6-aa9d-4d8d-a078-354e7360a029@github.com>
References: <zTSZWNkl9I8P5xSP_v09hE2PT29ngxOYoQ8Zhui4ZoA=.48419fb6-aa9d-4d8d-a078-354e7360a029@github.com>
Message-ID: <lHMMkw6QB96lDS0qRqbQhb4QmxXCJa0hWGdwuUBMEM4=.602eb73a-a514-4850-a8ae-41cef6f8c032@github.com>

On Tue, 17 Sep 2024 12:39:20 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> A trivial change which adds border around instruction text. It makes the text easier to read.
> 
> (In some tests, people added leading spaces to each line to make the instructions easier to read; with the added border, there's no need for this trick.)

LGTM, test instructions are better indented now and not close to the edge.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21038#pullrequestreview-2310418017

From honkar at openjdk.org  Tue Sep 17 17:48:04 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 17 Sep 2024 17:48:04 GMT
Subject: RFR: 8340308: PassFailJFrame: Make rows default to number of lines
 in instructions
In-Reply-To: <u0itoRE_OT4Jht_rlEj1RPKS2zDPZlywWqleNJMiDnE=.27f17c90-c321-45b9-8f78-e669ce10df69@github.com>
References: <u0itoRE_OT4Jht_rlEj1RPKS2zDPZlywWqleNJMiDnE=.27f17c90-c321-45b9-8f78-e669ce10df69@github.com>
Message-ID: <y-S7eX2Z4YfyVP_QLZl_0QlW1_vk3BKXbMy8hZFDolk=.1ceb2b1d-25c9-42fd-ba19-aedaed48a2e2@github.com>

On Tue, 17 Sep 2024 13:45:06 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> It has become quite common to use the following code
> 
> 
> .rows((int) INSTRUCTIONS.lines().count() + 1)
> 
> 
> to set the number of rows for `PassFailJFrame`.
> 
> Make this the default value. Newer tests could drop `.rows` from builder configuration if the new default works well.
> 
> If a test needs customising the new default value, the newly added method `rowsAdd` could be used to increase the number of rows.

LGTM, eliminates the need to specify `.rows((int) INSTRUCTIONS.lines().count() + 1)` if the default no. of rows works for the test.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21039#pullrequestreview-2310432394

From prr at openjdk.org  Tue Sep 17 18:33:52 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 17 Sep 2024 18:33:52 GMT
Subject: RFR: 8340078: Open source several 2D tests
Message-ID: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>

Open source 5 Java2D related rendering tests.

-------------

Commit messages:
 - 8340078

Changes: https://git.openjdk.org/jdk/pull/21045/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21045&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340078
  Stats: 484 lines in 5 files changed: 484 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21045.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21045/head:pull/21045

PR: https://git.openjdk.org/jdk/pull/21045

From honkar at openjdk.org  Tue Sep 17 18:47:08 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 17 Sep 2024 18:47:08 GMT
Subject: RFR: JDK-8339962 : Open source AWT TextField tests - Set1 [v3]
In-Reply-To: <Fog0s8VOThwYsgzPpN1mQaUXJVLVEOxG2tcDr5Vritc=.eac43e4b-7862-4154-93eb-6cefd9d95514@github.com>
References: <v6evWDMdJ5taNxUxxPD-onH6DfUhWGyWSW69gyb87fo=.380962ba-cc65-403e-8337-33186b5d9e29@github.com>
 <Fog0s8VOThwYsgzPpN1mQaUXJVLVEOxG2tcDr5Vritc=.eac43e4b-7862-4154-93eb-6cefd9d95514@github.com>
Message-ID: <e9cjSu1zs2z-uN6dSOFZ5dO4gXzUnoBUhH_r9jbugvM=.13d004f3-9db3-4478-a623-2d819c8be034@github.com>

On Mon, 16 Sep 2024 22:59:35 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test are open-sourced.
>> 
>> 1. 	test/jdk/java/awt/Label/ContainerValidateTest.java - Automated
>> 2. 	test/jdk/java/awt/TextField/SetEchoCharTest.java - Automated
>> 3. 	test/jdk/java/awt/TextField/SetEchoCharWordOpsTest.java - PassFailJFrame manual test
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   typo fix

This PR requires re-approval after a small update.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21005#issuecomment-2356648015

From aivanov at openjdk.org  Tue Sep 17 19:29:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 19:29:13 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <0KuII4A9thnWARW5tWmwaEOw0c91WSN0WmjDqxYAY4Y=.a4c6f377-e5a1-4302-b389-67fdbb4aa157@github.com>

On Tue, 17 Sep 2024 04:31:09 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/MenuItem/GiantFontTest.java line 72:

> 70:         mb.add(m);
> 71:         f.setMenuBar(mb);
> 72:         f.setSize (450, 400);

Suggestion:

        f.setSize(450, 400);

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 45:

> 43:  */
> 44: 
> 45: public class LotsOfMenuItemsTest implements ComponentListener {

Suggestion:

public class LotsOfMenuItemsTest extends ComponentAdapter {


You use only one method from `ComponentListener`, override only the one you need and remove the ones you don't use.

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 47:

> 45: public class LotsOfMenuItemsTest implements ComponentListener {
> 46:     private static final int NUM_WINDOWS = 400;
> 47:     private static TestFrame firstFrame, testFrame;

It is not recommended to declare several fields or variables on one line in Java.

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 48:

> 46:     private static final int NUM_WINDOWS = 400;
> 47:     private static TestFrame firstFrame, testFrame;
> 48:     private static Rectangle rect;

`rect` is never used.

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 53:

> 51:         LotsOfMenuItemsTest obj = new LotsOfMenuItemsTest();
> 52:         String INSTRUCTIONS = """
> 53:                 This test creates a lots of frames with menubars.

Suggestion:

                This test creates lots of frames with menu bars.

Either _?a lot of?_ or _?lots of?_.

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 58:

> 56: 
> 57:                 If everything seems to work - test passed.
> 58:                 Click "Done" button in the test harness window.

There's no **Done** button.

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 73:

> 71:     }
> 72: 
> 73:     private List<? extends Frame> createAndShowUI() {

It can be simplified to
Suggestion:

    private List<Frame> createAndShowUI() {

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 86:

> 84:                 testFrame.setTitle("Last Frame");
> 85:             }
> 86:         }

Suggestion:

        for (int i = 1; i < NUM_WINDOWS - 1; ++i) {
            testFrame = new TestFrame("Running(" + i + ")...");
            testFrame.setVisible(false);
            testFrame.dispose();
        }

        testFrame = new TestFrame("Last Frame");


Doesn't it make the code clearer and shorter?

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 89:

> 87:         list.add(firstFrame);
> 88:         list.add(testFrame);
> 89:         return list;

You can return a list like this:

Suggestion:

        return List.of(firstFrame, testFrame);


No need to explicitly create a list, no need to explicit add items one by one.

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 98:

> 96:         firstFrame.setLocation(970, 350);
> 97:         testFrame.setLocation(970, 510);
> 98:     }

Hard-coding coordinates is not the best solution. The workaround is to position the first frame using `PassFailJFrame` and then use the location of the first frame to position the second (test) frame.
Suggestion:

    @Override
    public void componentShown(ComponentEvent e) {
        PassFailJFrame.positionTestWindow(firstFrame,
                                          PassFailJFrame.Position.HORIZONTAL);
        testFrame.setLocation(firstFrame.getX(),
                              firstFrame.getY() + firstFrame.getWidth() + 8);
    }

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 103:

> 101: }
> 102: 
> 103: class TestFrame extends Frame {

Could you please make `TestFrame` a static nested class inside `LotsOfMenuItemsTest`.

I avoids conflicts when you mark a folder as Test Source in an IDE and that folder contains multiple tests.

In fact, you don't need to extend `Frame` at all: create an instance of the `Frame` class and add menu bar and set the size of the frame. However, I agree, keeping this stuff in constructor simplifies test.

test/jdk/java/awt/MenuItem/MenuSetFontTest.java line 47:

> 45:                     Click on the "File" menu. You will see "menu item" item.
> 46:                     Press pass if menu item is displayed using bold and large font else fail.
> 47:                     If you do not see menu at all, press fail.""";

Suggestion:

                    Press Pass if menu item is displayed using bold and large font, otherwise press Fail.
                    If you do not see menu at all, press Fail.""";

Capitalising the names of the buttons makes it easier to recognise it's a UI element.

test/jdk/java/awt/MenuItem/MenuSetFontTest.java line 54:

> 52:                 .rows((int) INSTRUCTIONS.lines().count() + 2)
> 53:                 .columns(40)
> 54:                 .testTimeOut(5)

You may omit the default timeout.

test/jdk/java/awt/MenuItem/MenuSetFontTest.java line 67:

> 65:         menu.add(item);
> 66:         menuBar.add(menu);
> 67:         menuBar.setFont(new Font("Monospaced", 1, 24));

Use the constants from the `Font` class:
Suggestion:

        menuBar.setFont(new Font(Font.MONOSPACED, Font.BOLD, 24));

test/jdk/java/awt/MenuItem/NullOrEmptyStringLabelTest.java line 47:

> 45:                 The bug is reproducible under Win32 and Solaris.
> 46:                 Setting 'null' and "" as a label of menu item
> 47:                 should by the spec set blank label on all platforms.

Suggestion:

                Setting 'null' and "" as a label of menu item
                should set blank label on all platforms according to the spec(ification).

It is uncommon to insert a phrase between an auxiliary verb and the main verb, even though adverbs are usually placed between them.

test/jdk/java/awt/MenuItem/NullOrEmptyStringLabelTest.java line 76:

> 74:         Button button3 = new Button("Set MenuItem label to 'text'");
> 75:         button1.addActionListener(new ActionListener() {
> 76:             public void actionPerformed(ActionEvent ev) {

Maybe add `@Override` annotation?

test/jdk/java/awt/MenuItem/NullOrEmptyStringLabelTest.java line 97:

> 95:         frame.add("North", button1);
> 96:         frame.add("South", button2);
> 97:         frame.add("Center", button3);

Wouldn't it be better to keep the logical and visual order of the buttons consistent? Or is the intention to set the label to `"text"` after `null` followed by `""`?

I also recommend using newer syntax (order of parameters) and constants from `BorderLayout`:
Suggestion:

        frame.add(button1, BorderLayout.NORTH);
        frame.add(button2, BorderLayout.CENTER);
        frame.add(button3, BorderLayout.SOUTH);

test/jdk/java/awt/MenuItem/UnicodeMenuItemTest.java line 81:

> 79: 
> 80:         MenuItem mi6 = new MenuItem("\u012d");
> 81:         m.add(mi6);

The numbering is weird here: 2, 6, 7 ? but there's no `mi1` or `m3`?

-------------

PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2310512618
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763692026
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763745882
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763708736
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763749772
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763710647
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763727356
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763756892
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763732588
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763707460
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763744407
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763705638
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763748726
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763768377
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763753615
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763764904
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763774205
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763784379
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1763788616

From aivanov at openjdk.org  Tue Sep 17 19:34:08 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 19:34:08 GMT
Subject: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab
 in JColorChooser [v4]
In-Reply-To: <chHEHotvS2SMPSaMhpsXF9NvJ7-kFvDNGuq0haoKn44=.eb9641ae-182d-483d-a432-ebfb7a44734a@github.com>
References: <DdaIu5i4A469vxzErA0H0qBDNote4lxqPFm2FM-BvGY=.afcb431e-6c5b-4c4c-bb6b-5bcac6b28872@github.com>
 <chHEHotvS2SMPSaMhpsXF9NvJ7-kFvDNGuq0haoKn44=.eb9641ae-182d-483d-a432-ebfb7a44734a@github.com>
Message-ID: <FGWxXQ5p_ZnD6vBuPWLGuC8ezo1VW-T5bRFhi5Id1pg=.e1c25074-ca64-4c4c-81bb-0c09e136f0e8@github.com>

On Fri, 6 Sep 2024 11:37:10 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> There is no Swatches tab available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test instructions.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove print statement

Marked as reviewed by aivanov (Reviewer).

test/jdk/javax/swing/JColorChooser/Test4887836.java line 35:

> 33:  * @bug 4887836
> 34:  * @library /java/awt/regtesthelpers /test/lib
> 35:  * @build PassFailJFrame

You may explicitly mention `jtreg.SkippedException` in the `@build` tag.
Suggestion:

 * @build PassFailJFrame jtreg.SkippedException

-------------

PR Review: https://git.openjdk.org/jdk/pull/20867#pullrequestreview-2310671748
PR Review Comment: https://git.openjdk.org/jdk/pull/20867#discussion_r1763794387

From azvegint at openjdk.org  Tue Sep 17 20:02:06 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 17 Sep 2024 20:02:06 GMT
Subject: RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder
 [v3]
In-Reply-To: <1JMeQt53ytU3UlSyfV77UDbccgjzpHbrFRfJR2mXb_k=.0f4f1ae2-adb0-4609-a05c-272ddd15befd@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
 <1JMeQt53ytU3UlSyfV77UDbccgjzpHbrFRfJR2mXb_k=.0f4f1ae2-adb0-4609-a05c-272ddd15befd@github.com>
Message-ID: <9kbLT1SRf8J6hM3DMogcNNMThcZ2N64VWhq5craU6-c=.9526f4c5-139a-4f0d-b65a-a260ff46759c@github.com>

On Tue, 17 Sep 2024 17:28:26 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>> 
>> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
>> 
>> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code as per test UI requirements.
>> 
>> Usage:
>> 
>> PassFailJFrame.builder()
>>                       .title("Test Instructions")
>>                       .instructions(INSTRUCTIONS)
>>                       .rows(int)
>>                       .columns(int)
>>                       .testUI(<TestClass::createAndShowUI>)
>>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>>                       .build()
>>                       .awaitAndCheck();
>> 
>> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
>> 
>> @aivanov-jdk has demonstrated custom test UI positioning in this PR: 
>> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   doc update

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21023#pullrequestreview-2310820280

From honkar at openjdk.org  Tue Sep 17 20:08:10 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 17 Sep 2024 20:08:10 GMT
Subject: Integrated: JDK-8340210 : Add positionTestUI() to
 PassFailJFrame.Builder
In-Reply-To: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
References: <_hYtl-HalmIy6fJ_mu6Kv9dYUXX8wwLbShWAqlv8jiA=.448debb3-5fbf-42e3-a6e3-0585cb8503a2@github.com>
Message-ID: <GRKP7qO4k6jMf9NjsLCz7ohSTH0lSuHdI6diBk6BXs0=.6f1ac57c-5f2d-4ca2-993f-0f2a4b064ca2@github.com>

On Mon, 16 Sep 2024 19:11:59 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> `positionTestUI()` option is added to PassFailJFrame (PFJ).
> 
> With this change multiple UI can be positioned using the PFJ new builder pattern by providing implementation for the Functional Interface `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)` in the test code. 
> 
> Since the position implementation is done in test code it allows flexibility as the user can add custom positioning code as per test UI requirements.
> 
> Usage:
> 
> PassFailJFrame.builder()
>                       .title("Test Instructions")
>                       .instructions(INSTRUCTIONS)
>                       .rows(int)
>                       .columns(int)
>                       .testUI(<TestClass::createAndShowUI>)
>                       .positionTestUI(<TestClass::positionMultiTestUI>)
>                       .build()
>                       .awaitAndCheck();
> 
> where positionMultiTestUI is the implementation for positioning of multiple test windows for `PositionWindows.positionTestWindows(List<? extends Window> testWindows,InstructionUI instructionUI)`
> 
> @aivanov-jdk has demonstrated custom test UI positioning in this PR: 
> **[8294156: Demo positioning of multiple test windows](https://github.com/openjdk/jdk/pull/15721)**

This pull request has now been integrated.

Changeset: f0ae90f3
Author:    Harshitha Onkar <honkar at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f0ae90f30c346544e87217ef1832d6a350fe1985
Stats:     23 lines in 1 file changed: 23 ins; 0 del; 0 mod

8340210: Add positionTestUI() to PassFailJFrame.Builder

Co-authored-by: Alexey Ivanov <aivanov at openjdk.org>
Reviewed-by: aivanov, azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/21023

From azvegint at openjdk.org  Tue Sep 17 20:16:04 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 17 Sep 2024 20:16:04 GMT
Subject: RFR: 8340078: Open source several 2D tests
In-Reply-To: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
References: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
Message-ID: <E5bVXexmbzN03J05DIWvTGglFqhQbdaAbXM3GUIEnT8=.812c574d-cf88-475a-a783-30039bb5c5c5@github.com>

On Tue, 17 Sep 2024 18:27:58 GMT, Phil Race <prr at openjdk.org> wrote:

> Open source 5 Java2D related rendering tests.

Changes requested by azvegint (Reviewer).

test/jdk/sun/java2d/GdiRendering/GdiLockTest.java line 28:

> 26:  * @bug 4693644
> 27:  * @summary verifies that there are no artifacts due to copying with GDI
> 28:  * @library java/awt/regtesthelpers

`test result: Error. Can't find library: java/awt/regtesthelpers`

Suggestion:

 * @library /java/awt/regtesthelpers

-------------

PR Review: https://git.openjdk.org/jdk/pull/21045#pullrequestreview-2310896603
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1763925919

From aivanov at openjdk.org  Tue Sep 17 20:36:05 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 20:36:05 GMT
Subject: RFR: 8339845: Update color.org and wapforum.org links to use HTTPS
 instead of HTTP
In-Reply-To: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
References: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
Message-ID: <0wS1qVCdabZKjxuRx3IBy3uA53nnKilyKQ8JaR9GsxQ=.0140fb6f-a835-4813-8df4-efb1ecd52c9a@github.com>

On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I get a review for this doc-only change? I updated some links because the websites moved from HTTP to HTTPS. The redirects can cause some false-positives on tests.
> 
> TIA

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21001#pullrequestreview-2311011048

From aivanov at openjdk.org  Tue Sep 17 20:43:05 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 17 Sep 2024 20:43:05 GMT
Subject: RFR: 8339845: Update color.org and wapforum.org links to use HTTPS
 instead of HTTP
In-Reply-To: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
References: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
Message-ID: <2iIFO4MQXVuZz2qJzbCTZ3OxUE3hBEgGIp4FcIYZIVg=.4c8dc5df-05e2-412d-98f9-39cc0d8da77a@github.com>

On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I get a review for this doc-only change? I updated some links because the websites moved from HTTP to HTTPS. The redirects can cause some false-positives on tests.
> 
> TIA

@nizarbenalla Looks you're a committer now. You have to issue the `/integrate` command again.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21001#issuecomment-2356883039

From ngubarkov at openjdk.org  Tue Sep 17 21:02:19 2024
From: ngubarkov at openjdk.org (Nikita Gubarkov)
Date: Tue, 17 Sep 2024 21:02:19 GMT
Subject: RFR: 8339341: SurfaceManager cacheMap retains strong references
 [v3]
In-Reply-To: <1ecWvJLiG54e0saEz_Jjz46gzxXnqsNDagdPQ3y_BN4=.27116e44-886b-405f-9d87-ec5e82e2fd20@github.com>
References: <1ecWvJLiG54e0saEz_Jjz46gzxXnqsNDagdPQ3y_BN4=.27116e44-886b-405f-9d87-ec5e82e2fd20@github.com>
Message-ID: <DJv2HleTy1AHZ1CSiDL7W0CdQ6a0KqpbHG6hB7jx2uM=.0615b515-429c-43a3-af5a-1bc5afd7bcac@github.com>

> I moved SurfaceDataProxy cache into a separate class.
> Now caching level is determined by placement of the SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" proxies and therefore strong refs via them do not prevent the cache and GraphicsConfig from being detected as weakly reachable.

Nikita Gubarkov has updated the pull request incrementally with one additional commit since the last revision:

  Move surface data proxy cache into base CGraphicsConfig

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20825/files
  - new: https://git.openjdk.org/jdk/pull/20825/files/3203ea9e..87866453

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20825&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20825&range=01-02

  Stats: 23 lines in 3 files changed: 7 ins; 14 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20825.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20825/head:pull/20825

PR: https://git.openjdk.org/jdk/pull/20825

From honkar at openjdk.org  Tue Sep 17 23:43:07 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 17 Sep 2024 23:43:07 GMT
Subject: RFR: 8340015: Open source several AWT focus tests - series 7 [v2]
In-Reply-To: <PZkBO7l5nzakzHctnjgNtYJkJ2Utibr9LX-gxd7dw30=.0df815ed-8837-46ef-8fcd-7efbde5fcccd@github.com>
References: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>
 <PZkBO7l5nzakzHctnjgNtYJkJ2Utibr9LX-gxd7dw30=.0df815ed-8837-46ef-8fcd-7efbde5fcccd@github.com>
Message-ID: <EeulNmwEoM0X7FwUiNwxlwpyyI_hcCGYvBilm2yTkMc=.5ec208fc-011f-4adb-92d6-7c57e1f64ee7@github.com>

On Tue, 17 Sep 2024 04:06:52 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few AWT focus tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   MToolkit removed

LGTM other than the minor inline review comments

test/jdk/java/awt/Focus/MinimizeNonfocusableWindowTest.java line 35:

> 33: import java.awt.Frame;
> 34: import java.awt.Panel;
> 35: import java.awt.Toolkit;

Unused import

test/jdk/java/awt/Focus/MinimizeNonfocusableWindowTest.java line 59:

> 57:                 .instructions(INSTRUCTIONS)
> 58:                 .rows((int) INSTRUCTIONS.lines().count() + 5)
> 59:                 .columns(35)

Looks better formatted with the following:

Suggestion:

                .rows((int) INSTRUCTIONS.lines().count() + 1)
                .columns(40)

test/jdk/java/awt/Focus/MinimizeNonfocusableWindowTest.java line 66:

> 64: 
> 65:     private static List<Window> createTestUI() {
> 66:         Panel panel = new Panel();

Unused variable can be removed.

test/jdk/java/awt/Focus/WindowDisposeFocusTest.java line 68:

> 66: 
> 67:     static public Window test(String[] args) {
> 68:         final JFrame frame = new JFrame();

Frame title is missing. 
Does setting a frame size look better here although the test is more to do with the dialogs?

test/jdk/java/awt/Focus/bug6435715.java line 78:

> 76:                 synchronized (this) {
> 77:                     try {
> 78:                         wait(3000);

Is large wait time required here? I think it can be reduced.

test/jdk/java/awt/Focus/bug6435715.java line 90:

> 88:         return fr;
> 89:     }
> 90: 

extra new line can be removed.

test/jdk/java/awt/Focus/bug6435715.java line 92:

> 90: 
> 91: }
> 92: 

extra new line can be removed.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21008#pullrequestreview-2311274622
PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1764150936
PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1764158164
PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1764151437
PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1764211515
PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1764216160
PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1764215060
PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1764215334

From honkar at openjdk.org  Wed Sep 18 00:36:05 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 18 Sep 2024 00:36:05 GMT
Subject: RFR: 8339902: Open source couple TextField related tests [v6]
In-Reply-To: <vzgFoKDCekHILA2r2HL0bQZRWX2xegFkXzTKf4YNOPY=.3d2b3493-c587-4689-b06f-576c55170631@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
 <vzgFoKDCekHILA2r2HL0bQZRWX2xegFkXzTKf4YNOPY=.3d2b3493-c587-4689-b06f-576c55170631@github.com>
Message-ID: <Bm17lFuwEPGwIlyYfyG4SUhuXNmIKNDfIA3wM_-eEWI=.a8f7dfc1-4311-4c9b-a764-00cc79bebad3@github.com>

On Tue, 17 Sep 2024 04:07:53 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Clean up and open source five TextField related tests: 
>> java/awt/TextField/CaretPositionTest;
>> java/awt/TextField/SetBoundsTest;
>> java/awt/TextField/SetEchoCharTest4;
>> java/awt/TextField/SetPasswordTest;
>> java/awt/TextField/ZeroEchoCharTest
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java
>   
>   Co-authored-by: Harshitha Onkar <harshitha.onkar at oracle.com>

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21026#pullrequestreview-2311391489

From honkar at openjdk.org  Wed Sep 18 01:00:10 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 18 Sep 2024 01:00:10 GMT
Subject: RFR: 8340078: Open source several 2D tests
In-Reply-To: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
References: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
Message-ID: <XLYbI_ANidVlgTHNTYN72dj2EhR3pXrmEv3NlsxlwyM=.8f2451c3-2018-4e00-8c34-6e280d4fd65b@github.com>

On Tue, 17 Sep 2024 18:27:58 GMT, Phil Race <prr at openjdk.org> wrote:

> Open source 5 Java2D related rendering tests.

Other than the following minor comments and the lib path mentioned here https://github.com/openjdk/jdk/pull/21045#discussion_r1763925919 , everything else looks good.

test/jdk/sun/java2d/SunGraphics2D/RevalidateBug.java line 34:

> 32:  */
> 33: 
> 34: import java.awt.Color;

Unused import.

test/jdk/sun/java2d/SunGraphics2D/ScaledPolyTest.java line 31:

> 29: 
> 30: import java.awt.Color;
> 31: import static java.awt.Color.*;

static import redudant here.

test/jdk/sun/java2d/SunGraphics2D/ScaledPolyTest.java line 38:

> 36: public class ScaledPolyTest {
> 37: 
> 38:     public static void main(String argv[]) {

Suggestion:

    public static void main(String[] argv) {

-------------

PR Review: https://git.openjdk.org/jdk/pull/21045#pullrequestreview-2311400355
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1764249465
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1764248906
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1764249519

From honkar at openjdk.org  Wed Sep 18 01:08:06 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 18 Sep 2024 01:08:06 GMT
Subject: RFR: 8340015: Open source several AWT focus tests - series 7 [v2]
In-Reply-To: <PZkBO7l5nzakzHctnjgNtYJkJ2Utibr9LX-gxd7dw30=.0df815ed-8837-46ef-8fcd-7efbde5fcccd@github.com>
References: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>
 <PZkBO7l5nzakzHctnjgNtYJkJ2Utibr9LX-gxd7dw30=.0df815ed-8837-46ef-8fcd-7efbde5fcccd@github.com>
Message-ID: <dx-qRAVYiKcY1BWluqk7eOkgzBOyZnVhkaX5_KVGXvk=.8aab86d5-e432-4166-9a14-c3bf129ab558@github.com>

On Tue, 17 Sep 2024 04:06:52 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few AWT focus tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   MToolkit removed

test/jdk/java/awt/Focus/MinimizeNonfocusableWindowTest.java line 61:

> 59:                 .columns(35)
> 60:                 .testUI(MinimizeNonfocusableWindowTest::createTestUI)
> 61:                 .build()

Suggestion:
`positionTestUI()` has been recently added to PassFailJFrame https://github.com/openjdk/jdk/pull/21023
Since this test has multiple test UIs you can try the new option to position them if it doesn't require much re-work.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1764255844

From psadhukhan at openjdk.org  Wed Sep 18 03:18:47 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 18 Sep 2024 03:18:47 GMT
Subject: RFR: 8340015: Open source several AWT focus tests - series 7 [v3]
In-Reply-To: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>
References: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>
Message-ID: <Z0RiN0XHBR1r_RlZ8YDyk0AlLzCr64rXV1GBRrx5LYo=.f30f125e-f7cb-4b42-851b-93fc9f986e25@github.com>

> Opensource few AWT focus tests

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21008/files
  - new: https://git.openjdk.org/jdk/pull/21008/files/a385e767..ef1d9d86

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21008&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21008&range=01-02

  Stats: 9 lines in 3 files changed: 1 ins; 4 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/21008.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21008/head:pull/21008

PR: https://git.openjdk.org/jdk/pull/21008

From psadhukhan at openjdk.org  Wed Sep 18 03:18:48 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 18 Sep 2024 03:18:48 GMT
Subject: RFR: 8340015: Open source several AWT focus tests - series 7 [v2]
In-Reply-To: <EeulNmwEoM0X7FwUiNwxlwpyyI_hcCGYvBilm2yTkMc=.5ec208fc-011f-4adb-92d6-7c57e1f64ee7@github.com>
References: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>
 <PZkBO7l5nzakzHctnjgNtYJkJ2Utibr9LX-gxd7dw30=.0df815ed-8837-46ef-8fcd-7efbde5fcccd@github.com>
 <EeulNmwEoM0X7FwUiNwxlwpyyI_hcCGYvBilm2yTkMc=.5ec208fc-011f-4adb-92d6-7c57e1f64ee7@github.com>
Message-ID: <pUjN6iaQEAxWiQ-O2jjRkPqHIPad80c_8L9p2u0Hgoo=.76ab9078-4af6-4b00-9126-a62db14ea9fa@github.com>

On Tue, 17 Sep 2024 23:40:49 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   MToolkit removed
>
> LGTM other than the minor inline review comments

@honkar-jdk please rereview..

> test/jdk/java/awt/Focus/MinimizeNonfocusableWindowTest.java line 59:
> 
>> 57:                 .instructions(INSTRUCTIONS)
>> 58:                 .rows((int) INSTRUCTIONS.lines().count() + 5)
>> 59:                 .columns(35)
> 
> Looks better formatted with the following:
> 
> Suggestion:
> 
>                 .rows((int) INSTRUCTIONS.lines().count() + 1)
>                 .columns(40)

ok

> test/jdk/java/awt/Focus/MinimizeNonfocusableWindowTest.java line 61:
> 
>> 59:                 .columns(35)
>> 60:                 .testUI(MinimizeNonfocusableWindowTest::createTestUI)
>> 61:                 .build()
> 
> Suggestion:
> `positionTestUI()` has been recently added to PassFailJFrame https://github.com/openjdk/jdk/pull/21023
> Since this test has multiple test UIs you can try the new option to position them if it doesn't require much re-work.

I will skip this one as it has already been positioned and I dont think the API will auto-position unlike testUI

> test/jdk/java/awt/Focus/MinimizeNonfocusableWindowTest.java line 66:
> 
>> 64: 
>> 65:     private static List<Window> createTestUI() {
>> 66:         Panel panel = new Panel();
> 
> Unused variable can be removed.

ok

> test/jdk/java/awt/Focus/WindowDisposeFocusTest.java line 68:
> 
>> 66: 
>> 67:     static public Window test(String[] args) {
>> 68:         final JFrame frame = new JFrame();
> 
> Frame title is missing. 
> Does setting a frame size look better here although the test is more to do with the dialogs?

ok

> test/jdk/java/awt/Focus/bug6435715.java line 78:
> 
>> 76:                 synchronized (this) {
>> 77:                     try {
>> 78:                         wait(3000);
> 
> Is large wait time required here? I think it can be reduced.

reduced..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21008#issuecomment-2357409777
PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1764335877
PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1764336544
PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1764335831
PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1764336061
PR Review Comment: https://git.openjdk.org/jdk/pull/21008#discussion_r1764335944

From psadhukhan at openjdk.org  Wed Sep 18 03:42:24 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 18 Sep 2024 03:42:24 GMT
Subject: RFR: 8339895: Open source several AWT focus tests - series 3
Message-ID: <CzS6G3XZR45SyXRYSIQN97O74FJbZCgdCVyGCufwqLg=.d0cb643b-03d5-477c-8d04-ed69caf3468c@github.com>

Opensource few focus tests

-------------

Commit messages:
 - 8339895: Open source several AWT focus tests - series 3
 - 8339895: Open source several AWT focus tests - series 3

Changes: https://git.openjdk.org/jdk/pull/21050/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21050&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339895
  Stats: 644 lines in 5 files changed: 644 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21050.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21050/head:pull/21050

PR: https://git.openjdk.org/jdk/pull/21050

From psadhukhan at openjdk.org  Wed Sep 18 03:56:44 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 18 Sep 2024 03:56:44 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4
Message-ID: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>

Opensource few Focus tests

-------------

Commit messages:
 - 8339906: Open source several AWT focus tests - series 4

Changes: https://git.openjdk.org/jdk/pull/21051/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21051&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339906
  Stats: 506 lines in 4 files changed: 506 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21051.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21051/head:pull/21051

PR: https://git.openjdk.org/jdk/pull/21051

From honkar at openjdk.org  Wed Sep 18 04:17:05 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 18 Sep 2024 04:17:05 GMT
Subject: RFR: 8340015: Open source several AWT focus tests - series 7 [v3]
In-Reply-To: <Z0RiN0XHBR1r_RlZ8YDyk0AlLzCr64rXV1GBRrx5LYo=.f30f125e-f7cb-4b42-851b-93fc9f986e25@github.com>
References: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>
 <Z0RiN0XHBR1r_RlZ8YDyk0AlLzCr64rXV1GBRrx5LYo=.f30f125e-f7cb-4b42-851b-93fc9f986e25@github.com>
Message-ID: <WlyD-BU2ONIFS6upqXQCwKpQnu_LLi2d2jllxLyaF3o=.e5e9bcba-26b0-46f1-8663-227e85d50a71@github.com>

On Wed, 18 Sep 2024 03:18:47 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few AWT focus tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21008#pullrequestreview-2311572116

From psadhukhan at openjdk.org  Wed Sep 18 04:17:47 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 18 Sep 2024 04:17:47 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v2]
In-Reply-To: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
Message-ID: <j9p5AGo89K7-U1lwXkaHI8h4W1qG9O0V67ukq7ZDj6I=.60467eb1-653c-42d5-adbb-b4a80b0c7285@github.com>

> Opensource few Focus tests

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Test automated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21051/files
  - new: https://git.openjdk.org/jdk/pull/21051/files/42accbbe..0d9821fb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21051&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21051&range=00-01

  Stats: 50 lines in 1 file changed: 13 ins; 5 del; 32 mod
  Patch: https://git.openjdk.org/jdk/pull/21051.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21051/head:pull/21051

PR: https://git.openjdk.org/jdk/pull/21051

From jdv at openjdk.org  Wed Sep 18 04:28:08 2024
From: jdv at openjdk.org (Jayathirth D V)
Date: Wed, 18 Sep 2024 04:28:08 GMT
Subject: RFR: JDK-8339962 : Open source AWT TextField tests - Set1 [v3]
In-Reply-To: <Fog0s8VOThwYsgzPpN1mQaUXJVLVEOxG2tcDr5Vritc=.eac43e4b-7862-4154-93eb-6cefd9d95514@github.com>
References: <v6evWDMdJ5taNxUxxPD-onH6DfUhWGyWSW69gyb87fo=.380962ba-cc65-403e-8337-33186b5d9e29@github.com>
 <Fog0s8VOThwYsgzPpN1mQaUXJVLVEOxG2tcDr5Vritc=.eac43e4b-7862-4154-93eb-6cefd9d95514@github.com>
Message-ID: <L2d4hNGRw2jHPoeWNLD8nRVdTwBO5jT2PU3UgOCBl_8=.3cbe556f-1b68-47df-972e-20d990d96eab@github.com>

On Mon, 16 Sep 2024 22:59:35 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test are open-sourced.
>> 
>> 1. 	test/jdk/java/awt/Label/ContainerValidateTest.java - Automated
>> 2. 	test/jdk/java/awt/TextField/SetEchoCharTest.java - Automated
>> 3. 	test/jdk/java/awt/TextField/SetEchoCharWordOpsTest.java - PassFailJFrame manual test
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   typo fix

Marked as reviewed by jdv (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21005#pullrequestreview-2311581113

From abhiscxk at openjdk.org  Wed Sep 18 04:30:33 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 04:30:33 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v2]
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <pcyOS1jCTS_z3a7WOCY_uSNAxvai_l7i90O1jjZQydw=.0d72e1e0-5d6d-4d8c-a4ec-88d82a07e829@github.com>

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Review comment fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21029/files
  - new: https://git.openjdk.org/jdk/pull/21029/files/62efa2b7..e99e2bad

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=00-01

  Stats: 71 lines in 5 files changed: 10 ins; 22 del; 39 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From abhiscxk at openjdk.org  Wed Sep 18 04:30:34 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 04:30:34 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v2]
In-Reply-To: <0KuII4A9thnWARW5tWmwaEOw0c91WSN0WmjDqxYAY4Y=.a4c6f377-e5a1-4302-b389-67fdbb4aa157@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <0KuII4A9thnWARW5tWmwaEOw0c91WSN0WmjDqxYAY4Y=.a4c6f377-e5a1-4302-b389-67fdbb4aa157@github.com>
Message-ID: <o4fEvHUrprukoR8ATyhLZsj2BQSOOotMvlrNuTEdxII=.174f3d75-f905-4b51-ac48-2c479cdcfdae@github.com>

On Tue, 17 Sep 2024 19:00:55 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment fix
>
> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 48:
> 
>> 46:     private static final int NUM_WINDOWS = 400;
>> 47:     private static TestFrame firstFrame, testFrame;
>> 48:     private static Rectangle rect;
> 
> `rect` is never used.

Removed.

> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 86:
> 
>> 84:                 testFrame.setTitle("Last Frame");
>> 85:             }
>> 86:         }
> 
> Suggestion:
> 
>         for (int i = 1; i < NUM_WINDOWS - 1; ++i) {
>             testFrame = new TestFrame("Running(" + i + ")...");
>             testFrame.setVisible(false);
>             testFrame.dispose();
>         }
> 
>         testFrame = new TestFrame("Last Frame");
> 
> 
> Doesn't it make the code clearer and shorter?

Yeah.. updated now.

> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 98:
> 
>> 96:         firstFrame.setLocation(970, 350);
>> 97:         testFrame.setLocation(970, 510);
>> 98:     }
> 
> Hard-coding coordinates is not the best solution. The workaround is to position the first frame using `PassFailJFrame` and then use the location of the first frame to position the second (test) frame.
> Suggestion:
> 
>     @Override
>     public void componentShown(ComponentEvent e) {
>         PassFailJFrame.positionTestWindow(firstFrame,
>                                           PassFailJFrame.Position.HORIZONTAL);
>         testFrame.setLocation(firstFrame.getX(),
>                               firstFrame.getY() + firstFrame.getWidth() + 8);
>     }

I gave a try to get PassFailFrame position but some error occured and then hard coded. I agree hard-coding is not a best solution and thanks for suggesting the other way around. A bit of correction in setting the testFrame location, y co-ordinate should be firstFrame.getY() + firstFrame.getHeight() + 8 else the gap is more between firstFrame and testFrame.

> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 103:
> 
>> 101: }
>> 102: 
>> 103: class TestFrame extends Frame {
> 
> Could you please make `TestFrame` a static nested class inside `LotsOfMenuItemsTest`.
> 
> I avoids conflicts when you mark a folder as Test Source in an IDE and that folder contains multiple tests.
> 
> In fact, you don't need to extend `Frame` at all: create an instance of the `Frame` class and add menu bar and set the size of the frame. However, I agree, keeping this stuff in constructor simplifies test.

Updated.

> test/jdk/java/awt/MenuItem/MenuSetFontTest.java line 54:
> 
>> 52:                 .rows((int) INSTRUCTIONS.lines().count() + 2)
>> 53:                 .columns(40)
>> 54:                 .testTimeOut(5)
> 
> You may omit the default timeout.

Removed from all tests.

>Wouldn't it be better to keep the logical and visual order of the buttons consistent? Or is the intention to set the label to "text" after null followed by ""?

I Just left them as it was before conversion.

> test/jdk/java/awt/MenuItem/UnicodeMenuItemTest.java line 81:
> 
>> 79: 
>> 80:         MenuItem mi6 = new MenuItem("\u012d");
>> 81:         m.add(mi6);
> 
> The numbering is weird here: 2, 6, 7 ? but there's no `mi1` or `m3`?

Ok.. Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764371719
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764370259
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764371347
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764369981
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764372023
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764372474
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764372546

From psadhukhan at openjdk.org  Wed Sep 18 04:32:50 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 18 Sep 2024 04:32:50 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v3]
In-Reply-To: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
Message-ID: <-SetXAnjt6NZPmvVPxUNqm09A2PZE3F8Hjo2iorxkcg=.81418686-ae75-4558-a7f0-0592f416ab04@github.com>

> Opensource few Focus tests

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  jcheck

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21051/files
  - new: https://git.openjdk.org/jdk/pull/21051/files/0d9821fb..509ccf65

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21051&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21051&range=01-02

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/21051.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21051/head:pull/21051

PR: https://git.openjdk.org/jdk/pull/21051

From psadhukhan at openjdk.org  Wed Sep 18 04:36:14 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 18 Sep 2024 04:36:14 GMT
Subject: Integrated: 8340015: Open source several AWT focus tests - series 7
In-Reply-To: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>
References: <Uj5kqyjBlFjX9VxGGnpnO2VyJNLgOxNkijecuvSBdXc=.530e3e6c-a7c9-4055-b938-cf4e4aa34650@github.com>
Message-ID: <TJ9FCilX60zTg-E599qiJqWrelslHIRfsWNmI2UPoPA=.0ced3cd2-f06d-4521-8a66-c40853397800@github.com>

On Mon, 16 Sep 2024 04:16:01 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few AWT focus tests

This pull request has now been integrated.

Changeset: 147e3007
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/147e30070d8adbe65453a3a9316b9324890ea25f
Stats:     266 lines in 4 files changed: 266 ins; 0 del; 0 mod

8340015: Open source several AWT focus tests - series 7

Reviewed-by: honkar

-------------

PR: https://git.openjdk.org/jdk/pull/21008

From abhiscxk at openjdk.org  Wed Sep 18 04:43:50 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 04:43:50 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v3]
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <hQm3nSZwZrUMN3lw0d6LuJKH5etoLE9Oi0Ikh7yd2Qs=.96d149d0-d033-44d7-8375-dfe52bfaead3@github.com>

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Add requires tag

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21029/files
  - new: https://git.openjdk.org/jdk/pull/21029/files/e99e2bad..086c47b1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=01-02

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From abhiscxk at openjdk.org  Wed Sep 18 06:22:34 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 06:22:34 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests
Message-ID: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>

Few AWT Frame related tests are converted from applet to manual and moved to open.

-------------

Commit messages:
 - Tests converted from applet and open sourced

Changes: https://git.openjdk.org/jdk/pull/21052/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21052&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340084
  Stats: 396 lines in 5 files changed: 396 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21052.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21052/head:pull/21052

PR: https://git.openjdk.org/jdk/pull/21052

From jpai at openjdk.org  Wed Sep 18 09:12:18 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 18 Sep 2024 09:12:18 GMT
Subject: RFR: 8340360: Update -mx to -Xmx in UnninstallUIMemoryLeaks test
Message-ID: <GiTzTgqxJjGnmF06tUXixW797PLLki0DFEhgp_npLIA=.bdab6608-56ab-478f-a5c2-4664ffbaec19@github.com>

Can I please get a review of this test-only change which replaces the use of the outdated "-mx" option with the "-Xmx" option when launching the java processes in this test? This test was missed out from one of the earlier integrated PR.

The test continues to pass after this change.

-------------

Commit messages:
 - 8340360:Update -mx to -Xmx in UnninstallUIMemoryLeaks test

Changes: https://git.openjdk.org/jdk/pull/21053/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21053&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340360
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21053.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21053/head:pull/21053

PR: https://git.openjdk.org/jdk/pull/21053

From aivanov at openjdk.org  Wed Sep 18 10:12:09 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 10:12:09 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v3]
In-Reply-To: <o4fEvHUrprukoR8ATyhLZsj2BQSOOotMvlrNuTEdxII=.174f3d75-f905-4b51-ac48-2c479cdcfdae@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <0KuII4A9thnWARW5tWmwaEOw0c91WSN0WmjDqxYAY4Y=.a4c6f377-e5a1-4302-b389-67fdbb4aa157@github.com>
 <o4fEvHUrprukoR8ATyhLZsj2BQSOOotMvlrNuTEdxII=.174f3d75-f905-4b51-ac48-2c479cdcfdae@github.com>
Message-ID: <zbWO80wNbzpLaba4DDRQmbtEJjzcHfQ3kQL4enGR7wc=.e63c3fbe-7ff5-425f-a674-3074d41b3255@github.com>

On Wed, 18 Sep 2024 04:25:55 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 98:
>> 
>>> 96:         firstFrame.setLocation(970, 350);
>>> 97:         testFrame.setLocation(970, 510);
>>> 98:     }
>> 
>> Hard-coding coordinates is not the best solution. The workaround is to position the first frame using `PassFailJFrame` and then use the location of the first frame to position the second (test) frame.
>> Suggestion:
>> 
>>     @Override
>>     public void componentShown(ComponentEvent e) {
>>         PassFailJFrame.positionTestWindow(firstFrame,
>>                                           PassFailJFrame.Position.HORIZONTAL);
>>         testFrame.setLocation(firstFrame.getX(),
>>                               firstFrame.getY() + firstFrame.getWidth() + 8);
>>     }
>
> I gave a try to get PassFailFrame position but some error occured and then hard coded. I agree hard-coding is not a best solution and thanks for suggesting the other way around. A bit of correction in setting the testFrame location, y co-ordinate should be firstFrame.getY() + firstFrame.getHeight() + 8 else the gap is more between firstFrame and testFrame.

Yes, it should be `getHeight()`. I initially used `getSize().height` and then changed it to `getHeight()` and must have selected the wrong suggestion in IDE and ended up with `getWidth()` instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764784210

From aivanov at openjdk.org  Wed Sep 18 10:12:09 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 10:12:09 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v3]
In-Reply-To: <zbWO80wNbzpLaba4DDRQmbtEJjzcHfQ3kQL4enGR7wc=.e63c3fbe-7ff5-425f-a674-3074d41b3255@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <0KuII4A9thnWARW5tWmwaEOw0c91WSN0WmjDqxYAY4Y=.a4c6f377-e5a1-4302-b389-67fdbb4aa157@github.com>
 <o4fEvHUrprukoR8ATyhLZsj2BQSOOotMvlrNuTEdxII=.174f3d75-f905-4b51-ac48-2c479cdcfdae@github.com>
 <zbWO80wNbzpLaba4DDRQmbtEJjzcHfQ3kQL4enGR7wc=.e63c3fbe-7ff5-425f-a674-3074d41b3255@github.com>
Message-ID: <pKSRk-DTMu9q1MRWUMrgFmakNG-BJAvSGTOW4VG9O2Q=.ccdf1805-7312-44d0-9b87-09f4a2a541db@github.com>

On Wed, 18 Sep 2024 10:07:13 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I gave a try to get PassFailFrame position but some error occured and then hard coded. I agree hard-coding is not a best solution and thanks for suggesting the other way around. A bit of correction in setting the testFrame location, y co-ordinate should be firstFrame.getY() + firstFrame.getHeight() + 8 else the gap is more between firstFrame and testFrame.
>
> Yes, it should be `getHeight()`. I initially used `getSize().height` and then changed it to `getHeight()` and must have selected the wrong suggestion in IDE and ended up with `getWidth()` instead.

Actually, I thought `.positionTestWindow` would be called for the first window automatically, then you can position other windows based on the assigned location. Eventually, it's not called at all if a list of windows is created.

I'll submit a bug for it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764786778

From abhiscxk at openjdk.org  Wed Sep 18 10:15:06 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 10:15:06 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v3]
In-Reply-To: <pKSRk-DTMu9q1MRWUMrgFmakNG-BJAvSGTOW4VG9O2Q=.ccdf1805-7312-44d0-9b87-09f4a2a541db@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <0KuII4A9thnWARW5tWmwaEOw0c91WSN0WmjDqxYAY4Y=.a4c6f377-e5a1-4302-b389-67fdbb4aa157@github.com>
 <o4fEvHUrprukoR8ATyhLZsj2BQSOOotMvlrNuTEdxII=.174f3d75-f905-4b51-ac48-2c479cdcfdae@github.com>
 <zbWO80wNbzpLaba4DDRQmbtEJjzcHfQ3kQL4enGR7wc=.e63c3fbe-7ff5-425f-a674-3074d41b3255@github.com>
 <pKSRk-DTMu9q1MRWUMrgFmakNG-BJAvSGTOW4VG9O2Q=.ccdf1805-7312-44d0-9b87-09f4a2a541db@github.com>
Message-ID: <Ci4oRgv_Gc2HyKk16ecK7yPAeMZjLDkD6egdkQdRs7Y=.0acc171f-e13d-44a8-b810-8eaebdde7f70@github.com>

On Wed, 18 Sep 2024 10:09:09 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Actually, I thought .positionTestWindow would be called for the first window automatically

No. both window were overlapped near top-left corner.

> I'll submit a bug for it.

Ok.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764790896

From aivanov at openjdk.org  Wed Sep 18 10:37:12 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 10:37:12 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v3]
In-Reply-To: <hQm3nSZwZrUMN3lw0d6LuJKH5etoLE9Oi0Ikh7yd2Qs=.96d149d0-d033-44d7-8375-dfe52bfaead3@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <hQm3nSZwZrUMN3lw0d6LuJKH5etoLE9Oi0Ikh7yd2Qs=.96d149d0-d033-44d7-8375-dfe52bfaead3@github.com>
Message-ID: <V0UT-JIekt99HdGzttXhjqeFy-se0hnH_VsF3IFmuAM=.ea92fd72-d659-413a-8d68-c6f0518e48fb@github.com>

On Wed, 18 Sep 2024 04:43:50 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add requires tag

Marked as reviewed by aivanov (Reviewer).

test/jdk/java/awt/MenuItem/GiantFontTest.java line 43:

> 41:         String INSTRUCTIONS = """
> 42:                         A frame with one menu will appear.
> 43:                         On Solaris, the menu's font should be quite large (48 point).

What about Linux? Solaris isn't supported by JDK any more.

Here, you may want to clarify where it's referring to a menu (item) on the menu bar and where the instructions refer to popup menu shown after activating the item on the menu bar. Just to make the instructions clearer.

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 51:

> 49:         LotsOfMenuItemsTest obj = new LotsOfMenuItemsTest();
> 50:         String INSTRUCTIONS = """
> 51:                 This test creates lots of frames with menubars.

Suggestion:

                This test creates lots of frames with menu bars.

It's usually spelt with a space.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2312285523
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764818954
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764810457

From abhiscxk at openjdk.org  Wed Sep 18 10:51:49 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 10:51:49 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v4]
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <_iAKIE0Ok4e_OjNBXwFLpABZJg3E54u93lO0_ovyVwc=.f5020b81-e55f-4360-bcc6-40b04ee194f4@github.com>

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Test instruction update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21029/files
  - new: https://git.openjdk.org/jdk/pull/21029/files/086c47b1..b13b2576

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=02-03

  Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From abhiscxk at openjdk.org  Wed Sep 18 10:51:50 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 10:51:50 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v3]
In-Reply-To: <V0UT-JIekt99HdGzttXhjqeFy-se0hnH_VsF3IFmuAM=.ea92fd72-d659-413a-8d68-c6f0518e48fb@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <hQm3nSZwZrUMN3lw0d6LuJKH5etoLE9Oi0Ikh7yd2Qs=.96d149d0-d033-44d7-8375-dfe52bfaead3@github.com>
 <V0UT-JIekt99HdGzttXhjqeFy-se0hnH_VsF3IFmuAM=.ea92fd72-d659-413a-8d68-c6f0518e48fb@github.com>
Message-ID: <KPpo2dbol78tTTpvYKYJxEcnyyogh7-QEVWur6h9X5Y=.304bf34c-00ab-41f5-b8fe-6102ef9e717e@github.com>

On Wed, 18 Sep 2024 10:33:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> What about Linux? Solaris isn't supported by JDK any more.

Tested on linux. Menu's font are large and on Windows it is normal size.  

> Here, you may want to clarify where it's referring to a menu (item) on the menu bar and where the instructions refer to popup menu shown after activating the item on the menu bar. Just to make the instructions clearer.

It is about the menu present on menu bar. Modified the test instructions.

> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 51:
> 
>> 49:         LotsOfMenuItemsTest obj = new LotsOfMenuItemsTest();
>> 50:         String INSTRUCTIONS = """
>> 51:                 This test creates lots of frames with menubars.
> 
> Suggestion:
> 
>                 This test creates lots of frames with menu bars.
> 
> It's usually spelt with a space.

Ok.. updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764836399
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764834778

From aivanov at openjdk.org  Wed Sep 18 10:55:05 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 10:55:05 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v4]
In-Reply-To: <Ci4oRgv_Gc2HyKk16ecK7yPAeMZjLDkD6egdkQdRs7Y=.0acc171f-e13d-44a8-b810-8eaebdde7f70@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <0KuII4A9thnWARW5tWmwaEOw0c91WSN0WmjDqxYAY4Y=.a4c6f377-e5a1-4302-b389-67fdbb4aa157@github.com>
 <o4fEvHUrprukoR8ATyhLZsj2BQSOOotMvlrNuTEdxII=.174f3d75-f905-4b51-ac48-2c479cdcfdae@github.com>
 <zbWO80wNbzpLaba4DDRQmbtEJjzcHfQ3kQL4enGR7wc=.e63c3fbe-7ff5-425f-a674-3074d41b3255@github.com>
 <pKSRk-DTMu9q1MRWUMrgFmakNG-BJAvSGTOW4VG9O2Q=.ccdf1805-7312-44d0-9b87-09f4a2a541db@github.com>
 <Ci4oRgv_Gc2HyKk16ecK7yPAeMZjLDkD6egdkQdRs7Y=.0acc171f-e13d-44a8-b810-8eaebdde7f70@github.com>
Message-ID: <YfZUddRL89DEKc_WfD80J-LxV839-td12Hqi1akSZcM=.d062b7a3-1565-42e1-b3db-680652276d63@github.com>

On Wed, 18 Sep 2024 10:12:27 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Actually, I thought `.positionTestWindow` would be called for the first window automatically, then you can position other windows based on the assigned location. Eventually, it's not called at all if a list of windows is created.
>> 
>> I'll submit a bug for it.
>
>> Actually, I thought .positionTestWindow would be called for the first window automatically
> 
> No. both window were overlapped near top-left corner.
> 
>> I'll submit a bug for it.
> 
> Ok.

> Actually, I thought `.positionTestWindow` would be called for the first window automatically, then you can position other windows based on the assigned location. Eventually, it's not called at all if a list of windows is created.
> 
> I'll submit a bug for it.

Submitted [JDK-8340365](https://bugs.openjdk.org/browse/JDK-8340365): _Position the first window of a window list_.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764840936

From serb at openjdk.org  Wed Sep 18 10:56:05 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Wed, 18 Sep 2024 10:56:05 GMT
Subject: RFR: 8340360: Update -mx to -Xmx in UnninstallUIMemoryLeaks test
In-Reply-To: <GiTzTgqxJjGnmF06tUXixW797PLLki0DFEhgp_npLIA=.bdab6608-56ab-478f-a5c2-4664ffbaec19@github.com>
References: <GiTzTgqxJjGnmF06tUXixW797PLLki0DFEhgp_npLIA=.bdab6608-56ab-478f-a5c2-4664ffbaec19@github.com>
Message-ID: <3ACnDuRZdnHN5vyAGo1-X3NXWe1StetPWeWzvFNnDHI=.e4b0582d-a373-4788-81cf-eb35899b3c0a@github.com>

On Wed, 18 Sep 2024 09:06:04 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which replaces the use of the outdated "-mx" option with the "-Xmx" option when launching the java processes in this test? This test was missed out from one of the earlier integrated PR.
> 
> The test continues to pass after this change.

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21053#pullrequestreview-2312337736

From aivanov at openjdk.org  Wed Sep 18 11:09:12 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 11:09:12 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v4]
In-Reply-To: <_iAKIE0Ok4e_OjNBXwFLpABZJg3E54u93lO0_ovyVwc=.f5020b81-e55f-4360-bcc6-40b04ee194f4@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <_iAKIE0Ok4e_OjNBXwFLpABZJg3E54u93lO0_ovyVwc=.f5020b81-e55f-4360-bcc6-40b04ee194f4@github.com>
Message-ID: <K9mL0yHOcR2yi02KJ8kcXMhdd9CGi1mTFkgsmR9NkP8=.cab20114-d162-461c-8856-16aae55baf19@github.com>

On Wed, 18 Sep 2024 10:51:49 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test instruction update

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2312364296

From nbenalla at openjdk.org  Wed Sep 18 11:10:27 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Wed, 18 Sep 2024 11:10:27 GMT
Subject: Integrated: 8339845: Update color.org and wapforum.org links to use
 HTTPS instead of HTTP
In-Reply-To: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
References: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
Message-ID: <c7LBJ2gQf16ogo4fo2H81D05MGRmno4Cq_4TCpmVZpc=.47ee33e6-9e19-488a-9024-fbb103cc9588@github.com>

On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I get a review for this doc-only change? I updated some links because the websites moved from HTTP to HTTPS. The redirects can cause some false-positives on tests.
> 
> TIA

This pull request has now been integrated.

Changeset: 45e438f3
Author:    Nizar Benalla <nbenalla at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/45e438f3f470c4af9d5066a4ae680f819bb3cde0
Stats:     9 lines in 5 files changed: 0 ins; 0 del; 9 mod

8339845: Update color.org and wapforum.org links to use HTTPS instead of HTTP

Reviewed-by: prr, honkar, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/21001

From nbenalla at openjdk.org  Wed Sep 18 11:10:27 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Wed, 18 Sep 2024 11:10:27 GMT
Subject: RFR: 8339845: Update color.org and wapforum.org links to use HTTPS
 instead of HTTP
In-Reply-To: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
References: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
Message-ID: <GA29-pLLcR1pdck0duekK830YUQ0EDpXXvQ13fRbkhg=.b312db10-1716-4558-9ac2-b837514fd93b@github.com>

On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I get a review for this doc-only change? I updated some links because the websites moved from HTTP to HTTPS. The redirects can cause some false-positives on tests.
> 
> TIA

I assumed this would be automatically merged once I became a committer.

Thank you all for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21001#issuecomment-2358175639

From aivanov at openjdk.org  Wed Sep 18 11:16:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 11:16:15 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v4]
In-Reply-To: <_iAKIE0Ok4e_OjNBXwFLpABZJg3E54u93lO0_ovyVwc=.f5020b81-e55f-4360-bcc6-40b04ee194f4@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <_iAKIE0Ok4e_OjNBXwFLpABZJg3E54u93lO0_ovyVwc=.f5020b81-e55f-4360-bcc6-40b04ee194f4@github.com>
Message-ID: <tgfFAsRHLi6PPUb49D_1sNPzU_BEflx2q2xGml9zSiw=.b2ae5be9-012c-4689-815f-4cb6d61d5f20@github.com>

On Wed, 18 Sep 2024 10:51:49 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test instruction update

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 83:

> 81:     }
> 82: 
> 83:     public void componentShown(ComponentEvent e) {

Suggestion:

    @Override
    public void componentShown(ComponentEvent e) {

Please add `@Override` annotation where applicable. It makes it explicit that a method implements an interface or overrides a method of a superclass.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764865262

From aivanov at openjdk.org  Wed Sep 18 11:24:06 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 11:24:06 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v4]
In-Reply-To: <_iAKIE0Ok4e_OjNBXwFLpABZJg3E54u93lO0_ovyVwc=.f5020b81-e55f-4360-bcc6-40b04ee194f4@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <_iAKIE0Ok4e_OjNBXwFLpABZJg3E54u93lO0_ovyVwc=.f5020b81-e55f-4360-bcc6-40b04ee194f4@github.com>
Message-ID: <PH3hoMHw8e_onidIObv6ARkULjfJnQN3jbeH72qXmwc=.430300e2-0dc1-49a7-9094-2ae3b5b43501@github.com>

On Wed, 18 Sep 2024 10:51:49 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test instruction update

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 65:

> 63:                 .rows((int) INSTRUCTIONS.lines().count() + 2)
> 64:                 .columns(40)
> 65:                 .testUI(obj.createAndShowUI())

Suggestion:

                .testUI(obj::createAndShowUI)

You should pass a method reference to call `createAndShowUI` on EDT.

When you pass a method reference, you delegate the job of calling the method to `PassFailJFrame` and it calls it on EDT.

If you use `obj.createAndShowUI`, you pass the result of calling `obj.createAndShowUI` ? the list of windows ? to `PassFailJFrame`, the method gets called on the main thread.

It's a subtle but important difference. I believe we're trying to ensure all components are created and accessed on EDT, both AWT and Swing, unless the test specifically verifies AWT components and needs to ensure these components behave as they should in a concurrent environment.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2312386493
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764872438

From abhiscxk at openjdk.org  Wed Sep 18 11:32:55 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 11:32:55 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v4]
In-Reply-To: <PH3hoMHw8e_onidIObv6ARkULjfJnQN3jbeH72qXmwc=.430300e2-0dc1-49a7-9094-2ae3b5b43501@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <_iAKIE0Ok4e_OjNBXwFLpABZJg3E54u93lO0_ovyVwc=.f5020b81-e55f-4360-bcc6-40b04ee194f4@github.com>
 <PH3hoMHw8e_onidIObv6ARkULjfJnQN3jbeH72qXmwc=.430300e2-0dc1-49a7-9094-2ae3b5b43501@github.com>
Message-ID: <QLnD9oAKdHapetQIQuOS7nb1wf6Jpe-2dfCNjl-_TKQ=.f4b87a54-c745-43ef-9411-554f0f8784e8@github.com>

On Wed, 18 Sep 2024 11:18:19 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test instruction update
>
> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 65:
> 
>> 63:                 .rows((int) INSTRUCTIONS.lines().count() + 2)
>> 64:                 .columns(40)
>> 65:                 .testUI(obj.createAndShowUI())
> 
> Suggestion:
> 
>                 .testUI(obj::createAndShowUI)
> 
> You should pass a method reference to call `createAndShowUI` on EDT.
> 
> When you pass a method reference, you delegate the job of calling the method to `PassFailJFrame` and it calls it on EDT.
> 
> If you use `obj.createAndShowUI`, you pass the result of calling `obj.createAndShowUI` ? the list of windows ? to `PassFailJFrame`, the method gets called on the main thread.
> 
> It's a subtle but important difference. I believe we're trying to ensure all components are created and accessed on EDT, both AWT and Swing, unless the test specifically verifies AWT components and needs to ensure these components behave as they should in a concurrent environment.

Updated.

> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 83:
> 
>> 81:     }
>> 82: 
>> 83:     public void componentShown(ComponentEvent e) {
> 
> Suggestion:
> 
>     @Override
>     public void componentShown(ComponentEvent e) {
> 
> Please add `@Override` annotation where applicable. It makes it explicit that a method implements an interface or overrides a method of a superclass.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764885524
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764885276

From abhiscxk at openjdk.org  Wed Sep 18 11:32:55 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 11:32:55 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v5]
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <ZnOWWt5zJhrGO19-6OOP43zUb_grWnr8_OsgzJGPrN0=.a6365393-fe39-4c8b-aed9-a09caf84f3c6@github.com>

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Review comment update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21029/files
  - new: https://git.openjdk.org/jdk/pull/21029/files/b13b2576..02e1a2f9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=03-04

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From aivanov at openjdk.org  Wed Sep 18 11:43:25 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 11:43:25 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v5]
In-Reply-To: <ZnOWWt5zJhrGO19-6OOP43zUb_grWnr8_OsgzJGPrN0=.a6365393-fe39-4c8b-aed9-a09caf84f3c6@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <ZnOWWt5zJhrGO19-6OOP43zUb_grWnr8_OsgzJGPrN0=.a6365393-fe39-4c8b-aed9-a09caf84f3c6@github.com>
Message-ID: <cMJNwyAIE3cXJuZr-RSb-YBMa__qYAchOT6HojUOU6M=.1daed066-609e-4685-838e-70f0ce8df3a9@github.com>

On Wed, 18 Sep 2024 11:32:55 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Looks good to me.

There's still a question with Solaris/Linux and macOS.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2312434941

From aivanov at openjdk.org  Wed Sep 18 11:43:25 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 11:43:25 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v3]
In-Reply-To: <KPpo2dbol78tTTpvYKYJxEcnyyogh7-QEVWur6h9X5Y=.304bf34c-00ab-41f5-b8fe-6102ef9e717e@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <hQm3nSZwZrUMN3lw0d6LuJKH5etoLE9Oi0Ikh7yd2Qs=.96d149d0-d033-44d7-8375-dfe52bfaead3@github.com>
 <V0UT-JIekt99HdGzttXhjqeFy-se0hnH_VsF3IFmuAM=.ea92fd72-d659-413a-8d68-c6f0518e48fb@github.com>
 <KPpo2dbol78tTTpvYKYJxEcnyyogh7-QEVWur6h9X5Y=.304bf34c-00ab-41f5-b8fe-6102ef9e717e@github.com>
Message-ID: <WdicwH8x6t1JHPNrow9V0XSZvTG3VreYZfe6KIdPVxI=.c6049235-f45f-4f35-8bae-64f0eadaf2ec@github.com>

On Wed, 18 Sep 2024 10:48:23 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> > What about Linux? Solaris isn't supported by JDK any more.
> 
> Tested on linux. Menu's font are large and on Windows it is normal size.

I'm for replacing Solaris with Linux. There's no way a test would be run on Solaris using the most recent version of Java.

When backporting, the text could be updated to ?on Linux _and Solaris_?.

What about macOS? The test can be run there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764901466

From abhiscxk at openjdk.org  Wed Sep 18 11:55:05 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 11:55:05 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v3]
In-Reply-To: <WdicwH8x6t1JHPNrow9V0XSZvTG3VreYZfe6KIdPVxI=.c6049235-f45f-4f35-8bae-64f0eadaf2ec@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <hQm3nSZwZrUMN3lw0d6LuJKH5etoLE9Oi0Ikh7yd2Qs=.96d149d0-d033-44d7-8375-dfe52bfaead3@github.com>
 <V0UT-JIekt99HdGzttXhjqeFy-se0hnH_VsF3IFmuAM=.ea92fd72-d659-413a-8d68-c6f0518e48fb@github.com>
 <KPpo2dbol78tTTpvYKYJxEcnyyogh7-QEVWur6h9X5Y=.304bf34c-00ab-41f5-b8fe-6102ef9e717e@github.com>
 <WdicwH8x6t1JHPNrow9V0XSZvTG3VreYZfe6KIdPVxI=.c6049235-f45f-4f35-8bae-64f0eadaf2ec@github.com>
Message-ID: <OeLj5cResYsahQMjZpmXc0dCzZfayb21QmhxiAp-1g0=.6b9cb44f-4099-456f-a084-b57ea786c89d@github.com>

On Wed, 18 Sep 2024 11:40:14 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>What about macOS? The test can be run there.

On macOS, it is of the normal font like windows. Should I update the instructions for macOS as well?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764916147

From abhiscxk at openjdk.org  Wed Sep 18 12:10:00 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 12:10:00 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v6]
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <jBedBftxrMsGt9uIWCl4h0Qa31TVSsxOEJDglNnICzY=.93c61fa0-a24f-494f-9916-7beba967d3ec@github.com>

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  test instruction update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21029/files
  - new: https://git.openjdk.org/jdk/pull/21029/files/02e1a2f9..e1366aaa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=04-05

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From abhiscxk at openjdk.org  Wed Sep 18 12:10:01 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 12:10:01 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v3]
In-Reply-To: <OeLj5cResYsahQMjZpmXc0dCzZfayb21QmhxiAp-1g0=.6b9cb44f-4099-456f-a084-b57ea786c89d@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <hQm3nSZwZrUMN3lw0d6LuJKH5etoLE9Oi0Ikh7yd2Qs=.96d149d0-d033-44d7-8375-dfe52bfaead3@github.com>
 <V0UT-JIekt99HdGzttXhjqeFy-se0hnH_VsF3IFmuAM=.ea92fd72-d659-413a-8d68-c6f0518e48fb@github.com>
 <KPpo2dbol78tTTpvYKYJxEcnyyogh7-QEVWur6h9X5Y=.304bf34c-00ab-41f5-b8fe-6102ef9e717e@github.com>
 <WdicwH8x6t1JHPNrow9V0XSZvTG3VreYZfe6KIdPVxI=.c6049235-f45f-4f35-8bae-64f0eadaf2ec@github.com>
 <OeLj5cResYsahQMjZpmXc0dCzZfayb21QmhxiAp-1g0=.6b9cb44f-4099-456f-a084-b57ea786c89d@github.com>
Message-ID: <zov0oZVLeQQRlhxPSmKcfmjY00comKu9gqzN4ygMc0M=.f7ff9449-f90e-46b0-96dc-b15c8e6bf353@github.com>

On Wed, 18 Sep 2024 11:52:16 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>>> > What about Linux? Solaris isn't supported by JDK any more.
>>> 
>>> Tested on linux. Menu's font are large and on Windows it is normal size.
>> 
>> I'm for replacing Solaris with Linux. There's no way a test would be run on Solaris using the most recent version of Java.
>> 
>> When backporting, the text could be updated to ?on Linux _and Solaris_?.
>> 
>> What about macOS? The test can be run there.
>
>>What about macOS? The test can be run there.
> 
> On macOS, it is of the normal font like windows. Should I update the instructions for macOS as well?

>I'm for replacing Solaris with Linux. There's no way a test would be run on Solaris using the most recent version of Java.
When backporting, the text could be updated to ?on Linux and Solaris?.
What about macOS? The test can be run there.

Replaced Solaris with Linux and updated the test instruction for MacOS as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764934721

From aivanov at openjdk.org  Wed Sep 18 12:10:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 12:10:13 GMT
Subject: RFR: 8340365: Position the first window of a window list
Message-ID: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>

Support of multiple test UI windows in `PassFailJFrame` is still evolving. After [JDK-8340210](https://bugs.openjdk.org/browse/JDK-8340210), the `Builder` has a method `positionTestUI` to supply an implementation of the `PositionWindows` interface which handles the positioning of all test UI windows created.

If `PositionWindows` is not provided, all the test UI windows are left with the default coordinates: (0, 0).

If `PassFailJFrame` called `positionTestWindow` for the first window, it would allow the test developer to position other windows based on the position of the first one.

This issue was raised in #21029 in [this thread of comments](https://github.com/openjdk/jdk/pull/21029#discussion_r1763744407).

To make it easier to position multiple test UI windows without implementing the `PositionWindows` interface, the `PassFailJFrame` should position the first window of the list.

The `LotsOfMenuItemsTest.java` test in #21029 had to hard-code the coordinates or use `PassFailJFrame.positionTestWindow` explicitly in its `ComponentListener.componentShown`.

With the proposed change in this pull request, the implementation would use `ComponentListener.componentMoved`:


    @Override
    public void componentMoved(ComponentEvent e) {
        testFrame.setLocation(firstFrame.getX(),
                              firstFrame.getY() + firstFrame.getHeight() + 8);
    }


This has the advantage in that the test UI windows don't flicker for a short time in the upper left corner of the screen; and the developer has to handle only positioning the second window (frame).

However, this has a funny effect: if you move the first frame with mouse or in any other way, the second frame follows. To avoid such kind of behaviour, call `removeComponentListener` in the handler.

@honkar-jdk, @azvegint, could you take a look?

-------------

Commit messages:
 - 8340365: Position the first window of a window list

Changes: https://git.openjdk.org/jdk/pull/21057/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21057&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340365
  Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21057.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21057/head:pull/21057

PR: https://git.openjdk.org/jdk/pull/21057

From aivanov at openjdk.org  Wed Sep 18 12:13:06 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 12:13:06 GMT
Subject: RFR: 8340365: Position the first window of a window list
In-Reply-To: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
References: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
Message-ID: <0PgNbnZZEv-VkfG9LD2fS-VzvOAZxoRBp_So1_KJBoc=.03da7ba1-e5f5-472e-a2bb-1eda627eed45@github.com>

On Wed, 18 Sep 2024 12:05:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Support of multiple test UI windows in `PassFailJFrame` is still evolving. After [JDK-8340210](https://bugs.openjdk.org/browse/JDK-8340210), the `Builder` has a method `positionTestUI` to supply an implementation of the `PositionWindows` interface which handles the positioning of all test UI windows created.
> 
> If `PositionWindows` is not provided, all the test UI windows are left with the default coordinates: (0, 0).
> 
> If `PassFailJFrame` called `positionTestWindow` for the first window, it would allow the test developer to position other windows based on the position of the first one.
> 
> This issue was raised in #21029 in [this thread of comments](https://github.com/openjdk/jdk/pull/21029#discussion_r1763744407).
> 
> To make it easier to position multiple test UI windows without implementing the `PositionWindows` interface, the `PassFailJFrame` should position the first window of the list.
> 
> The `LotsOfMenuItemsTest.java` test in #21029 had to hard-code the coordinates or use `PassFailJFrame.positionTestWindow` explicitly in its `ComponentListener.componentShown`.
> 
> With the proposed change in this pull request, the implementation would use `ComponentListener.componentMoved`:
> 
> 
>     @Override
>     public void componentMoved(ComponentEvent e) {
>         testFrame.setLocation(firstFrame.getX(),
>                               firstFrame.getY() + firstFrame.getHeight() + 8);
>     }
> 
> 
> This has the advantage in that the test UI windows don't flicker for a short time in the upper left corner of the screen; and the developer has to handle only positioning the second window (frame).
> 
> However, this has a funny effect: if you move the first frame with mouse or in any other way, the second frame follows. To avoid such kind of behaviour, call `removeComponentListener` in the handler.
> 
> @honkar-jdk, @azvegint, could you take a look?

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 354:

> 352:                 Window window = builder.testWindows.get(0);
> 353:                 positionTestWindow(window, builder.position);
> 354:             }

The previous `else` branch was used where `builder.testWindows` contained more than 1 window. This becomes redundant.

The conditions `builder.testWindows.size() >= 1` or `!builder.testWindows.isEmpty()` are always `true` when this code is reached, therefore I used a simple `else`-block instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21057#discussion_r1764941102

From aivanov at openjdk.org  Wed Sep 18 12:23:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 12:23:15 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v3]
In-Reply-To: <zov0oZVLeQQRlhxPSmKcfmjY00comKu9gqzN4ygMc0M=.f7ff9449-f90e-46b0-96dc-b15c8e6bf353@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <hQm3nSZwZrUMN3lw0d6LuJKH5etoLE9Oi0Ikh7yd2Qs=.96d149d0-d033-44d7-8375-dfe52bfaead3@github.com>
 <V0UT-JIekt99HdGzttXhjqeFy-se0hnH_VsF3IFmuAM=.ea92fd72-d659-413a-8d68-c6f0518e48fb@github.com>
 <KPpo2dbol78tTTpvYKYJxEcnyyogh7-QEVWur6h9X5Y=.304bf34c-00ab-41f5-b8fe-6102ef9e717e@github.com>
 <WdicwH8x6t1JHPNrow9V0XSZvTG3VreYZfe6KIdPVxI=.c6049235-f45f-4f35-8bae-64f0eadaf2ec@github.com>
 <OeLj5cResYsahQMjZpmXc0dCzZfayb21QmhxiAp-1g0=.6b9cb44f-4099-456f-a084-b57ea786c89d@github.com>
 <zov0oZVLeQQRlhxPSmKcfmjY00comKu9gqzN4ygMc0M=.f7ff9449-f90e-46b0-96dc-b15c8e6bf353@github.com>
Message-ID: <5IgdkOJDsenENTPRYyePD-Y1psoJ3LkHm5NodWAziFc=.0651cc50-582e-4dc7-a599-50a0bf230763@github.com>

On Wed, 18 Sep 2024 12:06:31 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>>>What about macOS? The test can be run there.
>> 
>> On macOS, it is of the normal font like windows. Should I update the instructions for macOS as well?
>
>>I'm for replacing Solaris with Linux. There's no way a test would be run on Solaris using the most recent version of Java.
> When backporting, the text could be updated to ?on Linux and Solaris?.
> What about macOS? The test can be run there.
> 
> Replaced Solaris with Linux and updated the test instruction for MacOS as well.

> > What about macOS? The test can be run there.
> 
> On macOS, it is of the normal font like windows. Should I update the instructions for macOS as well?

Looks like the test isn't applicable to macOS at all. AWT menu bar integrates with the macOS native menu bar at the top, the application can't seem to control how menu is rendered there, so both the item on the menu bar and items in the popup menu remain of regular font size.

On Windows, the menu items in the popup menu use the large font.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764954422

From abhiscxk at openjdk.org  Wed Sep 18 12:29:08 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 12:29:08 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v3]
In-Reply-To: <5IgdkOJDsenENTPRYyePD-Y1psoJ3LkHm5NodWAziFc=.0651cc50-582e-4dc7-a599-50a0bf230763@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <hQm3nSZwZrUMN3lw0d6LuJKH5etoLE9Oi0Ikh7yd2Qs=.96d149d0-d033-44d7-8375-dfe52bfaead3@github.com>
 <V0UT-JIekt99HdGzttXhjqeFy-se0hnH_VsF3IFmuAM=.ea92fd72-d659-413a-8d68-c6f0518e48fb@github.com>
 <KPpo2dbol78tTTpvYKYJxEcnyyogh7-QEVWur6h9X5Y=.304bf34c-00ab-41f5-b8fe-6102ef9e717e@github.com>
 <WdicwH8x6t1JHPNrow9V0XSZvTG3VreYZfe6KIdPVxI=.c6049235-f45f-4f35-8bae-64f0eadaf2ec@github.com>
 <OeLj5cResYsahQMjZpmXc0dCzZfayb21QmhxiAp-1g0=.6b9cb44f-4099-456f-a084-b57ea786c89d@github.com>
 <zov0oZVLeQQRlhxPSmKcfmjY00comKu9gqzN4ygMc0M=.f7ff9449-f90e-46b0-96dc-b15c8e6bf353@github.com>
 <5IgdkOJDsenENTPRYyePD-Y1psoJ3LkHm5NodWAziFc=.0651cc50-582e-4dc7-a599-50a0bf230763@github.com>
Message-ID: <CObuSxFN7JnexIZy50FYAXhMhqB9XFX9pS6Q26WPFH0=.e345b138-ef81-4193-87e2-844acb9b723d@github.com>

On Wed, 18 Sep 2024 12:20:21 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>>I'm for replacing Solaris with Linux. There's no way a test would be run on Solaris using the most recent version of Java.
>> When backporting, the text could be updated to ?on Linux and Solaris?.
>> What about macOS? The test can be run there.
>> 
>> Replaced Solaris with Linux and updated the test instruction for MacOS as well.
>
>> > What about macOS? The test can be run there.
>> 
>> On macOS, it is of the normal font like windows. Should I update the instructions for macOS as well?
> 
> Looks like the test isn't applicable to macOS at all. AWT menu bar integrates with the macOS native menu bar at the top, the application can't seem to control how menu is rendered there, so both the item on the menu bar and items in the popup menu remain of regular font size.
> 
> On Windows, the menu items in the popup menu use the large font.

Yes, by default apple uses native menu bar option to show the application menubar. 

>On Windows, the menu items in the popup menu use the large font.

In Linux also, the menu items in the popup menu use the large font.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764964184

From aivanov at openjdk.org  Wed Sep 18 12:29:10 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 12:29:10 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v6]
In-Reply-To: <YfZUddRL89DEKc_WfD80J-LxV839-td12Hqi1akSZcM=.d062b7a3-1565-42e1-b3db-680652276d63@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <0KuII4A9thnWARW5tWmwaEOw0c91WSN0WmjDqxYAY4Y=.a4c6f377-e5a1-4302-b389-67fdbb4aa157@github.com>
 <o4fEvHUrprukoR8ATyhLZsj2BQSOOotMvlrNuTEdxII=.174f3d75-f905-4b51-ac48-2c479cdcfdae@github.com>
 <zbWO80wNbzpLaba4DDRQmbtEJjzcHfQ3kQL4enGR7wc=.e63c3fbe-7ff5-425f-a674-3074d41b3255@github.com>
 <pKSRk-DTMu9q1MRWUMrgFmakNG-BJAvSGTOW4VG9O2Q=.ccdf1805-7312-44d0-9b87-09f4a2a541db@github.com>
 <Ci4oRgv_Gc2HyKk16ecK7yPAeMZjLDkD6egdkQdRs7Y=.0acc171f-e13d-44a8-b810-8eaebdde7f70@github.com>
 <YfZUddRL89DEKc_WfD80J-LxV839-td12Hqi1akSZcM=.d062b7a3-1565-42e1-b3db-680652276d63@github.com>
Message-ID: <pTDqQlNpmpSbbIheZlHwobf81K15oIH9kzkor5Nak50=.31c49681-84a2-409c-9549-f7438bfae741@github.com>

On Wed, 18 Sep 2024 10:52:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > Actually, I thought `.positionTestWindow` would be called for the first window automatically, then you can position other windows based on the assigned location. Eventually, it's not called at all if a list of windows is created.
> > I'll submit a bug for it.
> 
> Submitted [JDK-8340365](https://bugs.openjdk.org/browse/JDK-8340365): _Position the first window of a window list_.

If that had been the case, you would've used `componentMoved` and the code would've been shorter by 1 line as shown in #21057:


    @Override
    public void componentMoved(ComponentEvent e) {
        testFrame.setLocation(firstFrame.getX(),
                              firstFrame.getY() + firstFrame.getHeight() + 8);
    }

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764963245

From aivanov at openjdk.org  Wed Sep 18 12:33:09 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 12:33:09 GMT
Subject: RFR: 8339845: Update color.org and wapforum.org links to use HTTPS
 instead of HTTP
In-Reply-To: <GA29-pLLcR1pdck0duekK830YUQ0EDpXXvQ13fRbkhg=.b312db10-1716-4558-9ac2-b837514fd93b@github.com>
References: <FLRKaYRB9wRNQcM4OydsYPgQ6vrfJ7h1Tp7Glz3jryg=.f758b083-644d-4d3d-8a6d-f3ec3b4f27c3@github.com>
 <GA29-pLLcR1pdck0duekK830YUQ0EDpXXvQ13fRbkhg=.b312db10-1716-4558-9ac2-b837514fd93b@github.com>
Message-ID: <Z9AvBuHrfWqJPGFjw3b5XZ0iBOUZr95xxNyMs5hDeB4=.e4a78482-6ada-4f05-9347-63606d497703@github.com>

On Wed, 18 Sep 2024 11:07:29 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> I assumed this would be automatically merged once I became a committer.

No, the Skara bots don't revisit the PRs after the OpenJDK Census is changed.

You weren't a committer when you issued the `/integrate` command, so it required a sponsor. By the time I decided to sponsor, you're already a committer, and no one can sponsor integrating any more.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21001#issuecomment-2358341219

From abhiscxk at openjdk.org  Wed Sep 18 12:35:35 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 12:35:35 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v7]
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <Hzt5Z3fDvJxNQ6dY-PRPrytO6SK3gK0kIcCvanrJz0U=.aaf1a643-4ed5-41cf-a402-d790e33b298b@github.com>

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  test instruction update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21029/files
  - new: https://git.openjdk.org/jdk/pull/21029/files/e1366aaa..987ac818

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=05-06

  Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From abhiscxk at openjdk.org  Wed Sep 18 12:35:35 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 12:35:35 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v3]
In-Reply-To: <CObuSxFN7JnexIZy50FYAXhMhqB9XFX9pS6Q26WPFH0=.e345b138-ef81-4193-87e2-844acb9b723d@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <hQm3nSZwZrUMN3lw0d6LuJKH5etoLE9Oi0Ikh7yd2Qs=.96d149d0-d033-44d7-8375-dfe52bfaead3@github.com>
 <V0UT-JIekt99HdGzttXhjqeFy-se0hnH_VsF3IFmuAM=.ea92fd72-d659-413a-8d68-c6f0518e48fb@github.com>
 <KPpo2dbol78tTTpvYKYJxEcnyyogh7-QEVWur6h9X5Y=.304bf34c-00ab-41f5-b8fe-6102ef9e717e@github.com>
 <WdicwH8x6t1JHPNrow9V0XSZvTG3VreYZfe6KIdPVxI=.c6049235-f45f-4f35-8bae-64f0eadaf2ec@github.com>
 <OeLj5cResYsahQMjZpmXc0dCzZfayb21QmhxiAp-1g0=.6b9cb44f-4099-456f-a084-b57ea786c89d@github.com>
 <zov0oZVLeQQRlhxPSmKcfmjY00comKu9gqzN4ygMc0M=.f7ff9449-f90e-46b0-96dc-b15c8e6bf353@github.com>
 <5IgdkOJDsenENTPRYyePD-Y1psoJ3LkHm5NodWAziFc=.0651cc50-582e-4dc7-a599-50a0bf230763@github.com>
 <CObuSxFN7JnexIZy50FYAXhMhqB9XFX9pS6Q26WPFH0=.e345b138-ef81-4193-87e2-844acb9b723d@github.com>
Message-ID: <9T0kY99C99RxovPsHJprjNhFbXd2YK8ma8llY4YSAVs=.aceae5c8-e8a1-4e17-ab7d-5b86381a3972@github.com>

On Wed, 18 Sep 2024 12:26:53 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>>> > What about macOS? The test can be run there.
>>> 
>>> On macOS, it is of the normal font like windows. Should I update the instructions for macOS as well?
>> 
>> Looks like the test isn't applicable to macOS at all. AWT menu bar integrates with the macOS native menu bar at the top, the application can't seem to control how menu is rendered there, so both the item on the menu bar and items in the popup menu remain of regular font size.
>> 
>> On Windows, the menu items in the popup menu use the large font.
>
> Yes, by default apple uses native menu bar option to show the application menubar. 
> 
>>On Windows, the menu items in the popup menu use the large font.
> 
> In Linux also, the menu items in the popup menu use the large font.

Updated the test instruction and also captured menu items font size.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764967902

From abhiscxk at openjdk.org  Wed Sep 18 12:35:35 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 12:35:35 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v7]
In-Reply-To: <pTDqQlNpmpSbbIheZlHwobf81K15oIH9kzkor5Nak50=.31c49681-84a2-409c-9549-f7438bfae741@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <0KuII4A9thnWARW5tWmwaEOw0c91WSN0WmjDqxYAY4Y=.a4c6f377-e5a1-4302-b389-67fdbb4aa157@github.com>
 <o4fEvHUrprukoR8ATyhLZsj2BQSOOotMvlrNuTEdxII=.174f3d75-f905-4b51-ac48-2c479cdcfdae@github.com>
 <zbWO80wNbzpLaba4DDRQmbtEJjzcHfQ3kQL4enGR7wc=.e63c3fbe-7ff5-425f-a674-3074d41b3255@github.com>
 <pKSRk-DTMu9q1MRWUMrgFmakNG-BJAvSGTOW4VG9O2Q=.ccdf1805-7312-44d0-9b87-09f4a2a541db@github.com>
 <Ci4oRgv_Gc2HyKk16ecK7yPAeMZjLDkD6egdkQdRs7Y=.0acc171f-e13d-44a8-b810-8eaebdde7f70@github.com>
 <YfZUddRL89DEKc_WfD80J-LxV839-td12Hqi1akSZcM=.d062b7a3-1565-42e1-b3db-680652276d63@github.com>
 <pTDqQlNpmpSbbIheZlHwobf81K15oIH9kzkor5Nak50=.31c49681-84a2-409c-9549-f7438bfae741@github.com>
Message-ID: <O-VwDUYtfBXMNnfC1K2Uw4UgvCLjxIWT28ArsMJKDG8=.c5d4fb0e-e2d9-4514-aa10-7f2cdd61869b@github.com>

On Wed, 18 Sep 2024 12:26:19 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> Actually, I thought `.positionTestWindow` would be called for the first window automatically, then you can position other windows based on the assigned location. Eventually, it's not called at all if a list of windows is created.
>>> 
>>> I'll submit a bug for it.
>> 
>> Submitted [JDK-8340365](https://bugs.openjdk.org/browse/JDK-8340365): _Position the first window of a window list_.
>
>> > Actually, I thought `.positionTestWindow` would be called for the first window automatically, then you can position other windows based on the assigned location. Eventually, it's not called at all if a list of windows is created.
>> > I'll submit a bug for it.
>> 
>> Submitted [JDK-8340365](https://bugs.openjdk.org/browse/JDK-8340365): _Position the first window of a window list_.
> 
> If that had been the case, you would've used `componentMoved` and the code would've been shorter by 1 line as shown in #21057:
> 
> 
>     @Override
>     public void componentMoved(ComponentEvent e) {
>         testFrame.setLocation(firstFrame.getX(),
>                               firstFrame.getY() + firstFrame.getHeight() + 8);
>     }

I saw your PR and to reflect the changes here https://github.com/openjdk/jdk/pull/21057 should get integrated first.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764971651

From abhiscxk at openjdk.org  Wed Sep 18 12:38:34 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 12:38:34 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v8]
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <wTJeGIBptztDiJVPi5NPccE3_HjaOg4hPkk09Dzt9LQ=.f8e20898-cd7e-4a0c-9cc5-68dbbc522cec@github.com>

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  added requires jtreg tag

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21029/files
  - new: https://git.openjdk.org/jdk/pull/21029/files/987ac818..71ff7c28

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=06-07

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From psadhukhan at openjdk.org  Wed Sep 18 13:32:40 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 18 Sep 2024 13:32:40 GMT
Subject: RFR: 8340271: Open source several AWT Robot tests
Message-ID: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>

Opensource few Robot tests

-------------

Commit messages:
 - 8340271: Open source several AWT Robot tests
 - 8340271: Open source several AWT Robot tests

Changes: https://git.openjdk.org/jdk/pull/21062/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21062&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340271
  Stats: 184 lines in 2 files changed: 184 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21062.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21062/head:pull/21062

PR: https://git.openjdk.org/jdk/pull/21062

From aivanov at openjdk.org  Wed Sep 18 14:55:07 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 14:55:07 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v8]
In-Reply-To: <wTJeGIBptztDiJVPi5NPccE3_HjaOg4hPkk09Dzt9LQ=.f8e20898-cd7e-4a0c-9cc5-68dbbc522cec@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <wTJeGIBptztDiJVPi5NPccE3_HjaOg4hPkk09Dzt9LQ=.f8e20898-cd7e-4a0c-9cc5-68dbbc522cec@github.com>
Message-ID: <m_LweP3CnL1y67t9iJ9yI6-zV3vg_Diibq60bjP9lc4=.aeb63989-c5b6-44a4-9548-e6b652360be0@github.com>

On Wed, 18 Sep 2024 12:38:34 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   added requires jtreg tag

The instructions now look good to me.

There are lots of trailing whitespace characters though.

test/jdk/java/awt/MenuItem/GiantFontTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2007, 2024, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2002, 2024, Oracle and/or its affiliates. All rights reserved.

This test was written in 2002 for [JDK-4700350](https://bugs.openjdk.org/browse/JDK-4700350).

Could you also add `@bug 4700350` to jtreg tags?

https://github.com/openjdk/jdk/blob/ae39a6603c6c33a36dce30c3290a634b08a6bf05/src/java.desktop/windows/native/libawt/windows/awt_MenuItem.cpp#L513-L516

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2312945687
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1765206356

From abhiscxk at openjdk.org  Wed Sep 18 15:00:39 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 15:00:39 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v9]
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <c0KZfS6dGwAdoFWeipGWsahtRgEm99u_QhCuqRlk8yg=.ce0a2670-20e9-4ac0-ac5d-e7a1350007d0@github.com>

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  copyright year, whitespace error and bugid update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21029/files
  - new: https://git.openjdk.org/jdk/pull/21029/files/71ff7c28..f39bb5b4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=08
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=07-08

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From abhiscxk at openjdk.org  Wed Sep 18 15:00:39 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 15:00:39 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v8]
In-Reply-To: <m_LweP3CnL1y67t9iJ9yI6-zV3vg_Diibq60bjP9lc4=.aeb63989-c5b6-44a4-9548-e6b652360be0@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <wTJeGIBptztDiJVPi5NPccE3_HjaOg4hPkk09Dzt9LQ=.f8e20898-cd7e-4a0c-9cc5-68dbbc522cec@github.com>
 <m_LweP3CnL1y67t9iJ9yI6-zV3vg_Diibq60bjP9lc4=.aeb63989-c5b6-44a4-9548-e6b652360be0@github.com>
Message-ID: <y2yHlO2EaBYYrKU2UEjNbEOZFNePgIK5iS_hKcp6peE=.0ca7b8e9-4d36-4a56-95db-d39653b1ed78@github.com>

On Wed, 18 Sep 2024 14:50:51 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added requires jtreg tag
>
> test/jdk/java/awt/MenuItem/GiantFontTest.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2007, 2024, Oracle and/or its affiliates. All rights reserved.
> 
> Suggestion:
> 
>  * Copyright (c) 2002, 2024, Oracle and/or its affiliates. All rights reserved.
> 
> This test was written in 2002 for [JDK-4700350](https://bugs.openjdk.org/browse/JDK-4700350).
> 
> Could you also add `@bug 4700350` to jtreg tags?
> 
> https://github.com/openjdk/jdk/blob/ae39a6603c6c33a36dce30c3290a634b08a6bf05/src/java.desktop/windows/native/libawt/windows/awt_MenuItem.cpp#L513-L516

Thanks for finding the bugId. I was unable to find the details.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1765225031

From aivanov at openjdk.org  Wed Sep 18 15:00:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 15:00:39 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v8]
In-Reply-To: <wTJeGIBptztDiJVPi5NPccE3_HjaOg4hPkk09Dzt9LQ=.f8e20898-cd7e-4a0c-9cc5-68dbbc522cec@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <wTJeGIBptztDiJVPi5NPccE3_HjaOg4hPkk09Dzt9LQ=.f8e20898-cd7e-4a0c-9cc5-68dbbc522cec@github.com>
Message-ID: <iTJn6KK96GpN_RHWHHp8JLTVMhHSHYknpu_OXw0Bj-g=.0bb90281-78fd-4bf2-89ae-3d21f3616e0c@github.com>

On Wed, 18 Sep 2024 12:38:34 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   added requires jtreg tag

test/jdk/java/awt/MenuItem/GiantFontTest.java line 49:

> 47: 
> 48:                         On Windows, the menu's (present on menu bar) font
> 49:                         should be normal size.

I believe, ?If the menu text is clipped by the title bar, or is painted over the title bar or client area?? belongs here.

(I forgot to click *Add comment* button.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1765225984

From abhiscxk at openjdk.org  Wed Sep 18 15:07:58 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 15:07:58 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v8]
In-Reply-To: <iTJn6KK96GpN_RHWHHp8JLTVMhHSHYknpu_OXw0Bj-g=.0bb90281-78fd-4bf2-89ae-3d21f3616e0c@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <wTJeGIBptztDiJVPi5NPccE3_HjaOg4hPkk09Dzt9LQ=.f8e20898-cd7e-4a0c-9cc5-68dbbc522cec@github.com>
 <iTJn6KK96GpN_RHWHHp8JLTVMhHSHYknpu_OXw0Bj-g=.0bb90281-78fd-4bf2-89ae-3d21f3616e0c@github.com>
Message-ID: <4BdOzW_AI5TxDGWWmDudWijFCcH88OtrgqnPTOz02eI=.90711a3a-9dec-4ee5-8271-0687ecfe8e97@github.com>

On Wed, 18 Sep 2024 14:57:50 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added requires jtreg tag
>
> test/jdk/java/awt/MenuItem/GiantFontTest.java line 49:
> 
>> 47: 
>> 48:                         On Windows, the menu's (present on menu bar) font
>> 49:                         should be normal size.
> 
> I believe, ?If the menu text is clipped by the title bar, or is painted over the title bar or client area?? belongs here.
> 
> (I forgot to click *Add comment* button.)

Moved the test instructions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1765237338

From abhiscxk at openjdk.org  Wed Sep 18 15:07:57 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 15:07:57 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v10]
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <9-YKdoILkE1Q7CAxEuCBd8oCFu8zvxzSVGsnblN_CLY=.1b2cf110-99c2-47d7-b7a1-2518917733fd@github.com>

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Test instruction update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21029/files
  - new: https://git.openjdk.org/jdk/pull/21029/files/f39bb5b4..4eb80036

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=08-09

  Stats: 5 lines in 1 file changed: 2 ins; 2 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From aivanov at openjdk.org  Wed Sep 18 15:14:07 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 15:14:07 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v10]
In-Reply-To: <9-YKdoILkE1Q7CAxEuCBd8oCFu8zvxzSVGsnblN_CLY=.1b2cf110-99c2-47d7-b7a1-2518917733fd@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <9-YKdoILkE1Q7CAxEuCBd8oCFu8zvxzSVGsnblN_CLY=.1b2cf110-99c2-47d7-b7a1-2518917733fd@github.com>
Message-ID: <9Kg5uDSTVCz_dtdKby2RpCbjjDuD0k1nAYBXoUiJhHw=.0e9a977e-1569-465f-810a-c26c37f37ef6@github.com>

On Wed, 18 Sep 2024 15:07:57 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test instruction update

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2313020282

From aivanov at openjdk.org  Wed Sep 18 15:30:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 15:30:14 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v10]
In-Reply-To: <9-YKdoILkE1Q7CAxEuCBd8oCFu8zvxzSVGsnblN_CLY=.1b2cf110-99c2-47d7-b7a1-2518917733fd@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <9-YKdoILkE1Q7CAxEuCBd8oCFu8zvxzSVGsnblN_CLY=.1b2cf110-99c2-47d7-b7a1-2518917733fd@github.com>
Message-ID: <8-INsYpf0d3rZLtwPQhNPrVdSgFpOvzm0fh5NZUyVSw=.0c84e608-4613-4f7e-adfb-f32355aa33fc@github.com>

On Wed, 18 Sep 2024 15:07:57 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test instruction update

Huh, I found another issue.

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 107:

> 105:             setMenuBar(mb);
> 106:             setSize(450, 150);
> 107:         }

The original test had `setVisible(true);` here. This is why the loop contains `setVisible(false)`.

Without showing the frames, the test may not reproduce the original problem reported in [JDK-4175790](https://bugs.openjdk.org/browse/JDK-4175790).

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2313064053
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1765278585

From rgupta at openjdk.org  Wed Sep 18 15:34:02 2024
From: rgupta at openjdk.org (Ravi Gupta)
Date: Wed, 18 Sep 2024 15:34:02 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v10]
In-Reply-To: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
Message-ID: <etTuI5B_VPcWRsSh4LOz3y3n4g8-_AYqJdaYKwox240=.f195361d-2ef5-44f2-a9d8-a9590579a343@github.com>

> This testcase checks for the following assertions for Component events:
> 
> 1. When components are resized, moved, hidden and shown the respective events are triggered.
> 2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
> 3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
> 4. When a window is minimized/restored then hidden and shown component events should be triggered.
> 
> Testing:
> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.

Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:

  8333403: Review Comments Fixed

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19521/files
  - new: https://git.openjdk.org/jdk/pull/19521/files/acaee1a6..9633a03a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19521&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19521&range=08-09

  Stats: 689 lines in 2 files changed: 356 ins; 333 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/19521.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19521/head:pull/19521

PR: https://git.openjdk.org/jdk/pull/19521

From abhiscxk at openjdk.org  Wed Sep 18 15:42:10 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 18 Sep 2024 15:42:10 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v10]
In-Reply-To: <8-INsYpf0d3rZLtwPQhNPrVdSgFpOvzm0fh5NZUyVSw=.0c84e608-4613-4f7e-adfb-f32355aa33fc@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <9-YKdoILkE1Q7CAxEuCBd8oCFu8zvxzSVGsnblN_CLY=.1b2cf110-99c2-47d7-b7a1-2518917733fd@github.com>
 <8-INsYpf0d3rZLtwPQhNPrVdSgFpOvzm0fh5NZUyVSw=.0c84e608-4613-4f7e-adfb-f32355aa33fc@github.com>
Message-ID: <Rfq0hXXGLjq-nzGZ5ImsbFQBjym9XkzMCbBpND4AzR4=.50f065f5-8e8d-4cb2-91ba-abc7834d0879@github.com>

On Wed, 18 Sep 2024 15:26:51 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test instruction update
>
> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 107:
> 
>> 105:             setMenuBar(mb);
>> 106:             setSize(450, 150);
>> 107:         }
> 
> The original test had `setVisible(true);` here. This is why the loop contains `setVisible(false)`.
> 
> Without showing the frames, the test may not reproduce the original problem reported in [JDK-4175790](https://bugs.openjdk.org/browse/JDK-4175790).

I think the testFrame's are made invisible and disposed just after creating. Only the last frame and first frame is visible.
After the test update, **testFrame and firstFrame is setVisible by PassFailJFrame**.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1765299255

From rgupta at openjdk.org  Wed Sep 18 16:28:08 2024
From: rgupta at openjdk.org (Ravi Gupta)
Date: Wed, 18 Sep 2024 16:28:08 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v10]
In-Reply-To: <etTuI5B_VPcWRsSh4LOz3y3n4g8-_AYqJdaYKwox240=.f195361d-2ef5-44f2-a9d8-a9590579a343@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <etTuI5B_VPcWRsSh4LOz3y3n4g8-_AYqJdaYKwox240=.f195361d-2ef5-44f2-a9d8-a9590579a343@github.com>
Message-ID: <7nOZS0_7wlnmMkoAyVrjb-HYWDaS_arXkUrib5TVwig=.9bb092ac-a343-4784-bc1f-b3a3f1fbc842@github.com>

On Wed, 18 Sep 2024 15:34:02 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:

>> This testcase checks for the following assertions for Component events:
>> 
>> 1. When components are resized, moved, hidden and shown the respective events are triggered.
>> 2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
>> 3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
>> 4. When a window is minimized/restored then hidden and shown component events should be triggered.
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.
>
> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8333403: Review Comments Fixed

moved test to java/awt/Component

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19521#issuecomment-2358911741

From prr at openjdk.org  Wed Sep 18 17:32:06 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 18 Sep 2024 17:32:06 GMT
Subject: RFR: 8340306: Add border around instructions in PassFailJFrame
In-Reply-To: <zTSZWNkl9I8P5xSP_v09hE2PT29ngxOYoQ8Zhui4ZoA=.48419fb6-aa9d-4d8d-a078-354e7360a029@github.com>
References: <zTSZWNkl9I8P5xSP_v09hE2PT29ngxOYoQ8Zhui4ZoA=.48419fb6-aa9d-4d8d-a078-354e7360a029@github.com>
Message-ID: <5DiY0H_hQK6q62OP2ppCr7zCbc_UllhGMxlYQVDiHE8=.9a22abba-826e-49fc-9532-210662454c3c@github.com>

On Tue, 17 Sep 2024 12:39:20 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> A trivial change which adds border around instruction text. It makes the text easier to read.
> 
> (In some tests, people added leading spaces to each line to make the instructions easier to read; with the added border, there's no need for this trick.)

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21038#pullrequestreview-2313340695

From prr at openjdk.org  Wed Sep 18 17:42:09 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 18 Sep 2024 17:42:09 GMT
Subject: RFR: 8340078: Open source several 2D tests
In-Reply-To: <E5bVXexmbzN03J05DIWvTGglFqhQbdaAbXM3GUIEnT8=.812c574d-cf88-475a-a783-30039bb5c5c5@github.com>
References: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
 <E5bVXexmbzN03J05DIWvTGglFqhQbdaAbXM3GUIEnT8=.812c574d-cf88-475a-a783-30039bb5c5c5@github.com>
Message-ID: <pHrEPXd8339EOmiu961VUNy4vtbYaRC3HidGGQu-MRs=.a431d4db-fd38-4bb4-85c6-80eb4982bf96@github.com>

On Tue, 17 Sep 2024 20:10:17 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Open source 5 Java2D related rendering tests.
>
> test/jdk/sun/java2d/GdiRendering/GdiLockTest.java line 28:
> 
>> 26:  * @bug 4693644
>> 27:  * @summary verifies that there are no artifacts due to copying with GDI
>> 28:  * @library java/awt/regtesthelpers
> 
> `test result: Error. Can't find library: java/awt/regtesthelpers`
> 
> Suggestion:
> 
>  * @library /java/awt/regtesthelpers

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765461337

From prr at openjdk.org  Wed Sep 18 17:46:16 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 18 Sep 2024 17:46:16 GMT
Subject: RFR: 8340078: Open source several 2D tests
In-Reply-To: <XLYbI_ANidVlgTHNTYN72dj2EhR3pXrmEv3NlsxlwyM=.8f2451c3-2018-4e00-8c34-6e280d4fd65b@github.com>
References: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
 <XLYbI_ANidVlgTHNTYN72dj2EhR3pXrmEv3NlsxlwyM=.8f2451c3-2018-4e00-8c34-6e280d4fd65b@github.com>
Message-ID: <xHuOrtc3N7j0KHIkgDrBOq63eTR1CRbHG9uDh7QqLrY=.dfae72ea-b467-4301-8f4e-a4af9088cf44@github.com>

On Wed, 18 Sep 2024 00:48:59 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Open source 5 Java2D related rendering tests.
>
> test/jdk/sun/java2d/SunGraphics2D/RevalidateBug.java line 34:
> 
>> 32:  */
>> 33: 
>> 34: import java.awt.Color;
> 
> Unused import.

? I use Color multiple times.

> test/jdk/sun/java2d/SunGraphics2D/ScaledPolyTest.java line 31:
> 
>> 29: 
>> 30: import java.awt.Color;
>> 31: import static java.awt.Color.*;
> 
> static import redudant here.

fixed

> test/jdk/sun/java2d/SunGraphics2D/ScaledPolyTest.java line 38:
> 
>> 36: public class ScaledPolyTest {
>> 37: 
>> 38:     public static void main(String argv[]) {
> 
> Suggestion:
> 
>     public static void main(String[] argv) {

either is OK but since I'm updating the file anyway

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765466132
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765466027
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765467367

From prr at openjdk.org  Wed Sep 18 17:51:52 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 18 Sep 2024 17:51:52 GMT
Subject: RFR: 8340078: Open source several 2D tests [v2]
In-Reply-To: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
References: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
Message-ID: <H3BafJ38le_Fmr3NBQ5lfm14ww2Mv9yXuuputZuzkcI=.8d226a23-57de-4a5e-83bb-a5b114415e27@github.com>

> Open source 5 Java2D related rendering tests.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8340078

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21045/files
  - new: https://git.openjdk.org/jdk/pull/21045/files/92a846e5..2bf854f2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21045&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21045&range=00-01

  Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21045.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21045/head:pull/21045

PR: https://git.openjdk.org/jdk/pull/21045

From honkar at openjdk.org  Wed Sep 18 18:26:12 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 18 Sep 2024 18:26:12 GMT
Subject: RFR: 8340078: Open source several 2D tests [v2]
In-Reply-To: <H3BafJ38le_Fmr3NBQ5lfm14ww2Mv9yXuuputZuzkcI=.8d226a23-57de-4a5e-83bb-a5b114415e27@github.com>
References: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
 <H3BafJ38le_Fmr3NBQ5lfm14ww2Mv9yXuuputZuzkcI=.8d226a23-57de-4a5e-83bb-a5b114415e27@github.com>
Message-ID: <8cQKQmE7mYcIukHZzSnwrlxlxcuv2yKUYr-W8JrIDeQ=.c489bae0-6fa4-4653-9767-50dff6e80fef@github.com>

On Wed, 18 Sep 2024 17:51:52 GMT, Phil Race <prr at openjdk.org> wrote:

>> Open source 5 Java2D related rendering tests.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8340078

Changes requested by honkar (Reviewer).

test/jdk/sun/java2d/SunGraphics2D/DrawRoundRect0Bug.java line 31:

> 29: 
> 30: import java.awt.Color;
> 31: import static java.awt.Color.*;

Only static import might be required here based on its usage in test.

test/jdk/sun/java2d/SunGraphics2D/ScaledPolyTest.java line 37:

> 35: public class ScaledPolyTest {
> 36: 
> 37:     public static void main(String[] arg]) {

Extra bracket 

Suggestion:

    public static void main(String[] args) {

test/jdk/sun/java2d/SunGraphics2D/ScaledPolyTest.java line 67:

> 65:         int bluePix = blue.getRGB();
> 66:         int yellowPix = yellow.getRGB();
> 67:         int whitePix = white.getRGB();

Sorry for the mix-up with the tests. Somehow the comments got added to the wrong test. 
This test uses both static and non-static usage for Color.
Currently it doesn't compile because the static import was removed.
It might be better to follow one pattern throughout - either non-static or static?

-------------

PR Review: https://git.openjdk.org/jdk/pull/21045#pullrequestreview-2313420538
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765499341
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765509992
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765508604

From honkar at openjdk.org  Wed Sep 18 18:26:13 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 18 Sep 2024 18:26:13 GMT
Subject: RFR: 8340078: Open source several 2D tests [v2]
In-Reply-To: <xHuOrtc3N7j0KHIkgDrBOq63eTR1CRbHG9uDh7QqLrY=.dfae72ea-b467-4301-8f4e-a4af9088cf44@github.com>
References: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
 <XLYbI_ANidVlgTHNTYN72dj2EhR3pXrmEv3NlsxlwyM=.8f2451c3-2018-4e00-8c34-6e280d4fd65b@github.com>
 <xHuOrtc3N7j0KHIkgDrBOq63eTR1CRbHG9uDh7QqLrY=.dfae72ea-b467-4301-8f4e-a4af9088cf44@github.com>
Message-ID: <Ci9SR_k25lCYM3StmjfiIonxQfdzFrwCE3IBAdDUYvw=.005d56c8-3b38-45a0-aea7-64dbeaf69a7a@github.com>

On Wed, 18 Sep 2024 17:43:08 GMT, Phil Race <prr at openjdk.org> wrote:

>> test/jdk/sun/java2d/SunGraphics2D/RevalidateBug.java line 34:
>> 
>>> 32:  */
>>> 33: 
>>> 34: import java.awt.Color;
>> 
>> Unused import.
>
> ? I use Color multiple times.

I probably added it to the wrong test by mistake. It was for DrawRoundRect0Bug.java test which has the double Color imports - static and non-static.

>> test/jdk/sun/java2d/SunGraphics2D/ScaledPolyTest.java line 31:
>> 
>>> 29: 
>>> 30: import java.awt.Color;
>>> 31: import static java.awt.Color.*;
>> 
>> static import redudant here.
>
> fixed

Sorry somehow the comments got added to the wrong test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765499597
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765502560

From prr at openjdk.org  Wed Sep 18 18:39:14 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 18 Sep 2024 18:39:14 GMT
Subject: RFR: 8340360: Update -mx to -Xmx in UnninstallUIMemoryLeaks test
In-Reply-To: <GiTzTgqxJjGnmF06tUXixW797PLLki0DFEhgp_npLIA=.bdab6608-56ab-478f-a5c2-4664ffbaec19@github.com>
References: <GiTzTgqxJjGnmF06tUXixW797PLLki0DFEhgp_npLIA=.bdab6608-56ab-478f-a5c2-4664ffbaec19@github.com>
Message-ID: <Vxt1Dnc5t7fH194z2xaI_AsiRq0mFxDiu7e5h0xHsVM=.b7a6f718-1f37-4fc5-9ea2-96e7e5fef3c9@github.com>

On Wed, 18 Sep 2024 09:06:04 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which replaces the use of the outdated "-mx" option with the "-Xmx" option when launching the java processes in this test? This test was missed out from one of the earlier integrated PR.
> 
> The test continues to pass after this change.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21053#pullrequestreview-2313485139

From prr at openjdk.org  Wed Sep 18 18:43:34 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 18 Sep 2024 18:43:34 GMT
Subject: RFR: 8340078: Open source several 2D tests [v3]
In-Reply-To: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
References: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
Message-ID: <qbQDlMaY5vEVXwZGeUuokLUkSZcJNJXbaNUx08IYL98=.7949b5ae-0f8f-4d2f-beb1-2cac683058b6@github.com>

> Open source 5 Java2D related rendering tests.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8340078

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21045/files
  - new: https://git.openjdk.org/jdk/pull/21045/files/2bf854f2..abb8caf5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21045&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21045&range=01-02

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21045.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21045/head:pull/21045

PR: https://git.openjdk.org/jdk/pull/21045

From dnguyen at openjdk.org  Wed Sep 18 19:08:05 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 18 Sep 2024 19:08:05 GMT
Subject: RFR: JDK-8339962 : Open source AWT TextField tests - Set1 [v3]
In-Reply-To: <Fog0s8VOThwYsgzPpN1mQaUXJVLVEOxG2tcDr5Vritc=.eac43e4b-7862-4154-93eb-6cefd9d95514@github.com>
References: <v6evWDMdJ5taNxUxxPD-onH6DfUhWGyWSW69gyb87fo=.380962ba-cc65-403e-8337-33186b5d9e29@github.com>
 <Fog0s8VOThwYsgzPpN1mQaUXJVLVEOxG2tcDr5Vritc=.eac43e4b-7862-4154-93eb-6cefd9d95514@github.com>
Message-ID: <EpCDWV9o-NzxgeYOgKeIwOT3Q1Z6qAahVfLHpfB6kqE=.3432d2f2-97ef-4271-8570-ebbe630aef54@github.com>

On Mon, 16 Sep 2024 22:59:35 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test are open-sourced.
>> 
>> 1. 	test/jdk/java/awt/Label/ContainerValidateTest.java - Automated
>> 2. 	test/jdk/java/awt/TextField/SetEchoCharTest.java - Automated
>> 3. 	test/jdk/java/awt/TextField/SetEchoCharWordOpsTest.java - PassFailJFrame manual test
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   typo fix

Marked as reviewed by dnguyen (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21005#pullrequestreview-2313538787

From honkar at openjdk.org  Wed Sep 18 19:16:04 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 18 Sep 2024 19:16:04 GMT
Subject: RFR: 8340078: Open source several 2D tests [v3]
In-Reply-To: <qbQDlMaY5vEVXwZGeUuokLUkSZcJNJXbaNUx08IYL98=.7949b5ae-0f8f-4d2f-beb1-2cac683058b6@github.com>
References: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
 <qbQDlMaY5vEVXwZGeUuokLUkSZcJNJXbaNUx08IYL98=.7949b5ae-0f8f-4d2f-beb1-2cac683058b6@github.com>
Message-ID: <YIvzpol1CvIMhoQpJ8D5mWxYe7wSiKmKxWhDiIcZJnU=.14675026-4e68-4c60-ab36-a6709dfb0667@github.com>

On Wed, 18 Sep 2024 18:43:34 GMT, Phil Race <prr at openjdk.org> wrote:

>> Open source 5 Java2D related rendering tests.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8340078

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21045#pullrequestreview-2313552945

From honkar at openjdk.org  Wed Sep 18 19:28:12 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 18 Sep 2024 19:28:12 GMT
Subject: Integrated: JDK-8339962 : Open source AWT TextField tests - Set1
In-Reply-To: <v6evWDMdJ5taNxUxxPD-onH6DfUhWGyWSW69gyb87fo=.380962ba-cc65-403e-8337-33186b5d9e29@github.com>
References: <v6evWDMdJ5taNxUxxPD-onH6DfUhWGyWSW69gyb87fo=.380962ba-cc65-403e-8337-33186b5d9e29@github.com>
Message-ID: <jJvtWXO1ivDwatahmVBtt7oepMDAb-G_1xdKrlWM41c=.8b4f6928-4f57-43f1-90ec-8037e14075dd@github.com>

On Fri, 13 Sep 2024 22:04:24 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following test are open-sourced.
> 
> 1. 	test/jdk/java/awt/Label/ContainerValidateTest.java - Automated
> 2. 	test/jdk/java/awt/TextField/SetEchoCharTest.java - Automated
> 3. 	test/jdk/java/awt/TextField/SetEchoCharWordOpsTest.java - PassFailJFrame manual test

This pull request has now been integrated.

Changeset: 31849127
Author:    Harshitha Onkar <honkar at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/31849127a06e448c705a61c536f51fc037bc4979
Stats:     437 lines in 3 files changed: 437 ins; 0 del; 0 mod

8339962: Open source AWT TextField tests - Set1

Reviewed-by: jdv, dnguyen, prr

-------------

PR: https://git.openjdk.org/jdk/pull/21005

From prr at openjdk.org  Wed Sep 18 19:45:04 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 18 Sep 2024 19:45:04 GMT
Subject: RFR: 8340365: Position the first window of a window list
In-Reply-To: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
References: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
Message-ID: <f4Px95Y501ewsTDVmFaVtG3Vl-y7GvD6dIXpgcCVS40=.72e79b8f-a41c-4177-a2d1-62f37cc7008d@github.com>

On Wed, 18 Sep 2024 12:05:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Support of multiple test UI windows in `PassFailJFrame` is still evolving. After [JDK-8340210](https://bugs.openjdk.org/browse/JDK-8340210), the `Builder` has a method `positionTestUI` to supply an implementation of the `PositionWindows` interface which handles the positioning of all test UI windows created.
> 
> If `PositionWindows` is not provided, all the test UI windows are left with the default coordinates: (0, 0).
> 
> If `PassFailJFrame` called `positionTestWindow` for the first window, it would allow the test developer to position other windows based on the position of the first one.
> 
> This issue was raised in #21029 in [this thread of comments](https://github.com/openjdk/jdk/pull/21029#discussion_r1763744407).
> 
> To make it easier to position multiple test UI windows without implementing the `PositionWindows` interface, the `PassFailJFrame` should position the first window of the list.
> 
> The `LotsOfMenuItemsTest.java` test in #21029 had to hard-code the coordinates or use `PassFailJFrame.positionTestWindow` explicitly in its `ComponentListener.componentShown`.
> 
> With the proposed change in this pull request, the implementation would use `ComponentListener.componentMoved`:
> 
> 
>     @Override
>     public void componentMoved(ComponentEvent e) {
>         testFrame.setLocation(firstFrame.getX(),
>                               firstFrame.getY() + firstFrame.getHeight() + 8);
>     }
> 
> 
> This has the advantage in that the test UI windows don't flicker for a short time in the upper left corner of the screen; and the developer has to handle only positioning the second window (frame).
> 
> However, this has a funny effect: if you move the first frame with mouse or in any other way, the second frame follows. To avoid such kind of behaviour, call `removeComponentListener` in the handler.
> 
> @honkar-jdk, @azvegint, could you take a look?

"With the proposed change in this pull request, the implementation would use ComponentListener.componentMoved:"

you mean the implementation of the test ? Perhaps adding the required pattern in the examples would be a good idea.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21057#issuecomment-2359268838

From aivanov at openjdk.org  Wed Sep 18 20:28:01 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 20:28:01 GMT
Subject: RFR: 8340365: Position the first window of a window list
In-Reply-To: <f4Px95Y501ewsTDVmFaVtG3Vl-y7GvD6dIXpgcCVS40=.72e79b8f-a41c-4177-a2d1-62f37cc7008d@github.com>
References: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
 <f4Px95Y501ewsTDVmFaVtG3Vl-y7GvD6dIXpgcCVS40=.72e79b8f-a41c-4177-a2d1-62f37cc7008d@github.com>
Message-ID: <fXdLL9t4lj3i-PWSNt_ZLuhAcDZIMxozZ9NoRY6pNA8=.80c3e9f9-55a6-436d-9160-48bb55f60bb1@github.com>

On Wed, 18 Sep 2024 19:42:08 GMT, Phil Race <prr at openjdk.org> wrote:

> > With the proposed change in this pull request, the implementation would use ComponentListener.componentMoved:
> 
> you mean the implementation of the test ? Perhaps adding the required pattern in the examples would be a good idea.

@prrace Yes, I referred to the implementation of the `LotsOfMenuItemsTest.java` test.

This is more of a workaround until we add better layout options. Yet it looks simple and works well. It still requires the test developer to save references to frames.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21057#issuecomment-2359320527

From prr at openjdk.org  Wed Sep 18 20:42:56 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 18 Sep 2024 20:42:56 GMT
Subject: Integrated: 8340078: Open source several 2D tests
In-Reply-To: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
References: <_G3hZfUAcdUgOwd-cOfvVpLMogQlU2fRZP48zN6SoA8=.3101fd27-6d6d-46e5-badf-7a17b484d5b6@github.com>
Message-ID: <aN2teeWVyJCqGKE1wwJcU-i1cc9U7sRVtk53VPI1yU4=.38984d35-4c66-4c41-a8de-3a46ddc84c47@github.com>

On Tue, 17 Sep 2024 18:27:58 GMT, Phil Race <prr at openjdk.org> wrote:

> Open source 5 Java2D related rendering tests.

This pull request has now been integrated.

Changeset: 88a1c055
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/88a1c0550e435888c571d32c577fd697652e5620
Stats:     484 lines in 5 files changed: 484 ins; 0 del; 0 mod

8340078: Open source several 2D tests

Reviewed-by: honkar

-------------

PR: https://git.openjdk.org/jdk/pull/21045

From aivanov at openjdk.org  Wed Sep 18 20:54:44 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Sep 2024 20:54:44 GMT
Subject: RFR: 8340365: Position the first window of a window list
In-Reply-To: <fXdLL9t4lj3i-PWSNt_ZLuhAcDZIMxozZ9NoRY6pNA8=.80c3e9f9-55a6-436d-9160-48bb55f60bb1@github.com>
References: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
 <f4Px95Y501ewsTDVmFaVtG3Vl-y7GvD6dIXpgcCVS40=.72e79b8f-a41c-4177-a2d1-62f37cc7008d@github.com>
 <fXdLL9t4lj3i-PWSNt_ZLuhAcDZIMxozZ9NoRY6pNA8=.80c3e9f9-55a6-436d-9160-48bb55f60bb1@github.com>
Message-ID: <kr9W8ErVN-zmO0wIUZOXK_aybNHmTM-Fswv5KJp0oSc=.04ae2115-6f08-42d7-a548-2f2be10a7559@github.com>

On Wed, 18 Sep 2024 20:12:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Perhaps adding the required pattern in the examples would be a good idea.

Yes, it's a good idea.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21057#issuecomment-2359383555

From honkar at openjdk.org  Wed Sep 18 23:48:35 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 18 Sep 2024 23:48:35 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests
In-Reply-To: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
Message-ID: <CdgFyq6bXnw8EnDTReb1GxJeM36CJ_520ZqoEk7oGYI=.a479e1b5-8ebe-4685-b2c0-3bf2f03c92d1@github.com>

On Wed, 18 Sep 2024 06:18:03 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Few AWT Frame related tests are converted from applet to manual and moved to open.

Changes requested by honkar (Reviewer).

test/jdk/java/awt/Frame/FrameSetMinimumSizeTest.java line 61:

> 59:             if (!passed) {
> 60:                 throw new RuntimeException("Frame's setMinimumSize not honoured");
> 61:              }

The test condition does not seem right.
For instance if `passed` was false in one of the previous checks and the final case results in true then the test passes, which seems to be incorrect.

test/jdk/java/awt/Frame/FrameSetMinimumSizeTest.java line 80:

> 78:     private static boolean verifyFrameSize(Dimension expected) {
> 79: 
> 80:         if (f.getSize().width != expected.width || f.getSize().height != expected.height) {

Do we need to wrap calls to `verifyFrameSize()` in EDT, since we are accessing frame.getSize() ?

test/jdk/java/awt/Frame/PackTwiceTest.java line 56:

> 54: 
> 55:     private static Frame createUI() {
> 56:         Frame f = new Frame("TestFrame");

Title of the frame can be renamed to something more specific to the test.

Suggestion:

        Frame f = new Frame("PackTwiceTest TestFrame");

-------------

PR Review: https://git.openjdk.org/jdk/pull/21052#pullrequestreview-2314031722
PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1765883111
PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1765884441
PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1765885855

From honkar at openjdk.org  Wed Sep 18 23:51:35 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 18 Sep 2024 23:51:35 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests
In-Reply-To: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
Message-ID: <H1Pb-rkM37mNWoSyhGs5KXiiASW29MNs0ADlIIZzY7w=.5c61e7e3-7e8e-4287-baa0-67d0a8df1573@github.com>

On Wed, 18 Sep 2024 06:18:03 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Few AWT Frame related tests are converted from applet to manual and moved to open.

test/jdk/java/awt/Frame/EmptyFrameTest.java line 51:

> 49:     private static final int TOLERANCE = 5;
> 50:     public static void main(String[] args) throws Exception {
> 51: 

Extra newline

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1765887824

From honkar at openjdk.org  Wed Sep 18 23:55:34 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 18 Sep 2024 23:55:34 GMT
Subject: RFR: 8340271: Open source several AWT Robot tests
In-Reply-To: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
References: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
Message-ID: <oLgYyFrDr6LDj43n7V5MAFKg1iEXOVreQcEIb4WAjYo=.fc1a1770-10ea-4e8a-8df7-91590547eb7a@github.com>

On Wed, 18 Sep 2024 13:26:35 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few Robot tests

test/jdk/java/awt/Robot/RobotScrollTest.java line 47:

> 45:     private static final String INSTRUCTIONS = """
> 46:          0. DON'T TOUCH ANYTHING!
> 47:          1. This test is for Win32 and Linux only.

Suggestion:

         1. This test is for Win and Linux only.

test/jdk/java/awt/Robot/RobotScrollTest.java line 82:

> 80:         Point taAt = ta.getLocationOnScreen();
> 81:         // get bounds of button
> 82:         Rectangle bounds = ta.getBounds();

Should they be in EDT?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1765889419
PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1765889868

From jpai at openjdk.org  Thu Sep 19 01:47:42 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Thu, 19 Sep 2024 01:47:42 GMT
Subject: RFR: 8340360: Update -mx to -Xmx in UnninstallUIMemoryLeaks test
In-Reply-To: <GiTzTgqxJjGnmF06tUXixW797PLLki0DFEhgp_npLIA=.bdab6608-56ab-478f-a5c2-4664ffbaec19@github.com>
References: <GiTzTgqxJjGnmF06tUXixW797PLLki0DFEhgp_npLIA=.bdab6608-56ab-478f-a5c2-4664ffbaec19@github.com>
Message-ID: <7GCtJrZS_E9CDkTgRN2XTwD3RtrwmiJqQpJU5yCZFX0=.61b71fea-3c33-4834-a26e-2dbf7267ccb1@github.com>

On Wed, 18 Sep 2024 09:06:04 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which replaces the use of the outdated "-mx" option with the "-Xmx" option when launching the java processes in this test? This test was missed out from one of the earlier integrated PR.
> 
> The test continues to pass after this change.

Thank you Phil and Sergey for the reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21053#issuecomment-2359793882

From jpai at openjdk.org  Thu Sep 19 01:47:42 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Thu, 19 Sep 2024 01:47:42 GMT
Subject: Integrated: 8340360: Update -mx to -Xmx in UnninstallUIMemoryLeaks
 test
In-Reply-To: <GiTzTgqxJjGnmF06tUXixW797PLLki0DFEhgp_npLIA=.bdab6608-56ab-478f-a5c2-4664ffbaec19@github.com>
References: <GiTzTgqxJjGnmF06tUXixW797PLLki0DFEhgp_npLIA=.bdab6608-56ab-478f-a5c2-4664ffbaec19@github.com>
Message-ID: <A1rX_EHOAFXiLwFzy4BGI5mzkHr4ZhtNc8yv0b0jAf8=.9865c432-a92b-4f44-8124-a585bed0a87c@github.com>

On Wed, 18 Sep 2024 09:06:04 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which replaces the use of the outdated "-mx" option with the "-Xmx" option when launching the java processes in this test? This test was missed out from one of the earlier integrated PR.
> 
> The test continues to pass after this change.

This pull request has now been integrated.

Changeset: d9c67443
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d9c67443f7d7f03efb2837b63ee2acc6113f737f
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8340360: Update -mx to -Xmx in UnninstallUIMemoryLeaks test

Reviewed-by: serb, prr

-------------

PR: https://git.openjdk.org/jdk/pull/21053

From psadhukhan at openjdk.org  Thu Sep 19 04:00:30 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 19 Sep 2024 04:00:30 GMT
Subject: RFR: 8340271: Open source several AWT Robot tests [v2]
In-Reply-To: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
References: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
Message-ID: <O-TUZWPtrE0jhM88hf-8jegDZvovvsBIT2N_Yp7D_GM=.32a7cc06-9ee8-4fa5-bae7-417a0dde85e3@github.com>

> Opensource few Robot tests

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  minor review

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21062/files
  - new: https://git.openjdk.org/jdk/pull/21062/files/14afd0d0..1eeb6826

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21062&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21062&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21062.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21062/head:pull/21062

PR: https://git.openjdk.org/jdk/pull/21062

From psadhukhan at openjdk.org  Thu Sep 19 04:00:32 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 19 Sep 2024 04:00:32 GMT
Subject: RFR: 8340271: Open source several AWT Robot tests [v2]
In-Reply-To: <oLgYyFrDr6LDj43n7V5MAFKg1iEXOVreQcEIb4WAjYo=.fc1a1770-10ea-4e8a-8df7-91590547eb7a@github.com>
References: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
 <oLgYyFrDr6LDj43n7V5MAFKg1iEXOVreQcEIb4WAjYo=.fc1a1770-10ea-4e8a-8df7-91590547eb7a@github.com>
Message-ID: <iPbzmpjovbJUhxIcCwx7Jv_7sBu7S8thhy5pq0A8bgI=.b4e88584-034d-4060-93e1-ec30e586a7b6@github.com>

On Wed, 18 Sep 2024 23:52:34 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor review
>
> test/jdk/java/awt/Robot/RobotScrollTest.java line 47:
> 
>> 45:     private static final String INSTRUCTIONS = """
>> 46:          0. DON'T TOUCH ANYTHING!
>> 47:          1. This test is for Win32 and Linux only.
> 
> Suggestion:
> 
>          1. This test is for Win and Linux only.

done

> test/jdk/java/awt/Robot/RobotScrollTest.java line 82:
> 
>> 80:         Point taAt = ta.getLocationOnScreen();
>> 81:         // get bounds of button
>> 82:         Rectangle bounds = ta.getBounds();
> 
> Should they be in EDT?

manual test, not needed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766112199
PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766112387

From abhiscxk at openjdk.org  Thu Sep 19 04:56:13 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 19 Sep 2024 04:56:13 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v11]
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <s_mg4w4D9QwccLu5gW3ixWLlfOtco6epbw09Zk6nxmM=.15e9f353-0e02-4bf7-9144-aab0bf873718@github.com>

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Test restructured and test frames set visible true

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21029/files
  - new: https://git.openjdk.org/jdk/pull/21029/files/4eb80036..ed39f24a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=10
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=09-10

  Stats: 23 lines in 1 file changed: 12 ins; 9 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From abhiscxk at openjdk.org  Thu Sep 19 04:56:13 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 19 Sep 2024 04:56:13 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v10]
In-Reply-To: <Rfq0hXXGLjq-nzGZ5ImsbFQBjym9XkzMCbBpND4AzR4=.50f065f5-8e8d-4cb2-91ba-abc7834d0879@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <9-YKdoILkE1Q7CAxEuCBd8oCFu8zvxzSVGsnblN_CLY=.1b2cf110-99c2-47d7-b7a1-2518917733fd@github.com>
 <8-INsYpf0d3rZLtwPQhNPrVdSgFpOvzm0fh5NZUyVSw=.0c84e608-4613-4f7e-adfb-f32355aa33fc@github.com>
 <Rfq0hXXGLjq-nzGZ5ImsbFQBjym9XkzMCbBpND4AzR4=.50f065f5-8e8d-4cb2-91ba-abc7834d0879@github.com>
Message-ID: <taMk2hrmVx93tcxK2-Jv6o-N0NDMXvShCwDsi8rBR38=.cc3846b8-ef61-4fc5-8d19-8644c420df2a@github.com>

On Wed, 18 Sep 2024 15:39:04 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 107:
>> 
>>> 105:             setMenuBar(mb);
>>> 106:             setSize(450, 150);
>>> 107:         }
>> 
>> The original test had `setVisible(true);` here. This is why the loop contains `setVisible(false)`.
>> 
>> Without showing the frames, the test may not reproduce the original problem reported in [JDK-4175790](https://bugs.openjdk.org/browse/JDK-4175790).
>
> I think the testFrame's are made invisible and disposed just after creating. Only the last frame and first frame is visible.
> After the test update, **testFrame and firstFrame is setVisible by PassFailJFrame**.

Updated the test to set the test frames visible, `setVisible(true)`;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1766156261

From abhiscxk at openjdk.org  Thu Sep 19 05:21:02 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 19 Sep 2024 05:21:02 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests [v2]
In-Reply-To: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
Message-ID: <3F2xejJLH59rCU6yMgISA16Dff7fWPgx5BgZu-eZzHw=.e84e44f1-28e3-4dcc-9bdb-d917899ee3dc@github.com>

> Few AWT Frame related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Review comment fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21052/files
  - new: https://git.openjdk.org/jdk/pull/21052/files/6c662c99..c5de5524

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21052&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21052&range=00-01

  Stats: 33 lines in 3 files changed: 11 ins; 6 del; 16 mod
  Patch: https://git.openjdk.org/jdk/pull/21052.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21052/head:pull/21052

PR: https://git.openjdk.org/jdk/pull/21052

From abhiscxk at openjdk.org  Thu Sep 19 05:27:35 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 19 Sep 2024 05:27:35 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests [v2]
In-Reply-To: <CdgFyq6bXnw8EnDTReb1GxJeM36CJ_520ZqoEk7oGYI=.a479e1b5-8ebe-4685-b2c0-3bf2f03c92d1@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
 <CdgFyq6bXnw8EnDTReb1GxJeM36CJ_520ZqoEk7oGYI=.a479e1b5-8ebe-4685-b2c0-3bf2f03c92d1@github.com>
Message-ID: <35KUYcieQEU13dIvg0MpdVCvvyvVg3-YUrosb1Yuxrs=.d5b59b71-2ca1-4f58-a76c-e13f1a8fe1df@github.com>

On Wed, 18 Sep 2024 23:40:16 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment fix
>
> test/jdk/java/awt/Frame/FrameSetMinimumSizeTest.java line 61:
> 
>> 59:             if (!passed) {
>> 60:                 throw new RuntimeException("Frame's setMinimumSize not honoured");
>> 61:              }
> 
> The test condition does not seem right.
> For instance if `passed` was false in one of the previous checks and the final case results in true then the test passes, which seems to be incorrect.

Yes, you are right. Modified the condition to check after every frame resize.

> test/jdk/java/awt/Frame/FrameSetMinimumSizeTest.java line 80:
> 
>> 78:     private static boolean verifyFrameSize(Dimension expected) {
>> 79: 
>> 80:         if (f.getSize().width != expected.width || f.getSize().height != expected.height) {
> 
> Do we need to wrap calls to `verifyFrameSize()` in EDT, since we are accessing frame.getSize() ?

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1766177491
PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1766177586

From psadhukhan at openjdk.org  Thu Sep 19 05:30:58 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 19 Sep 2024 05:30:58 GMT
Subject: RFR: 8339995: Open source several AWT focus tests - series 6
Message-ID: <x2ZMBdtKL5Vl6Ttilo5YR4UGKKrXfm5rN-VnulWIjT4=.adef4881-a709-4756-9160-5785f2d3ea4f@github.com>

Opensource few Focus tests

-------------

Commit messages:
 - windows
 - InitialFocusTest
 - 8339995: Open source several AWT focus tests - series 6

Changes: https://git.openjdk.org/jdk/pull/21079/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21079&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339995
  Stats: 580 lines in 5 files changed: 580 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21079.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21079/head:pull/21079

PR: https://git.openjdk.org/jdk/pull/21079

From psadhukhan at openjdk.org  Thu Sep 19 05:34:48 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 19 Sep 2024 05:34:48 GMT
Subject: RFR: 8339995: Open source several AWT focus tests - series 6 [v2]
In-Reply-To: <x2ZMBdtKL5Vl6Ttilo5YR4UGKKrXfm5rN-VnulWIjT4=.adef4881-a709-4756-9160-5785f2d3ea4f@github.com>
References: <x2ZMBdtKL5Vl6Ttilo5YR4UGKKrXfm5rN-VnulWIjT4=.adef4881-a709-4756-9160-5785f2d3ea4f@github.com>
Message-ID: <A_wNaw65K8dCWTQCRTaWJfCSleWQUKGXdjLKO5ycSAE=.ebe8a500-5749-45cb-8864-7ae0ee042ac5@github.com>

> Opensource few Focus tests

Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:

 - Merge master
 - windows
 - InitialFocusTest
 - 8339995: Open source several AWT focus tests - series 6

-------------

Changes: https://git.openjdk.org/jdk/pull/21079/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21079&range=01
  Stats: 580 lines in 5 files changed: 580 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21079.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21079/head:pull/21079

PR: https://git.openjdk.org/jdk/pull/21079

From abhiscxk at openjdk.org  Thu Sep 19 05:39:40 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 19 Sep 2024 05:39:40 GMT
Subject: RFR: 8340271: Open source several AWT Robot tests [v2]
In-Reply-To: <O-TUZWPtrE0jhM88hf-8jegDZvovvsBIT2N_Yp7D_GM=.32a7cc06-9ee8-4fa5-bae7-417a0dde85e3@github.com>
References: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
 <O-TUZWPtrE0jhM88hf-8jegDZvovvsBIT2N_Yp7D_GM=.32a7cc06-9ee8-4fa5-bae7-417a0dde85e3@github.com>
Message-ID: <rdSGIs4gbAnJ5VWtOIHPb3uBTcJEJ-MQp-uJ-xuVJCA=.d51be195-6dcb-4b93-909a-2a235ff4f3af@github.com>

On Thu, 19 Sep 2024 04:00:30 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few Robot tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor review

test/jdk/java/awt/Robot/CreateScreenCapture.java line 44:

> 42: 
> 43:     static Robot robot;
> 44:     static Dialog dialog;

may be declared as local variable.

test/jdk/java/awt/Robot/CreateScreenCapture.java line 62:

> 60:         PassFailJFrame passFail = new PassFailJFrame(INSTRUCTIONS);
> 61:         dialog = new Dialog(new Frame(), "Instructions");
> 62:         messageText = new TextArea( "", 5, 80, TextArea.SCROLLBARS_BOTH);

Suggestion:

        messageText = new TextArea("", 5, 80, TextArea.SCROLLBARS_BOTH);

test/jdk/java/awt/Robot/CreateScreenCapture.java line 74:

> 72:             image = null;
> 73:             robot.delay(200);
> 74:             log("step #"+i);

Suggestion:

            log("step #" + i);

test/jdk/java/awt/Robot/CreateScreenCapture.java line 80:

> 78: 
> 79:     private static void log(String messageIn) {
> 80:         messageText.append( messageIn + "\n" );

Suggestion:

        messageText.append(messageIn + "\n");

test/jdk/java/awt/Robot/RobotScrollTest.java line 51:

> 49:          3. Once the pointer is on the text area, the Robot will use the mouse wheel
> 50:             to scroll the text.
> 51:             If the text scrolled, hit PASS, else, hit fail.""";

Suggestion:

            If the text scrolled, hit PASS, else, hit FAIL.""";

test/jdk/java/awt/Robot/RobotScrollTest.java line 95:

> 93: 
> 94:             for (int k = 0; k < 5; k++) {
> 95:                 robot.mouseWheel(-1*j);

Suggestion:

                robot.mouseWheel(-1 * j);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766182287
PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766183229
PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766184151
PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766184379
PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766185467
PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766186486

From psadhukhan at openjdk.org  Thu Sep 19 05:59:21 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 19 Sep 2024 05:59:21 GMT
Subject: RFR: 8340271: Open source several AWT Robot tests [v3]
In-Reply-To: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
References: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
Message-ID: <4lGXxaqjfLNx5K8JMvNuKSaq3BHUVd3-DCwrCS_laNo=.c4a7ddb3-65db-452d-92c3-347152f21b31@github.com>

> Opensource few Robot tests

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Formatting

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21062/files
  - new: https://git.openjdk.org/jdk/pull/21062/files/1eeb6826..e5111877

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21062&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21062&range=01-02

  Stats: 7 lines in 2 files changed: 0 ins; 1 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/21062.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21062/head:pull/21062

PR: https://git.openjdk.org/jdk/pull/21062

From azvegint at openjdk.org  Thu Sep 19 06:46:04 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 19 Sep 2024 06:46:04 GMT
Subject: RFR: 8340393: Open source closed choice tests #2
Message-ID: <nPZJzcL0dCCai5InSUz1W8kwsALcAHdRbirw1X76gjk=.808e59af-027a-4666-8e6d-c519bf4db53e@github.com>

few manual tests to open source
Tested on all platforms, all looks good.

-------------

Commit messages:
 - initial

Changes: https://git.openjdk.org/jdk/pull/21081/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21081&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340393
  Stats: 322 lines in 4 files changed: 322 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21081.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21081/head:pull/21081

PR: https://git.openjdk.org/jdk/pull/21081

From azvegint at openjdk.org  Thu Sep 19 06:48:36 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 19 Sep 2024 06:48:36 GMT
Subject: RFR: 8340365: Position the first window of a window list
In-Reply-To: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
References: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
Message-ID: <f8_aHm7gEbSFOCaqxWy-SYGHjbJ-LN__g6o7DnA-vu8=.8958320c-7b92-466c-b759-e1c6fff42bf8@github.com>

On Wed, 18 Sep 2024 12:05:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Support of multiple test UI windows in `PassFailJFrame` is still evolving. After [JDK-8340210](https://bugs.openjdk.org/browse/JDK-8340210), the `Builder` has a method `positionTestUI` to supply an implementation of the `PositionWindows` interface which handles the positioning of all test UI windows created.
> 
> If `PositionWindows` is not provided, all the test UI windows are left with the default coordinates: (0, 0).
> 
> If `PassFailJFrame` called `positionTestWindow` for the first window, it would allow the test developer to position other windows based on the position of the first one.
> 
> This issue was raised in #21029 in [this thread of comments](https://github.com/openjdk/jdk/pull/21029#discussion_r1763744407).
> 
> To make it easier to position multiple test UI windows without implementing the `PositionWindows` interface, the `PassFailJFrame` should position the first window of the list.
> 
> The `LotsOfMenuItemsTest.java` test in #21029 had to hard-code the coordinates or use `PassFailJFrame.positionTestWindow` explicitly in its `ComponentListener.componentShown`.
> 
> With the proposed change in this pull request, the implementation would use `ComponentListener.componentMoved`:
> 
> 
>     @Override
>     public void componentMoved(ComponentEvent e) {
>         testFrame.setLocation(firstFrame.getX(),
>                               firstFrame.getY() + firstFrame.getHeight() + 8);
>     }
> 
> 
> This has the advantage in that the test UI windows don't flicker for a short time in the upper left corner of the screen; and the developer has to handle only positioning the second window (frame).
> 
> However, this has a funny effect: if you move the first frame with mouse or in any other way, the second frame follows. To avoid such kind of behaviour, call `removeComponentListener` in the handler.
> 
> @honkar-jdk, @azvegint, could you take a look?

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21057#pullrequestreview-2314554177

From abhiscxk at openjdk.org  Thu Sep 19 09:10:37 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 19 Sep 2024 09:10:37 GMT
Subject: RFR: 8340271: Open source several AWT Robot tests [v3]
In-Reply-To: <4lGXxaqjfLNx5K8JMvNuKSaq3BHUVd3-DCwrCS_laNo=.c4a7ddb3-65db-452d-92c3-347152f21b31@github.com>
References: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
 <4lGXxaqjfLNx5K8JMvNuKSaq3BHUVd3-DCwrCS_laNo=.c4a7ddb3-65db-452d-92c3-347152f21b31@github.com>
Message-ID: <yhEL-swLTHc2ChRxZBdcoovtjtrVK4N7uRgq5PpXJSw=.3b199a4b-8641-495d-ab93-84383b9f4251@github.com>

On Thu, 19 Sep 2024 05:59:21 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few Robot tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Formatting

test/jdk/java/awt/Robot/CreateScreenCapture.java line 43:

> 41: public class CreateScreenCapture {
> 42: 
> 43:     static Robot robot;

`robot` var also can be moved inside main.

test/jdk/java/awt/Robot/CreateScreenCapture.java line 79:

> 77: 
> 78:     private static void log(String messageIn) {
> 79:         messageText.append( messageIn + "\n");

Suggestion:

        messageText.append(messageIn + "\n");

test/jdk/java/awt/Robot/RobotScrollTest.java line 47:

> 45:     private static final String INSTRUCTIONS = """
> 46:          0. DON'T TOUCH ANYTHING!
> 47:          1. This test is for Windown and Linux only.

Suggestion:

         1. This test is for Windows and Linux only.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766463911
PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766464170
PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766464530

From psadhukhan at openjdk.org  Thu Sep 19 09:18:57 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 19 Sep 2024 09:18:57 GMT
Subject: RFR: 8340271: Open source several AWT Robot tests [v4]
In-Reply-To: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
References: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
Message-ID: <x_rSI692H7I7r0QCdc3bul58viHeMHNSOs0auVS-BDY=.2114d42f-d435-4b74-a01b-19f4dc9236eb@github.com>

> Opensource few Robot tests

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  review comment fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21062/files
  - new: https://git.openjdk.org/jdk/pull/21062/files/e5111877..189044b1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21062&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21062&range=02-03

  Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/21062.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21062/head:pull/21062

PR: https://git.openjdk.org/jdk/pull/21062

From abhiscxk at openjdk.org  Thu Sep 19 09:18:57 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 19 Sep 2024 09:18:57 GMT
Subject: RFR: 8340271: Open source several AWT Robot tests [v4]
In-Reply-To: <x_rSI692H7I7r0QCdc3bul58viHeMHNSOs0auVS-BDY=.2114d42f-d435-4b74-a01b-19f4dc9236eb@github.com>
References: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
 <x_rSI692H7I7r0QCdc3bul58viHeMHNSOs0auVS-BDY=.2114d42f-d435-4b74-a01b-19f4dc9236eb@github.com>
Message-ID: <B2uhGyPPQcj-P567tUUf9LRQZVWZLqibsBSbCQ8xJDM=.660381d5-3035-4f66-8091-75851ec160c7@github.com>

On Thu, 19 Sep 2024 09:15:55 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few Robot tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment fix

Marked as reviewed by abhiscxk (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21062#pullrequestreview-2314932344

From aivanov at openjdk.org  Thu Sep 19 09:47:09 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 19 Sep 2024 09:47:09 GMT
Subject: RFR: 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds
 timeout
Message-ID: <kWrLjRneFM-LNQZwh6i-Vdq75dDYQP3rPbqXilfjzLk=.95139835-fe2b-493c-8cec-6b5dd4e60c25@github.com>

I am open-sourcing the `Numpad1KeyTyped.java` test.

I used `CountDownLatch` for synchronisation.

The test passes in CI.

-------------

Commit messages:
 - 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout

Changes: https://git.openjdk.org/jdk/pull/21085/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21085&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340008
  Stats: 178 lines in 1 file changed: 178 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21085.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21085/head:pull/21085

PR: https://git.openjdk.org/jdk/pull/21085

From aivanov at openjdk.org  Thu Sep 19 09:47:09 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 19 Sep 2024 09:47:09 GMT
Subject: RFR: 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15
 seconds timeout
In-Reply-To: <kWrLjRneFM-LNQZwh6i-Vdq75dDYQP3rPbqXilfjzLk=.95139835-fe2b-493c-8cec-6b5dd4e60c25@github.com>
References: <kWrLjRneFM-LNQZwh6i-Vdq75dDYQP3rPbqXilfjzLk=.95139835-fe2b-493c-8cec-6b5dd4e60c25@github.com>
Message-ID: <z9YJdA1B_3orxfeYuDLCQBE1UqDql6ZRfwwzi_Pa2dI=.4268a62b-7717-4a0a-9364-bcee3b3fe83d@github.com>

On Thu, 19 Sep 2024 09:40:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I am open-sourcing the `Numpad1KeyTyped.java` test.
> 
> I used `CountDownLatch` for synchronisation.
> 
> The test passes in CI.

The test is somewhat similar to #21013, it uses similar synchronisation logic.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21085#issuecomment-2360515586

From aivanov at openjdk.org  Thu Sep 19 09:47:43 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 19 Sep 2024 09:47:43 GMT
Subject: Integrated: 8340007: Refactor KeyEvent/FunctionKeyTest.java
In-Reply-To: <TT5b8Kyty70NTNh94YUfKY1lKtxbBe_Niw9X3HmSBTk=.ab198caa-c838-4336-9e07-470e607ac781@github.com>
References: <TT5b8Kyty70NTNh94YUfKY1lKtxbBe_Niw9X3HmSBTk=.ab198caa-c838-4336-9e07-470e607ac781@github.com>
Message-ID: <SZG2Ci9d84ggCo-YDXoD0NRoGR-Hc15x320FbZdxIOo=.e8df9ba7-5522-4c9f-92b8-ed8851814077@github.com>

On Mon, 16 Sep 2024 09:55:19 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> This changeset refactors `java/awt/event/KeyEvent/FunctionKeyTest.java`.
> 
> Key changes:
> 
> - Use `CyclicBarrier` to verify whether a key is pressed and released;
> - Use `CountDownLatch` for frame activation;
> - Ensure thread-safety for keeping thrown exceptions.
> 
> Other changes:
> 
> - Made `FunctionKeyTester` a nested class inside `FunctionKeyTest`;
> - Used constants for the key events rather than magic numbers.
> 
> I ran the updated test a few times with `JTREG=REPEAT_COUNT=20`, the test has passed.
> 
> The updated test executes somewhat quicker than the old one.
> 
> @azvegint, you may want to take a look.

This pull request has now been integrated.

Changeset: 2faf8b8d
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/2faf8b8d582183275b1fdc92313a1c63c1753e80
Stats:     114 lines in 1 file changed: 62 ins; 15 del; 37 mod

8340007: Refactor KeyEvent/FunctionKeyTest.java

Reviewed-by: azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/21013

From azvegint at openjdk.org  Thu Sep 19 09:52:36 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 19 Sep 2024 09:52:36 GMT
Subject: RFR: 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15
 seconds timeout
In-Reply-To: <kWrLjRneFM-LNQZwh6i-Vdq75dDYQP3rPbqXilfjzLk=.95139835-fe2b-493c-8cec-6b5dd4e60c25@github.com>
References: <kWrLjRneFM-LNQZwh6i-Vdq75dDYQP3rPbqXilfjzLk=.95139835-fe2b-493c-8cec-6b5dd4e60c25@github.com>
Message-ID: <u0etilkafAIvOXEyuwMnBGU6VN0-C9EeV4mwR0D-pcY=.7ae00a50-dd76-4a72-9e04-e80158976ec3@github.com>

On Thu, 19 Sep 2024 09:40:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I am open-sourcing the `Numpad1KeyTyped.java` test.
> 
> I used `CountDownLatch` for synchronisation.
> 
> The test passes in CI.

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21085#pullrequestreview-2315017807

From aivanov at openjdk.org  Thu Sep 19 11:51:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 19 Sep 2024 11:51:39 GMT
Subject: Integrated: 8340306: Add border around instructions in PassFailJFrame
In-Reply-To: <zTSZWNkl9I8P5xSP_v09hE2PT29ngxOYoQ8Zhui4ZoA=.48419fb6-aa9d-4d8d-a078-354e7360a029@github.com>
References: <zTSZWNkl9I8P5xSP_v09hE2PT29ngxOYoQ8Zhui4ZoA=.48419fb6-aa9d-4d8d-a078-354e7360a029@github.com>
Message-ID: <BgIvcJnaWfe6K54cTcnHEt0Wc457TkTbKLhmy5g9BuA=.95ec6465-b418-44b6-a707-69568099ae2a@github.com>

On Tue, 17 Sep 2024 12:39:20 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> A trivial change which adds border around instruction text. It makes the text easier to read.
> 
> (In some tests, people added leading spaces to each line to make the instructions easier to read; with the added border, there's no need for this trick.)

This pull request has now been integrated.

Changeset: 0120d3ee
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/0120d3eed50bdc9fa53f2c41b31791620aeef613
Stats:     2 lines in 1 file changed: 2 ins; 0 del; 0 mod

8340306: Add border around instructions in PassFailJFrame

Reviewed-by: honkar, prr

-------------

PR: https://git.openjdk.org/jdk/pull/21038

From ngubarkov at openjdk.org  Thu Sep 19 11:54:56 2024
From: ngubarkov at openjdk.org (Nikita Gubarkov)
Date: Thu, 19 Sep 2024 11:54:56 GMT
Subject: RFR: 8339341: SurfaceManager cacheMap retains strong references
 [v4]
In-Reply-To: <1ecWvJLiG54e0saEz_Jjz46gzxXnqsNDagdPQ3y_BN4=.27116e44-886b-405f-9d87-ec5e82e2fd20@github.com>
References: <1ecWvJLiG54e0saEz_Jjz46gzxXnqsNDagdPQ3y_BN4=.27116e44-886b-405f-9d87-ec5e82e2fd20@github.com>
Message-ID: <qP_So5GlLcIx3C4c_HAYXMmBwZNPMX7xfXh-UjDU5IA=.23474628-6b73-4212-9cf8-ca7066834d48@github.com>

> I moved SurfaceDataProxy cache into a separate class.
> Now caching level is determined by placement of the SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" proxies and therefore strong refs via them do not prevent the cache and GraphicsConfig from being detected as weakly reachable.

Nikita Gubarkov has updated the pull request incrementally with one additional commit since the last revision:

  Revert wildcard import in X11GraphicsDevice

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20825/files
  - new: https://git.openjdk.org/jdk/pull/20825/files/87866453..1a7a6d62

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20825&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20825&range=02-03

  Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/20825.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20825/head:pull/20825

PR: https://git.openjdk.org/jdk/pull/20825

From aturbanov at openjdk.org  Thu Sep 19 14:14:41 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Thu, 19 Sep 2024 14:14:41 GMT
Subject: RFR: 8339972: Make a few fields in SortingFocusTraversalPolicy
 static
In-Reply-To: <HP1wTLCSf2CmDsPY7n5glKw0FLG11yV-WFAps78qFBs=.bf09f28c-4110-4279-b844-703ccd9bcb27@github.com>
References: <HP1wTLCSf2CmDsPY7n5glKw0FLG11yV-WFAps78qFBs=.bf09f28c-4110-4279-b844-703ccd9bcb27@github.com>
Message-ID: <K5nJCosuNVogZNPQ10Q5Qn615-yyaPbvobyQSdPkUEo=.4a25b35e-8c12-4351-b5e8-19de7ec4b084@github.com>

On Thu, 25 Jul 2024 11:17:23 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> 2 fields in javax.swing.SortingFocusTraversalPolicy could be made 'static':
> 1. FORWARD_TRAVERSAL = 0
> 2. BACKWARD_TRAVERSAL = 1

Any more reviewers? I will integrate tomorrow.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20327#issuecomment-2361102283

From azvegint at openjdk.org  Thu Sep 19 15:13:36 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 19 Sep 2024 15:13:36 GMT
Subject: RFR: 8340308: PassFailJFrame: Make rows default to number of lines
 in instructions
In-Reply-To: <u0itoRE_OT4Jht_rlEj1RPKS2zDPZlywWqleNJMiDnE=.27f17c90-c321-45b9-8f78-e669ce10df69@github.com>
References: <u0itoRE_OT4Jht_rlEj1RPKS2zDPZlywWqleNJMiDnE=.27f17c90-c321-45b9-8f78-e669ce10df69@github.com>
Message-ID: <RY617TfxeWKDxevDCOpgPuJ6lGkOSgnRCli5Y1FK07A=.e4c424c8-dd1e-4bb9-859f-26b38319b47f@github.com>

On Tue, 17 Sep 2024 13:45:06 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> It has become quite common to use the following code
> 
> 
> .rows((int) INSTRUCTIONS.lines().count() + 1)
> 
> 
> to set the number of rows for `PassFailJFrame`.
> 
> Make this the default value. Newer tests could drop `.rows` from builder configuration if the new default works well.
> 
> If a test needs customising the new default value, the newly added method `rowsAdd` could be used to increase the number of rows.

As another improvement, we can also consider calculating the default number of columns (based on the widest string?) in a separate issue.

-------------

Marked as reviewed by azvegint (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21039#pullrequestreview-2315852047

From abhiscxk at openjdk.org  Thu Sep 19 15:47:27 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 19 Sep 2024 15:47:27 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v12]
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <XKLzVFoLbvvVjFGFYbH3Yeh-YLEWnFEFxapy3imeC0I=.bd2696a2-be5b-4a2e-8b9f-fb5df1adfc0e@github.com>

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Test update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21029/files
  - new: https://git.openjdk.org/jdk/pull/21029/files/ed39f24a..9dc4e922

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=11
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=10-11

  Stats: 15 lines in 1 file changed: 8 ins; 2 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From aivanov at openjdk.org  Thu Sep 19 15:57:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 19 Sep 2024 15:57:39 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v11]
In-Reply-To: <s_mg4w4D9QwccLu5gW3ixWLlfOtco6epbw09Zk6nxmM=.15e9f353-0e02-4bf7-9144-aab0bf873718@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <s_mg4w4D9QwccLu5gW3ixWLlfOtco6epbw09Zk6nxmM=.15e9f353-0e02-4bf7-9144-aab0bf873718@github.com>
Message-ID: <vg0xg6oi5ynfruBWnvl-wgADwDfnOrb9rR_erny4E5A=.b261bc5f-520e-4885-8ebd-b431c2364101@github.com>

On Thu, 19 Sep 2024 04:56:13 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test restructured and test frames set visible true

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 44:

> 42:     private static final int NUM_WINDOWS = 400;
> 43:     private static TestFrame firstFrame;
> 44:     private static TestFrame testFrame;

`testFrame` field is no longer needed, it can be a local variable in `componentShown`.

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 77:

> 75:     public void componentShown(ComponentEvent e) {
> 76:         for (int i = 1; i < NUM_WINDOWS - 1; ++i) {
> 77:             testFrame = new TestFrame("Running(" + i + ")...");

Currently the created frames flicker at the upper left upper corner of the screen, I suggest displaying them below the first frame:


    public void componentShown(ComponentEvent e) {
        final int x = firstFrame.getX();
        final int y = firstFrame.getY() + firstFrame.getHeight() + 8;

        for (int i = 1; i < NUM_WINDOWS - 1; ++i) {
            testFrame = new TestFrame("Running(" + i + ")...", x, y);


You'll create the last frame using the same constructor as above in the loop.

I find this way less distracting, and I can read the instructions while the test continues to perform its _initialisation_.

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 83:

> 81:         testFrame = new TestFrame("Last Frame");
> 82:         testFrame.setLocation(firstFrame.getX(),
> 83:                 firstFrame.getY() + firstFrame.getHeight() + 8);

I mean, these two lines will become:


        testFrame = new TestFrame("Last Frame", x, y);

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 94:

> 92:         }
> 93: 
> 94:         public TestFrame(String title, boolean visible) {

You'll need a constructor which accepts `x` and `y`:
Suggestion:

        public TestFrame(String title) {
            this(title, 0, 0, false);
        }

        public TestFrame(String s, int x, int y) {
            this(s, x, y, true);
        }

        private TestFrame(String title,
                          int x, int y,
                          boolean visible) {


Then you'll call `setLocation(x, y);` before calling `setSize`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2315786971
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1766976607
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1766983802
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1766985049
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1766989912

From abhiscxk at openjdk.org  Thu Sep 19 16:08:09 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 19 Sep 2024 16:08:09 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v13]
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <naLxmUqs4ticZr1DXt9dMeafrDDLtcQpMSsP0OITWcc=.36fa6fe1-cbf3-44f8-b4a4-5dfb8d50540b@github.com>

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  TestFrame var declared as local var

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21029/files
  - new: https://git.openjdk.org/jdk/pull/21029/files/9dc4e922..421ef3ef

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=12
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=11-12

  Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From aivanov at openjdk.org  Thu Sep 19 16:08:10 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 19 Sep 2024 16:08:10 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v11]
In-Reply-To: <vg0xg6oi5ynfruBWnvl-wgADwDfnOrb9rR_erny4E5A=.b261bc5f-520e-4885-8ebd-b431c2364101@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <s_mg4w4D9QwccLu5gW3ixWLlfOtco6epbw09Zk6nxmM=.15e9f353-0e02-4bf7-9144-aab0bf873718@github.com>
 <vg0xg6oi5ynfruBWnvl-wgADwDfnOrb9rR_erny4E5A=.b261bc5f-520e-4885-8ebd-b431c2364101@github.com>
Message-ID: <mxPVEEg_Xx-InAzQ_dPyiyIR1L6OBXFhZnvkLumZwQQ=.126484bd-911a-4795-9127-8ec7a3738c69@github.com>

On Thu, 19 Sep 2024 14:55:39 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test restructured and test frames set visible true
>
> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 94:
> 
>> 92:         }
>> 93: 
>> 94:         public TestFrame(String title, boolean visible) {
> 
> You'll need a constructor which accepts `x` and `y`:
> Suggestion:
> 
>         public TestFrame(String title) {
>             this(title, 0, 0, false);
>         }
> 
>         public TestFrame(String s, int x, int y) {
>             this(s, x, y, true);
>         }
> 
>         private TestFrame(String title,
>                           int x, int y,
>                           boolean visible) {
> 
> 
> Then you'll call `setLocation(x, y);` before calling `setSize`.

Most of these comments are already resolved, except for

> `testFrame` field is no longer needed, it can be a local variable in `componentShown`.

I discussed it with Abhishek privately but I forgot to click the *Submit* button to post them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1767098803

From honkar at openjdk.org  Thu Sep 19 16:11:35 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 19 Sep 2024 16:11:35 GMT
Subject: RFR: 8340271: Open source several AWT Robot tests [v4]
In-Reply-To: <x_rSI692H7I7r0QCdc3bul58viHeMHNSOs0auVS-BDY=.2114d42f-d435-4b74-a01b-19f4dc9236eb@github.com>
References: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
 <x_rSI692H7I7r0QCdc3bul58viHeMHNSOs0auVS-BDY=.2114d42f-d435-4b74-a01b-19f4dc9236eb@github.com>
Message-ID: <wFVPZEsmyZy_EOBYw6pcRxk2TNZhKO3bqdJaMcbQ-p0=.4f1614af-b091-49e4-b18f-1397e9932b23@github.com>

On Thu, 19 Sep 2024 09:18:57 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few Robot tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment fix

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21062#pullrequestreview-2316010203

From aivanov at openjdk.org  Thu Sep 19 16:15:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 19 Sep 2024 16:15:39 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v13]
In-Reply-To: <naLxmUqs4ticZr1DXt9dMeafrDDLtcQpMSsP0OITWcc=.36fa6fe1-cbf3-44f8-b4a4-5dfb8d50540b@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <naLxmUqs4ticZr1DXt9dMeafrDDLtcQpMSsP0OITWcc=.36fa6fe1-cbf3-44f8-b4a4-5dfb8d50540b@github.com>
Message-ID: <tDs-fhWqcrs17eIpoXmr-HqhVkmE-BIDT3fCcwmAn8A=.513ab456-df17-419e-9741-76e3fbfa7634@github.com>

On Thu, 19 Sep 2024 16:08:09 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   TestFrame var declared as local var

Except for the minor nit, looks good to me now.

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 75:

> 73:     @Override
> 74:     public void componentShown(ComponentEvent e) {
> 75:         TestFrame testFrame;

I'd rather declare it before the loop ? it's where `testFrame` is used.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2316017874
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1767114783

From abhiscxk at openjdk.org  Thu Sep 19 16:22:27 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 19 Sep 2024 16:22:27 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v14]
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <RztOW3ab8aVvhquGLJSuvolPoq8k3QUwdqyvUphzzdY=.02cb3b9d-e5be-4f0c-a40d-fa1298c0a0b3@github.com>

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Minor fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21029/files
  - new: https://git.openjdk.org/jdk/pull/21029/files/421ef3ef..5aa4f88f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=13
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21029&range=12-13

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21029.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21029/head:pull/21029

PR: https://git.openjdk.org/jdk/pull/21029

From abhiscxk at openjdk.org  Thu Sep 19 16:22:28 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 19 Sep 2024 16:22:28 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v13]
In-Reply-To: <tDs-fhWqcrs17eIpoXmr-HqhVkmE-BIDT3fCcwmAn8A=.513ab456-df17-419e-9741-76e3fbfa7634@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <naLxmUqs4ticZr1DXt9dMeafrDDLtcQpMSsP0OITWcc=.36fa6fe1-cbf3-44f8-b4a4-5dfb8d50540b@github.com>
 <tDs-fhWqcrs17eIpoXmr-HqhVkmE-BIDT3fCcwmAn8A=.513ab456-df17-419e-9741-76e3fbfa7634@github.com>
Message-ID: <CRDBMBLuMAsVENdMa248jYZFaRc5uxLHVW57gWeBMus=.69e20673-edce-4363-83d6-8270dc4ed169@github.com>

On Thu, 19 Sep 2024 16:12:45 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   TestFrame var declared as local var
>
> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 75:
> 
>> 73:     @Override
>> 74:     public void componentShown(ComponentEvent e) {
>> 75:         TestFrame testFrame;
> 
> I'd rather declare it before the loop ? it's where `testFrame` is used.

Ok... Need re-review.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1767121466

From psadhukhan at openjdk.org  Thu Sep 19 16:24:44 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 19 Sep 2024 16:24:44 GMT
Subject: Integrated: 8340271: Open source several AWT Robot tests
In-Reply-To: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
References: <nGwhv37IsS-Jph3KaakW8bdg5fxvZwnMHsUPRlcgNzo=.d110a070-d700-4715-9c30-609ea09d6802@github.com>
Message-ID: <ofxR1a0wki0EOc6bPlTCU_nvLswsLJYvID8L2JR6N7E=.9c5867e8-cac9-4757-a0fe-3da1eae31ced@github.com>

On Wed, 18 Sep 2024 13:26:35 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few Robot tests

This pull request has now been integrated.

Changeset: bc36ace7
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/bc36ace72c1189dcd6d0c05d40d8c568acd89b01
Stats:     182 lines in 2 files changed: 182 ins; 0 del; 0 mod

8340271: Open source several AWT Robot tests

Reviewed-by: abhiscxk, honkar

-------------

PR: https://git.openjdk.org/jdk/pull/21062

From aivanov at openjdk.org  Thu Sep 19 16:28:47 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 19 Sep 2024 16:28:47 GMT
Subject: RFR: 8339984: Open source AWT MenuItem related tests [v14]
In-Reply-To: <RztOW3ab8aVvhquGLJSuvolPoq8k3QUwdqyvUphzzdY=.02cb3b9d-e5be-4f0c-a40d-fa1298c0a0b3@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
 <RztOW3ab8aVvhquGLJSuvolPoq8k3QUwdqyvUphzzdY=.02cb3b9d-e5be-4f0c-a40d-fa1298c0a0b3@github.com>
Message-ID: <AyL68q0TYDF6OwTv06pqNhXZJJS2sqVQKnhhFHldYGQ=.0ea1db66-06f9-47e2-b667-94f16f40a203@github.com>

On Thu, 19 Sep 2024 16:22:27 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor fix

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2316045934

From aivanov at openjdk.org  Thu Sep 19 16:57:35 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 19 Sep 2024 16:57:35 GMT
Subject: RFR: 8340308: PassFailJFrame: Make rows default to number of lines
 in instructions
In-Reply-To: <RY617TfxeWKDxevDCOpgPuJ6lGkOSgnRCli5Y1FK07A=.e4c424c8-dd1e-4bb9-859f-26b38319b47f@github.com>
References: <u0itoRE_OT4Jht_rlEj1RPKS2zDPZlywWqleNJMiDnE=.27f17c90-c321-45b9-8f78-e669ce10df69@github.com>
 <RY617TfxeWKDxevDCOpgPuJ6lGkOSgnRCli5Y1FK07A=.e4c424c8-dd1e-4bb9-859f-26b38319b47f@github.com>
Message-ID: <d_h7HeoVnb-trq89MkSZVOmS2WRoVVa26KxEtGIolbo=.9a416542-3265-4c24-a69c-5ecd37bcbe31@github.com>

On Thu, 19 Sep 2024 15:10:55 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> As another improvement, we can also consider calculating the default number of columns (based on the widest string?) in a separate issue.

Yes!

I added a comment in JBS:

> This is part of a larger effort for providing better defaults for sizing the instructions which is tracked by [JDK-8328163](https://bugs.openjdk.org/browse/JDK-8328163): *Implement automatic instruction sizing for `PassFailJFrame`*.

I quickly prototyped it in my [8328163-autoSize-passFail](https://github.com/aivanov-jdk/jdk/tree/8328163-autoSize-passFail) branch ([diff to master](https://github.com/openjdk/jdk/compare/master...aivanov-jdk:jdk:8328163-autoSize-passFail)) in March 2024, yet it proved to be not as simple.

I guess if we disable word-wrapping on `JTextArea`, it becomes simpler; yet some tests already depend on word-wrapping. I or anyone else have to come up with a clever heuristics which works good in most cases.

I thought about using something like this: disable word-wrapping and get text dimensions; if the width is too large (how large?), then enable word-wrapping and reduce the width of the text area, recalculate the preferred size again. If the height is too large (how large?), limit it to a value, the instructions are already in `JScrollPane`, yet it's best to avoid scroll bars ? seeing all the instruction text is always better compared to having to scroll.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21039#issuecomment-2361637062

From aivanov at openjdk.org  Thu Sep 19 17:02:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 19 Sep 2024 17:02:38 GMT
Subject: Integrated: 8340308: PassFailJFrame: Make rows default to number of
 lines in instructions
In-Reply-To: <u0itoRE_OT4Jht_rlEj1RPKS2zDPZlywWqleNJMiDnE=.27f17c90-c321-45b9-8f78-e669ce10df69@github.com>
References: <u0itoRE_OT4Jht_rlEj1RPKS2zDPZlywWqleNJMiDnE=.27f17c90-c321-45b9-8f78-e669ce10df69@github.com>
Message-ID: <nH-oJ7x2TZ2uTMSCzRkNJe9jzOthLDLl9x6WTYGI8s4=.1c251ffa-aa7d-4726-bd28-aab267003dc8@github.com>

On Tue, 17 Sep 2024 13:45:06 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> It has become quite common to use the following code
> 
> 
> .rows((int) INSTRUCTIONS.lines().count() + 1)
> 
> 
> to set the number of rows for `PassFailJFrame`.
> 
> Make this the default value. Newer tests could drop `.rows` from builder configuration if the new default works well.
> 
> If a test needs customising the new default value, the newly added method `rowsAdd` could be used to increase the number of rows.

This pull request has now been integrated.

Changeset: d1d82400
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d1d824008d1dc70029013820814fd03c40b4e309
Stats:     35 lines in 1 file changed: 34 ins; 0 del; 1 mod

8340308: PassFailJFrame: Make rows default to number of lines in instructions

Reviewed-by: honkar, azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/21039

From honkar at openjdk.org  Thu Sep 19 18:05:30 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 19 Sep 2024 18:05:30 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2
Message-ID: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>

Following tests are updated in this PR:

1. 	test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java
2. 	test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java
3. 	test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java
4. 	test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java

-------------

Commit messages:
 - eof newline
 - checkbox tests

Changes: https://git.openjdk.org/jdk/pull/21094/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21094&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340077
  Stats: 409 lines in 4 files changed: 409 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21094.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21094/head:pull/21094

PR: https://git.openjdk.org/jdk/pull/21094

From kizune at openjdk.org  Thu Sep 19 19:53:44 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 19 Sep 2024 19:53:44 GMT
Subject: Integrated: 8339902: Open source couple TextField related tests
In-Reply-To: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
References: <3eqU_lYBmHdKOD1J2VZxY519u95a2qPAfZaOalgAr-U=.ccbf6739-7c82-43fa-a77f-d729e3123e12@github.com>
Message-ID: <JImU24CFbPeSGj7IihCTOjtkv66Eq9VYgTUBLp19zrc=.8969d4f5-a30d-47df-a53e-48562027c7b8@github.com>

On Mon, 16 Sep 2024 23:02:58 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and open source five TextField related tests: 
> java/awt/TextField/CaretPositionTest;
> java/awt/TextField/SetBoundsTest;
> java/awt/TextField/SetEchoCharTest4;
> java/awt/TextField/SetPasswordTest;
> java/awt/TextField/ZeroEchoCharTest

This pull request has now been integrated.

Changeset: fde85083
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/fde8508379d2983fa70784faef60699c81f9c359
Stats:     527 lines in 5 files changed: 527 ins; 0 del; 0 mod

8339902: Open source couple TextField related tests

Reviewed-by: honkar

-------------

PR: https://git.openjdk.org/jdk/pull/21026

From prr at openjdk.org  Thu Sep 19 22:23:06 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 19 Sep 2024 22:23:06 GMT
Subject: Integrated: 8340480: Bad copyright notices in changes from JDK-8339902
Message-ID: <WUzr81oP4HJCdBwtOmrglVtvplF_h4F5tEGKiF3Nwbc=.a27a67a9-2d19-4433-b9f7-4bde28d65cc4@github.com>

fix legal notices

-------------

Commit messages:
 - 8340480

Changes: https://git.openjdk.org/jdk/pull/21095/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21095&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340480
  Stats: 5 lines in 5 files changed: 0 ins; 5 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21095.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21095/head:pull/21095

PR: https://git.openjdk.org/jdk/pull/21095

From kcr at openjdk.org  Thu Sep 19 22:23:06 2024
From: kcr at openjdk.org (Kevin Rushforth)
Date: Thu, 19 Sep 2024 22:23:06 GMT
Subject: Integrated: 8340480: Bad copyright notices in changes from
 JDK-8339902
In-Reply-To: <WUzr81oP4HJCdBwtOmrglVtvplF_h4F5tEGKiF3Nwbc=.a27a67a9-2d19-4433-b9f7-4bde28d65cc4@github.com>
References: <WUzr81oP4HJCdBwtOmrglVtvplF_h4F5tEGKiF3Nwbc=.a27a67a9-2d19-4433-b9f7-4bde28d65cc4@github.com>
Message-ID: <DQDtYhVWf4nDq_WlObKaPUsEWolrFSi4qgS7LXo-43I=.7a82337c-16c6-481b-ba18-7b171b012002@github.com>

On Thu, 19 Sep 2024 22:12:28 GMT, Phil Race <prr at openjdk.org> wrote:

> fix legal notices

Marked as reviewed by kcr (Author).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21095#pullrequestreview-2316838873

From bpb at openjdk.org  Thu Sep 19 22:23:06 2024
From: bpb at openjdk.org (Brian Burkhalter)
Date: Thu, 19 Sep 2024 22:23:06 GMT
Subject: Integrated: 8340480: Bad copyright notices in changes from
 JDK-8339902
In-Reply-To: <WUzr81oP4HJCdBwtOmrglVtvplF_h4F5tEGKiF3Nwbc=.a27a67a9-2d19-4433-b9f7-4bde28d65cc4@github.com>
References: <WUzr81oP4HJCdBwtOmrglVtvplF_h4F5tEGKiF3Nwbc=.a27a67a9-2d19-4433-b9f7-4bde28d65cc4@github.com>
Message-ID: <k8NOnOQPflOmSASF62ZV83qfUzoVf7Dvc-6mKhK1ogE=.fc52f586-5242-4198-a816-1a595c3ae51c@github.com>

On Thu, 19 Sep 2024 22:12:28 GMT, Phil Race <prr at openjdk.org> wrote:

> fix legal notices

Looks okay.

-------------

Marked as reviewed by bpb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21095#pullrequestreview-2316841147

From kizune at openjdk.org  Thu Sep 19 22:23:07 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 19 Sep 2024 22:23:07 GMT
Subject: Integrated: 8340480: Bad copyright notices in changes from
 JDK-8339902
In-Reply-To: <WUzr81oP4HJCdBwtOmrglVtvplF_h4F5tEGKiF3Nwbc=.a27a67a9-2d19-4433-b9f7-4bde28d65cc4@github.com>
References: <WUzr81oP4HJCdBwtOmrglVtvplF_h4F5tEGKiF3Nwbc=.a27a67a9-2d19-4433-b9f7-4bde28d65cc4@github.com>
Message-ID: <GhYKapP_GCl5-CykA-AlmbaHG4oTy1UcSYX4sW3ypWI=.3a57bcd5-41d5-4736-8373-34e0b49c2b2d@github.com>

On Thu, 19 Sep 2024 22:12:28 GMT, Phil Race <prr at openjdk.org> wrote:

> fix legal notices

Marked as reviewed by kizune (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21095#pullrequestreview-2316842102

From prr at openjdk.org  Thu Sep 19 22:23:07 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 19 Sep 2024 22:23:07 GMT
Subject: Integrated: 8340480: Bad copyright notices in changes from JDK-8339902
In-Reply-To: <WUzr81oP4HJCdBwtOmrglVtvplF_h4F5tEGKiF3Nwbc=.a27a67a9-2d19-4433-b9f7-4bde28d65cc4@github.com>
References: <WUzr81oP4HJCdBwtOmrglVtvplF_h4F5tEGKiF3Nwbc=.a27a67a9-2d19-4433-b9f7-4bde28d65cc4@github.com>
Message-ID: <zsWdkB3Gnv1Mug7Yr_C0KJ_YDCa0efFHSRip0H6O-6I=.9be8a9ce-f99f-4e79-a49e-fa3c626d91b8@github.com>

On Thu, 19 Sep 2024 22:12:28 GMT, Phil Race <prr at openjdk.org> wrote:

> fix legal notices

This pull request has now been integrated.

Changeset: fdc16a37
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/fdc16a373459cb2311316448c765b1bee5c73694
Stats:     5 lines in 5 files changed: 0 ins; 5 del; 0 mod

8340480: Bad copyright notices in changes from JDK-8339902

Reviewed-by: kcr, bpb, kizune

-------------

PR: https://git.openjdk.org/jdk/pull/21095

From kizune at openjdk.org  Thu Sep 19 22:35:54 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 19 Sep 2024 22:35:54 GMT
Subject: RFR: 8340228: Open source couple more miscellaneous AWT tests
Message-ID: <GCL1sMFO9DhSYhDnE02xoO-H607Bu-zH_U6YLOfpk5I=.c6f84457-4752-4758-9007-003a636bfbbf@github.com>

Cleaning up and opensourcing three more tests.

-------------

Commit messages:
 - 8340228: Open source couple more miscellaneous AWT tests

Changes: https://git.openjdk.org/jdk/pull/21097/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21097&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340228
  Stats: 321 lines in 3 files changed: 321 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21097.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21097/head:pull/21097

PR: https://git.openjdk.org/jdk/pull/21097

From prr at openjdk.org  Thu Sep 19 22:49:36 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 19 Sep 2024 22:49:36 GMT
Subject: RFR: 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15
 seconds timeout
In-Reply-To: <kWrLjRneFM-LNQZwh6i-Vdq75dDYQP3rPbqXilfjzLk=.95139835-fe2b-493c-8cec-6b5dd4e60c25@github.com>
References: <kWrLjRneFM-LNQZwh6i-Vdq75dDYQP3rPbqXilfjzLk=.95139835-fe2b-493c-8cec-6b5dd4e60c25@github.com>
Message-ID: <pllOTXOVniy0xCSuYDHDrINHwMiV_BuyA4nGGW1qBm4=.6f268b45-af0d-495c-9469-eaac946bd18b@github.com>

On Thu, 19 Sep 2024 09:40:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I am open-sourcing the `Numpad1KeyTyped.java` test.
> 
> I used `CountDownLatch` for synchronisation.
> 
> The test passes in CI.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21085#pullrequestreview-2316868433

From prr at openjdk.org  Thu Sep 19 22:52:45 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 19 Sep 2024 22:52:45 GMT
Subject: RFR: 8339895: Open source several AWT focus tests - series 3
In-Reply-To: <CzS6G3XZR45SyXRYSIQN97O74FJbZCgdCVyGCufwqLg=.d0cb643b-03d5-477c-8d04-ed69caf3468c@github.com>
References: <CzS6G3XZR45SyXRYSIQN97O74FJbZCgdCVyGCufwqLg=.d0cb643b-03d5-477c-8d04-ed69caf3468c@github.com>
Message-ID: <0TfZRUlaR22cmFAYehh21Zijdtc68KQJFKmaNpZm1aA=.74c931d4-611a-4917-a5c8-55b0e4099609@github.com>

On Wed, 18 Sep 2024 03:37:17 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few focus tests

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21050#pullrequestreview-2316870545

From prr at openjdk.org  Thu Sep 19 22:53:38 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 19 Sep 2024 22:53:38 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v3]
In-Reply-To: <-SetXAnjt6NZPmvVPxUNqm09A2PZE3F8Hjo2iorxkcg=.81418686-ae75-4558-a7f0-0592f416ab04@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
 <-SetXAnjt6NZPmvVPxUNqm09A2PZE3F8Hjo2iorxkcg=.81418686-ae75-4558-a7f0-0592f416ab04@github.com>
Message-ID: <e9nofhpfmBXvvdA28UxC_K-kKziMXEoaEMtr66HqSL0=.95343adb-5a5c-4a7a-8f30-6b8f07de3127@github.com>

On Wed, 18 Sep 2024 04:32:50 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few Focus tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   jcheck

Marked as reviewed by prr (Reviewer).

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 28:

> 26:  * @bug 4982943
> 27:  * @key headful
> 28:  * @summary focus lost in text fields or text areas, unable to enter characters from keyboar

keyboar -> keyboard

-------------

PR Review: https://git.openjdk.org/jdk/pull/21051#pullrequestreview-2316871337
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767681367

From psadhukhan at openjdk.org  Fri Sep 20 03:08:41 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 03:08:41 GMT
Subject: Integrated: 8339895: Open source several AWT focus tests - series 3
In-Reply-To: <CzS6G3XZR45SyXRYSIQN97O74FJbZCgdCVyGCufwqLg=.d0cb643b-03d5-477c-8d04-ed69caf3468c@github.com>
References: <CzS6G3XZR45SyXRYSIQN97O74FJbZCgdCVyGCufwqLg=.d0cb643b-03d5-477c-8d04-ed69caf3468c@github.com>
Message-ID: <JH7jLezK2SPwnUXn73xFZxWreHK1_0J8_zC1IoknpO0=.a83d9aed-97a7-4ef4-afba-1ffc3e0c76eb@github.com>

On Wed, 18 Sep 2024 03:37:17 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few focus tests

This pull request has now been integrated.

Changeset: 94c33179
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/94c33179b6a1205100d7c125f3a7c11e29621db9
Stats:     644 lines in 5 files changed: 644 ins; 0 del; 0 mod

8339895: Open source several AWT focus tests - series 3

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/21050

From psadhukhan at openjdk.org  Fri Sep 20 03:15:06 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 03:15:06 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v4]
In-Reply-To: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
Message-ID: <3yNHmOgVkZcfJZpewia9X0v-JIK0aaSj3TxO36G4Ya4=.54c0600d-09cf-4fb1-973b-449a8660a47b@github.com>

> Opensource few Focus tests

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  typo

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21051/files
  - new: https://git.openjdk.org/jdk/pull/21051/files/509ccf65..c1a3daf6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21051&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21051&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21051.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21051/head:pull/21051

PR: https://git.openjdk.org/jdk/pull/21051

From psadhukhan at openjdk.org  Fri Sep 20 03:15:06 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 03:15:06 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v3]
In-Reply-To: <e9nofhpfmBXvvdA28UxC_K-kKziMXEoaEMtr66HqSL0=.95343adb-5a5c-4a7a-8f30-6b8f07de3127@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
 <-SetXAnjt6NZPmvVPxUNqm09A2PZE3F8Hjo2iorxkcg=.81418686-ae75-4558-a7f0-0592f416ab04@github.com>
 <e9nofhpfmBXvvdA28UxC_K-kKziMXEoaEMtr66HqSL0=.95343adb-5a5c-4a7a-8f30-6b8f07de3127@github.com>
Message-ID: <Ao6R40Haj6Pe6q9O5MaatvfgS7z8XPGsd-DU_Bt9e5c=.6442e796-2b5d-405a-9b96-0fd5d9b7fa82@github.com>

On Thu, 19 Sep 2024 22:50:22 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   jcheck
>
> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 28:
> 
>> 26:  * @bug 4982943
>> 27:  * @key headful
>> 28:  * @summary focus lost in text fields or text areas, unable to enter characters from keyboar
> 
> keyboar -> keyboard

@prrace Fixed but it revokes the approval....Please reapprove or someone "R"eviewer awake in this TZ to approve this minor change..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767893273

From psadhukhan at openjdk.org  Fri Sep 20 03:28:15 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 03:28:15 GMT
Subject: RFR: 8339935: Open source several AWT focus tests - series 5
Message-ID: <9CBDlYAA5yUeyovwlZ8wpQ5fEE6YIXMUUt53BVb-JbU=.9f8c5c39-2e90-4d6a-868f-734cea42367e@github.com>

Opensource few AWT focus tests

-------------

Commit messages:
 - 8339935: Open source several AWT focus tests - series 5

Changes: https://git.openjdk.org/jdk/pull/21103/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21103&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339935
  Stats: 315 lines in 4 files changed: 315 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21103.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21103/head:pull/21103

PR: https://git.openjdk.org/jdk/pull/21103

From psadhukhan at openjdk.org  Fri Sep 20 04:07:15 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 04:07:15 GMT
Subject: RFR: 8340367: Opensource few AWT image tests
Message-ID: <P8HjYF8P5RZA8rHbvrwphv7piP2VNBlOa1QhFWTb9to=.04ff770d-03eb-4c9e-b5be-0687b1fd8ccd@github.com>

Opensource few image tests

-------------

Commit messages:
 - jcheck
 - 8340367: Opensource few AWT image tests
 - 8340367: Opensource few AWT image tests
 - 8340367: Opensource few AWT image tests

Changes: https://git.openjdk.org/jdk/pull/21104/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21104&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340367
  Stats: 513 lines in 5 files changed: 513 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21104.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21104/head:pull/21104

PR: https://git.openjdk.org/jdk/pull/21104

From abhiscxk at openjdk.org  Fri Sep 20 04:16:39 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 20 Sep 2024 04:16:39 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v4]
In-Reply-To: <3yNHmOgVkZcfJZpewia9X0v-JIK0aaSj3TxO36G4Ya4=.54c0600d-09cf-4fb1-973b-449a8660a47b@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
 <3yNHmOgVkZcfJZpewia9X0v-JIK0aaSj3TxO36G4Ya4=.54c0600d-09cf-4fb1-973b-449a8660a47b@github.com>
Message-ID: <44FJk5ELzbsAwVrkTt47tgSpzQN1sgFpEEEYnGn4Rro=.4fa7b325-f2cc-46b1-b743-db8dd37d97ec@github.com>

On Fri, 20 Sep 2024 03:15:06 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few Focus tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   typo

test/jdk/java/awt/Focus/AltTabEventsTest.java line 61:

> 59:            2. Press Alt-tab.
> 60:            In the messqge dialog area you should see that
> 61:            WINDOW_DEACTIVATED,WINDOW_LOST_FOCUS event were generated.

Suggestion:

           WINDOW_DEACTIVATED, WINDOW_LOST_FOCUS event were generated.

test/jdk/java/awt/Focus/AltTabEventsTest.java line 80:

> 78:                 .rows((int) INSTRUCTIONS.lines().count() + 5)
> 79:                 .columns(35)
> 80:                 .testUI(AltTabEventsTest::createTestUI)

can be changed to `new Test();` and thus leading to remove the `createTestUI()` method.

test/jdk/java/awt/Focus/AltTabEventsTest.java line 104:

> 102:         WindowAdapter wa = new WindowAdapter() {
> 103:                 public void windowActivated(WindowEvent e) {
> 104:                     println(e.toString());

can be replaced with `PassFailJFrame.log` everywhere. Anyways there is a repetition of `println`.
Suggestion:

                    PassFailJFrame.log(e.toString());

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 54:

> 52: 
> 53:     public ComponentLostFocusTest() {
> 54:         try{

Suggestion:

        try {

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 56:

> 54:         try{
> 55:             r = new Robot();
> 56:         } catch(Exception e){

Suggestion:

        } catch (Exception e) {

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 69:

> 67:         });
> 68: 
> 69:         frame.setLayout (new FlowLayout ());

Suggestion:

        frame.setLayout (new FlowLayout());

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 79:

> 77:     public void doTest() {
> 78:         // Do requesting focus to the modal dialog in order to after that
> 79:         // to do requesting focus to the frame

Doesn't sound correct, can it be rephrased?

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 103:

> 101:         tf.addFocusListener(new FocusAdapter() {
> 102:             public void focusGained(FocusEvent e) {
> 103:                 System.out.println("TextField gained focus: "+e);

Suggestion:

                System.out.println("TextField gained focus: " + e);

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 111:

> 109: 
> 110:         System.out.println("Focused window: " + KeyboardFocusManager.getCurrentKeyboardFocusManager().getFocusedWindow());
> 111:         System.out.println("Focus owner: " + KeyboardFocusManager.getCurrentKeyboardFocusManager().getFocusOwner());

please limit it to 80 cols.

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 118:

> 116:     }
> 117: 
> 118:     private void doRequestFocusToTextField(){

Suggestion:

    private void doRequestFocusToTextField() {

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 121:

> 119:         // do activation using press title
> 120:         Point loc = frame.getLocationOnScreen();
> 121:         r.mouseMove(loc.x + frame.getWidth()/2, loc.y + frame.getInsets().top/2);

Suggestion:

        r.mouseMove(loc.x + frame.getWidth() / 2, loc.y + frame.getInsets().top / 2);

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 121:

> 119:         // do activation using press title
> 120:         Point loc = frame.getLocationOnScreen();
> 121:         r.mouseMove(loc.x + frame.getWidth()/2, loc.y + frame.getInsets().top/2);

Should it be accessed on EDT?

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 131:

> 129:     }
> 130: 
> 131:     public static final void main(String args[]){

Suggestion:

    public static final void main(String args[]) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767916449
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767916965
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767917411
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767919827
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767918226
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767918406
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767919134
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767919295
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767920580
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767920637
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767920840
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767921196
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767920918

From psadhukhan at openjdk.org  Fri Sep 20 04:19:35 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 04:19:35 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2
In-Reply-To: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
Message-ID: <b4xFwqxAwVNrmMmJ-yAteMVnNgZzjYdcD52JAxSq4rY=.194d7221-e4d3-4236-9e40-2ee7d6ffef02@github.com>

On Thu, 19 Sep 2024 17:59:26 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following tests are updated in this PR:
> 
> 1. 	test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java
> 2. 	test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java
> 3. 	test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java
> 4. 	test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21094#pullrequestreview-2317190922

From abhiscxk at openjdk.org  Fri Sep 20 04:21:50 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 20 Sep 2024 04:21:50 GMT
Subject: Integrated: 8339984: Open source AWT MenuItem related tests
In-Reply-To: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
References: <65-2xRE3aiuoK1Bi1CQR3abb-Km0mL-Gd03qNOd8eco=.0765fe63-3886-4e10-b07f-e1c249a8df87@github.com>
Message-ID: <setsp0U0mXGPqn_1CfJO59iMGiOY8i-JAjGMhoatxqw=.f0d453b6-d774-44bd-967f-f8c4bc5c35f7@github.com>

On Tue, 17 Sep 2024 04:31:09 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Few AWT MenuItem related tests are converted from applet to manual and moved to open.

This pull request has now been integrated.

Changeset: f4e40179
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f4e401791efb920b9773f2886b34904c95106727
Stats:     468 lines in 5 files changed: 468 ins; 0 del; 0 mod

8339984: Open source AWT MenuItem related tests

Reviewed-by: aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/21029

From honkar at openjdk.org  Fri Sep 20 05:07:34 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 20 Sep 2024 05:07:34 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2
In-Reply-To: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
Message-ID: <Hy5Smx4UMwjF-Nro6kTnZsDCduMyklZvtsCHErgmbHI=.bafa76f1-2f0d-4256-85b5-12b6d22093be@github.com>

On Thu, 19 Sep 2024 17:59:26 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following tests are updated in this PR:
> 
> 1. 	test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java
> 2. 	test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java
> 3. 	test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java
> 4. 	test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java

test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java line 42:

> 40: public class CheckboxBoxSizeTest {
> 41:     private static final String INSTRUCTIONS = """
> 42:             This test must be run at UI Scale of 100% OR 150% or greater.

@prsadhuk Tested at different UI Scales on windows and "the box" doesn't seem to scale properly and doesn't match windows native app (used Word -> Font settings to check). 
I think it is product bug. These tests weren't problemlisted so I may need to create a new JBS bug and problemlist this test and probably CheckboxIndicatorSizeTest on windows.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1767986862

From psadhukhan at openjdk.org  Fri Sep 20 05:13:03 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 05:13:03 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v5]
In-Reply-To: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
Message-ID: <9khMD1XZeuJHnMsYp2Xj1Yo5cI50RKQlFeGVQYdLeYk=.dcbcb46d-b89e-4aec-8c38-020c1083a073@github.com>

> Opensource few Focus tests

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Formatting, EDT addition

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21051/files
  - new: https://git.openjdk.org/jdk/pull/21051/files/c1a3daf6..4b6795d8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21051&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21051&range=03-04

  Stats: 68 lines in 2 files changed: 30 ins; 21 del; 17 mod
  Patch: https://git.openjdk.org/jdk/pull/21051.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21051/head:pull/21051

PR: https://git.openjdk.org/jdk/pull/21051

From psadhukhan at openjdk.org  Fri Sep 20 05:14:34 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 05:14:34 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2
In-Reply-To: <Hy5Smx4UMwjF-Nro6kTnZsDCduMyklZvtsCHErgmbHI=.bafa76f1-2f0d-4256-85b5-12b6d22093be@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
 <Hy5Smx4UMwjF-Nro6kTnZsDCduMyklZvtsCHErgmbHI=.bafa76f1-2f0d-4256-85b5-12b6d22093be@github.com>
Message-ID: <Z7ASo3Ql2zypHRCVvujbm7FBNtHBVnTLEwo0fwdR5JU=.21da8d15-d301-4c21-865d-994b465bd199@github.com>

On Fri, 20 Sep 2024 05:04:18 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are updated in this PR:
>> 
>> 1. 	test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java
>> 2. 	test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java
>> 3. 	test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java
>> 4. 	test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java
>
> test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java line 42:
> 
>> 40: public class CheckboxBoxSizeTest {
>> 41:     private static final String INSTRUCTIONS = """
>> 42:             This test must be run at UI Scale of 100% OR 150% or greater.
> 
> @prsadhuk Tested at different UI Scales on windows and "the box" doesn't seem to scale properly and doesn't match windows native app (used Word -> Font settings to check). 
> I think it is product bug. These tests weren't problemlisted so I may need to create a new JBS bug and problemlist this test and probably CheckboxIndicatorSizeTest on windows.

Looks to be similar to [JDK-8233068](https://bugs.openjdk.org/browse/JDK-8233068)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1767992127

From psadhukhan at openjdk.org  Fri Sep 20 05:17:38 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 05:17:38 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v4]
In-Reply-To: <44FJk5ELzbsAwVrkTt47tgSpzQN1sgFpEEEYnGn4Rro=.4fa7b325-f2cc-46b1-b743-db8dd37d97ec@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
 <3yNHmOgVkZcfJZpewia9X0v-JIK0aaSj3TxO36G4Ya4=.54c0600d-09cf-4fb1-973b-449a8660a47b@github.com>
 <44FJk5ELzbsAwVrkTt47tgSpzQN1sgFpEEEYnGn4Rro=.4fa7b325-f2cc-46b1-b743-db8dd37d97ec@github.com>
Message-ID: <99zQrHIY81ZRXt_9lN9cScUVujJcyhhfXEnMtR00URI=.11d7d3e4-d9d9-4f2f-baa6-cd9a288995d0@github.com>

On Fri, 20 Sep 2024 04:02:12 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   typo
>
> test/jdk/java/awt/Focus/AltTabEventsTest.java line 61:
> 
>> 59:            2. Press Alt-tab.
>> 60:            In the messqge dialog area you should see that
>> 61:            WINDOW_DEACTIVATED,WINDOW_LOST_FOCUS event were generated.
> 
> Suggestion:
> 
>            WINDOW_DEACTIVATED, WINDOW_LOST_FOCUS event were generated.

ok

> test/jdk/java/awt/Focus/AltTabEventsTest.java line 80:
> 
>> 78:                 .rows((int) INSTRUCTIONS.lines().count() + 5)
>> 79:                 .columns(35)
>> 80:                 .testUI(AltTabEventsTest::createTestUI)
> 
> can be changed to `new Test();` and thus leading to remove the `createTestUI()` method.

ok

> test/jdk/java/awt/Focus/AltTabEventsTest.java line 104:
> 
>> 102:         WindowAdapter wa = new WindowAdapter() {
>> 103:                 public void windowActivated(WindowEvent e) {
>> 104:                     println(e.toString());
> 
> can be replaced with `PassFailJFrame.log` everywhere. Anyways there is a repetition of `println`.
> Suggestion:
> 
>                     PassFailJFrame.log(e.toString());

it will be same..

> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 54:
> 
>> 52: 
>> 53:     public ComponentLostFocusTest() {
>> 54:         try{
> 
> Suggestion:
> 
>         try {

ok

> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 56:
> 
>> 54:         try{
>> 55:             r = new Robot();
>> 56:         } catch(Exception e){
> 
> Suggestion:
> 
>         } catch (Exception e) {

ok

> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 69:
> 
>> 67:         });
>> 68: 
>> 69:         frame.setLayout (new FlowLayout ());
> 
> Suggestion:
> 
>         frame.setLayout (new FlowLayout());

ok

> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 79:
> 
>> 77:     public void doTest() {
>> 78:         // Do requesting focus to the modal dialog in order to after that
>> 79:         // to do requesting focus to the frame
> 
> Doesn't sound correct, can it be rephrased?

removed

> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 103:
> 
>> 101:         tf.addFocusListener(new FocusAdapter() {
>> 102:             public void focusGained(FocusEvent e) {
>> 103:                 System.out.println("TextField gained focus: "+e);
> 
> Suggestion:
> 
>                 System.out.println("TextField gained focus: " + e);

ok

> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 111:
> 
>> 109: 
>> 110:         System.out.println("Focused window: " + KeyboardFocusManager.getCurrentKeyboardFocusManager().getFocusedWindow());
>> 111:         System.out.println("Focus owner: " + KeyboardFocusManager.getCurrentKeyboardFocusManager().getFocusOwner());
> 
> please limit it to 80 cols.

ok

> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 118:
> 
>> 116:     }
>> 117: 
>> 118:     private void doRequestFocusToTextField(){
> 
> Suggestion:
> 
>     private void doRequestFocusToTextField() {

ok

> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 121:
> 
>> 119:         // do activation using press title
>> 120:         Point loc = frame.getLocationOnScreen();
>> 121:         r.mouseMove(loc.x + frame.getWidth()/2, loc.y + frame.getInsets().top/2);
> 
> Suggestion:
> 
>         r.mouseMove(loc.x + frame.getWidth() / 2, loc.y + frame.getInsets().top / 2);

ok

> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 121:
> 
>> 119:         // do activation using press title
>> 120:         Point loc = frame.getLocationOnScreen();
>> 121:         r.mouseMove(loc.x + frame.getWidth()/2, loc.y + frame.getInsets().top/2);
> 
> Should it be accessed on EDT?

modified test to put relevant portion under EDT and also added dispose..

> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 131:
> 
>> 129:     }
>> 130: 
>> 131:     public static final void main(String args[]){
> 
> Suggestion:
> 
>     public static final void main(String args[]) {

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767992547
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767992609
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767992742
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767993053
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767992807
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767992856
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767992946
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767993001
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767993094
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767993136
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767993175
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767993524
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767993207

From abhiscxk at openjdk.org  Fri Sep 20 05:27:36 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 20 Sep 2024 05:27:36 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v4]
In-Reply-To: <99zQrHIY81ZRXt_9lN9cScUVujJcyhhfXEnMtR00URI=.11d7d3e4-d9d9-4f2f-baa6-cd9a288995d0@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
 <3yNHmOgVkZcfJZpewia9X0v-JIK0aaSj3TxO36G4Ya4=.54c0600d-09cf-4fb1-973b-449a8660a47b@github.com>
 <44FJk5ELzbsAwVrkTt47tgSpzQN1sgFpEEEYnGn4Rro=.4fa7b325-f2cc-46b1-b743-db8dd37d97ec@github.com>
 <99zQrHIY81ZRXt_9lN9cScUVujJcyhhfXEnMtR00URI=.11d7d3e4-d9d9-4f2f-baa6-cd9a288995d0@github.com>
Message-ID: <ioUeYTh4y4ssM1efRSLDktoYlaDWfgsYoHpZ9RxWRJM=.9ef6c866-db99-4c70-a968-2f2fd60c28bc@github.com>

On Fri, 20 Sep 2024 05:13:03 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/java/awt/Focus/AltTabEventsTest.java line 80:
>> 
>>> 78:                 .rows((int) INSTRUCTIONS.lines().count() + 5)
>>> 79:                 .columns(35)
>>> 80:                 .testUI(AltTabEventsTest::createTestUI)
>> 
>> can be changed to `new Test();` and thus leading to remove the `createTestUI()` method.
>
> ok

Looks like you missed this.

>> test/jdk/java/awt/Focus/AltTabEventsTest.java line 104:
>> 
>>> 102:         WindowAdapter wa = new WindowAdapter() {
>>> 103:                 public void windowActivated(WindowEvent e) {
>>> 104:                     println(e.toString());
>> 
>> can be replaced with `PassFailJFrame.log` everywhere. Anyways there is a repetition of `println`.
>> Suggestion:
>> 
>>                     PassFailJFrame.log(e.toString());
>
> it will be same..

`println` method can be removed if `PassFailJFrame.log` is used directly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767997395
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767998311

From abhiscxk at openjdk.org  Fri Sep 20 05:27:36 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 20 Sep 2024 05:27:36 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v4]
In-Reply-To: <ioUeYTh4y4ssM1efRSLDktoYlaDWfgsYoHpZ9RxWRJM=.9ef6c866-db99-4c70-a968-2f2fd60c28bc@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
 <3yNHmOgVkZcfJZpewia9X0v-JIK0aaSj3TxO36G4Ya4=.54c0600d-09cf-4fb1-973b-449a8660a47b@github.com>
 <44FJk5ELzbsAwVrkTt47tgSpzQN1sgFpEEEYnGn4Rro=.4fa7b325-f2cc-46b1-b743-db8dd37d97ec@github.com>
 <99zQrHIY81ZRXt_9lN9cScUVujJcyhhfXEnMtR00URI=.11d7d3e4-d9d9-4f2f-baa6-cd9a288995d0@github.com>
 <ioUeYTh4y4ssM1efRSLDktoYlaDWfgsYoHpZ9RxWRJM=.9ef6c866-db99-4c70-a968-2f2fd60c28bc@github.com>
Message-ID: <V1gGNlyfJhb0hvYvgmkSxk1_I7C6qiD-Ue6ZDkAb3ts=.3bc09c49-3d15-4509-99a8-7151ce9a86dc@github.com>

On Fri, 20 Sep 2024 05:20:54 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> ok
>
> Looks like you missed this.

Sorry, it was a mistake on my side. Don't know why but updated test was not shown. It is updated now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767999704

From honkar at openjdk.org  Fri Sep 20 05:29:35 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 20 Sep 2024 05:29:35 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2
In-Reply-To: <Z7ASo3Ql2zypHRCVvujbm7FBNtHBVnTLEwo0fwdR5JU=.21da8d15-d301-4c21-865d-994b465bd199@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
 <Hy5Smx4UMwjF-Nro6kTnZsDCduMyklZvtsCHErgmbHI=.bafa76f1-2f0d-4256-85b5-12b6d22093be@github.com>
 <Z7ASo3Ql2zypHRCVvujbm7FBNtHBVnTLEwo0fwdR5JU=.21da8d15-d301-4c21-865d-994b465bd199@github.com>
Message-ID: <ARzBHgjoRZnCtlJZF8rJfk9EGzdo32vHhkbTgSb2smk=.6ee978e2-00c7-46d3-89e1-3669bcdee42b@github.com>

On Fri, 20 Sep 2024 05:12:22 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java line 42:
>> 
>>> 40: public class CheckboxBoxSizeTest {
>>> 41:     private static final String INSTRUCTIONS = """
>>> 42:             This test must be run at UI Scale of 100% OR 150% or greater.
>> 
>> @prsadhuk Tested at different UI Scales on windows and "the box" doesn't seem to scale properly and doesn't match windows native app (used Word -> Font settings to check). 
>> I think it is product bug. These tests weren't problemlisted so I may need to create a new JBS bug and problemlist this test and probably CheckboxIndicatorSizeTest on windows.
>
> Looks to be similar to [JDK-8233068](https://bugs.openjdk.org/browse/JDK-8233068)

@prsadhuk Thanks for linking the issue. Yes it looks to be similar.
Unlike XCheckboxPeer.java, WCheckboxPeer.java does not have paintCheckbox(), it is probably done somewhere else for windows.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1768001190

From psadhukhan at openjdk.org  Fri Sep 20 05:35:35 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 05:35:35 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v4]
In-Reply-To: <ioUeYTh4y4ssM1efRSLDktoYlaDWfgsYoHpZ9RxWRJM=.9ef6c866-db99-4c70-a968-2f2fd60c28bc@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
 <3yNHmOgVkZcfJZpewia9X0v-JIK0aaSj3TxO36G4Ya4=.54c0600d-09cf-4fb1-973b-449a8660a47b@github.com>
 <44FJk5ELzbsAwVrkTt47tgSpzQN1sgFpEEEYnGn4Rro=.4fa7b325-f2cc-46b1-b743-db8dd37d97ec@github.com>
 <99zQrHIY81ZRXt_9lN9cScUVujJcyhhfXEnMtR00URI=.11d7d3e4-d9d9-4f2f-baa6-cd9a288995d0@github.com>
 <ioUeYTh4y4ssM1efRSLDktoYlaDWfgsYoHpZ9RxWRJM=.9ef6c866-db99-4c70-a968-2f2fd60c28bc@github.com>
Message-ID: <ciyOOHdrcSA9od4KqKJ4FXRRXtyw3clihPciloy14ZM=.1a47578d-470c-4c75-b4ee-c1054db3fae3@github.com>

On Fri, 20 Sep 2024 05:22:33 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> it will be same..
>
> `println` method can be removed if `PassFailJFrame.log` is used directly.

Then PassFailJFrame.log will be repeated, so it's same...dont think it's critical to change..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1768003727

From abhiscxk at openjdk.org  Fri Sep 20 05:35:35 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 20 Sep 2024 05:35:35 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v4]
In-Reply-To: <ciyOOHdrcSA9od4KqKJ4FXRRXtyw3clihPciloy14ZM=.1a47578d-470c-4c75-b4ee-c1054db3fae3@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
 <3yNHmOgVkZcfJZpewia9X0v-JIK0aaSj3TxO36G4Ya4=.54c0600d-09cf-4fb1-973b-449a8660a47b@github.com>
 <44FJk5ELzbsAwVrkTt47tgSpzQN1sgFpEEEYnGn4Rro=.4fa7b325-f2cc-46b1-b743-db8dd37d97ec@github.com>
 <99zQrHIY81ZRXt_9lN9cScUVujJcyhhfXEnMtR00URI=.11d7d3e4-d9d9-4f2f-baa6-cd9a288995d0@github.com>
 <ioUeYTh4y4ssM1efRSLDktoYlaDWfgsYoHpZ9RxWRJM=.9ef6c866-db99-4c70-a968-2f2fd60c28bc@github.com>
 <ciyOOHdrcSA9od4KqKJ4FXRRXtyw3clihPciloy14ZM=.1a47578d-470c-4c75-b4ee-c1054db3fae3@github.com>
Message-ID: <cbvS1aFkhOaW8QxqHB6vzUKi7Cdy8vtFMcXbH4kXvLE=.06ac07b9-4b2e-4e7d-b518-cc7c9bec4b0b@github.com>

On Fri, 20 Sep 2024 05:30:52 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> `println` method can be removed if `PassFailJFrame.log` is used directly.
>
> Then PassFailJFrame.log will be repeated, so it's same...dont think it's critical to change..

Yeah, not critical.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1768004981

From abhiscxk at openjdk.org  Fri Sep 20 05:35:37 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 20 Sep 2024 05:35:37 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v5]
In-Reply-To: <9khMD1XZeuJHnMsYp2Xj1Yo5cI50RKQlFeGVQYdLeYk=.dcbcb46d-b89e-4aec-8c38-020c1083a073@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
 <9khMD1XZeuJHnMsYp2Xj1Yo5cI50RKQlFeGVQYdLeYk=.dcbcb46d-b89e-4aec-8c38-020c1083a073@github.com>
Message-ID: <9js-98w3ESNvmE26nWCArUf4SQQt1M-IHgtrHwpSQ94=.ab02640b-88fa-4996-90fb-6f31aa2129cc@github.com>

On Fri, 20 Sep 2024 05:13:03 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few Focus tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Formatting, EDT addition

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 53:

> 51:     static Dialog dialog = null;
> 52:     static volatile boolean passed;
> 53:     static Point loc;

Should it be volatile also?

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 107:

> 105:     private static void doRequestFocusToTextField() {
> 106:         // do activation using press title
> 107:         r.mouseMove(loc.x + frame.getWidth() / 2, loc.y + frame.getInsets().top / 2);

`frame.getWidth` also should be on EDT ?

test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 121:

> 119:         r.setAutoDelay(100);
> 120: 
> 121:         ComponentLostFocusTest test;

Unused variable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1768003653
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1768002428
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1768003421

From psadhukhan at openjdk.org  Fri Sep 20 05:41:18 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 05:41:18 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v6]
In-Reply-To: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
Message-ID: <t4IDMIeys7UvNMCYl9IAI3vdfASBNRHm24Nsee4Zc54=.06fa40cf-c20e-4ced-a8c1-7ce17b77199c@github.com>

> Opensource few Focus tests

Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:

 - volatile
 - EDT

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21051/files
  - new: https://git.openjdk.org/jdk/pull/21051/files/4b6795d8..2dcd760b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21051&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21051&range=04-05

  Stats: 7 lines in 1 file changed: 4 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21051.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21051/head:pull/21051

PR: https://git.openjdk.org/jdk/pull/21051

From psadhukhan at openjdk.org  Fri Sep 20 05:41:19 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 05:41:19 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v5]
In-Reply-To: <9js-98w3ESNvmE26nWCArUf4SQQt1M-IHgtrHwpSQ94=.ab02640b-88fa-4996-90fb-6f31aa2129cc@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
 <9khMD1XZeuJHnMsYp2Xj1Yo5cI50RKQlFeGVQYdLeYk=.dcbcb46d-b89e-4aec-8c38-020c1083a073@github.com>
 <9js-98w3ESNvmE26nWCArUf4SQQt1M-IHgtrHwpSQ94=.ab02640b-88fa-4996-90fb-6f31aa2129cc@github.com>
Message-ID: <aK3EHRlnVGXTXEX9cBOYQDe3HG_EcIXLDoAOlGRTVr4=.0d4d94b2-1f70-44ea-b6d9-753a191b0e14@github.com>

On Fri, 20 Sep 2024 05:30:45 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Formatting, EDT addition
>
> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 53:
> 
>> 51:     static Dialog dialog = null;
>> 52:     static volatile boolean passed;
>> 53:     static Point loc;
> 
> Should it be volatile also?

ok

> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 107:
> 
>> 105:     private static void doRequestFocusToTextField() {
>> 106:         // do activation using press title
>> 107:         r.mouseMove(loc.x + frame.getWidth() / 2, loc.y + frame.getInsets().top / 2);
> 
> `frame.getWidth` also should be on EDT ?

ok

> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 121:
> 
>> 119:         r.setAutoDelay(100);
>> 120: 
>> 121:         ComponentLostFocusTest test;
> 
> Unused variable.

removed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1768008256
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1768007088
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1768007142

From abhiscxk at openjdk.org  Fri Sep 20 05:50:34 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 20 Sep 2024 05:50:34 GMT
Subject: RFR: 8339906: Open source several AWT focus tests - series 4 [v6]
In-Reply-To: <t4IDMIeys7UvNMCYl9IAI3vdfASBNRHm24Nsee4Zc54=.06fa40cf-c20e-4ced-a8c1-7ce17b77199c@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
 <t4IDMIeys7UvNMCYl9IAI3vdfASBNRHm24Nsee4Zc54=.06fa40cf-c20e-4ced-a8c1-7ce17b77199c@github.com>
Message-ID: <G1KFQKuEFIc-kUFpB_R0N3Wd0SdS3_jpNes7usXeqz4=.9a43a293-91ea-4656-9406-4e7f071d6976@github.com>

On Fri, 20 Sep 2024 05:41:18 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few Focus tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - volatile
>  - EDT

Hope you have run the automated test in CI.

-------------

Marked as reviewed by abhiscxk (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21051#pullrequestreview-2317316384

From psadhukhan at openjdk.org  Fri Sep 20 06:10:41 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 06:10:41 GMT
Subject: Integrated: 8339906: Open source several AWT focus tests - series 4
In-Reply-To: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
References: <RPVlyQaACUytxuQtntX5-465BhBOfoF6zIIDeSHt2Z8=.2fe2cad9-1489-4435-ad44-3f4d13e8b748@github.com>
Message-ID: <lOLCEvm0z57T6d-i4dshqkDcJLi1Uw9iDWmeAuHe2Wk=.d597c80f-1c02-4661-83e6-06c24a39157e@github.com>

On Wed, 18 Sep 2024 03:51:08 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few Focus tests

This pull request has now been integrated.

Changeset: 46b02f49
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/46b02f49bcc730d94e37cf17fa996fdd12bdb990
Stats:     526 lines in 4 files changed: 526 ins; 0 del; 0 mod

8339906: Open source several AWT focus tests - series 4

Reviewed-by: abhiscxk, prr

-------------

PR: https://git.openjdk.org/jdk/pull/21051

From psadhukhan at openjdk.org  Fri Sep 20 07:47:36 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 07:47:36 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests [v2]
In-Reply-To: <3F2xejJLH59rCU6yMgISA16Dff7fWPgx5BgZu-eZzHw=.e84e44f1-28e3-4dcc-9bdb-d917899ee3dc@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
 <3F2xejJLH59rCU6yMgISA16Dff7fWPgx5BgZu-eZzHw=.e84e44f1-28e3-4dcc-9bdb-d917899ee3dc@github.com>
Message-ID: <hdCAgdf0zklM2Xib1-2BstZ578Xte9E1CqCSHyphm54=.2febcc42-159b-4c74-b432-7490eaa04028@github.com>

On Thu, 19 Sep 2024 05:21:02 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT Frame related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment fix

test/jdk/java/awt/Frame/DefaultLocationTest.java line 59:

> 57:             EventQueue.invokeAndWait(() -> {
> 58:                 if (f != null) {
> 59:                     f.dispose();

We add "f" to PassFailJFrame through `addTestWIndow` so I would assume `awaitAndCheck` should dispose off the frame when we press Pass/Fail, no need to do it explicitly..

test/jdk/java/awt/Frame/FrameLayoutTest.java line 33:

> 31:  * @library /java/awt/regtesthelpers
> 32:  * @requires (os.family == "windows")
> 33:  * @build PassFailJFrame

guess @library @build placement should be together, although not mandatory I presume..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1768063691
PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1768140237

From abhiscxk at openjdk.org  Fri Sep 20 08:04:30 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 20 Sep 2024 08:04:30 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests [v3]
In-Reply-To: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
Message-ID: <3iLEo71PiOQcWkrWO7yQwGAeimfJAZ3mIVJ5eXTGpFA=.ff572634-949c-49b3-a16f-83f1959f6565@github.com>

> Few AWT Frame related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Review comment update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21052/files
  - new: https://git.openjdk.org/jdk/pull/21052/files/c5de5524..523e410c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21052&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21052&range=01-02

  Stats: 10 lines in 1 file changed: 0 ins; 8 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21052.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21052/head:pull/21052

PR: https://git.openjdk.org/jdk/pull/21052

From abhiscxk at openjdk.org  Fri Sep 20 08:04:33 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 20 Sep 2024 08:04:33 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests [v2]
In-Reply-To: <hdCAgdf0zklM2Xib1-2BstZ578Xte9E1CqCSHyphm54=.2febcc42-159b-4c74-b432-7490eaa04028@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
 <3F2xejJLH59rCU6yMgISA16Dff7fWPgx5BgZu-eZzHw=.e84e44f1-28e3-4dcc-9bdb-d917899ee3dc@github.com>
 <hdCAgdf0zklM2Xib1-2BstZ578Xte9E1CqCSHyphm54=.2febcc42-159b-4c74-b432-7490eaa04028@github.com>
Message-ID: <Z4RZ56qkvDL2TwJfd4puSkFbPA-uz_BSbFnw2yJAjyo=.a32de964-5ae3-4d81-8d8c-74dd6622ffd5@github.com>

On Fri, 20 Sep 2024 06:36:24 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment fix
>
> test/jdk/java/awt/Frame/DefaultLocationTest.java line 59:
> 
>> 57:             EventQueue.invokeAndWait(() -> {
>> 58:                 if (f != null) {
>> 59:                     f.dispose();
> 
> We add "f" to PassFailJFrame through `addTestWIndow` so I would assume `awaitAndCheck` should dispose off the frame when we press Pass/Fail, no need to do it explicitly..

Ok.. updated.

> test/jdk/java/awt/Frame/FrameLayoutTest.java line 33:
> 
>> 31:  * @library /java/awt/regtesthelpers
>> 32:  * @requires (os.family == "windows")
>> 33:  * @build PassFailJFrame
> 
> guess @library @build placement should be together, although not mandatory I presume..

Keeping it as it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1768167394
PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1768167699

From psadhukhan at openjdk.org  Fri Sep 20 08:47:36 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 08:47:36 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests [v3]
In-Reply-To: <3iLEo71PiOQcWkrWO7yQwGAeimfJAZ3mIVJ5eXTGpFA=.ff572634-949c-49b3-a16f-83f1959f6565@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
 <3iLEo71PiOQcWkrWO7yQwGAeimfJAZ3mIVJ5eXTGpFA=.ff572634-949c-49b3-a16f-83f1959f6565@github.com>
Message-ID: <3jqAwnN7GJt0IDuI1_iS10L1PQhZIkmzU54GGB4Kg-E=.37b4f22c-f1a1-4650-a9b6-a5d054c56e84@github.com>

On Fri, 20 Sep 2024 08:04:30 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT Frame related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21052#pullrequestreview-2317653132

From psadhukhan at openjdk.org  Fri Sep 20 09:03:38 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 09:03:38 GMT
Subject: RFR: 8340393: Open source closed choice tests #2
In-Reply-To: <nPZJzcL0dCCai5InSUz1W8kwsALcAHdRbirw1X76gjk=.808e59af-027a-4666-8e6d-c519bf4db53e@github.com>
References: <nPZJzcL0dCCai5InSUz1W8kwsALcAHdRbirw1X76gjk=.808e59af-027a-4666-8e6d-c519bf4db53e@github.com>
Message-ID: <6Ce-Nxs0__xuTHYjWSvXCPa3h-1J3X8624OyUsBcVv0=.46051e38-0445-4f9c-9f34-7d31e2268907@github.com>

On Thu, 19 Sep 2024 06:39:40 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> few manual tests to open source
> Tested on all platforms, all looks good.

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/java/awt/Choice/CheckChoiceTest.java line 29:

> 27: import java.awt.BorderLayout;
> 28: import java.awt.Choice;
> 29: import java.awt.Frame;

I guess it was decided that java.awt will come before javax.swing...

test/jdk/java/awt/Choice/DisabledList.java line 43:

> 41: 
> 42:     private static final String INSTRUCTIONS = """
> 43:             1) Switch checkbox

Shouldn't it be "Enable checkbox"?

-------------

PR Review: https://git.openjdk.org/jdk/pull/21081#pullrequestreview-2317656604
PR Review Comment: https://git.openjdk.org/jdk/pull/21081#discussion_r1768231187
PR Review Comment: https://git.openjdk.org/jdk/pull/21081#discussion_r1768250456

From azvegint at openjdk.org  Fri Sep 20 09:18:20 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 20 Sep 2024 09:18:20 GMT
Subject: RFR: 8340393: Open source closed choice tests #2 [v2]
In-Reply-To: <6Ce-Nxs0__xuTHYjWSvXCPa3h-1J3X8624OyUsBcVv0=.46051e38-0445-4f9c-9f34-7d31e2268907@github.com>
References: <nPZJzcL0dCCai5InSUz1W8kwsALcAHdRbirw1X76gjk=.808e59af-027a-4666-8e6d-c519bf4db53e@github.com>
 <6Ce-Nxs0__xuTHYjWSvXCPa3h-1J3X8624OyUsBcVv0=.46051e38-0445-4f9c-9f34-7d31e2268907@github.com>
Message-ID: <Yf3ygYszuvyRNLqdkg5_xfdOddD807HrQtGhJnAladM=.fbdcd446-62e6-4c99-aa76-47977c26e973@github.com>

On Fri, 20 Sep 2024 08:46:32 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8340433: Open source closed choice tests #3
>
> test/jdk/java/awt/Choice/CheckChoiceTest.java line 29:
> 
>> 27: import java.awt.BorderLayout;
>> 28: import java.awt.Choice;
>> 29: import java.awt.Frame;
> 
> I guess it was decided that java.awt will come before javax.swing...

updated.

> test/jdk/java/awt/Choice/DisabledList.java line 43:
> 
>> 41: 
>> 42:     private static final String INSTRUCTIONS = """
>> 43:             1) Switch checkbox
> 
> Shouldn't it be "Enable checkbox"?

I would read the "Enable checkbox" as somehow related to `setEnabled`, but the component is already enabled.
So I'll keep it as it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21081#discussion_r1768266361
PR Review Comment: https://git.openjdk.org/jdk/pull/21081#discussion_r1768266326

From azvegint at openjdk.org  Fri Sep 20 09:18:20 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 20 Sep 2024 09:18:20 GMT
Subject: RFR: 8340393: Open source closed choice tests #2 [v2]
In-Reply-To: <nPZJzcL0dCCai5InSUz1W8kwsALcAHdRbirw1X76gjk=.808e59af-027a-4666-8e6d-c519bf4db53e@github.com>
References: <nPZJzcL0dCCai5InSUz1W8kwsALcAHdRbirw1X76gjk=.808e59af-027a-4666-8e6d-c519bf4db53e@github.com>
Message-ID: <p_ZWtbwTyCU92u1nyfQnnawO7OzyTALTHxJwM4KVD3U=.6cbf3804-ab07-4c86-80e7-63911c3a67c7@github.com>

> few manual tests to open source
> Tested on all platforms, all looks good.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  8340433: Open source closed choice tests #3

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21081/files
  - new: https://git.openjdk.org/jdk/pull/21081/files/fecc2f8c..29851a72

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21081&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21081&range=00-01

  Stats: 6 lines in 1 file changed: 3 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21081.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21081/head:pull/21081

PR: https://git.openjdk.org/jdk/pull/21081

From psadhukhan at openjdk.org  Fri Sep 20 09:21:38 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 09:21:38 GMT
Subject: RFR: 8340393: Open source closed choice tests #2 [v2]
In-Reply-To: <Yf3ygYszuvyRNLqdkg5_xfdOddD807HrQtGhJnAladM=.fbdcd446-62e6-4c99-aa76-47977c26e973@github.com>
References: <nPZJzcL0dCCai5InSUz1W8kwsALcAHdRbirw1X76gjk=.808e59af-027a-4666-8e6d-c519bf4db53e@github.com>
 <6Ce-Nxs0__xuTHYjWSvXCPa3h-1J3X8624OyUsBcVv0=.46051e38-0445-4f9c-9f34-7d31e2268907@github.com>
 <Yf3ygYszuvyRNLqdkg5_xfdOddD807HrQtGhJnAladM=.fbdcd446-62e6-4c99-aa76-47977c26e973@github.com>
Message-ID: <c43OuTEe4M5zO1t3siJLROl-EwehsOz7sBTvUiQlcoo=.c0585d11-0654-4904-b002-a10adfe61382@github.com>

On Fri, 20 Sep 2024 09:13:29 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> test/jdk/java/awt/Choice/DisabledList.java line 43:
>> 
>>> 41: 
>>> 42:     private static final String INSTRUCTIONS = """
>>> 43:             1) Switch checkbox
>> 
>> Shouldn't it be "Enable checkbox"?
>
> I would read the "Enable checkbox" as somehow related to `setEnabled`, but the component is already enabled.
> So I'll keep it as it is.

As per Checkbox spec
"A check box is a graphical component that can be in either an "on" (true) or "off" (false) state"
so I guess "Switch on checkbox" would be more apt.. To me atleast, "switch checkbox" doesn't sound perfect...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21081#discussion_r1768273607

From azvegint at openjdk.org  Fri Sep 20 09:35:31 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 20 Sep 2024 09:35:31 GMT
Subject: RFR: 8340393: Open source closed choice tests #2 [v3]
In-Reply-To: <nPZJzcL0dCCai5InSUz1W8kwsALcAHdRbirw1X76gjk=.808e59af-027a-4666-8e6d-c519bf4db53e@github.com>
References: <nPZJzcL0dCCai5InSUz1W8kwsALcAHdRbirw1X76gjk=.808e59af-027a-4666-8e6d-c519bf4db53e@github.com>
Message-ID: <BSl2nl0attbO4LmSbfvDoAMvFBGb--43ncQv-gsTGoM=.ec39e931-0811-4107-96b8-cd7d1f963938@github.com>

> few manual tests to open source
> Tested on all platforms, all looks good.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  instructions update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21081/files
  - new: https://git.openjdk.org/jdk/pull/21081/files/29851a72..964075ea

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21081&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21081&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21081.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21081/head:pull/21081

PR: https://git.openjdk.org/jdk/pull/21081

From azvegint at openjdk.org  Fri Sep 20 09:35:32 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 20 Sep 2024 09:35:32 GMT
Subject: RFR: 8340393: Open source closed choice tests #2 [v3]
In-Reply-To: <c43OuTEe4M5zO1t3siJLROl-EwehsOz7sBTvUiQlcoo=.c0585d11-0654-4904-b002-a10adfe61382@github.com>
References: <nPZJzcL0dCCai5InSUz1W8kwsALcAHdRbirw1X76gjk=.808e59af-027a-4666-8e6d-c519bf4db53e@github.com>
 <6Ce-Nxs0__xuTHYjWSvXCPa3h-1J3X8624OyUsBcVv0=.46051e38-0445-4f9c-9f34-7d31e2268907@github.com>
 <Yf3ygYszuvyRNLqdkg5_xfdOddD807HrQtGhJnAladM=.fbdcd446-62e6-4c99-aa76-47977c26e973@github.com>
 <c43OuTEe4M5zO1t3siJLROl-EwehsOz7sBTvUiQlcoo=.c0585d11-0654-4904-b002-a10adfe61382@github.com>
Message-ID: <_7j2TAirDLXpnKkjHbcoRdgr-AERTKwRTDDqhs5eDbg=.607443c0-f534-4bfc-b4b9-3b474caf4b8d@github.com>

On Fri, 20 Sep 2024 09:18:42 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> I would read the "Enable checkbox" as somehow related to `setEnabled`, but the component is already enabled.
>> So I'll keep it as it is.
>
> As per Checkbox spec
> "A check box is a graphical component that can be in either an "on" (true) or "off" (false) state"
> so I guess "Switch on checkbox" would be more apt.. To me atleast, "switch checkbox" doesn't sound perfect...

It is off by default in this test, so "switch" will set it to the desired selected state. So it should be OK.
Anyway, updated to the "Select the checkbox"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21081#discussion_r1768291260

From aivanov at openjdk.org  Fri Sep 20 09:50:36 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 20 Sep 2024 09:50:36 GMT
Subject: RFR: 8339972: Make a few fields in SortingFocusTraversalPolicy
 static
In-Reply-To: <HP1wTLCSf2CmDsPY7n5glKw0FLG11yV-WFAps78qFBs=.bf09f28c-4110-4279-b844-703ccd9bcb27@github.com>
References: <HP1wTLCSf2CmDsPY7n5glKw0FLG11yV-WFAps78qFBs=.bf09f28c-4110-4279-b844-703ccd9bcb27@github.com>
Message-ID: <LZl9zZ6TIqpHOH6vzmadlERBRy1YL1OrFMRkV9iZyoc=.216808a4-d822-4955-916f-56b859014491@github.com>

On Thu, 25 Jul 2024 11:17:23 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> 2 fields in javax.swing.SortingFocusTraversalPolicy could be made 'static':
> 1. FORWARD_TRAVERSAL = 0
> 2. BACKWARD_TRAVERSAL = 1

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20327#pullrequestreview-2317790478

From psadhukhan at openjdk.org  Fri Sep 20 09:50:36 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 20 Sep 2024 09:50:36 GMT
Subject: RFR: 8340393: Open source closed choice tests #2 [v3]
In-Reply-To: <BSl2nl0attbO4LmSbfvDoAMvFBGb--43ncQv-gsTGoM=.ec39e931-0811-4107-96b8-cd7d1f963938@github.com>
References: <nPZJzcL0dCCai5InSUz1W8kwsALcAHdRbirw1X76gjk=.808e59af-027a-4666-8e6d-c519bf4db53e@github.com>
 <BSl2nl0attbO4LmSbfvDoAMvFBGb--43ncQv-gsTGoM=.ec39e931-0811-4107-96b8-cd7d1f963938@github.com>
Message-ID: <7rYt4COxxiogUL6DQNhmtahmIokeRpxhk7bcGfxjuZA=.9e0a2199-c367-438e-8ce8-ed204d1558fe@github.com>

On Fri, 20 Sep 2024 09:35:31 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> few manual tests to open source
>> Tested on all platforms, all looks good.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instructions update

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21081#pullrequestreview-2317791410

From azvegint at openjdk.org  Fri Sep 20 09:58:13 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 20 Sep 2024 09:58:13 GMT
Subject: RFR: 8340433: Open source closed choice tests #3
Message-ID: <bkuFu9a7K35iiT58GCiPFGwsQwQDXBiqZ8gwNz85rhk=.ddda876b-9987-4d54-bc4f-b1710b04df2d@github.com>

few more tests to open source

Testing is good.

-------------

Commit messages:
 - 8340433: Open source closed choice tests #3

Changes: https://git.openjdk.org/jdk/pull/21107/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21107&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340433
  Stats: 341 lines in 3 files changed: 341 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21107.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21107/head:pull/21107

PR: https://git.openjdk.org/jdk/pull/21107

From aivanov at openjdk.org  Fri Sep 20 10:02:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 20 Sep 2024 10:02:38 GMT
Subject: RFR: 8339524: Clean up ExtendedRobot tests
In-Reply-To: <HC64NDQIWs3GWaJI1BscY7iAsc6uZabf1QytcbWHqdU=.f353752e-03ca-4a8f-986b-3690d3a1da52@github.com>
References: <HC64NDQIWs3GWaJI1BscY7iAsc6uZabf1QytcbWHqdU=.f353752e-03ca-4a8f-986b-3690d3a1da52@github.com>
Message-ID: <8UBfUqA1QpTm7I9A-l0zarbWIU1TWEcex9os8w4gBko=.cbf24cac-4fed-4c6b-8773-836131bc3cd1@github.com>

On Wed, 4 Sep 2024 03:34:34 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Cleaning up tests building ExtendedRobot that shouldn't be.

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java line 1:

> 1: /*

`frame` should be disposed of on EDT.

`TestTitlePane` can be static.

test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java line 44:

> 42:     private TestTitlePane testTitlePane;
> 43:     private boolean passed;
> 44:     private static Robot robot = createRobot();

Suggestion:

    private static final Robot robot = createRobot();

test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java line 153:

> 151:              Robot robot = new Robot();
> 152:              return robot;
> 153:          }catch(Exception ex) {

Suggestion:

         } catch(Exception ex) {

And pass the caught exception as the `cause` parameter to `Error` ? `ex.printStackTrace()` becomes redundant.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20846#pullrequestreview-2317810835
PR Review Comment: https://git.openjdk.org/jdk/pull/20846#discussion_r1768331370
PR Review Comment: https://git.openjdk.org/jdk/pull/20846#discussion_r1768329617
PR Review Comment: https://git.openjdk.org/jdk/pull/20846#discussion_r1768328968

From aivanov at openjdk.org  Fri Sep 20 10:05:35 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 20 Sep 2024 10:05:35 GMT
Subject: RFR: 8339524: Clean up ExtendedRobot tests
In-Reply-To: <HC64NDQIWs3GWaJI1BscY7iAsc6uZabf1QytcbWHqdU=.f353752e-03ca-4a8f-986b-3690d3a1da52@github.com>
References: <HC64NDQIWs3GWaJI1BscY7iAsc6uZabf1QytcbWHqdU=.f353752e-03ca-4a8f-986b-3690d3a1da52@github.com>
Message-ID: <jsPzjOJcLasjLf7h-hMAsjC0ypmaYprMvwQy-Fy0bww=.b8ab542a-4117-48a3-aa56-252f41decf98@github.com>

On Wed, 4 Sep 2024 03:34:34 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Cleaning up tests building ExtendedRobot that shouldn't be.

The title suggest a larger amount of clean-up. ?Clean up _a few_ tests? could be better. (Git recommends the use of imperative mood in titles: ?Clean up? instead of ?Cleaning up?, and it's shorter.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20846#issuecomment-2363346284

From aivanov at openjdk.org  Fri Sep 20 10:09:44 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 20 Sep 2024 10:09:44 GMT
Subject: Integrated: 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15
 seconds timeout
In-Reply-To: <kWrLjRneFM-LNQZwh6i-Vdq75dDYQP3rPbqXilfjzLk=.95139835-fe2b-493c-8cec-6b5dd4e60c25@github.com>
References: <kWrLjRneFM-LNQZwh6i-Vdq75dDYQP3rPbqXilfjzLk=.95139835-fe2b-493c-8cec-6b5dd4e60c25@github.com>
Message-ID: <wKSnvMc1TbrYhkU4PPrhKPJGlrVRBN0jAwonZKQ2qk4=.52cf2121-7799-47df-912f-c73c216f6d74@github.com>

On Thu, 19 Sep 2024 09:40:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I am open-sourcing the `Numpad1KeyTyped.java` test.
> 
> I used `CountDownLatch` for synchronisation.
> 
> The test passes in CI.

This pull request has now been integrated.

Changeset: 3c22d83c
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3c22d83c0fb9eee2e2b87e607680b96363849c16
Stats:     178 lines in 1 file changed: 178 ins; 0 del; 0 mod

8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout

Reviewed-by: azvegint, prr

-------------

PR: https://git.openjdk.org/jdk/pull/21085

From aturbanov at openjdk.org  Fri Sep 20 12:46:45 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Fri, 20 Sep 2024 12:46:45 GMT
Subject: Integrated: 8339972: Make a few fields in SortingFocusTraversalPolicy
 static
In-Reply-To: <HP1wTLCSf2CmDsPY7n5glKw0FLG11yV-WFAps78qFBs=.bf09f28c-4110-4279-b844-703ccd9bcb27@github.com>
References: <HP1wTLCSf2CmDsPY7n5glKw0FLG11yV-WFAps78qFBs=.bf09f28c-4110-4279-b844-703ccd9bcb27@github.com>
Message-ID: <gZgOQwd5n5QS207oEMwPMqenBSFP8MlYPhjMV_XQS9w=.d17e8ce6-aae9-4a41-848e-aa77d93b3cf9@github.com>

On Thu, 25 Jul 2024 11:17:23 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> 2 fields in javax.swing.SortingFocusTraversalPolicy could be made 'static':
> 1. FORWARD_TRAVERSAL = 0
> 2. BACKWARD_TRAVERSAL = 1

This pull request has now been integrated.

Changeset: fe80618b
Author:    Andrey Turbanov <aturbanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/fe80618bf3f80094a93239dd43d4a9b515c5fa18
Stats:     3 lines in 1 file changed: 0 ins; 0 del; 3 mod

8339972: Make a few fields in SortingFocusTraversalPolicy static

Reviewed-by: azvegint, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/20327

From prr at openjdk.org  Fri Sep 20 17:13:15 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 20 Sep 2024 17:13:15 GMT
Subject: RFR: 8340411: open source several 2D imaging tests
Message-ID: <PG3yJ3autwvRlyLp8YMrl4mxPNtByugQdydq9aLdnJU=.e8f9e35c-5542-410b-a9ae-4ea5ecbc8cc5@github.com>

open source several 2d imaging related tests.

-------------

Commit messages:
 - 8340411

Changes: https://git.openjdk.org/jdk/pull/21113/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21113&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340411
  Stats: 485 lines in 4 files changed: 485 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21113.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21113/head:pull/21113

PR: https://git.openjdk.org/jdk/pull/21113

From aivanov at openjdk.org  Fri Sep 20 17:51:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 20 Sep 2024 17:51:39 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v10]
In-Reply-To: <etTuI5B_VPcWRsSh4LOz3y3n4g8-_AYqJdaYKwox240=.f195361d-2ef5-44f2-a9d8-a9590579a343@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <etTuI5B_VPcWRsSh4LOz3y3n4g8-_AYqJdaYKwox240=.f195361d-2ef5-44f2-a9d8-a9590579a343@github.com>
Message-ID: <RB06iE4u9SFWj6HMU8dXPomzEyuW7aolqQefiwEgTdY=.aa2ab481-960b-4b02-bce5-3e78b918abfa@github.com>

On Wed, 18 Sep 2024 15:34:02 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:

>> This testcase checks for the following assertions for Component events:
>> 
>> 1. When components are resized, moved, hidden and shown the respective events are triggered.
>> 2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
>> 3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
>> 4. When a window is minimized/restored then hidden and shown component events should be triggered.
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.
>
> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8333403: Review Comments Fixed

Looks good to me except for minor nits.

test/jdk/java/awt/Component/ComponentEventTest.java line 44:

> 42: import java.awt.event.InputEvent;
> 43: import java.lang.reflect.InvocationTargetException;
> 44: import jdk.test.lib.Platform;

Suggestion:

import java.lang.reflect.InvocationTargetException;

import jdk.test.lib.Platform;


You should put a blank line to separate standard library imports from custom (internal) classes.

test/jdk/java/awt/Component/ComponentEventTest.java line 167:

> 165:         System.out.println("Iconify frame");
> 166:         resetValues();
> 167:         iconifyFrame();

`testIconifyFrame`?

test/jdk/java/awt/Component/ComponentEventTest.java line 171:

> 169:         System.out.println("Deiconify frame");
> 170:         resetValues();
> 171:         deiconifyFrame();

`testDeiconifyFrame`?

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19521#pullrequestreview-2318886438
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1768976680
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1768980677
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1768980977

From honkar at openjdk.org  Fri Sep 20 18:13:39 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 20 Sep 2024 18:13:39 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests [v3]
In-Reply-To: <3iLEo71PiOQcWkrWO7yQwGAeimfJAZ3mIVJ5eXTGpFA=.ff572634-949c-49b3-a16f-83f1959f6565@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
 <3iLEo71PiOQcWkrWO7yQwGAeimfJAZ3mIVJ5eXTGpFA=.ff572634-949c-49b3-a16f-83f1959f6565@github.com>
Message-ID: <73NHZZqbNYlFP6rReDvvbYS9c5zpWpo45sApYC9ZMio=.f164947a-863b-4b59-808c-cda1eb2ff49a@github.com>

On Fri, 20 Sep 2024 08:04:30 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT Frame related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Updated changes LGTM

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21052#pullrequestreview-2318962652

From honkar at openjdk.org  Fri Sep 20 19:16:37 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 20 Sep 2024 19:16:37 GMT
Subject: RFR: 8340433: Open source closed choice tests #3
In-Reply-To: <bkuFu9a7K35iiT58GCiPFGwsQwQDXBiqZ8gwNz85rhk=.ddda876b-9987-4d54-bc4f-b1710b04df2d@github.com>
References: <bkuFu9a7K35iiT58GCiPFGwsQwQDXBiqZ8gwNz85rhk=.ddda876b-9987-4d54-bc4f-b1710b04df2d@github.com>
Message-ID: <_0MhCk10bAxTeKlDCmn0_zNhxSdheonZtYUEiOlNVB4=.6680aa81-854a-4d22-a2d2-07b8eb3e959f@github.com>

On Fri, 20 Sep 2024 09:53:00 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> few more tests to open source
> 
> Testing is good.

test/jdk/java/awt/Choice/ChoicePosTest.java line 94:

> 92:     private static void captureAndTestChoices() {
> 93:         Point c1loc = c1.getLocationOnScreen();
> 94:         Point c2loc = c2.getLocationOnScreen();

Does this require EDT?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21107#discussion_r1769092861

From azvegint at openjdk.org  Fri Sep 20 19:31:33 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 20 Sep 2024 19:31:33 GMT
Subject: RFR: 8340411: open source several 2D imaging tests
In-Reply-To: <PG3yJ3autwvRlyLp8YMrl4mxPNtByugQdydq9aLdnJU=.e8f9e35c-5542-410b-a9ae-4ea5ecbc8cc5@github.com>
References: <PG3yJ3autwvRlyLp8YMrl4mxPNtByugQdydq9aLdnJU=.e8f9e35c-5542-410b-a9ae-4ea5ecbc8cc5@github.com>
Message-ID: <gnRTIeWHLIFjNBkzcDokGLySJnessDuHFLHljs-Y354=.4a47737c-f7a6-471c-ba91-5c5cc5ddd363@github.com>

On Fri, 20 Sep 2024 17:07:31 GMT, Phil Race <prr at openjdk.org> wrote:

> open source several 2d imaging related tests.

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21113#pullrequestreview-2319167876

From honkar at openjdk.org  Fri Sep 20 19:36:36 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 20 Sep 2024 19:36:36 GMT
Subject: RFR: 8340433: Open source closed choice tests #3
In-Reply-To: <bkuFu9a7K35iiT58GCiPFGwsQwQDXBiqZ8gwNz85rhk=.ddda876b-9987-4d54-bc4f-b1710b04df2d@github.com>
References: <bkuFu9a7K35iiT58GCiPFGwsQwQDXBiqZ8gwNz85rhk=.ddda876b-9987-4d54-bc4f-b1710b04df2d@github.com>
Message-ID: <UtITJ3j-D1G1il6pvIF14w4b--1iNsYbnDFN1pBKYAM=.5a470977-f6a2-46ef-a2f5-769eb571d875@github.com>

On Fri, 20 Sep 2024 09:53:00 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> few more tests to open source
> 
> Testing is good.

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21107#pullrequestreview-2319189353

From azvegint at openjdk.org  Fri Sep 20 19:36:37 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 20 Sep 2024 19:36:37 GMT
Subject: RFR: 8340433: Open source closed choice tests #3
In-Reply-To: <_0MhCk10bAxTeKlDCmn0_zNhxSdheonZtYUEiOlNVB4=.6680aa81-854a-4d22-a2d2-07b8eb3e959f@github.com>
References: <bkuFu9a7K35iiT58GCiPFGwsQwQDXBiqZ8gwNz85rhk=.ddda876b-9987-4d54-bc4f-b1710b04df2d@github.com>
 <_0MhCk10bAxTeKlDCmn0_zNhxSdheonZtYUEiOlNVB4=.6680aa81-854a-4d22-a2d2-07b8eb3e959f@github.com>
Message-ID: <31SBo7hk47dD32Si9bwm-YsXCteaw34uMbMQIzNgZrw=.023eb48d-267c-445a-bb80-f92288237960@github.com>

On Fri, 20 Sep 2024 19:14:19 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> few more tests to open source
>> 
>> Testing is good.
>
> test/jdk/java/awt/Choice/ChoicePosTest.java line 94:
> 
>> 92:     private static void captureAndTestChoices() {
>> 93:         Point c1loc = c1.getLocationOnScreen();
>> 94:         Point c2loc = c2.getLocationOnScreen();
> 
> Does this require EDT?

In this case this is not necessary, we just read the values after a rather long delay after setVisible.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21107#discussion_r1769154049

From aturbanov at openjdk.org  Fri Sep 20 19:38:35 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Fri, 20 Sep 2024 19:38:35 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests [v3]
In-Reply-To: <3iLEo71PiOQcWkrWO7yQwGAeimfJAZ3mIVJ5eXTGpFA=.ff572634-949c-49b3-a16f-83f1959f6565@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
 <3iLEo71PiOQcWkrWO7yQwGAeimfJAZ3mIVJ5eXTGpFA=.ff572634-949c-49b3-a16f-83f1959f6565@github.com>
Message-ID: <kIdCs163tKF2JjO3qfbu74MJ2HyDG08CUwE6RZRaoZs=.cb105213-61bb-4241-a2fa-be2c0e37960d@github.com>

On Fri, 20 Sep 2024 08:04:30 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT Frame related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

test/jdk/java/awt/Frame/FrameLayoutTest.java line 65:

> 63:         f.add(new Button("East"),BorderLayout.EAST);
> 64:         f.add(new Button("West"),BorderLayout.WEST);
> 65:         f.add(new Button("Cent"),BorderLayout.CENTER);

Suggestion:

        f.add(new Button("North"), BorderLayout.NORTH);
        f.add(new Button("South"), BorderLayout.SOUTH);
        f.add(new Button("East"), BorderLayout.EAST);
        f.add(new Button("West"), BorderLayout.WEST);
        f.add(new Button("Cent"), BorderLayout.CENTER);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1769169427

From prr at openjdk.org  Fri Sep 20 20:38:15 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 20 Sep 2024 20:38:15 GMT
Subject: RFR: 8340411: open source several 2D imaging tests [v2]
In-Reply-To: <PG3yJ3autwvRlyLp8YMrl4mxPNtByugQdydq9aLdnJU=.e8f9e35c-5542-410b-a9ae-4ea5ecbc8cc5@github.com>
References: <PG3yJ3autwvRlyLp8YMrl4mxPNtByugQdydq9aLdnJU=.e8f9e35c-5542-410b-a9ae-4ea5ecbc8cc5@github.com>
Message-ID: <SlXvP9ocWYFvFXDYaDBCcoB8jVmnJ84j0bcpfLFvMZk=.5adf9db1-0076-4668-85c9-b300bb588f78@github.com>

> open source several 2d imaging related tests.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8340411

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21113/files
  - new: https://git.openjdk.org/jdk/pull/21113/files/828bd843..3c176ba4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21113&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21113&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21113.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21113/head:pull/21113

PR: https://git.openjdk.org/jdk/pull/21113

From azvegint at openjdk.org  Fri Sep 20 20:42:36 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 20 Sep 2024 20:42:36 GMT
Subject: RFR: 8340411: open source several 2D imaging tests [v2]
In-Reply-To: <SlXvP9ocWYFvFXDYaDBCcoB8jVmnJ84j0bcpfLFvMZk=.5adf9db1-0076-4668-85c9-b300bb588f78@github.com>
References: <PG3yJ3autwvRlyLp8YMrl4mxPNtByugQdydq9aLdnJU=.e8f9e35c-5542-410b-a9ae-4ea5ecbc8cc5@github.com>
 <SlXvP9ocWYFvFXDYaDBCcoB8jVmnJ84j0bcpfLFvMZk=.5adf9db1-0076-4668-85c9-b300bb588f78@github.com>
Message-ID: <RlJI98NgsKBczfgRTn9gJtu05bOR4zp0QnZLu75If7s=.d7ba6276-bb53-4be8-89f9-ac18e06f5df1@github.com>

On Fri, 20 Sep 2024 20:38:15 GMT, Phil Race <prr at openjdk.org> wrote:

>> open source several 2d imaging related tests.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8340411

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21113#pullrequestreview-2319302988

From duke at openjdk.org  Fri Sep 20 20:49:34 2024
From: duke at openjdk.org (Abdelhak Zaaim)
Date: Fri, 20 Sep 2024 20:49:34 GMT
Subject: RFR: 8340411: open source several 2D imaging tests [v2]
In-Reply-To: <SlXvP9ocWYFvFXDYaDBCcoB8jVmnJ84j0bcpfLFvMZk=.5adf9db1-0076-4668-85c9-b300bb588f78@github.com>
References: <PG3yJ3autwvRlyLp8YMrl4mxPNtByugQdydq9aLdnJU=.e8f9e35c-5542-410b-a9ae-4ea5ecbc8cc5@github.com>
 <SlXvP9ocWYFvFXDYaDBCcoB8jVmnJ84j0bcpfLFvMZk=.5adf9db1-0076-4668-85c9-b300bb588f78@github.com>
Message-ID: <PhBuMLQwyExdNHqKtz9gP8Nxqgj0Uf280i9VHWElGu0=.0ca6de75-5dd7-41fa-afab-c3f6e7d6e68a@github.com>

On Fri, 20 Sep 2024 20:38:15 GMT, Phil Race <prr at openjdk.org> wrote:

>> open source several 2d imaging related tests.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8340411

Marked as reviewed by abdelhak-zaaim at github.com (no known OpenJDK username).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21113#pullrequestreview-2319314802

From prr at openjdk.org  Fri Sep 20 23:33:18 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 20 Sep 2024 23:33:18 GMT
Subject: RFR: 8340143: Open source several Java2D rendering loop tests.
Message-ID: <esjs4KwtSHviWVCI0rlJBIrkICCZf6HfB_313L_Ouq0=.4949fb2f-9c87-43a9-9a71-c11a31149177@github.com>

Open source some Java2d loop rendering tests.

-------------

Commit messages:
 - 8340143

Changes: https://git.openjdk.org/jdk/pull/21114/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21114&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340143
  Stats: 394 lines in 5 files changed: 394 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21114.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21114/head:pull/21114

PR: https://git.openjdk.org/jdk/pull/21114

From aivanov at openjdk.org  Sun Sep 22 14:47:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Sun, 22 Sep 2024 14:47:14 GMT
Subject: RFR: 8337287: Update image in javax.swing.text.Document.insert
 [v2]
In-Reply-To: <uGCW954xUGOPLGAdN1je8b3k9tQHYTfi8vb8-fYRHYk=.737dfade-8b82-4194-a4ab-fcf30bcb7ea1@github.com>
References: <uGCW954xUGOPLGAdN1je8b3k9tQHYTfi8vb8-fYRHYk=.737dfade-8b82-4194-a4ab-fcf30bcb7ea1@github.com>
Message-ID: <cTId-fHmBsho77NR9mJ2L3Hg_KxOYaFKFtYSBrdoeDo=.1c6a1185-3d6f-4ee1-b225-c899d2013228@github.com>

> This changeset updates the image in the documentation for the `Document.insert` method. The image in `Document.remove` was updated by [JDK-4622866](https://bugs.openjdk.org/browse/JDK-4622866) in PR #15701.
> 
> Now the illustration of inserting looks similar to removing. The new image is in SVG format.
> 
> For reference:
> 
> - [`Document.insert` in JDK 22](https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet));
> - [Updated docs for JDK 24](https://cr.openjdk.org/~aivanov/8337287/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet)).
> 
> As in the case with `remove`, I marked up to classes and members with {@code}.

Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:

  Describe inserting ?quick? into text

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20376/files
  - new: https://git.openjdk.org/jdk/pull/20376/files/697da25b..8077bde0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20376&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20376&range=00-01

  Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20376.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20376/head:pull/20376

PR: https://git.openjdk.org/jdk/pull/20376

From aivanov at openjdk.org  Sun Sep 22 14:47:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Sun, 22 Sep 2024 14:47:14 GMT
Subject: RFR: 8337287: Update image in javax.swing.text.Document.insert
In-Reply-To: <uGCW954xUGOPLGAdN1je8b3k9tQHYTfi8vb8-fYRHYk=.737dfade-8b82-4194-a4ab-fcf30bcb7ea1@github.com>
References: <uGCW954xUGOPLGAdN1je8b3k9tQHYTfi8vb8-fYRHYk=.737dfade-8b82-4194-a4ab-fcf30bcb7ea1@github.com>
Message-ID: <G0eabwT3kn_ai167YBA_GxLM6vxa-XlCsV9-g5Jw3Yo=.834d852b-6b33-466b-9d7e-f738e7d4f91c@github.com>

On Mon, 29 Jul 2024 13:43:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> This changeset updates the image in the documentation for the `Document.insert` method. The image in `Document.remove` was updated by [JDK-4622866](https://bugs.openjdk.org/browse/JDK-4622866) in PR #15701.
> 
> Now the illustration of inserting looks similar to removing. The new image is in SVG format.
> 
> For reference:
> 
> - [`Document.insert` in JDK 22](https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet));
> - [Updated docs for JDK 24](https://cr.openjdk.org/~aivanov/8337287/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet)).
> 
> As in the case with `remove`, I marked up to classes and members with {@code}.

> > > Just curious why the chars are not in the middle of the boxes?
> > 
> > The text is positioned in the middle of the box -0.5 pixels.
> 
> Moving the text position by 0.5 seems to help, and the values become equal: 7 on either side.
> 
> This needs to be done for the image in `remove` too, so I'd rather do that separately, at a later time.

Submitted [JDK-8340580](https://bugs.openjdk.org/browse/JDK-8340580): *Characters in Document diagrams not in the middle*.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20376#issuecomment-2366822283

From alanb at openjdk.org  Sun Sep 22 15:36:36 2024
From: alanb at openjdk.org (Alan Bateman)
Date: Sun, 22 Sep 2024 15:36:36 GMT
Subject: RFR: 8311530: Deprecate jdk.jsobject module for removal
In-Reply-To: <WhG8jlLAttk0bO_beHeYTh7G3lhWR-uRvJdPqVr_wj4=.2a8b5a00-5382-46df-8e39-abcfa76fc64b@github.com>
References: <IGLgrBcj15QFo70cviDkjokoBOBpDBYXru2PS2N7hKQ=.d365a073-1153-420f-992c-03c7994073e9@github.com>
 <_MLFl-Zir7vvv44qc5hGXChNRhuiwmvTYkXLxVIUFC0=.a6fd655a-6e1a-4704-b317-5a2553a86fd3@github.com>
 <WhG8jlLAttk0bO_beHeYTh7G3lhWR-uRvJdPqVr_wj4=.2a8b5a00-5382-46df-8e39-abcfa76fc64b@github.com>
Message-ID: <XQQv6Ry03Tw27yo_CGmJyIcIR1U2UgbQXwqhwOv_qrY=.0e41f9dd-c158-473e-8493-25435b8b43c4@github.com>

On Fri, 6 Sep 2024 13:16:34 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Looks good. I'll review the CSR when its ready.
>
>> Looks good. I'll review the CSR when its ready.
> 
> Thanks.
> 
>> The changes to make jdk.jsobject an upgradeable module looks right.
> 
> Thanks for checking. My testing primarily focused on this aspect of the change, so it's pretty well tested.
> 
>> I was initially surprised by the wording "will be delivered with JavaFX" but after playing with a few alternatives I concluded that what we have is okay.
> 
> Yeah, I tried a few variants and couldn't come up with anything better.

@kevinrushforth Is the CSR on your list to write?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20555#issuecomment-2366841622

From rgupta at openjdk.org  Mon Sep 23 04:19:20 2024
From: rgupta at openjdk.org (Ravi Gupta)
Date: Mon, 23 Sep 2024 04:19:20 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v11]
In-Reply-To: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
Message-ID: <qt1TqbEVk_Y1g5-XOSbd4L8khlM7mlY3SqomRss4DHM=.428750c0-bc08-4426-a74c-1d1e6abac2df@github.com>

> This testcase checks for the following assertions for Component events:
> 
> 1. When components are resized, moved, hidden and shown the respective events are triggered.
> 2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
> 3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
> 4. When a window is minimized/restored then hidden and shown component events should be triggered.
> 
> Testing:
> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.

Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:

  8333403: Review Comments Fixed

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19521/files
  - new: https://git.openjdk.org/jdk/pull/19521/files/9633a03a..fe35276b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19521&range=10
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19521&range=09-10

  Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/19521.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19521/head:pull/19521

PR: https://git.openjdk.org/jdk/pull/19521

From abhiscxk at openjdk.org  Mon Sep 23 04:21:27 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 23 Sep 2024 04:21:27 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests [v4]
In-Reply-To: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
Message-ID: <O2i5etw8bQIABwfWsc-Y_yLCZzWc799rcZ4LgcpkLZk=.04dfc903-798d-4833-92c5-337e1b7a1eef@github.com>

> Few AWT Frame related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  minor spacing

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21052/files
  - new: https://git.openjdk.org/jdk/pull/21052/files/523e410c..cdeb0647

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21052&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21052&range=02-03

  Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/21052.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21052/head:pull/21052

PR: https://git.openjdk.org/jdk/pull/21052

From abhiscxk at openjdk.org  Mon Sep 23 04:38:35 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 23 Sep 2024 04:38:35 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests [v3]
In-Reply-To: <3jqAwnN7GJt0IDuI1_iS10L1PQhZIkmzU54GGB4Kg-E=.37b4f22c-f1a1-4650-a9b6-a5d054c56e84@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
 <3iLEo71PiOQcWkrWO7yQwGAeimfJAZ3mIVJ5eXTGpFA=.ff572634-949c-49b3-a16f-83f1959f6565@github.com>
 <3jqAwnN7GJt0IDuI1_iS10L1PQhZIkmzU54GGB4Kg-E=.37b4f22c-f1a1-4650-a9b6-a5d054c56e84@github.com>
Message-ID: <F13I-BMcY_cWKJ2kbs-_IbbNQK9pcZskA1gpDsqpg_k=.51e471ad-cdaa-4912-855c-7c53edb4ef60@github.com>

On Fri, 20 Sep 2024 08:44:59 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment update
>
> Marked as reviewed by psadhukhan (Reviewer).

@prsadhuk Please re-review this PR. There is a minor spacing change compared to last commit.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21052#issuecomment-2367222019

From tr at openjdk.org  Mon Sep 23 05:03:58 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 23 Sep 2024 05:03:58 GMT
Subject: RFR: 8339836: Open source several AWT Mouse tests - Batch 1
Message-ID: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>

Open source these AWT Mouse tests:

java/awt/Mouse/MouseEnterExitTest.java
java/awt/Mouse/MouseEnterExitTest2.java
java/awt/Mouse/MousePressedTest.java
java/awt/Mouse/MouseEnterExitTest4.java
java/awt/Mouse/MouseEnterExitTest3.java

-------------

Commit messages:
 - jtreg updates
 - Open Source few Mouse Test

Changes: https://git.openjdk.org/jdk/pull/21124/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21124&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339836
  Stats: 607 lines in 5 files changed: 607 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21124.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21124/head:pull/21124

PR: https://git.openjdk.org/jdk/pull/21124

From tr at openjdk.org  Mon Sep 23 06:46:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 23 Sep 2024 06:46:21 GMT
Subject: RFR: 8339982: Open source several AWT Mouse tests - Batch 2
Message-ID: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>

Open source these AWT Mouse and GraphicsEnvironment tests:

java/awt/MouseClickCount/MouseClickCount.java
java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java
java/awt/MouseDragTest/MouseDragTest.java
java/awt/OpenWinDoubleClickTest/OpenWinDoubleClickTest.java
java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java

-------------

Commit messages:
 - Moved Graphics test
 - Open Source few Mouse Test
 - Open Source few Mouse Test

Changes: https://git.openjdk.org/jdk/pull/21126/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21126&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339982
  Stats: 676 lines in 6 files changed: 676 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21126.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21126/head:pull/21126

PR: https://git.openjdk.org/jdk/pull/21126

From psadhukhan at openjdk.org  Mon Sep 23 07:08:36 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 23 Sep 2024 07:08:36 GMT
Subject: RFR: 8340084: Open source AWT Frame related tests [v4]
In-Reply-To: <O2i5etw8bQIABwfWsc-Y_yLCZzWc799rcZ4LgcpkLZk=.04dfc903-798d-4833-92c5-337e1b7a1eef@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
 <O2i5etw8bQIABwfWsc-Y_yLCZzWc799rcZ4LgcpkLZk=.04dfc903-798d-4833-92c5-337e1b7a1eef@github.com>
Message-ID: <ghG4HBx14fvqNXQB7Bs0Ho4mfwYNtH-GaZxnXBAoIcw=.f0586437-d60e-484d-bf6c-a52905b99b3b@github.com>

On Mon, 23 Sep 2024 04:21:27 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT Frame related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor spacing

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21052#pullrequestreview-2321276681

From abhiscxk at openjdk.org  Mon Sep 23 08:05:46 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 23 Sep 2024 08:05:46 GMT
Subject: Integrated: 8340084: Open source AWT Frame related tests
In-Reply-To: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
References: <0YCOwo6vg8Op9ELdPFeWHh_iJtPdA-bn5DYqSLQb_Jc=.3df80134-bb45-4a43-a4bc-e9449db1450a@github.com>
Message-ID: <k3CdJtoqSxZJAs1TFijxqlaNwnfNUA_3oFW4lWN45TU=.b6ad0673-e290-4cd6-818a-c38e8c3f81a3@github.com>

On Wed, 18 Sep 2024 06:18:03 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Few AWT Frame related tests are converted from applet to manual and moved to open.

This pull request has now been integrated.

Changeset: bc7c0dc4
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/bc7c0dc45dcd66d24ece8ebbd5c1b25e131eae67
Stats:     393 lines in 5 files changed: 393 ins; 0 del; 0 mod

8340084: Open source AWT Frame related tests

Reviewed-by: psadhukhan, honkar

-------------

PR: https://git.openjdk.org/jdk/pull/21052

From aivanov at openjdk.org  Mon Sep 23 11:46:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Sep 2024 11:46:39 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v11]
In-Reply-To: <qt1TqbEVk_Y1g5-XOSbd4L8khlM7mlY3SqomRss4DHM=.428750c0-bc08-4426-a74c-1d1e6abac2df@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <qt1TqbEVk_Y1g5-XOSbd4L8khlM7mlY3SqomRss4DHM=.428750c0-bc08-4426-a74c-1d1e6abac2df@github.com>
Message-ID: <S2hVsd_1w3qSIfmKvPJ_FoEr9XdWymz_1lMgY5_Gmlc=.47a23cbf-0683-4ecb-8c1b-9054cd4288ef@github.com>

On Mon, 23 Sep 2024 04:19:20 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:

>> This testcase checks for the following assertions for Component events:
>> 
>> 1. When components are resized, moved, hidden and shown the respective events are triggered.
>> 2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
>> 3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
>> 4. When a window is minimized/restored then hidden and shown component events should be triggered.
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.
>
> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8333403: Review Comments Fixed

Looks good to me.

I presume you've run the updated test in CI.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19521#pullrequestreview-2321939823

From kcr at openjdk.org  Mon Sep 23 12:51:38 2024
From: kcr at openjdk.org (Kevin Rushforth)
Date: Mon, 23 Sep 2024 12:51:38 GMT
Subject: RFR: 8311530: Deprecate jdk.jsobject module for removal
In-Reply-To: <IGLgrBcj15QFo70cviDkjokoBOBpDBYXru2PS2N7hKQ=.d365a073-1153-420f-992c-03c7994073e9@github.com>
References: <IGLgrBcj15QFo70cviDkjokoBOBpDBYXru2PS2N7hKQ=.d365a073-1153-420f-992c-03c7994073e9@github.com>
Message-ID: <umhdvXQEepk2KYi0pcub_yjju5pXQ-Q_dDIN9GrHOkE=.608f2cc0-6c30-4157-9454-b6120fbf6c07@github.com>

On Mon, 12 Aug 2024 17:22:47 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it with JavaFX instead.
> 
> See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR openjdk/jfx#1529 for the JavaFX PR that will include the module with JavaFX. That PR describes the needed test scenarios.
> 
> This PR does two things:
> 
> 1. Deprecates the `jdk.jsobject` module for removal; the javadoc indicates that the module will be delivered with JavaFX
> 2. Makes `jdk.jsobject` an upgradeable module, which will facilitate the transition by allowing the version of the module shipped with JavaFX to be used in favor of the deprecated module in the JDK itself.

Yes, this was on hold for a couple weeks; I plan to write the CSR this week.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20555#issuecomment-2368124430

From aivanov at openjdk.org  Mon Sep 23 13:10:43 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Sep 2024 13:10:43 GMT
Subject: RFR: 7188058: Background of TextComponents are not changing colors
 to the default disabled color when set to uneditable [v5]
In-Reply-To: <9N8EtzrVB-E5O4pEd-FsudqecadPPEreSGrIBPyTRRg=.b1fd306f-4b00-4872-8565-2fcefe2bbe08@github.com>
References: <xISI213Mn0nqyvLjCS0agPMEDaUmz7wbJUoH51jVUpI=.6dfeb0ef-d756-4426-acfc-7629bab3dcc6@github.com>
 <095gCTeexK0MP5AzEUrNwAOtXDzFiNDUIjd5LHbh-sY=.fb49a844-8568-4713-9f34-8e1641e11efe@github.com>
 <9N8EtzrVB-E5O4pEd-FsudqecadPPEreSGrIBPyTRRg=.b1fd306f-4b00-4872-8565-2fcefe2bbe08@github.com>
Message-ID: <3YTKEFp8vOet2pT-FRKw3F72RoDNYN9mWmSWcTmBC2I=.3886e32f-46c2-4161-a3a8-4d6bb3160c8c@github.com>

On Fri, 23 Aug 2024 04:26:30 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Also, since the testcase is just testing the background color, I think it can be made automated and even headless by using textfield/textarea rendering to BufferedImage

AWT components cannot be created in headless environment.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19876#issuecomment-2368176102

From aivanov at openjdk.org  Mon Sep 23 13:17:43 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Sep 2024 13:17:43 GMT
Subject: RFR: 7188058: Background of TextComponents are not changing colors
 to the default disabled color when set to uneditable [v2]
In-Reply-To: <DcQj9MnPGdBki680yK7NMSSRUBDIoJyFbaBTVPyVBXU=.b4ad2c88-08b4-4327-8c1e-aaf375f7c1fe@github.com>
References: <xISI213Mn0nqyvLjCS0agPMEDaUmz7wbJUoH51jVUpI=.6dfeb0ef-d756-4426-acfc-7629bab3dcc6@github.com>
 <aOd8NZ5VF5RVV1jFxYPbE5tiCRPK2NGmfHuX-VpMuhg=.725ab6ad-0601-4678-ba8a-5dc9ea89ca2d@github.com>
 <77lt11qmN9Pift0gg2CmeN1v1CRSv4nP50d8hdNPynU=.f2f65d8a-293d-48c2-81d4-0b945cfcb158@github.com>
 <oAcgcL7ffwWcfOlF-i1CMOOZ4LRZoxvn1YSJu7TcGws=.b3e91d62-74d1-4c48-ac23-7e484a295baa@github.com>
 <JAHWO2uL0SJaWwUxuFgStBybeMSFHPwES9cFFDekf-0=.c09a9fc8-5f58-4a94-8f35-70977bd2e909@github.com>
 <DcQj9MnPGdBki680yK7NMSSRUBDIoJyFbaBTVPyVBXU=.b4ad2c88-08b4-4327-8c1e-aaf375f7c1fe@github.com>
Message-ID: <8MUR_6S1CHlM2K_qkrsklBYvrQAZWdgJugYDf0-KsXk=.6c6aa260-6f0e-4d2f-8342-ab998e413022@github.com>

On Thu, 8 Aug 2024 01:19:55 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Yes, but as far I could see `TextArea.background` property is being set in 
>> `AquaLookAndFeel.java, MotifLookAndFeel.java, BasicLookAndFeel.java, XAWTLookAndFeel.java and WindowsLookAndFeel.java`
>> and this L&F will not be set in AWT environment, if I am not wrong so you will either get garbage or wrong default color if you use UIManager.getColor..so I guess you need to use `TextComponent.getBackground()` which returns SystemColor.control if nothing is set
>
> i've made the change to use TextComponent.getBackground() instead to get the correct background color

AWT components **must not depend on `javax.swing.UIManager`** ? pluggable Look and Feels and `UIManager` are features of Swing.

Some AWT components are implemented using lightweight components from Swing, in this case it's appropriate to use `javax.swing` packages but *not in the common code* ? in the peers.

As far as I can see, [JDK-7188058](https://bugs.openjdk.org/browse/JDK-7188058) references Linux and macOS only. AWT component on Mac use Swing components; not sure about Linux though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19876#discussion_r1771403834

From sgehwolf at openjdk.org  Mon Sep 23 13:20:37 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 23 Sep 2024 13:20:37 GMT
Subject: RFR: 8336382: Fixes error reporting in loading AWT and fonts [v3]
In-Reply-To: <EDgyJfKO5A7SvPmjTbkRo-R-9yFFWIcI4sQhPSuGiyg=.a61ad063-d7b3-4696-8d10-d80a7ede3371@github.com>
References: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
 <GbmkgT6SggwJSszpDku1oVChLXFdDXjxj-1qlcbQ53A=.77d741a9-5975-4f23-951b-35abcdeeffe4@github.com>
 <EDgyJfKO5A7SvPmjTbkRo-R-9yFFWIcI4sQhPSuGiyg=.a61ad063-d7b3-4696-8d10-d80a7ede3371@github.com>
Message-ID: <chRPMTpWOXXfwgMdFEbNDzgVmuN11XTxPr-buwFq4rM=.af23cbf3-2231-40ea-8051-429233609bb3@github.com>

On Fri, 13 Sep 2024 09:02:07 GMT, Karm Michal Babacek <duke at openjdk.org> wrote:

>> There is nothing in this PR that I would accept. It should be withdrawn.
>
> ping @prrace

@Karm There are a few things that have not yet been addressed:

- @avu mentioned [here](https://github.com/openjdk/jdk/pull/20169#discussion_r1677699984) that copyright years of the file need updating
- There is a title mismatch between this PR and the JBS entry. Which one should it be if any? (and I'll help you fix that one).

I'd also merge in latest master since x86 tests have since been disabled. That should fix the GHA issue.

Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20169#issuecomment-2368212843

From aivanov at openjdk.org  Mon Sep 23 13:33:37 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Sep 2024 13:33:37 GMT
Subject: RFR: 7188058: Background of TextComponents are not changing colors
 to the default disabled color when set to uneditable [v5]
In-Reply-To: <095gCTeexK0MP5AzEUrNwAOtXDzFiNDUIjd5LHbh-sY=.fb49a844-8568-4713-9f34-8e1641e11efe@github.com>
References: <xISI213Mn0nqyvLjCS0agPMEDaUmz7wbJUoH51jVUpI=.6dfeb0ef-d756-4426-acfc-7629bab3dcc6@github.com>
 <095gCTeexK0MP5AzEUrNwAOtXDzFiNDUIjd5LHbh-sY=.fb49a844-8568-4713-9f34-8e1641e11efe@github.com>
Message-ID: <IoK_QSNVRnILBB667odG9kBymj_FbU2QgqujofUhLKs=.43744c8f-30ee-41b4-b758-6a756cfb82f3@github.com>

On Tue, 20 Aug 2024 23:53:45 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Currently the bug described in the issue is that the colors of the TextComponents do not change when setting TextComponents to uneditable. The default uneditable color (SystemColor.control) happens to be the same as the default for the editable color for some L&Fs, so the fix may not be initially noticeable. However, the bug still exists where the the color is not being changed when changing between editable and uneditable. You can check by changing TextComponent.getBackground() code to return Color.GRAY on line 342 and you can see that TextComponents are not changing to a gray background when set to uneditable.
>> 
>> This fix adds a private setBackground method in TextComponent so that TextArea and TextField can change the background color to the correct color (SystemColor.control) when set uneditable by overriding the TextComponent setEditable. You can verify the fix by changing this color to Color.GRAY and verifying the backgrounds change to gray when the TextComponents are disabled.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix import

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/java/awt/TextComponent.java line 363:

> 361: 
> 362:     void setBackground(Color c, boolean setByClient) {
> 363:         backgroundSetByClientCode = setByClient;

Assigning the passed value to `backgroundSetByClientCode` does not make sense to me: the code in `TextArea.setEditable` already depends on the value of `backgroundSetByClientCode`, and the field shouldn't change as the result.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19876#pullrequestreview-2322221456
PR Review Comment: https://git.openjdk.org/jdk/pull/19876#discussion_r1771424499

From aivanov at openjdk.org  Mon Sep 23 13:33:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Sep 2024 13:33:38 GMT
Subject: RFR: 7188058: Background of TextComponents are not changing colors
 to the default disabled color when set to uneditable [v5]
In-Reply-To: <h0mnOASeA0ILqtDlAovozWyg_rq9wQSQL0FWo198Dtc=.8d3617c3-e479-4131-8ec1-9215cc25c426@github.com>
References: <xISI213Mn0nqyvLjCS0agPMEDaUmz7wbJUoH51jVUpI=.6dfeb0ef-d756-4426-acfc-7629bab3dcc6@github.com>
 <095gCTeexK0MP5AzEUrNwAOtXDzFiNDUIjd5LHbh-sY=.fb49a844-8568-4713-9f34-8e1641e11efe@github.com>
 <h0mnOASeA0ILqtDlAovozWyg_rq9wQSQL0FWo198Dtc=.8d3617c3-e479-4131-8ec1-9215cc25c426@github.com>
Message-ID: <yXLUQbH0Jsri3hsdjvcKDnjm3eXl5Kqcjq2pIZZ-mvg=.3fd49f40-5cd9-4c62-bc81-60db5109a4d0@github.com>

On Fri, 23 Aug 2024 05:24:16 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix import
>
> src/java.desktop/share/classes/java/awt/TextArea.java line 610:
> 
>> 608: 
>> 609:     @Override
>> 610:     public synchronized void setEditable(boolean b) {
> 
> `setEditable` method is overridden in both `TextArea` and `TextField` class and method implementation is same. Since both of them are  inherited from `TextComponent` class, could we move the code to `TextComponent's setEditable` method and remove them from respective classes?

This is a good suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19876#discussion_r1771426903

From aivanov at openjdk.org  Mon Sep 23 13:56:37 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Sep 2024 13:56:37 GMT
Subject: RFR: 7188058: Background of TextComponents are not changing colors
 to the default disabled color when set to uneditable [v5]
In-Reply-To: <095gCTeexK0MP5AzEUrNwAOtXDzFiNDUIjd5LHbh-sY=.fb49a844-8568-4713-9f34-8e1641e11efe@github.com>
References: <xISI213Mn0nqyvLjCS0agPMEDaUmz7wbJUoH51jVUpI=.6dfeb0ef-d756-4426-acfc-7629bab3dcc6@github.com>
 <095gCTeexK0MP5AzEUrNwAOtXDzFiNDUIjd5LHbh-sY=.fb49a844-8568-4713-9f34-8e1641e11efe@github.com>
Message-ID: <8LKkRLDLELCkF2tuLqf968QXC6MHzPtLfpfjH9UYfSE=.db30c343-224b-4ac4-9d6f-a8ae2dccf700@github.com>

On Tue, 20 Aug 2024 23:53:45 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Currently the bug described in the issue is that the colors of the TextComponents do not change when setting TextComponents to uneditable. The default uneditable color (SystemColor.control) happens to be the same as the default for the editable color for some L&Fs, so the fix may not be initially noticeable. However, the bug still exists where the the color is not being changed when changing between editable and uneditable. You can check by changing TextComponent.getBackground() code to return Color.GRAY on line 342 and you can see that TextComponents are not changing to a gray background when set to uneditable.
>> 
>> This fix adds a private setBackground method in TextComponent so that TextArea and TextField can change the background color to the correct color (SystemColor.control) when set uneditable by overriding the TextComponent setEditable. You can verify the fix by changing this color to Color.GRAY and verifying the backgrounds change to gray when the TextComponents are disabled.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix import

Is it a bug?

How do native text fields and areas behave on Linux and macOS? Does any of them change colours when it's switched into uneditable mode?

AWT components should behave as native controls do. On Windows, uneditable text field and text area usually have a different background which corresponds to background of a dialog box. Is it the case on Linux and macOS?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19876#issuecomment-2368341628

From azvegint at openjdk.org  Mon Sep 23 14:00:52 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 23 Sep 2024 14:00:52 GMT
Subject: Integrated: 8340393: Open source closed choice tests #2
In-Reply-To: <nPZJzcL0dCCai5InSUz1W8kwsALcAHdRbirw1X76gjk=.808e59af-027a-4666-8e6d-c519bf4db53e@github.com>
References: <nPZJzcL0dCCai5InSUz1W8kwsALcAHdRbirw1X76gjk=.808e59af-027a-4666-8e6d-c519bf4db53e@github.com>
Message-ID: <Hx9sY7YKuZ7VYo02DcZQgldcebD0pRiOiOcyeJpamp8=.079f152e-660c-4976-808b-43a27361391b@github.com>

On Thu, 19 Sep 2024 06:39:40 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> few manual tests to open source
> Tested on all platforms, all looks good.

This pull request has now been integrated.

Changeset: a9b0f9cc
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a9b0f9ccbf98c6b90626fcd7087fa8eeb0c168eb
Stats:     322 lines in 4 files changed: 322 ins; 0 del; 0 mod

8340393: Open source closed choice tests #2

Reviewed-by: psadhukhan

-------------

PR: https://git.openjdk.org/jdk/pull/21081

From aivanov at openjdk.org  Mon Sep 23 14:35:36 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Sep 2024 14:35:36 GMT
Subject: RFR: 8340365: Position the first window of a window list
In-Reply-To: <kr9W8ErVN-zmO0wIUZOXK_aybNHmTM-Fswv5KJp0oSc=.04ae2115-6f08-42d7-a548-2f2be10a7559@github.com>
References: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
 <f4Px95Y501ewsTDVmFaVtG3Vl-y7GvD6dIXpgcCVS40=.72e79b8f-a41c-4177-a2d1-62f37cc7008d@github.com>
 <fXdLL9t4lj3i-PWSNt_ZLuhAcDZIMxozZ9NoRY6pNA8=.80c3e9f9-55a6-436d-9160-48bb55f60bb1@github.com>
 <kr9W8ErVN-zmO0wIUZOXK_aybNHmTM-Fswv5KJp0oSc=.04ae2115-6f08-42d7-a548-2f2be10a7559@github.com>
Message-ID: <8mWQprTxNQEMMZ0nVDYNvfqXnPIVRHTeIsg0cSrgwZ4=.0254a87f-2b21-4d8b-a35a-df0b89c9b30c@github.com>

On Wed, 18 Sep 2024 20:52:23 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > Perhaps adding the required pattern in the examples would be a good idea.
> 
> Yes, it's a good idea.

Although, I support this, I feel it is out of scope for this change.

I submitted [JDK-8340469](https://bugs.openjdk.org/browse/JDK-8340469): _Provide example of multiple test UI windows_, and I'm currently working on improving the docs for `PassFailJFrame`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21057#issuecomment-2368469117

From aivanov at openjdk.org  Mon Sep 23 14:38:07 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Sep 2024 14:38:07 GMT
Subject: RFR: 8340461: Amend description for logArea
Message-ID: <1f-Y1noCKQ3rL7KSJOPRswNG4xpNGQoOYG0M3Dn1Y7s=.4666e474-e104-43cc-9680-9d980260ad12@github.com>

Resolve the error:

PassFailJFrame.java:161: error: text not allowed in <ul> element
 *     <li>to add a log area</li>,
                                 ^


Shorten the rendered javadoc for `log`, `logClear` and `logSet`.

@azvegint, could you take a look?

-------------

Commit messages:
 - 8340461: Amend description for logArea

Changes: https://git.openjdk.org/jdk/pull/21138/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21138&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340461
  Stats: 9 lines in 1 file changed: 4 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/21138.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21138/head:pull/21138

PR: https://git.openjdk.org/jdk/pull/21138

From azvegint at openjdk.org  Mon Sep 23 14:38:07 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 23 Sep 2024 14:38:07 GMT
Subject: RFR: 8340461: Amend description for logArea
In-Reply-To: <1f-Y1noCKQ3rL7KSJOPRswNG4xpNGQoOYG0M3Dn1Y7s=.4666e474-e104-43cc-9680-9d980260ad12@github.com>
References: <1f-Y1noCKQ3rL7KSJOPRswNG4xpNGQoOYG0M3Dn1Y7s=.4666e474-e104-43cc-9680-9d980260ad12@github.com>
Message-ID: <c9W9tdWI8kCB-ZVlls3oBuaXkrrFi27hgNZWCTAZKIA=.bab1c150-8850-4e47-a1d4-64cd9e807b0b@github.com>

On Mon, 23 Sep 2024 14:30:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Resolve the error:
> 
> PassFailJFrame.java:161: error: text not allowed in <ul> element
>  *     <li>to add a log area</li>,
>                                  ^
> 
> 
> Shorten the rendered javadoc for `log`, `logClear` and `logSet`.
> 
> @azvegint, could you take a look?

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21138#pullrequestreview-2322478851

From aivanov at openjdk.org  Mon Sep 23 14:40:36 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Sep 2024 14:40:36 GMT
Subject: RFR: 8340365: Position the first window of a window list
In-Reply-To: <fXdLL9t4lj3i-PWSNt_ZLuhAcDZIMxozZ9NoRY6pNA8=.80c3e9f9-55a6-436d-9160-48bb55f60bb1@github.com>
References: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
 <f4Px95Y501ewsTDVmFaVtG3Vl-y7GvD6dIXpgcCVS40=.72e79b8f-a41c-4177-a2d1-62f37cc7008d@github.com>
 <fXdLL9t4lj3i-PWSNt_ZLuhAcDZIMxozZ9NoRY6pNA8=.80c3e9f9-55a6-436d-9160-48bb55f60bb1@github.com>
Message-ID: <EdbnEXcRZXNOwQ9MOAeyFWD_U7DSV7PypZlNtdxqwH0=.4dc31e19-a078-422b-9eaf-9262f2283cde@github.com>

On Wed, 18 Sep 2024 20:12:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > > With the proposed change in this pull request, the implementation would use ComponentListener.componentMoved:
> > 
> > 
> > you mean the implementation of the test ? Perhaps adding the required pattern in the examples would be a good idea.
> 
> @prrace Yes, I referred to the implementation of the `LotsOfMenuItemsTest.java` test.
> 
> This is more of a workaround until we add better layout options. Yet it looks simple and works well. It still requires the test developer to save references to frames.

Eventually, @kumarabhi006 re-worked the test in #21029, and `LotsOfMenuItemsTest.java` no longer uses the feature of `PassFailJFrame` for creating multiple test windows.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21057#issuecomment-2368483198

From kcr at openjdk.org  Mon Sep 23 16:32:23 2024
From: kcr at openjdk.org (Kevin Rushforth)
Date: Mon, 23 Sep 2024 16:32:23 GMT
Subject: RFR: 8311530: Deprecate jdk.jsobject module for removal [v2]
In-Reply-To: <IGLgrBcj15QFo70cviDkjokoBOBpDBYXru2PS2N7hKQ=.d365a073-1153-420f-992c-03c7994073e9@github.com>
References: <IGLgrBcj15QFo70cviDkjokoBOBpDBYXru2PS2N7hKQ=.d365a073-1153-420f-992c-03c7994073e9@github.com>
Message-ID: <Sgi1WKvchV1LRS-hPO7eUZIaCWXjfCDLCLidsn1kYts=.944d041e-24f0-4938-877c-7cd95641506e@github.com>

> Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it with JavaFX instead.
> 
> See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR openjdk/jfx#1529 for the JavaFX PR that will include the module with JavaFX. That PR describes the needed test scenarios.
> 
> This PR does two things:
> 
> 1. Deprecates the `jdk.jsobject` module for removal; the javadoc indicates that the module will be delivered with JavaFX
> 2. Makes `jdk.jsobject` an upgradeable module, which will facilitate the transition by allowing the version of the module shipped with JavaFX to be used in favor of the deprecated module in the JDK itself.

Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:

 - Merge branch 'master' into 8311530-depr-jsobject
 - Merge branch 'master' into 8311530-depr-jsobject
 - Merge branch 'master' into 8311530-depr-jsobject
 - Update javadoc
 - Update copyright years
 - Merge branch 'master' into 8311530-depr-jsobject
 - Add jdk.jsobject to list of UPGRADEABLE_MODULES in UpgradeableModules test
 - 8311530: Deprecate jdk.jsobject module for removal

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20555/files
  - new: https://git.openjdk.org/jdk/pull/20555/files/c3ee6ad3..d2ff851c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20555&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20555&range=00-01

  Stats: 168234 lines in 1172 files changed: 155508 ins; 7077 del; 5649 mod
  Patch: https://git.openjdk.org/jdk/pull/20555.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20555/head:pull/20555

PR: https://git.openjdk.org/jdk/pull/20555

From prr at openjdk.org  Mon Sep 23 17:59:37 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 23 Sep 2024 17:59:37 GMT
Subject: RFR: 8340367: Opensource few AWT image tests
In-Reply-To: <P8HjYF8P5RZA8rHbvrwphv7piP2VNBlOa1QhFWTb9to=.04ff770d-03eb-4c9e-b5be-0687b1fd8ccd@github.com>
References: <P8HjYF8P5RZA8rHbvrwphv7piP2VNBlOa1QhFWTb9to=.04ff770d-03eb-4c9e-b5be-0687b1fd8ccd@github.com>
Message-ID: <OkMt1I-rK8mcidI_FPtj9zJYcg6b__dydCRET6FxoEw=.9cdc2ecb-8437-4b23-bc8b-c496b466e52f@github.com>

On Fri, 20 Sep 2024 03:58:20 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few image tests

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21104#pullrequestreview-2322963148

From prr at openjdk.org  Mon Sep 23 18:01:38 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 23 Sep 2024 18:01:38 GMT
Subject: RFR: 8339995: Open source several AWT focus tests - series 6 [v2]
In-Reply-To: <A_wNaw65K8dCWTQCRTaWJfCSleWQUKGXdjLKO5ycSAE=.ebe8a500-5749-45cb-8864-7ae0ee042ac5@github.com>
References: <x2ZMBdtKL5Vl6Ttilo5YR4UGKKrXfm5rN-VnulWIjT4=.adef4881-a709-4756-9160-5785f2d3ea4f@github.com>
 <A_wNaw65K8dCWTQCRTaWJfCSleWQUKGXdjLKO5ycSAE=.ebe8a500-5749-45cb-8864-7ae0ee042ac5@github.com>
Message-ID: <x1zjfz7CK23cAoBV_72ve6XwCYg0riC_vnIZZvOmnPI=.addf8fc9-6149-495f-8117-f7d9f8a1b6f3@github.com>

On Thu, 19 Sep 2024 05:34:48 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few Focus tests
>
> Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Merge master
>  - windows
>  - InitialFocusTest
>  - 8339995: Open source several AWT focus tests - series 6

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21079#pullrequestreview-2322968024

From prr at openjdk.org  Mon Sep 23 18:06:37 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 23 Sep 2024 18:06:37 GMT
Subject: RFR: 8339935: Open source several AWT focus tests - series 5
In-Reply-To: <9CBDlYAA5yUeyovwlZ8wpQ5fEE6YIXMUUt53BVb-JbU=.9f8c5c39-2e90-4d6a-868f-734cea42367e@github.com>
References: <9CBDlYAA5yUeyovwlZ8wpQ5fEE6YIXMUUt53BVb-JbU=.9f8c5c39-2e90-4d6a-868f-734cea42367e@github.com>
Message-ID: <C5Hbi8kSA7LtRpdEEDIcUnyGqZ-d96gC-1uAAIJ8zEI=.c63ee9c0-3ac5-4ccf-a656-7dd7b65f263b@github.com>

On Fri, 20 Sep 2024 03:23:26 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few AWT focus tests

Changes requested by prr (Reviewer).

test/jdk/java/awt/Focus/LightweightPopupTest.java line 27:

> 25:  * @test
> 26:  * @bug 4472032
> 27:  * @summary Switching between lightweight menus by holizontal arrow key works incorrect

holizontal -> horizontal

test/jdk/java/awt/Focus/ProxiedWindowHideTest.java line 27:

> 25:  * @test
> 26:  * @bug 4396407
> 27:  * @summary Tests that after proxied window were hidden focus is being restored correctly

... after a proxied window is hidden ...

test/jdk/java/awt/Focus/ProxiedWindowHideTest.java line 43:

> 41: 
> 42:     private static final String INSTRUCTIONS = """
> 43:            You will see JFrame with title 'TEST'.

looks to me like the title is actually "ProxiedWindowHideTest frame".
A tester might decide to fail the test because of this.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21103#pullrequestreview-2322970675
PR Review Comment: https://git.openjdk.org/jdk/pull/21103#discussion_r1771870228
PR Review Comment: https://git.openjdk.org/jdk/pull/21103#discussion_r1771874098
PR Review Comment: https://git.openjdk.org/jdk/pull/21103#discussion_r1771873321

From prr at openjdk.org  Mon Sep 23 18:27:44 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 23 Sep 2024 18:27:44 GMT
Subject: RFR: 8340461: Amend description for logArea
In-Reply-To: <1f-Y1noCKQ3rL7KSJOPRswNG4xpNGQoOYG0M3Dn1Y7s=.4666e474-e104-43cc-9680-9d980260ad12@github.com>
References: <1f-Y1noCKQ3rL7KSJOPRswNG4xpNGQoOYG0M3Dn1Y7s=.4666e474-e104-43cc-9680-9d980260ad12@github.com>
Message-ID: <S2lKd4aBBpyL0pC5kcfHGzlNHDzZEylqDsPW95Oq0vU=.534ba56b-4cf2-44b8-bb01-20d655a0c85d@github.com>

On Mon, 23 Sep 2024 14:30:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Resolve the error:
> 
> PassFailJFrame.java:161: error: text not allowed in <ul> element
>  *     <li>to add a log area</li>,
>                                  ^
> 
> 
> Shorten the rendered javadoc for `log`, `logClear` and `logSet`.
> 
> @azvegint, could you take a look?

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21138#pullrequestreview-2323012627

From aivanov at openjdk.org  Mon Sep 23 18:27:45 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Sep 2024 18:27:45 GMT
Subject: Integrated: 8340461: Amend description for logArea
In-Reply-To: <1f-Y1noCKQ3rL7KSJOPRswNG4xpNGQoOYG0M3Dn1Y7s=.4666e474-e104-43cc-9680-9d980260ad12@github.com>
References: <1f-Y1noCKQ3rL7KSJOPRswNG4xpNGQoOYG0M3Dn1Y7s=.4666e474-e104-43cc-9680-9d980260ad12@github.com>
Message-ID: <oxGPvvUWsoD01L42QaLiSK-yb9yI2M1WZWoIVxmuwkE=.179da59d-6f40-45eb-b1ce-ca381490ae7e@github.com>

On Mon, 23 Sep 2024 14:30:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Resolve the error:
> 
> PassFailJFrame.java:161: error: text not allowed in <ul> element
>  *     <li>to add a log area</li>,
>                                  ^
> 
> 
> Shorten the rendered javadoc for `log`, `logClear` and `logSet`.
> 
> @azvegint, could you take a look?

This pull request has now been integrated.

Changeset: 833ff299
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/833ff29983e0d433ccd4c7e946b15e42045faeaa
Stats:     9 lines in 1 file changed: 4 ins; 0 del; 5 mod

8340461: Amend description for logArea

Reviewed-by: azvegint, prr

-------------

PR: https://git.openjdk.org/jdk/pull/21138

From prr at openjdk.org  Mon Sep 23 18:29:43 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 23 Sep 2024 18:29:43 GMT
Subject: Integrated: 8340411: open source several 2D imaging tests
In-Reply-To: <PG3yJ3autwvRlyLp8YMrl4mxPNtByugQdydq9aLdnJU=.e8f9e35c-5542-410b-a9ae-4ea5ecbc8cc5@github.com>
References: <PG3yJ3autwvRlyLp8YMrl4mxPNtByugQdydq9aLdnJU=.e8f9e35c-5542-410b-a9ae-4ea5ecbc8cc5@github.com>
Message-ID: <S_Ut5EHb76UgicBahk6hJZ1goGmZm68RFvD5_nvZI1w=.b70259bd-1497-4148-83dc-6665b7e903e7@github.com>

On Fri, 20 Sep 2024 17:07:31 GMT, Phil Race <prr at openjdk.org> wrote:

> open source several 2d imaging related tests.

This pull request has now been integrated.

Changeset: 8dcf7b8f
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8dcf7b8fa7b17bf34c62c561c6ed78e8080df1ff
Stats:     485 lines in 4 files changed: 485 ins; 0 del; 0 mod

8340411: open source several 2D imaging tests

Reviewed-by: azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/21113

From prr at openjdk.org  Mon Sep 23 18:31:37 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 23 Sep 2024 18:31:37 GMT
Subject: RFR: 8340365: Position the first window of a window list
In-Reply-To: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
References: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
Message-ID: <5h-0TuymzAYRn8c7HLxBUtHzmDP0FRcSMbnmpNhXlZs=.f1bc9cbf-f4f0-45ec-9393-74f43aec7b45@github.com>

On Wed, 18 Sep 2024 12:05:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Support of multiple test UI windows in `PassFailJFrame` is still evolving. After [JDK-8340210](https://bugs.openjdk.org/browse/JDK-8340210), the `Builder` has a method `positionTestUI` to supply an implementation of the `PositionWindows` interface which handles the positioning of all test UI windows created.
> 
> If `PositionWindows` is not provided, all the test UI windows are left with the default coordinates: (0, 0).
> 
> If `PassFailJFrame` called `positionTestWindow` for the first window, it would allow the test developer to position other windows based on the position of the first one.
> 
> This issue was raised in #21029 in [this thread of comments](https://github.com/openjdk/jdk/pull/21029#discussion_r1763744407).
> 
> To make it easier to position multiple test UI windows without implementing the `PositionWindows` interface, the `PassFailJFrame` should position the first window of the list.
> 
> The `LotsOfMenuItemsTest.java` test in #21029 had to hard-code the coordinates or use `PassFailJFrame.positionTestWindow` explicitly in its `ComponentListener.componentShown`.
> 
> With the proposed change in this pull request, the implementation would use `ComponentListener.componentMoved`:
> 
> 
>     @Override
>     public void componentMoved(ComponentEvent e) {
>         testFrame.setLocation(firstFrame.getX(),
>                               firstFrame.getY() + firstFrame.getHeight() + 8);
>     }
> 
> 
> This has the advantage in that the test UI windows don't flicker for a short time in the upper left corner of the screen; and the developer has to handle only positioning the second window (frame).
> 
> However, this has a funny effect: if you move the first frame with mouse or in any other way, the second frame follows. To avoid such kind of behaviour, call `removeComponentListener` in the handler.
> 
> @honkar-jdk, @azvegint, could you take a look?

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21057#pullrequestreview-2323024259

From aivanov at openjdk.org  Mon Sep 23 18:34:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Sep 2024 18:34:38 GMT
Subject: Integrated: 8340365: Position the first window of a window list
In-Reply-To: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
References: <QBv-Qv_RxZgCqITKwrFFNbBb4rYGXb7dI_3MsBJ2TFU=.db4be0a0-c6e2-47e1-9a85-6b46432b660c@github.com>
Message-ID: <YmjO5bOtHBlNuN8CP8BtL8oTXxqZqudlCTX-UyP-Dv8=.b42cc3a5-0799-48d7-8a7a-e0e4ce6b2572@github.com>

On Wed, 18 Sep 2024 12:05:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Support of multiple test UI windows in `PassFailJFrame` is still evolving. After [JDK-8340210](https://bugs.openjdk.org/browse/JDK-8340210), the `Builder` has a method `positionTestUI` to supply an implementation of the `PositionWindows` interface which handles the positioning of all test UI windows created.
> 
> If `PositionWindows` is not provided, all the test UI windows are left with the default coordinates: (0, 0).
> 
> If `PassFailJFrame` called `positionTestWindow` for the first window, it would allow the test developer to position other windows based on the position of the first one.
> 
> This issue was raised in #21029 in [this thread of comments](https://github.com/openjdk/jdk/pull/21029#discussion_r1763744407).
> 
> To make it easier to position multiple test UI windows without implementing the `PositionWindows` interface, the `PassFailJFrame` should position the first window of the list.
> 
> The `LotsOfMenuItemsTest.java` test in #21029 had to hard-code the coordinates or use `PassFailJFrame.positionTestWindow` explicitly in its `ComponentListener.componentShown`.
> 
> With the proposed change in this pull request, the implementation would use `ComponentListener.componentMoved`:
> 
> 
>     @Override
>     public void componentMoved(ComponentEvent e) {
>         testFrame.setLocation(firstFrame.getX(),
>                               firstFrame.getY() + firstFrame.getHeight() + 8);
>     }
> 
> 
> This has the advantage in that the test UI windows don't flicker for a short time in the upper left corner of the screen; and the developer has to handle only positioning the second window (frame).
> 
> However, this has a funny effect: if you move the first frame with mouse or in any other way, the second frame follows. To avoid such kind of behaviour, call `removeComponentListener` in the handler.
> 
> @honkar-jdk, @azvegint, could you take a look?

This pull request has now been integrated.

Changeset: e97f0fe1
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e97f0fe1b4046bfcc40e85ba1bee4f4c40053300
Stats:     3 lines in 1 file changed: 0 ins; 2 del; 1 mod

8340365: Position the first window of a window list

Reviewed-by: azvegint, prr

-------------

PR: https://git.openjdk.org/jdk/pull/21057

From prr at openjdk.org  Mon Sep 23 18:37:35 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 23 Sep 2024 18:37:35 GMT
Subject: RFR: 8340228: Open source couple more miscellaneous AWT tests
In-Reply-To: <GCL1sMFO9DhSYhDnE02xoO-H607Bu-zH_U6YLOfpk5I=.c6f84457-4752-4758-9007-003a636bfbbf@github.com>
References: <GCL1sMFO9DhSYhDnE02xoO-H607Bu-zH_U6YLOfpk5I=.c6f84457-4752-4758-9007-003a636bfbbf@github.com>
Message-ID: <BJEAHF1YTF2M89hmR8dlsrsRH1iOSCv7QyPhi34_Yqc=.37d879c0-ad65-4314-a47d-8b650b03eff3@github.com>

On Thu, 19 Sep 2024 22:31:24 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Cleaning up and opensourcing three more tests.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21097#pullrequestreview-2323036132

From prr at openjdk.org  Mon Sep 23 18:44:35 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 23 Sep 2024 18:44:35 GMT
Subject: RFR: 8340433: Open source closed choice tests #3
In-Reply-To: <bkuFu9a7K35iiT58GCiPFGwsQwQDXBiqZ8gwNz85rhk=.ddda876b-9987-4d54-bc4f-b1710b04df2d@github.com>
References: <bkuFu9a7K35iiT58GCiPFGwsQwQDXBiqZ8gwNz85rhk=.ddda876b-9987-4d54-bc4f-b1710b04df2d@github.com>
Message-ID: <jwVZbm1MchmoCpg3zu4lzTDgtFdyN6ki3MKiYDkQUR0=.c4771b8e-4fe1-4843-88e8-4e6b9d23ff9d@github.com>

On Fri, 20 Sep 2024 09:53:00 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> few more tests to open source
> 
> Testing is good.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21107#pullrequestreview-2323049215

From aivanov at openjdk.org  Mon Sep 23 20:45:44 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Sep 2024 20:45:44 GMT
Subject: RFR: 8340466: Add descriptions for PassFailJFrame constructors
Message-ID: <YDqxPeO0ID6Xf_JF-oHqYOtgWfCVY93sP2AeoiFnOoM=.ff6f613d-30f0-4a90-bc7d-1f6c6fe2665a@github.com>

I added description to all the constructors available in `PassFailJFrame`.

I generated the javadoc for it: [`PassFailJFrame/api`](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html) which is easier to read. This hosted javadoc could be used as a reference to its API.

The constructor with the largest number of parameters contains a short description of how to use the `PassFailJFrame` object.

Shall we deprecate the constructors in favour of `Builder`?

The builder provides a more streamlined experience, therefore new tests should use it instead of constructors. We may update the tests which use the constructors, after which the constructors can be removed.

-------------

Commit messages:
 - Describe the remaining PassFailJFrame constructors
 - Describe PassFailJFrame(title, instructions, timeOut)
 - Put EDT into <dfn> tags where it's introduced
 - Re-flow constructor parameters at timeout, wrap entire throws clause
 - Re-write description of PassFailJFrame constructor without screenshots
 - Re-write description of PassFailJFrame constructor with screenshots
 - Replace plain `&` in javadocs with `&amp;`

Changes: https://git.openjdk.org/jdk/pull/21145/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21145&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340466
  Stats: 154 lines in 1 file changed: 97 ins; 14 del; 43 mod
  Patch: https://git.openjdk.org/jdk/pull/21145.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21145/head:pull/21145

PR: https://git.openjdk.org/jdk/pull/21145

From prr at openjdk.org  Mon Sep 23 20:52:35 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 23 Sep 2024 20:52:35 GMT
Subject: RFR: 8339836: Open source several AWT Mouse tests - Batch 1
In-Reply-To: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>
References: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>
Message-ID: <wj0_It75St5lYRMOH-e92Uj7fQXhC02qCsBGVu2_AVY=.f44144cd-69a7-47d6-8ab4-7492d4ac2254@github.com>

On Mon, 23 Sep 2024 04:56:43 GMT, Tejesh R <tr at openjdk.org> wrote:

> Open source these AWT Mouse tests:
> 
> java/awt/Mouse/MouseEnterExitTest.java
> java/awt/Mouse/MouseEnterExitTest2.java
> java/awt/Mouse/MousePressedTest.java
> java/awt/Mouse/MouseEnterExitTest4.java
> java/awt/Mouse/MouseEnterExitTest3.java

test/jdk/java/awt/Mouse/MouseEnterExitTest.java line 46:

> 44:  * @summary Test to verify Lightweight components don't get
> 45:  *          enter/exit during drags
> 46:  * @library /java/awt/regtesthelpers

Can't the drag be done by Robot to make this an automated test ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21124#discussion_r1772059227

From duke at openjdk.org  Tue Sep 24 00:59:37 2024
From: duke at openjdk.org (toshiogata)
Date: Tue, 24 Sep 2024 00:59:37 GMT
Subject: RFR: 8337851: Some tests have name which confuse jtreg [v3]
In-Reply-To: <UQeiy7wEZjrXxCuhOcOEssL1XKlTFAAwS2qUdzuvLBs=.13b82d2a-e074-46a3-8730-6ea18e8a43bf@github.com>
References: <NglaDEADAHmN4v7TUvv7YxzZeFFawp9l96gFu2EWR3A=.f01b2a1b-ec59-4170-99bf-8d407bfdd03f@github.com>
 <hw2ar_bTsYWoUYRwApfmTSdoaWSRZz25mbs6-uU4iP8=.c2c3aa48-96ac-4d41-a413-9dc83556e6f2@github.com>
 <pCVdEUx0veIrZOzWK6Q-v9mfX98I_mirvqrOPybayyE=.53bdd20c-7723-4243-94e8-d52dcb3892ab@github.com>
 <UQeiy7wEZjrXxCuhOcOEssL1XKlTFAAwS2qUdzuvLBs=.13b82d2a-e074-46a3-8730-6ea18e8a43bf@github.com>
Message-ID: <fFJQlcs5vLsVKQTfdkws1uvf8My2vG9YfTXouF7XDm0=.e799ab93-7d90-47ef-851e-1faeb822cf34@github.com>

On Fri, 23 Aug 2024 22:36:51 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Moving files from one directory to another can sometimes be a bit risky, especially for `javac` tests, because that implies moving the classes from one unnamed package to a different unnamed package.
>> 
>> Please confirm that all tests under `test/langtools/tools/javac` continue to pass after the files have been moved. You can either run just those tests, or run all langtools `tier1` tests if that is easier.
>
>> > @jonathan-gibbons Is this a bug in jtreg, or where these files actually improperly named?
>> 
>> Not a bug as such, but maybe a little-known misfeature. `jtreg` has always had problems with filenames that could cause confusion, and the general sense has generally been, "if it hurts, don't do it!". That being said, our overall library API and infrastructure is way better these days than in times past, and it might be reasonable to file an Enhancement for `jtreg` to have a utility/check/test to detect these anomalous situations.
>> 
>> In the meantime, renaming the files to avoid the problem is the recommended solution.
> 
> Filed https://bugs.openjdk.org/browse/CODETOOLS-7903803

@jonathan-gibbons 
I was wondering if you have had a chance to see my response and aivanov-jdk's question. I would appreciate your reaction. Thank you.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20475#issuecomment-2369886576

From psadhukhan at openjdk.org  Tue Sep 24 02:10:47 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 24 Sep 2024 02:10:47 GMT
Subject: Integrated: 8339995: Open source several AWT focus tests - series 6
In-Reply-To: <x2ZMBdtKL5Vl6Ttilo5YR4UGKKrXfm5rN-VnulWIjT4=.adef4881-a709-4756-9160-5785f2d3ea4f@github.com>
References: <x2ZMBdtKL5Vl6Ttilo5YR4UGKKrXfm5rN-VnulWIjT4=.adef4881-a709-4756-9160-5785f2d3ea4f@github.com>
Message-ID: <4ELUqfhw-49Oy_3CunDT7Us4C85mdkttirXbVl0Keyk=.855dc3c4-dbf3-4c78-9372-c765482628c5@github.com>

On Thu, 19 Sep 2024 05:25:17 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few Focus tests

This pull request has now been integrated.

Changeset: 3411f9df
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3411f9dff79c2e7cb7ce8ebf036f8b3fd9bb647d
Stats:     580 lines in 5 files changed: 580 ins; 0 del; 0 mod

8339995: Open source several AWT focus tests - series 6

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/21079

From psadhukhan at openjdk.org  Tue Sep 24 02:12:45 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 24 Sep 2024 02:12:45 GMT
Subject: Integrated: 8340367: Opensource few AWT image tests
In-Reply-To: <P8HjYF8P5RZA8rHbvrwphv7piP2VNBlOa1QhFWTb9to=.04ff770d-03eb-4c9e-b5be-0687b1fd8ccd@github.com>
References: <P8HjYF8P5RZA8rHbvrwphv7piP2VNBlOa1QhFWTb9to=.04ff770d-03eb-4c9e-b5be-0687b1fd8ccd@github.com>
Message-ID: <WfwM6JvEnqYwDpDXXiM7DWDsj9rFpBZUQnLHegVZPrs=.3bf06dd4-4278-4ee2-b9d5-96d8bd1d8eda@github.com>

On Fri, 20 Sep 2024 03:58:20 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few image tests

This pull request has now been integrated.

Changeset: 6c91a16f
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/6c91a16f16cbeb1bb0a79459e7db1fd9f576e743
Stats:     513 lines in 5 files changed: 513 ins; 0 del; 0 mod

8340367: Opensource few AWT image tests

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/21104

From psadhukhan at openjdk.org  Tue Sep 24 02:17:26 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 24 Sep 2024 02:17:26 GMT
Subject: RFR: 8339935: Open source several AWT focus tests - series 5 [v2]
In-Reply-To: <C5Hbi8kSA7LtRpdEEDIcUnyGqZ-d96gC-1uAAIJ8zEI=.c63ee9c0-3ac5-4ccf-a656-7dd7b65f263b@github.com>
References: <9CBDlYAA5yUeyovwlZ8wpQ5fEE6YIXMUUt53BVb-JbU=.9f8c5c39-2e90-4d6a-868f-734cea42367e@github.com>
 <C5Hbi8kSA7LtRpdEEDIcUnyGqZ-d96gC-1uAAIJ8zEI=.c63ee9c0-3ac5-4ccf-a656-7dd7b65f263b@github.com>
Message-ID: <wc1ssJnYiUjZlMe9hRGM1z0KiE9HQ4TBmVqx-bHAhQ4=.96c55a5c-22d6-4ac8-86dd-f6b7ae3509b4@github.com>

On Mon, 23 Sep 2024 18:03:52 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> test/jdk/java/awt/Focus/ProxiedWindowHideTest.java line 27:
> 
>> 25:  * @test
>> 26:  * @bug 4396407
>> 27:  * @summary Tests that after proxied window were hidden focus is being restored correctly
> 
> ... after a proxied window is hidden ...

ok..fixed...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21103#discussion_r1772468601

From psadhukhan at openjdk.org  Tue Sep 24 02:17:26 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 24 Sep 2024 02:17:26 GMT
Subject: RFR: 8339935: Open source several AWT focus tests - series 5 [v2]
In-Reply-To: <9CBDlYAA5yUeyovwlZ8wpQ5fEE6YIXMUUt53BVb-JbU=.9f8c5c39-2e90-4d6a-868f-734cea42367e@github.com>
References: <9CBDlYAA5yUeyovwlZ8wpQ5fEE6YIXMUUt53BVb-JbU=.9f8c5c39-2e90-4d6a-868f-734cea42367e@github.com>
Message-ID: <efinAJ1vjfInLf5TnlC5EYkiN21f3JkKcOhxB0esfXQ=.df460eaf-246f-478e-952d-1c345f694326@github.com>

> Opensource few AWT focus tests

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Review fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21103/files
  - new: https://git.openjdk.org/jdk/pull/21103/files/dfe88b09..df628978

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21103&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21103&range=00-01

  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/21103.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21103/head:pull/21103

PR: https://git.openjdk.org/jdk/pull/21103

From psadhukhan at openjdk.org  Tue Sep 24 02:34:37 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 24 Sep 2024 02:34:37 GMT
Subject: RFR: 8339982: Open source several AWT Mouse tests - Batch 2
In-Reply-To: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
References: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
Message-ID: <m4uLPIscC3KjE7tlnE9SmfrBCqxaKrr6bFe7R77Z2as=.7294a40b-5a91-423f-9e0e-611914da08ca@github.com>

On Mon, 23 Sep 2024 06:40:55 GMT, Tejesh R <tr at openjdk.org> wrote:

> Open source these AWT Mouse and GraphicsEnvironment tests:
> 
> java/awt/MouseClickCount/MouseClickCount.java
> java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java
> java/awt/MouseDragTest/MouseDragTest.java
> java/awt/OpenWinDoubleClickTest/OpenWinDoubleClickTest.java
> java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java

test/jdk/java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java line 43:

> 41:  *          returning first screen
> 42:  * @requires (os.family == "windows")
> 43:  * @library /open/test/jdk/java/awt/regtesthelpers

Seems like you have not tested these tests after opensourcing...Please adjust to correct path for all the tests..

test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 98:

> 96: 
> 97:     public void mousePressed(MouseEvent e) {
> 98:     }

I guess if you use MouseAdapter instead of MouseListener, then you only have to provide implementation for the method you need, not for all..

test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 128:

> 126:         if (e.getID() == MouseEvent.MOUSE_EXITED)
> 127:             type = "MOUSE_EXITED";
> 128: 

MOUSE_ENTERED is used twice...Also, it seems you are only printing MouseExit/Enter so other types can be deleted..

test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 168:

> 166:     public void mouseClicked(MouseEvent e) {
> 167:     }
> 168: 

same here...MouseAdapter...

test/jdk/java/awt/Mouse/OpenWinDoubleClickTest.java line 38:

> 36:  * @library /open/test/jdk/java/awt/regtesthelpers
> 37:  * @build PassFailJFrame
> 38:  * @run main/manual OpenWinDoubleClickTest

Guess we decided to rename this test...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772472012
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772475894
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772476755
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772477852
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772472446

From psadhukhan at openjdk.org  Tue Sep 24 02:56:35 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 24 Sep 2024 02:56:35 GMT
Subject: RFR: 8340143: Open source several Java2D rendering loop tests.
In-Reply-To: <esjs4KwtSHviWVCI0rlJBIrkICCZf6HfB_313L_Ouq0=.4949fb2f-9c87-43a9-9a71-c11a31149177@github.com>
References: <esjs4KwtSHviWVCI0rlJBIrkICCZf6HfB_313L_Ouq0=.4949fb2f-9c87-43a9-9a71-c11a31149177@github.com>
Message-ID: <wjof5b8Po8KiWK9itnKH7_VeAvjhpFaUPgSFuNmAj2g=.3b1e3238-9cc6-4e1d-aa46-3056f3de4fcd@github.com>

On Fri, 20 Sep 2024 23:27:11 GMT, Phil Race <prr at openjdk.org> wrote:

> Open source some Java2d loop rendering tests.

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21114#pullrequestreview-2323886695

From tr at openjdk.org  Tue Sep 24 04:10:33 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 24 Sep 2024 04:10:33 GMT
Subject: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v2]
In-Reply-To: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
References: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
Message-ID: <w0q9dW-IxSeHnbVvAUfYBYt-bolYbLh7A96psE6zKIs=.98bea943-ebdc-4566-9470-05eef40d9406@github.com>

> Open source these AWT Mouse and GraphicsEnvironment tests:
> 
> java/awt/MouseClickCount/MouseClickCount.java
> java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java
> java/awt/MouseDragTest/MouseDragTest.java
> java/awt/OpenWinDoubleClickTest/OpenWinDoubleClickTest.java
> java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java

Tejesh R has updated the pull request incrementally with two additional commits since the last revision:

 - Renamed OpenWinDoubleClickTest to DoubleClickTest
 - jtreg updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21126/files
  - new: https://git.openjdk.org/jdk/pull/21126/files/0f491e0c..d2bd742e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21126&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21126&range=00-01

  Stats: 8 lines in 5 files changed: 0 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/21126.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21126/head:pull/21126

PR: https://git.openjdk.org/jdk/pull/21126

From tr at openjdk.org  Tue Sep 24 04:10:35 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 24 Sep 2024 04:10:35 GMT
Subject: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v2]
In-Reply-To: <m4uLPIscC3KjE7tlnE9SmfrBCqxaKrr6bFe7R77Z2as=.7294a40b-5a91-423f-9e0e-611914da08ca@github.com>
References: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
 <m4uLPIscC3KjE7tlnE9SmfrBCqxaKrr6bFe7R77Z2as=.7294a40b-5a91-423f-9e0e-611914da08ca@github.com>
Message-ID: <HH77X9MghnarhhGDdkIPE82z8qtICSgrBug9sdeYZcU=.99124d22-4122-43ec-8ddd-23fda3e7bddc@github.com>

On Tue, 24 Sep 2024 02:20:03 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Renamed OpenWinDoubleClickTest to DoubleClickTest
>>  - jtreg updates
>
> test/jdk/java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java line 43:
> 
>> 41:  *          returning first screen
>> 42:  * @requires (os.family == "windows")
>> 43:  * @library /open/test/jdk/java/awt/regtesthelpers
> 
> Seems like you have not tested these tests after opensourcing...Please adjust to correct path for all the tests..

Had missed to commit and push here.

> test/jdk/java/awt/Mouse/OpenWinDoubleClickTest.java line 38:
> 
>> 36:  * @library /open/test/jdk/java/awt/regtesthelpers
>> 37:  * @build PassFailJFrame
>> 38:  * @run main/manual OpenWinDoubleClickTest
> 
> Guess we decided to rename this test...

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772553805
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772553955

From rgupta at openjdk.org  Tue Sep 24 04:22:42 2024
From: rgupta at openjdk.org (Ravi Gupta)
Date: Tue, 24 Sep 2024 04:22:42 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v11]
In-Reply-To: <qt1TqbEVk_Y1g5-XOSbd4L8khlM7mlY3SqomRss4DHM=.428750c0-bc08-4426-a74c-1d1e6abac2df@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <qt1TqbEVk_Y1g5-XOSbd4L8khlM7mlY3SqomRss4DHM=.428750c0-bc08-4426-a74c-1d1e6abac2df@github.com>
Message-ID: <UUH6iJYSwz_TZytAiGGFDaJM08QO1S193BJ-9wyX6OQ=.7faa9d34-1bf7-402b-85b9-474f6e699c77@github.com>

On Mon, 23 Sep 2024 04:19:20 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:

>> This testcase checks for the following assertions for Component events:
>> 
>> 1. When components are resized, moved, hidden and shown the respective events are triggered.
>> 2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
>> 3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
>> 4. When a window is minimized/restored then hidden and shown component events should be triggered.
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.
>
> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8333403: Review Comments Fixed

I ran CI job with the latest code it passes without failure.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19521#issuecomment-2370118834

From duke at openjdk.org  Tue Sep 24 04:31:36 2024
From: duke at openjdk.org (duke)
Date: Tue, 24 Sep 2024 04:31:36 GMT
Subject: RFR: 8333403: Write a test to check various components events are
 triggered properly [v11]
In-Reply-To: <qt1TqbEVk_Y1g5-XOSbd4L8khlM7mlY3SqomRss4DHM=.428750c0-bc08-4426-a74c-1d1e6abac2df@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
 <qt1TqbEVk_Y1g5-XOSbd4L8khlM7mlY3SqomRss4DHM=.428750c0-bc08-4426-a74c-1d1e6abac2df@github.com>
Message-ID: <6s2YVn1i--3tECwgOHftmvquR3QopmNTPmp3eqHUdC8=.5c507dd6-827b-48b4-9462-3724180a2272@github.com>

On Mon, 23 Sep 2024 04:19:20 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:

>> This testcase checks for the following assertions for Component events:
>> 
>> 1. When components are resized, moved, hidden and shown the respective events are triggered.
>> 2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
>> 3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
>> 4. When a window is minimized/restored then hidden and shown component events should be triggered.
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.
>
> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8333403: Review Comments Fixed

@ravigupta30 
Your change (at version fe35276b9185f2ac4cd54d73cecb0904c9dfb5d5) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19521#issuecomment-2370126937

From tr at openjdk.org  Tue Sep 24 04:38:05 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 24 Sep 2024 04:38:05 GMT
Subject: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v3]
In-Reply-To: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
References: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
Message-ID: <ffzdwgSpT9gIvql9TPlCsvwWXKhpCwjccALBq_priEs=.2c024097-5677-4cf7-ad3e-66c72600cb64@github.com>

> Open source these AWT Mouse and GraphicsEnvironment tests:
> 
> java/awt/MouseClickCount/MouseClickCount.java
> java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java
> java/awt/MouseDragTest/MouseDragTest.java
> java/awt/OpenWinDoubleClickTest/OpenWinDoubleClickTest.java
> java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review comments updated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21126/files
  - new: https://git.openjdk.org/jdk/pull/21126/files/d2bd742e..6c274e31

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21126&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21126&range=01-02

  Stats: 120 lines in 1 file changed: 21 ins; 93 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/21126.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21126/head:pull/21126

PR: https://git.openjdk.org/jdk/pull/21126

From tr at openjdk.org  Tue Sep 24 04:38:06 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 24 Sep 2024 04:38:06 GMT
Subject: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v3]
In-Reply-To: <m4uLPIscC3KjE7tlnE9SmfrBCqxaKrr6bFe7R77Z2as=.7294a40b-5a91-423f-9e0e-611914da08ca@github.com>
References: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
 <m4uLPIscC3KjE7tlnE9SmfrBCqxaKrr6bFe7R77Z2as=.7294a40b-5a91-423f-9e0e-611914da08ca@github.com>
Message-ID: <y7rrFOgjpEpysH4jkiXYrPegsAMBOK9rps7te9XbSh8=.eb0de062-63dd-49d8-84c2-cf2df231b32c@github.com>

On Tue, 24 Sep 2024 02:27:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments updated
>
> test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 98:
> 
>> 96: 
>> 97:     public void mousePressed(MouseEvent e) {
>> 98:     }
> 
> I guess if you use MouseAdapter instead of MouseListener, then you only have to provide implementation for the method you need, not for all..

Yes, good one. Have updated.

> test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 128:
> 
>> 126:         if (e.getID() == MouseEvent.MOUSE_EXITED)
>> 127:             type = "MOUSE_EXITED";
>> 128: 
> 
> MOUSE_ENTERED is used twice...Also, it seems you are only printing MouseExit/Enter so other types can be deleted..

Updated.

> test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 168:
> 
>> 166:     public void mouseClicked(MouseEvent e) {
>> 167:     }
>> 168: 
> 
> same here...MouseAdapter...

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772571883
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772571943
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772572019

From psadhukhan at openjdk.org  Tue Sep 24 05:53:40 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 24 Sep 2024 05:53:40 GMT
Subject: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v3]
In-Reply-To: <ffzdwgSpT9gIvql9TPlCsvwWXKhpCwjccALBq_priEs=.2c024097-5677-4cf7-ad3e-66c72600cb64@github.com>
References: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
 <ffzdwgSpT9gIvql9TPlCsvwWXKhpCwjccALBq_priEs=.2c024097-5677-4cf7-ad3e-66c72600cb64@github.com>
Message-ID: <VGPQYaANteE-BEcRw0Djz3f6ZwMM4aVIfcUvUSA03zc=.9d81ff04-933e-4a2f-9b0f-b8dd73d2f723@github.com>

On Tue, 24 Sep 2024 04:38:05 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Open source these AWT Mouse and GraphicsEnvironment tests:
>> 
>> java/awt/MouseClickCount/MouseClickCount.java
>> java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java
>> java/awt/MouseDragTest/MouseDragTest.java
>> java/awt/OpenWinDoubleClickTest/OpenWinDoubleClickTest.java
>> java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments updated

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 68:

> 66: 
> 67:         addMouseListener(new MouseAdapter() {
> 68:             public void mouseEntered(MouseEvent e) {

you can add @Override

-------------

PR Review: https://git.openjdk.org/jdk/pull/21126#pullrequestreview-2324125907
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772667730

From tr at openjdk.org  Tue Sep 24 06:07:19 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 24 Sep 2024 06:07:19 GMT
Subject: RFR: 8339836: Open source several AWT Mouse tests - Batch 1 [v2]
In-Reply-To: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>
References: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>
Message-ID: <dpbUNC1PFWZO82DMZ_JrSuWfwDc8VI264YVgrhJ_o54=.1db6f649-78b5-4630-8780-92c93f9fe37f@github.com>

> Open source these AWT Mouse tests:
> 
> java/awt/Mouse/MouseEnterExitTest.java
> java/awt/Mouse/MouseEnterExitTest2.java
> java/awt/Mouse/MousePressedTest.java
> java/awt/Mouse/MouseEnterExitTest4.java
> java/awt/Mouse/MouseEnterExitTest3.java

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  MouseEnterExitTest converted to automated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21124/files
  - new: https://git.openjdk.org/jdk/pull/21124/files/8819524b..440905cb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21124&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21124&range=00-01

  Stats: 106 lines in 1 file changed: 24 ins; 60 del; 22 mod
  Patch: https://git.openjdk.org/jdk/pull/21124.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21124/head:pull/21124

PR: https://git.openjdk.org/jdk/pull/21124

From tr at openjdk.org  Tue Sep 24 06:07:20 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 24 Sep 2024 06:07:20 GMT
Subject: RFR: 8339836: Open source several AWT Mouse tests - Batch 1 [v2]
In-Reply-To: <wj0_It75St5lYRMOH-e92Uj7fQXhC02qCsBGVu2_AVY=.f44144cd-69a7-47d6-8ab4-7492d4ac2254@github.com>
References: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>
 <wj0_It75St5lYRMOH-e92Uj7fQXhC02qCsBGVu2_AVY=.f44144cd-69a7-47d6-8ab4-7492d4ac2254@github.com>
Message-ID: <CzxtTgndCWD5IpQkqtfUHZVpPk4pMFiRX2ICB0XVxns=.4aa893a4-bd8e-438d-87a5-ea8c3a0fe616@github.com>

On Mon, 23 Sep 2024 20:49:54 GMT, Phil Race <prr at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   MouseEnterExitTest converted to automated
>
> test/jdk/java/awt/Mouse/MouseEnterExitTest.java line 46:
> 
>> 44:  * @summary Test to verify Lightweight components don't get
>> 45:  *          enter/exit during drags
>> 46:  * @library /java/awt/regtesthelpers
> 
> Can't the drag be done by Robot to make this an automated test ?

Yes, converted to automated test. Tested in CI too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21124#discussion_r1772680704

From tr at openjdk.org  Tue Sep 24 06:29:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 24 Sep 2024 06:29:21 GMT
Subject: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v4]
In-Reply-To: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
References: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
Message-ID: <YPL9iPnYVjmQ04mraSLhysttnmAmbrQ5Qpo9dL-9Fa4=.85a98d94-32d5-4f29-8f73-cdcbdcce3196@github.com>

> Open source these AWT Mouse and GraphicsEnvironment tests:
> 
> java/awt/MouseClickCount/MouseClickCount.java
> java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java
> java/awt/MouseDragTest/MouseDragTest.java
> java/awt/OpenWinDoubleClickTest/OpenWinDoubleClickTest.java
> java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review comments updated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21126/files
  - new: https://git.openjdk.org/jdk/pull/21126/files/6c274e31..1c8c5efb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21126&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21126&range=02-03

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21126.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21126/head:pull/21126

PR: https://git.openjdk.org/jdk/pull/21126

From tr at openjdk.org  Tue Sep 24 06:29:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 24 Sep 2024 06:29:21 GMT
Subject: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v3]
In-Reply-To: <VGPQYaANteE-BEcRw0Djz3f6ZwMM4aVIfcUvUSA03zc=.9d81ff04-933e-4a2f-9b0f-b8dd73d2f723@github.com>
References: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
 <ffzdwgSpT9gIvql9TPlCsvwWXKhpCwjccALBq_priEs=.2c024097-5677-4cf7-ad3e-66c72600cb64@github.com>
 <VGPQYaANteE-BEcRw0Djz3f6ZwMM4aVIfcUvUSA03zc=.9d81ff04-933e-4a2f-9b0f-b8dd73d2f723@github.com>
Message-ID: <wCMrqBtfiHjpek-JuJAxJQLcWnnCKUOdVV9t4U-yk9g=.4679822f-d47d-4160-8889-3c11dd4892f8@github.com>

On Tue, 24 Sep 2024 05:49:39 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments updated
>
> test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 68:
> 
>> 66: 
>> 67:         addMouseListener(new MouseAdapter() {
>> 68:             public void mouseEntered(MouseEvent e) {
> 
> you can add @Override

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772703060

From abhiscxk at openjdk.org  Tue Sep 24 07:52:01 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 24 Sep 2024 07:52:01 GMT
Subject: RFR: 8340605: Open source several AWT PopupMenu tests
Message-ID: <s2yEIJ_5shNyXnWKgQnKypsUp-wNVwjHQBXYW0Q8I88=.f47e4717-c72d-4ded-838c-cefd6f852209@github.com>

Several AWT PopupMEnu related tests are converted from applet to manual and moved to open.

-------------

Commit messages:
 - Test moved to open

Changes: https://git.openjdk.org/jdk/pull/21151/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21151&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340605
  Stats: 432 lines in 5 files changed: 432 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21151.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21151/head:pull/21151

PR: https://git.openjdk.org/jdk/pull/21151

From duke at openjdk.org  Tue Sep 24 12:19:37 2024
From: duke at openjdk.org (Daniel Gredler)
Date: Tue, 24 Sep 2024 12:19:37 GMT
Subject: RFR: 8339974: Graphics2D.drawString doesn't always work with Font
 derived from AffineTransform [v2]
In-Reply-To: <8wAz3aLdxXQrWuQtLvRXEtJ7ODGOGsuDE2QW465A05k=.5ed6a47d-e07f-400d-9566-70e4f6ecb8b2@github.com>
References: <kFBgZ5CM0uq7As9MMN2dDMuWcv24SA1gQvfxCsFu9n0=.80c106f5-a525-4255-bf57-887407ca050e@github.com>
 <8wAz3aLdxXQrWuQtLvRXEtJ7ODGOGsuDE2QW465A05k=.5ed6a47d-e07f-400d-9566-70e4f6ecb8b2@github.com>
Message-ID: <GRuc4Hed0oGAsLVoymq7nwxxMyQ2FTP-VxJSEsQqt6A=.ca407fb8-bdcf-4b64-835e-99f0666ac511@github.com>

On Fri, 13 Sep 2024 14:41:48 GMT, Daniel Gredler <duke at openjdk.org> wrote:

>> There is a bug in `TextLayout.getOutline(AffineTransform)`, where the transformation is applied too early (before the layout path applies its mapping). The most obvious error caused by this bug is that `Graphics2D.drawString(...)` fails to draw the string when using a rotated + scaled `AffineTransform` (see minimal test case in the bug report).
>> 
>> There are two uses of `TextLayout.getOutline(AffineTransform)`: the first one, triggered via a simple `Graphics2D.drawString(...)` was the one I ran into; the second one requires the use of a transformed font with a `PSPrinterJob`. Both are broken. This PR includes two test classes verifying that both scenarios were broken before the fix and are working after the fix.
>> 
>> Two points which might require some discussion:
>> 1. I've changed the signature of method `TextLine.getOutline(AffineTransform)`, to just `TextLine.getOutline()`; I'm assuming this is OK since `TextLine` is a package-private class.
>> 2. I've added a fast path in `TextLayout.getOutline(AffineTransform)` to transform the shape in place if it is a `GeneralPath` (it should usually be, and avoids an extra `Shape` copy vs. the current code, which makes no copy). A bit more complex, but efficient.
>
> Daniel Gredler has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add bug ID and summary to test classes

@prrace Do you have some time to review this PR? Would love to wrap this one up in the next week or two. Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20993#issuecomment-2371107247

From aivanov at openjdk.org  Tue Sep 24 15:56:17 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 24 Sep 2024 15:56:17 GMT
Subject: RFR: 8340785: Update description of PassFailJFrame and samples
Message-ID: <4U0oKfNqwC3u8g7SdPaeohdEGbrlCLG_sSruyRsRMvM=.70a2ab5f-38e6-49be-b01f-f4d213fc7980@github.com>

I re-worked the entire description of `PassFailJFrame`:

Add description of what UI elements it provides and how to interact with them.
Add anchors for linking to the sections.

Use `{@snippet}` instead of `<pre>{@code}</pre>` for sample code.
Use method references instead of lambdas in samples.
Document required jtreg tags to use `PassFailJFrame`.
Rename `SampleOldManualTest` to `ObsoleteManualTest`.

Provide an overview of `Builder` methods to configure `PassFailJFrame`.

As in #21145, the generated javadoc [PassFailJFrame.html](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html) could be easier to read and review.

The current version of the generated docs contains changes from #21145 and this PR. The PRs can be integrated independently.

-------------

Commit messages:
 - 8340785: Update description of PassFailJFrame and samples

Changes: https://git.openjdk.org/jdk/pull/21162/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21162&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340785
  Stats: 159 lines in 1 file changed: 126 ins; 0 del; 33 mod
  Patch: https://git.openjdk.org/jdk/pull/21162.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21162/head:pull/21162

PR: https://git.openjdk.org/jdk/pull/21162

From aivanov at openjdk.org  Tue Sep 24 16:03:41 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 24 Sep 2024 16:03:41 GMT
Subject: RFR: 8340785: Update description of PassFailJFrame and samples
In-Reply-To: <4U0oKfNqwC3u8g7SdPaeohdEGbrlCLG_sSruyRsRMvM=.70a2ab5f-38e6-49be-b01f-f4d213fc7980@github.com>
References: <4U0oKfNqwC3u8g7SdPaeohdEGbrlCLG_sSruyRsRMvM=.70a2ab5f-38e6-49be-b01f-f4d213fc7980@github.com>
Message-ID: <lzWFKySRgr1tU3gOQfUJ5yTusthxvNt63lM8HvduqHY=.13e9e1cc-4017-4db4-8312-09f3020f21c7@github.com>

On Tue, 24 Sep 2024 15:51:09 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I re-worked the entire description of `PassFailJFrame`:
> 
> Add description of what UI elements it provides and how to interact with them.
> Add anchors for linking to the sections.
> 
> Use `{@snippet}` instead of `<pre>{@code}</pre>` for sample code.
> Use method references instead of lambdas in samples.
> Document required jtreg tags to use `PassFailJFrame`.
> Rename `SampleOldManualTest` to `ObsoleteManualTest`.
> 
> Provide an overview of `Builder` methods to configure `PassFailJFrame`.
> 
> As in #21145, the generated javadoc [PassFailJFrame.html](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html) could be easier to read and review.
> 
> The current version of the generated docs contains changes from #21145 and this PR. The PRs can be integrated independently.

There are still some missing parts, like more details on different kinds of `testUI` overloads and support for multiple windows.

At the same time, the description is close to comprehensive, the javadoc comment for the `PassFailJFrame` takes more than 200 lines.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21162#issuecomment-2371711426

From aivanov at openjdk.org  Tue Sep 24 16:12:29 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 24 Sep 2024 16:12:29 GMT
Subject: RFR: 8340466: Add description for PassFailJFrame constructors [v2]
In-Reply-To: <YDqxPeO0ID6Xf_JF-oHqYOtgWfCVY93sP2AeoiFnOoM=.ff6f613d-30f0-4a90-bc7d-1f6c6fe2665a@github.com>
References: <YDqxPeO0ID6Xf_JF-oHqYOtgWfCVY93sP2AeoiFnOoM=.ff6f613d-30f0-4a90-bc7d-1f6c6fe2665a@github.com>
Message-ID: <d_1xzCt_n2o7bpsZDrgY3vjS69dX7HijTXoccZN10yk=.0a56094f-66d8-45e2-bbea-f0531b3d7101@github.com>

> I added description to all the constructors available in `PassFailJFrame`.
> 
> I generated the javadoc for it: [`PassFailJFrame` constructor details](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html#constructor-detail) which is easier to read. This hosted javadoc could be used as a reference to its API.
> 
> The constructor with the largest number of parameters contains a short description of how to use the `PassFailJFrame` object.
> 
> Shall we deprecate the constructors in favour of `Builder`?
> 
> The builder provides a more streamlined experience, therefore new tests should use it instead of constructors. We may update the tests which use the constructors, after which the constructors can be removed.

Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:

  Use EDT abbreviation in constructor description
  
  The term EDT (Event Dispatch Thread) is introduced in
  the top-level doc comment.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21145/files
  - new: https://git.openjdk.org/jdk/pull/21145/files/c36d4076..ff2e7f82

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21145&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21145&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21145.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21145/head:pull/21145

PR: https://git.openjdk.org/jdk/pull/21145

From prr at openjdk.org  Tue Sep 24 17:24:47 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 24 Sep 2024 17:24:47 GMT
Subject: RFR: 8340466: Add description for PassFailJFrame constructors [v2]
In-Reply-To: <d_1xzCt_n2o7bpsZDrgY3vjS69dX7HijTXoccZN10yk=.0a56094f-66d8-45e2-bbea-f0531b3d7101@github.com>
References: <YDqxPeO0ID6Xf_JF-oHqYOtgWfCVY93sP2AeoiFnOoM=.ff6f613d-30f0-4a90-bc7d-1f6c6fe2665a@github.com>
 <d_1xzCt_n2o7bpsZDrgY3vjS69dX7HijTXoccZN10yk=.0a56094f-66d8-45e2-bbea-f0531b3d7101@github.com>
Message-ID: <DYAJO58N7oW4ARdxow6HKusDodCoSGl9gJR7lnyWdRo=.56b269d9-6702-4853-9172-1fbd7b71126c@github.com>

On Tue, 24 Sep 2024 16:12:29 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I added description to all the constructors available in `PassFailJFrame`.
>> 
>> I generated the javadoc for it: [`PassFailJFrame` constructor details](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html#constructor-detail) which is easier to read. This hosted javadoc could be used as a reference to its API.
>> 
>> The constructor with the largest number of parameters contains a short description of how to use the `PassFailJFrame` object.
>> 
>> Shall we deprecate the constructors in favour of `Builder`?
>> 
>> The builder provides a more streamlined experience, therefore new tests should use it instead of constructors. We may update the tests which use the constructors, after which the constructors can be removed.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use EDT abbreviation in constructor description
>   
>   The term EDT (Event Dispatch Thread) is introduced in
>   the top-level doc comment.

Marked as reviewed by prr (Reviewer).

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 328:

> 326:      * <p>
> 327:      * After you create a test UI window, register the window using
> 328:      * {@link #addTestWindow(Window) addTestWindow} for disposing of, and

disposing of -> disposal

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 351:

> 349:      * If you enable screenshots by setting the {@code screenCapture}
> 350:      * parameter to {@code true}, a <i>Screenshot</i> button is added.
> 351:      * Clicking the <i>Screenshot</i> button, takes screenshot of

"screenshots"

-------------

PR Review: https://git.openjdk.org/jdk/pull/21145#pullrequestreview-2325912386
PR Review Comment: https://git.openjdk.org/jdk/pull/21145#discussion_r1773746225
PR Review Comment: https://git.openjdk.org/jdk/pull/21145#discussion_r1773748489

From prr at openjdk.org  Tue Sep 24 18:10:35 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 24 Sep 2024 18:10:35 GMT
Subject: RFR: 8340785: Update description of PassFailJFrame and samples
In-Reply-To: <4U0oKfNqwC3u8g7SdPaeohdEGbrlCLG_sSruyRsRMvM=.70a2ab5f-38e6-49be-b01f-f4d213fc7980@github.com>
References: <4U0oKfNqwC3u8g7SdPaeohdEGbrlCLG_sSruyRsRMvM=.70a2ab5f-38e6-49be-b01f-f4d213fc7980@github.com>
Message-ID: <N9Z4_fYslgfEMn05xM1n7-FwXbeHd2XkiV3-v8HWWcA=.d6c27926-1eb6-4d5d-9baa-8a2e39006a41@github.com>

On Tue, 24 Sep 2024 15:51:09 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I re-worked the entire description of `PassFailJFrame`:
> 
> Add description of what UI elements it provides and how to interact with them.
> Add anchors for linking to the sections.
> 
> Use `{@snippet}` instead of `<pre>{@code}</pre>` for sample code.
> Use method references instead of lambdas in samples.
> Document required jtreg tags to use `PassFailJFrame`.
> Rename `SampleOldManualTest` to `ObsoleteManualTest`.
> 
> Provide an overview of `Builder` methods to configure `PassFailJFrame`.
> 
> As in #21145, the generated javadoc [PassFailJFrame.html](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html) could be easier to read and review.
> 
> The current version of the generated docs contains changes from #21145 and this PR. The PRs can be integrated independently.

Marked as reviewed by prr (Reviewer).

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 85:

> 83:  * <i>Pass</i> / <i>Fail</i> buttons. The framework automatically
> 84:  * creates a frame to display the instructions, provides buttons
> 85:  * to select the test result, handles test timeout.

"and handles"

-------------

PR Review: https://git.openjdk.org/jdk/pull/21162#pullrequestreview-2325919120
PR Review Comment: https://git.openjdk.org/jdk/pull/21162#discussion_r1773750384

From prr at openjdk.org  Tue Sep 24 18:10:43 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 24 Sep 2024 18:10:43 GMT
Subject: Integrated: 8340143: Open source several Java2D rendering loop tests.
In-Reply-To: <esjs4KwtSHviWVCI0rlJBIrkICCZf6HfB_313L_Ouq0=.4949fb2f-9c87-43a9-9a71-c11a31149177@github.com>
References: <esjs4KwtSHviWVCI0rlJBIrkICCZf6HfB_313L_Ouq0=.4949fb2f-9c87-43a9-9a71-c11a31149177@github.com>
Message-ID: <l7okM6fmK2TcHcJpCx5E2HYHtY0sZgi-13tO4IrXnmg=.c136e5f5-c1b1-4dcf-a623-f6b4e231862b@github.com>

On Fri, 20 Sep 2024 23:27:11 GMT, Phil Race <prr at openjdk.org> wrote:

> Open source some Java2d loop rendering tests.

This pull request has now been integrated.

Changeset: 90c2c0b4
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/90c2c0b4ad4ee7d2ea149aea771cf81bd666b1dc
Stats:     394 lines in 5 files changed: 394 ins; 0 del; 0 mod

8340143: Open source several Java2D rendering loop tests.

Reviewed-by: psadhukhan

-------------

PR: https://git.openjdk.org/jdk/pull/21114

From prr at openjdk.org  Tue Sep 24 18:12:38 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 24 Sep 2024 18:12:38 GMT
Subject: RFR: 8339935: Open source several AWT focus tests - series 5 [v2]
In-Reply-To: <efinAJ1vjfInLf5TnlC5EYkiN21f3JkKcOhxB0esfXQ=.df460eaf-246f-478e-952d-1c345f694326@github.com>
References: <9CBDlYAA5yUeyovwlZ8wpQ5fEE6YIXMUUt53BVb-JbU=.9f8c5c39-2e90-4d6a-868f-734cea42367e@github.com>
 <efinAJ1vjfInLf5TnlC5EYkiN21f3JkKcOhxB0esfXQ=.df460eaf-246f-478e-952d-1c345f694326@github.com>
Message-ID: <xv3R9zDzM6TleLLzGpK4gwgipDX52yzm-uZpaX53xGk=.d288dad5-c9bb-4f1d-9cc3-5f973274805f@github.com>

On Tue, 24 Sep 2024 02:17:26 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few AWT focus tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review fix

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21103#pullrequestreview-2326020522

From honkar at openjdk.org  Tue Sep 24 18:54:37 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 24 Sep 2024 18:54:37 GMT
Subject: RFR: 8339836: Open source several AWT Mouse tests - Batch 1 [v2]
In-Reply-To: <dpbUNC1PFWZO82DMZ_JrSuWfwDc8VI264YVgrhJ_o54=.1db6f649-78b5-4630-8780-92c93f9fe37f@github.com>
References: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>
 <dpbUNC1PFWZO82DMZ_JrSuWfwDc8VI264YVgrhJ_o54=.1db6f649-78b5-4630-8780-92c93f9fe37f@github.com>
Message-ID: <0edenVY5Ei9g7Op8k3lhl0cvQZZU9Q6jh2USRmiJ3SE=.2c956e75-12de-434a-baea-2c52ee799980@github.com>

On Tue, 24 Sep 2024 06:07:19 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Open source these AWT Mouse tests:
>> 
>> java/awt/Mouse/MouseEnterExitTest.java
>> java/awt/Mouse/MouseEnterExitTest2.java
>> java/awt/Mouse/MousePressedTest.java
>> java/awt/Mouse/MouseEnterExitTest4.java
>> java/awt/Mouse/MouseEnterExitTest3.java
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   MouseEnterExitTest converted to automated

LGTM other than few inline suggestions

test/jdk/java/awt/Mouse/MouseEnterExitTest.java line 111:

> 109: 
> 110: public class MouseEnterExitTest {
> 111:     static MouseFrame TestFrame;

naming convention

Suggestion:

    static MouseFrame testFrame;

test/jdk/java/awt/Mouse/MouseEnterExitTest.java line 128:

> 126:                     TestFrame.getLocationOnScreen().y + TestFrame.getSize().height / 2));
> 127:             robot.delay(100);
> 128:             robot.waitForIdle();

Ideally waitForIdle() is called first then followed by delay.

Suggestion:

            robot.waitForIdle();
            robot.delay(100);

test/jdk/java/awt/Mouse/MouseEnterExitTest3.java line 45:

> 43:      final static Button button = new Button("Button");
> 44:      final static JButton jbutton = new JButton("JButton");
> 45:      final static Frame frame = new Frame("Mouse Enter/Exit Test");

Modifier order, same for the other two

Suggestion:

     static final Button button = new Button("Button");

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21124#pullrequestreview-2326065123
PR Review Comment: https://git.openjdk.org/jdk/pull/21124#discussion_r1773835727
PR Review Comment: https://git.openjdk.org/jdk/pull/21124#discussion_r1773834527
PR Review Comment: https://git.openjdk.org/jdk/pull/21124#discussion_r1773840125

From azvegint at openjdk.org  Tue Sep 24 18:59:41 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 24 Sep 2024 18:59:41 GMT
Subject: Integrated: 8340433: Open source closed choice tests #3
In-Reply-To: <bkuFu9a7K35iiT58GCiPFGwsQwQDXBiqZ8gwNz85rhk=.ddda876b-9987-4d54-bc4f-b1710b04df2d@github.com>
References: <bkuFu9a7K35iiT58GCiPFGwsQwQDXBiqZ8gwNz85rhk=.ddda876b-9987-4d54-bc4f-b1710b04df2d@github.com>
Message-ID: <SEoDky98hES5_iTuIWmA5EwcaKB8MLth7kr81qheA_M=.6e42eb32-a60e-46e1-b3a2-3b122abf5824@github.com>

On Fri, 20 Sep 2024 09:53:00 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> few more tests to open source
> 
> Testing is good.

This pull request has now been integrated.

Changeset: 8c08c43a
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8c08c43a34b7a237c0281ef58594af4f263ba3ca
Stats:     341 lines in 3 files changed: 341 ins; 0 del; 0 mod

8340433: Open source closed choice tests #3

Reviewed-by: honkar, prr

-------------

PR: https://git.openjdk.org/jdk/pull/21107

From honkar at openjdk.org  Tue Sep 24 19:07:36 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 24 Sep 2024 19:07:36 GMT
Subject: RFR: 8339836: Open source several AWT Mouse tests - Batch 1 [v2]
In-Reply-To: <dpbUNC1PFWZO82DMZ_JrSuWfwDc8VI264YVgrhJ_o54=.1db6f649-78b5-4630-8780-92c93f9fe37f@github.com>
References: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>
 <dpbUNC1PFWZO82DMZ_JrSuWfwDc8VI264YVgrhJ_o54=.1db6f649-78b5-4630-8780-92c93f9fe37f@github.com>
Message-ID: <baLSnNFV_1DFQ4m3Fi08sEE9zhrhA4U2gnq88w7TtJM=.2c6297d8-829f-4cd7-8f74-49a4e88dcf51@github.com>

On Tue, 24 Sep 2024 06:07:19 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Open source these AWT Mouse tests:
>> 
>> java/awt/Mouse/MouseEnterExitTest.java
>> java/awt/Mouse/MouseEnterExitTest2.java
>> java/awt/Mouse/MousePressedTest.java
>> java/awt/Mouse/MouseEnterExitTest4.java
>> java/awt/Mouse/MouseEnterExitTest3.java
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   MouseEnterExitTest converted to automated

test/jdk/java/awt/Mouse/MouseEnterExitTest4.java line 37:

> 35:  * @bug 4431868
> 36:  * @summary Tests that window totally obscured by its child doesn't receive
> 37:  *          enter/exit events when located over another frame

Suggestion: This test can be automated similar to MouseEnterExitTest.java  with robot.mouseMove() and checking for mouseEntered and Exited events.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21124#discussion_r1773887674

From honkar at openjdk.org  Tue Sep 24 23:38:37 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 24 Sep 2024 23:38:37 GMT
Subject: RFR: 8340466: Add description for PassFailJFrame constructors [v2]
In-Reply-To: <d_1xzCt_n2o7bpsZDrgY3vjS69dX7HijTXoccZN10yk=.0a56094f-66d8-45e2-bbea-f0531b3d7101@github.com>
References: <YDqxPeO0ID6Xf_JF-oHqYOtgWfCVY93sP2AeoiFnOoM=.ff6f613d-30f0-4a90-bc7d-1f6c6fe2665a@github.com>
 <d_1xzCt_n2o7bpsZDrgY3vjS69dX7HijTXoccZN10yk=.0a56094f-66d8-45e2-bbea-f0531b3d7101@github.com>
Message-ID: <gCGMdUCS6yV8PuVJqwrCSHTQ6iXurMNG0jXtdao0iSM=.764bff62-86b5-4fdb-8064-e4b67aa92c07@github.com>

On Tue, 24 Sep 2024 16:12:29 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I added description to all the constructors available in `PassFailJFrame`.
>> 
>> I generated the javadoc for it: [`PassFailJFrame` constructor details](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html#constructor-detail) which is easier to read. This hosted javadoc could be used as a reference to its API.
>> 
>> The constructor with the largest number of parameters contains a short description of how to use the `PassFailJFrame` object.
>> 
>> Shall we deprecate the constructors in favour of `Builder`?
>> 
>> The builder provides a more streamlined experience, therefore new tests should use it instead of constructors. We may update the tests which use the constructors, after which the constructors can be removed.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use EDT abbreviation in constructor description
>   
>   The term EDT (Event Dispatch Thread) is introduced in
>   the top-level doc comment.

> Shall we deprecate the constructors in favor of Builder?

>The builder provides a more streamlined experience, therefore new tests should use it instead of constructors. We may update the tests which use the constructors, after which the constructors can be removed.

There are some cases where the builder approach may not work as expected especially modal dialog tests and  in such instances the older constructor methods are used.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21145#pullrequestreview-2326697452

From honkar at openjdk.org  Tue Sep 24 23:53:34 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 24 Sep 2024 23:53:34 GMT
Subject: RFR: 8340466: Add description for PassFailJFrame constructors [v2]
In-Reply-To: <d_1xzCt_n2o7bpsZDrgY3vjS69dX7HijTXoccZN10yk=.0a56094f-66d8-45e2-bbea-f0531b3d7101@github.com>
References: <YDqxPeO0ID6Xf_JF-oHqYOtgWfCVY93sP2AeoiFnOoM=.ff6f613d-30f0-4a90-bc7d-1f6c6fe2665a@github.com>
 <d_1xzCt_n2o7bpsZDrgY3vjS69dX7HijTXoccZN10yk=.0a56094f-66d8-45e2-bbea-f0531b3d7101@github.com>
Message-ID: <Qk1BUu59yHLXw7YA4hsQVMisIIAoCaI-ywg9rIhJWQo=.70ff71c1-b738-426f-8402-e5272a3339e1@github.com>

On Tue, 24 Sep 2024 16:12:29 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I added description to all the constructors available in `PassFailJFrame`.
>> 
>> I generated the javadoc for it: [`PassFailJFrame` constructor details](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html#constructor-detail) which is easier to read. This hosted javadoc could be used as a reference to its API.
>> 
>> The constructor with the largest number of parameters contains a short description of how to use the `PassFailJFrame` object.
>> 
>> Shall we deprecate the constructors in favour of `Builder`?
>> 
>> The builder provides a more streamlined experience, therefore new tests should use it instead of constructors. We may update the tests which use the constructors, after which the constructors can be removed.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use EDT abbreviation in constructor description
>   
>   The term EDT (Event Dispatch Thread) is introduced in
>   the top-level doc comment.

Marked as reviewed by honkar (Reviewer).

Doc changes looks good.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21145#pullrequestreview-2326708134
Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21145#pullrequestreview-2326708441

From psadhukhan at openjdk.org  Wed Sep 25 03:11:41 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 25 Sep 2024 03:11:41 GMT
Subject: Integrated: 8339935: Open source several AWT focus tests - series 5
In-Reply-To: <9CBDlYAA5yUeyovwlZ8wpQ5fEE6YIXMUUt53BVb-JbU=.9f8c5c39-2e90-4d6a-868f-734cea42367e@github.com>
References: <9CBDlYAA5yUeyovwlZ8wpQ5fEE6YIXMUUt53BVb-JbU=.9f8c5c39-2e90-4d6a-868f-734cea42367e@github.com>
Message-ID: <dIzo5H8rwYtDXFnaHc5IYWiw607Ke4T99BgdjdHP7D4=.3b78ee97-8262-477b-b376-a17a89794736@github.com>

On Fri, 20 Sep 2024 03:23:26 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few AWT focus tests

This pull request has now been integrated.

Changeset: b1f8d2ea
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/b1f8d2ea76322a89eea84851a1e791f52c31261b
Stats:     315 lines in 4 files changed: 315 ins; 0 del; 0 mod

8339935: Open source several AWT focus tests - series 5

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/21103

From psadhukhan at openjdk.org  Wed Sep 25 03:14:35 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 25 Sep 2024 03:14:35 GMT
Subject: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v4]
In-Reply-To: <YPL9iPnYVjmQ04mraSLhysttnmAmbrQ5Qpo9dL-9Fa4=.85a98d94-32d5-4f29-8f73-cdcbdcce3196@github.com>
References: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
 <YPL9iPnYVjmQ04mraSLhysttnmAmbrQ5Qpo9dL-9Fa4=.85a98d94-32d5-4f29-8f73-cdcbdcce3196@github.com>
Message-ID: <rl39_sPLuO-im-fjuediFhUuCsXCK9YnQNaR6vH5NM8=.2eb0a668-688f-4488-a4fe-d8077b080ca1@github.com>

On Tue, 24 Sep 2024 06:29:21 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Open source these AWT Mouse and GraphicsEnvironment tests:
>> 
>> java/awt/MouseClickCount/MouseClickCount.java
>> java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java
>> java/awt/MouseDragTest/MouseDragTest.java
>> java/awt/OpenWinDoubleClickTest/OpenWinDoubleClickTest.java
>> java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments updated

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21126#pullrequestreview-2326885672

From honkar at openjdk.org  Wed Sep 25 04:51:23 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 25 Sep 2024 04:51:23 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v2]
In-Reply-To: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
Message-ID: <RWSvNMHNuXRYRuaiSXej6hjiUXKWMYcJrHuYnq5oOMY=.1d399308-2d94-4fb1-b961-b1e556854761@github.com>

> Following tests are updated in this PR:
> 
> 1. 	test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java
> 2. 	test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java
> 3. 	test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java
> 4. 	test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  problemlist updated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21094/files
  - new: https://git.openjdk.org/jdk/pull/21094/files/fd311363..ef0c9916

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21094&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21094&range=00-01

  Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21094.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21094/head:pull/21094

PR: https://git.openjdk.org/jdk/pull/21094

From honkar at openjdk.org  Wed Sep 25 04:51:23 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 25 Sep 2024 04:51:23 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v2]
In-Reply-To: <ARzBHgjoRZnCtlJZF8rJfk9EGzdo32vHhkbTgSb2smk=.6ee978e2-00c7-46d3-89e1-3669bcdee42b@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
 <Hy5Smx4UMwjF-Nro6kTnZsDCduMyklZvtsCHErgmbHI=.bafa76f1-2f0d-4256-85b5-12b6d22093be@github.com>
 <Z7ASo3Ql2zypHRCVvujbm7FBNtHBVnTLEwo0fwdR5JU=.21da8d15-d301-4c21-865d-994b465bd199@github.com>
 <ARzBHgjoRZnCtlJZF8rJfk9EGzdo32vHhkbTgSb2smk=.6ee978e2-00c7-46d3-89e1-3669bcdee42b@github.com>
Message-ID: <EzqVSrESeWDKePRSFGUoJjB1Qf4EHhDnCqeft94X3BE=.f3ecfd8f-7352-4247-a636-db9fd7ae9f4a@github.com>

On Fri, 20 Sep 2024 05:26:50 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Looks to be similar to [JDK-8233068](https://bugs.openjdk.org/browse/JDK-8233068)
>
> @prsadhuk Thanks for linking the issue. Yes it looks to be similar.
> Unlike XCheckboxPeer.java, WCheckboxPeer.java does not have paintCheckbox(), it is probably done somewhere else for windows.

Problemlisted the tests - CheckboxNullLabelTest.java, CheckboxIndicatorSizeTest.java, CheckboxBoxSizeTest.java on windows. [JDK-8340870](https://bugs.openjdk.org/browse/JDK-8340870)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1774446288

From honkar at openjdk.org  Wed Sep 25 05:11:49 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 25 Sep 2024 05:11:49 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v3]
In-Reply-To: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
Message-ID: <M_frFO86zmARq3cQ9sxjd_eBUcKKbTy9CPBxjNlDaQM=.70fd26e0-b5c2-4eb6-99c2-0be792df7bc1@github.com>

> Following tests are updated in this PR:
> 
> 1. 	test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java
> 2. 	test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java
> 3. 	test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java
> 4. 	test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java

Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:

 - Merge master
 - problemlist updated
 - eof newline
 - checkbox tests

-------------

Changes: https://git.openjdk.org/jdk/pull/21094/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21094&range=02
  Stats: 412 lines in 5 files changed: 412 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21094.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21094/head:pull/21094

PR: https://git.openjdk.org/jdk/pull/21094

From tr at openjdk.org  Wed Sep 25 07:25:04 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 25 Sep 2024 07:25:04 GMT
Subject: RFR: 8340193: Open source several AWT Dialog tests - Batch 1
Message-ID: <A_AenkvGSNRrpXk_wcGxZ3Cw-dCFaHsd-75onI6mCX4=.1f17a7fe-701d-417e-8579-08856070ee18@github.com>

Open source these AWT Mouse tests:

java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java
java/awt/Dialog/FileDialogWrongNameCrash.java
java/awt/Dialog/DialogResizeTest.java
java/awt/Dialog/GetLocationTest_1.java
java/awt/Dialog/DialogIconTest/DialogIconTest.java

-------------

Commit messages:
 - Open source

Changes: https://git.openjdk.org/jdk/pull/21174/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21174&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340193
  Stats: 685 lines in 11 files changed: 685 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21174.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21174/head:pull/21174

PR: https://git.openjdk.org/jdk/pull/21174

From psadhukhan at openjdk.org  Wed Sep 25 07:30:40 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 25 Sep 2024 07:30:40 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v3]
In-Reply-To: <M_frFO86zmARq3cQ9sxjd_eBUcKKbTy9CPBxjNlDaQM=.70fd26e0-b5c2-4eb6-99c2-0be792df7bc1@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
 <M_frFO86zmARq3cQ9sxjd_eBUcKKbTy9CPBxjNlDaQM=.70fd26e0-b5c2-4eb6-99c2-0be792df7bc1@github.com>
Message-ID: <Bbzzp5BZ9XbIqt5m9glHmwscI44I5i1LvVtPzbbwYFo=.d5926559-45b4-4071-aaff-dfdd8656d8a1@github.com>

On Wed, 25 Sep 2024 05:11:49 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are updated in this PR:
>> 
>> 1. 	test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java
>> 2. 	test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java
>> 3. 	test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java
>> 4. 	test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java
>
> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Merge master
>  - problemlist updated
>  - eof newline
>  - checkbox tests

test/jdk/ProblemList.txt line 797:

> 795: java/awt/Checkbox/CheckboxBoxSizeTest.java 8340870 windows-all
> 796: java/awt/Checkbox/CheckboxIndicatorSizeTest.java 8340870 windows-all
> 797: java/awt/Checkbox/CheckboxBoxSizeTest.java 8340870 windows-all

duplicate addition CheckboxBoxSizeTest

test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java line 43:

> 41:     private static final String INSTRUCTIONS = """
> 42:             This test must be run at UI Scale of 100% OR 150% or greater.
> 43:             Compare the size of box to any of native apps on Windows

Maybe you can mention anyone of the native app for easy verification...
Also, it seems if tester tests with 100%, it might look same and tester can pass it...I guess the problem comes with hidpi scale of 150% or more, so maybe we can remove 100% from instruction OR mention 100% AND 150% to check for both...

test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java line 65:

> 63:             Verify that all indicators of checkboxes has the same size.
> 64:             Verify that all indicators of radio buttons has the same size.
> 65:             Press PASS if the above conditions are true else Press FAIL.

I guess "Same size" is not correct here...I guess what we meant is the size should be proportionate to scaling or "size will change if font size is changed", it seems the size does not increase if we increase the scale..
but it still remains the "same", so some tester can consider it pass

test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java line 167:

> 165:         testPanel.setFont(newFont);
> 166:         frame.invalidate();
> 167:         frame.validate();

DO we need to invalidate and then validate? guess we can remove these 2 lines or does it have any impact on testing?

test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java line 58:

> 56: 
> 57:      private static Frame createAndShowUI() {
> 58:          StrangeCheckbox cbox = new StrangeCheckbox();

I guess we can bring in the code in the StrangeCheckbox constructor and remove that class altogether as it's not doing anything particular rather than implicitly creating a Frame..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1774671318
PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1774646697
PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1774653116
PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1774654287
PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1774680092

From tr at openjdk.org  Wed Sep 25 07:31:37 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 25 Sep 2024 07:31:37 GMT
Subject: RFR: 8340605: Open source several AWT PopupMenu tests
In-Reply-To: <s2yEIJ_5shNyXnWKgQnKypsUp-wNVwjHQBXYW0Q8I88=.f47e4717-c72d-4ded-838c-cefd6f852209@github.com>
References: <s2yEIJ_5shNyXnWKgQnKypsUp-wNVwjHQBXYW0Q8I88=.f47e4717-c72d-4ded-838c-cefd6f852209@github.com>
Message-ID: <DowzlMr2Wzqr7pm8NfoUKflwRDwysZKqpZ1QVsiyqo4=.982e81e5-e15e-45c8-b5e8-c4b80172ba91@github.com>

On Tue, 24 Sep 2024 07:46:14 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Several AWT PopupMEnu related tests are converted from applet to manual and moved to open.

test/jdk/java/awt/PopupMenu/PopupLeadingSeparatorTest.java line 48:

> 46:                 Press mouse button on the frame. Popup menu without leading
> 47:                 separator should appear.
> 48:                 If a PopupMenu behaves same, press Pass, else press Fail.

Suggestion:

                If a PopupMenu behaves same press Pass, else press Fail.

test/jdk/java/awt/PopupMenu/PopupMenuWithMenuBar.java line 43:

> 41: 
> 42: public class PopupMenuWithMenuBar {
> 43: 

Suggestion:

test/jdk/java/awt/PopupMenu/PopupOnButton.java line 48:

> 46:                 Right-click on the button.
> 47:                 Popup Menu should appear and behave fine.
> 48:                 If a PopupMenu appears, press Pass, else press Fail.

Suggestion:

                If a PopupMenu appears press Pass, else press Fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21151#discussion_r1774682082
PR Review Comment: https://git.openjdk.org/jdk/pull/21151#discussion_r1774685425
PR Review Comment: https://git.openjdk.org/jdk/pull/21151#discussion_r1774686569

From abhiscxk at openjdk.org  Wed Sep 25 07:42:03 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 25 Sep 2024 07:42:03 GMT
Subject: RFR: 8340605: Open source several AWT PopupMenu tests [v2]
In-Reply-To: <s2yEIJ_5shNyXnWKgQnKypsUp-wNVwjHQBXYW0Q8I88=.f47e4717-c72d-4ded-838c-cefd6f852209@github.com>
References: <s2yEIJ_5shNyXnWKgQnKypsUp-wNVwjHQBXYW0Q8I88=.f47e4717-c72d-4ded-838c-cefd6f852209@github.com>
Message-ID: <f3LdJ3M6gcgWcB4GOcbpZJ-dGlmd_nv41T1DOw3kBL0=.c1ec6221-9326-4d05-ae46-8243a1bd5f12@github.com>

> Several AWT PopupMEnu related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  remove blank line

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21151/files
  - new: https://git.openjdk.org/jdk/pull/21151/files/d696cbe9..8f6bbc27

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21151&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21151&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21151.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21151/head:pull/21151

PR: https://git.openjdk.org/jdk/pull/21151

From abhiscxk at openjdk.org  Wed Sep 25 07:42:03 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 25 Sep 2024 07:42:03 GMT
Subject: RFR: 8340605: Open source several AWT PopupMenu tests [v2]
In-Reply-To: <DowzlMr2Wzqr7pm8NfoUKflwRDwysZKqpZ1QVsiyqo4=.982e81e5-e15e-45c8-b5e8-c4b80172ba91@github.com>
References: <s2yEIJ_5shNyXnWKgQnKypsUp-wNVwjHQBXYW0Q8I88=.f47e4717-c72d-4ded-838c-cefd6f852209@github.com>
 <DowzlMr2Wzqr7pm8NfoUKflwRDwysZKqpZ1QVsiyqo4=.982e81e5-e15e-45c8-b5e8-c4b80172ba91@github.com>
Message-ID: <hNQNxHU-2N4kQakXw8VWwhypHY7MxVvLs_1w8jYVpjk=.3f94c92b-68d1-46a0-b3ea-e1f4afa8780f@github.com>

On Wed, 25 Sep 2024 07:26:12 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove blank line
>
> test/jdk/java/awt/PopupMenu/PopupLeadingSeparatorTest.java line 48:
> 
>> 46:                 Press mouse button on the frame. Popup menu without leading
>> 47:                 separator should appear.
>> 48:                 If a PopupMenu behaves same, press Pass, else press Fail.
> 
> Suggestion:
> 
>                 If a PopupMenu behaves same press Pass, else press Fail.

seems correct to me.

> test/jdk/java/awt/PopupMenu/PopupOnButton.java line 48:
> 
>> 46:                 Right-click on the button.
>> 47:                 Popup Menu should appear and behave fine.
>> 48:                 If a PopupMenu appears, press Pass, else press Fail.
> 
> Suggestion:
> 
>                 If a PopupMenu appears press Pass, else press Fail.

same here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21151#discussion_r1774702878
PR Review Comment: https://git.openjdk.org/jdk/pull/21151#discussion_r1774703670

From aivanov at openjdk.org  Wed Sep 25 09:36:34 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 25 Sep 2024 09:36:34 GMT
Subject: RFR: 8340466: Add description for PassFailJFrame constructors [v2]
In-Reply-To: <gCGMdUCS6yV8PuVJqwrCSHTQ6iXurMNG0jXtdao0iSM=.764bff62-86b5-4fdb-8064-e4b67aa92c07@github.com>
References: <YDqxPeO0ID6Xf_JF-oHqYOtgWfCVY93sP2AeoiFnOoM=.ff6f613d-30f0-4a90-bc7d-1f6c6fe2665a@github.com>
 <d_1xzCt_n2o7bpsZDrgY3vjS69dX7HijTXoccZN10yk=.0a56094f-66d8-45e2-bbea-f0531b3d7101@github.com>
 <gCGMdUCS6yV8PuVJqwrCSHTQ6iXurMNG0jXtdao0iSM=.764bff62-86b5-4fdb-8064-e4b67aa92c07@github.com>
Message-ID: <jnnDrAcQNTkkSz_rKBEy85AcpaM2mPAoM8T2GvqUf4c=.a4f8b56a-be5d-40f5-875e-6692ad17e6c7@github.com>

On Tue, 24 Sep 2024 23:36:17 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> > Shall we deprecate the constructors in favor of Builder?
> >
> > The builder provides a more streamlined experience, therefore new tests should use it instead of constructors. We may update the tests which use the constructors, after which the constructors can be removed.
> 
> There are some cases where the builder approach may not work as expected especially modal dialog tests and in such instances the older constructor methods are used.

I can't see how it's possible? Do you have an example?

The builder provides the same features as constructors do. The only difference is that builder automatically shows all the registered windows.

Just like with the `PassFailJFrame` constructors, you can do other stuff before you use builder to create an instance of `PassFailJFrame`; just like with the constructors, you can do other stuff after creating the instance and before calling `awaitAndCheck`. You can use `addTestWindow` and `positionTestWindow` during the test execution if needed.

You also can employ (window) events to start or to synchronise other parts of running the test, `LotsOfMenuItemsTest.java` is a great example of such an approach.

https://github.com/openjdk/jdk/blob/9806d2139cb5994effdee3f7bc6b23eb81858ed3/test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java#L74-L85

I agree there could be shortcomings in the `PassFailJFrame` design where you have to write more code for an uncommon scenario. However, if the most common scenario lets you write less code, it is still a win.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21145#issuecomment-2373565416

From tr at openjdk.org  Wed Sep 25 09:49:03 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 25 Sep 2024 09:49:03 GMT
Subject: RFR: 8339836: Open source several AWT Mouse tests - Batch 1 [v3]
In-Reply-To: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>
References: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>
Message-ID: <U-QMhaMoat5MptFqtJLVk3p_5tQMjONXSIfxWV94GOM=.2bbdf53b-8aba-45df-885a-165db2a3a5c0@github.com>

> Open source these AWT Mouse tests:
> 
> java/awt/Mouse/MouseEnterExitTest.java
> java/awt/Mouse/MouseEnterExitTest2.java
> java/awt/Mouse/MousePressedTest.java
> java/awt/Mouse/MouseEnterExitTest4.java
> java/awt/Mouse/MouseEnterExitTest3.java

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Updated review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21124/files
  - new: https://git.openjdk.org/jdk/pull/21124/files/440905cb..ccaf669d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21124&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21124&range=01-02

  Stats: 24 lines in 2 files changed: 5 ins; 5 del; 14 mod
  Patch: https://git.openjdk.org/jdk/pull/21124.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21124/head:pull/21124

PR: https://git.openjdk.org/jdk/pull/21124

From tr at openjdk.org  Wed Sep 25 10:05:22 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 25 Sep 2024 10:05:22 GMT
Subject: RFR: 8339836: Open source several AWT Mouse tests - Batch 1 [v4]
In-Reply-To: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>
References: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>
Message-ID: <o7sfAPoVzAhi4Dm7aPCwNqiCGkU9pR7FDXSWFm56LX4=.15b4ebc1-77de-4e19-a4e9-1a4a269c00b8@github.com>

> Open source these AWT Mouse tests:
> 
> java/awt/Mouse/MouseEnterExitTest.java
> java/awt/Mouse/MouseEnterExitTest2.java
> java/awt/Mouse/MousePressedTest.java
> java/awt/Mouse/MouseEnterExitTest4.java
> java/awt/Mouse/MouseEnterExitTest3.java

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Converted MouseEnterExitTest4 to automated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21124/files
  - new: https://git.openjdk.org/jdk/pull/21124/files/ccaf669d..19a32d5c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21124&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21124&range=02-03

  Stats: 51 lines in 1 file changed: 20 ins; 10 del; 21 mod
  Patch: https://git.openjdk.org/jdk/pull/21124.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21124/head:pull/21124

PR: https://git.openjdk.org/jdk/pull/21124

From aivanov at openjdk.org  Wed Sep 25 10:39:09 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 25 Sep 2024 10:39:09 GMT
Subject: RFR: 8340466: Add description for PassFailJFrame constructors [v3]
In-Reply-To: <YDqxPeO0ID6Xf_JF-oHqYOtgWfCVY93sP2AeoiFnOoM=.ff6f613d-30f0-4a90-bc7d-1f6c6fe2665a@github.com>
References: <YDqxPeO0ID6Xf_JF-oHqYOtgWfCVY93sP2AeoiFnOoM=.ff6f613d-30f0-4a90-bc7d-1f6c6fe2665a@github.com>
Message-ID: <Q6vM-0-NEY4RS2KZTd_rHDk8tTp27-rrOMYQAUTvJME=.a4eac755-b8e9-4607-92b8-dece51975dd3@github.com>

> I added description to all the constructors available in `PassFailJFrame`.
> 
> I generated the javadoc for it: [`PassFailJFrame` constructor details](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html#constructor-detail) which is easier to read. This hosted javadoc could be used as a reference to its API.
> 
> The constructor with the largest number of parameters contains a short description of how to use the `PassFailJFrame` object.
> 
> Shall we deprecate the constructors in favour of `Builder`?
> 
> The builder provides a more streamlined experience, therefore new tests should use it instead of constructors. We may update the tests which use the constructors, after which the constructors can be removed.

Alexey Ivanov has updated the pull request incrementally with two additional commits since the last revision:

 - Takes screenshots...
 - disposing of -> disposal

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21145/files
  - new: https://git.openjdk.org/jdk/pull/21145/files/ff2e7f82..2bac4d48

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21145&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21145&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21145.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21145/head:pull/21145

PR: https://git.openjdk.org/jdk/pull/21145

From aivanov at openjdk.org  Wed Sep 25 10:39:09 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 25 Sep 2024 10:39:09 GMT
Subject: RFR: 8340466: Add description for PassFailJFrame constructors [v2]
In-Reply-To: <DYAJO58N7oW4ARdxow6HKusDodCoSGl9gJR7lnyWdRo=.56b269d9-6702-4853-9172-1fbd7b71126c@github.com>
References: <YDqxPeO0ID6Xf_JF-oHqYOtgWfCVY93sP2AeoiFnOoM=.ff6f613d-30f0-4a90-bc7d-1f6c6fe2665a@github.com>
 <d_1xzCt_n2o7bpsZDrgY3vjS69dX7HijTXoccZN10yk=.0a56094f-66d8-45e2-bbea-f0531b3d7101@github.com>
 <DYAJO58N7oW4ARdxow6HKusDodCoSGl9gJR7lnyWdRo=.56b269d9-6702-4853-9172-1fbd7b71126c@github.com>
Message-ID: <TymCUPb4G77L2ADv-5NzgmOfiE_UelnpRdh3DAhmjZE=.d173236f-6546-4d5d-89c3-241dbf242575@github.com>

On Tue, 24 Sep 2024 17:20:57 GMT, Phil Race <prr at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use EDT abbreviation in constructor description
>>   
>>   The term EDT (Event Dispatch Thread) is introduced in
>>   the top-level doc comment.
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 351:
> 
>> 349:      * If you enable screenshots by setting the {@code screenCapture}
>> 350:      * parameter to {@code true}, a <i>Screenshot</i> button is added.
>> 351:      * Clicking the <i>Screenshot</i> button, takes screenshot of
> 
> "screenshots"

And the comma is not needed, it separates the subject from its verb.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21145#discussion_r1774990323

From aivanov at openjdk.org  Wed Sep 25 10:54:09 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 25 Sep 2024 10:54:09 GMT
Subject: RFR: 8340785: Update description of PassFailJFrame and samples
 [v2]
In-Reply-To: <4U0oKfNqwC3u8g7SdPaeohdEGbrlCLG_sSruyRsRMvM=.70a2ab5f-38e6-49be-b01f-f4d213fc7980@github.com>
References: <4U0oKfNqwC3u8g7SdPaeohdEGbrlCLG_sSruyRsRMvM=.70a2ab5f-38e6-49be-b01f-f4d213fc7980@github.com>
Message-ID: <-_HSa6RcEvu35m9oU59M7tXGI6VD797Oa78Amn_gF7w=.d7d74752-eb53-4086-9329-b178462ac9af@github.com>

> I re-worked the entire description of `PassFailJFrame`:
> 
> Add description of what UI elements it provides and how to interact with them.
> Add anchors for linking to the sections.
> 
> Use `{@snippet}` instead of `<pre>{@code}</pre>` for sample code.
> Use method references instead of lambdas in samples.
> Document required jtreg tags to use `PassFailJFrame`.
> Rename `SampleOldManualTest` to `ObsoleteManualTest`.
> 
> Provide an overview of `Builder` methods to configure `PassFailJFrame`.
> 
> As in #21145, the generated javadoc [PassFailJFrame.html](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html) could be easier to read and review.
> 
> The current version of the generated docs contains changes from #21145 and this PR. The PRs can be integrated independently.

Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:

  Amend: and handles timeout.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21162/files
  - new: https://git.openjdk.org/jdk/pull/21162/files/cbb1464a..6ba944d1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21162&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21162&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21162.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21162/head:pull/21162

PR: https://git.openjdk.org/jdk/pull/21162

From azvegint at openjdk.org  Wed Sep 25 10:55:04 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 25 Sep 2024 10:55:04 GMT
Subject: RFR: 8340687: Open source closed frame tests #1
Message-ID: <L0esVp8RRIiKlUOg1PO7z49Xo45zAVnLeWsAQSEkWF8=.8a32ec1c-c597-4b1d-b21d-4b37fb58ca04@github.com>

few more tests to open source

Testing looks good

-------------

Commit messages:
 - 8340687: Open source closed frame tests #1

Changes: https://git.openjdk.org/jdk/pull/21180/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21180&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340687
  Stats: 458 lines in 4 files changed: 458 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21180.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21180/head:pull/21180

PR: https://git.openjdk.org/jdk/pull/21180

From aivanov at openjdk.org  Wed Sep 25 11:36:08 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 25 Sep 2024 11:36:08 GMT
Subject: RFR: 8340899: Remove wildcard bound in
 PositionWindows.positionTestWindows
Message-ID: <hu-Y60yuVFxHJ7jhraW8rehzV_XMTeqcjoyZGxrr6E4=.54ce9e30-a87b-4ac5-8c94-e10381a077c0@github.com>

Removes the wildcard bound from `PassFailJFrame.PositionWindows.positionTestWindows` so that implementing the interface is simpler as one don't have to remember to declare the `testWindows` parameter as `List<? extends Window>` ? just use `List<Window>`.

It is a backwards compatible change, all the tests which use `List<? extends Window>` continue to compile successfully.

-------------

Commit messages:
 - 8340899: Remove wildcard bound in PositionWindows.positionTestWindows

Changes: https://git.openjdk.org/jdk/pull/21181/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21181&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340899
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21181.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21181/head:pull/21181

PR: https://git.openjdk.org/jdk/pull/21181

From aivanov at openjdk.org  Wed Sep 25 11:41:34 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 25 Sep 2024 11:41:34 GMT
Subject: RFR: 8340687: Open source closed frame tests #1
In-Reply-To: <L0esVp8RRIiKlUOg1PO7z49Xo45zAVnLeWsAQSEkWF8=.8a32ec1c-c597-4b1d-b21d-4b37fb58ca04@github.com>
References: <L0esVp8RRIiKlUOg1PO7z49Xo45zAVnLeWsAQSEkWF8=.8a32ec1c-c597-4b1d-b21d-4b37fb58ca04@github.com>
Message-ID: <DRBYv36-vAhbQqzoC4dVDg8E1LgDwySVpBKImcSebsQ=.1fa84410-7f10-4d79-9be8-618e6f3c083f@github.com>

On Wed, 25 Sep 2024 10:48:53 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> few more tests to open source
> 
> Testing looks good

GitHub doesn't like `#1` in the subject of the JBS issue ? it links it to the first PR in the JDK project.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21180#issuecomment-2373841065

From mbaesken at openjdk.org  Wed Sep 25 11:51:04 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Wed, 25 Sep 2024 11:51:04 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
Message-ID: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>

It has been discussed that checking the return value of pthread_create should be done.
See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .

-------------

Commit messages:
 - JDK-8339475

Changes: https://git.openjdk.org/jdk/pull/21182/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21182&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339475
  Stats: 7 lines in 2 files changed: 6 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21182.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21182/head:pull/21182

PR: https://git.openjdk.org/jdk/pull/21182

From azvegint at openjdk.org  Wed Sep 25 11:53:35 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 25 Sep 2024 11:53:35 GMT
Subject: RFR: 8340899: Remove wildcard bound in
 PositionWindows.positionTestWindows
In-Reply-To: <hu-Y60yuVFxHJ7jhraW8rehzV_XMTeqcjoyZGxrr6E4=.54ce9e30-a87b-4ac5-8c94-e10381a077c0@github.com>
References: <hu-Y60yuVFxHJ7jhraW8rehzV_XMTeqcjoyZGxrr6E4=.54ce9e30-a87b-4ac5-8c94-e10381a077c0@github.com>
Message-ID: <RLYpZgQblyDGRR_gDDd2BcVSKU5XmLLErpZnGpKBsvI=.97480c1d-5908-40ed-a402-ff1b498e45d4@github.com>

On Wed, 25 Sep 2024 11:31:38 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Removes the wildcard bound from `PassFailJFrame.PositionWindows.positionTestWindows` so that implementing the interface is simpler as one don't have to remember to declare the `testWindows` parameter as `List<? extends Window>` ? just use `List<Window>`.
> 
> It is a backwards compatible change, all the tests which use `List<? extends Window>` continue to compile successfully.

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21181#pullrequestreview-2328014811

From aivanov at openjdk.org  Wed Sep 25 11:53:35 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 25 Sep 2024 11:53:35 GMT
Subject: RFR: 8340899: Remove wildcard bound in
 PositionWindows.positionTestWindows
In-Reply-To: <hu-Y60yuVFxHJ7jhraW8rehzV_XMTeqcjoyZGxrr6E4=.54ce9e30-a87b-4ac5-8c94-e10381a077c0@github.com>
References: <hu-Y60yuVFxHJ7jhraW8rehzV_XMTeqcjoyZGxrr6E4=.54ce9e30-a87b-4ac5-8c94-e10381a077c0@github.com>
Message-ID: <DI-ey_5BXvctwCX-XezEkNe4as66i_wzanZjfOHPHiE=.85c1719c-db24-4abb-92b3-f3c16d15c6a1@github.com>

On Wed, 25 Sep 2024 11:31:38 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Removes the wildcard bound from `PassFailJFrame.PositionWindows.positionTestWindows` so that implementing the interface is simpler as one don't have to remember to declare the `testWindows` parameter as `List<? extends Window>` ? just use `List<Window>`.
> 
> It is a backwards compatible change, all the tests which use `List<? extends Window>` continue to compile successfully.

You can test this change with tests from #21180 `DefaultFrameIconTest.java` and/or `MenuCrash.java`.

The tests declare the first parameter to `positionTestWindows` as `List<? extends Window> testWindows`. If it were declared as `List<Window> testWindows`, the test would not compile with the current version of `PassFailJFrame`.

Removing the wildcard lower bound from `PassFailJFrame.PositionWindows.positionTestWindows` makes it possible to use the `List<Window>` type in tests.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21181#issuecomment-2373864729

From mbaesken at openjdk.org  Wed Sep 25 11:54:34 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Wed, 25 Sep 2024 11:54:34 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
In-Reply-To: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
Message-ID: <k9ehkIJQa75PX85a_2GEGRLwvzDhgDKMshFla7QomQU=.2128bdb1-3885-4caa-8787-2bce523ee602@github.com>

On Wed, 25 Sep 2024 11:46:00 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> It has been discussed that checking the return value of pthread_create should be done.
> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .

I found some strange handling of the return value on macOS.
Here we check already the return value of pthread_create ; but then it seems we add the errno twice when calling JLI_ReportErrorMessageSys, once in the calling params and once in JLI_ReportErrorMessageSys itself.
Should we better call  with the return value of pthread_create in the error case? Or just with a string without additional parameters?
The comment about Solaris 8 is also very outdated, don't think we need that any more in jdk24.


src/java.base/macosx/native/libjli/java_md_macosx.m 

312     if (pthread_create(&main_thr, NULL, &apple_main, &args) != 0) {
313         JLI_ReportErrorMessageSys("Could not create main thread: %s\n", strerror(errno));

src/java.base/unix/native/libjli/java_md_common.c

244  JLI_ReportErrorMessageSys(const char* fmt, ...) {
245      va_list vl;
246      char *emsg;
247  
248      /*
249       * TODO: its safer to use strerror_r but is not available on
250       * Solaris 8. Until then....
251       */
252      emsg = strerror(errno);
253      if (emsg != NULL) {
254          fprintf(stderr, "%s\n", emsg);
255      }

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21182#issuecomment-2373866698

From azvegint at openjdk.org  Wed Sep 25 11:55:36 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 25 Sep 2024 11:55:36 GMT
Subject: RFR: 8340687: Open source closed frame tests #1
In-Reply-To: <DRBYv36-vAhbQqzoC4dVDg8E1LgDwySVpBKImcSebsQ=.1fa84410-7f10-4d79-9be8-618e6f3c083f@github.com>
References: <L0esVp8RRIiKlUOg1PO7z49Xo45zAVnLeWsAQSEkWF8=.8a32ec1c-c597-4b1d-b21d-4b37fb58ca04@github.com>
 <DRBYv36-vAhbQqzoC4dVDg8E1LgDwySVpBKImcSebsQ=.1fa84410-7f10-4d79-9be8-618e6f3c083f@github.com>
Message-ID: <vx_x_6Tif4ROIMU0ZYIAKRZTgUs_qMPHnehng1Lh_jk=.bde153a6-4e85-4bd6-96b3-5209dd0e0079@github.com>

On Wed, 25 Sep 2024 11:39:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> GitHub doesn't like `#1` in the subject of the JBS issue ? it links it to the first PR in the JDK project.

I know, but it's just visual, the PR can be integrated without any issue

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21180#issuecomment-2373869146

From aivanov at openjdk.org  Wed Sep 25 12:06:35 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 25 Sep 2024 12:06:35 GMT
Subject: RFR: 8340687: Open source closed frame tests #1
In-Reply-To: <L0esVp8RRIiKlUOg1PO7z49Xo45zAVnLeWsAQSEkWF8=.8a32ec1c-c597-4b1d-b21d-4b37fb58ca04@github.com>
References: <L0esVp8RRIiKlUOg1PO7z49Xo45zAVnLeWsAQSEkWF8=.8a32ec1c-c597-4b1d-b21d-4b37fb58ca04@github.com>
Message-ID: <YP2Yz0YWGwxGggDGfBAg5_2ce9frN_T8tSiuve0W4nQ=.d0e03ac6-545e-43fb-ba9e-a4b31988a840@github.com>

On Wed, 25 Sep 2024 10:48:53 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> few more tests to open source
> 
> Testing looks good

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21180#pullrequestreview-2328048717

From aivanov at openjdk.org  Wed Sep 25 12:06:36 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 25 Sep 2024 12:06:36 GMT
Subject: RFR: 8340687: Open source closed frame tests #1
In-Reply-To: <vx_x_6Tif4ROIMU0ZYIAKRZTgUs_qMPHnehng1Lh_jk=.bde153a6-4e85-4bd6-96b3-5209dd0e0079@github.com>
References: <L0esVp8RRIiKlUOg1PO7z49Xo45zAVnLeWsAQSEkWF8=.8a32ec1c-c597-4b1d-b21d-4b37fb58ca04@github.com>
 <DRBYv36-vAhbQqzoC4dVDg8E1LgDwySVpBKImcSebsQ=.1fa84410-7f10-4d79-9be8-618e6f3c083f@github.com>
 <vx_x_6Tif4ROIMU0ZYIAKRZTgUs_qMPHnehng1Lh_jk=.bde153a6-4e85-4bd6-96b3-5209dd0e0079@github.com>
Message-ID: <_qJ66WTe1Xu7gjGOpMQQC3mIEVd4mS5LG7ejhDNeLfQ=.36e41c6a-6e8c-4d04-93f3-16c3961dba17@github.com>

On Wed, 25 Sep 2024 11:53:23 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> > GitHub doesn't like `#1` in the subject of the JBS issue ? it links it to the first PR in the JDK project.
> 
> I know, but it's just visual, the PR can be integrated without any issue

But it looks frightening and confusing, especially with the red marker.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21180#issuecomment-2373889667

From mbaesken at openjdk.org  Wed Sep 25 12:23:04 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Wed, 25 Sep 2024 12:23:04 GMT
Subject: RFR: 8340801: Disable ubsan checks in some awt/2d coding
Message-ID: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>

There is some old awt/2d coding where warnings occur when running with ubsan enabled binaries.
However at most of these locations the coding should work (at least on our supported platform set) so the warnings can be disabled at least for now.

The change adds a macro ATTRIBUTE_NO_UBSAN  similar to what we already use in Hotspot coding.

-------------

Commit messages:
 - JDK-8340801

Changes: https://git.openjdk.org/jdk/pull/21184/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21184&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340801
  Stats: 14 lines in 3 files changed: 14 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21184.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21184/head:pull/21184

PR: https://git.openjdk.org/jdk/pull/21184

From kizune at openjdk.org  Wed Sep 25 16:50:44 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 25 Sep 2024 16:50:44 GMT
Subject: Integrated: 8340228: Open source couple more miscellaneous AWT tests
In-Reply-To: <GCL1sMFO9DhSYhDnE02xoO-H607Bu-zH_U6YLOfpk5I=.c6f84457-4752-4758-9007-003a636bfbbf@github.com>
References: <GCL1sMFO9DhSYhDnE02xoO-H607Bu-zH_U6YLOfpk5I=.c6f84457-4752-4758-9007-003a636bfbbf@github.com>
Message-ID: <sFdPx7_3SYprLNJZM6dTv0OCjhYzy9Da-naEZ06YBVM=.ab6fa1df-23fe-4cde-9819-1015ba597b7b@github.com>

On Thu, 19 Sep 2024 22:31:24 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Cleaning up and opensourcing three more tests.

This pull request has now been integrated.

Changeset: f7bc9ba5
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f7bc9ba552cf913eef2131b964c48f1b4b55131c
Stats:     321 lines in 3 files changed: 321 ins; 0 del; 0 mod

8340228: Open source couple more miscellaneous AWT tests

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/21097

From prr at openjdk.org  Wed Sep 25 17:19:35 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 25 Sep 2024 17:19:35 GMT
Subject: RFR: 8339341: SurfaceManager cacheMap retains strong references
 [v4]
In-Reply-To: <qP_So5GlLcIx3C4c_HAYXMmBwZNPMX7xfXh-UjDU5IA=.23474628-6b73-4212-9cf8-ca7066834d48@github.com>
References: <1ecWvJLiG54e0saEz_Jjz46gzxXnqsNDagdPQ3y_BN4=.27116e44-886b-405f-9d87-ec5e82e2fd20@github.com>
 <qP_So5GlLcIx3C4c_HAYXMmBwZNPMX7xfXh-UjDU5IA=.23474628-6b73-4212-9cf8-ca7066834d48@github.com>
Message-ID: <yMJOAJfBOmrl5n0ENWeGopmOP2K9Rd_PqCoYUHGpLhE=.2c3edba7-a00c-48f5-a0a5-2974bc76e9dc@github.com>

On Thu, 19 Sep 2024 11:54:56 GMT, Nikita Gubarkov <ngubarkov at openjdk.org> wrote:

>> I moved SurfaceDataProxy cache into a separate class.
>> Now caching level is determined by placement of the SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" proxies and therefore strong refs via them do not prevent the cache and GraphicsConfig from being detected as weakly reachable.
>
> Nikita Gubarkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert wildcard import in X11GraphicsDevice

I ran the latest version of the PR through our automated test system and all looks good, although obviously that isn't detaching and reattaching monitors ... so I need to spend some time understanding the fix.
Also this absolutely needs at least two reviewers. @jayathirthrao and @azvegint  please review as well.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20825#issuecomment-2374694339

From avu at openjdk.org  Wed Sep 25 18:34:39 2024
From: avu at openjdk.org (Alexey Ushakov)
Date: Wed, 25 Sep 2024 18:34:39 GMT
Subject: RFR: 8339341: SurfaceManager cacheMap retains strong references
 [v4]
In-Reply-To: <qP_So5GlLcIx3C4c_HAYXMmBwZNPMX7xfXh-UjDU5IA=.23474628-6b73-4212-9cf8-ca7066834d48@github.com>
References: <1ecWvJLiG54e0saEz_Jjz46gzxXnqsNDagdPQ3y_BN4=.27116e44-886b-405f-9d87-ec5e82e2fd20@github.com>
 <qP_So5GlLcIx3C4c_HAYXMmBwZNPMX7xfXh-UjDU5IA=.23474628-6b73-4212-9cf8-ca7066834d48@github.com>
Message-ID: <P82Wl3v1H_o8xBNXhWlCqqMttAQdz4Mn5enla22ANhg=.cb907c2d-52e9-4304-8ce0-0519ccd8d3c2@github.com>

On Thu, 19 Sep 2024 11:54:56 GMT, Nikita Gubarkov <ngubarkov at openjdk.org> wrote:

>> I moved SurfaceDataProxy cache into a separate class.
>> Now caching level is determined by placement of the SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" proxies and therefore strong refs via them do not prevent the cache and GraphicsConfig from being detected as weakly reachable.
>
> Nikita Gubarkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert wildcard import in X11GraphicsDevice

I've reviewed the fix offline, and some of my suggestions were taken into account.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20825#issuecomment-2374872413

From prr at openjdk.org  Wed Sep 25 20:35:00 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 25 Sep 2024 20:35:00 GMT
Subject: RFR: 8340560: Open Source several AWT/2D font and rendering tests
Message-ID: <PID9btqC7r9H4iRAG1fPdARMP_XuuaS1MrmUUiHuBUU=.618165ee-264c-40dc-adb8-438c161111c6@github.com>

Open sourcing some rendering tests.

-------------

Commit messages:
 - 8340560

Changes: https://git.openjdk.org/jdk/pull/21192/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21192&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340560
  Stats: 578 lines in 4 files changed: 578 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21192.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21192/head:pull/21192

PR: https://git.openjdk.org/jdk/pull/21192

From prr at openjdk.org  Wed Sep 25 20:57:38 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 25 Sep 2024 20:57:38 GMT
Subject: RFR: 8340466: Add description for PassFailJFrame constructors [v3]
In-Reply-To: <Q6vM-0-NEY4RS2KZTd_rHDk8tTp27-rrOMYQAUTvJME=.a4eac755-b8e9-4607-92b8-dece51975dd3@github.com>
References: <YDqxPeO0ID6Xf_JF-oHqYOtgWfCVY93sP2AeoiFnOoM=.ff6f613d-30f0-4a90-bc7d-1f6c6fe2665a@github.com>
 <Q6vM-0-NEY4RS2KZTd_rHDk8tTp27-rrOMYQAUTvJME=.a4eac755-b8e9-4607-92b8-dece51975dd3@github.com>
Message-ID: <rANA07on8SeClo27gnBW64GL_S_OGZrfB4RDazzkUY0=.e60bb476-33aa-4a83-9c0a-e1ace361c8ac@github.com>

On Wed, 25 Sep 2024 10:39:09 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I added description to all the constructors available in `PassFailJFrame`.
>> 
>> I generated the javadoc for it: [`PassFailJFrame` constructor details](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html#constructor-detail) which is easier to read. This hosted javadoc could be used as a reference to its API.
>> 
>> The constructor with the largest number of parameters contains a short description of how to use the `PassFailJFrame` object.
>> 
>> Shall we deprecate the constructors in favour of `Builder`?
>> 
>> The builder provides a more streamlined experience, therefore new tests should use it instead of constructors. We may update the tests which use the constructors, after which the constructors can be removed.
>
> Alexey Ivanov has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Takes screenshots...
>  - disposing of -> disposal

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21145#pullrequestreview-2329520645

From prr at openjdk.org  Wed Sep 25 20:58:46 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 25 Sep 2024 20:58:46 GMT
Subject: RFR: 8340899: Remove wildcard bound in
 PositionWindows.positionTestWindows
In-Reply-To: <hu-Y60yuVFxHJ7jhraW8rehzV_XMTeqcjoyZGxrr6E4=.54ce9e30-a87b-4ac5-8c94-e10381a077c0@github.com>
References: <hu-Y60yuVFxHJ7jhraW8rehzV_XMTeqcjoyZGxrr6E4=.54ce9e30-a87b-4ac5-8c94-e10381a077c0@github.com>
Message-ID: <WqW3zm3Fsu_OyEBY6_Z4hkM79HSPfFlrbvilO8NCATo=.c040320b-2af0-469a-8bdc-d7a8cbfde5a4@github.com>

On Wed, 25 Sep 2024 11:31:38 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Removes the wildcard bound from `PassFailJFrame.PositionWindows.positionTestWindows` so that implementing the interface is simpler as one don't have to remember to declare the `testWindows` parameter as `List<? extends Window>` ? just use `List<Window>`.
> 
> It is a backwards compatible change, all the tests which use `List<? extends Window>` continue to compile successfully.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21181#pullrequestreview-2329522271

From prr at openjdk.org  Wed Sep 25 20:58:38 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 25 Sep 2024 20:58:38 GMT
Subject: RFR: 8340785: Update description of PassFailJFrame and samples
 [v2]
In-Reply-To: <-_HSa6RcEvu35m9oU59M7tXGI6VD797Oa78Amn_gF7w=.d7d74752-eb53-4086-9329-b178462ac9af@github.com>
References: <4U0oKfNqwC3u8g7SdPaeohdEGbrlCLG_sSruyRsRMvM=.70a2ab5f-38e6-49be-b01f-f4d213fc7980@github.com>
 <-_HSa6RcEvu35m9oU59M7tXGI6VD797Oa78Amn_gF7w=.d7d74752-eb53-4086-9329-b178462ac9af@github.com>
Message-ID: <h3s2214lfrB4aXreF8xg0qu8Wyg5W_ZQwj1vR6UWHGg=.de6dc039-4453-4c88-8a16-a49d5b11e9f9@github.com>

On Wed, 25 Sep 2024 10:54:09 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I re-worked the entire description of `PassFailJFrame`:
>> 
>> Add description of what UI elements it provides and how to interact with them.
>> Add anchors for linking to the sections.
>> 
>> Use `{@snippet}` instead of `<pre>{@code}</pre>` for sample code.
>> Use method references instead of lambdas in samples.
>> Document required jtreg tags to use `PassFailJFrame`.
>> Rename `SampleOldManualTest` to `ObsoleteManualTest`.
>> 
>> Provide an overview of `Builder` methods to configure `PassFailJFrame`.
>> 
>> As in #21145, the generated javadoc [PassFailJFrame.html](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html) could be easier to read and review.
>> 
>> The current version of the generated docs contains changes from #21145 and this PR. The PRs can be integrated independently.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Amend: and handles timeout.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21162#pullrequestreview-2329521434

From achung at openjdk.org  Thu Sep 26 01:17:38 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 26 Sep 2024 01:17:38 GMT
Subject: RFR: 8339879: Open some dialog swing tests
Message-ID: <LWBp0wnS6GkzFhiFfCeKiIAMO5TjlUcaVyEFPR3UXgM=.8edf3ccc-92c6-4360-bde8-8d8a8d2245e8@github.com>

First set of dialog swing tests to open during fall 2024 test sprint

-------------

Commit messages:
 - library path change
 - moving tests to open

Changes: https://git.openjdk.org/jdk/pull/21196/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21196&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339879
  Stats: 572 lines in 4 files changed: 572 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21196.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21196/head:pull/21196

PR: https://git.openjdk.org/jdk/pull/21196

From achung at openjdk.org  Thu Sep 26 01:18:49 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 26 Sep 2024 01:18:49 GMT
Subject: Integrated: 8339271: giflib attribution correction
In-Reply-To: <9bUf9UKVavgShir_2Z2Hfjelu4gLJUxoWCel8AntU_M=.2a57b6e4-dafa-45ec-97ba-a70da712b2f9@github.com>
References: <9bUf9UKVavgShir_2Z2Hfjelu4gLJUxoWCel8AntU_M=.2a57b6e4-dafa-45ec-97ba-a70da712b2f9@github.com>
Message-ID: <jQEi1Msqslgtw9e8OVbm1PEvGWrQ-a6ggaopUCCwMh4=.a06b50a3-5ff6-4417-baad-549ce4e768bc@github.com>

On Wed, 4 Sep 2024 19:43:19 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Changing format of file paths in giflib copyright file and removing extra text from authors list

This pull request has now been integrated.

Changeset: 66f16398
Author:    Alisen Chung <achung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/66f1639846645f1d3b4096ef6d62f2b301cf7ed2
Stats:     16 lines in 1 file changed: 6 ins; 10 del; 0 mod

8339271: giflib attribution correction

Reviewed-by: dnguyen, prr

-------------

PR: https://git.openjdk.org/jdk/pull/20859

From abhiscxk at openjdk.org  Thu Sep 26 05:53:17 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 26 Sep 2024 05:53:17 GMT
Subject: RFR: 8340354: Open source AWT desktop properties and print related
 tests
Message-ID: <yOfPiZp2v3H8OSK4-Wv2GV2SeZq7x0heUpdXWQyKav0=.7f1df951-2c9d-4e6c-b2b2-3464caeaa711@github.com>

AWT Desktop properties and printer related tests are converted from applet to manual and moved to open.

-------------

Commit messages:
 - Applet test converted to manual and open sourced

Changes: https://git.openjdk.org/jdk/pull/21197/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21197&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340354
  Stats: 1225 lines in 5 files changed: 1225 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21197.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21197/head:pull/21197

PR: https://git.openjdk.org/jdk/pull/21197

From tr at openjdk.org  Thu Sep 26 06:56:23 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 26 Sep 2024 06:56:23 GMT
Subject: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v5]
In-Reply-To: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
References: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
Message-ID: <AAyJQxLyZ1mtk1NFhtWSw0KRIqksLRDmzWp63MDF804=.bee235e6-a0e8-4d8b-96ef-76e224b0ac9d@github.com>

> Open source these AWT Mouse and GraphicsEnvironment tests:
> 
> java/awt/MouseClickCount/MouseClickCount.java
> java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java
> java/awt/MouseDragTest/MouseDragTest.java
> java/awt/OpenWinDoubleClickTest/OpenWinDoubleClickTest.java
> java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  ProblemList updated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21126/files
  - new: https://git.openjdk.org/jdk/pull/21126/files/1c8c5efb..6d36b51b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21126&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21126&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21126.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21126/head:pull/21126

PR: https://git.openjdk.org/jdk/pull/21126

From tr at openjdk.org  Thu Sep 26 06:57:40 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 26 Sep 2024 06:57:40 GMT
Subject: RFR: 8340605: Open source several AWT PopupMenu tests [v2]
In-Reply-To: <f3LdJ3M6gcgWcB4GOcbpZJ-dGlmd_nv41T1DOw3kBL0=.c1ec6221-9326-4d05-ae46-8243a1bd5f12@github.com>
References: <s2yEIJ_5shNyXnWKgQnKypsUp-wNVwjHQBXYW0Q8I88=.f47e4717-c72d-4ded-838c-cefd6f852209@github.com>
 <f3LdJ3M6gcgWcB4GOcbpZJ-dGlmd_nv41T1DOw3kBL0=.c1ec6221-9326-4d05-ae46-8243a1bd5f12@github.com>
Message-ID: <Em684O-5L2w2CKRGvBOmw2PWwnRi6XfmQmfhUIxqezk=.e0c717d4-0f97-47dc-8d18-f8bdf1910c1a@github.com>

On Wed, 25 Sep 2024 07:42:03 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Several AWT PopupMEnu related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove blank line

LGTM.

-------------

Marked as reviewed by tr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21151#pullrequestreview-2330279311

From clanger at openjdk.org  Thu Sep 26 06:57:36 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Thu, 26 Sep 2024 06:57:36 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
In-Reply-To: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
Message-ID: <HvGbitEArV8r4soTDxX95-GW7jRqGcVcEm-c2okGX8A=.b331bd3e-6b5a-48c2-b2b7-f8bd542fc96f@github.com>

On Wed, 25 Sep 2024 11:46:00 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> It has been discussed that checking the return value of pthread_create should be done.
> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .

Looks good overall, just one nit.

I guess it's ok to print a warning to stderr in this case.

src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m line 278:

> 276:     int rslt = pthread_attr_init(&attr);
> 277:     if (rslt != 0) return;
> 278:     rc = pthread_create(&thr, &attr, SplashScreenThread, (void *) splash);

For the sake of symmetry, could you rename rc to rslt here?

-------------

Changes requested by clanger (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21182#pullrequestreview-2330276303
PR Review Comment: https://git.openjdk.org/jdk/pull/21182#discussion_r1776482707

From tr at openjdk.org  Thu Sep 26 07:02:39 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 26 Sep 2024 07:02:39 GMT
Subject: RFR: 8339879: Open some dialog swing tests
In-Reply-To: <LWBp0wnS6GkzFhiFfCeKiIAMO5TjlUcaVyEFPR3UXgM=.8edf3ccc-92c6-4360-bde8-8d8a8d2245e8@github.com>
References: <LWBp0wnS6GkzFhiFfCeKiIAMO5TjlUcaVyEFPR3UXgM=.8edf3ccc-92c6-4360-bde8-8d8a8d2245e8@github.com>
Message-ID: <TeieZgIKMcmUUuLbma1_4YRuZutyu-17A6VDc5ZxkIE=.67575ad2-444b-4ce9-93ae-8b1adcc72ded@github.com>

On Thu, 26 Sep 2024 01:11:03 GMT, Alisen Chung <achung at openjdk.org> wrote:

> First set of dialog swing tests to open during fall 2024 test sprint

test/jdk/java/awt/Dialog/DialogInitialResizability.java line 35:

> 33:  * @summary Checks that with resizable set to false before show()
> 34:  *          dialog can not be resized.
> 35:  * @library jdk/java/awt/regtesthelpers

Suggestion:

 * @library /java/awt/regtesthelpers

Other places too.

test/jdk/java/awt/Dialog/DialogInitialResizability.java line 42:

> 40: public class DialogInitialResizability {
> 41:     static String instructions = """
> 42:                     Steps to try to reproduce the problem:

Suggestion:

                    Steps to try to reproduce the problem:

Can remove this line.

test/jdk/java/awt/Dialog/ShownModalDialogSerializationTest.java line 66:

> 64:     static void deleteTestUI() {
> 65:         if (dialog != null) {
> 66:             dialog.setVisible(false);

Can be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21196#discussion_r1776483877
PR Review Comment: https://git.openjdk.org/jdk/pull/21196#discussion_r1776487151
PR Review Comment: https://git.openjdk.org/jdk/pull/21196#discussion_r1776489614

From mbaesken at openjdk.org  Thu Sep 26 07:10:10 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Thu, 26 Sep 2024 07:10:10 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
 [v2]
In-Reply-To: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
Message-ID: <LD_w6J1peRbEj3UHoYHapdY-C4fWVRg7I3UsTi-WPFk=.be958d34-0f21-4b57-9e13-edca6cdb413e@github.com>

> It has been discussed that checking the return value of pthread_create should be done.
> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .

Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:

  remove rc

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21182/files
  - new: https://git.openjdk.org/jdk/pull/21182/files/c1d981c1..c04a074b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21182&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21182&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/21182.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21182/head:pull/21182

PR: https://git.openjdk.org/jdk/pull/21182

From clanger at openjdk.org  Thu Sep 26 07:10:10 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Thu, 26 Sep 2024 07:10:10 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
In-Reply-To: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
Message-ID: <Zkfvi3eWbvg9JGs0MGgGie4Mmj7ToEadXxf3RtY2l_0=.e3589df6-595f-4a11-98b2-9161ab597505@github.com>

On Wed, 25 Sep 2024 11:46:00 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> It has been discussed that checking the return value of pthread_create should be done.
> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .

> JLI_ReportErrorMessageSys



> I found some strange handling of the return value on macOS. Here we check already the return value of pthread_create ; but then it seems we add the errno twice when calling JLI_ReportErrorMessageSys, once in the calling params and once in JLI_ReportErrorMessageSys itself. Should we better call with the return value of pthread_create in the error case? Or just with a string without additional parameters? The comment about Solaris 8 is also very outdated, don't think we need that any more in jdk24.
> 
> ```
> src/java.base/macosx/native/libjli/java_md_macosx.m 
> 
> 312     if (pthread_create(&main_thr, NULL, &apple_main, &args) != 0) {
> 313         JLI_ReportErrorMessageSys("Could not create main thread: %s\n", strerror(errno));
> 
> src/java.base/unix/native/libjli/java_md_common.c
> 
> 244  JLI_ReportErrorMessageSys(const char* fmt, ...) {
> 245      va_list vl;
> 246      char *emsg;
> 247  
> 248      /*
> 249       * TODO: its safer to use strerror_r but is not available on
> 250       * Solaris 8. Until then....
> 251       */
> 252      emsg = strerror(errno);
> 253      if (emsg != NULL) {
> 254          fprintf(stderr, "%s\n", emsg);
> 255      }
> ```

Yes, I think the call to java_md_macosx.m seems redundant. And I would remove the comment in java_md_common.c. strerror is used at various places in JDK coding and there's actually only one place that uses strerror_r, in jni_util_md.c

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21182#issuecomment-2376100891

From mbaesken at openjdk.org  Thu Sep 26 07:10:10 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Thu, 26 Sep 2024 07:10:10 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
In-Reply-To: <Zkfvi3eWbvg9JGs0MGgGie4Mmj7ToEadXxf3RtY2l_0=.e3589df6-595f-4a11-98b2-9161ab597505@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
 <Zkfvi3eWbvg9JGs0MGgGie4Mmj7ToEadXxf3RtY2l_0=.e3589df6-595f-4a11-98b2-9161ab597505@github.com>
Message-ID: <nXZT5914eHrahw4YiA8geVZ3ImjTdVqosaL49shBblA=.dfea9787-8a9c-480b-9627-68dd2707c556@github.com>

On Thu, 26 Sep 2024 07:04:52 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>Yes, I think the call to java_md_macosx.m seems redundant. And I would remove the comment in java_md_common.c. strerror is >used at various places in JDK coding and there's actually only one place that uses strerror_r, in jni_util_md.c

Thanks for the comment;  should I change it in this PR or separately ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21182#issuecomment-2376105104

From mbaesken at openjdk.org  Thu Sep 26 07:10:11 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Thu, 26 Sep 2024 07:10:11 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
 [v2]
In-Reply-To: <HvGbitEArV8r4soTDxX95-GW7jRqGcVcEm-c2okGX8A=.b331bd3e-6b5a-48c2-b2b7-f8bd542fc96f@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
 <HvGbitEArV8r4soTDxX95-GW7jRqGcVcEm-c2okGX8A=.b331bd3e-6b5a-48c2-b2b7-f8bd542fc96f@github.com>
Message-ID: <we21Wj8Dpc6Iwf-uoZuJwUCiNK-nUGMa_gw6dMTpW98=.62dc3ac0-eb3c-44e9-b79f-0d63549a6504@github.com>

On Thu, 26 Sep 2024 06:53:41 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove rc
>
> src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m line 278:
> 
>> 276:     int rslt = pthread_attr_init(&attr);
>> 277:     if (rslt != 0) return;
>> 278:     rc = pthread_create(&thr, &attr, SplashScreenThread, (void *) splash);
> 
> For the sake of symmetry, could you rename rc to rslt here?

Sure, I changed it .

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21182#discussion_r1776497907

From abhiscxk at openjdk.org  Thu Sep 26 08:12:14 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 26 Sep 2024 08:12:14 GMT
Subject: RFR: 8340437: Open source few more AWT Frame related tests
Message-ID: <9QKIqkcpfibamjrGdJsGBFMH7q1YcT23mdhS-opzfRQ=.2edd9fc4-648b-4ef4-8858-19433b35aed0@github.com>

AWT Frame related tests are converted from applet to manual/automated and moved to open.

-------------

Commit messages:
 - Frame related test open sourced

Changes: https://git.openjdk.org/jdk/pull/21199/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21199&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340437
  Stats: 770 lines in 4 files changed: 770 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21199.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21199/head:pull/21199

PR: https://git.openjdk.org/jdk/pull/21199

From clanger at openjdk.org  Thu Sep 26 09:38:40 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Thu, 26 Sep 2024 09:38:40 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
In-Reply-To: <nXZT5914eHrahw4YiA8geVZ3ImjTdVqosaL49shBblA=.dfea9787-8a9c-480b-9627-68dd2707c556@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
 <Zkfvi3eWbvg9JGs0MGgGie4Mmj7ToEadXxf3RtY2l_0=.e3589df6-595f-4a11-98b2-9161ab597505@github.com>
 <nXZT5914eHrahw4YiA8geVZ3ImjTdVqosaL49shBblA=.dfea9787-8a9c-480b-9627-68dd2707c556@github.com>
Message-ID: <wJThu1Iyog3VhrPDiNXltuvqMKL7OuKcB-XKFTi1A80=.32c75623-2f4b-4503-a25d-620b8e791850@github.com>

On Thu, 26 Sep 2024 07:07:27 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> > Yes, I think the call to java_md_macosx.m seems redundant. And I would remove the comment in java_md_common.c. strerror is >used at various places in JDK coding and there's actually only one place that uses strerror_r, in jni_util_md.c
> 
> Thanks for the comment; should I change it in this PR or separately ?

I guess it's good to do this cleanup in this one as it touches similar coding...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21182#issuecomment-2376447188

From psadhukhan at openjdk.org  Thu Sep 26 09:49:05 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 26 Sep 2024 09:49:05 GMT
Subject: RFR: 8340621: Open source several AWT List tests
Message-ID: <YVyV6xsPjwRo0o8xo0FZT1C9qzkW8q3lFRmI-OwMW4E=.ccb1d178-2ebe-4e49-8db3-32e22534b49f@github.com>

Opensource few AWT List tests

-------------

Commit messages:
 - 8340621: Open source several AWT List tests

Changes: https://git.openjdk.org/jdk/pull/21202/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21202&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340621
  Stats: 500 lines in 5 files changed: 500 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21202.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21202/head:pull/21202

PR: https://git.openjdk.org/jdk/pull/21202

From jwaters at openjdk.org  Thu Sep 26 10:43:34 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Thu, 26 Sep 2024 10:43:34 GMT
Subject: RFR: 8340801: Disable ubsan checks in some awt/2d coding
In-Reply-To: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
References: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
Message-ID: <hwvD_1EGftmYe9CxpZQeoqp3mtvLVbFAn4BIL4bVgaE=.21938e96-a569-426b-b8c5-97024f4f529a@github.com>

On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> There is some old awt/2d coding where warnings occur when running with ubsan enabled binaries.
> However at most of these locations the coding should work (at least on our supported platform set) so the warnings can be disabled at least for now.
> 
> The change adds a macro ATTRIBUTE_NO_UBSAN  similar to what we already use in Hotspot coding.

jni_md.h seems like a pretty big sledgehammer for something that seems to only be in one file, for just java.desktop. Is this macro planned to be used outside of java.desktop?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21184#issuecomment-2376587585

From jwaters at openjdk.org  Thu Sep 26 10:49:34 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Thu, 26 Sep 2024 10:49:34 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
In-Reply-To: <Zkfvi3eWbvg9JGs0MGgGie4Mmj7ToEadXxf3RtY2l_0=.e3589df6-595f-4a11-98b2-9161ab597505@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
 <Zkfvi3eWbvg9JGs0MGgGie4Mmj7ToEadXxf3RtY2l_0=.e3589df6-595f-4a11-98b2-9161ab597505@github.com>
Message-ID: <6Au0dLxlFxRuAZfeUNLEJKm22q5PaykN3qXo2iiaRyI=.1254832b-c9c3-476e-a5eb-30e338240624@github.com>

On Thu, 26 Sep 2024 07:04:52 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> I found some strange handling of the return value on macOS. Here we check already the return value of pthread_create ; but then it seems we add the errno twice when calling JLI_ReportErrorMessageSys, once in the calling params and once in JLI_ReportErrorMessageSys itself. Should we better call with the return value of pthread_create in the error case? Or just with a string without additional parameters? The comment about Solaris 8 is also very outdated, don't think we need that any more in jdk24.
> 
> ```
> src/java.base/macosx/native/libjli/java_md_macosx.m 
> 
> 312     if (pthread_create(&main_thr, NULL, &apple_main, &args) != 0) {
> 313         JLI_ReportErrorMessageSys("Could not create main thread: %s\n", strerror(errno));
> 
> src/java.base/unix/native/libjli/java_md_common.c
> 
> 244  JLI_ReportErrorMessageSys(const char* fmt, ...) {
> 245      va_list vl;
> 246      char *emsg;
> 247  
> 248      /*
> 249       * TODO: its safer to use strerror_r but is not available on
> 250       * Solaris 8. Until then....
> 251       */
> 252      emsg = strerror(errno);
> 253      if (emsg != NULL) {
> 254          fprintf(stderr, "%s\n", emsg);
> 255      }
> ```

Ah, that problem with JLI_ReportErrorMessageSys. I recall that me and Thomas reported a possibly related issue for it ages ago
https://bugs.openjdk.org/browse/JDK-8292016

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21182#issuecomment-2376597702

From aivanov at openjdk.org  Thu Sep 26 11:37:43 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 26 Sep 2024 11:37:43 GMT
Subject: Integrated: 8340899: Remove wildcard bound in
 PositionWindows.positionTestWindows
In-Reply-To: <hu-Y60yuVFxHJ7jhraW8rehzV_XMTeqcjoyZGxrr6E4=.54ce9e30-a87b-4ac5-8c94-e10381a077c0@github.com>
References: <hu-Y60yuVFxHJ7jhraW8rehzV_XMTeqcjoyZGxrr6E4=.54ce9e30-a87b-4ac5-8c94-e10381a077c0@github.com>
Message-ID: <DeWAURE7GS1zQRM2hR5UQk50YXSkxuzgj26uNj4bSv8=.26465df6-733a-46b2-98f0-fdfe7282a48b@github.com>

On Wed, 25 Sep 2024 11:31:38 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Removes the wildcard bound from `PassFailJFrame.PositionWindows.positionTestWindows` so that implementing the interface is simpler as one don't have to remember to declare the `testWindows` parameter as `List<? extends Window>` ? just use `List<Window>`.
> 
> It is a backwards compatible change, all the tests which use `List<? extends Window>` continue to compile successfully.

This pull request has now been integrated.

Changeset: e2626db2
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e2626db2f00d0cc9f3ff8ea374a1ccc89373e398
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8340899: Remove wildcard bound in PositionWindows.positionTestWindows

Reviewed-by: azvegint, prr

-------------

PR: https://git.openjdk.org/jdk/pull/21181

From aivanov at openjdk.org  Thu Sep 26 11:39:40 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 26 Sep 2024 11:39:40 GMT
Subject: Integrated: 8340466: Add description for PassFailJFrame constructors
In-Reply-To: <YDqxPeO0ID6Xf_JF-oHqYOtgWfCVY93sP2AeoiFnOoM=.ff6f613d-30f0-4a90-bc7d-1f6c6fe2665a@github.com>
References: <YDqxPeO0ID6Xf_JF-oHqYOtgWfCVY93sP2AeoiFnOoM=.ff6f613d-30f0-4a90-bc7d-1f6c6fe2665a@github.com>
Message-ID: <r-9JLwLvZ0pchFZh1F_28AgDbTDCTQ0dz13f9EVrGT8=.367574d0-e65d-475d-a6b9-4eb6b2f97941@github.com>

On Mon, 23 Sep 2024 20:40:47 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I added description to all the constructors available in `PassFailJFrame`.
> 
> I generated the javadoc for it: [`PassFailJFrame` constructor details](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html#constructor-detail) which is easier to read. This hosted javadoc could be used as a reference to its API.
> 
> The constructor with the largest number of parameters contains a short description of how to use the `PassFailJFrame` object.
> 
> Shall we deprecate the constructors in favour of `Builder`?
> 
> The builder provides a more streamlined experience, therefore new tests should use it instead of constructors. We may update the tests which use the constructors, after which the constructors can be removed.

This pull request has now been integrated.

Changeset: 3762ec39
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3762ec3978bfe9910929ab22aaf238e9f4c84630
Stats:     153 lines in 1 file changed: 96 ins; 14 del; 43 mod

8340466: Add description for PassFailJFrame constructors

Reviewed-by: prr, honkar

-------------

PR: https://git.openjdk.org/jdk/pull/21145

From psadhukhan at openjdk.org  Thu Sep 26 11:47:17 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 26 Sep 2024 11:47:17 GMT
Subject: RFR: 8340639: Open source few more AWT List tests
Message-ID: <Ryv0vapuxFUfZxC82_Ocj56gRFybhh_tkC0yjVTSMWw=.07764b87-620e-44b9-b795-f7a3418e6694@github.com>

Opensource few more AWT List tests

-------------

Commit messages:
 - 8340639: Open source few more AWT List tests
 - 8340639: Open source few more AWT List tests

Changes: https://git.openjdk.org/jdk/pull/21205/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21205&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340639
  Stats: 388 lines in 4 files changed: 388 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21205.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21205/head:pull/21205

PR: https://git.openjdk.org/jdk/pull/21205

From mbaesken at openjdk.org  Thu Sep 26 11:53:37 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Thu, 26 Sep 2024 11:53:37 GMT
Subject: RFR: 8340801: Disable ubsan checks in some awt/2d coding
In-Reply-To: <hwvD_1EGftmYe9CxpZQeoqp3mtvLVbFAn4BIL4bVgaE=.21938e96-a569-426b-b8c5-97024f4f529a@github.com>
References: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
 <hwvD_1EGftmYe9CxpZQeoqp3mtvLVbFAn4BIL4bVgaE=.21938e96-a569-426b-b8c5-97024f4f529a@github.com>
Message-ID: <j7pOVmjxxK1CVYBJzpfVGYTNTH1v0Ee3Gp-Zbu0JQak=.a8262ff2-937c-47ce-a06c-73cf46343601@github.com>

On Thu, 26 Sep 2024 10:41:25 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> jni_md.h seems like a pretty big sledgehammer for something that seems to only be in one file, for just java.desktop. Is this macro planned to be used outside of java.desktop?

Yes I have a couple (currently 2) more I would like to exclude as well .
The exclusions should work (similar to HS) for the whole  JDK C codebase.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21184#issuecomment-2376722785

From mbaesken at openjdk.org  Thu Sep 26 12:04:37 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Thu, 26 Sep 2024 12:04:37 GMT
Subject: RFR: 8340801: Disable ubsan checks in some awt/2d coding
In-Reply-To: <j7pOVmjxxK1CVYBJzpfVGYTNTH1v0Ee3Gp-Zbu0JQak=.a8262ff2-937c-47ce-a06c-73cf46343601@github.com>
References: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
 <hwvD_1EGftmYe9CxpZQeoqp3mtvLVbFAn4BIL4bVgaE=.21938e96-a569-426b-b8c5-97024f4f529a@github.com>
 <j7pOVmjxxK1CVYBJzpfVGYTNTH1v0Ee3Gp-Zbu0JQak=.a8262ff2-937c-47ce-a06c-73cf46343601@github.com>
Message-ID: <uBDB-VUw8-MF8hCBvkHNLEJ8UmBqv6ZgRXya07vR2iM=.6986c899-f0a4-4859-9ee5-a734a30103ce@github.com>

On Thu, 26 Sep 2024 11:51:19 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> The exclusions should work (similar to HS) for the whole JDK C codebase.

Maybe we can offer a separate header ub.hpp next to jni_md.h  that contains the macro/attribute stuff.
Similar to sanitizers/ub.hpp in HS.  This header is then included in the few files were the macro/attributes are needed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21184#issuecomment-2376743367

From azvegint at openjdk.org  Thu Sep 26 12:36:44 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 26 Sep 2024 12:36:44 GMT
Subject: Integrated: 8340687: Open source closed frame tests #1
In-Reply-To: <L0esVp8RRIiKlUOg1PO7z49Xo45zAVnLeWsAQSEkWF8=.8a32ec1c-c597-4b1d-b21d-4b37fb58ca04@github.com>
References: <L0esVp8RRIiKlUOg1PO7z49Xo45zAVnLeWsAQSEkWF8=.8a32ec1c-c597-4b1d-b21d-4b37fb58ca04@github.com>
Message-ID: <oKzj73D-Dk-2a4lAo6rdFM-cF_vpxZnh6ilDESnKnHI=.4b3638aa-c841-468b-b29f-9c89f9c1d339@github.com>

On Wed, 25 Sep 2024 10:48:53 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> few more tests to open source
> 
> Testing looks good

This pull request has now been integrated.

Changeset: 47fcf5a3
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/47fcf5a3b0796ffeb6407be961ceb552ca2a40f8
Stats:     458 lines in 4 files changed: 458 ins; 0 del; 0 mod

8340687: Open source closed frame tests #1

Reviewed-by: aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/21180

From aivanov at openjdk.org  Thu Sep 26 13:05:11 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 26 Sep 2024 13:05:11 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in PassFailJFrame
Message-ID: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>

Provides a set of default layouts for manual test using multiple test UI windows.

The initial implementation in the demo in #15721 was too complicated. After looking at the simplified version used in #21180, I re-worked the layouts into separate methods.

The layout methods are in `WindowLayouts` class next to `PassFailJFrame`. It is not necessary to mention it explicitly in the `@build` jtreg tag.

The builder now provides new methods:

- `positionTestUIRightRow` positions the test UI windows in a row to the right of the instruction frame. The top of the windows is aligned to that of the instruction frame.
- `positionTestUIRightColumn` positions the test UI windows in a column to the right of the instruction frame. The top of the first window is aligned to that of the instruction frame.
- `positionTestUIRightColumnCentered` positions the test UI windows in a column to the right of the instruction frame centering the stack of the windows.
- `positionTestUIBottomRow` positions the test UI windows in a row to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
- `positionTestUIBottomRowCentered` positions the test UI windows in a row to the bottom of the instruction frame centering the row of the windows.
- `positionTestUIBottomColumn` positions the test UI windows in a column to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.

If required, the test developer can provide a custom implementation.

-------------

Commit messages:
 - 8317116: Provide layouts for multiple test UI in PassFailJFrame

Changes: https://git.openjdk.org/jdk/pull/21207/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21207&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8317116
  Stats: 320 lines in 2 files changed: 316 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/21207.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21207/head:pull/21207

PR: https://git.openjdk.org/jdk/pull/21207

From aturbanov at openjdk.org  Thu Sep 26 13:09:39 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Thu, 26 Sep 2024 13:09:39 GMT
Subject: RFR: 8340621: Open source several AWT List tests
In-Reply-To: <YVyV6xsPjwRo0o8xo0FZT1C9qzkW8q3lFRmI-OwMW4E=.ccb1d178-2ebe-4e49-8db3-32e22534b49f@github.com>
References: <YVyV6xsPjwRo0o8xo0FZT1C9qzkW8q3lFRmI-OwMW4E=.ccb1d178-2ebe-4e49-8db3-32e22534b49f@github.com>
Message-ID: <-z1wDm3pTKdx_Z6ZIwLM9_bZY5EKTXRsPn8AKaz_WdQ=.c86c6b6e-cd03-43bd-9ace-ed8ac48bfe0a@github.com>

On Thu, 26 Sep 2024 09:43:25 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few AWT List tests

test/jdk/java/awt/List/DisabledListIsGreyTest.java line 63:

> 61:         List list1 = new List(3);
> 62:         List list2 = new List(3);
> 63:         for(int i = 0; i < 5; i++) {

Suggestion:

        for (int i = 0; i < 5; i++) {

test/jdk/java/awt/List/ListFrameResizeTest.java line 67:

> 65:     private static Frame createTestUI() {
> 66:         wintest client = new wintest("ListFrameResizeTest Frame");
> 67:         client.resize(500,300);

Suggestion:

        client.resize(500, 300);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21202#discussion_r1777043004
PR Review Comment: https://git.openjdk.org/jdk/pull/21202#discussion_r1777041094

From aturbanov at openjdk.org  Thu Sep 26 13:13:44 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Thu, 26 Sep 2024 13:13:44 GMT
Subject: RFR: 8340354: Open source AWT desktop properties and print related
 tests
In-Reply-To: <yOfPiZp2v3H8OSK4-Wv2GV2SeZq7x0heUpdXWQyKav0=.7f1df951-2c9d-4e6c-b2b2-3464caeaa711@github.com>
References: <yOfPiZp2v3H8OSK4-Wv2GV2SeZq7x0heUpdXWQyKav0=.7f1df951-2c9d-4e6c-b2b2-3464caeaa711@github.com>
Message-ID: <L6d05jGqcrpbLdMIlr5drZQhUL1nzaNqM0aATArAS2E=.66582b50-390b-4ed3-b025-7c3bd326e90c@github.com>

On Thu, 26 Sep 2024 05:47:33 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> AWT Desktop properties and printer related tests are converted from applet to manual and moved to open.

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 195:

> 193:         menu3.setEnabled(false);
> 194:         menu4.setEnabled(false);
> 195:         MenuItem itemPrinter  = new MenuItem("Print to Printer...");

Suggestion:

        MenuItem itemPrinter = new MenuItem("Print to Printer...");

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 196:

> 194:         menu4.setEnabled(false);
> 195:         MenuItem itemPrinter  = new MenuItem("Print to Printer...");
> 196:         MenuItem itemScreen  = new MenuItem("Print to Screen...");

Suggestion:

        MenuItem itemScreen = new MenuItem("Print to Screen...");

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 214:

> 212:     {
> 213:         Enumeration propNames = props.propertyNames();
> 214:         while(propNames.hasMoreElements()) {

Suggestion:

        while (propNames.hasMoreElements()) {

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 229:

> 227:             PrintJob pj = getToolkit().getPrintJob(
> 228:                 MainFrame.this, "Print test!", props);
> 229:             if( pj == null ) {

Suggestion:

            if (pj == null) {

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 274:

> 272:     class ActionPrintToScreen implements ActionListener {
> 273:         public void actionPerformed(ActionEvent ev) {
> 274:             PrintFrame  printFrame = new PrintFrame( MainFrame.this );

Suggestion:

            PrintFrame printFrame = new PrintFrame( MainFrame.this );

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 312:

> 310:         String label;
> 311:         int     width = 100;
> 312:         int     height = 30;

Suggestion:

        int width = 100;
        int height = 30;

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 332:

> 330:         public Dimension getPreferredSize()
> 331:         {
> 332:             return new Dimension(width,height);

Suggestion:

            return new Dimension(width, height);

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 364:

> 362:         public Dimension getPreferredSize()
> 363:         {
> 364:             return new Dimension(width,height);

Suggestion:

            return new Dimension(width, height);

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 416:

> 414:             // component at the top of the z-order, that should print
> 415:             // _below_ the native guys to match the screen...
> 416:             add(new LWButton("LWButton"),0);

Suggestion:

            add(new LWButton("LWButton"), 0);

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 227:

> 225:                 new MenuItem("Print to Printer in Background");
> 226:         itemBackground.setActionCommand("none");
> 227:         MenuItem itemScreen  = new MenuItem("Print to Screen...");

Suggestion:

        MenuItem itemScreen = new MenuItem("Print to Screen...");

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 270:

> 268:             PrintJob pj = getToolkit().getPrintJob(
> 269:                     MainFrame.this, "Print test!", jobAttributes, pageAttributes);
> 270:             if( pj == null ) return;

Suggestion:

            if (pj == null) return;

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 312:

> 310:     class ActionPrintToScreen implements ActionListener {
> 311:         public void actionPerformed(ActionEvent ev) {
> 312:             PrintFrame  printFrame = new PrintFrame( MainFrame.this );

Suggestion:

            PrintFrame printFrame = new PrintFrame( MainFrame.this );

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 350:

> 348:         String label;
> 349:         int     width = 100;
> 350:         int     height = 30;

Suggestion:

        int width = 100;
        int height = 30;

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 370:

> 368:         public Dimension getPreferredSize()
> 369:         {
> 370:             return new Dimension(width,height);

Suggestion:

            return new Dimension(width, height);

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 402:

> 400:         public Dimension getPreferredSize()
> 401:         {
> 402:             return new Dimension(width,height);

Suggestion:

            return new Dimension(width, height);

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 454:

> 452:             // component at the top of the z-order, that should print
> 453:             // _below_ the native guys to match the screen...
> 454:             add(new LWButton("LWButton"),0);

Suggestion:

            add(new LWButton("LWButton"), 0);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777050594
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777050882
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777052492
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777052858
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777053052
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777053426
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777053649
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777053854
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777054089
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777045638
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777046211
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777046623
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777047330
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777048754
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777049214
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777049932

From aturbanov at openjdk.org  Thu Sep 26 13:14:39 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Thu, 26 Sep 2024 13:14:39 GMT
Subject: RFR: 8340560: Open Source several AWT/2D font and rendering tests
In-Reply-To: <PID9btqC7r9H4iRAG1fPdARMP_XuuaS1MrmUUiHuBUU=.618165ee-264c-40dc-adb8-438c161111c6@github.com>
References: <PID9btqC7r9H4iRAG1fPdARMP_XuuaS1MrmUUiHuBUU=.618165ee-264c-40dc-adb8-438c161111c6@github.com>
Message-ID: <jyiZo3UMqaDbu--S0EgstVoZGNndGdxHqIj4LAthULE=.a2cb6850-821c-42ad-97ef-467edce57b25@github.com>

On Wed, 25 Sep 2024 20:29:40 GMT, Phil Race <prr at openjdk.org> wrote:

> Open sourcing some rendering tests.

test/jdk/sun/awt/font/TestArabicHebrew.java line 75:

> 73:         int index = font.canDisplayUpTo(str);
> 74:         if (index != -1) {
> 75:             throw new RuntimeException("Cannot display char " +  index + " for " + script);

Suggestion:

            throw new RuntimeException("Cannot display char " + index + " for " + script);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21192#discussion_r1777055226

From psadhukhan at openjdk.org  Thu Sep 26 13:43:27 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 26 Sep 2024 13:43:27 GMT
Subject: RFR: 8340621: Open source several AWT List tests [v2]
In-Reply-To: <YVyV6xsPjwRo0o8xo0FZT1C9qzkW8q3lFRmI-OwMW4E=.ccb1d178-2ebe-4e49-8db3-32e22534b49f@github.com>
References: <YVyV6xsPjwRo0o8xo0FZT1C9qzkW8q3lFRmI-OwMW4E=.ccb1d178-2ebe-4e49-8db3-32e22534b49f@github.com>
Message-ID: <guJeDGfAeMUCtkT232gqrTV1PuvnlT7k3A01vCRE9jU=.8a22518d-2da7-4b9a-9b27-263476f71307@github.com>

> Opensource few AWT List tests

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  spacing

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21202/files
  - new: https://git.openjdk.org/jdk/pull/21202/files/156e2e7d..5ced7942

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21202&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21202&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21202.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21202/head:pull/21202

PR: https://git.openjdk.org/jdk/pull/21202

From aivanov at openjdk.org  Thu Sep 26 13:57:09 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 26 Sep 2024 13:57:09 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
Message-ID: <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>

> Provides a set of default layouts for manual test using multiple test UI windows.
> 
> The initial implementation in the demo in #15721 was too complicated. After looking at the simplified version used in #21180, I re-worked the layouts into separate methods.
> 
> The layout methods are in `WindowLayouts` class next to `PassFailJFrame`. It is not necessary to mention it explicitly in the `@build` jtreg tag.
> 
> The builder now provides new methods:
> 
> - `positionTestUIRightRow` positions the test UI windows in a row to the right of the instruction frame. The top of the windows is aligned to that of the instruction frame.
> - `positionTestUIRightColumn` positions the test UI windows in a column to the right of the instruction frame. The top of the first window is aligned to that of the instruction frame.
> - `positionTestUIRightColumnCentered` positions the test UI windows in a column to the right of the instruction frame centering the stack of the windows.
> - `positionTestUIBottomRow` positions the test UI windows in a row to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
> - `positionTestUIBottomRowCentered` positions the test UI windows in a row to the bottom of the instruction frame centering the row of the windows.
> - `positionTestUIBottomColumn` positions the test UI windows in a column to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
> 
> If required, the test developer can provide a custom implementation.

Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:

  Add missing parentheses for vertical positioning

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21207/files
  - new: https://git.openjdk.org/jdk/pull/21207/files/53d70888..10c9b563

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21207&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21207&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21207.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21207/head:pull/21207

PR: https://git.openjdk.org/jdk/pull/21207

From jwaters at openjdk.org  Thu Sep 26 14:27:34 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Thu, 26 Sep 2024 14:27:34 GMT
Subject: RFR: 8340801: Disable ubsan checks in some awt/2d coding
In-Reply-To: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
References: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
Message-ID: <H2RaDUegzFunqkJNfBjwUVqDfI0tqmJ2LL9qK1a9g-0=.0daa4fa3-f0a4-475b-b2e4-9d8f674f3ca7@github.com>

On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> There is some old awt/2d coding where warnings occur when running with ubsan enabled binaries.
> However at most of these locations the coding should work (at least on our supported platform set) so the warnings can be disabled at least for now.
> 
> The change adds a macro ATTRIBUTE_NO_UBSAN  similar to what we already use in Hotspot coding.

Marked as reviewed by jwaters (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21184#pullrequestreview-2331451920

From jwaters at openjdk.org  Thu Sep 26 14:27:35 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Thu, 26 Sep 2024 14:27:35 GMT
Subject: RFR: 8340801: Disable ubsan checks in some awt/2d coding
In-Reply-To: <j7pOVmjxxK1CVYBJzpfVGYTNTH1v0Ee3Gp-Zbu0JQak=.a8262ff2-937c-47ce-a06c-73cf46343601@github.com>
References: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
 <hwvD_1EGftmYe9CxpZQeoqp3mtvLVbFAn4BIL4bVgaE=.21938e96-a569-426b-b8c5-97024f4f529a@github.com>
 <j7pOVmjxxK1CVYBJzpfVGYTNTH1v0Ee3Gp-Zbu0JQak=.a8262ff2-937c-47ce-a06c-73cf46343601@github.com>
Message-ID: <AJKSyJdqQW29EKBqkj8anqTqGI5XxJyA06UtsOJRA60=.0e3b5082-2595-487e-b772-5eb7189145c1@github.com>

On Thu, 26 Sep 2024 11:51:19 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> > jni_md.h seems like a pretty big sledgehammer for something that seems to only be in one file, for just java.desktop. Is this macro planned to be used outside of java.desktop?
> 
> Yes I have a couple (currently 2) more I would like to exclude as well . The exclusions should work (similar to HS) for the whole JDK C codebase.

Alright, if this is planned to be used across the entire JDK and not just in java.desktop then I guess this should be ok. Indeed, perhaps a ubsan.h header would be appropriate for a macro like this. I'll leave that up to further discussion

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21184#issuecomment-2377128778

From mbaesken at openjdk.org  Thu Sep 26 14:34:38 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Thu, 26 Sep 2024 14:34:38 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
 [v2]
In-Reply-To: <LD_w6J1peRbEj3UHoYHapdY-C4fWVRg7I3UsTi-WPFk=.be958d34-0f21-4b57-9e13-edca6cdb413e@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
 <LD_w6J1peRbEj3UHoYHapdY-C4fWVRg7I3UsTi-WPFk=.be958d34-0f21-4b57-9e13-edca6cdb413e@github.com>
Message-ID: <La-LSVYuPs22T6CxuY2Hq9_xwQJFQIz486FWt6DFIAo=.55da394d-2179-46b4-966b-2ec2aa32965f@github.com>

On Thu, 26 Sep 2024 07:10:10 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> It has been discussed that checking the return value of pthread_create should be done.
>> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove rc

Interesting, the errno is not even set on macOS according to the man page, at least for pthread_detach
https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/pthread_detach.3.html
"Note that the function does not change the value of errno, as it did for some drafts of the standard. "
So better print the return code there in the error case.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21182#issuecomment-2377148133

From mbaesken at openjdk.org  Thu Sep 26 14:44:53 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Thu, 26 Sep 2024 14:44:53 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
 [v3]
In-Reply-To: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
Message-ID: <1hkPgl0OA5lEpF6vEmb9DVg-fNndalfotPEmQegz9-w=.40d1f46e-a7cf-49f9-bd55-10f9b9a033f9@github.com>

> It has been discussed that checking the return value of pthread_create should be done.
> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .

Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:

  some macOS cleanup

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21182/files
  - new: https://git.openjdk.org/jdk/pull/21182/files/c04a074b..8fd42bb2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21182&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21182&range=01-02

  Stats: 14 lines in 2 files changed: 3 ins; 6 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/21182.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21182/head:pull/21182

PR: https://git.openjdk.org/jdk/pull/21182

From mbaesken at openjdk.org  Thu Sep 26 14:44:53 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Thu, 26 Sep 2024 14:44:53 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
 [v2]
In-Reply-To: <LD_w6J1peRbEj3UHoYHapdY-C4fWVRg7I3UsTi-WPFk=.be958d34-0f21-4b57-9e13-edca6cdb413e@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
 <LD_w6J1peRbEj3UHoYHapdY-C4fWVRg7I3UsTi-WPFk=.be958d34-0f21-4b57-9e13-edca6cdb413e@github.com>
Message-ID: <sobs4QUkRe3OkIqlI86_Aarehexg2k06WTwTVWaTfqY=.b33939bd-ba25-490b-8ef1-d9c1567e2187@github.com>

On Thu, 26 Sep 2024 07:10:10 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> It has been discussed that checking the return value of pthread_create should be done.
>> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove rc

I removed the very old Solaris 8 comment.
I adjusted the macOS related code mentioned above.
For pthread_detach, I switched to  JLI_ReportErrorMessage , because the manpage says that errno is not set; so better do not print it in the failure case on macOS.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21182#issuecomment-2377172814

From mbaesken at openjdk.org  Thu Sep 26 14:51:35 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Thu, 26 Sep 2024 14:51:35 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
 [v3]
In-Reply-To: <1hkPgl0OA5lEpF6vEmb9DVg-fNndalfotPEmQegz9-w=.40d1f46e-a7cf-49f9-bd55-10f9b9a033f9@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
 <1hkPgl0OA5lEpF6vEmb9DVg-fNndalfotPEmQegz9-w=.40d1f46e-a7cf-49f9-bd55-10f9b9a033f9@github.com>
Message-ID: <vxR3FOwCXrZg8Fd7nHfj0le4PPDtYIZ5JPh9UcJKQfg=.54151c42-9378-424b-ac67-a1dc257b85d4@github.com>

On Thu, 26 Sep 2024 14:44:53 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> It has been discussed that checking the return value of pthread_create should be done.
>> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   some macOS cleanup

Maybe "Check return value of pthread_create in jdk coding"  does not fit any more for the bug/PR name now ? Any good suggestions?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21182#issuecomment-2377193680

From clanger at openjdk.org  Thu Sep 26 16:03:44 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Thu, 26 Sep 2024 16:03:44 GMT
Subject: RFR: 8339475: Check return value of pthread_create in jdk coding
 [v3]
In-Reply-To: <1hkPgl0OA5lEpF6vEmb9DVg-fNndalfotPEmQegz9-w=.40d1f46e-a7cf-49f9-bd55-10f9b9a033f9@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
 <1hkPgl0OA5lEpF6vEmb9DVg-fNndalfotPEmQegz9-w=.40d1f46e-a7cf-49f9-bd55-10f9b9a033f9@github.com>
Message-ID: <WntR3s6bf81Bm3EfB2zD32-xz0SPfICQAsPDsTryoiQ=.60a70696-84a8-4234-a274-ae8a12d2f148@github.com>

On Thu, 26 Sep 2024 14:44:53 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> It has been discussed that checking the return value of pthread_create should be done.
>> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   some macOS cleanup

LGTM.

The bug title could be changed into something like "Clean up return code handling for pthread calls in library coding"

-------------

Marked as reviewed by clanger (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21182#pullrequestreview-2331751511

From achung at openjdk.org  Thu Sep 26 16:04:31 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 26 Sep 2024 16:04:31 GMT
Subject: RFR: 8339879: Open some dialog swing tests [v2]
In-Reply-To: <LWBp0wnS6GkzFhiFfCeKiIAMO5TjlUcaVyEFPR3UXgM=.8edf3ccc-92c6-4360-bde8-8d8a8d2245e8@github.com>
References: <LWBp0wnS6GkzFhiFfCeKiIAMO5TjlUcaVyEFPR3UXgM=.8edf3ccc-92c6-4360-bde8-8d8a8d2245e8@github.com>
Message-ID: <77Oo7T87dLg_JJmRDqZ0rNZ_qQZMEmfECMFRy-8Jz4g=.1e6f6f3d-2fa9-49ca-abf5-a5c5b24ba2ce@github.com>

> First set of dialog swing tests to open during fall 2024 test sprint

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  update jtreg

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21196/files
  - new: https://git.openjdk.org/jdk/pull/21196/files/d3e65e57..c1534adc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21196&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21196&range=00-01

  Stats: 4 lines in 3 files changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/21196.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21196/head:pull/21196

PR: https://git.openjdk.org/jdk/pull/21196

From achung at openjdk.org  Thu Sep 26 16:04:32 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 26 Sep 2024 16:04:32 GMT
Subject: RFR: 8339879: Open some dialog swing tests [v2]
In-Reply-To: <TeieZgIKMcmUUuLbma1_4YRuZutyu-17A6VDc5ZxkIE=.67575ad2-444b-4ce9-93ae-8b1adcc72ded@github.com>
References: <LWBp0wnS6GkzFhiFfCeKiIAMO5TjlUcaVyEFPR3UXgM=.8edf3ccc-92c6-4360-bde8-8d8a8d2245e8@github.com>
 <TeieZgIKMcmUUuLbma1_4YRuZutyu-17A6VDc5ZxkIE=.67575ad2-444b-4ce9-93ae-8b1adcc72ded@github.com>
Message-ID: <hpLg4Lign0Q9OeZxLraGE4RJH50NSl38qGR0pCLKqrw=.00f8ccc6-d2e4-48a6-8c1d-8d18299621b0@github.com>

On Thu, 26 Sep 2024 06:59:32 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update jtreg
>
> test/jdk/java/awt/Dialog/ShownModalDialogSerializationTest.java line 66:
> 
>> 64:     static void deleteTestUI() {
>> 65:         if (dialog != null) {
>> 66:             dialog.setVisible(false);
> 
> Can be removed.

WIll keep this for test stability

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21196#discussion_r1777372586

From kizune at openjdk.org  Thu Sep 26 16:31:35 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 26 Sep 2024 16:31:35 GMT
Subject: RFR: 8340437: Open source few more AWT Frame related tests
In-Reply-To: <9QKIqkcpfibamjrGdJsGBFMH7q1YcT23mdhS-opzfRQ=.2edd9fc4-648b-4ef4-8858-19433b35aed0@github.com>
References: <9QKIqkcpfibamjrGdJsGBFMH7q1YcT23mdhS-opzfRQ=.2edd9fc4-648b-4ef4-8858-19433b35aed0@github.com>
Message-ID: <j9P-XxNkFCRxe-Uw39rRzdHuUETz7mPXP6F5JU5SdYM=.e8833a1c-4d37-4265-84fa-b18126a8893d@github.com>

On Thu, 26 Sep 2024 08:05:27 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> AWT Frame related tests are converted from applet to manual/automated and moved to open.

Looks good.

-------------

Marked as reviewed by kizune (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21199#pullrequestreview-2331824106

From rgupta at openjdk.org  Thu Sep 26 16:34:45 2024
From: rgupta at openjdk.org (Ravi Gupta)
Date: Thu, 26 Sep 2024 16:34:45 GMT
Subject: Integrated: 8333403: Write a test to check various components events
 are triggered properly
In-Reply-To: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
References: <Brk82HU5d32yH4R_QpqwbTkPPZHAMVLWHxXesIiqZvU=.90f199ea-6140-40a4-be1a-f764418ccfea@github.com>
Message-ID: <--L54NElqy6PQGIZ06EgyJQX0kAIGMnqTjme4a6CU50=.de217a96-18ff-4528-8f7f-21e44505a57c@github.com>

On Mon, 3 Jun 2024 12:22:53 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:

> This testcase checks for the following assertions for Component events:
> 
> 1. When components are resized, moved, hidden and shown the respective events are triggered.
> 2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
> 3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
> 4. When a window is minimized/restored then hidden and shown component events should be triggered.
> 
> Testing:
> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.

This pull request has now been integrated.

Changeset: a02d895f
Author:    Ravi Gupta <rgupta at openjdk.org>
Committer: Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a02d895f7ad59fe33f8a761dbd7bceb0b8dfefc0
Stats:     357 lines in 1 file changed: 357 ins; 0 del; 0 mod

8333403: Write a test to check various components events are triggered properly

Reviewed-by: aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/19521

From aivanov at openjdk.org  Thu Sep 26 17:16:35 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 26 Sep 2024 17:16:35 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
Message-ID: <Oui2cbzSJxQXYOHDtx7JUN2CQfTcHw9ztGso7SsU2Xk=.38b52345-6119-47f5-afd0-5ce6136ebd3b@github.com>

On Thu, 26 Sep 2024 13:57:09 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Provides a set of default layouts for manual test using multiple test UI windows.
>> 
>> The initial implementation in the demo in #15721 was too complicated. After looking at the simplified version used in #21180, I re-worked the layouts into separate methods.
>> 
>> The layout methods are in `WindowLayouts` class next to `PassFailJFrame`. It is not necessary to mention it explicitly in the `@build` jtreg tag.
>> 
>> The builder now provides new methods:
>> 
>> - `positionTestUIRightRow` positions the test UI windows in a row to the right of the instruction frame. The top of the windows is aligned to that of the instruction frame.
>> - `positionTestUIRightColumn` positions the test UI windows in a column to the right of the instruction frame. The top of the first window is aligned to that of the instruction frame.
>> - `positionTestUIRightColumnCentered` positions the test UI windows in a column to the right of the instruction frame centering the stack of the windows.
>> - `positionTestUIBottomRow` positions the test UI windows in a row to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
>> - `positionTestUIBottomRowCentered` positions the test UI windows in a row to the bottom of the instruction frame centering the row of the windows.
>> - `positionTestUIBottomColumn` positions the test UI windows in a column to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
>> 
>> If required, the test developer can provide a custom implementation.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missing parentheses for vertical positioning

A set of demos for each layout is provided in #21210. See [the screenshots](https://github.com/openjdk/jdk/pull/21210#issuecomment-2377200316) there.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21207#issuecomment-2377508683

From honkar at openjdk.org  Thu Sep 26 18:09:15 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 26 Sep 2024 18:09:15 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v3]
In-Reply-To: <Bbzzp5BZ9XbIqt5m9glHmwscI44I5i1LvVtPzbbwYFo=.d5926559-45b4-4071-aaff-dfdd8656d8a1@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
 <M_frFO86zmARq3cQ9sxjd_eBUcKKbTy9CPBxjNlDaQM=.70fd26e0-b5c2-4eb6-99c2-0be792df7bc1@github.com>
 <Bbzzp5BZ9XbIqt5m9glHmwscI44I5i1LvVtPzbbwYFo=.d5926559-45b4-4071-aaff-dfdd8656d8a1@github.com>
Message-ID: <ErRmBPQTlylCe5SMPEJpr_aAivXWPtxlJIJEZCOp5Xw=.689282c2-73f5-4903-a513-c2a5aa081cb1@github.com>

On Wed, 25 Sep 2024 07:19:09 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - Merge master
>>  - problemlist updated
>>  - eof newline
>>  - checkbox tests
>
> test/jdk/ProblemList.txt line 797:
> 
>> 795: java/awt/Checkbox/CheckboxBoxSizeTest.java 8340870 windows-all
>> 796: java/awt/Checkbox/CheckboxIndicatorSizeTest.java 8340870 windows-all
>> 797: java/awt/Checkbox/CheckboxBoxSizeTest.java 8340870 windows-all
> 
> duplicate addition CheckboxBoxSizeTest

Good catch. Updated.

> test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java line 58:
> 
>> 56: 
>> 57:      private static Frame createAndShowUI() {
>> 58:          StrangeCheckbox cbox = new StrangeCheckbox();
> 
> I guess we can bring in the code in the StrangeCheckbox constructor and remove that class altogether as it's not doing anything particular rather than implicitly creating a Frame..

Updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1777537647
PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1777537841

From honkar at openjdk.org  Thu Sep 26 18:09:13 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 26 Sep 2024 18:09:13 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v4]
In-Reply-To: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
Message-ID: <XTWO6szFQCQwYMS-7jJiSp7HBXb_Wn82t3CvTHvIJAg=.56be4854-2441-4fa6-93a6-20cc38b42c0a@github.com>

> Following tests are updated in this PR:
> 
> 1. 	test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java
> 2. 	test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java
> 3. 	test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java
> 4. 	test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  review fixes, updated problemlist

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21094/files
  - new: https://git.openjdk.org/jdk/pull/21094/files/a45d86bb..84249711

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21094&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21094&range=02-03

  Stats: 29 lines in 4 files changed: 7 ins; 13 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/21094.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21094/head:pull/21094

PR: https://git.openjdk.org/jdk/pull/21094

From honkar at openjdk.org  Thu Sep 26 18:12:36 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 26 Sep 2024 18:12:36 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v3]
In-Reply-To: <Bbzzp5BZ9XbIqt5m9glHmwscI44I5i1LvVtPzbbwYFo=.d5926559-45b4-4071-aaff-dfdd8656d8a1@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
 <M_frFO86zmARq3cQ9sxjd_eBUcKKbTy9CPBxjNlDaQM=.70fd26e0-b5c2-4eb6-99c2-0be792df7bc1@github.com>
 <Bbzzp5BZ9XbIqt5m9glHmwscI44I5i1LvVtPzbbwYFo=.d5926559-45b4-4071-aaff-dfdd8656d8a1@github.com>
Message-ID: <JxZ3bC5jNm4BLVMl-SI2nkgPyQbochlqPGiehbIUMKg=.bf0ff1e8-4486-4c6e-848e-daa4ce6bc630@github.com>

On Wed, 25 Sep 2024 07:04:38 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - Merge master
>>  - problemlist updated
>>  - eof newline
>>  - checkbox tests
>
> test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java line 43:
> 
>> 41:     private static final String INSTRUCTIONS = """
>> 42:             This test must be run at UI Scale of 100% OR 150% or greater.
>> 43:             Compare the size of box to any of native apps on Windows
> 
> Maybe you can mention anyone of the native app for easy verification...
> Also, it seems if tester tests with 100%, it might look same and tester can pass it...I guess the problem comes with hidpi scale of 150% or more, so maybe we can remove 100% from instruction OR mention 100% AND 150% to check for both...

Updated instructions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1777543178

From honkar at openjdk.org  Thu Sep 26 18:28:53 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 26 Sep 2024 18:28:53 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v5]
In-Reply-To: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
Message-ID: <X-Gpic6v9ND5nGNTf_lZ7t6Xs0fL8zcSytdUlOKcgpI=.53e9383f-b6df-4fd0-8a89-fa53bdab6087@github.com>

> Following tests are updated in this PR:
> 
> 1. 	test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java
> 2. 	test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java
> 3. 	test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java
> 4. 	test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  removed validate()

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21094/files
  - new: https://git.openjdk.org/jdk/pull/21094/files/84249711..a9212cfc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21094&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21094&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21094.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21094/head:pull/21094

PR: https://git.openjdk.org/jdk/pull/21094

From honkar at openjdk.org  Thu Sep 26 18:28:56 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 26 Sep 2024 18:28:56 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v3]
In-Reply-To: <Bbzzp5BZ9XbIqt5m9glHmwscI44I5i1LvVtPzbbwYFo=.d5926559-45b4-4071-aaff-dfdd8656d8a1@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
 <M_frFO86zmARq3cQ9sxjd_eBUcKKbTy9CPBxjNlDaQM=.70fd26e0-b5c2-4eb6-99c2-0be792df7bc1@github.com>
 <Bbzzp5BZ9XbIqt5m9glHmwscI44I5i1LvVtPzbbwYFo=.d5926559-45b4-4071-aaff-dfdd8656d8a1@github.com>
Message-ID: <4uYLTQ9HH4N2UhDeGokzwJsOUmVWEapdwSZqUTRgvbs=.fbe18b1e-bc76-4880-95f2-b70b92efc81f@github.com>

On Wed, 25 Sep 2024 07:07:22 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - Merge master
>>  - problemlist updated
>>  - eof newline
>>  - checkbox tests
>
> test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java line 65:
> 
>> 63:             Verify that all indicators of checkboxes has the same size.
>> 64:             Verify that all indicators of radio buttons has the same size.
>> 65:             Press PASS if the above conditions are true else Press FAIL.
> 
> I guess "Same size" is not correct here...I guess what we meant is the size should be proportionate to scaling or "size will change if font size is changed", it seems the size does not increase if we increase the scale..
> but it still remains the "same", so some tester can consider it pass

@prsadhuk I have a clarification about this: 
Does thecheckbox size depend on label size (font size) and they need to be scaled proportionately or is the size dependent only on uiScale?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1777560509

From prr at openjdk.org  Thu Sep 26 21:27:35 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 26 Sep 2024 21:27:35 GMT
Subject: RFR: 8340801: Disable ubsan checks in some awt/2d coding
In-Reply-To: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
References: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
Message-ID: <xZHRfRmcxI5Nm_rsC5Ev9XFDVJWiCfi6XYl5mb6mdGI=.9cfc12bb-5d33-4ec1-a932-9fbd1e63a60b@github.com>

On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> There is some old awt/2d coding where warnings occur when running with ubsan enabled binaries.
> However at most of these locations the coding should work (at least on our supported platform set) so the warnings can be disabled at least for now.
> 
> The change adds a macro ATTRIBUTE_NO_UBSAN  similar to what we already use in Hotspot coding.

This needs careful thinking about by various parties.
I am not sold on it, and the build team have indicated they do not support --enable-ubsan and my experience with that and similar options is that they are a nightmare to find a system on which they build and produce a working binary.

Until there's solid committed support by the leads of the build team I don't think we should be considering these kinds of PRs.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21184#issuecomment-2377966195

From honkar at openjdk.org  Thu Sep 26 21:56:23 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 26 Sep 2024 21:56:23 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4
Message-ID: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>

Following tests are added as part of this PR:

1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual PassFailJFrame (PFJ) test**, problemlisted on all platforms.

2. java/awt/dnd/DragSourceMotionListenerTest.java -  **Automated test**, problemlisted on windows

3. /java/awt/dnd/DragToAnotherScreenTest.java - **Manual PFJ test**

4. /java/awt/dnd/RejectDragTest.java - **Automated test**, problemlisted on macOS

-------------

Commit messages:
 - open problemlist updated
 - open-sourced DnD tests

Changes: https://git.openjdk.org/jdk/pull/21213/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21213&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340555
  Stats: 880 lines in 7 files changed: 880 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21213.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21213/head:pull/21213

PR: https://git.openjdk.org/jdk/pull/21213

From honkar at openjdk.org  Fri Sep 27 00:04:39 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 27 Sep 2024 00:04:39 GMT
Subject: RFR: 8339879: Open some dialog swing tests [v2]
In-Reply-To: <77Oo7T87dLg_JJmRDqZ0rNZ_qQZMEmfECMFRy-8Jz4g=.1e6f6f3d-2fa9-49ca-abf5-a5c5b24ba2ce@github.com>
References: <LWBp0wnS6GkzFhiFfCeKiIAMO5TjlUcaVyEFPR3UXgM=.8edf3ccc-92c6-4360-bde8-8d8a8d2245e8@github.com>
 <77Oo7T87dLg_JJmRDqZ0rNZ_qQZMEmfECMFRy-8Jz4g=.1e6f6f3d-2fa9-49ca-abf5-a5c5b24ba2ce@github.com>
Message-ID: <xjisIR366mmW-I7zIy1ttP8OzZNe2lOx-xTb77dhI6k=.0588a232-5c2e-482c-82aa-31719eb3bd1f@github.com>

On Thu, 26 Sep 2024 16:04:31 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> First set of dialog swing tests to open during fall 2024 test sprint
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update jtreg

LGTM other than the minor comments

test/jdk/java/awt/Dialog/DialogInitialResizability.java line 96:

> 94:         }
> 95:     }
> 96: }

Missing EOF newline

test/jdk/java/awt/Dialog/NestedDialogTest.java line 45:

> 43:  * @test
> 44:  * @bug 4110094 4178930 4178390
> 45:  * @summary Test: Rewrite of Win32 modal dialogs

Suggestion:

 * @summary Test: Rewrite of Win modal dialogs

test/jdk/java/awt/Dialog/NestedDialogTest.java line 312:

> 310:         super.dispose();
> 311:     }
> 312: }

missing EOF newline

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21196#pullrequestreview-2332532470
PR Review Comment: https://git.openjdk.org/jdk/pull/21196#discussion_r1777861509
PR Review Comment: https://git.openjdk.org/jdk/pull/21196#discussion_r1777861019
PR Review Comment: https://git.openjdk.org/jdk/pull/21196#discussion_r1777861225

From azvegint at openjdk.org  Fri Sep 27 00:55:36 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 27 Sep 2024 00:55:36 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4
In-Reply-To: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
References: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
Message-ID: <b-o6-MAdxR9NZWX1BM9f8ztjUek-EzLYR4DoxbpQLVk=.034fbf68-e4e2-4fc0-8913-691ea7fde0df@github.com>

On Thu, 26 Sep 2024 21:51:44 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following tests are added as part of this PR:
> 
> 1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual PassFailJFrame (PFJ) test**, problemlisted on all platforms.
> 
> 2. java/awt/dnd/DragSourceMotionListenerTest.java -  **Automated test**, problemlisted on windows
> 
> 3. /java/awt/dnd/DragToAnotherScreenTest.java - **Manual PFJ test**
> 
> 4. /java/awt/dnd/RejectDragTest.java - **Automated test**, problemlisted on macOS

Marked as reviewed by azvegint (Reviewer).

test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDSource.java line 71:

> 69:         }
> 70:         return tmp.toByteArray();
> 71:     }

Suggestion:



unused

-------------

PR Review: https://git.openjdk.org/jdk/pull/21213#pullrequestreview-2332556958
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1777877683

From honkar at openjdk.org  Fri Sep 27 01:06:20 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 27 Sep 2024 01:06:20 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4 [v2]
In-Reply-To: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
References: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
Message-ID: <r7taEWe21dP8Oeu1h8FizI6yhmq0-It4cQNzEXjWTV4=.2eafc549-0287-4c24-8213-465c2fea6c23@github.com>

> Following tests are added as part of this PR:
> 
> 1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual PassFailJFrame (PFJ) test**, problemlisted on all platforms.
> 
> 2. java/awt/dnd/DragSourceMotionListenerTest.java -  **Automated test**, problemlisted on windows
> 
> 3. /java/awt/dnd/DragToAnotherScreenTest.java - **Manual PFJ test**
> 
> 4. /java/awt/dnd/RejectDragTest.java - **Automated test**, problemlisted on macOS

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  unused getContent() removed

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21213/files
  - new: https://git.openjdk.org/jdk/pull/21213/files/948c9d14..68f49cc1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21213&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21213&range=00-01

  Stats: 13 lines in 1 file changed: 0 ins; 13 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21213.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21213/head:pull/21213

PR: https://git.openjdk.org/jdk/pull/21213

From honkar at openjdk.org  Fri Sep 27 01:06:20 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 27 Sep 2024 01:06:20 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4 [v2]
In-Reply-To: <b-o6-MAdxR9NZWX1BM9f8ztjUek-EzLYR4DoxbpQLVk=.034fbf68-e4e2-4fc0-8913-691ea7fde0df@github.com>
References: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
 <b-o6-MAdxR9NZWX1BM9f8ztjUek-EzLYR4DoxbpQLVk=.034fbf68-e4e2-4fc0-8913-691ea7fde0df@github.com>
Message-ID: <0vlpVzKy7d0MEDqeGhRKwxJzg6n3G82PygrxKJnV2l4=.b77cce7c-a7bb-48cf-959e-bc4f53263b15@github.com>

On Fri, 27 Sep 2024 00:32:00 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   unused getContent() removed
>
> test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDSource.java line 71:
> 
>> 69:         }
>> 70:         return tmp.toByteArray();
>> 71:     }
> 
> Suggestion:
> 
> 
> 
> unused

Updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1777891201

From azvegint at openjdk.org  Fri Sep 27 01:11:39 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 27 Sep 2024 01:11:39 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4 [v2]
In-Reply-To: <0vlpVzKy7d0MEDqeGhRKwxJzg6n3G82PygrxKJnV2l4=.b77cce7c-a7bb-48cf-959e-bc4f53263b15@github.com>
References: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
 <b-o6-MAdxR9NZWX1BM9f8ztjUek-EzLYR4DoxbpQLVk=.034fbf68-e4e2-4fc0-8913-691ea7fde0df@github.com>
 <0vlpVzKy7d0MEDqeGhRKwxJzg6n3G82PygrxKJnV2l4=.b77cce7c-a7bb-48cf-959e-bc4f53263b15@github.com>
Message-ID: <JZad4UtjtTBWbGu8ZKQr00FCVHwb6DqN2HquHEb_eYA=.7a8ee7fa-340b-43c4-805c-8296393c1923@github.com>

On Fri, 27 Sep 2024 01:02:06 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDSource.java line 71:
>> 
>>> 69:         }
>>> 70:         return tmp.toByteArray();
>>> 71:     }
>> 
>> Suggestion:
>> 
>> 
>> 
>> unused
>
> Updated

import java.io.ByteArrayOutputStream;
import java.io.FileInputStream;
import java.io.IOException;

those are also unused.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1777894234

From azvegint at openjdk.org  Fri Sep 27 01:14:34 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 27 Sep 2024 01:14:34 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4 [v2]
In-Reply-To: <r7taEWe21dP8Oeu1h8FizI6yhmq0-It4cQNzEXjWTV4=.2eafc549-0287-4c24-8213-465c2fea6c23@github.com>
References: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
 <r7taEWe21dP8Oeu1h8FizI6yhmq0-It4cQNzEXjWTV4=.2eafc549-0287-4c24-8213-465c2fea6c23@github.com>
Message-ID: <H6-wq_Rs0ZA1XC3-BnRPha-LqODxjQQ75Jm7LJ8n7BQ=.d886d757-3433-4335-bcbc-144b57029121@github.com>

On Fri, 27 Sep 2024 01:06:20 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are added as part of this PR:
>> 
>> 1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual PassFailJFrame (PFJ) test**, problemlisted on all platforms.
>> 
>> 2. java/awt/dnd/DragSourceMotionListenerTest.java -  **Automated test**, problemlisted on windows
>> 
>> 3. /java/awt/dnd/DragToAnotherScreenTest.java - **Manual PFJ test**
>> 
>> 4. /java/awt/dnd/RejectDragTest.java - **Automated test**, problemlisted on macOS
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   unused getContent() removed

test/jdk/java/awt/dnd/RejectDragTest.java line 41:

> 39: import java.awt.dnd.DropTargetDragEvent;
> 40: import java.awt.dnd.DropTargetDropEvent;
> 41: import java.awt.dnd.DropTargetEvent;

Suggestion:

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1777895495

From honkar at openjdk.org  Fri Sep 27 04:17:30 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 27 Sep 2024 04:17:30 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4 [v3]
In-Reply-To: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
References: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
Message-ID: <MAnyM8Icle8vnzSsxU2DH7Ht4IrLApX-6YkcPd7_8-s=.60a04688-4180-4fff-bf39-104cee66b7dd@github.com>

> Following tests are added as part of this PR:
> 
> 1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual PassFailJFrame (PFJ) test**, problemlisted on all platforms.
> 
> 2. java/awt/dnd/DragSourceMotionListenerTest.java -  **Automated test**, problemlisted on windows
> 
> 3. /java/awt/dnd/DragToAnotherScreenTest.java - **Manual PFJ test**
> 
> 4. /java/awt/dnd/RejectDragTest.java - **Automated test**, problemlisted on macOS

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  unused imports

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21213/files
  - new: https://git.openjdk.org/jdk/pull/21213/files/68f49cc1..39f4a395

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21213&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21213&range=01-02

  Stats: 39 lines in 2 files changed: 0 ins; 39 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21213.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21213/head:pull/21213

PR: https://git.openjdk.org/jdk/pull/21213

From psadhukhan at openjdk.org  Fri Sep 27 04:55:35 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 27 Sep 2024 04:55:35 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v3]
In-Reply-To: <4uYLTQ9HH4N2UhDeGokzwJsOUmVWEapdwSZqUTRgvbs=.fbe18b1e-bc76-4880-95f2-b70b92efc81f@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
 <M_frFO86zmARq3cQ9sxjd_eBUcKKbTy9CPBxjNlDaQM=.70fd26e0-b5c2-4eb6-99c2-0be792df7bc1@github.com>
 <Bbzzp5BZ9XbIqt5m9glHmwscI44I5i1LvVtPzbbwYFo=.d5926559-45b4-4071-aaff-dfdd8656d8a1@github.com>
 <4uYLTQ9HH4N2UhDeGokzwJsOUmVWEapdwSZqUTRgvbs=.fbe18b1e-bc76-4880-95f2-b70b92efc81f@github.com>
Message-ID: <f_Wb7P60LF70EH0lFr3WUR9p3nioe9Kmb5t50f6dMCo=.ffe19f16-2ef1-4fd9-a2c4-9e2bc9ef5035@github.com>

On Thu, 26 Sep 2024 18:24:23 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java line 65:
>> 
>>> 63:             Verify that all indicators of checkboxes has the same size.
>>> 64:             Verify that all indicators of radio buttons has the same size.
>>> 65:             Press PASS if the above conditions are true else Press FAIL.
>> 
>> I guess "Same size" is not correct here...I guess what we meant is the size should be proportionate to scaling or "size will change if font size is changed", it seems the size does not increase if we increase the scale..
>> but it still remains the "same", so some tester can consider it pass
>
> @prsadhuk I have a clarification about this: 
> Does the checkbox size depend on label size (font size) and they need to be scaled proportionately or is the checkbox and indicator size dependent only on uiScale?

One is global setting and the other local..and local would get affected by global setting ie
Checkboz size should be proportionate to local label fontsize and 
when we up the global uiScale, it would also increase the label font implicitly which then would affect checkbox size

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1778004732

From mbaesken at openjdk.org  Fri Sep 27 06:27:35 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Fri, 27 Sep 2024 06:27:35 GMT
Subject: RFR: 8339475: Clean up return code handling for pthread calls in
 library coding [v3]
In-Reply-To: <1hkPgl0OA5lEpF6vEmb9DVg-fNndalfotPEmQegz9-w=.40d1f46e-a7cf-49f9-bd55-10f9b9a033f9@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
 <1hkPgl0OA5lEpF6vEmb9DVg-fNndalfotPEmQegz9-w=.40d1f46e-a7cf-49f9-bd55-10f9b9a033f9@github.com>
Message-ID: <z5TZ54W8yZtT5MP1zUThp-BXNV3nNC72VNH7rS8R0BM=.df7ba24c-e0f6-4502-a148-d7cbf3e3059c@github.com>

On Thu, 26 Sep 2024 14:44:53 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> It has been discussed that checking the return value of pthread_create should be done.
>> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   some macOS cleanup

Thanks for the review !  I changed the title too .

Julian, are you fine with the latest rev. ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21182#issuecomment-2378492980

From jwaters at openjdk.org  Fri Sep 27 06:33:36 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Fri, 27 Sep 2024 06:33:36 GMT
Subject: RFR: 8339475: Clean up return code handling for pthread calls in
 library coding [v3]
In-Reply-To: <1hkPgl0OA5lEpF6vEmb9DVg-fNndalfotPEmQegz9-w=.40d1f46e-a7cf-49f9-bd55-10f9b9a033f9@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
 <1hkPgl0OA5lEpF6vEmb9DVg-fNndalfotPEmQegz9-w=.40d1f46e-a7cf-49f9-bd55-10f9b9a033f9@github.com>
Message-ID: <vMVtu9pH6JADKPR0qo8j_fvjVOnX50855DsPvor8kNI=.bfda5a70-d7fc-4608-b2fd-b29655f8e6b5@github.com>

On Thu, 26 Sep 2024 14:44:53 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> It has been discussed that checking the return value of pthread_create should be done.
>> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   some macOS cleanup

I am ok with this. I wonder what @tstuefe and @dholmes-ora think about the JLI_ReportErrorMessageSys changes though. I recall one of them preferring strerror_r over strerror

-------------

Marked as reviewed by jwaters (Committer).

PR Review: https://git.openjdk.org/jdk/pull/21182#pullrequestreview-2332853638

From mbaesken at openjdk.org  Fri Sep 27 06:48:34 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Fri, 27 Sep 2024 06:48:34 GMT
Subject: RFR: 8340801: Disable ubsan checks in some awt/2d coding
In-Reply-To: <xZHRfRmcxI5Nm_rsC5Ev9XFDVJWiCfi6XYl5mb6mdGI=.9cfc12bb-5d33-4ec1-a932-9fbd1e63a60b@github.com>
References: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
 <xZHRfRmcxI5Nm_rsC5Ev9XFDVJWiCfi6XYl5mb6mdGI=.9cfc12bb-5d33-4ec1-a932-9fbd1e63a60b@github.com>
Message-ID: <kzaKJvULt9BpWyh-xiePRrDa4zfR_3xbRsVnn_LELoE=.d4ddfaa6-c4ee-4a17-b845-df4111ecd713@github.com>

On Thu, 26 Sep 2024 21:25:07 GMT, Phil Race <prr at openjdk.org> wrote:

> build team have indicated they do not support --enable-ubsan 

What 'build team' are you talking about ? Some Oracle internal build team?
The ubsan support came in 2023, so nothing new (change was from Justin King)
https://github.com/openjdk/jdk/commit/7a85d95e828283d57e1df0344be454626470675d
And it was reviewed by erikj and ihse, I think those are members of the OpenJDK build group and very competent OpenJDK reviewers.
So the flag is as good or bad as any other configure flag of OpenJDK .

>and my experience with that and similar options is that they are a nightmare to find a system on which they build

We use and run this regularly on SUSE and Ubuntu Linux and have VERY good experience with it. It works (at least on recent Linux distros) very well. (on macOS our experience is a bit different there I had a couple of issues with ubsan)
A lot of large C/C++ based OSS projects support it like Linux kernel, Android, Chromium etc.
https://docs.kernel.org/dev-tools/ubsan.html
https://source.android.com/docs/security/test/ubsan
https://www.chromium.org/developers/testing/undefinedbehaviorsanitizer/

and btw.  Oracle blogs happily about it too and recommends it 
https://blogs.oracle.com/linux/post/improving-application-security-with-undefinedbehaviorsanitizer-ubsan-and-gcc
So it is a well established tool in the OSS world.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21184#issuecomment-2378520093

From jwaters at openjdk.org  Fri Sep 27 07:09:37 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Fri, 27 Sep 2024 07:09:37 GMT
Subject: RFR: 8340801: Disable ubsan checks in some awt/2d coding
In-Reply-To: <kzaKJvULt9BpWyh-xiePRrDa4zfR_3xbRsVnn_LELoE=.d4ddfaa6-c4ee-4a17-b845-df4111ecd713@github.com>
References: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
 <xZHRfRmcxI5Nm_rsC5Ev9XFDVJWiCfi6XYl5mb6mdGI=.9cfc12bb-5d33-4ec1-a932-9fbd1e63a60b@github.com>
 <kzaKJvULt9BpWyh-xiePRrDa4zfR_3xbRsVnn_LELoE=.d4ddfaa6-c4ee-4a17-b845-df4111ecd713@github.com>
Message-ID: <Jrzwm6hTlBFhVxBYBGyzCr9xEKVzCAUOtz8KPQYtOvU=.5ec11b1e-5364-40db-bea5-1b6727448210@github.com>

On Fri, 27 Sep 2024 06:46:24 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> And it was reviewed by erikj and ihse, I think those are members of the OpenJDK build group

Erik and Magnus are indeed part of the build team. Erik is the Skara tool lead but does build work as well, while Magnus is pretty much the face of the build team at this point



> very competent OpenJDK reviewers

If only I could be a competent reviewer one of these days :(

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21184#issuecomment-2378552970

From mbaesken at openjdk.org  Fri Sep 27 07:26:34 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Fri, 27 Sep 2024 07:26:34 GMT
Subject: RFR: 8339475: Clean up return code handling for pthread calls in
 library coding [v3]
In-Reply-To: <vMVtu9pH6JADKPR0qo8j_fvjVOnX50855DsPvor8kNI=.bfda5a70-d7fc-4608-b2fd-b29655f8e6b5@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
 <1hkPgl0OA5lEpF6vEmb9DVg-fNndalfotPEmQegz9-w=.40d1f46e-a7cf-49f9-bd55-10f9b9a033f9@github.com>
 <vMVtu9pH6JADKPR0qo8j_fvjVOnX50855DsPvor8kNI=.bfda5a70-d7fc-4608-b2fd-b29655f8e6b5@github.com>
Message-ID: <yBoe7AmC3Pmp4GKEKFLz_ZdoJ59YvBxEySSTXZKIUWE=.744d7c84-13c8-47c8-ad96-8216c7bc8b1f@github.com>

On Fri, 27 Sep 2024 06:30:54 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> I am ok with this. I wonder what @tstuefe and @dholmes-ora think about the JLI_ReportErrorMessageSys changes though. I recall one of them preferring strerror_r over strerror

Hi Julian, in HS we use a large array of error strings :
8148425: strerror() function is not thread-safe
https://hg.openjdk.org/jdk9/jdk9/hotspot/rev/1537c752a7f5

In case we want to replace strerror in java_md_common.c (by strerror_r or by an array like we use in HS), that would be another separate issue.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21182#issuecomment-2378588837

From mbaesken at openjdk.org  Fri Sep 27 07:30:40 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Fri, 27 Sep 2024 07:30:40 GMT
Subject: Integrated: 8339475: Clean up return code handling for pthread calls
 in library coding
In-Reply-To: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
Message-ID: <wrdHCsqvMnSxmwyzjTc1eCTzr_PDqnHaTQdnk-ZT65Y=.6e91c48d-6c67-419b-96dd-634788cb495e@github.com>

On Wed, 25 Sep 2024 11:46:00 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> It has been discussed that checking the return value of pthread_create should be done.
> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .

This pull request has now been integrated.

Changeset: 2a2ecc99
Author:    Matthias Baesken <mbaesken at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/2a2ecc994e02049d6d84f083b8e92a51368577bf
Stats:     23 lines in 4 files changed: 9 ins; 7 del; 7 mod

8339475: Clean up return code handling for pthread calls in library coding

Reviewed-by: clanger, jwaters

-------------

PR: https://git.openjdk.org/jdk/pull/21182

From mbaesken at openjdk.org  Fri Sep 27 07:46:34 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Fri, 27 Sep 2024 07:46:34 GMT
Subject: RFR: 8340801: Disable ubsan checks in some awt/2d coding
In-Reply-To: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
References: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
Message-ID: <5F8WL1Qh0Lq_JHGMORBPlnpcNwJ8TDR4hZei-R2tcpA=.83d0a9fe-4682-44f8-a57f-3a6cccfd3fc8@github.com>

On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> There is some old awt/2d coding where warnings occur when running with ubsan enabled binaries.
> However at most of these locations the coding should work (at least on our supported platform set) so the warnings can be disabled at least for now.
> 
> The change adds a macro ATTRIBUTE_NO_UBSAN  similar to what we already use in Hotspot coding.

Btw regarding the function/method exclusion, this was introduced in HS some time ago 
https://bugs.openjdk.org/browse/JDK-8334239
We just needed in HS codebase a couple of places where we use/keep undefined behavior  (e.g. im vmError.cpp where it is intentionally used).  Obviously, the mentioned HS change does not work for the other C libs so this is some kind of follow up.
In HS we use the ATTRIBUTE_NO_UBSAN macro currently at 4 code locations.  So it is not intended or likely that this macro would go to a lot of places of the JDK libs, just a small number comparable to usage in HS.
Regarding putting  it into jni_md.h, probably it would moving it from there to a separate header like it is done in HS would be better, I can do that if this is preferred.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21184#issuecomment-2378625842

From psadhukhan at openjdk.org  Fri Sep 27 07:57:36 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 27 Sep 2024 07:57:36 GMT
Subject: RFR: 8340193: Open source several AWT Dialog tests - Batch 1
In-Reply-To: <A_AenkvGSNRrpXk_wcGxZ3Cw-dCFaHsd-75onI6mCX4=.1f17a7fe-701d-417e-8579-08856070ee18@github.com>
References: <A_AenkvGSNRrpXk_wcGxZ3Cw-dCFaHsd-75onI6mCX4=.1f17a7fe-701d-417e-8579-08856070ee18@github.com>
Message-ID: <1iDPjVAbfvfeK0NaWkN3uzNqvieGr-NKKWeAVW0KETE=.283c1d4d-86e3-4ede-8649-54d501139c99@github.com>

On Wed, 25 Sep 2024 07:20:21 GMT, Tejesh R <tr at openjdk.org> wrote:

> Open source these AWT Mouse tests:
> 
> java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java
> java/awt/Dialog/FileDialogWrongNameCrash.java
> java/awt/Dialog/DialogResizeTest.java
> java/awt/Dialog/GetLocationTest_1.java
> java/awt/Dialog/DialogIconTest/DialogIconTest.java

test/jdk/java/awt/Dialog/DialogResizeTest.java line 133:

> 131:     public void componentHidden(ComponentEvent e) {
> 132:         System.out.println("componentHidden event occurred.");
> 133:     }

I guess PassFailJFrame.log would be of more use than System println, if at all these logs are of any help..

test/jdk/java/awt/Dialog/FileDialogWrongNameCrash.java line 58:

> 56: 
> 57:     private static Frame initialize() {
> 58:         Frame frame = new Frame("Frame");

give more meaningful name

test/jdk/java/awt/Dialog/GetLocationTest_1.java line 50:

> 48:                    up with the top left by the cursor
> 49:                 2. If you see this correct behavior press PASS. If you see that
> 50:                    the yellow window is offset by an inset (5, 24) press FAIL

how will tester knows that the inset is of this dimension, it might vary from platform to platform and also vary with different scaling? maybe just delete this hardcoded dimension?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1778177853
PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1778188170
PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1778189364

From tr at openjdk.org  Fri Sep 27 10:09:22 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 27 Sep 2024 10:09:22 GMT
Subject: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v2]
In-Reply-To: <A_AenkvGSNRrpXk_wcGxZ3Cw-dCFaHsd-75onI6mCX4=.1f17a7fe-701d-417e-8579-08856070ee18@github.com>
References: <A_AenkvGSNRrpXk_wcGxZ3Cw-dCFaHsd-75onI6mCX4=.1f17a7fe-701d-417e-8579-08856070ee18@github.com>
Message-ID: <86Vb8yXKc16RS5EW6180IUmGP5ORgSIhuM2kpZUjdDw=.1080dd5e-6760-4c51-91da-979fea7cc28b@github.com>

> Open source these AWT Mouse tests:
> 
> java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java
> java/awt/Dialog/FileDialogWrongNameCrash.java
> java/awt/Dialog/DialogResizeTest.java
> java/awt/Dialog/GetLocationTest_1.java
> java/awt/Dialog/DialogIconTest/DialogIconTest.java

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review comments updated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21174/files
  - new: https://git.openjdk.org/jdk/pull/21174/files/dde69a54..23802939

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21174&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21174&range=00-01

  Stats: 4 lines in 3 files changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/21174.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21174/head:pull/21174

PR: https://git.openjdk.org/jdk/pull/21174

From tr at openjdk.org  Fri Sep 27 10:09:23 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 27 Sep 2024 10:09:23 GMT
Subject: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v2]
In-Reply-To: <1iDPjVAbfvfeK0NaWkN3uzNqvieGr-NKKWeAVW0KETE=.283c1d4d-86e3-4ede-8649-54d501139c99@github.com>
References: <A_AenkvGSNRrpXk_wcGxZ3Cw-dCFaHsd-75onI6mCX4=.1f17a7fe-701d-417e-8579-08856070ee18@github.com>
 <1iDPjVAbfvfeK0NaWkN3uzNqvieGr-NKKWeAVW0KETE=.283c1d4d-86e3-4ede-8649-54d501139c99@github.com>
Message-ID: <brPkqcdO-rqyltEYrncQhWpgT-1j273JWxnOPnJL6cM=.ea4aaa43-b81f-4d32-bfac-de5ef36b945f@github.com>

On Fri, 27 Sep 2024 07:43:06 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments updated
>
> test/jdk/java/awt/Dialog/DialogResizeTest.java line 133:
> 
>> 131:     public void componentHidden(ComponentEvent e) {
>> 132:         System.out.println("componentHidden event occurred.");
>> 133:     }
> 
> I guess PassFailJFrame.log would be of more use than System println, if at all these logs are of any help..

I'm getting this error if I use ` PassFailJFrame.log`  to `componentResize` method.
`java.lang.NullPointerException: Cannot invoke "javax.swing.JTextArea.append(String)" because "PassFailJFrame.logArea" is null`. Since the test is about resize, I've updated only resize related print statement.

> test/jdk/java/awt/Dialog/FileDialogWrongNameCrash.java line 58:
> 
>> 56: 
>> 57:     private static Frame initialize() {
>> 58:         Frame frame = new Frame("Frame");
> 
> give more meaningful name

Updated.

> test/jdk/java/awt/Dialog/GetLocationTest_1.java line 50:
> 
>> 48:                    up with the top left by the cursor
>> 49:                 2. If you see this correct behavior press PASS. If you see that
>> 50:                    the yellow window is offset by an inset (5, 24) press FAIL
> 
> how will tester knows that the inset is of this dimension, it might vary from platform to platform and also vary with different scaling? maybe just delete this hardcoded dimension?

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1778369974
PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1778370100
PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1778370296

From tr at openjdk.org  Fri Sep 27 10:28:22 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 27 Sep 2024 10:28:22 GMT
Subject: RFR: 8340366: Open source several AWT Dialog tests - Batch 3
Message-ID: <ejyQ7t2JdYEP7T27OvQ7XNx5dcUck4yKg_eoSyZulas=.9008c135-5b01-4713-9777-549263d30ae6@github.com>

Open source these AWT Dialog tests:

java/awt/Dialog/ModalDialogTest.java
java/awt/Dialog/DialogModalityTest.java
java/awt/Dialog/DialogResizeTest2.java
java/awt/Dialog/HideDialogTest.java
java/awt/Dialog/FileDialogUserFilterTest.java

-------------

Commit messages:
 - Update ProblemList
 - Open Source

Changes: https://git.openjdk.org/jdk/pull/21218/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21218&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340366
  Stats: 656 lines in 6 files changed: 656 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21218.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21218/head:pull/21218

PR: https://git.openjdk.org/jdk/pull/21218

From azvegint at openjdk.org  Fri Sep 27 11:00:41 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 27 Sep 2024 11:00:41 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4 [v3]
In-Reply-To: <MAnyM8Icle8vnzSsxU2DH7Ht4IrLApX-6YkcPd7_8-s=.60a04688-4180-4fff-bf39-104cee66b7dd@github.com>
References: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
 <MAnyM8Icle8vnzSsxU2DH7Ht4IrLApX-6YkcPd7_8-s=.60a04688-4180-4fff-bf39-104cee66b7dd@github.com>
Message-ID: <lYhWmFZzyAGwCS5xk4_PPMQ6EXqPqqCWO8PsLox1E0k=.306396cd-c496-48be-8013-f2a5adf1a04f@github.com>

On Fri, 27 Sep 2024 04:17:30 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are added as part of this PR:
>> 
>> 1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual PassFailJFrame (PFJ) test**, problemlisted on all platforms.
>> 
>> 2. java/awt/dnd/DragSourceMotionListenerTest.java -  **Automated test**, problemlisted on windows
>> 
>> 3. /java/awt/dnd/DragToAnotherScreenTest.java - **Manual PFJ test**
>> 
>> 4. /java/awt/dnd/RejectDragTest.java - **Automated test**, problemlisted on macOS
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   unused imports

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21213#pullrequestreview-2333427235

From psadhukhan at openjdk.org  Fri Sep 27 11:57:38 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 27 Sep 2024 11:57:38 GMT
Subject: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v2]
In-Reply-To: <brPkqcdO-rqyltEYrncQhWpgT-1j273JWxnOPnJL6cM=.ea4aaa43-b81f-4d32-bfac-de5ef36b945f@github.com>
References: <A_AenkvGSNRrpXk_wcGxZ3Cw-dCFaHsd-75onI6mCX4=.1f17a7fe-701d-417e-8579-08856070ee18@github.com>
 <1iDPjVAbfvfeK0NaWkN3uzNqvieGr-NKKWeAVW0KETE=.283c1d4d-86e3-4ede-8649-54d501139c99@github.com>
 <brPkqcdO-rqyltEYrncQhWpgT-1j273JWxnOPnJL6cM=.ea4aaa43-b81f-4d32-bfac-de5ef36b945f@github.com>
Message-ID: <OQfqBYokPEnN9O8aNDvwzhz-CW-g7jXHrcuLD_7PpqU=.b0fd8792-b604-43c4-8b7a-1dc82cd86729@github.com>

On Fri, 27 Sep 2024 10:05:34 GMT, Tejesh R <tr at openjdk.org> wrote:

>> test/jdk/java/awt/Dialog/DialogResizeTest.java line 133:
>> 
>>> 131:     public void componentHidden(ComponentEvent e) {
>>> 132:         System.out.println("componentHidden event occurred.");
>>> 133:     }
>> 
>> I guess PassFailJFrame.log would be of more use than System println, if at all these logs are of any help..
>
> I'm getting this error if I use ` PassFailJFrame.log`  to `componentResize` method.
> `java.lang.NullPointerException: Cannot invoke "javax.swing.JTextArea.append(String)" because "PassFailJFrame.logArea" is null`. Since the test is about resize, I've updated only resize related print statement.

Probably component is resized even before PassFailJFrame creates the logArea in Builder interface.
The instructions says 
"When isResizable is true the dialog is resizable. When isResizable is false the dialog is non-resizable" and you are logging "PassFailJFrame.log("isResizable is set to: " + bResizeState);" 

so, it seems ComponentListener is not needed and all these 4 methods can be removed which is only logging and that too is not visible to tester...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1778500627

From azvegint at openjdk.org  Fri Sep 27 14:19:40 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 27 Sep 2024 14:19:40 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
Message-ID: <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>

On Thu, 26 Sep 2024 13:57:09 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Provides a set of default layouts for manual test using multiple test UI windows.
>> 
>> The initial implementation in the demo in #15721 was too complicated. After looking at the simplified version used in #21180, I re-worked the layouts into separate methods.
>> 
>> The layout methods are in `WindowLayouts` class next to `PassFailJFrame`. It is not necessary to mention it explicitly in the `@build` jtreg tag.
>> 
>> The builder now provides new methods:
>> 
>> - `positionTestUIRightRow` positions the test UI windows in a row to the right of the instruction frame. The top of the windows is aligned to that of the instruction frame.
>> - `positionTestUIRightColumn` positions the test UI windows in a column to the right of the instruction frame. The top of the first window is aligned to that of the instruction frame.
>> - `positionTestUIRightColumnCentered` positions the test UI windows in a column to the right of the instruction frame centering the stack of the windows.
>> - `positionTestUIBottomRow` positions the test UI windows in a row to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
>> - `positionTestUIBottomRowCentered` positions the test UI windows in a row to the bottom of the instruction frame centering the row of the windows.
>> - `positionTestUIBottomColumn` positions the test UI windows in a column to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
>> 
>> If required, the test developer can provide a custom implementation.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missing parentheses for vertical positioning

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1405:

> 1403:          * Positions the test UI windows in a row to the right of
> 1404:          * the instruction frame. The top of the windows is aligned to
> 1405:          * that of the instruction frame.

Since we are touching this, what are our options for positioning the instruction frame?

The `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)` has no effect now with positionTestUIRightRow:


        PassFailJFrame.builder()
                      .instructions(INSTRUCTIONS)
                      .rows(15)
                      .columns(30)
                      .testUI(() -> WindowCreator.createTestWindows(2))
                      .position(PassFailJFrame.Position.TOP_LEFT_CORNER)
                      .positionTestUIRightRow()
                      .build()
                      .awaitAndCheck();


Should we provide a way to place instruction frame in arbitrary location on screen?
It will allow us to provide more flexibility and more advanced layouts without too much effort from a test developer.

test/jdk/java/awt/regtesthelpers/WindowLayouts.java line 133:

> 131:     public static void bottomOneRowCentered(final List<Window> windows,
> 132:                                             final PassFailJFrame.InstructionUI instructionUI) {
> 133:         layoutColumn(getScreenCenter().x

Suggestion:

        layoutRow(getScreenCenter().x


typo.

test/jdk/java/awt/regtesthelpers/WindowLayouts.java line 175:

> 173:             x += w.getWidth() + WINDOW_GAP;
> 174:         }
> 175: 

Suggestion:

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778689582
PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778670409
PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778699306

From aivanov at openjdk.org  Fri Sep 27 14:23:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 27 Sep 2024 14:23:38 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
 <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>
Message-ID: <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>

On Fri, 27 Sep 2024 14:07:44 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add missing parentheses for vertical positioning
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1405:
> 
>> 1403:          * Positions the test UI windows in a row to the right of
>> 1404:          * the instruction frame. The top of the windows is aligned to
>> 1405:          * that of the instruction frame.
> 
> Since we are touching this, what are our options for positioning the instruction frame?
> 
> The `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)` has no effect now with positionTestUIRightRow:
> 
> 
>         PassFailJFrame.builder()
>                       .instructions(INSTRUCTIONS)
>                       .rows(15)
>                       .columns(30)
>                       .testUI(() -> WindowCreator.createTestWindows(2))
>                       .position(PassFailJFrame.Position.TOP_LEFT_CORNER)
>                       .positionTestUIRightRow()
>                       .build()
>                       .awaitAndCheck();
> 
> 
> Should we provide a way to place instruction frame in arbitrary location on screen?
> It will allow us to provide more flexibility and more advanced layouts without too much effort from a test developer.

If you call `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)` after `.positionTestUIRightRow`, it is respected.

> test/jdk/java/awt/regtesthelpers/WindowLayouts.java line 133:
> 
>> 131:     public static void bottomOneRowCentered(final List<Window> windows,
>> 132:                                             final PassFailJFrame.InstructionUI instructionUI) {
>> 133:         layoutColumn(getScreenCenter().x
> 
> Suggestion:
> 
>         layoutRow(getScreenCenter().x
> 
> 
> typo.

Let me check? All the samples look good, however, this looks like a typo.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778707886
PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778705954

From azvegint at openjdk.org  Fri Sep 27 14:27:35 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 27 Sep 2024 14:27:35 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
 <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>
 <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>
Message-ID: <hyKFVfViUsG8qwpPQVFHAnw8zkIEN_Rku6JIt9swmQU=.fbe00fdb-ede9-4665-ab7a-f116f7be4746@github.com>

On Fri, 27 Sep 2024 14:19:46 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/regtesthelpers/WindowLayouts.java line 133:
>> 
>>> 131:     public static void bottomOneRowCentered(final List<Window> windows,
>>> 132:                                             final PassFailJFrame.InstructionUI instructionUI) {
>>> 133:         layoutColumn(getScreenCenter().x
>> 
>> Suggestion:
>> 
>>         layoutRow(getScreenCenter().x
>> 
>> 
>> typo.
>
> Let me check? All the samples look good, however, this looks like a typo.

I tried this

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21210/head:pull/21210
$ git checkout pull/21210


And the BottomOneRowCentered example looks like following to me: 
![image](https://github.com/user-attachments/assets/c455c8f1-91b8-4664-b445-4598a835cedb)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778713508

From aivanov at openjdk.org  Fri Sep 27 14:30:36 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 27 Sep 2024 14:30:36 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
 <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>
 <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>
Message-ID: <EKrJ1YIYDJoVeO8Mq8xxQzkuE7ITs7G6I5119Mzq5wg=.183e1b31-dc88-4f3f-adbb-888bc2c57914@github.com>

On Fri, 27 Sep 2024 14:21:14 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1405:
>> 
>>> 1403:          * Positions the test UI windows in a row to the right of
>>> 1404:          * the instruction frame. The top of the windows is aligned to
>>> 1405:          * that of the instruction frame.
>> 
>> Since we are touching this, what are our options for positioning the instruction frame?
>> 
>> The `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)` has no effect now with positionTestUIRightRow:
>> 
>> 
>>         PassFailJFrame.builder()
>>                       .instructions(INSTRUCTIONS)
>>                       .rows(15)
>>                       .columns(30)
>>                       .testUI(() -> WindowCreator.createTestWindows(2))
>>                       .position(PassFailJFrame.Position.TOP_LEFT_CORNER)
>>                       .positionTestUIRightRow()
>>                       .build()
>>                       .awaitAndCheck();
>> 
>> 
>> Should we provide a way to place instruction frame in arbitrary location on screen?
>> It will allow us to provide more flexibility and more advanced layouts without too much effort from a test developer.
>
> If you call `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)` after `.positionTestUIRightRow`, it is respected.

> Should we provide a way to place instruction frame in arbitrary location on screen?

You can do it by using the `InstructionUI` interface that's passed to you when you implement a custom layout.

We're still trying to encapsulate the frame that hosts the instructions? if it's exposed, then the test developer can do whatever they want? yet then they have to ensure calling methods on that frame from EDT.

I'd rather not expose the frame at this time.

How often does one need to position the instructions at an arbitrary location on the screen? The `TOP_LEFT_CORNER` position is used by 6 tests only.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778717585

From aivanov at openjdk.org  Fri Sep 27 14:41:57 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 27 Sep 2024 14:41:57 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v3]
In-Reply-To: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
Message-ID: <cBZHjCfgu1BPKG0XvI99uMIIgqhkB0Z8Vk3aYVJrmI0=.4db75e31-ac37-4ebf-ab62-6f48fe8a0c34@github.com>

> Provides a set of default layouts for manual test using multiple test UI windows.
> 
> The initial implementation in the demo in #15721 was too complicated. After looking at the simplified version used in #21180, I re-worked the layouts into separate methods.
> 
> The layout methods are in `WindowLayouts` class next to `PassFailJFrame`. It is not necessary to mention it explicitly in the `@build` jtreg tag.
> 
> The builder now provides new methods:
> 
> - `positionTestUIRightRow` positions the test UI windows in a row to the right of the instruction frame. The top of the windows is aligned to that of the instruction frame.
> - `positionTestUIRightColumn` positions the test UI windows in a column to the right of the instruction frame. The top of the first window is aligned to that of the instruction frame.
> - `positionTestUIRightColumnCentered` positions the test UI windows in a column to the right of the instruction frame centering the stack of the windows.
> - `positionTestUIBottomRow` positions the test UI windows in a row to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
> - `positionTestUIBottomRowCentered` positions the test UI windows in a row to the bottom of the instruction frame centering the row of the windows.
> - `positionTestUIBottomColumn` positions the test UI windows in a column to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
> 
> If required, the test developer can provide a custom implementation.

Alexey Ivanov has updated the pull request incrementally with two additional commits since the last revision:

 - Remove extra line layoutRow
 - bottomOneRowCentered: layoutColumn -> layoutRow

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21207/files
  - new: https://git.openjdk.org/jdk/pull/21207/files/10c9b563..b4876fde

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21207&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21207&range=01-02

  Stats: 7 lines in 1 file changed: 0 ins; 1 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/21207.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21207/head:pull/21207

PR: https://git.openjdk.org/jdk/pull/21207

From aivanov at openjdk.org  Fri Sep 27 14:41:57 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 27 Sep 2024 14:41:57 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <hyKFVfViUsG8qwpPQVFHAnw8zkIEN_Rku6JIt9swmQU=.fbe00fdb-ede9-4665-ab7a-f116f7be4746@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
 <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>
 <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>
 <hyKFVfViUsG8qwpPQVFHAnw8zkIEN_Rku6JIt9swmQU=.fbe00fdb-ede9-4665-ab7a-f116f7be4746@github.com>
Message-ID: <9bkKv8y6M_qcEdzQ9oKzrO4kV0qSmWN2kCqx3wYYzbY=.3f55401f-87dd-4ea3-a7a8-1cd2c6ce1efb@github.com>

On Fri, 27 Sep 2024 14:25:17 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Let me check? All the samples look good, however, this looks like a typo.
>
> I tried this
> 
> Checkout this PR locally:
> $ git fetch https://git.openjdk.org/jdk.git pull/21210/head:pull/21210
> $ git checkout pull/21210
> 
> 
> And the BottomOneRowCentered example looks like following to me: 
> ![image](https://github.com/user-attachments/assets/c455c8f1-91b8-4664-b445-4598a835cedb)

Yes, I see it now. I wonder why it worked correctly when I ran the tests to take screenshots.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778732607

From aivanov at openjdk.org  Fri Sep 27 14:51:35 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 27 Sep 2024 14:51:35 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <EKrJ1YIYDJoVeO8Mq8xxQzkuE7ITs7G6I5119Mzq5wg=.183e1b31-dc88-4f3f-adbb-888bc2c57914@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
 <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>
 <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>
 <EKrJ1YIYDJoVeO8Mq8xxQzkuE7ITs7G6I5119Mzq5wg=.183e1b31-dc88-4f3f-adbb-888bc2c57914@github.com>
Message-ID: <LR9mOKhNh3d3-0ZEx1lDIG3qEC9kcBaHbMHBNGDBxtU=.1832d142-070d-4a38-a6dd-3c4872b3891f@github.com>

On Fri, 27 Sep 2024 14:28:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> If you call `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)` after `.positionTestUIRightRow`, it is respected.
>
>> Should we provide a way to place instruction frame in arbitrary location on screen?
> 
> You can do it by using the `InstructionUI` interface that's passed to you when you implement a custom layout.
> 
> We're still trying to encapsulate the frame that hosts the instructions? if it's exposed, then the test developer can do whatever they want? yet then they have to ensure calling methods on that frame from EDT.
> 
> I'd rather not expose the frame at this time.
> 
> How often does one need to position the instructions at an arbitrary location on the screen? The `TOP_LEFT_CORNER` position is used by 6 tests only.

With the instruction frame exposed, it would be possible to create owned modeless `JDialog` or `Dialog` instead of `JFrame` and `Frame` which has a great benefit: all the windows are brought to the top when you switch back to the test from another application. And there's only a single window on the taskbar for the test.

I've been thinking about adding helper methods `createOwnedJDialog` and `createOwnedDialog` to cover this use case.

Currently, it's possible to host test UI in a modeless dialog if you use `testUI` with `PanelCreator` that is pass a method which creates `JComponent`. I admit I like navigating the UI much easier in this case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778741079

From azvegint at openjdk.org  Fri Sep 27 14:51:35 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 27 Sep 2024 14:51:35 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <qjLQy-9UMdJLqqEZBUvfDC5D5paOyXurp_xWSgG2vk0=.17788466-4dc5-498d-8c7e-b66c121aeb06@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
 <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>
 <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>
 <EKrJ1YIYDJoVeO8Mq8xxQzkuE7ITs7G6I5119Mzq5wg=.183e1b31-dc88-4f3f-adbb-888bc2c57914@github.com>
 <LR9mOKhNh3d3-0ZEx1lDIG3qEC9kcBaHbMHBNGDBxtU=.1832d142-070d-4a38-a6dd-3c4872b3891f@github.com>
 <qjLQy-9UMdJLqqEZBUvfDC5D5paOyXurp_xWSgG2vk0=.17788466-4dc5-498d-8c7e-b66c121aeb06@github.com>
Message-ID: <om6c_nOXej5YboSdcwtFeXdFDYkj9ZDVGwTnk0M1dQw=.8990d820-1c67-4ebf-adbd-6c32b5afbda9@github.com>

On Fri, 27 Sep 2024 14:48:20 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> With the instruction frame exposed, it would be possible to create owned modeless `JDialog` or `Dialog` instead of `JFrame` and `Frame` which has a great benefit: all the windows are brought to the top when you switch back to the test from another application. And there's only a single window on the taskbar for the test.
>> 
>> I've been thinking about adding helper methods `createOwnedJDialog` and `createOwnedDialog` to cover this use case.
>> 
>> Currently, it's possible to host test UI in a modeless dialog if you use `testUI` with `PanelCreator` that is pass a method which creates `JComponent`. I admit I like navigating the UI much easier in this case.
>
>> If you call `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)` after `.positionTestUIRightRow`, it is respected.
> 
> Perhaps, this behaviour should be called out in the docs somewhere. All `.positionTestUIRight*` as well as `.positionTestUIBottom*` *implicitly* set the position.

> You can do it by using the InstructionUI interface that's passed to you when you implement a custom layout.

But it cannot be combined with the newly added methods like:


        PassFailJFrame.builder()
                .instructions(INSTRUCTIONS)
                .rows(15)
                .columns(30)
                .testUI(() -> WindowCreator.createTestWindows(3))
                .positionTestUI((testWindows, instructionUI) -> instructionUI.setLocation(200, 200))
                // or add a new method like
                //.instructionFrameLocation(200, 200)
                .positionTestUIRightRow()
                .build()
                .awaitAndCheck();


The idea is to make it very simple without having to implement the `positionTestUI` interface (I am not talking about exposing the frame, see the snippet above).
Like place the instruction frame here, and layout other windows relative to it.

But I agree it is a rare case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778744890

From aivanov at openjdk.org  Fri Sep 27 14:51:35 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 27 Sep 2024 14:51:35 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <LR9mOKhNh3d3-0ZEx1lDIG3qEC9kcBaHbMHBNGDBxtU=.1832d142-070d-4a38-a6dd-3c4872b3891f@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
 <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>
 <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>
 <EKrJ1YIYDJoVeO8Mq8xxQzkuE7ITs7G6I5119Mzq5wg=.183e1b31-dc88-4f3f-adbb-888bc2c57914@github.com>
 <LR9mOKhNh3d3-0ZEx1lDIG3qEC9kcBaHbMHBNGDBxtU=.1832d142-070d-4a38-a6dd-3c4872b3891f@github.com>
Message-ID: <qjLQy-9UMdJLqqEZBUvfDC5D5paOyXurp_xWSgG2vk0=.17788466-4dc5-498d-8c7e-b66c121aeb06@github.com>

On Fri, 27 Sep 2024 14:45:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> Should we provide a way to place instruction frame in arbitrary location on screen?
>> 
>> You can do it by using the `InstructionUI` interface that's passed to you when you implement a custom layout.
>> 
>> We're still trying to encapsulate the frame that hosts the instructions? if it's exposed, then the test developer can do whatever they want? yet then they have to ensure calling methods on that frame from EDT.
>> 
>> I'd rather not expose the frame at this time.
>> 
>> How often does one need to position the instructions at an arbitrary location on the screen? The `TOP_LEFT_CORNER` position is used by 6 tests only.
>
> With the instruction frame exposed, it would be possible to create owned modeless `JDialog` or `Dialog` instead of `JFrame` and `Frame` which has a great benefit: all the windows are brought to the top when you switch back to the test from another application. And there's only a single window on the taskbar for the test.
> 
> I've been thinking about adding helper methods `createOwnedJDialog` and `createOwnedDialog` to cover this use case.
> 
> Currently, it's possible to host test UI in a modeless dialog if you use `testUI` with `PanelCreator` that is pass a method which creates `JComponent`. I admit I like navigating the UI much easier in this case.

> If you call `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)` after `.positionTestUIRightRow`, it is respected.

Perhaps, this behaviour should be called out in the docs somewhere. All `.positionTestUIRight*` as well as `.positionTestUIBottom*` *implicitly* set the position.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778744618

From aivanov at openjdk.org  Fri Sep 27 14:56:37 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 27 Sep 2024 14:56:37 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <om6c_nOXej5YboSdcwtFeXdFDYkj9ZDVGwTnk0M1dQw=.8990d820-1c67-4ebf-adbd-6c32b5afbda9@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
 <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>
 <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>
 <EKrJ1YIYDJoVeO8Mq8xxQzkuE7ITs7G6I5119Mzq5wg=.183e1b31-dc88-4f3f-adbb-888bc2c57914@github.com>
 <LR9mOKhNh3d3-0ZEx1lDIG3qEC9kcBaHbMHBNGDBxtU=.1832d142-070d-4a38-a6dd-3c4872b3891f@github.com>
 <qjLQy-9UMdJLqqEZBUvfDC5D5paOyXurp_xWSgG2vk0=.17788466-4dc5-498d-8c7e-b66c121aeb06@github.com>
 <om6c_nOXej5YboSdcwtFeXdFDYkj9ZDVGwTnk0M1dQw=.8990d820-1c67-4ebf-adbd-6c32b5afbda9@github.com>
Message-ID: <kQipifuPtrQx_62l0nJeiR9i0GHJ4kDsd_rBXZbEwrc=.827523df-8de4-49d0-bd4d-2be07b676db7@github.com>

On Fri, 27 Sep 2024 14:48:32 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>>> If you call `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)` after `.positionTestUIRightRow`, it is respected.
>> 
>> Perhaps, this behaviour should be called out in the docs somewhere. All `.positionTestUIRight*` as well as `.positionTestUIBottom*` *implicitly* set the position.
>
>> You can do it by using the InstructionUI interface that's passed to you when you implement a custom layout.
> 
> But it cannot be combined with the newly added methods like:
> 
> 
>         PassFailJFrame.builder()
>                 .instructions(INSTRUCTIONS)
>                 .rows(15)
>                 .columns(30)
>                 .testUI(() -> WindowCreator.createTestWindows(3))
>                 .positionTestUI((testWindows, instructionUI) -> instructionUI.setLocation(200, 200))
>                 // or add a new method like
>                 //.instructionFrameLocation(200, 200)
>                 .positionTestUIRightRow()
>                 .build()
>                 .awaitAndCheck();
> 
> 
> The idea is to make it very simple without having to implement the `positionTestUI` interface (I am not talking about exposing the frame, see the snippet above).
> Like place the instruction frame here, and layout other windows relative to it.
> 
> But I agree it is a rare case.

No, not directly.

But you can combine it with explicit call to `WindowLayouts`:


.positionTestUI((testWindows, instructionUI) -> {
    instructionUI.setLocation(200, 200);
    WindowLayouts.rightOneRow(testWindows, instructionUI);
})


So, this (rare) scenario still doesn't require you to reimplement everything.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778751155

From azvegint at openjdk.org  Fri Sep 27 14:56:37 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 27 Sep 2024 14:56:37 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <9bkKv8y6M_qcEdzQ9oKzrO4kV0qSmWN2kCqx3wYYzbY=.3f55401f-87dd-4ea3-a7a8-1cd2c6ce1efb@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
 <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>
 <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>
 <hyKFVfViUsG8qwpPQVFHAnw8zkIEN_Rku6JIt9swmQU=.fbe00fdb-ede9-4665-ab7a-f116f7be4746@github.com>
 <9bkKv8y6M_qcEdzQ9oKzrO4kV0qSmWN2kCqx3wYYzbY=.3f55401f-87dd-4ea3-a7a8-1cd2c6ce1efb@github.com>
Message-ID: <pqaUT4EbyCOcmqbyGuxq23i0JmWaOobsblgKmJfyAR4=.09d69a2f-a896-481c-8811-86a9fe7169f8@github.com>

On Fri, 27 Sep 2024 14:39:26 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I tried this
>> 
>> Checkout this PR locally:
>> $ git fetch https://git.openjdk.org/jdk.git pull/21210/head:pull/21210
>> $ git checkout pull/21210
>> 
>> 
>> And the BottomOneRowCentered example looks like following to me: 
>> ![image](https://github.com/user-attachments/assets/c455c8f1-91b8-4664-b445-4598a835cedb)
>
> Yes, I see it now. I wonder why it worked correctly when I ran the tests to take screenshots.

jtreg doesn't recompile classes with `@build` (like PassFailJFrame) even if they are changed, so I usually do the `rm -rf JT*` if I touched some of them.
This may be your case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778751391

From azvegint at openjdk.org  Fri Sep 27 15:01:35 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 27 Sep 2024 15:01:35 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <kQipifuPtrQx_62l0nJeiR9i0GHJ4kDsd_rBXZbEwrc=.827523df-8de4-49d0-bd4d-2be07b676db7@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
 <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>
 <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>
 <EKrJ1YIYDJoVeO8Mq8xxQzkuE7ITs7G6I5119Mzq5wg=.183e1b31-dc88-4f3f-adbb-888bc2c57914@github.com>
 <LR9mOKhNh3d3-0ZEx1lDIG3qEC9kcBaHbMHBNGDBxtU=.1832d142-070d-4a38-a6dd-3c4872b3891f@github.com>
 <qjLQy-9UMdJLqqEZBUvfDC5D5paOyXurp_xWSgG2vk0=.17788466-4dc5-498d-8c7e-b66c121aeb06@github.com>
 <om6c_nOXej5YboSdcwtFeXdFDYkj9ZDVGwTnk0M1dQw=.8990d820-1c67-4ebf-adbd-6c32b5afbda9@github.com>
 <kQipifuPtrQx_62l0nJeiR9i0GHJ4kDsd_rBXZbEwrc=.827523df-8de4-49d0-bd4d-2be07b676db7@github.com>
Message-ID: <ZLaSsKEjgdVPpja6QWY_IGJq2Ns7zNJhzO2Bq9P0jX8=.1f7a7a1b-3ffa-49ef-b1fd-78b548ccbbf4@github.com>

On Fri, 27 Sep 2024 14:53:21 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> You can do it by using the InstructionUI interface that's passed to you when you implement a custom layout.
>> 
>> But it cannot be combined with the newly added methods like:
>> 
>> 
>>         PassFailJFrame.builder()
>>                 .instructions(INSTRUCTIONS)
>>                 .rows(15)
>>                 .columns(30)
>>                 .testUI(() -> WindowCreator.createTestWindows(3))
>>                 .positionTestUI((testWindows, instructionUI) -> instructionUI.setLocation(200, 200))
>>                 // or add a new method like
>>                 //.instructionFrameLocation(200, 200)
>>                 .positionTestUIRightRow()
>>                 .build()
>>                 .awaitAndCheck();
>> 
>> 
>> The idea is to make it very simple without having to implement the `positionTestUI` interface (I am not talking about exposing the frame, see the snippet above).
>> Like place the instruction frame here, and layout other windows relative to it.
>> 
>> But I agree it is a rare case.
>
> No, not directly.
> 
> But you can combine it with explicit call to `WindowLayouts`:
> 
> 
> .positionTestUI((testWindows, instructionUI) -> {
>     instructionUI.setLocation(200, 200);
>     WindowLayouts.rightOneRow(testWindows, instructionUI);
> })
> 
> 
> So, this (rare) scenario still doesn't require you to reimplement everything.

Oh, I hadn't paid attention to the fact that these methods are public. I guess it is a good solution to my request.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778758261

From azvegint at openjdk.org  Fri Sep 27 15:10:35 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 27 Sep 2024 15:10:35 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v3]
In-Reply-To: <cBZHjCfgu1BPKG0XvI99uMIIgqhkB0Z8Vk3aYVJrmI0=.4db75e31-ac37-4ebf-ab62-6f48fe8a0c34@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <cBZHjCfgu1BPKG0XvI99uMIIgqhkB0Z8Vk3aYVJrmI0=.4db75e31-ac37-4ebf-ab62-6f48fe8a0c34@github.com>
Message-ID: <ukQdFdIVQvcpq1sJdLOVFSzbaAho3oLGgxQgr4pzupg=.8a8ab3d1-391b-49db-9643-dad519b2efa2@github.com>

On Fri, 27 Sep 2024 14:41:57 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Provides a set of default layouts for manual test using multiple test UI windows.
>> 
>> The initial implementation in the demo in #15721 was too complicated. After looking at the simplified version used in #21180, I re-worked the layouts into separate methods.
>> 
>> The layout methods are in `WindowLayouts` class next to `PassFailJFrame`. It is not necessary to mention it explicitly in the `@build` jtreg tag.
>> 
>> The builder now provides new methods:
>> 
>> - `positionTestUIRightRow` positions the test UI windows in a row to the right of the instruction frame. The top of the windows is aligned to that of the instruction frame.
>> - `positionTestUIRightColumn` positions the test UI windows in a column to the right of the instruction frame. The top of the first window is aligned to that of the instruction frame.
>> - `positionTestUIRightColumnCentered` positions the test UI windows in a column to the right of the instruction frame centering the stack of the windows.
>> - `positionTestUIBottomRow` positions the test UI windows in a row to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
>> - `positionTestUIBottomRowCentered` positions the test UI windows in a row to the bottom of the instruction frame centering the row of the windows.
>> - `positionTestUIBottomColumn` positions the test UI windows in a column to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
>> 
>> If required, the test developer can provide a custom implementation.
>
> Alexey Ivanov has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Remove extra line layoutRow
>  - bottomOneRowCentered: layoutColumn -> layoutRow

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21207#pullrequestreview-2333995930

From aivanov at openjdk.org  Fri Sep 27 15:20:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 27 Sep 2024 15:20:38 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <ZLaSsKEjgdVPpja6QWY_IGJq2Ns7zNJhzO2Bq9P0jX8=.1f7a7a1b-3ffa-49ef-b1fd-78b548ccbbf4@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
 <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>
 <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>
 <EKrJ1YIYDJoVeO8Mq8xxQzkuE7ITs7G6I5119Mzq5wg=.183e1b31-dc88-4f3f-adbb-888bc2c57914@github.com>
 <LR9mOKhNh3d3-0ZEx1lDIG3qEC9kcBaHbMHBNGDBxtU=.1832d142-070d-4a38-a6dd-3c4872b3891f@github.com>
 <qjLQy-9UMdJLqqEZBUvfDC5D5paOyXurp_xWSgG2vk0=.17788466-4dc5-498d-8c7e-b66c121aeb06@github.com>
 <om6c_nOXej5YboSdcwtFeXdFDYkj9ZDVGwTnk0M1dQw=.8990d820-1c67-4ebf-adbd-6c32b5afbda9@github.com>
 <kQipifuPtrQx_62l0nJeiR9i0GHJ4kDsd_rBXZbEwrc=.827523df-8de4-49d0-bd4d-2be07b676db7@github.com>
 <ZLaSsKEjgdVPpja6QWY_IGJq2Ns7zNJhzO2Bq9P0jX8=.1f7a7a1b-3ffa-49ef-b1fd-78b548ccbbf4@github.com>
Message-ID: <Nzt249Y1fFcFKyZUWIksVJ6rVE2DqdwmBxpewuojcPE=.83cb1f6a-371b-47cd-b140-b0da71d714c7@github.com>

On Fri, 27 Sep 2024 14:58:31 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> No, not directly.
>> 
>> But you can combine it with explicit call to `WindowLayouts`:
>> 
>> 
>> .positionTestUI((testWindows, instructionUI) -> {
>>     instructionUI.setLocation(200, 200);
>>     WindowLayouts.rightOneRow(testWindows, instructionUI);
>> })
>> 
>> 
>> So, this (rare) scenario still doesn't require you to reimplement everything.
>
> Oh, I hadn't paid attention to the fact that these methods are public. I guess it is a good solution to my request.

I like the updated version much better that what I had initially. It's really *flexible* now. One can combine different layouts on sublists to achieve more complex layouts. Yet I am still to play around with it. Anyway more complex layouts are out of scope for this PR.

Thank you @azvegint! It is your usage in #21180 that made me realise I had overcomplicated the code for laying out windows.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778791631

From azvegint at openjdk.org  Fri Sep 27 15:35:35 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 27 Sep 2024 15:35:35 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v2]
In-Reply-To: <Nzt249Y1fFcFKyZUWIksVJ6rVE2DqdwmBxpewuojcPE=.83cb1f6a-371b-47cd-b140-b0da71d714c7@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <vOR5O7sGMRfGYBT7CTumcR5Du1EH50tlPMid3a2BNA4=.97912768-e0f1-4f80-aa67-476196cb0fc7@github.com>
 <iFLAraKbgJYI5DrctCRViW1y73uUWTCZgUGsU1HNz9s=.5a15daf5-cd0c-404f-a5c9-1f1ee2b6cdb9@github.com>
 <slNh4IqXLiBg1M8RD7VtP3G6IboRuVxR6Le_Hwv27FA=.c9946ca9-2240-4e36-8000-1ded3635f570@github.com>
 <EKrJ1YIYDJoVeO8Mq8xxQzkuE7ITs7G6I5119Mzq5wg=.183e1b31-dc88-4f3f-adbb-888bc2c57914@github.com>
 <LR9mOKhNh3d3-0ZEx1lDIG3qEC9kcBaHbMHBNGDBxtU=.1832d142-070d-4a38-a6dd-3c4872b3891f@github.com>
 <qjLQy-9UMdJLqqEZBUvfDC5D5paOyXurp_xWSgG2vk0=.17788466-4dc5-498d-8c7e-b66c121aeb06@github.com>
 <om6c_nOXej5YboSdcwtFeXdFDYkj9ZDVGwTnk0M1dQw=.8990d820-1c67-4ebf-adbd-6c32b5afbda9@github.com>
 <kQipifuPtrQx_62l0nJeiR9i0GHJ4kDsd_rBXZbEwrc=.827523df-8de4-49d0-bd4d-2be07b676db7@github.com>
 <ZLaSsKEjgdVPpja6QWY_IGJq2Ns7zNJhzO2Bq9P0jX8=.1f7a7a1b-3ffa-49ef-b1fd-78b548ccbbf4@github.com>
 <Nzt249Y1fFcFKyZUWIksVJ6rVE2DqdwmBxp
 ewuojcPE=.83cb1f6a-371b-47cd-b140-b0da71d714c7@github.com>
Message-ID: <YaHY0tjaNjaYkdS-6FYH3TdTy78zQw1ZiGTrpeHh6hQ=.bc07bfb1-2ea7-4212-a683-ada0a0fa4871@github.com>

On Fri, 27 Sep 2024 15:18:10 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Oh, I hadn't paid attention to the fact that these methods are public. I guess it is a good solution to my request.
>
> I like the updated version much better that what I had initially. It's really *flexible* now. One can combine different layouts on sublists to achieve more complex layouts. Yet I am still to play around with it. Anyway more complex layouts are out of scope for this PR.
> 
> Thank you @azvegint! It is your usage in #21180 that made me realise I had overcomplicated the code for laying out windows.

Thank you for implementing this!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778812242

From aivanov at openjdk.org  Fri Sep 27 16:32:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 27 Sep 2024 16:32:15 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v4]
In-Reply-To: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
Message-ID: <XxSOBwAvc5XQCzf-uPGtCCzHtvc2XoIWkTKqvy5tUwo=.5fcac96e-2fbe-4443-b890-eec32a4c818f@github.com>

> Provides a set of default layouts for manual test using multiple test UI windows.
> 
> The initial implementation in the demo in #15721 was too complicated. After looking at the simplified version used in #21180, I re-worked the layouts into separate methods.
> 
> The layout methods are in `WindowLayouts` class next to `PassFailJFrame`. It is not necessary to mention it explicitly in the `@build` jtreg tag.
> 
> The builder now provides new methods:
> 
> - `positionTestUIRightRow` positions the test UI windows in a row to the right of the instruction frame. The top of the windows is aligned to that of the instruction frame.
> - `positionTestUIRightColumn` positions the test UI windows in a column to the right of the instruction frame. The top of the first window is aligned to that of the instruction frame.
> - `positionTestUIRightColumnCentered` positions the test UI windows in a column to the right of the instruction frame centering the stack of the windows.
> - `positionTestUIBottomRow` positions the test UI windows in a row to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
> - `positionTestUIBottomRowCentered` positions the test UI windows in a row to the bottom of the instruction frame centering the row of the windows.
> - `positionTestUIBottomColumn` positions the test UI windows in a column to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
> 
> If required, the test developer can provide a custom implementation.

Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge master
 - Remove extra line layoutRow
 - bottomOneRowCentered: layoutColumn -> layoutRow
 - Add missing parentheses for vertical positioning
 - 8317116: Provide layouts for multiple test UI in PassFailJFrame

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21207/files
  - new: https://git.openjdk.org/jdk/pull/21207/files/b4876fde..b6f1f334

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21207&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21207&range=02-03

  Stats: 2348 lines in 87 files changed: 1668 ins; 565 del; 115 mod
  Patch: https://git.openjdk.org/jdk/pull/21207.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21207/head:pull/21207

PR: https://git.openjdk.org/jdk/pull/21207

From aivanov at openjdk.org  Fri Sep 27 16:41:06 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 27 Sep 2024 16:41:06 GMT
Subject: RFR: 8341037: Use standard layouts in DefaultFrameIconTest.java and
 MenuCrash.java
Message-ID: <cS9l_dZ0n4syDxzDR89dc7eHpMtzdQRIzhwazaGCpQA=.62015088-62c4-4b46-860d-22f4e65eb14e@github.com>

Now that standard window layouts are available as part of the `PassFailJFrame` framework, we can use them in tests.

Two tests from #21180, specifically `test/jdk/java/awt/Frame/DefaultFrameIconTest.java` and `test/jdk/java/awt/Frame/MenuCrash.java`, use two test windows. At this time, the tests implement positioning explicitly in the test. After #21207 is integrated, these two tests could be updated to use the standard layout. They would serve as sample usage of multi-window test UI.

-------------

Depends on: https://git.openjdk.org/jdk/pull/21207

Commit messages:
 - Merge branch '8317116-passFail-WindowLayouts'
 - 8341037: Use standard layouts in DefaultFrameIconTest.java and MenuCrash.java
 - Merge master

Changes: https://git.openjdk.org/jdk/pull/21226/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21226&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8341037
  Stats: 22 lines in 2 files changed: 0 ins; 20 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21226.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21226/head:pull/21226

PR: https://git.openjdk.org/jdk/pull/21226

From azvegint at openjdk.org  Fri Sep 27 16:48:35 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 27 Sep 2024 16:48:35 GMT
Subject: RFR: 8341037: Use standard layouts in DefaultFrameIconTest.java
 and MenuCrash.java
In-Reply-To: <cS9l_dZ0n4syDxzDR89dc7eHpMtzdQRIzhwazaGCpQA=.62015088-62c4-4b46-860d-22f4e65eb14e@github.com>
References: <cS9l_dZ0n4syDxzDR89dc7eHpMtzdQRIzhwazaGCpQA=.62015088-62c4-4b46-860d-22f4e65eb14e@github.com>
Message-ID: <gu-ILroc2wtMaxGqfgUDoUfYs-sVzafeD7l6V-pkirc=.cb822412-5542-4e95-9cbc-ff4767cbd784@github.com>

On Fri, 27 Sep 2024 16:34:52 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Now that standard window layouts are available as part of the `PassFailJFrame` framework, we can use them in tests.
> 
> Two tests from #21180, specifically `test/jdk/java/awt/Frame/DefaultFrameIconTest.java` and `test/jdk/java/awt/Frame/MenuCrash.java`, use two test windows. At this time, the tests implement positioning explicitly in the test. After #21207 is integrated, these two tests could be updated to use the standard layout. They would serve as sample usage of multi-window test UI.

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21226#pullrequestreview-2334200890

From abhiscxk at openjdk.org  Fri Sep 27 18:01:24 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 27 Sep 2024 18:01:24 GMT
Subject: RFR: 8340354: Open source AWT desktop properties and print related
 tests [v2]
In-Reply-To: <yOfPiZp2v3H8OSK4-Wv2GV2SeZq7x0heUpdXWQyKav0=.7f1df951-2c9d-4e6c-b2b2-3464caeaa711@github.com>
References: <yOfPiZp2v3H8OSK4-Wv2GV2SeZq7x0heUpdXWQyKav0=.7f1df951-2c9d-4e6c-b2b2-3464caeaa711@github.com>
Message-ID: <zVnITp_WcupCYrpvDt3nRh7fC81YWzwByuerX1FEayg=.020c2c46-7ef5-4f9d-b324-99fb6c1eaaaa@github.com>

> AWT Desktop properties and printer related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  spacing fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21197/files
  - new: https://git.openjdk.org/jdk/pull/21197/files/d511f71f..acab40c8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21197&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21197&range=00-01

  Stats: 20 lines in 2 files changed: 2 ins; 0 del; 18 mod
  Patch: https://git.openjdk.org/jdk/pull/21197.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21197/head:pull/21197

PR: https://git.openjdk.org/jdk/pull/21197

From aivanov at openjdk.org  Fri Sep 27 19:46:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 27 Sep 2024 19:46:39 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4 [v3]
In-Reply-To: <MAnyM8Icle8vnzSsxU2DH7Ht4IrLApX-6YkcPd7_8-s=.60a04688-4180-4fff-bf39-104cee66b7dd@github.com>
References: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
 <MAnyM8Icle8vnzSsxU2DH7Ht4IrLApX-6YkcPd7_8-s=.60a04688-4180-4fff-bf39-104cee66b7dd@github.com>
Message-ID: <U4DPGGDTt0vvGiv1VSLWeuMijYD46YlrOYvumpAKF-w=.f4b82462-b7b1-4205-a311-536101e820e9@github.com>

On Fri, 27 Sep 2024 04:17:30 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are added as part of this PR:
>> 
>> 1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual PassFailJFrame (PFJ) test**, problemlisted on all platforms.
>> 
>> 2. java/awt/dnd/DragSourceMotionListenerTest.java -  **Automated test**, problemlisted on windows
>> 
>> 3. /java/awt/dnd/DragToAnotherScreenTest.java - **Manual PFJ test**
>> 
>> 4. /java/awt/dnd/RejectDragTest.java - **Automated test**, problemlisted on macOS
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   unused imports

test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDSource.html line 1:

> 1: <!--

Can we create the file on-the-fly from a string in a source file?

It looks the file is required for the test.

test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDSource.java line 46:

> 44: import java.nio.file.Paths;
> 45: 
> 46: class DnDSource extends Button implements Transferable,

This class can likely be a static nested class inside `DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java`.

If both the HTML and DnDSource are within `DnDHTMLToOutlookTest.java`, the test becomes self-sufficient. And the folder can be omitted.

test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDSource.java line 76:

> 74:         if (dir == null) {
> 75:             dir = ".";
> 76:         }

Suggestion:

        String dir = System.getProperty("test.src", ".");

test/jdk/java/awt/dnd/DragToAnotherScreenTest.java line 43:

> 41: /*
> 42:  * @test
> 43:  * @bug 6179157

Shall we add `@key multimon`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779072015
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779075989
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779076939
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779078385

From honkar at openjdk.org  Fri Sep 27 20:06:37 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 27 Sep 2024 20:06:37 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4 [v3]
In-Reply-To: <U4DPGGDTt0vvGiv1VSLWeuMijYD46YlrOYvumpAKF-w=.f4b82462-b7b1-4205-a311-536101e820e9@github.com>
References: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
 <MAnyM8Icle8vnzSsxU2DH7Ht4IrLApX-6YkcPd7_8-s=.60a04688-4180-4fff-bf39-104cee66b7dd@github.com>
 <U4DPGGDTt0vvGiv1VSLWeuMijYD46YlrOYvumpAKF-w=.f4b82462-b7b1-4205-a311-536101e820e9@github.com>
Message-ID: <I9A3r9FCDVZbBUfsmD5B6A3_ji9I3B2JVc-6TjCWk7Y=.512045d1-80b5-40bd-a385-00b4804801ff@github.com>

On Fri, 27 Sep 2024 19:35:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   unused imports
>
> test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDSource.html line 1:
> 
>> 1: <!--
> 
> Can we create the file on-the-fly from a string in a source file?
> 
> It looks the file is required for the test.

At this point I'll leave it as a separate .html file.

> test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDSource.java line 46:
> 
>> 44: import java.nio.file.Paths;
>> 45: 
>> 46: class DnDSource extends Button implements Transferable,
> 
> This class can likely be a static nested class inside `DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java`.
> 
> If both the HTML and DnDSource are within `DnDHTMLToOutlookTest.java`, the test becomes self-sufficient. And the folder can be omitted.

Yes, although keeping it separate makes the test look cleaner.

> test/jdk/java/awt/dnd/DragToAnotherScreenTest.java line 43:
> 
>> 41: /*
>> 42:  * @test
>> 43:  * @bug 6179157
> 
> Shall we add `@key multimon`?

This test is applicable for single monitors as well. Does `@key multimon` mean muti-monitor setup only ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779097185
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779094108
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779093711

From honkar at openjdk.org  Fri Sep 27 20:12:24 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 27 Sep 2024 20:12:24 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4 [v4]
In-Reply-To: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
References: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
Message-ID: <6kpdI-BesMPrDwp77k189Oz7A2q0vNvJv2q9TrdzBCw=.f359835c-decf-428d-8382-74693f10361e@github.com>

> Following tests are added as part of this PR:
> 
> 1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual PassFailJFrame (PFJ) test**, problemlisted on all platforms.
> 
> 2. java/awt/dnd/DragSourceMotionListenerTest.java -  **Automated test**, problemlisted on windows
> 
> 3. /java/awt/dnd/DragToAnotherScreenTest.java - **Manual PFJ test**
> 
> 4. /java/awt/dnd/RejectDragTest.java - **Automated test**, problemlisted on macOS

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  review fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21213/files
  - new: https://git.openjdk.org/jdk/pull/21213/files/39f4a395..0cddb296

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21213&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21213&range=02-03

  Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21213.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21213/head:pull/21213

PR: https://git.openjdk.org/jdk/pull/21213

From kizune at openjdk.org  Fri Sep 27 20:34:15 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 27 Sep 2024 20:34:15 GMT
Subject: RFR: 8340407: Open source a few more Component related tests
Message-ID: <rK-dbwVbgJrsiQWOTxrpHB88COtl7MnDEAf20nGGZ_U=.d32ac658-4799-4202-8166-477950ac3e4d@github.com>

Clean up and open source four tests.

-------------

Commit messages:
 - 8340407: Open source a few more Component related tests

Changes: https://git.openjdk.org/jdk/pull/21234/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21234&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340407
  Stats: 1395 lines in 4 files changed: 1395 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21234.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21234/head:pull/21234

PR: https://git.openjdk.org/jdk/pull/21234

From kizune at openjdk.org  Fri Sep 27 20:39:21 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 27 Sep 2024 20:39:21 GMT
Subject: RFR: 8340458: Open source additional Component tests (part 2)
Message-ID: <amLY1mvQ69kyzvu63buXopJZJKpu8I4kZDPKup-iwmQ=.e797a9b2-738c-4b38-a585-60a2c3f1b250@github.com>

Clean up and open source four more tests.

-------------

Commit messages:
 - 8340458: Open source additional Component tests (part 2)

Changes: https://git.openjdk.org/jdk/pull/21235/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21235&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340458
  Stats: 487 lines in 4 files changed: 487 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21235.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21235/head:pull/21235

PR: https://git.openjdk.org/jdk/pull/21235

From honkar at openjdk.org  Fri Sep 27 22:01:13 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 27 Sep 2024 22:01:13 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4 [v5]
In-Reply-To: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
References: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
Message-ID: <HWQFkOKyZP55INGkyK7ZJjI9_TxsvyYhLC2f02rKv5M=.75885fef-476f-47d3-919b-d9f9930acaa6@github.com>

> Following tests are added as part of this PR:
> 
> 1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual PassFailJFrame (PFJ) test**, problemlisted on all platforms.
> 
> 2. java/awt/dnd/DragSourceMotionListenerTest.java -  **Automated test**, problemlisted on windows
> 
> 3. /java/awt/dnd/DragToAnotherScreenTest.java - **Manual PFJ test**
> 
> 4. /java/awt/dnd/RejectDragTest.java - **Automated test**, problemlisted on macOS

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  removed redundant frame.setLocation()

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21213/files
  - new: https://git.openjdk.org/jdk/pull/21213/files/0cddb296..200da175

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21213&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21213&range=03-04

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21213.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21213/head:pull/21213

PR: https://git.openjdk.org/jdk/pull/21213

From kizune at openjdk.org  Sat Sep 28 01:13:40 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Sat, 28 Sep 2024 01:13:40 GMT
Subject: RFR: 8340560: Open Source several AWT/2D font and rendering tests
In-Reply-To: <PID9btqC7r9H4iRAG1fPdARMP_XuuaS1MrmUUiHuBUU=.618165ee-264c-40dc-adb8-438c161111c6@github.com>
References: <PID9btqC7r9H4iRAG1fPdARMP_XuuaS1MrmUUiHuBUU=.618165ee-264c-40dc-adb8-438c161111c6@github.com>
Message-ID: <jPmKxVXJ7rpEXc4js1AXglXChsQxxzZIshqiHGOQxjI=.259d6744-f646-4d5c-b5b4-5eea7dc9fe04@github.com>

On Wed, 25 Sep 2024 20:29:40 GMT, Phil Race <prr at openjdk.org> wrote:

> Open sourcing some rendering tests.

Looks good.

-------------

Marked as reviewed by kizune (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21192#pullrequestreview-2334842791

From ysuenaga at openjdk.org  Sat Sep 28 09:11:37 2024
From: ysuenaga at openjdk.org (Yasumasa Suenaga)
Date: Sat, 28 Sep 2024 09:11:37 GMT
Subject: RFR: 8339309: unused-variable warnings happen in libfontmanager
In-Reply-To: <Abj2BkDUSUeMIve32Kvb3Qi4KdNSN5eV2Ngj1btLBWE=.5d19cbf7-8daf-4963-a9bb-49123ec307e2@github.com>
References: <Abj2BkDUSUeMIve32Kvb3Qi4KdNSN5eV2Ngj1btLBWE=.5d19cbf7-8daf-4963-a9bb-49123ec307e2@github.com>
Message-ID: <OjEeQbJ4LBL8zDDLpqV0JbWgyirODgtHPMq1mdua49c=.89b50e63-d59d-4cb0-8a26-51f85a1e103c@github.com>

On Fri, 30 Aug 2024 10:17:38 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

> I saw following errors (warnings) when I tried to build OpenJDK on Fedora 40 with gcc-14.2.1-1.fc40.x86_64:
> 
> 
> /home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/HBShaper_Panama.c: In function ?jdk_hb_shape?:
> /home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/HBShaper_Panama.c:101:16: error: unused variable ?yPtSize? [-Werror=unused-variable]
>   101 | float yPtSize = euclidianDistance(matrix[2], matrix[3]);
>       | ^~~~~~~
> cc1: all warnings being treated as errors
> * For target support_native_java.desktop_libfontmanager_X11FontScaler.o:
> /home/ysuenaga/github-forked/jdk/src/java.desktop/unix/native/libfontmanager/X11FontScaler.c: In function ?Java_sun_font_NativeFont_getGlyphAdvance?:
> /home/ysuenaga/github-forked/jdk/src/java.desktop/unix/native/libfontmanager/X11FontScaler.c:270:32: error: unused variable ?descent? [-Werror=unused-variable]
>   270 | int direction, ascent, descent;
>       | ^~~~~~~
> /home/ysuenaga/github-forked/jdk/src/java.desktop/unix/native/libfontmanager/X11FontScaler.c:270:24: error: unused variable ?ascent? [-Werror=unused-variable]
>   270 | int direction, ascent, descent;
>       | ^~~~~~
> /home/ysuenaga/github-forked/jdk/src/java.desktop/unix/native/libfontmanager/X11FontScaler.c:270:13: error: unused variable ?direction? [-Werror=unused-variable]
>   270 | int direction, ascent, descent;
>       | ^~~~~~~~~
> /home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c: In function ?Java_sun_font_FreetypeFontScaler_createScalerContextNative?:
> /home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c:516:19: error: unused variable ?scalerInfo? [-Werror=unused-variable]
>   516 | FTScalerInfo *scalerInfo =
>       | ^~~~~~~~~~
> /home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c: In function ?Java_sun_font_FreetypeFontScaler_getGlyphPointNative?:
> /home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c:1655:13: error: unused variable ?point? [-Werror=unused-variable]
>  1655 | jobject point = NULL;
>       | ^~~~~

I do not stick my proposal, bu5 I hope this will be fixed ASAP for modern C compilers.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20790#issuecomment-2380576054

From fweimer at openjdk.org  Sat Sep 28 10:43:39 2024
From: fweimer at openjdk.org (Florian Weimer)
Date: Sat, 28 Sep 2024 10:43:39 GMT
Subject: RFR: 8339475: Clean up return code handling for pthread calls in
 library coding [v3]
In-Reply-To: <1hkPgl0OA5lEpF6vEmb9DVg-fNndalfotPEmQegz9-w=.40d1f46e-a7cf-49f9-bd55-10f9b9a033f9@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
 <1hkPgl0OA5lEpF6vEmb9DVg-fNndalfotPEmQegz9-w=.40d1f46e-a7cf-49f9-bd55-10f9b9a033f9@github.com>
Message-ID: <q8EKltnXTZ9DZQtEebqs24MmEysSLUBXDRgeYTD4W9Y=.c328d42d-1b0b-4a08-81b6-e7be489c72c7@github.com>

On Thu, 26 Sep 2024 14:44:53 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> It has been discussed that checking the return value of pthread_create should be done.
>> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   some macOS cleanup

src/java.base/macosx/native/libjli/java_md_macosx.m line 315:

> 313:     rc = pthread_create(&main_thr, NULL, &apple_main, &args);
> 314:     if (rc != 0) {
> 315:         JLI_ReportErrorMessageSys("Could not create main thread, return code: %s\n", rc);

This looks buggy, so I filed: https://bugs.openjdk.org/browse/JDK-8341135

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21182#discussion_r1779461874

From duke at openjdk.org  Sat Sep 28 23:03:56 2024
From: duke at openjdk.org (Karm Michal Babacek)
Date: Sat, 28 Sep 2024 23:03:56 GMT
Subject: RFR: 8336382: Fixes error reporting in loading AWT and fonts [v4]
In-Reply-To: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
References: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
Message-ID: <CSh2CzHjXKZk8Qak1-Tb3oxOiqBNRP4Ik2bXPh6adFE=.7d435e12-617d-4831-8a57-07194c7fbeb5@github.com>

> If there is a problem with finding and calling e.g. `java/awt/GraphicsEnvironment` in `AWTIsHeadless`, the env' Exception remains set and it is not cleared. Later, that manifests as:
> 
>     Fatal error reported via JNI: Could not allocate library name
> 
> Which is misleading. The code path is perhaps rare in a normal JDK usage, but it has been complicating our users' bug reports in the GraalVM/native-image ecosystem for quite some time.
> 
> Instead of failing later indicating that the user has incorrectly configured JNI, it bails out very soon with a message that seems as if a jstring could not have been allocated. It sends users on wild goose chases where it appears `JNU_NewStringPlatform` calls failed,  e.g.
> 
> * https://github.com/oracle/graal/issues/9138
> * https://github.com/oracle/graal/issues/8475
> * https://github.com/oracle/graal/issues/9300
> * https://github.com/quarkusio/quarkus/issues/31596
> * https://github.com/graalvm/mandrel/issues/292
> * https://github.com/Karm/mandrel-integration-tests/issues/262
> 
> This commit fixes the error reporting in the AWTIsHeadless.
> 
> Furthermore, when AOT compiled, there is little sense for having a JAVA_HOME, yet some parts of AWT code look for it to search fonts. In such case, an empty directory structure is enough to accommodate it, e.g.
> 
> /tmp/JAVA_HOME/
> /tmp/JAVA_HOME/conf
> /tmp/JAVA_HOME/conf/fonts
> /tmp/JAVA_HOME/lib
> 
> The exception is somewhat cryptic for users again, merely stating:
> 
>     Exception in thread "main" java.io.IOException: Problem reading font data.
>         at java.desktop at 22.0.1/java.awt.Font.createFont0(Font.java:1205)
>         at java.desktop at 22.0.1/java.awt.Font.createFont(Font.java:1076)
>         at imageio.Main.loadFonts(Main.java:139
> 
> Adding the cause there makes it clearer, i.e. that JAVA_HOME might be missing:
> 
>     Exception in thread "main" java.io.IOException: Problem reading font data.
>         at java.desktop at 23-internal/java.awt.Font.createFont0(Font.java:1206)
>         at java.desktop at 23-internal/java.awt.Font.createFont(Font.java:1076)
>         at imageio.Main.loadFonts(Main.java:139)
>         at imageio.Main.paintRectangles(Main.java:97)
>         at imageio.Main.main(Main.java:195)
>         at java.base at 23-internal/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)
>     Caused by: java.lang.Error: java.home property not set
>         at java.desktop at 23-internal/sun.awt.FontConfiguration.findFontConfigFile(FontConfiguration.java:180)
>         at java.desktop at 23-internal/sun.awt.FontConf...

Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' of github.com:openjdk/jdk into awt-load-messages-fonts_backup
 - Display "Problem reading font data. java.home property not set." when java.homenot set and AWT cannot try to lookup fonts
 - Treats missing class as a fatal error
 - Reverts changes to java/awt/Font.java
 - Fixes error reporting in loading AWT and fonts
   
   If there is problem with finding and calling e.g. java/awt/GraphicsEnvironment
   in AWTIsHeadless, the env' Exception remains set and it not cleared.
   Later, that manifests as:
   
       Fatal error reported via JNI: Could not allocate library name
   
   Which is misleading. The code path is perhaps rare in normal JDK usage,
   but it has been complicating our users' bug reports in the GraalVM/native-image
   ecosystem for quite some time.
   
   Instead of failing later with some clear message that indicates that the
   user has incorrectly configured JNI, it bails out very soon with a message
   that seems as if a jstring could not have been allocated. It sends users
   on wild goose chases, e.g.
   
   https://github.com/oracle/graal/issues/9138
   https://github.com/oracle/graal/issues/8475
   https://github.com/oracle/graal/issues/9300
   https://github.com/quarkusio/quarkus/issues/31596
   https://github.com/graalvm/mandrel/issues/292
   https://github.com/Karm/mandrel-integration-tests/issues/262
   
   This commit fixes the error reporting in the AWTIsHeadless.
   
   Furthermore, when AOT compiled, there is little sense for having a JAVA_HOME,
   yet some parts of AWT code look for it to search fonts. In such case, an
   empty directory structure is enough to accommodate it, e.g.
   
   /tmp/JAVA_HOME/
   /tmp/JAVA_HOME/conf
   /tmp/JAVA_HOME/conf/fonts
   /tmp/JAVA_HOME/lib
   
   The exception is somewhat cryptic for users again, merely stating:
   
       Exception in thread "main" java.io.IOException: Problem reading font data.
           at java.desktop at 22.0.1/java.awt.Font.createFont0(Font.java:1205)
           at java.desktop at 22.0.1/java.awt.Font.createFont(Font.java:1076)
           at imageio.Main.loadFonts(Main.java:139
   
   Adding the cause there makes it clearer, i.e. that JAVA_HOME might be missing:
   
       Exception in thread "main" java.io.IOException: Problem reading font data.
           at java.desktop at 23-internal/java.awt.Font.createFont0(Font.java:1206)
           at java.desktop at 23-internal/java.awt.Font.createFont(Font.java:1076)
           at imageio.Main.loadFonts(Main.java:139)
           at imageio.Main.paintRectangles(Main.java:97)
           at imageio.Main.main(Main.java:195)
           at java.base at 23-internal/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)
       Caused by: java.lang.Error: java.home property not set
           at java.desktop at 23-internal/sun.awt.FontConfiguration.findFontConfigFile(FontConfiguration.java:180)
           at java.desktop at 23-internal/sun.awt.FontConfiguration.<init>(FontConfiguration.java:97)

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20169/files
  - new: https://git.openjdk.org/jdk/pull/20169/files/4e33725a..8b203e7c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20169&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20169&range=02-03

  Stats: 256790 lines in 3090 files changed: 209022 ins; 30625 del; 17143 mod
  Patch: https://git.openjdk.org/jdk/pull/20169.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20169/head:pull/20169

PR: https://git.openjdk.org/jdk/pull/20169

From duke at openjdk.org  Sat Sep 28 23:11:10 2024
From: duke at openjdk.org (Karm Michal Babacek)
Date: Sat, 28 Sep 2024 23:11:10 GMT
Subject: RFR: 8336382: Fixes error reporting in loading AWT and fonts [v5]
In-Reply-To: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
References: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
Message-ID: <pGL2MYSwyQOf5dTNdJhPGamxCSnzmpR2eOYag0A1okA=.2e4df9f5-17ee-4b91-929a-2510f2370538@github.com>

> If there is a problem with finding and calling e.g. `java/awt/GraphicsEnvironment` in `AWTIsHeadless`, the env' Exception remains set and it is not cleared. Later, that manifests as:
> 
>     Fatal error reported via JNI: Could not allocate library name
> 
> Which is misleading. The code path is perhaps rare in a normal JDK usage, but it has been complicating our users' bug reports in the GraalVM/native-image ecosystem for quite some time.
> 
> Instead of failing later indicating that the user has incorrectly configured JNI, it bails out very soon with a message that seems as if a jstring could not have been allocated. It sends users on wild goose chases where it appears `JNU_NewStringPlatform` calls failed,  e.g.
> 
> * https://github.com/oracle/graal/issues/9138
> * https://github.com/oracle/graal/issues/8475
> * https://github.com/oracle/graal/issues/9300
> * https://github.com/quarkusio/quarkus/issues/31596
> * https://github.com/graalvm/mandrel/issues/292
> * https://github.com/Karm/mandrel-integration-tests/issues/262
> 
> This commit fixes the error reporting in the AWTIsHeadless.
> 
> Furthermore, when AOT compiled, there is little sense for having a JAVA_HOME, yet some parts of AWT code look for it to search fonts. In such case, an empty directory structure is enough to accommodate it, e.g.
> 
> /tmp/JAVA_HOME/
> /tmp/JAVA_HOME/conf
> /tmp/JAVA_HOME/conf/fonts
> /tmp/JAVA_HOME/lib
> 
> The exception is somewhat cryptic for users again, merely stating:
> 
>     Exception in thread "main" java.io.IOException: Problem reading font data.
>         at java.desktop at 22.0.1/java.awt.Font.createFont0(Font.java:1205)
>         at java.desktop at 22.0.1/java.awt.Font.createFont(Font.java:1076)
>         at imageio.Main.loadFonts(Main.java:139
> 
> Adding the cause there makes it clearer, i.e. that JAVA_HOME might be missing:
> 
>     Exception in thread "main" java.io.IOException: Problem reading font data.
>         at java.desktop at 23-internal/java.awt.Font.createFont0(Font.java:1206)
>         at java.desktop at 23-internal/java.awt.Font.createFont(Font.java:1076)
>         at imageio.Main.loadFonts(Main.java:139)
>         at imageio.Main.paintRectangles(Main.java:97)
>         at imageio.Main.main(Main.java:195)
>         at java.base at 23-internal/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)
>     Caused by: java.lang.Error: java.home property not set
>         at java.desktop at 23-internal/sun.awt.FontConfiguration.findFontConfigFile(FontConfiguration.java:180)
>         at java.desktop at 23-internal/sun.awt.FontConf...

Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision:

  Year 2024 for Font.java

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20169/files
  - new: https://git.openjdk.org/jdk/pull/20169/files/8b203e7c..0cd0ab42

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20169&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20169&range=03-04

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20169.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20169/head:pull/20169

PR: https://git.openjdk.org/jdk/pull/20169

From duke at openjdk.org  Sat Sep 28 23:11:10 2024
From: duke at openjdk.org (Karm Michal Babacek)
Date: Sat, 28 Sep 2024 23:11:10 GMT
Subject: RFR: 8336382: Fixes error reporting in loading AWT and fonts [v5]
In-Reply-To: <chRPMTpWOXXfwgMdFEbNDzgVmuN11XTxPr-buwFq4rM=.af23cbf3-2231-40ea-8051-429233609bb3@github.com>
References: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
 <GbmkgT6SggwJSszpDku1oVChLXFdDXjxj-1qlcbQ53A=.77d741a9-5975-4f23-951b-35abcdeeffe4@github.com>
 <EDgyJfKO5A7SvPmjTbkRo-R-9yFFWIcI4sQhPSuGiyg=.a61ad063-d7b3-4696-8d10-d80a7ede3371@github.com>
 <chRPMTpWOXXfwgMdFEbNDzgVmuN11XTxPr-buwFq4rM=.af23cbf3-2231-40ea-8051-429233609bb3@github.com>
Message-ID: <vM30qGeH0xBl8eUNnyoPg1yKUP1bj7oe38e5qO4qmwQ=.24148540-b96b-4878-8e98-14cd4f816403@github.com>

On Mon, 23 Sep 2024 13:17:09 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> ping @prrace
>
> @Karm There are a few things that have not yet been addressed:
> 
> - @avu mentioned [here](https://github.com/openjdk/jdk/pull/20169#discussion_r1677699984) that copyright years of the file need updating
> - There is a title mismatch between this PR and the JBS entry. Which one should it be if any? (and I'll help you fix that one).
> 
> I'd also merge in latest master since x86 tests have since been disabled. That should fix the GHA issue.
> 
> Thanks!

Hello @jerboaa,

> * @avu mentioned [here](https://github.com/openjdk/jdk/pull/20169#discussion_r1677699984) that copyright years of the file need updating

The year there is 2024 for both edited files.

> * There is a title mismatch between this PR and the JBS entry. Which one should it be if any? (and I'll help you fix that one).

Use the title from this PR, please.

> I'd also merge in latest master since x86 tests have since been disabled. That should fix the GHA issue.

Done.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20169#issuecomment-2381018969

From duke at openjdk.org  Sat Sep 28 23:13:42 2024
From: duke at openjdk.org (Karm Michal Babacek)
Date: Sat, 28 Sep 2024 23:13:42 GMT
Subject: RFR: 8336382: Fixes error reporting in loading AWT and fonts [v4]
In-Reply-To: <CSh2CzHjXKZk8Qak1-Tb3oxOiqBNRP4Ik2bXPh6adFE=.7d435e12-617d-4831-8a57-07194c7fbeb5@github.com>
References: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
 <CSh2CzHjXKZk8Qak1-Tb3oxOiqBNRP4Ik2bXPh6adFE=.7d435e12-617d-4831-8a57-07194c7fbeb5@github.com>
Message-ID: <90Ab0H3CPoePCLTgpkDwSKvSyJN3E9bZUYD8fBBEuj0=.b570b995-65da-49bd-97c7-b79a240926ba@github.com>

On Sat, 28 Sep 2024 23:03:56 GMT, Karm Michal Babacek <duke at openjdk.org> wrote:

>> If there is a problem with finding and calling e.g. `java/awt/GraphicsEnvironment` in `AWTIsHeadless`, the env' Exception remains set and it is not cleared. Later, that manifests as:
>> 
>>     Fatal error reported via JNI: Could not allocate library name
>> 
>> Which is misleading. The code path is perhaps rare in a normal JDK usage, but it has been complicating our users' bug reports in the GraalVM/native-image ecosystem for quite some time.
>> 
>> Instead of failing later indicating that the user has incorrectly configured JNI, it bails out very soon with a message that seems as if a jstring could not have been allocated. It sends users on wild goose chases where it appears `JNU_NewStringPlatform` calls failed,  e.g.
>> 
>> * https://github.com/oracle/graal/issues/9138
>> * https://github.com/oracle/graal/issues/8475
>> * https://github.com/oracle/graal/issues/9300
>> * https://github.com/quarkusio/quarkus/issues/31596
>> * https://github.com/graalvm/mandrel/issues/292
>> * https://github.com/Karm/mandrel-integration-tests/issues/262
>> 
>> This commit fixes the error reporting in the AWTIsHeadless.
>> 
>> Furthermore, when AOT compiled, there is little sense for having a JAVA_HOME, yet some parts of AWT code look for it to search fonts. In such case, an empty directory structure is enough to accommodate it, e.g.
>> 
>> /tmp/JAVA_HOME/
>> /tmp/JAVA_HOME/conf
>> /tmp/JAVA_HOME/conf/fonts
>> /tmp/JAVA_HOME/lib
>> 
>> The exception is somewhat cryptic for users again, merely stating:
>> 
>>     Exception in thread "main" java.io.IOException: Problem reading font data.
>>         at java.desktop at 22.0.1/java.awt.Font.createFont0(Font.java:1205)
>>         at java.desktop at 22.0.1/java.awt.Font.createFont(Font.java:1076)
>>         at imageio.Main.loadFonts(Main.java:139
>> 
>> Adding the cause there makes it clearer, i.e. that JAVA_HOME might be missing:
>> 
>>     Exception in thread "main" java.io.IOException: Problem reading font data.
>>         at java.desktop at 23-internal/java.awt.Font.createFont0(Font.java:1206)
>>         at java.desktop at 23-internal/java.awt.Font.createFont(Font.java:1076)
>>         at imageio.Main.loadFonts(Main.java:139)
>>         at imageio.Main.paintRectangles(Main.java:97)
>>         at imageio.Main.main(Main.java:195)
>>         at java.base at 23-internal/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)
>>     Caused by: java.lang.Error: java.home property not set
>>         at java.desktop at 23-internal/sun.awt.FontConfiguration.findFontConfigF...
>
> Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' of github.com:openjdk/jdk into awt-load-messages-fonts_backup
>  - Display "Problem reading font data. java.home property not set." when java.homenot set and AWT cannot try to lookup fonts
>  - Treats missing class as a fatal error
>  - Reverts changes to java/awt/Font.java
>  - Fixes error reporting in loading AWT and fonts
>    
>    If there is problem with finding and calling e.g. java/awt/GraphicsEnvironment
>    in AWTIsHeadless, the env' Exception remains set and it not cleared.
>    Later, that manifests as:
>    
>        Fatal error reported via JNI: Could not allocate library name
>    
>    Which is misleading. The code path is perhaps rare in normal JDK usage,
>    but it has been complicating our users' bug reports in the GraalVM/native-image
>    ecosystem for quite some time.
>    
>    Instead of failing later with some clear message that indicates that the
>    user has incorrectly configured JNI, it bails out very soon with a message
>    that seems as if a jstring could not have been allocated. It sends users
>    on wild goose chases, e.g.
>    
>    https://github.com/oracle/graal/issues/9138
>    https://github.com/oracle/graal/issues/8475
>    https://github.com/oracle/graal/issues/9300
>    https://github.com/quarkusio/quarkus/issues/31596
>    https://github.com/graalvm/mandrel/issues/292
>    https://github.com/Karm/mandrel-integration-tests/issues/262
>    
>    This commit fixes the error reporting in the AWTIsHeadless.
>    
>    Furthermore, when AOT compiled, there is little sense for having a JAVA_HOME,
>    yet some parts of AWT code look for it to search fonts. In such case, an
>    empty directory structure is enough to accommodate it, e.g.
>    
>    /tmp/JAVA_HOME/
>    /tmp/JAVA_HOME/conf
>    /tmp/JAVA_HOME/conf/fonts
>    /tmp/JAVA_HOME/lib
>    
>    The exception is somewhat cryptic for users again, merely stating:
>    
>        Exception in thread "main" java.io.IOException: Problem reading font data.
>            at java.desktop at 22.0.1/java.awt.Font.createFont0(Font.java:1205)
>            at java.desktop at 22.0.1/java.awt.Font.createFont(Font.java:1076)
>            at imageio.Main.loadFonts(Main.java:139
>    
>    Adding the cause there makes it clearer, i.e. that JAVA_HOME might be missing:
>    
>        Exception in thr...

# Font.java and information leakage

@prrace @jerboaa 

Would this solution address the concern? Instead of passing on the whole throwable, we just inspect it and if it is this particular one, we pass on the information to the user?

+++ b/src/java.desktop/share/classes/java/awt/Font.java
@@ -971,6 +971,9 @@ public static Font[] createFonts(InputStream fontStream)
             }
             return createFont0(fontFormat, fontStream, true, tracker);
         } catch (InterruptedException e) {
+            if (e.getCause().getMessage().contains("java.home property not set")) {
+                throw new IOException("Problem reading font data. java.home property not set.");
+            }
             throw new IOException("Problem reading font data.");

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20169#issuecomment-2381019606

From jdv at openjdk.org  Sun Sep 29 08:05:22 2024
From: jdv at openjdk.org (Jayathirth D V)
Date: Sun, 29 Sep 2024 08:05:22 GMT
Subject: RFR: 8340874: Open source some of the AWT Geometry/Button tests
Message-ID: <YfEuPtfHEPEkBEqyMvVnWAYdUgRpEL5zHFy5sZbWo7s=.fff33462-3ece-46b7-8958-5ef4ea1f62a9@github.com>

Cleanup and open source some of the AWT geom and button tests.

-------------

Commit messages:
 - 8340874: Open source some of the AWT Geometry/Button tests

Changes: https://git.openjdk.org/jdk/pull/21246/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21246&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340874
  Stats: 438 lines in 4 files changed: 438 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21246.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21246/head:pull/21246

PR: https://git.openjdk.org/jdk/pull/21246

From mbaesken at openjdk.org  Sun Sep 29 16:53:40 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Sun, 29 Sep 2024 16:53:40 GMT
Subject: RFR: 8339475: Clean up return code handling for pthread calls in
 library coding [v3]
In-Reply-To: <q8EKltnXTZ9DZQtEebqs24MmEysSLUBXDRgeYTD4W9Y=.c328d42d-1b0b-4a08-81b6-e7be489c72c7@github.com>
References: <7EOB-djMPj6wz3Q87w8hEOyFM_wbfuFzNg54EcL397k=.82ac7581-1f09-42dd-842e-df076dc5ac06@github.com>
 <1hkPgl0OA5lEpF6vEmb9DVg-fNndalfotPEmQegz9-w=.40d1f46e-a7cf-49f9-bd55-10f9b9a033f9@github.com>
 <q8EKltnXTZ9DZQtEebqs24MmEysSLUBXDRgeYTD4W9Y=.c328d42d-1b0b-4a08-81b6-e7be489c72c7@github.com>
Message-ID: <qfAjCPpzS1S1KykGPu7iBAdx7Ry8StMrV_eVhSh6kmM=.a47cf9e4-978f-4b38-bcf8-c2dfd7bc31fe@github.com>

On Sat, 28 Sep 2024 10:40:49 GMT, Florian Weimer <fweimer at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   some macOS cleanup
>
> src/java.base/macosx/native/libjli/java_md_macosx.m line 315:
> 
>> 313:     rc = pthread_create(&main_thr, NULL, &apple_main, &args);
>> 314:     if (rc != 0) {
>> 315:         JLI_ReportErrorMessageSys("Could not create main thread, return code: %s\n", rc);
> 
> This looks buggy, so I filed: https://bugs.openjdk.org/browse/JDK-8341135

Thanks, I'll look into this next week.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21182#discussion_r1780086189

From prr at openjdk.org  Sun Sep 29 17:07:44 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 29 Sep 2024 17:07:44 GMT
Subject: Integrated: 8340560: Open Source several AWT/2D font and rendering
 tests
In-Reply-To: <PID9btqC7r9H4iRAG1fPdARMP_XuuaS1MrmUUiHuBUU=.618165ee-264c-40dc-adb8-438c161111c6@github.com>
References: <PID9btqC7r9H4iRAG1fPdARMP_XuuaS1MrmUUiHuBUU=.618165ee-264c-40dc-adb8-438c161111c6@github.com>
Message-ID: <cG_08WoRcWI2ICgcwESKcrGp3YjKyIKKriosbXG0nxY=.37027c79-49ec-425b-ba4b-a82604359945@github.com>

On Wed, 25 Sep 2024 20:29:40 GMT, Phil Race <prr at openjdk.org> wrote:

> Open sourcing some rendering tests.

This pull request has now been integrated.

Changeset: ade17ecb
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ade17ecb6cb5125d048401a878b557e5afefc08c
Stats:     578 lines in 4 files changed: 578 ins; 0 del; 0 mod

8340560: Open Source several AWT/2D font and rendering tests

Reviewed-by: kizune

-------------

PR: https://git.openjdk.org/jdk/pull/21192

From duke at openjdk.org  Sun Sep 29 21:07:49 2024
From: duke at openjdk.org (Karm Michal Babacek)
Date: Sun, 29 Sep 2024 21:07:49 GMT
Subject: RFR: 8336382: Fixes error reporting in loading AWT and fonts [v6]
In-Reply-To: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
References: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
Message-ID: <He69pnakjPHscZe6zXmYMI2IjpkoZRbkOD4Hk4iBfUk=.a0d503dd-1854-4201-987e-8a285d8f17c7@github.com>

> If there is a problem with finding and calling e.g. `java/awt/GraphicsEnvironment` in `AWTIsHeadless`, the env' Exception remains set and it is not cleared. Later, that manifests as:
> 
>     Fatal error reported via JNI: Could not allocate library name
> 
> Which is misleading. The code path is perhaps rare in a normal JDK usage, but it has been complicating our users' bug reports in the GraalVM/native-image ecosystem for quite some time.
> 
> Instead of failing later indicating that the user has incorrectly configured JNI, it bails out very soon with a message that seems as if a jstring could not have been allocated. It sends users on wild goose chases where it appears `JNU_NewStringPlatform` calls failed,  e.g.
> 
> * https://github.com/oracle/graal/issues/9138
> * https://github.com/oracle/graal/issues/8475
> * https://github.com/oracle/graal/issues/9300
> * https://github.com/quarkusio/quarkus/issues/31596
> * https://github.com/graalvm/mandrel/issues/292
> * https://github.com/Karm/mandrel-integration-tests/issues/262
> 
> This commit fixes the error reporting in the AWTIsHeadless.
> 
> Furthermore, when AOT compiled, there is little sense for having a JAVA_HOME, yet some parts of AWT code look for it to search fonts. In such case, an empty directory structure is enough to accommodate it, e.g.
> 
> /tmp/JAVA_HOME/
> /tmp/JAVA_HOME/conf
> /tmp/JAVA_HOME/conf/fonts
> /tmp/JAVA_HOME/lib
> 
> The exception is somewhat cryptic for users again, merely stating:
> 
>     Exception in thread "main" java.io.IOException: Problem reading font data.
>         at java.desktop at 22.0.1/java.awt.Font.createFont0(Font.java:1205)
>         at java.desktop at 22.0.1/java.awt.Font.createFont(Font.java:1076)
>         at imageio.Main.loadFonts(Main.java:139
> 
> Adding the cause there makes it clearer, i.e. that JAVA_HOME might be missing:
> 
>     Exception in thread "main" java.io.IOException: Problem reading font data.
>         at java.desktop at 23-internal/java.awt.Font.createFont0(Font.java:1206)
>         at java.desktop at 23-internal/java.awt.Font.createFont(Font.java:1076)
>         at imageio.Main.loadFonts(Main.java:139)
>         at imageio.Main.paintRectangles(Main.java:97)
>         at imageio.Main.main(Main.java:195)
>         at java.base at 23-internal/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)
>     Caused by: java.lang.Error: java.home property not set
>         at java.desktop at 23-internal/sun.awt.FontConfiguration.findFontConfigFile(FontConfiguration.java:180)
>         at java.desktop at 23-internal/sun.awt.FontConf...

Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision:

  Reverting "java.home property not set" from Font.java

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20169/files
  - new: https://git.openjdk.org/jdk/pull/20169/files/0cd0ab42..2b3de582

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20169&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20169&range=04-05

  Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20169.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20169/head:pull/20169

PR: https://git.openjdk.org/jdk/pull/20169

From duke at openjdk.org  Sun Sep 29 21:07:49 2024
From: duke at openjdk.org (Karm Michal Babacek)
Date: Sun, 29 Sep 2024 21:07:49 GMT
Subject: RFR: 8336382: Fixes error reporting in loading AWT and fonts [v4]
In-Reply-To: <90Ab0H3CPoePCLTgpkDwSKvSyJN3E9bZUYD8fBBEuj0=.b570b995-65da-49bd-97c7-b79a240926ba@github.com>
References: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
 <CSh2CzHjXKZk8Qak1-Tb3oxOiqBNRP4Ik2bXPh6adFE=.7d435e12-617d-4831-8a57-07194c7fbeb5@github.com>
 <90Ab0H3CPoePCLTgpkDwSKvSyJN3E9bZUYD8fBBEuj0=.b570b995-65da-49bd-97c7-b79a240926ba@github.com>
Message-ID: <dYjzh6iZlSOa6sHFOtVKoGu4p5USbK37iwpB2GGnvF8=.b2bc7fd0-cb1e-4a39-886a-921d2e9f85ae@github.com>

On Sat, 28 Sep 2024 23:10:53 GMT, Karm Michal Babacek <duke at openjdk.org> wrote:

> # Font.java and information leakage
> 
> @prrace @jerboaa
> 
> Would this solution address the concern? Instead of passing on the whole throwable, we just inspect it and if it is this particular one, we pass on the information to the user?
> 
> ```
> +++ b/src/java.desktop/share/classes/java/awt/Font.java
> @@ -971,6 +971,9 @@ public static Font[] createFonts(InputStream fontStream)
>              }
>              return createFont0(fontFormat, fontStream, true, tracker);
>          } catch (InterruptedException e) {
> +            if (e.getCause().getMessage().contains("java.home property not set")) {
> +                throw new IOException("Problem reading font data. java.home property not set.");
> +            }
>              throw new IOException("Problem reading font data.");
> ```

I retract this. It's not that inconvenient and I don't want to complicate this PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20169#issuecomment-2381602619

From duke at openjdk.org  Sun Sep 29 21:10:56 2024
From: duke at openjdk.org (Karm Michal Babacek)
Date: Sun, 29 Sep 2024 21:10:56 GMT
Subject: RFR: 8336382: Fixes error reporting in loading AWT and fonts [v7]
In-Reply-To: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
References: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
Message-ID: <j3mcbP9Q9wL96C9H38tOP9OlpaNb1cZEnxFdK2V0OY8=.736baf95-23e6-4ef7-84d5-d91cdae09001@github.com>

> If there is a problem with finding and calling e.g. `java/awt/GraphicsEnvironment` in `AWTIsHeadless`, the env' Exception remains set and it is not cleared. Later, that manifests as:
> 
>     Fatal error reported via JNI: Could not allocate library name
> 
> Which is misleading. The code path is perhaps rare in a normal JDK usage, but it has been complicating our users' bug reports in the GraalVM/native-image ecosystem for quite some time.
> 
> Instead of failing later indicating that the user has incorrectly configured JNI, it bails out very soon with a message that seems as if a jstring could not have been allocated. It sends users on wild goose chases where it appears `JNU_NewStringPlatform` calls failed,  e.g.
> 
> * https://github.com/oracle/graal/issues/9138
> * https://github.com/oracle/graal/issues/8475
> * https://github.com/oracle/graal/issues/9300
> * https://github.com/quarkusio/quarkus/issues/31596
> * https://github.com/graalvm/mandrel/issues/292
> * https://github.com/Karm/mandrel-integration-tests/issues/262
> 
> This commit fixes the error reporting in the AWTIsHeadless.
> 
> Furthermore, when AOT compiled, there is little sense for having a JAVA_HOME, yet some parts of AWT code look for it to search fonts. In such case, an empty directory structure is enough to accommodate it, e.g.
> 
> /tmp/JAVA_HOME/
> /tmp/JAVA_HOME/conf
> /tmp/JAVA_HOME/conf/fonts
> /tmp/JAVA_HOME/lib
> 
> The exception is somewhat cryptic for users again, merely stating:
> 
>     Exception in thread "main" java.io.IOException: Problem reading font data.
>         at java.desktop at 22.0.1/java.awt.Font.createFont0(Font.java:1205)
>         at java.desktop at 22.0.1/java.awt.Font.createFont(Font.java:1076)
>         at imageio.Main.loadFonts(Main.java:139
> 
> Adding the cause there makes it clearer, i.e. that JAVA_HOME might be missing:
> 
>     Exception in thread "main" java.io.IOException: Problem reading font data.
>         at java.desktop at 23-internal/java.awt.Font.createFont0(Font.java:1206)
>         at java.desktop at 23-internal/java.awt.Font.createFont(Font.java:1076)
>         at imageio.Main.loadFonts(Main.java:139)
>         at imageio.Main.paintRectangles(Main.java:97)
>         at imageio.Main.main(Main.java:195)
>         at java.base at 23-internal/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)
>     Caused by: java.lang.Error: java.home property not set
>         at java.desktop at 23-internal/sun.awt.FontConfiguration.findFontConfigFile(FontConfiguration.java:180)
>         at java.desktop at 23-internal/sun.awt.FontConf...

Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision:

  Reverting changes from Font.java

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20169/files
  - new: https://git.openjdk.org/jdk/pull/20169/files/2b3de582..aa47484d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20169&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20169&range=05-06

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20169.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20169/head:pull/20169

PR: https://git.openjdk.org/jdk/pull/20169

From prr at openjdk.org  Sun Sep 29 21:50:36 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 29 Sep 2024 21:50:36 GMT
Subject: RFR: 8339879: Open some dialog swing tests [v2]
In-Reply-To: <77Oo7T87dLg_JJmRDqZ0rNZ_qQZMEmfECMFRy-8Jz4g=.1e6f6f3d-2fa9-49ca-abf5-a5c5b24ba2ce@github.com>
References: <LWBp0wnS6GkzFhiFfCeKiIAMO5TjlUcaVyEFPR3UXgM=.8edf3ccc-92c6-4360-bde8-8d8a8d2245e8@github.com>
 <77Oo7T87dLg_JJmRDqZ0rNZ_qQZMEmfECMFRy-8Jz4g=.1e6f6f3d-2fa9-49ca-abf5-a5c5b24ba2ce@github.com>
Message-ID: <rnmt48IXcPcBI68XQskEYvAOcbG6GkyZSI8cMM3qCns=.213a58b6-f084-443d-a912-74a1509428d1@github.com>

On Thu, 26 Sep 2024 16:04:31 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> First set of dialog swing tests to open during fall 2024 test sprint
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update jtreg

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21196#pullrequestreview-2336023608

From prr at openjdk.org  Sun Sep 29 21:58:36 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 29 Sep 2024 21:58:36 GMT
Subject: RFR: 8340354: Open source AWT desktop properties and print related
 tests [v2]
In-Reply-To: <zVnITp_WcupCYrpvDt3nRh7fC81YWzwByuerX1FEayg=.020c2c46-7ef5-4f9d-b324-99fb6c1eaaaa@github.com>
References: <yOfPiZp2v3H8OSK4-Wv2GV2SeZq7x0heUpdXWQyKav0=.7f1df951-2c9d-4e6c-b2b2-3464caeaa711@github.com>
 <zVnITp_WcupCYrpvDt3nRh7fC81YWzwByuerX1FEayg=.020c2c46-7ef5-4f9d-b324-99fb6c1eaaaa@github.com>
Message-ID: <j75LGRPP6qQZ3_9unEqY59RA7voVqCr9kDKuB9SfZMc=.841f4d07-bea6-4aea-a638-42311281d93d@github.com>

On Fri, 27 Sep 2024 18:01:24 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> AWT Desktop properties and printer related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spacing fix

Marked as reviewed by prr (Reviewer).

test/jdk/java/awt/DesktopProperties/ThreeDBackgroundColor.java line 25:

> 23: 
> 24: import java.awt.Color;
> 25:         import java.awt.Frame;

seem to have some extra spaces here

-------------

PR Review: https://git.openjdk.org/jdk/pull/21197#pullrequestreview-2336024767
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1780187884

From prr at openjdk.org  Sun Sep 29 22:13:34 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 29 Sep 2024 22:13:34 GMT
Subject: RFR: 8340437: Open source few more AWT Frame related tests
In-Reply-To: <9QKIqkcpfibamjrGdJsGBFMH7q1YcT23mdhS-opzfRQ=.2edd9fc4-648b-4ef4-8858-19433b35aed0@github.com>
References: <9QKIqkcpfibamjrGdJsGBFMH7q1YcT23mdhS-opzfRQ=.2edd9fc4-648b-4ef4-8858-19433b35aed0@github.com>
Message-ID: <mkpoJKmD616p55UWYtKtIx8A9qegdMmgrxgR4ydHM-Y=.8e7a2716-0bec-4a84-a8bc-3a29d9b38482@github.com>

On Thu, 26 Sep 2024 08:05:27 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> AWT Frame related tests are converted from applet to manual/automated and moved to open.

test/jdk/java/awt/Frame/IMStatusBar.java line 44:

> 42:         String INSTRUCTIONS = """
> 43:                 If the window appears the right size, but then resizes so that the
> 44:                 status field overlaps the bottom label, press Fail; otherwise press Pass.

does this ALWAYS bring up an IM window ? On all platforms.

test/jdk/java/awt/Frame/MultiScreenTest.java line 78:

> 76:             throw new SkippedException("You have only one monitor in your system - test passed");
> 77:         }
> 78:         MultiScreenTest obj = new MultiScreenTest();

Although this test will bail if there aren't two monitors, I'd like to see us remember to add @key multimon to such tests.
Then if someone wants to run multimon testsand ONLY those tests they can specify this key 
I'm sure we missed a couple of opportunities to do it already but let's not miss this one.

See 
https://github.com/openjdk/jdk/blob/master/test/jdk/TEST.ROOT

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21199#discussion_r1780190393
PR Review Comment: https://git.openjdk.org/jdk/pull/21199#discussion_r1780189828

From prr at openjdk.org  Sun Sep 29 22:16:35 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 29 Sep 2024 22:16:35 GMT
Subject: RFR: 8340621: Open source several AWT List tests [v2]
In-Reply-To: <guJeDGfAeMUCtkT232gqrTV1PuvnlT7k3A01vCRE9jU=.8a22518d-2da7-4b9a-9b27-263476f71307@github.com>
References: <YVyV6xsPjwRo0o8xo0FZT1C9qzkW8q3lFRmI-OwMW4E=.ccb1d178-2ebe-4e49-8db3-32e22534b49f@github.com>
 <guJeDGfAeMUCtkT232gqrTV1PuvnlT7k3A01vCRE9jU=.8a22518d-2da7-4b9a-9b27-263476f71307@github.com>
Message-ID: <ae_TBFa2PgKadI1EMWvjmGFxPxZqtcYliosirhCtR0Q=.03ce6250-4c70-4e84-aef9-bc04eff3eebc@github.com>

On Thu, 26 Sep 2024 13:43:27 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few AWT List tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spacing

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21202#pullrequestreview-2336027726

From dholmes at openjdk.org  Sun Sep 29 22:19:35 2024
From: dholmes at openjdk.org (David Holmes)
Date: Sun, 29 Sep 2024 22:19:35 GMT
Subject: RFR: 8340801: Disable ubsan checks in some awt/2d coding
In-Reply-To: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
References: <Qh8rfa--rq3Z3kMQwy6idjPacOT3PBd7U_JfG4maHNI=.c9002df4-e829-46f6-962b-952a026bd4a1@github.com>
Message-ID: <O7XW4a3YxSJeLCtbLUJ73xeINN5P0m2MQMEPtbkhuNU=.05a00a08-6a49-42be-917c-4df8702f3f9b@github.com>

On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> There is some old awt/2d coding where warnings occur when running with ubsan enabled binaries.
> However at most of these locations the coding should work (at least on our supported platform set) so the warnings can be disabled at least for now.
> 
> The change adds a macro ATTRIBUTE_NO_UBSAN  similar to what we already use in Hotspot coding.

`jni_md.h` is shipped as part of every JDK distribution - this change does NOT belong in that file.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21184#issuecomment-2381630944

From prr at openjdk.org  Sun Sep 29 22:37:35 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 29 Sep 2024 22:37:35 GMT
Subject: RFR: 8340639: Open source few more AWT List tests
In-Reply-To: <Ryv0vapuxFUfZxC82_Ocj56gRFybhh_tkC0yjVTSMWw=.07764b87-620e-44b9-b795-f7a3418e6694@github.com>
References: <Ryv0vapuxFUfZxC82_Ocj56gRFybhh_tkC0yjVTSMWw=.07764b87-620e-44b9-b795-f7a3418e6694@github.com>
Message-ID: <_-kwCiKKzeD9T9rtracYvj8vAEHM67Yv25JGeTDkkdU=.6d876ecf-4dd4-497f-863f-e6e744cf8b04@github.com>

On Thu, 26 Sep 2024 11:41:31 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few more AWT List tests

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21205#pullrequestreview-2336030580

From prr at openjdk.org  Sun Sep 29 22:49:36 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 29 Sep 2024 22:49:36 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4 [v3]
In-Reply-To: <I9A3r9FCDVZbBUfsmD5B6A3_ji9I3B2JVc-6TjCWk7Y=.512045d1-80b5-40bd-a385-00b4804801ff@github.com>
References: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
 <MAnyM8Icle8vnzSsxU2DH7Ht4IrLApX-6YkcPd7_8-s=.60a04688-4180-4fff-bf39-104cee66b7dd@github.com>
 <U4DPGGDTt0vvGiv1VSLWeuMijYD46YlrOYvumpAKF-w=.f4b82462-b7b1-4205-a311-536101e820e9@github.com>
 <I9A3r9FCDVZbBUfsmD5B6A3_ji9I3B2JVc-6TjCWk7Y=.512045d1-80b5-40bd-a385-00b4804801ff@github.com>
Message-ID: <9w3Yi9potjXjSib3GNgzTBvGfQR8-12UvIKK5fAQqvw=.9c53c824-62b9-4abb-9647-f15b48367b96@github.com>

On Fri, 27 Sep 2024 20:01:17 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> test/jdk/java/awt/dnd/DragToAnotherScreenTest.java line 43:
>> 
>>> 41: /*
>>> 42:  * @test
>>> 43:  * @bug 6179157
>> 
>> Shall we add `@key multimon`?
>
> This test is applicable for single monitors as well. Does `@key multimon` mean muti-monitor setup only ?

Adding multimon seems OK here.
It was the original reason for the test ...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1780195462

From prr at openjdk.org  Sun Sep 29 22:55:34 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 29 Sep 2024 22:55:34 GMT
Subject: RFR: 8340366: Open source several AWT Dialog tests - Batch 3
In-Reply-To: <ejyQ7t2JdYEP7T27OvQ7XNx5dcUck4yKg_eoSyZulas=.9008c135-5b01-4713-9777-549263d30ae6@github.com>
References: <ejyQ7t2JdYEP7T27OvQ7XNx5dcUck4yKg_eoSyZulas=.9008c135-5b01-4713-9777-549263d30ae6@github.com>
Message-ID: <4GjELLn_WKfoYFQfO4XkDaBmaYVn7KsTaJi6zGLnFyQ=.b4e79691-65bd-4f13-8e85-7d929499b349@github.com>

On Fri, 27 Sep 2024 10:20:59 GMT, Tejesh R <tr at openjdk.org> wrote:

> Open source these AWT Dialog tests:
> 
> java/awt/Dialog/ModalDialogTest.java
> java/awt/Dialog/DialogModalityTest.java
> java/awt/Dialog/DialogResizeTest2.java
> java/awt/Dialog/HideDialogTest.java
> java/awt/Dialog/FileDialogUserFilterTest.java

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21218#pullrequestreview-2336033346

From prr at openjdk.org  Sun Sep 29 22:56:39 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 29 Sep 2024 22:56:39 GMT
Subject: RFR: 8341037: Use standard layouts in DefaultFrameIconTest.java
 and MenuCrash.java
In-Reply-To: <cS9l_dZ0n4syDxzDR89dc7eHpMtzdQRIzhwazaGCpQA=.62015088-62c4-4b46-860d-22f4e65eb14e@github.com>
References: <cS9l_dZ0n4syDxzDR89dc7eHpMtzdQRIzhwazaGCpQA=.62015088-62c4-4b46-860d-22f4e65eb14e@github.com>
Message-ID: <z7W-xawWSO4XLpUztxTrQ91BEJKnK0b8VjOdgPl__Cg=.a1f7cd9b-5295-48db-99b9-e552a7292a25@github.com>

On Fri, 27 Sep 2024 16:34:52 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Now that standard window layouts are available as part of the `PassFailJFrame` framework, we can use them in tests.
> 
> Two tests from #21180, specifically `test/jdk/java/awt/Frame/DefaultFrameIconTest.java` and `test/jdk/java/awt/Frame/MenuCrash.java`, use two test windows. At this time, the tests implement positioning explicitly in the test. After #21207 is integrated, these two tests could be updated to use the standard layout. They would serve as sample usage of multi-window test UI.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21226#pullrequestreview-2336033511

From prr at openjdk.org  Sun Sep 29 22:58:33 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 29 Sep 2024 22:58:33 GMT
Subject: RFR: 8340874: Open source some of the AWT Geometry/Button tests
In-Reply-To: <YfEuPtfHEPEkBEqyMvVnWAYdUgRpEL5zHFy5sZbWo7s=.fff33462-3ece-46b7-8958-5ef4ea1f62a9@github.com>
References: <YfEuPtfHEPEkBEqyMvVnWAYdUgRpEL5zHFy5sZbWo7s=.fff33462-3ece-46b7-8958-5ef4ea1f62a9@github.com>
Message-ID: <gUwc6l8HkxFZgAMcGpi9W4AuKkAAsKXil3zYuTQGCjY=.6a58f104-78a4-4d2c-b188-b28a3761f082@github.com>

On Sun, 29 Sep 2024 07:59:49 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

> Cleanup and open source some of the AWT geom and button tests.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21246#pullrequestreview-2336033889

From prr at openjdk.org  Sun Sep 29 23:04:39 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 29 Sep 2024 23:04:39 GMT
Subject: RFR: 8340407: Open source a few more Component related tests
In-Reply-To: <rK-dbwVbgJrsiQWOTxrpHB88COtl7MnDEAf20nGGZ_U=.d32ac658-4799-4202-8166-477950ac3e4d@github.com>
References: <rK-dbwVbgJrsiQWOTxrpHB88COtl7MnDEAf20nGGZ_U=.d32ac658-4799-4202-8166-477950ac3e4d@github.com>
Message-ID: <CLCfkM1IsS5_8uEigYj27lY6fLMPQGP5yJua1NSCuvI=.ef682396-d14d-42d8-a92d-5c79ad0f4e15@github.com>

On Fri, 27 Sep 2024 20:29:42 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and open source four tests.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21234#pullrequestreview-2336034746

From dnguyen at openjdk.org  Sun Sep 29 23:59:20 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Sun, 29 Sep 2024 23:59:20 GMT
Subject: RFR: 8340432: Open source some MenuBar tests - Set2
Message-ID: <P6braHc3jBKCK6O0fqHKser3QsQ6glIAApAjyFaF1Wo=.cdffdb28-a489-4ebb-9d7d-6a3e4be48768@github.com>

Following tests are added as part of this PR:

/java/awt/MenuBar/MenuBarOnDisabledFrame/MenuBarOnDisabledFrame.java (Manual with PassFailJFrame)
/java/awt/MenuBar/MenuBarAddRemoveTest/MenuBarAddRemoveTest.java (Manual with PassFailJFrame)
/java/awt/MenuBar/SetHelpMenuTest/SetHelpMenuTest.java (Manual with PassFailJFrame)
/java/awt/MenuBar/MenuBarVisuals/MenuBarVisuals.java (Manual with PassFailJFrame)

-------------

Commit messages:
 - Remove escape chars
 - Initial commit to open

Changes: https://git.openjdk.org/jdk/pull/21251/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21251&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340432
  Stats: 326 lines in 4 files changed: 326 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21251.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21251/head:pull/21251

PR: https://git.openjdk.org/jdk/pull/21251

From dnguyen at openjdk.org  Mon Sep 30 00:12:54 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 30 Sep 2024 00:12:54 GMT
Subject: RFR: 8340164: Open source few Component tests - Set1
Message-ID: <TBLTIJvSS8mq5BJwwM3B5t_HfRDXXHGGzHAheL2KHgE=.94f2cdb8-8896-45c8-a797-1a5e7ea508c9@github.com>

Following tests are added as part of this PR:

/java/awt/LightweightComponent/LightweightFontTest/LightweightFontTest.java (Manual with PassFailJFrame)
/java/awt/LightweightComponent/LightWeightTabFocus/LightWeightTabFocus.java (Automated)
/java/awt/LightweightComponent/LWParentMovedTest/LWParentMovedTest.java (Automated)

-------------

Commit messages:
 - Initial commit

Changes: https://git.openjdk.org/jdk/pull/21252/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21252&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340164
  Stats: 435 lines in 3 files changed: 435 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21252.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21252/head:pull/21252

PR: https://git.openjdk.org/jdk/pull/21252

From psadhukhan at openjdk.org  Mon Sep 30 02:47:42 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 30 Sep 2024 02:47:42 GMT
Subject: Integrated: 8340621: Open source several AWT List tests
In-Reply-To: <YVyV6xsPjwRo0o8xo0FZT1C9qzkW8q3lFRmI-OwMW4E=.ccb1d178-2ebe-4e49-8db3-32e22534b49f@github.com>
References: <YVyV6xsPjwRo0o8xo0FZT1C9qzkW8q3lFRmI-OwMW4E=.ccb1d178-2ebe-4e49-8db3-32e22534b49f@github.com>
Message-ID: <fEKXw24TbIq2bh-4pXI12yEB8eAsTOojwEOjZeSWpUI=.eb789559-2006-4a19-9247-6bdd467b8ce7@github.com>

On Thu, 26 Sep 2024 09:43:25 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few AWT List tests

This pull request has now been integrated.

Changeset: ae4d2f15
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ae4d2f15901bf02efceaac26ee4aa3ae666bf467
Stats:     500 lines in 5 files changed: 500 ins; 0 del; 0 mod

8340621: Open source several AWT List tests

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/21202

From psadhukhan at openjdk.org  Mon Sep 30 02:48:47 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 30 Sep 2024 02:48:47 GMT
Subject: Integrated: 8340639: Open source few more AWT List tests
In-Reply-To: <Ryv0vapuxFUfZxC82_Ocj56gRFybhh_tkC0yjVTSMWw=.07764b87-620e-44b9-b795-f7a3418e6694@github.com>
References: <Ryv0vapuxFUfZxC82_Ocj56gRFybhh_tkC0yjVTSMWw=.07764b87-620e-44b9-b795-f7a3418e6694@github.com>
Message-ID: <4WfMkjO-5JXZyeZr7EYdnNVlT_Aihg0RF6wabkS1q_Q=.c861f104-d6fb-4835-9fa0-89b40d961752@github.com>

On Thu, 26 Sep 2024 11:41:31 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few more AWT List tests

This pull request has now been integrated.

Changeset: dd569909
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/dd56990962d58e4f482773f67bc43383d7748536
Stats:     388 lines in 4 files changed: 388 ins; 0 del; 0 mod

8340639: Open source few more AWT List tests

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/21205

From psadhukhan at openjdk.org  Mon Sep 30 03:14:10 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 30 Sep 2024 03:14:10 GMT
Subject: RFR: 8340719: Open source AWT List tests
Message-ID: <5wgQPCKvLrE2lr_4uvJ9xAEL108ikcdSjwIJofAlnqg=.68a076ed-26de-44eb-94d9-402a30061906@github.com>

Opensource few AWT List tests...

-------------

Commit messages:
 - Merge master
 - 8340719: Open source AWT List tests

Changes: https://git.openjdk.org/jdk/pull/21253/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21253&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340719
  Stats: 412 lines in 5 files changed: 412 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21253.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21253/head:pull/21253

PR: https://git.openjdk.org/jdk/pull/21253

From psadhukhan at openjdk.org  Mon Sep 30 03:30:37 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 30 Sep 2024 03:30:37 GMT
Subject: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v5]
In-Reply-To: <AAyJQxLyZ1mtk1NFhtWSw0KRIqksLRDmzWp63MDF804=.bee235e6-a0e8-4d8b-96ef-76e224b0ac9d@github.com>
References: <uAVUmO5oIBQXSFTbqnr61Nj_TmrO18l9U_moSnxPlg0=.b103600b-05cb-4fb1-8d6a-523dfb4a1f20@github.com>
 <AAyJQxLyZ1mtk1NFhtWSw0KRIqksLRDmzWp63MDF804=.bee235e6-a0e8-4d8b-96ef-76e224b0ac9d@github.com>
Message-ID: <1S_0A9Mz5zYGReIMfPDZCOfClxEdTXEoQcIJ2Sk66z8=.07757c9b-b3d6-4b80-9bd1-f2319b639c86@github.com>

On Thu, 26 Sep 2024 06:56:23 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Open source these AWT Mouse and GraphicsEnvironment tests:
>> 
>> java/awt/MouseClickCount/MouseClickCount.java
>> java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java
>> java/awt/MouseDragTest/MouseDragTest.java
>> java/awt/OpenWinDoubleClickTest/OpenWinDoubleClickTest.java
>> java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   ProblemList updated

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21126#pullrequestreview-2336265524

From psadhukhan at openjdk.org  Mon Sep 30 03:32:37 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 30 Sep 2024 03:32:37 GMT
Subject: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v2]
In-Reply-To: <OQfqBYokPEnN9O8aNDvwzhz-CW-g7jXHrcuLD_7PpqU=.b0fd8792-b604-43c4-8b7a-1dc82cd86729@github.com>
References: <A_AenkvGSNRrpXk_wcGxZ3Cw-dCFaHsd-75onI6mCX4=.1f17a7fe-701d-417e-8579-08856070ee18@github.com>
 <1iDPjVAbfvfeK0NaWkN3uzNqvieGr-NKKWeAVW0KETE=.283c1d4d-86e3-4ede-8649-54d501139c99@github.com>
 <brPkqcdO-rqyltEYrncQhWpgT-1j273JWxnOPnJL6cM=.ea4aaa43-b81f-4d32-bfac-de5ef36b945f@github.com>
 <OQfqBYokPEnN9O8aNDvwzhz-CW-g7jXHrcuLD_7PpqU=.b0fd8792-b604-43c4-8b7a-1dc82cd86729@github.com>
Message-ID: <Yf0ZXBB50sK6d_5t38tGTfOAVbf_3yIwKppzRlLfNX4=.07f2afb1-6fd1-40aa-932b-cb9e4d5f8880@github.com>

On Fri, 27 Sep 2024 11:55:21 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> I'm getting this error if I use ` PassFailJFrame.log`  to `componentResize` method.
>> `java.lang.NullPointerException: Cannot invoke "javax.swing.JTextArea.append(String)" because "PassFailJFrame.logArea" is null`. Since the test is about resize, I've updated only resize related print statement.
>
> Probably component is resized even before PassFailJFrame creates the logArea in Builder interface.
> The instructions says 
> "When isResizable is true the dialog is resizable. When isResizable is false the dialog is non-resizable" and you are logging "PassFailJFrame.log("isResizable is set to: " + bResizeState);" 
> 
> so, it seems ComponentListener is not needed and all these 4 methods can be removed which is only logging and that too is not visible to tester...

this is pending..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1780355712

From psadhukhan at openjdk.org  Mon Sep 30 03:32:38 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 30 Sep 2024 03:32:38 GMT
Subject: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v2]
In-Reply-To: <86Vb8yXKc16RS5EW6180IUmGP5ORgSIhuM2kpZUjdDw=.1080dd5e-6760-4c51-91da-979fea7cc28b@github.com>
References: <A_AenkvGSNRrpXk_wcGxZ3Cw-dCFaHsd-75onI6mCX4=.1f17a7fe-701d-417e-8579-08856070ee18@github.com>
 <86Vb8yXKc16RS5EW6180IUmGP5ORgSIhuM2kpZUjdDw=.1080dd5e-6760-4c51-91da-979fea7cc28b@github.com>
Message-ID: <ON0Lf3_OWlMwYK-X4p795cIO5_VUoRs3GkZxjjeUUK8=.9db9a03b-c290-45a4-89e1-820c66893684@github.com>

On Fri, 27 Sep 2024 10:09:22 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Open source these AWT Mouse tests:
>> 
>> java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java
>> java/awt/Dialog/FileDialogWrongNameCrash.java
>> java/awt/Dialog/DialogResizeTest.java
>> java/awt/Dialog/GetLocationTest_1.java
>> java/awt/Dialog/DialogIconTest/DialogIconTest.java
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments updated

test/jdk/java/awt/Dialog/GetLocationTest_1.java line 50:

> 48:                    up with the top left by the cursor
> 49:                 2. If you see this correct behavior press PASS. If you see that
> 50:                    the yellow window location is offset by an some inset, press FAIL

"an" to be removed..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1780355523

From psadhukhan at openjdk.org  Mon Sep 30 03:39:36 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 30 Sep 2024 03:39:36 GMT
Subject: RFR: 8340458: Open source additional Component tests (part 2)
In-Reply-To: <amLY1mvQ69kyzvu63buXopJZJKpu8I4kZDPKup-iwmQ=.e797a9b2-738c-4b38-a585-60a2c3f1b250@github.com>
References: <amLY1mvQ69kyzvu63buXopJZJKpu8I4kZDPKup-iwmQ=.e797a9b2-738c-4b38-a585-60a2c3f1b250@github.com>
Message-ID: <p6xZPdl1d_j37yKhaSHVPcKdmJ10RH7GYhSLAhokZJY=.8388fc41-c9f2-45b1-b251-ac611fcda729@github.com>

On Fri, 27 Sep 2024 20:33:07 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and open source four more tests.

test/jdk/java/awt/Component/BackgroundColorTest/InitialBackgroundSettingTest.java line 52:

> 50:     Scrollbar bar = new Scrollbar(Scrollbar.HORIZONTAL);
> 51:     Button button = new Button("I am the button");
> 52: 

I believe all this initialization needs to be put in `setupGUI` under EDT..more so as it is an automated test..

test/jdk/java/awt/Component/ListDoubleIndentTest/ListDoubleIndentTest.java line 66:

> 64: 
> 65:         try {
> 66:             Frame f = new Frame("ListDoubleIndentTest");

dispose is missing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21235#discussion_r1780356570
PR Review Comment: https://git.openjdk.org/jdk/pull/21235#discussion_r1780358166

From psadhukhan at openjdk.org  Mon Sep 30 03:42:36 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 30 Sep 2024 03:42:36 GMT
Subject: RFR: 8340432: Open source some MenuBar tests - Set2
In-Reply-To: <P6braHc3jBKCK6O0fqHKser3QsQ6glIAApAjyFaF1Wo=.cdffdb28-a489-4ebb-9d7d-6a3e4be48768@github.com>
References: <P6braHc3jBKCK6O0fqHKser3QsQ6glIAApAjyFaF1Wo=.cdffdb28-a489-4ebb-9d7d-6a3e4be48768@github.com>
Message-ID: <12hguJo6qcfU8-F5r314cXl-AkIwxB9zsOOyXRrBGt0=.8f04c53b-755f-4039-83ef-e408c3aaba1e@github.com>

On Sun, 29 Sep 2024 23:54:13 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Following tests are added as part of this PR:
> 
> /java/awt/MenuBar/MenuBarOnDisabledFrame/MenuBarOnDisabledFrame.java (Manual with PassFailJFrame)
> /java/awt/MenuBar/MenuBarAddRemoveTest/MenuBarAddRemoveTest.java (Manual with PassFailJFrame)
> /java/awt/MenuBar/SetHelpMenuTest/SetHelpMenuTest.java (Manual with PassFailJFrame)
> /java/awt/MenuBar/MenuBarVisuals/MenuBarVisuals.java (Manual with PassFailJFrame)

test/jdk/java/awt/MenuBar/MenuBarAddRemoveTest/MenuBarAddRemoveTest.java line 28:

> 26:  * @bug 4028130 4112308
> 27:  * @summary Disabling a frame does not disable the menus on the frame, on
> 28:  *      solaris/linux

seems summary is wrong for this test...

test/jdk/java/awt/MenuBar/MenuBarVisuals/MenuBarVisuals.java line 63:

> 61: 
> 62:     private static Frame createUI() {
> 63:         Frame f = new Frame("Test frame");

meaningful frame name can be given...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21251#discussion_r1780359098
PR Review Comment: https://git.openjdk.org/jdk/pull/21251#discussion_r1780359591

From psadhukhan at openjdk.org  Mon Sep 30 03:56:35 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 30 Sep 2024 03:56:35 GMT
Subject: RFR: 8340164: Open source few Component tests - Set1
In-Reply-To: <TBLTIJvSS8mq5BJwwM3B5t_HfRDXXHGGzHAheL2KHgE=.94f2cdb8-8896-45c8-a797-1a5e7ea508c9@github.com>
References: <TBLTIJvSS8mq5BJwwM3B5t_HfRDXXHGGzHAheL2KHgE=.94f2cdb8-8896-45c8-a797-1a5e7ea508c9@github.com>
Message-ID: <UDXQ7T9CH0xauxmzyQ_6jCeVvdEcwM5ofp8Yn7maObw=.3a54f999-af34-4530-8e7e-86ac162e2b03@github.com>

On Mon, 30 Sep 2024 00:08:25 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Following tests are added as part of this PR:
> 
> /java/awt/LightweightComponent/LightweightFontTest/LightweightFontTest.java (Manual with PassFailJFrame)
> /java/awt/LightweightComponent/LightWeightTabFocus/LightWeightTabFocus.java (Automated)
> /java/awt/LightweightComponent/LWParentMovedTest/LWParentMovedTest.java (Automated)

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/java/awt/LightweightComponent/LWParentMovedTest/LWParentMovedTest.java line 28:

> 26:  * @bug 4147246
> 27:  * @summary Simple check for peer != null in Component.componentMoved
> 28:  * (Component.java)

Component.java can be removed..guess it was Native*Helper inner class which made it reference Component.java but now that class is not there so reference to java file can be removed..

-------------

PR Review: https://git.openjdk.org/jdk/pull/21252#pullrequestreview-2336280311
PR Review Comment: https://git.openjdk.org/jdk/pull/21252#discussion_r1780365388

From abhiscxk at openjdk.org  Mon Sep 30 06:10:21 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 30 Sep 2024 06:10:21 GMT
Subject: RFR: 8340437: Open source few more AWT Frame related tests [v2]
In-Reply-To: <9QKIqkcpfibamjrGdJsGBFMH7q1YcT23mdhS-opzfRQ=.2edd9fc4-648b-4ef4-8858-19433b35aed0@github.com>
References: <9QKIqkcpfibamjrGdJsGBFMH7q1YcT23mdhS-opzfRQ=.2edd9fc4-648b-4ef4-8858-19433b35aed0@github.com>
Message-ID: <b20ah0gv5f-lTTRcqKaExLNv_obxPbkH3ZGgSb2vgu8=.4b8527ea-7b86-4960-8be7-e90fba4180ac@github.com>

> AWT Frame related tests are converted from applet to manual/automated and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  add multimonitor jtreg key

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21199/files
  - new: https://git.openjdk.org/jdk/pull/21199/files/837c6d1b..20e5f11b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21199&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21199&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21199.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21199/head:pull/21199

PR: https://git.openjdk.org/jdk/pull/21199

From abhiscxk at openjdk.org  Mon Sep 30 06:10:21 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 30 Sep 2024 06:10:21 GMT
Subject: RFR: 8340437: Open source few more AWT Frame related tests [v2]
In-Reply-To: <mkpoJKmD616p55UWYtKtIx8A9qegdMmgrxgR4ydHM-Y=.8e7a2716-0bec-4a84-a8bc-3a29d9b38482@github.com>
References: <9QKIqkcpfibamjrGdJsGBFMH7q1YcT23mdhS-opzfRQ=.2edd9fc4-648b-4ef4-8858-19433b35aed0@github.com>
 <mkpoJKmD616p55UWYtKtIx8A9qegdMmgrxgR4ydHM-Y=.8e7a2716-0bec-4a84-a8bc-3a29d9b38482@github.com>
Message-ID: <U5QcyYBikg4O-KtixxAqmo6AcbICPT3RRHJ6ZLaAoPI=.1f87ff27-6a56-4e1e-b114-24960a8b721e@github.com>

On Sun, 29 Sep 2024 22:08:28 GMT, Phil Race <prr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add multimonitor jtreg key
>
> test/jdk/java/awt/Frame/MultiScreenTest.java line 78:
> 
>> 76:             throw new SkippedException("You have only one monitor in your system - test passed");
>> 77:         }
>> 78:         MultiScreenTest obj = new MultiScreenTest();
> 
> Although this test will bail if there aren't two monitors, I'd like to see us remember to add @key multimon to such tests.
> Then if someone wants to run multimon testsand ONLY those tests they can specify this key 
> I'm sure we missed a couple of opportunities to do it already but let's not miss this one.
> 
> See 
> https://github.com/openjdk/jdk/blob/master/test/jdk/TEST.ROOT

Ok.. added ` @key multimon `.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21199#discussion_r1780482257

From abhiscxk at openjdk.org  Mon Sep 30 06:12:38 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 30 Sep 2024 06:12:38 GMT
Subject: RFR: 8340354: Open source AWT desktop properties and print related
 tests [v3]
In-Reply-To: <yOfPiZp2v3H8OSK4-Wv2GV2SeZq7x0heUpdXWQyKav0=.7f1df951-2c9d-4e6c-b2b2-3464caeaa711@github.com>
References: <yOfPiZp2v3H8OSK4-Wv2GV2SeZq7x0heUpdXWQyKav0=.7f1df951-2c9d-4e6c-b2b2-3464caeaa711@github.com>
Message-ID: <Re19ult1DANyGjFhzqNqshoc16OQER3iYWTx-GmoztQ=.594d4a7d-e9bb-49b9-aa13-1228e99e1938@github.com>

> AWT Desktop properties and printer related tests are converted from applet to manual and moved to open.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Remove extra spaces

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21197/files
  - new: https://git.openjdk.org/jdk/pull/21197/files/acab40c8..ae0e6e72

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21197&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21197&range=01-02

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/21197.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21197/head:pull/21197

PR: https://git.openjdk.org/jdk/pull/21197

From abhiscxk at openjdk.org  Mon Sep 30 06:12:39 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 30 Sep 2024 06:12:39 GMT
Subject: RFR: 8340354: Open source AWT desktop properties and print related
 tests [v2]
In-Reply-To: <j75LGRPP6qQZ3_9unEqY59RA7voVqCr9kDKuB9SfZMc=.841f4d07-bea6-4aea-a638-42311281d93d@github.com>
References: <yOfPiZp2v3H8OSK4-Wv2GV2SeZq7x0heUpdXWQyKav0=.7f1df951-2c9d-4e6c-b2b2-3464caeaa711@github.com>
 <zVnITp_WcupCYrpvDt3nRh7fC81YWzwByuerX1FEayg=.020c2c46-7ef5-4f9d-b324-99fb6c1eaaaa@github.com>
 <j75LGRPP6qQZ3_9unEqY59RA7voVqCr9kDKuB9SfZMc=.841f4d07-bea6-4aea-a638-42311281d93d@github.com>
Message-ID: <y0y8Jx3YyWrpXU9Q0kpNOdw4Tsa6eZ3mPbSVTKUXXWs=.371a4d9e-2449-4882-94d8-2176b3091ff2@github.com>

On Sun, 29 Sep 2024 21:55:45 GMT, Phil Race <prr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   spacing fix
>
> test/jdk/java/awt/DesktopProperties/ThreeDBackgroundColor.java line 25:
> 
>> 23: 
>> 24: import java.awt.Color;
>> 25:         import java.awt.Frame;
> 
> seem to have some extra spaces here

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1780484207

From abhiscxk at openjdk.org  Mon Sep 30 06:41:42 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 30 Sep 2024 06:41:42 GMT
Subject: Integrated: 8340605: Open source several AWT PopupMenu tests
In-Reply-To: <s2yEIJ_5shNyXnWKgQnKypsUp-wNVwjHQBXYW0Q8I88=.f47e4717-c72d-4ded-838c-cefd6f852209@github.com>
References: <s2yEIJ_5shNyXnWKgQnKypsUp-wNVwjHQBXYW0Q8I88=.f47e4717-c72d-4ded-838c-cefd6f852209@github.com>
Message-ID: <E9x6CelZK2ghS-luZPDtQTbejceuwjDq4ZdGxBG6WAA=.bde2f71b-1fa1-472c-8d57-9898505996b9@github.com>

On Tue, 24 Sep 2024 07:46:14 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Several AWT PopupMEnu related tests are converted from applet to manual and moved to open.

This pull request has now been integrated.

Changeset: 822a7738
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/822a773873c42ea27a6be90da92b2b2c9fb8caee
Stats:     431 lines in 5 files changed: 431 ins; 0 del; 0 mod

8340605: Open source several AWT PopupMenu tests

Reviewed-by: tr

-------------

PR: https://git.openjdk.org/jdk/pull/21151

From abhiscxk at openjdk.org  Mon Sep 30 06:42:38 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 30 Sep 2024 06:42:38 GMT
Subject: RFR: 8340437: Open source few more AWT Frame related tests [v2]
In-Reply-To: <mkpoJKmD616p55UWYtKtIx8A9qegdMmgrxgR4ydHM-Y=.8e7a2716-0bec-4a84-a8bc-3a29d9b38482@github.com>
References: <9QKIqkcpfibamjrGdJsGBFMH7q1YcT23mdhS-opzfRQ=.2edd9fc4-648b-4ef4-8858-19433b35aed0@github.com>
 <mkpoJKmD616p55UWYtKtIx8A9qegdMmgrxgR4ydHM-Y=.8e7a2716-0bec-4a84-a8bc-3a29d9b38482@github.com>
Message-ID: <ongMzsMZxL4RZLLKAbFV-GMjgAgJQajPJVWrGK7fsdQ=.4ad439b8-dfb2-443d-9f40-ebe47a546aeb@github.com>

On Sun, 29 Sep 2024 22:11:06 GMT, Phil Race <prr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add multimonitor jtreg key
>
> test/jdk/java/awt/Frame/IMStatusBar.java line 44:
> 
>> 42:         String INSTRUCTIONS = """
>> 43:                 If the window appears the right size, but then resizes so that the
>> 44:                 status field overlaps the bottom label, press Fail; otherwise press Pass.
> 
> does this ALWAYS bring up an IM window ? On all platforms.

I checked on all platforms (Win, Linux and Mac), IM window always shown.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21199#discussion_r1780517191

From sgehwolf at openjdk.org  Mon Sep 30 09:08:37 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 30 Sep 2024 09:08:37 GMT
Subject: RFR: 8336382: Fixes error reporting in loading AWT and fonts [v7]
In-Reply-To: <vM30qGeH0xBl8eUNnyoPg1yKUP1bj7oe38e5qO4qmwQ=.24148540-b96b-4878-8e98-14cd4f816403@github.com>
References: <m5S3knqxLW2I6NdoAyl9U3LoU6F9SHU2YySXCqJdZkc=.28b5a09b-2336-48dc-9dc1-ea12af8b618a@github.com>
 <GbmkgT6SggwJSszpDku1oVChLXFdDXjxj-1qlcbQ53A=.77d741a9-5975-4f23-951b-35abcdeeffe4@github.com>
 <EDgyJfKO5A7SvPmjTbkRo-R-9yFFWIcI4sQhPSuGiyg=.a61ad063-d7b3-4696-8d10-d80a7ede3371@github.com>
 <chRPMTpWOXXfwgMdFEbNDzgVmuN11XTxPr-buwFq4rM=.af23cbf3-2231-40ea-8051-429233609bb3@github.com>
 <vM30qGeH0xBl8eUNnyoPg1yKUP1bj7oe38e5qO4qmwQ=.24148540-b96b-4878-8e98-14cd4f816403@github.com>
Message-ID: <IW-km070ZDXoazO6uGw9Q-52Gg2AZfxnhdbHvukbFRs=.8ac69df3-1952-44ab-afe2-119ee33c518e@github.com>

On Sat, 28 Sep 2024 23:07:39 GMT, Karm Michal Babacek <duke at openjdk.org> wrote:

> > * There is a title mismatch between this PR and the JBS entry. Which one should it be if any? (and I'll help you fix that one).
> 
> Use the title from this PR, please.

Done.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20169#issuecomment-2382554795

From jdv at openjdk.org  Mon Sep 30 11:27:43 2024
From: jdv at openjdk.org (Jayathirth D V)
Date: Mon, 30 Sep 2024 11:27:43 GMT
Subject: Integrated: 8340874: Open source some of the AWT Geometry/Button tests
In-Reply-To: <YfEuPtfHEPEkBEqyMvVnWAYdUgRpEL5zHFy5sZbWo7s=.fff33462-3ece-46b7-8958-5ef4ea1f62a9@github.com>
References: <YfEuPtfHEPEkBEqyMvVnWAYdUgRpEL5zHFy5sZbWo7s=.fff33462-3ece-46b7-8958-5ef4ea1f62a9@github.com>
Message-ID: <SvmcH9DDlRei-9wSf3cuJforzbsKJgp10SRGEzJMP9o=.ff69fd39-0f24-40d3-be83-403bb92faae0@github.com>

On Sun, 29 Sep 2024 07:59:49 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

> Cleanup and open source some of the AWT geom and button tests.

This pull request has now been integrated.

Changeset: e19c7d80
Author:    Jayathirth D V <jdv at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e19c7d80f722395583fbdb4cc10dc9051c8602f2
Stats:     438 lines in 4 files changed: 438 ins; 0 del; 0 mod

8340874: Open source some of the AWT Geometry/Button tests

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/21246

From abhiscxk at openjdk.org  Mon Sep 30 12:17:37 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 30 Sep 2024 12:17:37 GMT
Subject: RFR: 8340719: Open source AWT List tests
In-Reply-To: <5wgQPCKvLrE2lr_4uvJ9xAEL108ikcdSjwIJofAlnqg=.68a076ed-26de-44eb-94d9-402a30061906@github.com>
References: <5wgQPCKvLrE2lr_4uvJ9xAEL108ikcdSjwIJofAlnqg=.68a076ed-26de-44eb-94d9-402a30061906@github.com>
Message-ID: <yqE9hZeD4ssUDqoapxC63MvwZ4uZPQZjmsgqzbW9IyA=.c4ca35be-16f9-4cfc-a5ca-cd078958d27e@github.com>

On Mon, 30 Sep 2024 03:07:17 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few AWT List tests...

test/jdk/java/awt/List/HandlingKeyEventIfMousePressedTest.java line 49:

> 47: import java.awt.event.MouseAdapter;
> 48: import java.awt.event.MouseMotionAdapter;
> 49: import java.awt.event.MouseEvent;

Suggestion:

import java.awt.event.MouseEvent;
import java.awt.event.MouseMotionAdapter;

test/jdk/java/awt/List/HandlingKeyEventIfMousePressedTest.java line 73:

> 71:             // key pressing when the mouse is kept in the 'pressed' state
> 72:             robot.keyPress(KeyEvent.VK_DOWN);
> 73:             robot.keyRelease(KeyEvent.VK_DOWN);

Test summary says about "SPACE, UP and DOWN" keys but the test checks only for "DOWN" key... should it extend for other keys as well?

test/jdk/java/awt/List/ListActionEventTest.java line 56:

> 54:                 .title("ListActionEventTest Instructions")
> 55:                 .instructions(INSTRUCTIONS)
> 56:                 .rows((int) INSTRUCTIONS.lines().count() + 2)

may be removed.

test/jdk/java/awt/List/MultiSelectionListHorizScrollbar.java line 41:

> 39:     private static final String INSTRUCTIONS = """
> 40:          Resize the frame so that the lists are not wide enough to fully display the lines of text they contain.
> 41:          Once the lists are in this state, press pass if both lists display an horizontal scrollbar. Otherwise press fail.""";

Plz limit it to 80

test/jdk/java/awt/List/MultiSelectionListHorizScrollbar.java line 41:

> 39:     private static final String INSTRUCTIONS = """
> 40:          Resize the frame so that the lists are not wide enough to fully display the lines of text they contain.
> 41:          Once the lists are in this state, press pass if both lists display an horizontal scrollbar. Otherwise press fail.""";

Suggestion:

         Resize the frame so that the lists are not wide enough to fully display the lines of text they contain.
         Once the lists are in this state, press Pass if both lists display an horizontal scrollbar. Otherwise press Fail.""";

test/jdk/java/awt/List/RepaintAfterResize.java line 63:

> 61:         frame.setLayout (new FlowLayout ());
> 62:         list.setBounds(100, 100, 100, 100);
> 63:         for(int i=0 ; i < 7 ; i++){

Suggestion:

        for(int i = 0 ; i < 7 ; i++){

test/jdk/java/awt/List/RepaintAfterResize.java line 64:

> 62:         list.setBounds(100, 100, 100, 100);
> 63:         for(int i=0 ; i < 7 ; i++){
> 64:             list.add(" "+i);

Suggestion:

            list.add(" " + i);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1780974265
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1780984859
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1780993928
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1780994975
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1780995750
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1781001435
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1781001796

From azvegint at openjdk.org  Mon Sep 30 13:24:00 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 30 Sep 2024 13:24:00 GMT
Subject: RFR: 8340907: Open source closed frame tests # 2
Message-ID: <sIRypM0KaHiXhJ44ZF4d1TjaWbX7VRirnxgkoJD3iH8=.19ece419-6d3f-4b9a-b7f8-88f9936df1a5@github.com>

Few more tests to open source

Testing looks good.

-------------

Commit messages:
 - 8340907: Open source closed frame tests # 2

Changes: https://git.openjdk.org/jdk/pull/21264/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21264&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340907
  Stats: 441 lines in 5 files changed: 441 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21264.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21264/head:pull/21264

PR: https://git.openjdk.org/jdk/pull/21264

From psadhukhan at openjdk.org  Mon Sep 30 13:59:12 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 30 Sep 2024 13:59:12 GMT
Subject: RFR: 8340719: Open source AWT List tests [v2]
In-Reply-To: <5wgQPCKvLrE2lr_4uvJ9xAEL108ikcdSjwIJofAlnqg=.68a076ed-26de-44eb-94d9-402a30061906@github.com>
References: <5wgQPCKvLrE2lr_4uvJ9xAEL108ikcdSjwIJofAlnqg=.68a076ed-26de-44eb-94d9-402a30061906@github.com>
Message-ID: <YBIE0ZNqVSuV3pF6_86lYgXVVMUHjpbFj_ZgPMxEDQs=.83905853-fd7e-4aae-8b7d-2de536e5726c@github.com>

> Opensource few AWT List tests...

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Formatting

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21253/files
  - new: https://git.openjdk.org/jdk/pull/21253/files/df6b2260..6fea3fca

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21253&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21253&range=00-01

  Stats: 8 lines in 3 files changed: 3 ins; 1 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/21253.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21253/head:pull/21253

PR: https://git.openjdk.org/jdk/pull/21253

From psadhukhan at openjdk.org  Mon Sep 30 13:59:12 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 30 Sep 2024 13:59:12 GMT
Subject: RFR: 8340719: Open source AWT List tests [v2]
In-Reply-To: <yqE9hZeD4ssUDqoapxC63MvwZ4uZPQZjmsgqzbW9IyA=.c4ca35be-16f9-4cfc-a5ca-cd078958d27e@github.com>
References: <5wgQPCKvLrE2lr_4uvJ9xAEL108ikcdSjwIJofAlnqg=.68a076ed-26de-44eb-94d9-402a30061906@github.com>
 <yqE9hZeD4ssUDqoapxC63MvwZ4uZPQZjmsgqzbW9IyA=.c4ca35be-16f9-4cfc-a5ca-cd078958d27e@github.com>
Message-ID: <vDH9JwqIqDTQbaxreJ5I5xn3gZsI3vc1-ZUJwvbl-yw=.61a437e3-3f61-4b0a-9ed6-8266162d920d@github.com>

On Mon, 30 Sep 2024 11:52:22 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Formatting
>
> test/jdk/java/awt/List/HandlingKeyEventIfMousePressedTest.java line 49:
> 
>> 47: import java.awt.event.MouseAdapter;
>> 48: import java.awt.event.MouseMotionAdapter;
>> 49: import java.awt.event.MouseEvent;
> 
> Suggestion:
> 
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseMotionAdapter;

ok

> test/jdk/java/awt/List/HandlingKeyEventIfMousePressedTest.java line 73:
> 
>> 71:             // key pressing when the mouse is kept in the 'pressed' state
>> 72:             robot.keyPress(KeyEvent.VK_DOWN);
>> 73:             robot.keyRelease(KeyEvent.VK_DOWN);
> 
> Test summary says about "SPACE, UP and DOWN" keys but the test checks only for "DOWN" key... should it extend for other keys as well?

Original test is similar so have not changed.

> test/jdk/java/awt/List/ListActionEventTest.java line 56:
> 
>> 54:                 .title("ListActionEventTest Instructions")
>> 55:                 .instructions(INSTRUCTIONS)
>> 56:                 .rows((int) INSTRUCTIONS.lines().count() + 2)
> 
> may be removed.

not mandatory...

> test/jdk/java/awt/List/MultiSelectionListHorizScrollbar.java line 41:
> 
>> 39:     private static final String INSTRUCTIONS = """
>> 40:          Resize the frame so that the lists are not wide enough to fully display the lines of text they contain.
>> 41:          Once the lists are in this state, press pass if both lists display an horizontal scrollbar. Otherwise press fail.""";
> 
> Plz limit it to 80

ok

> test/jdk/java/awt/List/RepaintAfterResize.java line 63:
> 
>> 61:         frame.setLayout (new FlowLayout ());
>> 62:         list.setBounds(100, 100, 100, 100);
>> 63:         for(int i=0 ; i < 7 ; i++){
> 
> Suggestion:
> 
>         for(int i = 0 ; i < 7 ; i++){

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1781183071
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1781184555
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1781184867
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1781185059
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1781185263

From aivanov at openjdk.org  Mon Sep 30 14:39:44 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 30 Sep 2024 14:39:44 GMT
Subject: RFR: JDK-8340555 : Open source DnD tests - Set4 [v5]
In-Reply-To: <HWQFkOKyZP55INGkyK7ZJjI9_TxsvyYhLC2f02rKv5M=.75885fef-476f-47d3-919b-d9f9930acaa6@github.com>
References: <049tozCf4dKSaVUlxgE1XtIXbrMfcH9WDmQh_W5Gs4s=.87356976-dfb0-4536-a84f-ca97943518a5@github.com>
 <HWQFkOKyZP55INGkyK7ZJjI9_TxsvyYhLC2f02rKv5M=.75885fef-476f-47d3-919b-d9f9930acaa6@github.com>
Message-ID: <Ldm9HDW_6gVNgB8G8q-lIfc04o7-ERRUi4fS_AwBX-U=.cf3a5c82-ec3a-41e7-82db-d1936c281a7c@github.com>

On Fri, 27 Sep 2024 22:01:13 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are added as part of this PR:
>> 
>> 1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual PassFailJFrame (PFJ) test**, problemlisted on all platforms.
>> 
>> 2. java/awt/dnd/DragSourceMotionListenerTest.java -  **Automated test**, problemlisted on windows
>> 
>> 3. /java/awt/dnd/DragToAnotherScreenTest.java - **Manual PFJ test**
>> 
>> 4. /java/awt/dnd/RejectDragTest.java - **Automated test**, problemlisted on macOS
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed redundant frame.setLocation()

test/jdk/ProblemList.txt line 468:

> 466: java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java 8266243 macosx-aarch64
> 467: java/awt/dnd/BadSerializationTest/BadSerializationTest.java 8277817 linux-x64,windows-x64
> 468: java/awt/dnd/DragSourceMotionListenerTest.java 8225131 windows-all

`DragSourceMotionListenerTest` passes for me on Windows. Does it need to be problem-listed?

test/jdk/ProblemList.txt line 469:

> 467: java/awt/dnd/BadSerializationTest/BadSerializationTest.java 8277817 linux-x64,windows-x64
> 468: java/awt/dnd/DragSourceMotionListenerTest.java 8225131 windows-all
> 469: java/awt/dnd/RejectDragTest.java 7124259 macosx-all

I wonder if `RejectDragTest` still fails on macOS. Latest comment in [JDK-7124259](https://bugs.openjdk.org/browse/JDK-7124259) is dated February 2020. The problem could be fixed by now.

test/jdk/ProblemList.txt line 470:

> 468: java/awt/dnd/DragSourceMotionListenerTest.java 8225131 windows-all
> 469: java/awt/dnd/RejectDragTest.java 7124259 macosx-all
> 470: java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java 8027424 generic-all

DnDHTMLToOutlookTest passes for me with Mozilla Thunderbird 128.2.3 as well as with Microsoft Word and Outlook version 2302 on Windows.

I haven't tested on Linux or macOS.

test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java line 71:

> 69: 
> 70:         mainPanel = new Panel();
> 71:         mainPanel.setLayout(new FlowLayout());

If we could make the panel larger, it would be easier to move it around on the screen. It's too small, and you can't grab it by title bar unless you resize the window.

This test involves interacting with other applications, so it's good to be able to move the drag source, the button, on the screen.

test/jdk/java/awt/dnd/DragSourceMotionListenerTest.java line 82:

> 80:     private static final Point testPoint2 = new Point();
> 81:     private static volatile Point srcPoint;
> 82:     private static volatile Dimension d;

`d` shouldn't be `volatile`; it should rather be a local variable in all the `invokeAndWait` calls ? it's used only there.

test/jdk/java/awt/dnd/DragSourceMotionListenerTest.java line 152:

> 150:                 srcPoint = source.getLocationOnScreen();
> 151:                 d = source.getSize();
> 152:                 srcPoint.translate(d.width / 2, d.height / 2);

This is thread-safe only because you use `invokeAndWait`, not because `srcPoint` is a volatile variable. It's only the assignment to a volatile variable that creates the *happens-before* relation to the following reads.

It is easier to reason the correctness of the code if you assign to a volatile variable once; otherwise, additional modifications to the state of the assigned reference aren't guaranteed to be seen by other threads which read the updated reference from the variable.

This case is still thread-safe, even without using `volatile` modifiers because of `invokeAndWait`, provided there are no other threads but main and EDT which read the value of `srcPoint`.

Since it's common to add the `volatile` modifier, we should follow the rules for using it:

Suggestion:

                Point p = source.getLocationOnScreen();
                Dimension d = source.getSize();
                p.translate(d.width / 2, d.height / 2);
                srcPoint = p;


In the suggested snippet, the write to `srcPoint` occurs when the object `p` that has be read from another thread already has the state we want. When another thread reads the new value `srcPoint`, it is guaranteed to see the result of `translate` operation, which wasn't the case for the code as it's written (if it were not for `invokeAndWait`).

test/jdk/java/awt/dnd/DragSourceMotionListenerTest.java line 165:

> 163:                 dstOutsidePoint.translate(3 * d.width / 2, d.height / 2);
> 164:              });
> 165:             testPoint1.setLocation(dstOutsidePoint);

EDT is not guaranteed to see the updated values of `testPoint2` fields without additional synchronisation, and you need it for `sourceAdapter.dragMouseMoved`.

test/jdk/java/awt/dnd/DragSourceMotionListenerTest.java line 172:

> 170:                 dstInsidePoint.translate(d.width / 2, d.height / 2);
> 171:             });
> 172:             testPoint2.setLocation(dstInsidePoint);

EDT is not guaranteed to see the updated values of `testPoint2` fields without additional synchronisation, and you need it for `sourceAdapter.dragDropEnd`.

Nether testPoint1 nor testPoint2 are used on main thread (except for the object instantiation). Move `setLocation` calls into `invokeAndWait`: then EDT is guaranteed to see the updated fields values of the `Point` objects.

test/jdk/java/awt/dnd/DragSourceMotionListenerTest.java line 229:

> 227:             mouseReleaseEvent.countDown();
> 228:             clickedComponent = (Component)e.getSource();
> 229:         }

Suggestion:

        if (e.getID() == MouseEvent.MOUSE_RELEASED) {
            clickedComponent = (Component)e.getSource();
            mouseReleaseEvent.countDown();
        }

For thread-safety, you have to assign `clickedComponent` before releasing the latch; otherwise, the thread that's released from `await` is not guaranteed to see the updated value of `clickedComponent`.

test/jdk/java/awt/dnd/DragSourceMotionListenerTest.java line 235:

> 233:         mouseReleaseEvent = new CountDownLatch(1);
> 234:         robot.waitForIdle();
> 235:         reset();

I suggest moving `reset()` before you create a new instance of `CountDownLatch`  and therefore before you write its reference to the volatile field `mouseReleaseEvent`.

test/jdk/java/awt/dnd/DragSourceMotionListenerTest.java line 240:

> 238:         robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 239:         robot.waitForIdle();
> 240:         robot.delay(500);

Waiting is somewhat redundant here? you wait for the event using a `CountDownLatch`.

test/jdk/java/awt/dnd/DragSourceMotionListenerTest.java line 245:

> 243:         }
> 244: 
> 245:         Component c = clickedComponent;

Accessing `clickedComponent` is not thread-safe here.

For it to be thread-safe, you have to assign the value before `mouseReleaseEvent.countDown()`.

test/jdk/java/awt/dnd/DragToAnotherScreenTest.java line 60:

> 58: 
> 59:                 If on multi-monitor screens then please position
> 60:                 the drag and drop windows on different screens.

This can be done automatically? I mean `PassFailJFrame` won't be able to handle positioning of the second frame on another screen. Yet you can do it in the code.

test/jdk/java/awt/dnd/DragToAnotherScreenTest.java line 73:

> 71:                 If the second label changes its text to drag me
> 72:                 after the drop and you DO NOT see any error messages
> 73:                 in the log area press PASS else FAIL.

I think we can make it semi-automatic then. If the test determines an error condition, the test could fail automatically.

However, to give a better experience for the tester, the test could display a message before calling `forceFail`.

Another way could be disabling the `Pass` button, yet it's not possible at the moment.

test/jdk/java/awt/dnd/RejectDragTest.java line 147:

> 145:             startPoint.translate(50, 50);
> 146:             endPoint.translate(150, 150);
> 147:         });

The same problem occurs here: evaluate the correct values for the fields of `startPoint` and `endPoint` and only then assign a reference to the volatile field.

(As in `DragSourceMotionListenerTest.java`)

test/jdk/java/awt/dnd/RejectDragTest.java line 169:

> 167: 
> 168:     public static int sign(int n) {
> 169:         return Integer.compare(n, 0);

Actually, [the specification](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/Integer.html#compare(int,int)) does not guarantee only `0`, `1`, and `-1` are returned, yet OpenJDK implementation does return these three values only:

https://github.com/openjdk/jdk/blob/f1bf469b4ee07b48b629a126111e307d3cab7fd7/src/java.base/share/classes/java/lang/Integer.java#L1408-L1410

We could use this, I guess.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781211627
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781247125
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781096791
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781110291
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781112427
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781127928
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781169609
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781174131
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781141616
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781162547
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781137066
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781137675
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781257340
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781261574
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781222555
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1781233684

From dnguyen at openjdk.org  Mon Sep 30 16:53:00 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 30 Sep 2024 16:53:00 GMT
Subject: RFR: 8340432: Open source some MenuBar tests - Set2 [v2]
In-Reply-To: <P6braHc3jBKCK6O0fqHKser3QsQ6glIAApAjyFaF1Wo=.cdffdb28-a489-4ebb-9d7d-6a3e4be48768@github.com>
References: <P6braHc3jBKCK6O0fqHKser3QsQ6glIAApAjyFaF1Wo=.cdffdb28-a489-4ebb-9d7d-6a3e4be48768@github.com>
Message-ID: <BgSw46dp8lnPnxwu_e0bI6Qdurz7HMyQNM8uXM_MNMc=.32c2b374-63c2-4f0f-94cb-0e173ebf3283@github.com>

> Following tests are added as part of this PR:
> 
> /java/awt/MenuBar/MenuBarOnDisabledFrame/MenuBarOnDisabledFrame.java (Manual with PassFailJFrame)
> /java/awt/MenuBar/MenuBarAddRemoveTest/MenuBarAddRemoveTest.java (Manual with PassFailJFrame)
> /java/awt/MenuBar/SetHelpMenuTest/SetHelpMenuTest.java (Manual with PassFailJFrame)
> /java/awt/MenuBar/MenuBarVisuals/MenuBarVisuals.java (Manual with PassFailJFrame)

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21251/files
  - new: https://git.openjdk.org/jdk/pull/21251/files/b93f91b5..43ab7d2b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21251&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21251&range=00-01

  Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21251.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21251/head:pull/21251

PR: https://git.openjdk.org/jdk/pull/21251

From dnguyen at openjdk.org  Mon Sep 30 16:53:00 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 30 Sep 2024 16:53:00 GMT
Subject: RFR: 8340432: Open source some MenuBar tests - Set2 [v2]
In-Reply-To: <12hguJo6qcfU8-F5r314cXl-AkIwxB9zsOOyXRrBGt0=.8f04c53b-755f-4039-83ef-e408c3aaba1e@github.com>
References: <P6braHc3jBKCK6O0fqHKser3QsQ6glIAApAjyFaF1Wo=.cdffdb28-a489-4ebb-9d7d-6a3e4be48768@github.com>
 <12hguJo6qcfU8-F5r314cXl-AkIwxB9zsOOyXRrBGt0=.8f04c53b-755f-4039-83ef-e408c3aaba1e@github.com>
Message-ID: <vgbv6pxyKzRQEMckOseuI2prCD3hT1_6rOFrtyEV2yc=.937b44a8-5b22-4ab1-a0b4-b3fd197a8312@github.com>

On Mon, 30 Sep 2024 03:38:37 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> test/jdk/java/awt/MenuBar/MenuBarAddRemoveTest/MenuBarAddRemoveTest.java line 28:
> 
>> 26:  * @bug 4028130 4112308
>> 27:  * @summary Disabling a frame does not disable the menus on the frame, on
>> 28:  *      solaris/linux
> 
> seems summary is wrong for this test...

Good catch. Test didn't have one originally, and I missed it. Added, thanks.

> test/jdk/java/awt/MenuBar/MenuBarVisuals/MenuBarVisuals.java line 63:
> 
>> 61: 
>> 62:     private static Frame createUI() {
>> 63:         Frame f = new Frame("Test frame");
> 
> meaningful frame name can be given...

Updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21251#discussion_r1781458161
PR Review Comment: https://git.openjdk.org/jdk/pull/21251#discussion_r1781457673

From honkar at openjdk.org  Mon Sep 30 16:56:26 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 30 Sep 2024 16:56:26 GMT
Subject: RFR: JDK-8340332 : Open source mixed AWT tests - Set3
Message-ID: <k347Z9aHy9eB7k5bF8tC18MfFIIp3phMXhBKcmgvZ5A=.e57cb348-a879-4d06-ae1b-7ee9b8b22da9@github.com>

Following tests are open-sourced in this PR:

1. /java/awt/MouseInfo/ContainerResizeMousePositionTest.java - Automated
2. [LINUX ONLY] /java/awt/color/XAWTDifference/XAWTDifference.java - Manual PFJ test

-------------

Commit messages:
 - mixed awt tests

Changes: https://git.openjdk.org/jdk/pull/21271/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21271&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340332
  Stats: 361 lines in 3 files changed: 361 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/21271.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21271/head:pull/21271

PR: https://git.openjdk.org/jdk/pull/21271

From aivanov at openjdk.org  Mon Sep 30 17:45:35 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 30 Sep 2024 17:45:35 GMT
Subject: RFR: JDK-8340332 : Open source mixed AWT tests - Set3
In-Reply-To: <k347Z9aHy9eB7k5bF8tC18MfFIIp3phMXhBKcmgvZ5A=.e57cb348-a879-4d06-ae1b-7ee9b8b22da9@github.com>
References: <k347Z9aHy9eB7k5bF8tC18MfFIIp3phMXhBKcmgvZ5A=.e57cb348-a879-4d06-ae1b-7ee9b8b22da9@github.com>
Message-ID: <Rxch2OySQxMekw-r98NV8RQxpbEd8YxMn6EjzchoHxg=.f6e0f408-811a-49e6-a597-453a3030c6e7@github.com>

On Mon, 30 Sep 2024 16:51:04 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following tests are open-sourced in this PR:
> 
> 1. /java/awt/MouseInfo/ContainerResizeMousePositionTest.java - Automated
> 2. [LINUX ONLY] /java/awt/color/XAWTDifference/XAWTDifference.java - Manual PFJ test

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/MouseInfo/ContainerResizeMousePositionTest.java line 95:

> 93: 
> 94:         if (!eventCaught.await(2, TimeUnit.SECONDS)) {
> 95:             if (!testSucceeded) {

These two conditions look independent.

If `eventCaught.await` returned `false`, the test should fail with a timeout.

Otherwise, the test fails if `testSucceeded` didn't become `true`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21271#pullrequestreview-2338223302
PR Review Comment: https://git.openjdk.org/jdk/pull/21271#discussion_r1781527179

From honkar at openjdk.org  Mon Sep 30 18:16:41 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 30 Sep 2024 18:16:41 GMT
Subject: RFR: JDK-8340332 : Open source mixed AWT tests - Set3
In-Reply-To: <Rxch2OySQxMekw-r98NV8RQxpbEd8YxMn6EjzchoHxg=.f6e0f408-811a-49e6-a597-453a3030c6e7@github.com>
References: <k347Z9aHy9eB7k5bF8tC18MfFIIp3phMXhBKcmgvZ5A=.e57cb348-a879-4d06-ae1b-7ee9b8b22da9@github.com>
 <Rxch2OySQxMekw-r98NV8RQxpbEd8YxMn6EjzchoHxg=.f6e0f408-811a-49e6-a597-453a3030c6e7@github.com>
Message-ID: <_OGZmuep5GS5-sbbcT9HxT4t7ynzZotWMgDKrcbhOP4=.ba7a58a6-8d0a-4c8d-a103-781597b19e78@github.com>

On Mon, 30 Sep 2024 17:40:36 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Following tests are open-sourced in this PR:
>> 
>> 1. /java/awt/MouseInfo/ContainerResizeMousePositionTest.java - Automated
>> 2. [LINUX ONLY] /java/awt/color/XAWTDifference/XAWTDifference.java - Manual PFJ test
>
> test/jdk/java/awt/MouseInfo/ContainerResizeMousePositionTest.java line 95:
> 
>> 93: 
>> 94:         if (!eventCaught.await(2, TimeUnit.SECONDS)) {
>> 95:             if (!testSucceeded) {
> 
> These two conditions look independent.
> 
> If `eventCaught.await` returned `false`, the test should fail with a timeout.
> 
> Otherwise, the test fails if `testSucceeded` didn't become `true`.

Did you mean this way ?


if (eventCaught.await(2, TimeUnit.SECONDS)) {
    if (!testSucceeded) {
        throw new RuntimeException("Test Failed: Container.getMousePosition(boolean)"
                                   + " returned incorrect result while Container resized");
    }
} else {
    throw new RuntimeException("Test timeout: Didn't receive"
                               + " Component Resized Event");
}

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21271#discussion_r1781562446

From aivanov at openjdk.org  Mon Sep 30 18:28:37 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 30 Sep 2024 18:28:37 GMT
Subject: RFR: JDK-8340332 : Open source mixed AWT tests - Set3
In-Reply-To: <_OGZmuep5GS5-sbbcT9HxT4t7ynzZotWMgDKrcbhOP4=.ba7a58a6-8d0a-4c8d-a103-781597b19e78@github.com>
References: <k347Z9aHy9eB7k5bF8tC18MfFIIp3phMXhBKcmgvZ5A=.e57cb348-a879-4d06-ae1b-7ee9b8b22da9@github.com>
 <Rxch2OySQxMekw-r98NV8RQxpbEd8YxMn6EjzchoHxg=.f6e0f408-811a-49e6-a597-453a3030c6e7@github.com>
 <_OGZmuep5GS5-sbbcT9HxT4t7ynzZotWMgDKrcbhOP4=.ba7a58a6-8d0a-4c8d-a103-781597b19e78@github.com>
Message-ID: <3U_bj5xZ8TtmdpwR5KZMxAiz0nqwAzzSz9tbthRWal0=.ec8770f2-bab8-4c06-994e-53f84742ee11@github.com>

On Mon, 30 Sep 2024 18:13:50 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> test/jdk/java/awt/MouseInfo/ContainerResizeMousePositionTest.java line 95:
>> 
>>> 93: 
>>> 94:         if (!eventCaught.await(2, TimeUnit.SECONDS)) {
>>> 95:             if (!testSucceeded) {
>> 
>> These two conditions look independent.
>> 
>> If `eventCaught.await` returned `false`, the test should fail with a timeout.
>> 
>> Otherwise, the test fails if `testSucceeded` didn't become `true`.
>
> Did you mean this way ? Condition updated
> 
> 
>         if (eventCaught.await(2, TimeUnit.SECONDS)) {
>             if (!testSucceeded) {
>                 throw new RuntimeException("Test Failed: Container.getMousePosition(boolean)"
>                                            + " returned incorrect result while Container resized");
>             }
>         } else {
>             throw new RuntimeException("Test timeout: Didn't receive"
>                                        + " Component Resized Event");
>         }

I'd rather not put them into one condition either, even though the condition above looks correct.


        if (!eventCaught.await(2, TimeUnit.SECONDS)) {
            throw new RuntimeException("componentResized isn't received within a timeout");
        }

        if (!testSucceeded) {
            throw new RuntimeException("Container.getMousePosition(boolean)"
                                       + " returned incorrect result while Container resized");
        }

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21271#discussion_r1781575360

From aivanov at openjdk.org  Mon Sep 30 18:42:56 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 30 Sep 2024 18:42:56 GMT
Subject: RFR: JDK-8340332 : Open source mixed AWT tests - Set3 [v2]
In-Reply-To: <1wTFkhyXMj0PiqfJC9meMNw7qQWKBA3TRIr6nJA6C1Y=.9af23e26-5f81-4660-a3ca-b83fd85d4bb6@github.com>
References: <k347Z9aHy9eB7k5bF8tC18MfFIIp3phMXhBKcmgvZ5A=.e57cb348-a879-4d06-ae1b-7ee9b8b22da9@github.com>
 <1wTFkhyXMj0PiqfJC9meMNw7qQWKBA3TRIr6nJA6C1Y=.9af23e26-5f81-4660-a3ca-b83fd85d4bb6@github.com>
Message-ID: <n2N5joKfScZxYSblBqVSpFCQWa5cNt05JBYw5QPyOW0=.902bd860-f8a8-4172-8493-b15f88296d6c@github.com>

On Mon, 30 Sep 2024 18:39:22 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are open-sourced in this PR:
>> 
>> 1. /java/awt/MouseInfo/ContainerResizeMousePositionTest.java - Automated
>> 2. [LINUX ONLY] /java/awt/color/XAWTDifference/XAWTDifference.java - Manual PFJ test
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   test condition updated

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21271#pullrequestreview-2338323027

From honkar at openjdk.org  Mon Sep 30 18:42:56 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 30 Sep 2024 18:42:56 GMT
Subject: RFR: JDK-8340332 : Open source mixed AWT tests - Set3 [v2]
In-Reply-To: <3U_bj5xZ8TtmdpwR5KZMxAiz0nqwAzzSz9tbthRWal0=.ec8770f2-bab8-4c06-994e-53f84742ee11@github.com>
References: <k347Z9aHy9eB7k5bF8tC18MfFIIp3phMXhBKcmgvZ5A=.e57cb348-a879-4d06-ae1b-7ee9b8b22da9@github.com>
 <Rxch2OySQxMekw-r98NV8RQxpbEd8YxMn6EjzchoHxg=.f6e0f408-811a-49e6-a597-453a3030c6e7@github.com>
 <_OGZmuep5GS5-sbbcT9HxT4t7ynzZotWMgDKrcbhOP4=.ba7a58a6-8d0a-4c8d-a103-781597b19e78@github.com>
 <3U_bj5xZ8TtmdpwR5KZMxAiz0nqwAzzSz9tbthRWal0=.ec8770f2-bab8-4c06-994e-53f84742ee11@github.com>
Message-ID: <aLl_ApTGZrE_3oHWRslzx42_-YTUszI8Pxk_UpoTbJs=.060f4288-3503-4f86-aaac-fefe98710cfa@github.com>

On Mon, 30 Sep 2024 18:26:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Did you mean this way ? Condition updated
>> 
>> 
>>         if (eventCaught.await(2, TimeUnit.SECONDS)) {
>>             if (!testSucceeded) {
>>                 throw new RuntimeException("Test Failed: Container.getMousePosition(boolean)"
>>                                            + " returned incorrect result while Container resized");
>>             }
>>         } else {
>>             throw new RuntimeException("Test timeout: Didn't receive"
>>                                        + " Component Resized Event");
>>         }
>
> I'd rather not put them into one condition either, even though the condition above looks correct.
> 
> 
>         if (!eventCaught.await(2, TimeUnit.SECONDS)) {
>             throw new RuntimeException("componentResized isn't received within a timeout");
>         }
> 
>         if (!testSucceeded) {
>             throw new RuntimeException("Container.getMousePosition(boolean)"
>                                        + " returned incorrect result while Container resized");
>         }

After re-reading the comment it makes sense to keep it separate. Thanks. Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21271#discussion_r1781589442

From honkar at openjdk.org  Mon Sep 30 18:42:56 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 30 Sep 2024 18:42:56 GMT
Subject: RFR: JDK-8340332 : Open source mixed AWT tests - Set3 [v2]
In-Reply-To: <k347Z9aHy9eB7k5bF8tC18MfFIIp3phMXhBKcmgvZ5A=.e57cb348-a879-4d06-ae1b-7ee9b8b22da9@github.com>
References: <k347Z9aHy9eB7k5bF8tC18MfFIIp3phMXhBKcmgvZ5A=.e57cb348-a879-4d06-ae1b-7ee9b8b22da9@github.com>
Message-ID: <1wTFkhyXMj0PiqfJC9meMNw7qQWKBA3TRIr6nJA6C1Y=.9af23e26-5f81-4660-a3ca-b83fd85d4bb6@github.com>

> Following tests are open-sourced in this PR:
> 
> 1. /java/awt/MouseInfo/ContainerResizeMousePositionTest.java - Automated
> 2. [LINUX ONLY] /java/awt/color/XAWTDifference/XAWTDifference.java - Manual PFJ test

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  test condition updated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21271/files
  - new: https://git.openjdk.org/jdk/pull/21271/files/fdfbfdb1..59bfb969

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21271&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21271&range=00-01

  Stats: 7 lines in 1 file changed: 3 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/21271.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21271/head:pull/21271

PR: https://git.openjdk.org/jdk/pull/21271

From honkar at openjdk.org  Mon Sep 30 18:48:44 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 30 Sep 2024 18:48:44 GMT
Subject: Integrated: JDK-8340332 : Open source mixed AWT tests - Set3
In-Reply-To: <k347Z9aHy9eB7k5bF8tC18MfFIIp3phMXhBKcmgvZ5A=.e57cb348-a879-4d06-ae1b-7ee9b8b22da9@github.com>
References: <k347Z9aHy9eB7k5bF8tC18MfFIIp3phMXhBKcmgvZ5A=.e57cb348-a879-4d06-ae1b-7ee9b8b22da9@github.com>
Message-ID: <PpTQ9OMIx58H2DtksJMZqzCHrK0PKWk17F52UvWGU5k=.6512256e-319c-45ac-bc09-ade8e0e98a72@github.com>

On Mon, 30 Sep 2024 16:51:04 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following tests are open-sourced in this PR:
> 
> 1. /java/awt/MouseInfo/ContainerResizeMousePositionTest.java - Automated
> 2. [LINUX ONLY] /java/awt/color/XAWTDifference/XAWTDifference.java - Manual PFJ test

This pull request has now been integrated.

Changeset: bfdeb33e
Author:    Harshitha Onkar <honkar at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/bfdeb33e6f1d4f9f0cc65925ea792be98b1f4d61
Stats:     364 lines in 3 files changed: 364 ins; 0 del; 0 mod

8340332: Open source mixed AWT tests - Set3

Reviewed-by: aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/21271

From aivanov at openjdk.org  Mon Sep 30 20:09:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 30 Sep 2024 20:09:38 GMT
Subject: RFR: 8337287: Update image in javax.swing.text.Document.insert
 [v2]
In-Reply-To: <cTId-fHmBsho77NR9mJ2L3Hg_KxOYaFKFtYSBrdoeDo=.1c6a1185-3d6f-4ee1-b225-c899d2013228@github.com>
References: <uGCW954xUGOPLGAdN1je8b3k9tQHYTfi8vb8-fYRHYk=.737dfade-8b82-4194-a4ab-fcf30bcb7ea1@github.com>
 <cTId-fHmBsho77NR9mJ2L3Hg_KxOYaFKFtYSBrdoeDo=.1c6a1185-3d6f-4ee1-b225-c899d2013228@github.com>
Message-ID: <1TGqxsSHZHNp46r8nTik_pLqIg0KTIougl87l5Gj23k=.49d18ea7-c23c-4332-9007-cbd9f9de586f@github.com>

On Sun, 22 Sep 2024 14:47:14 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> This changeset updates the image in the documentation for the `Document.insert` method. The image in `Document.remove` was updated by [JDK-4622866](https://bugs.openjdk.org/browse/JDK-4622866) in PR #15701.
>> 
>> Now the illustration of inserting looks similar to removing. The new image is in SVG format.
>> 
>> For reference:
>> 
>> - [`Document.insert` in JDK 22](https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet));
>> - [Updated docs for JDK 24](https://cr.openjdk.org/~aivanov/8337287/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet)).
>> 
>> As in the case with `remove`, I marked up to classes and members with {@code}.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Describe inserting ?quick? into text

> > Does it make sense to add a sentence which describes the image? I added one for `remove` to explain all the `Position`s in the removed area are collapsed.
> 
> I missed this question. Yes, sure.

@prrace I updated the PR with an example, look for ?For example, if the document contains the text??.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20376#issuecomment-2384050928

From aivanov at openjdk.org  Mon Sep 30 20:09:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 30 Sep 2024 20:09:39 GMT
Subject: RFR: 8337287: Update image in javax.swing.text.Document.insert
In-Reply-To: <VuiOfLGEHf8qGHHfAdUzSf2UGjER2PZmoTMDY9shoP8=.67f977a7-c99a-4ba8-9972-0ac787b23d1f@github.com>
References: <uGCW954xUGOPLGAdN1je8b3k9tQHYTfi8vb8-fYRHYk=.737dfade-8b82-4194-a4ab-fcf30bcb7ea1@github.com>
 <VuiOfLGEHf8qGHHfAdUzSf2UGjER2PZmoTMDY9shoP8=.67f977a7-c99a-4ba8-9972-0ac787b23d1f@github.com>
Message-ID: <B4ghajlDBKDv8RrXr5PRuBPrucPEjEpAsh08NxYrVLs=.50099b97-9786-4d37-b640-7ca7311704cc@github.com>

On Sat, 24 Aug 2024 00:11:14 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> This changeset updates the image in the documentation for the `Document.insert` method. The image in `Document.remove` was updated by [JDK-4622866](https://bugs.openjdk.org/browse/JDK-4622866) in PR #15701.
>> 
>> Now the illustration of inserting looks similar to removing. The new image is in SVG format.
>> 
>> For reference:
>> 
>> - [`Document.insert` in JDK 22](https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet));
>> - [Updated docs for JDK 24](https://cr.openjdk.org/~aivanov/8337287/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet)).
>> 
>> As in the case with `remove`, I marked up to classes and members with {@code}.
>
> Just curious why the chars are not in the middle of the boxes?

@mrserb Do you have any other questions?

I'll update the position of text in `Document-insert.svg` and ``Document-remove.svg` separately after this PR is integrated.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20376#issuecomment-2384054075

From prr at openjdk.org  Mon Sep 30 21:49:38 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 30 Sep 2024 21:49:38 GMT
Subject: RFR: 8317116: Provide layouts for multiple test UI in
 PassFailJFrame [v4]
In-Reply-To: <XxSOBwAvc5XQCzf-uPGtCCzHtvc2XoIWkTKqvy5tUwo=.5fcac96e-2fbe-4443-b890-eec32a4c818f@github.com>
References: <9minai4Y6OoUTkyplL3RYvd1D07IasQLaiXyj6OWLbo=.8613d393-a538-4510-8ca1-f4e35c9b0b9a@github.com>
 <XxSOBwAvc5XQCzf-uPGtCCzHtvc2XoIWkTKqvy5tUwo=.5fcac96e-2fbe-4443-b890-eec32a4c818f@github.com>
Message-ID: <L9TQp4znVevNUSYb5gMrhyBukY27XQNctVnyTi8Akd4=.8691a8af-6c5e-4daf-a311-0dbe61541a56@github.com>

On Fri, 27 Sep 2024 16:32:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Provides a set of default layouts for manual test using multiple test UI windows.
>> 
>> The initial implementation in the demo in #15721 was too complicated. After looking at the simplified version used in #21180, I re-worked the layouts into separate methods.
>> 
>> The layout methods are in `WindowLayouts` class next to `PassFailJFrame`. It is not necessary to mention it explicitly in the `@build` jtreg tag.
>> 
>> The builder now provides new methods:
>> 
>> - `positionTestUIRightRow` positions the test UI windows in a row to the right of the instruction frame. The top of the windows is aligned to that of the instruction frame.
>> - `positionTestUIRightColumn` positions the test UI windows in a column to the right of the instruction frame. The top of the first window is aligned to that of the instruction frame.
>> - `positionTestUIRightColumnCentered` positions the test UI windows in a column to the right of the instruction frame centering the stack of the windows.
>> - `positionTestUIBottomRow` positions the test UI windows in a row to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
>> - `positionTestUIBottomRowCentered` positions the test UI windows in a row to the bottom of the instruction frame centering the row of the windows.
>> - `positionTestUIBottomColumn` positions the test UI windows in a column to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
>> 
>> If required, the test developer can provide a custom implementation.
>
> Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge master
>  - Remove extra line layoutRow
>  - bottomOneRowCentered: layoutColumn -> layoutRow
>  - Add missing parentheses for vertical positioning
>  - 8317116: Provide layouts for multiple test UI in PassFailJFrame

nice

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21207#pullrequestreview-2338631084

From prr at openjdk.org  Mon Sep 30 21:50:38 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 30 Sep 2024 21:50:38 GMT
Subject: RFR: 8340164: Open source few Component tests - Set1
In-Reply-To: <TBLTIJvSS8mq5BJwwM3B5t_HfRDXXHGGzHAheL2KHgE=.94f2cdb8-8896-45c8-a797-1a5e7ea508c9@github.com>
References: <TBLTIJvSS8mq5BJwwM3B5t_HfRDXXHGGzHAheL2KHgE=.94f2cdb8-8896-45c8-a797-1a5e7ea508c9@github.com>
Message-ID: <Js-4U5yXLnx0pEGRhC11J5a5QFEVAqRJxEo6xbmtlsQ=.53e43402-0971-4a8e-9391-abb2f889b446@github.com>

On Mon, 30 Sep 2024 00:08:25 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Following tests are added as part of this PR:
> 
> /java/awt/LightweightComponent/LightweightFontTest/LightweightFontTest.java (Manual with PassFailJFrame)
> /java/awt/LightweightComponent/LightWeightTabFocus/LightWeightTabFocus.java (Automated)
> /java/awt/LightweightComponent/LWParentMovedTest/LWParentMovedTest.java (Automated)

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21252#pullrequestreview-2338640360

From prr at openjdk.org  Mon Sep 30 21:53:39 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 30 Sep 2024 21:53:39 GMT
Subject: RFR: 8340437: Open source few more AWT Frame related tests [v2]
In-Reply-To: <b20ah0gv5f-lTTRcqKaExLNv_obxPbkH3ZGgSb2vgu8=.4b8527ea-7b86-4960-8be7-e90fba4180ac@github.com>
References: <9QKIqkcpfibamjrGdJsGBFMH7q1YcT23mdhS-opzfRQ=.2edd9fc4-648b-4ef4-8858-19433b35aed0@github.com>
 <b20ah0gv5f-lTTRcqKaExLNv_obxPbkH3ZGgSb2vgu8=.4b8527ea-7b86-4960-8be7-e90fba4180ac@github.com>
Message-ID: <fpce_yhnm1y9hqxY-5cFKOneIFZvozO37Ka9bsGGun8=.882fd906-8385-464c-9345-48759daa795a@github.com>

On Mon, 30 Sep 2024 06:10:21 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> AWT Frame related tests are converted from applet to manual/automated and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add multimonitor jtreg key

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21199#pullrequestreview-2338655243

From prr at openjdk.org  Mon Sep 30 21:53:39 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 30 Sep 2024 21:53:39 GMT
Subject: RFR: 8340354: Open source AWT desktop properties and print related
 tests [v3]
In-Reply-To: <Re19ult1DANyGjFhzqNqshoc16OQER3iYWTx-GmoztQ=.594d4a7d-e9bb-49b9-aa13-1228e99e1938@github.com>
References: <yOfPiZp2v3H8OSK4-Wv2GV2SeZq7x0heUpdXWQyKav0=.7f1df951-2c9d-4e6c-b2b2-3464caeaa711@github.com>
 <Re19ult1DANyGjFhzqNqshoc16OQER3iYWTx-GmoztQ=.594d4a7d-e9bb-49b9-aa13-1228e99e1938@github.com>
Message-ID: <-_5MCd0FVgq05-RjKK5VIVa9__vhbqh8jjgrsdrLqNg=.6b06066f-7561-442b-ad3e-60beb777d989@github.com>

On Mon, 30 Sep 2024 06:12:38 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> AWT Desktop properties and printer related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove extra spaces

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21197#pullrequestreview-2338651015

From prr at openjdk.org  Mon Sep 30 21:55:39 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 30 Sep 2024 21:55:39 GMT
Subject: RFR: 8340432: Open source some MenuBar tests - Set2 [v2]
In-Reply-To: <BgSw46dp8lnPnxwu_e0bI6Qdurz7HMyQNM8uXM_MNMc=.32c2b374-63c2-4f0f-94cb-0e173ebf3283@github.com>
References: <P6braHc3jBKCK6O0fqHKser3QsQ6glIAApAjyFaF1Wo=.cdffdb28-a489-4ebb-9d7d-6a3e4be48768@github.com>
 <BgSw46dp8lnPnxwu_e0bI6Qdurz7HMyQNM8uXM_MNMc=.32c2b374-63c2-4f0f-94cb-0e173ebf3283@github.com>
Message-ID: <FzDqg1-M0OY3hwTe7vRIQw8JrbEJ4Z4cNg-zd659MU4=.02347214-e6fb-4d46-800f-625154bb2a8f@github.com>

On Mon, 30 Sep 2024 16:53:00 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Following tests are added as part of this PR:
>> 
>> /java/awt/MenuBar/MenuBarOnDisabledFrame/MenuBarOnDisabledFrame.java (Manual with PassFailJFrame)
>> /java/awt/MenuBar/MenuBarAddRemoveTest/MenuBarAddRemoveTest.java (Manual with PassFailJFrame)
>> /java/awt/MenuBar/SetHelpMenuTest/SetHelpMenuTest.java (Manual with PassFailJFrame)
>> /java/awt/MenuBar/MenuBarVisuals/MenuBarVisuals.java (Manual with PassFailJFrame)
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21251#pullrequestreview-2338664548

From prr at openjdk.org  Mon Sep 30 21:57:36 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 30 Sep 2024 21:57:36 GMT
Subject: RFR: 8340719: Open source AWT List tests [v2]
In-Reply-To: <YBIE0ZNqVSuV3pF6_86lYgXVVMUHjpbFj_ZgPMxEDQs=.83905853-fd7e-4aae-8b7d-2de536e5726c@github.com>
References: <5wgQPCKvLrE2lr_4uvJ9xAEL108ikcdSjwIJofAlnqg=.68a076ed-26de-44eb-94d9-402a30061906@github.com>
 <YBIE0ZNqVSuV3pF6_86lYgXVVMUHjpbFj_ZgPMxEDQs=.83905853-fd7e-4aae-8b7d-2de536e5726c@github.com>
Message-ID: <wiwK1bGDEchMIFnox_bPBNGAi6jnoXO9O0rRnapHMdI=.ffd239ac-32d4-4c60-9bf2-b1cb75184a7c@github.com>

On Mon, 30 Sep 2024 13:59:12 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Opensource few AWT List tests...
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Formatting

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21253#pullrequestreview-2338674485

From prr at openjdk.org  Mon Sep 30 21:59:38 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 30 Sep 2024 21:59:38 GMT
Subject: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v5]
In-Reply-To: <X-Gpic6v9ND5nGNTf_lZ7t6Xs0fL8zcSytdUlOKcgpI=.53e9383f-b6df-4fd0-8a89-fa53bdab6087@github.com>
References: <umX9iW4V7p88T42WsNNEY-K8DpN_EKj8OiqQBB4S6U4=.9ec78b1d-b65f-44ed-81a4-f86e09ced3fd@github.com>
 <X-Gpic6v9ND5nGNTf_lZ7t6Xs0fL8zcSytdUlOKcgpI=.53e9383f-b6df-4fd0-8a89-fa53bdab6087@github.com>
Message-ID: <u5yhs8C2RgLRuB5BzzlAHGt1aZsXlflBGV7l9jCg3C8=.a8b6f703-4ba5-4ce8-ad20-754d2e322ebd@github.com>

On Thu, 26 Sep 2024 18:28:53 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are updated in this PR:
>> 
>> 1. 	test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java
>> 2. 	test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java
>> 3. 	test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java
>> 4. 	test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed validate()

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21094#pullrequestreview-2338680630

From prr at openjdk.org  Mon Sep 30 22:00:40 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 30 Sep 2024 22:00:40 GMT
Subject: RFR: 8339836: Open source several AWT Mouse tests - Batch 1 [v4]
In-Reply-To: <o7sfAPoVzAhi4Dm7aPCwNqiCGkU9pR7FDXSWFm56LX4=.15b4ebc1-77de-4e19-a4e9-1a4a269c00b8@github.com>
References: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>
 <o7sfAPoVzAhi4Dm7aPCwNqiCGkU9pR7FDXSWFm56LX4=.15b4ebc1-77de-4e19-a4e9-1a4a269c00b8@github.com>
Message-ID: <oej0RSGGMS5w3bf-b3CS5OfsWLhkPUI3dX1fOg_cKAA=.5b3cea87-d4e9-4526-8ae3-67c85add6281@github.com>

On Wed, 25 Sep 2024 10:05:22 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Open source these AWT Mouse tests:
>> 
>> java/awt/Mouse/MouseEnterExitTest.java
>> java/awt/Mouse/MouseEnterExitTest2.java
>> java/awt/Mouse/MousePressedTest.java
>> java/awt/Mouse/MouseEnterExitTest4.java
>> java/awt/Mouse/MouseEnterExitTest3.java
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Converted MouseEnterExitTest4 to automated

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21124#pullrequestreview-2338685486

From prr at openjdk.org  Mon Sep 30 22:02:35 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 30 Sep 2024 22:02:35 GMT
Subject: RFR: 8340907: Open source closed frame tests # 2
In-Reply-To: <sIRypM0KaHiXhJ44ZF4d1TjaWbX7VRirnxgkoJD3iH8=.19ece419-6d3f-4b9a-b7f8-88f9936df1a5@github.com>
References: <sIRypM0KaHiXhJ44ZF4d1TjaWbX7VRirnxgkoJD3iH8=.19ece419-6d3f-4b9a-b7f8-88f9936df1a5@github.com>
Message-ID: <DDpzMwJQEo70_DsT3F_gt8mM-KkZmCdVkxr3pGV9qXM=.6e109c7a-3318-4b02-8e0a-66456dafbac3@github.com>

On Mon, 30 Sep 2024 13:19:20 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Few more tests to open source
> 
> Testing looks good.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21264#pullrequestreview-2338695621

From kizune at openjdk.org  Mon Sep 30 22:12:47 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 30 Sep 2024 22:12:47 GMT
Subject: Integrated: 8340407: Open source a few more Component related tests
In-Reply-To: <rK-dbwVbgJrsiQWOTxrpHB88COtl7MnDEAf20nGGZ_U=.d32ac658-4799-4202-8166-477950ac3e4d@github.com>
References: <rK-dbwVbgJrsiQWOTxrpHB88COtl7MnDEAf20nGGZ_U=.d32ac658-4799-4202-8166-477950ac3e4d@github.com>
Message-ID: <_XlOrSIV88HQ5gzS6gidBDSJzmXJqhK6m7KN4gLNugo=.28ab1883-6bb7-4e64-8eaf-b816dc4cf90e@github.com>

On Fri, 27 Sep 2024 20:29:42 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and open source four tests.

This pull request has now been integrated.

Changeset: a32c3b43
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a32c3b43aaefdebf5be229f90d9cd26db1859b95
Stats:     1395 lines in 4 files changed: 1395 ins; 0 del; 0 mod

8340407: Open source a few more Component related tests

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/21234

From honkar at openjdk.org  Mon Sep 30 22:25:36 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 30 Sep 2024 22:25:36 GMT
Subject: RFR: 8339836: Open source several AWT Mouse tests - Batch 1 [v4]
In-Reply-To: <o7sfAPoVzAhi4Dm7aPCwNqiCGkU9pR7FDXSWFm56LX4=.15b4ebc1-77de-4e19-a4e9-1a4a269c00b8@github.com>
References: <Zr75BbwKZKStlJQ0zRBu3qqNikpUHO8R5N7Fb0ZOGqo=.7317eaf8-1492-4602-acc1-009f92560632@github.com>
 <o7sfAPoVzAhi4Dm7aPCwNqiCGkU9pR7FDXSWFm56LX4=.15b4ebc1-77de-4e19-a4e9-1a4a269c00b8@github.com>
Message-ID: <GaCwrlIqaH1C7nXbb2EcJ0NowC5nKaPQnyxEX4qE6yM=.1513c139-b2e2-4d87-a100-4180489980f4@github.com>

On Wed, 25 Sep 2024 10:05:22 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Open source these AWT Mouse tests:
>> 
>> java/awt/Mouse/MouseEnterExitTest.java
>> java/awt/Mouse/MouseEnterExitTest2.java
>> java/awt/Mouse/MousePressedTest.java
>> java/awt/Mouse/MouseEnterExitTest4.java
>> java/awt/Mouse/MouseEnterExitTest3.java
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Converted MouseEnterExitTest4 to automated

Updated changes to make MouseEnterExitTest4.java automated looks good.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21124#pullrequestreview-2338724141

From kizune at openjdk.org  Mon Sep 30 22:32:20 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 30 Sep 2024 22:32:20 GMT
Subject: RFR: 8340458: Open source additional Component tests (part 2) [v2]
In-Reply-To: <p6xZPdl1d_j37yKhaSHVPcKdmJ10RH7GYhSLAhokZJY=.8388fc41-c9f2-45b1-b251-ac611fcda729@github.com>
References: <amLY1mvQ69kyzvu63buXopJZJKpu8I4kZDPKup-iwmQ=.e797a9b2-738c-4b38-a585-60a2c3f1b250@github.com>
 <p6xZPdl1d_j37yKhaSHVPcKdmJ10RH7GYhSLAhokZJY=.8388fc41-c9f2-45b1-b251-ac611fcda729@github.com>
Message-ID: <eikkqx6Vx4S53tLSCyM7Y3Rf_AG-m7-dzusWU_CZSHk=.a321f409-5b63-4127-8bb0-5b5ccca51090@github.com>

On Mon, 30 Sep 2024 03:32:23 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moved variables initialization into the method that is called on EDT;
>>   Moved dispose call onto EDT so it is called even if test is failed;
>>   Added missing window dispose call;
>
> test/jdk/java/awt/Component/BackgroundColorTest/InitialBackgroundSettingTest.java line 52:
> 
>> 50:     Scrollbar bar = new Scrollbar(Scrollbar.HORIZONTAL);
>> 51:     Button button = new Button("I am the button");
>> 52: 
> 
> I believe all this initialization needs to be put in `setupGUI` under EDT..more so as it is an automated test..

Fixed.

> test/jdk/java/awt/Component/ListDoubleIndentTest/ListDoubleIndentTest.java line 66:
> 
>> 64: 
>> 65:         try {
>> 66:             Frame f = new Frame("ListDoubleIndentTest");
> 
> dispose is missing

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21235#discussion_r1781852988
PR Review Comment: https://git.openjdk.org/jdk/pull/21235#discussion_r1781853061

From kizune at openjdk.org  Mon Sep 30 22:32:19 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 30 Sep 2024 22:32:19 GMT
Subject: RFR: 8340458: Open source additional Component tests (part 2) [v2]
In-Reply-To: <amLY1mvQ69kyzvu63buXopJZJKpu8I4kZDPKup-iwmQ=.e797a9b2-738c-4b38-a585-60a2c3f1b250@github.com>
References: <amLY1mvQ69kyzvu63buXopJZJKpu8I4kZDPKup-iwmQ=.e797a9b2-738c-4b38-a585-60a2c3f1b250@github.com>
Message-ID: <pm7Lc_z5l4rocrKo56gWbXlh1JJ04yJ78O93XwlqFkA=.8ae35b3b-286d-48c5-91a6-e619295af93f@github.com>

> Clean up and open source four more tests.

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Moved variables initialization into the method that is called on EDT;
  Moved dispose call onto EDT so it is called even if test is failed;
  Added missing window dispose call;

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21235/files
  - new: https://git.openjdk.org/jdk/pull/21235/files/e236df12..86b36700

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21235&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21235&range=00-01

  Stats: 26 lines in 2 files changed: 15 ins; 0 del; 11 mod
  Patch: https://git.openjdk.org/jdk/pull/21235.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21235/head:pull/21235

PR: https://git.openjdk.org/jdk/pull/21235

From honkar at openjdk.org  Mon Sep 30 23:14:35 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 30 Sep 2024 23:14:35 GMT
Subject: RFR: 8340907: Open source closed frame tests # 2
In-Reply-To: <sIRypM0KaHiXhJ44ZF4d1TjaWbX7VRirnxgkoJD3iH8=.19ece419-6d3f-4b9a-b7f8-88f9936df1a5@github.com>
References: <sIRypM0KaHiXhJ44ZF4d1TjaWbX7VRirnxgkoJD3iH8=.19ece419-6d3f-4b9a-b7f8-88f9936df1a5@github.com>
Message-ID: <oG1VykjGbQkxJeja5cGf5OzlYhm7xXQogU0B2-TQlPI=.a72ec5b3-1081-40e9-8617-04c52145ba87@github.com>

On Mon, 30 Sep 2024 13:19:20 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Few more tests to open source
> 
> Testing looks good.

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21264#pullrequestreview-2338777426

From honkar at openjdk.org  Mon Sep 30 23:35:34 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 30 Sep 2024 23:35:34 GMT
Subject: RFR: 8340907: Open source closed frame tests # 2
In-Reply-To: <sIRypM0KaHiXhJ44ZF4d1TjaWbX7VRirnxgkoJD3iH8=.19ece419-6d3f-4b9a-b7f8-88f9936df1a5@github.com>
References: <sIRypM0KaHiXhJ44ZF4d1TjaWbX7VRirnxgkoJD3iH8=.19ece419-6d3f-4b9a-b7f8-88f9936df1a5@github.com>
Message-ID: <DCo_83zhLauDGYKeCfjTZHBnO27XI6JGS-2rgoELp7Q=.5b6b7e6f-e102-4d4d-8de4-86af65560d11@github.com>

On Mon, 30 Sep 2024 13:19:20 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Few more tests to open source
> 
> Testing looks good.

test/jdk/java/awt/Frame/DeiconifyClipTest.java line 41:

> 39: 
> 40: import javax.swing.BoxLayout;
> 41: import javax.swing.JFrame;

@azvegint Since it is an AWT test should we be using Frame instead of JFrame ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21264#discussion_r1781922858