RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java test failed on linux machine

[Tejesh R]

On Wed, 28 Aug 2024 04:24:56 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rather than left top.
>> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.
>
> @TejeshR13 Did you check the current changes on CI system? Did you observe any failure on the particular machine where it failed in CI?

> As @kumarabhi006 and @alisenchung pointed out I think there might be cases of false positives with high tolerance values.
> 
> Following are couple of suggestions:
> 
> * Check if a lower more optimal value of tolerance works.
> * Continue pixel compare till you encounter 4-5 pixels of the expected color (with tolerance)
> * Adding debug logs to see which colors pass the criteria.

Checking for optimal value based on collected color samples as others mentioned might not be of much use here. But as u mentioned here we can merge both the technique along with tolerance to do that. 
How debug logs would help in analysis?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20723#issuecomment-2323818865