RFR: 8051591: Test javax/swing/JTabbedPane/8007563/Test8007563.java fails [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Tue Sep 3 08:44:22 UTC 2024
On Tue, 3 Sep 2024 05:50:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
>> Test removed from `Problem-list` file as well.
>>
>> CI testing link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove secondaryloop code
I am not sure why secondary loop was added in the testcase for JDK-8078269..
JDK-8078269 issue was `TabbedPane.tabAreaBackground` should have precedence over `setBackground` but it was not working after JDK-8007563..
The 8007563 tests for non-opaque case whereas 8078269 issue was for opaque.
It seems if we put `UIManager.put("TabbedPane.tabAreaBackground", Color.GREEN); ` then the tabbedpane areas where there are no tabs are not GREEN but RED...
Seems like we need a new testcase for JDK-8078269 and do away with secondary loop in 8007563 testcase..
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2325936371
More information about the client-libs-dev
mailing list