RFR: 8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize [v2]

[Harshitha Onkar]

On Sat, 31 Aug 2024 09:08:59 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
>> 
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
>> 
>> Fix:
>> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review Comments Fixed : Further stabilized the test by increasing the delay as well as removing some unwanted lines of code

frame.setExtendedState(JFrame.MAXIMIZED_BOTH);
                System.out.println("Frame is maximized");
                robot.waitForIdle();

You missed adding delays after frame state changes, in the above case after  robot.waitForIdle() adding robot.delay(100) can stabilize the test. This applies to all the places where frame.setExtendedState() is used.

-------------

Changes requested by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20777#pullrequestreview-2277965584