RFR: 8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize [v4]

Harshitha Onkar honkar at openjdk.org
Tue Sep 3 18:17:33 UTC 2024


On Tue, 3 Sep 2024 18:14:44 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
>> 
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
>> 
>> Fix:
>> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments fixed : Added some more delays

LGTM now. 
Does CI testing look good with the updated changes? Since this is an intermittent test failure it is good to check if the added delays are working as expected.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20777#pullrequestreview-2278139908


More information about the client-libs-dev mailing list