RFR: 8051591: Test javax/swing/JTabbedPane/8007563/Test8007563.java fails [v2]
Damon Nguyen
dnguyen at openjdk.org
Wed Sep 4 01:13:25 UTC 2024
On Tue, 3 Sep 2024 05:50:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
>> Test removed from `Problem-list` file as well.
>>
>> CI testing link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove secondaryloop code
I tested this myself and it does seem to be stable and pass consistently. Looks like the extra delay works.
Following the logic regarding the precedence of the different sources of background color, it does seem like Prasanta is correct when glancing over the different sources of colors.
Worth noting, I think it'd be good to rename the test since we're removing it from the problemlist and moving the test to a new location anyway. Maybe rename it to `JTabbedPaneBackgroundColorTest` or something similar to be more descriptive.
-------------
Changes requested by dnguyen (Committer).
PR Review: https://git.openjdk.org/jdk/pull/20791#pullrequestreview-2278752187
More information about the client-libs-dev
mailing list