RFR: 8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize [v4]

Tejesh R tr at openjdk.org
Wed Sep 4 07:00:19 UTC 2024


On Tue, 3 Sep 2024 18:17:33 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
>> 
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
>> 
>> Fix:
>> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments fixed : Added some more delays

test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java line 213:

> 211: 
> 212:     private void disposeFrame() {
> 213:         frame.dispose();

null check might be required here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20777#discussion_r1743175302


More information about the client-libs-dev mailing list