RFR: 8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize [v5]

Harshitha Onkar honkar at openjdk.org
Wed Sep 4 20:05:20 UTC 2024


On Wed, 4 Sep 2024 17:30:59 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
>> 
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
>> 
>> Fix:
>> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added null check to frame before disposing

LGTM

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20777#pullrequestreview-2281129608


More information about the client-libs-dev mailing list