RFR: 8051591: Test javax/swing/JTabbedPane/8007563/Test8007563.java fails [v3]

[Harshitha Onkar]

On Wed, 4 Sep 2024 04:21:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Test was failing on multiple platforms mainly windows and linux and was problemlisted for all platforms. Increased the delay from 200ms to 500 ms to fetch the correct background color using robot. Now test passed for multiple iteration (~50 times) in CI pipeline for all platforms. Wild imports are expanded and test is pulled out of an extra level of folder.
>> Test removed from `Problem-list` file as well.
>> 
>> CI testing link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test name renamed

LGTM other than the minor test changes mentioned below.

test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneBackgroundColor.java line 45:

> 43: 
> 44: public class TestJTabbedPaneBackgroundColor {
> 45:     private static final ArrayList<String> LIST = new ArrayList<>();

I think it can be changed to a non-final static var

Suggestion:

    private static ArrayList<String> lafList = new ArrayList<>();

test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneBackgroundColor.java line 54:

> 52:     public static void main(String[] args) throws Exception {
> 53:         robot = new Robot();
> 54:         robot.setAutoDelay(200);

This can be removed as there no Robot mouse or key events.
 `robot.setAutoDelay(200);`

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20791#pullrequestreview-2284347635
PR Review Comment: https://git.openjdk.org/jdk/pull/20791#discussion_r1746331625
PR Review Comment: https://git.openjdk.org/jdk/pull/20791#discussion_r1746333137