RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java test failed on linux machine [v6]

[Abhishek Kumar]

On Fri, 6 Sep 2024 05:37:09 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rather than left top.
>> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated with review comments

test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 50:

> 48:     private static Checkbox checkbox;
> 49:     private static volatile Point point;
> 50:     private static volatile boolean checkmarkFound = false;

`checkmarkFound` need not to be `volatile`. Although declaring it as volatile won't add any overhead but it will prevent optimization. For this test, it won't have much impact though.

test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 61:

> 59:         try {
> 60:             EventQueue.invokeAndWait(() -> {
> 61:                 frame = new Frame("ComboBox checker scaling test");

I just noticed the title contains `ComboBox checker`. Should it be `CheckBox checker` ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20723#discussion_r1746545404
PR Review Comment: https://git.openjdk.org/jdk/pull/20723#discussion_r1746543021